Commit graph

14916 commits

Author SHA1 Message Date
Michael Schuster
f321cd8ae6
Windows: Add Win32 stand-alone migration tool NCNavRemove
Removes all Explorer Navigation Pane entries for a given ApplicationName, specified in NavRemove.ini in the working directory.

Also compiles a DLL with the same behaviour that exports:
- RemoveNavigationPaneEntries

Both tool variants are Mutex-protected.

Statically linked, optimized for binary size, no Qt dependencies.

Signed-off-by: Michael Schuster <michael@schuster.ms>
2020-09-21 16:40:19 +02:00
Michael Schuster
68776fe319
Windows MSI: Add helper DLL and shared migration tools code
The helper DLL will be utilized by Windows Installer with Custom Actions defined in the NCMsiHelper.wxs WiX fragment.

Exports:
- ExecNsisUninstaller
- RemoveNavigationPaneEntries

Signed-off-by: Michael Schuster <michael@schuster.ms>
2020-09-21 16:40:19 +02:00
Michael Schuster
fc365df5de
Windows MSI: Let CMake install Shell Extensions WiX fragment to "msi/"
Signed-off-by: Michael Schuster <michael@schuster.ms>
2020-09-21 16:40:19 +02:00
Michael Schuster
fad9b2c969
Windows MSI: Add Upgrade Code and migration tool build options to NEXTCLOUD.cmake
The Upgrade Code is a GUID (specified without brackets) for the MSI package to allow Windows Installer identify existing installations.

New build options (default: OFF):
- BUILD_WIN_MSI: Build all MSI scripts and a required helper DLL (to uninstall NSIS legacy installations and remove Explorer Navigation Pane entries)
- BUILD_WIN_TOOLS: Build additional migration tools (currently NCNavRemove, a stand-alone tool for Explorer entries removal)

The helper DLL and migration tools are set to be statically linked and optimized for binary size.

Signed-off-by: Michael Schuster <michael@schuster.ms>
2020-09-21 16:40:19 +02:00
Kevin Ottens
58b88de936
Merge pull request #2431 from jplsek/remove-this-includes
Remove "This includes" due to tooltip order
2020-09-21 15:40:37 +02:00
Jeremy Plsek
3a53afd704 Remove "This includes" due to tooltip order
Signed-off-by: Jeremy Plsek <jeremyplsek@gmail.com>
2020-09-21 09:46:25 +00:00
Nextcloud bot
c127052f2d
[tx-robot] updated from transifex 2020-09-21 03:32:07 +00:00
Nextcloud bot
ed972a0e3f
[tx-robot] updated from transifex 2020-09-20 03:31:45 +00:00
Nextcloud bot
5d7e1b6a69
[tx-robot] updated from transifex 2020-09-19 03:34:11 +00:00
Michael Schuster
0f2784107c
Merge pull request #2437 from nextcloud/remove_no_description_available_messages_in_activity_list
If there's no description just say nothing
2020-09-18 20:41:34 +02:00
Kevin Ottens
3171cb2720 If there's no description just say nothing
Otherwise we get lots of "No description available" lines in the
activity list which is basically noise. Also trains the user to ignore
the secondary line.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-18 17:46:38 +00:00
Michael Schuster
f451e1d2d5
Merge pull request #2445 from nextcloud/fix-mac-catalina-login
Entitlement to sign the QtWebEngineProcess with an exception.
2020-09-18 06:44:11 +02:00
Camila San
9c5a51bb07 Entitlement to sign the QtWebEngineProcess with an exception.
Fix for #1793: The problem seems to be related enabling hardened runtime.
This exception allows the webview to load.

Signed-off-by: Camila San <hello@camila.codes>
2020-09-18 04:35:06 +00:00
Nextcloud bot
091c805f9e
[tx-robot] updated from transifex 2020-09-18 03:30:59 +00:00
Dominique Fuchs
54364e7374
Merge pull request #2439 from nextcloud/fix-subfolder-missing-contentsync
Fix missing subdirectory discovery on move operations in macOS
2020-09-17 16:04:12 +02:00
Dominique Fuchs
f8f3190cb4 Fix missing subdirectory discovery on move operations in macOS.
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>

Add qAsConst to avoid detaching

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>

Changed callchain to find and return possibly coalesced paths

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>

Removed another qAsConst remnant, more func const-correctness.

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
2020-09-17 15:44:32 +02:00
Nextcloud bot
ed3eb1ac9c
[tx-robot] updated from transifex 2020-09-17 04:13:19 +00:00
Kevin Ottens
61a74e67c9
Merge pull request #2435 from nextcloud/fix-journal-upgrade-multiple-syncconnections
Fix incomplete journal upgrade from 2.x to 3.x
2020-09-16 13:21:42 +02:00
Dominique Fuchs
d09b0284dd
Do not break out of outer loop when upgrading folders, continue instead
Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>

Remove awkward debug line a.k.a. whoops

Signed-off-by: Dominique Fuchs <32204802+DominiqueFuchs@users.noreply.github.com>
2020-09-16 10:57:43 +02:00
Kevin Ottens
5eba2e9163
Merge pull request #2432 from nextcloud/fix/nsis-language-encoding
Windows: Fix NSIS language encoding (use UTF-8)
2020-09-16 09:13:26 +02:00
Michael Schuster
0e1e3a29ce Windows: Remove unused and outdated NSIS Transifex settings
The last translation update from Transifex was done in 2017, so the scripts and settings were never used for Nextcloud.

This commit removes the unused scripts and "Auto-generated" comments in the translation files.

Some files have been modified over time either way and MSI will replace NSIS soon.

Signed-off-by: Michael Schuster <michael@schuster.ms>
2020-09-16 05:41:27 +00:00
Michael Schuster
7f5b7f637c Windows: Fix NSIS language encoding (use UTF-8 instead of Win code pages)
The old conversion to specific code pages caused display errors (see issue #2393 for Russian).

Based on bin/l10n.sh, the files in this commit were converted to UTF-8 using iconv with the following parameters:

  iconv -f CP1252 -t UTF-8 -o German.nsh German.nsh
  iconv -f CP1252 -t UTF-8 -o Galician.nsh Galician.nsh
  iconv -f CP1253 -t UTF-8 -o Greek.nsh Greek.nsh
  iconv -f CP1250 -t UTF-8 -o Slovenian.nsh Slovenian.nsh
  iconv -f CP1257 -t UTF-8 -o Estonian.nsh Estonian.nsh
  iconv -f CP1252 -t UTF-8 -o Italian.nsh Italian.nsh
  iconv -f CP1252 -t UTF-8 -o PortugueseBR.nsh PortugueseBR.nsh
  iconv -f CP1252 -t UTF-8 -o Spanish.nsh Spanish.nsh
  iconv -f CP1252 -t UTF-8 -o Dutch.nsh Dutch.nsh
  iconv -f CP1252 -t UTF-8 -o Finnish.nsh Finnish.nsh
  iconv -f CP932 -t UTF-8 -o Japanese.nsh Japanese.nsh
  iconv -f CP1250 -t UTF-8 -o Slovak.nsh Slovak.nsh
  iconv -f CP1254 -t UTF-8 -o Turkish.nsh Turkish.nsh
  iconv -f CP1252 -t UTF-8 -o Norwegian.nsh Norwegian.nsh
  iconv -f CP852  -t UTF-8 -o Czech.nsh Czech.nsh

The installer script nextcloud.nsi in the client-building repo needs the following line (to be added on top):
  Unicode true

Signed-off-by: Michael Schuster <michael@schuster.ms>
2020-09-16 05:41:27 +00:00
Nextcloud bot
dbe8422c5d
[tx-robot] updated from transifex 2020-09-16 03:27:56 +00:00
Kevin Ottens
9d05bc0a8b
Merge pull request #2424 from nextcloud/enable_ci_for_stable_branches
Try to enable the CI on stable branches as well
2020-09-15 15:24:58 +02:00
Kevin Ottens
f3c2632f8c Try to enable the CI on stable branches as well
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-15 12:46:36 +00:00
Kevin Ottens
16dda17334
Merge pull request #2423 from nextcloud/disable_bugprone_forward_declaration_namespace_clang_tidy_check
Disable bugprone-forward-declaration-namespace check
2020-09-15 14:45:29 +02:00
Kevin Ottens
63c3580755 Disable bugprone-forward-declaration-namespace check
Turns out this clang-tidy check can give false positives coming from
headers outside the project while it shouldn't.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-15 12:04:32 +00:00
Kevin Ottens
8aaa533a3e
Merge pull request #2412 from jplsek/tooltip-update
Include list info in tooltip
2020-09-15 13:50:39 +02:00
Jeremy Plsek
797df2b5d5 Include list info in tooltip
Also extend the tooltip timeout

Signed-off-by: Jeremy Plsek <jeremyplsek@gmail.com>
2020-09-15 10:04:06 +00:00
Kevin Ottens
14993d4de6
Merge pull request #2417 from nextcloud/fix_menu_popup_in_main_dialog
Fix menu popup in main dialog
2020-09-15 11:03:07 +02:00
Kevin Ottens
6ee37b5975 Make sure menu are closed when button is clicked again
This way we also made sure all the Menu are currently on the same close
policy.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-15 08:46:10 +00:00
Kevin Ottens
f7efe6a902 Delay binding on the menu width
Indee the MenuItem might not be linked to its Menu at creation time
which will make the binding fail and give a warning. Delay for the menu
availability.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-15 08:46:10 +00:00
Kevin Ottens
eb0cedebfa Remove pre-QQC2.3 workaround
Now that we depend on Qt 5.12 anyway, the count property is available
just fine on the Menu item.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-15 08:46:09 +00:00
Kevin Ottens
4f5d707e44
Merge pull request #2418 from nextcloud/use_primary_screen_as_fallback_when_qcursor_pos_search_failed
Use QGuiApplication::primaryScreen() as fallback for Systray::currentScreen()
2020-09-15 10:44:54 +02:00
Kevin Ottens
7ccb016397 Use QGuiApplication::primaryScreen() as fallback for Systray::currentScreen()
Under Wayland QCursor::pos() is unlikely to give us anything meaningful,
so fallback to the primary screen information.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-15 07:17:03 +00:00
Nextcloud bot
54b09a1fbb
[tx-robot] updated from transifex 2020-09-15 03:22:14 +00:00
Nextcloud bot
9d3a905cc5
[tx-robot] updated from transifex 2020-09-12 03:19:44 +00:00
Nextcloud bot
88a573a643
[tx-robot] updated from transifex 2020-09-11 03:20:37 +00:00
Kevin Ottens
01986df8ca Don't use a confusing "royal you" in the sync messages
Users get rightfully confused with the "You changed ..." messages in the
activity list for syncs. Indeed, some of those changes might be coming
from the server in which case we don't really know who did the change.

So now we use the old "Synced ..." messages for changes pulled from the
server and we have a more precise "You changed ..." (renamed, deleted,
created) when the changes were initiated locally (since there we know
the user reading the message did it).

Also changed how the messages are constructed so that they can be
properly translated.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-10 15:40:05 +02:00
Nextcloud bot
9ab256b4b4
[tx-robot] updated from transifex 2020-09-10 03:25:52 +00:00
Camila
95f634ce28 Click on activity list in systray open file in the file manager.
Clean up code, add more const and auto.

Signed-off-by: Camila <hello@camila.codes>
2020-09-09 20:06:46 +02:00
Camila
c1086c9886 Fix tooltip for activity info.
Also improves readability of the items in the list.

Signed-off-by: Camila <hello@camila.codes>
2020-09-09 20:06:46 +02:00
Valdnet
a432501d80 l10n: Add a period 2020-09-09 10:07:10 +02:00
Nextcloud bot
301a926f4d
[tx-robot] updated from transifex 2020-09-09 03:19:56 +00:00
Valdnet
9822079cae l10n: Extract the button name 2020-09-08 16:44:51 +02:00
Valdnet
528fa92e86 l10n: Delete unnecessary sentence 2020-09-08 16:44:51 +02:00
Valdnet
1444500f77 l10n: A few more fixes 2020-09-08 16:44:51 +02:00
Valdnet
e2737b5067 l10n: Word correction 2020-09-08 16:44:51 +02:00
Valdnet
f931bc832c l10n: Corrected translation 2020-09-08 16:44:51 +02:00
Kevin Ottens
fdb35e5f9f Leave the implicit uint to int cast
I wrongly (and stupidly) assumed the int in QBitArray was treated as a
hash as well but it is an index so it must be positive. Also to make
things even worse I misread on which expression clang-tidy was
complaining regarding the implementation specific narrowing
conversion... This is happening after the modulo operator and not
before. We're in a safe range of values at that point, so it's fine to
let the narrowing happen.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-08 16:44:31 +02:00