mirrors/nextcloud-desktop
1
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2024-11-26 06:55:59 +03:00
Code Issues Projects Releases Packages Wiki Activity

Leave the implicit uint to int cast

Browse source 
I wrongly (and stupidly) assumed the int in QBitArray was treated as a
hash as well but it is an index so it must be positive. Also to make
things even worse I misread on which expression clang-tidy was
complaining regarding the implementation specific narrowing
conversion... This is happening after the modulo operator and not
before. We're in a safe range of values at that point, so it's fine to
let the narrowing happen.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
This commit is contained in:
Kevin Ottens 2020-09-03 17:02:08 +02:00 committed by Kevin Ottens
parent de3ba2721b
commit fdb35e5f9f
1 changed files with 4 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
src/gui/socketapi.cpp
View file

@ -105,25 +105,16 @@ public:
void storeHash(uint hash)
{
int bits = bit_cast(hash);
hashBits.setBit((bits & 0xFFFF) % NumBits);
hashBits.setBit((bits >> 16) % NumBits);
hashBits.setBit((hash & 0xFFFF) % NumBits); // NOLINT it's uint all the way and the modulo puts us back in the 0..1023 range
hashBits.setBit((hash >> 16) % NumBits); // NOLINT
}
bool isHashMaybeStored(uint hash) const
{
int bits = bit_cast(hash);
return hashBits.testBit((bits & 0xFFFF) % NumBits)
&& hashBits.testBit((bits >> 16) % NumBits);
return hashBits.testBit((hash & 0xFFFF) % NumBits) // NOLINT
&& hashBits.testBit((hash >> 16) % NumBits); // NOLINT
}
private:
static int bit_cast(uint input)
{
int output = 0;
std::memcpy(&output, &input, sizeof(int));
return output;
}
QBitArray hashBits;
};