Claudio Cambra
|
bbfe9ca411
|
Merge pull request #5027 from nextcloud/bugfix/modernise-accountsettings-code
Modernise and improve code in AccountSettings
|
2022-10-29 14:37:29 +02:00 |
|
Claudio Cambra
|
ff3eab1275
|
Modernise QString-related construction
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2022-10-29 14:03:58 +02:00 |
|
Claudio Cambra
|
b4be56c267
|
Add braces to all if statements missing them
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2022-10-29 14:03:58 +02:00 |
|
Claudio Cambra
|
7d05d8471b
|
Expand use of const and auto, improve readability of accountsettings
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
|
2022-10-29 14:03:58 +02:00 |
|
Claudio Cambra
|
7ac4898840
|
Merge pull request #5107 from nextcloud/bugfix/refactor-folderman-edit-locally
Refactor FolderMan's "Edit Locally" capabilities as separate class
|
2022-10-29 14:02:04 +02:00 |
|
Claudio Cambra
|
72e154def1
|
Rename EditLocallyHandler to EditLocallyJob
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2022-10-29 13:32:48 +02:00 |
|
Claudio Cambra
|
ee8b12009a
|
Ensure the checkTokenJob object gets deallocated
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2022-10-29 13:32:48 +02:00 |
|
Claudio Cambra
|
ae12519dd5
|
Show edit locally loading dialog sooner, improve feedback for user
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2022-10-29 13:32:48 +02:00 |
|
Claudio Cambra
|
9f7a699ad9
|
Refactor edit locally handler management away from application and into own class
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2022-10-29 13:32:48 +02:00 |
|
Claudio Cambra
|
4b6fdcc550
|
Don't show the user any potenitally questionable remote data
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2022-10-29 13:32:48 +02:00 |
|
Claudio Cambra
|
9438d3f1c7
|
Verify token before checking disk or modifying state
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2022-10-29 13:32:48 +02:00 |
|
Claudio Cambra
|
9a00aa6e66
|
Refactor edit locally into its own class, rather than bolting onto FolderMan
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2022-10-29 13:32:48 +02:00 |
|
Claudio Cambra
|
224621bb85
|
Refactor large editFileLocally FolderMan method into smaller, clearer separate methods
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2022-10-29 13:32:48 +02:00 |
|
Nextcloud bot
|
3449dba0a8
|
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
|
2022-10-29 03:31:52 +00:00 |
|
Claudio Cambra
|
b6deeecfda
|
Merge pull request #5093 from nextcloud/work/validate-edit-locally-token
Validate and sanitise edit locally token and relpath before sending to server
|
2022-10-28 13:11:01 +02:00 |
|
Claudio Cambra
|
734c986cd1
|
Use addQueryParams for checkTokenForEditLocally SimpleApiJob
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2022-10-28 12:38:46 +02:00 |
|
Claudio Cambra
|
0b33ce2b40
|
Make sure to check relPath and compare to canonical cleaned path
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2022-10-28 12:38:18 +02:00 |
|
Claudio Cambra
|
0c6127de44
|
Make sure to encode the relPath
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2022-10-28 12:38:14 +02:00 |
|
Claudio Cambra
|
8683ee08e7
|
Validate edit locally token before sending to server
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2022-10-28 12:37:26 +02:00 |
|
Nextcloud bot
|
8c37bf2711
|
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
|
2022-10-28 03:20:17 +00:00 |
|
Claudio Cambra
|
47009fc7ff
|
Merge pull request #5102 from nextcloud/bugfix/fix-mac-autoupdater-settings
Fix macOS autoupdater settings
|
2022-10-27 15:56:46 +02:00 |
|
Claudio Cambra
|
16532375da
|
Fix macOS autoupdater settings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2022-10-27 14:30:33 +02:00 |
|
Nextcloud bot
|
0f0fd68a99
|
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
|
2022-10-27 03:19:41 +00:00 |
|
Claudio Cambra
|
2abbe5c251
|
Merge pull request #5026 from nextcloud/bugfix/modernise-account-code
Modernise and improve code in AccountManager
|
2022-10-26 19:11:33 +02:00 |
|
Claudio Cambra
|
a537df296b
|
Constexpr settings constant strings, expand use of const and auto, modernise, in accountsmanager
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
|
2022-10-26 13:28:24 +02:00 |
|
Nextcloud bot
|
620f64e9a2
|
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
|
2022-10-26 03:21:16 +00:00 |
|
Claudio Cambra
|
95898fda4e
|
Merge pull request #5018 from nextcloud/feature/force-sync-tray-button
Add a 'Sync now' button to the sync status header in the tray window
|
2022-10-25 21:33:08 +02:00 |
|
Claudio Cambra
|
c0baf5c93c
|
Add a 'Sync now' button to the sync status header in the tray window
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2022-10-25 19:14:40 +02:00 |
|
Claudio Cambra
|
94b45d6d68
|
Add forcefoldersync method to folder manager
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2022-10-25 19:14:40 +02:00 |
|
Claudio Cambra
|
1a6326ed97
|
Create commonly accessible properties for current user colours in Style.qml
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2022-10-25 19:14:40 +02:00 |
|
Claudio Cambra
|
ea53398bd7
|
Merge pull request #5070 from nextcloud/work/simplify-cleanuppollsjob-constructor
Remove unneeded parameter from CleanupPollsJob constructor
|
2022-10-25 19:14:25 +02:00 |
|
Claudio Cambra
|
48359408ea
|
Remove unneeded parameter from CleanupPollsJob constructor
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2022-10-25 16:00:03 +02:00 |
|
Claudio Cambra
|
9f27758c28
|
Merge pull request #5042 from nextcloud/bugfix/systray-slots
Make Systray's void methods slots
|
2022-10-25 15:57:47 +02:00 |
|
Claudio Cambra
|
57f8de9fb6
|
Make Systray's void methods slots
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
|
2022-10-25 12:19:17 +02:00 |
|
Claudio Cambra
|
25b556f3a9
|
Merge pull request #5071 from nextcloud/work/sync-engine-method-cleanup
Clean up methods in sync engine
|
2022-10-25 12:18:58 +02:00 |
|
Claudio Cambra
|
421f5e723a
|
Clean up methods in sync engine
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
|
2022-10-25 11:05:46 +02:00 |
|
Matthieu Gallien
|
02ce08bcdb
|
Merge pull request #5086 from nextcloud/NeroBurner-patch-1
Update CMake usage in README build instructions
|
2022-10-25 11:04:20 +02:00 |
|
NeroBurner
|
69692922cf
|
Update CMake usage in README build instructions
CMake 3.14.0 released in March 2019 [1] added the command line config options
`-S <source-dir>` and `-B <build-dir>` and the build argument `--build <build-dir>` [2].
These options are universally valid independent of the build system used (`make`,
`nmake`, `ninja`, `MSBuild`,...), making the provided CMake commands more generic.
As reference Ubuntu 20.04 ships the CMake 3.16.3 [3] version.
- [1] https://gitlab.kitware.com/cmake/cmake/-/tags/v3.14.0
- [2] https://cmake.org/cmake/help/v3.14/release/3.14.html#command-line
- [3] https://packages.ubuntu.com/focal/cmake
Signed-off-by: NeroBurner <pyro4hell@gmail.com>
|
2022-10-25 09:50:14 +02:00 |
|
Nextcloud bot
|
6db336128c
|
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
|
2022-10-25 03:24:49 +00:00 |
|
Matthieu Gallien
|
4b2f103dd2
|
Merge pull request #5087 from nextcloud/bugfix/syncFolderStatusIcon
emit missing signal to update folder sync status icon
|
2022-10-24 18:36:17 +02:00 |
|
Matthieu Gallien
|
81f33ef94c
|
emit missing signal to update folder sync status icon
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
|
2022-10-24 16:53:06 +02:00 |
|
Matthieu Gallien
|
f1c3ceeee5
|
Merge pull request #4949 from nextcloud/bugfix/checkCertAgainstPrivateKey
validate certificate for E2EE against private key
|
2022-10-24 15:39:00 +02:00 |
|
Matthieu Gallien
|
b9d4e7045e
|
fix review comments from @allexzander
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
|
2022-10-24 10:25:41 +02:00 |
|
Matthieu Gallien
|
7ffbd95636
|
fix more sonarcloud issues
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
|
2022-10-24 10:25:41 +02:00 |
|
Matthieu Gallien
|
5e81ab821e
|
fix more issues reported by sonarcloud
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
|
2022-10-24 10:25:41 +02:00 |
|
Matthieu Gallien
|
b19b69df02
|
remove useless lines: fix review comment
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
|
2022-10-24 10:25:41 +02:00 |
|
Matthieu Gallien
|
cd30d3645e
|
fix review comments from sonarcloud static analyzis
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
|
2022-10-24 10:25:41 +02:00 |
|
Matthieu Gallien
|
8ea75f4967
|
address review comments from @allexzander
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
|
2022-10-24 10:25:41 +02:00 |
|
Matthieu Gallien
|
1ec7774e2f
|
validate certificate for E2EE against private key
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
|
2022-10-24 10:25:41 +02:00 |
|
Nextcloud bot
|
eb92426cc2
|
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
|
2022-10-24 03:20:08 +00:00 |
|