Commit graph

16997 commits

Author SHA1 Message Date
Matthieu Gallien
127b8c0b2d
Merge pull request #3746 from nextcloud/bugfix/doNotCrashPushNotifications
prevent infinte recursion when closing a websocket in case of SSL errors
2021-09-07 09:33:09 +02:00
Matthieu Gallien
95e3ecfd3c prevent infinte recursion when closing a websocket in case of SSL errors
the slots connected to the web socket can be called even during close
and lead to infinite calls to close -> error slot -> close -> ...

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-09-07 07:09:43 +00:00
Matthieu Gallien
46f7d07889
Merge pull request #3753 from nextcloud/bugfix/close-wizard-after-done
Close wizard if done
2021-09-07 09:08:09 +02:00
Felix Weilbach
6fd0adda52 Close wizard if done
This is needed because of the changes in 02bb5db544

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-07 06:43:27 +00:00
Nextcloud bot
68a433d9bc
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-07 03:56:34 +00:00
allexzander
17044317ba
Merge pull request #3754 from nextcloud/bugfix/remove-assert
Remove assert that causes crashes
2021-09-06 18:54:58 +03:00
Felix Weilbach
031b2e0683 Remove assert that caues crashes
This assert does not add value. Utility::concatUrlPath() takes care of
appending paths correctly.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-06 15:54:44 +00:00
allexzander
8385eeeab2
Merge pull request #3688 from nextcloud/feature/share-via-talk
Sharing to Talk/Email
2021-09-06 18:53:31 +03:00
alex-z
24ad43a208 Enable Xvfb for graphical tests on Linux.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2021-09-06 13:27:39 +00:00
allexzander
a3fc812539 Enable share to Talk and Email. Display correct icon. Added unit tests.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-09-06 13:27:39 +00:00
allexzander
3f6defe594
Merge pull request #3750 from nextcloud/remove-autoupdate-section-macos
macOS client is not able to do auto updates
2021-09-06 16:26:27 +03:00
Felix Weilbach
41ecb2c160 macOS client is not able to do auto updates
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-06 11:39:08 +02:00
Nextcloud bot
e5517c343d
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-06 03:55:31 +00:00
Nextcloud bot
e56e9acf79
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-05 03:55:00 +00:00
Nextcloud bot
0b14c340f2
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-04 03:53:11 +00:00
Felix Weilbach
1274959434
Merge pull request #3689 from nextcloud/bugfix/removeObsoleteWizardPage
Remove wizard page that has been dead for 4 years
2021-09-03 20:26:26 +02:00
Hannah von Reth
02bb5db544 Remove wizard page that has been dead for 4 years 2021-09-03 16:08:37 +02:00
Felix Weilbach
f396c58b5f
Merge pull request #3701 from nextcloud/bugfix/fix-qml-warnings
Fix qml warnings
2021-09-03 14:03:27 +02:00
Felix Weilbach
fa37f5c2bc Don't create binding loop
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-03 11:48:42 +00:00
Felix Weilbach
8a2097e7b9 Implicitly defined onFoo properties in Connections are deprecated
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-03 11:48:42 +00:00
Matthieu Gallien
c07aec320a
Merge pull request #3727 from nextcloud/bugfix/only-set-dav-user-after-login
Only set dav user after login
2021-09-03 11:23:37 +02:00
Felix Weilbach
ba2d8e8201 Only set dav user after login.
Setting the credentials of the account inside the auth widget is not a
good idea as that will destroy the previous credentials object which
may wait for a signal to be emitted by the credentials dialog that
was created by the credentials that are going to be deleted. Uff.

It should be enough to set the dav user only after login because the
dav user will never change.

See also the discussion here
https://github.com/nextcloud/desktop/issues/3677#issuecomment-907976839

Fixes #3677

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-03 08:32:15 +00:00
Nextcloud bot
9e6e4095a8
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-03 03:56:30 +00:00
Nextcloud bot
d8618d2447
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-02 03:53:42 +00:00
Felix Weilbach
19ee6560a9
Merge pull request #3729 from nextcloud/cmakecleanup
CMake cleanup
2021-09-01 15:16:21 +02:00
Nicolas Fella
bc3eb7845d Remove unneeded target_link_libraries
OS_SPECIFIC_LINK_LIBRARIES is always empty here

Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
2021-09-01 11:43:03 +00:00
Nicolas Fella
72277726a3 Remove unneeded include_directories
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
2021-09-01 11:43:03 +00:00
Nicolas Fella
18ddb9df4a Use CMAKE_INSTALL_DATADIR instead of custom DATADIR
CMake provides what we wan out of the box

Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
2021-09-01 11:43:03 +00:00
Nicolas Fella
d247e4791a Remove copy of GNUInstallDirs
It is provided by CMake itself

Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
2021-09-01 11:43:03 +00:00
Nextcloud bot
49a3a7d7c7
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-01 03:53:21 +00:00
Felix Weilbach
9ce161679a
Merge pull request #3719 from pprkut/svg
Allow using rsvg-convert to generate pngs instead of inkscape
2021-08-31 15:30:32 +02:00
Heinz Wiesinger
727de34879 Allow using rsvg-convert to generate pngs instead of inkscape
Signed-off-by: Heinz Wiesinger <pprkut@liwjatan.org>
2021-08-31 14:52:46 +02:00
Matthieu Gallien
8b71a1f305
Merge pull request #3683 from nextcloud/ci/fixClangTidyConfigFile
fix name of one clang-tidy check
2021-08-31 11:38:19 +02:00
Matthieu Gallien
d17d831205 switch from Q_DECL_OVERRIDE to plain override
our requirements guarantee availability of override keyword so we just
use it

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-08-31 08:35:57 +00:00
Matthieu Gallien
25669938fd let clang-tidy add missing override after enabling again the check
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-08-31 08:35:56 +00:00
Matthieu Gallien
0c3f5cde12 fix name of one clang-tidy check
allow modernize-use-override to work fine

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-08-31 08:35:56 +00:00
Nextcloud bot
843b9d45f4
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-31 03:54:33 +00:00
Nextcloud bot
494e100b0f
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-30 03:53:26 +00:00
Nextcloud bot
02e518381c
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-29 03:52:22 +00:00
Nextcloud bot
1d4f6ab19d
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-28 04:24:43 +00:00
Nextcloud bot
6ae83c25ed
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-27 03:55:02 +00:00
Matthieu Gallien
e83d441d42
Merge pull request #3697 from nextcloud/bugfix/warnings2
Fix more warnings
2021-08-26 18:44:12 +02:00
Felix Weilbach
44df9283fe Handle every enum value in switch statement
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-08-26 15:52:25 +00:00
Felix Weilbach
23fca8019b Add parens around && in || statement
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-08-26 15:52:25 +00:00
Felix Weilbach
4d72d375f2 Fix warnings related to wrong ordering of ctor init
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-08-26 15:52:25 +00:00
Matthieu Gallien
210e736bf5
Merge pull request #3715 from nextcloud/i18n/fixUnecessaryTrCall
remove a tr call where translator cannot do anything meaningful
2021-08-26 17:51:04 +02:00
Matthieu Gallien
601c4fb3c0 remove a tr call where translator cannot do anything meaningful
close #3708

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-08-26 15:26:54 +00:00
Matthieu Gallien
fbe39db773
Merge pull request #3698 from nextcloud/bugfix/nextcloud-cmd-documentation-update
Update nextcloudcmd documentation.
2021-08-26 09:48:37 +02:00
allexzander
4927e48bf3 Update nextcloudcmd documentation.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-08-26 10:38:06 +03:00
Nextcloud bot
3feba08965
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-08-26 03:54:45 +00:00