Matthieu Gallien
82c9a52d33
Merge pull request #7020 from nextcloud/bugfix/removeReadOnlyFoldersInReadOnlyFolders
...
Bugfix/remove read only folders in read only folders
2024-08-23 09:56:55 +02:00
Matthieu Gallien
3e397e664d
enable users to delete unexpected new folders inside a read-only folder
...
let unexpected new folders in read-only folders be read-write
would be done for folders that are inside a read-only folder and cannot
be uploaded because the parent folder is realy read-only
most probably those folders should never have been there
in case they would be read-only, users cannot delete them, in such
situation, letting them be read-write again should really help
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-08-23 09:56:44 +02:00
Matthieu Gallien
96d4062425
when deciding to create a new folder on server: check permissions
...
sometime we need to create a folder on server because some local files
or folders modifications would be lost without that
in that case instead of locally deleting teh folder, we create it back
on server
when doing that, it is important to check the remote permissions such
that we do not try to create a folder in a read-only folder on server
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-08-23 09:56:44 +02:00
Nextcloud bot
17d88ff0fd
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-08-23 02:44:30 +00:00
Matthieu Gallien
14a5dd14f6
Merge pull request #7017 from nextcloud/bugfix/fixIncorrectQStringBuilderUsage
...
avoid wrong usage of QStringBuilder via auto type deduction
2024-08-22 14:53:57 +02:00
Matthieu Gallien
316af5c13f
avoid wrong usage of QStringBuilder via auto type deduction
...
detected via https://github.com/KDE/clazy/blob/master/docs/checks/README-auto-unexpected-qstringbuilder.md#auto-unexpected-qstringbuilder
also reported by g++ via compile time warnings
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-08-22 14:53:46 +02:00
Matthieu Gallien
bb771497ff
Merge pull request #6952 from nextcloud/bugfix/doc-building-warnings
...
Fix doc building warnings
2024-08-22 11:06:08 +02:00
Claudio Cambra
45ce19dcbe
Fix string warning in account setup commandline doc
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-08-22 11:05:59 +02:00
Claudio Cambra
ff2a8ffc61
Fix table warning in troubleshooting doc
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-08-22 11:05:59 +02:00
Claudio Cambra
b1b2813050
Fix header underline warnings in docs
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-08-22 11:05:59 +02:00
Matthieu Gallien
aa1c83c9cc
Merge pull request #7016 from nextcloud/bugfix/hideEncryptFromContextMenu
...
Bugfix/hide encrypt from context menu
2024-08-22 10:12:41 +02:00
Matthieu Gallien
539be0a16a
only empty top folders offer the menu entry to encrypt
...
in the contextual menu shown in files explorer will show encrypt menu
entry only for top folders that are non-encrypted and empty
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-08-22 10:12:32 +02:00
Matthieu Gallien
1c3743d670
only add encrypt menu entry for top folders
...
with current end-to-end encryption only top folders can be encrypted
limit the availability of the menu entry to top folders
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-08-22 10:12:32 +02:00
Matthieu Gallien
5bb90c783e
ensure the arguments of socket API commands are valid
...
fix string data being invalid when using QStringView
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-08-22 10:12:32 +02:00
Matthieu Gallien
a384119a81
Merge pull request #7015 from nextcloud/fix-bug-report-typo
...
fix bug report breakage
2024-08-22 10:10:59 +02:00
Josh
7ba64dd584
fix bug report breakage
...
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-08-22 10:10:50 +02:00
Nextcloud bot
fd59381c80
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-08-22 02:46:08 +00:00
suiso67
a270756402
Narrow down ReadWrite folder permission to owner
...
Signed-off-by: suiso67 <suiso67@macadamia.rocks>
2024-08-21 22:12:42 +09:00
Matthieu Gallien
8cb1db4c29
Merge pull request #7010 from nextcloud/bugfix/deleteReadonlyFolders
...
Bugfix/delete readonly folders
2024-08-21 14:38:31 +02:00
Matthieu Gallien
8dcbdebd02
make folders read-write when needed when deleting local items
...
if a folder is read-only, when deleting content inside this folder, it
may be needed to make it temporary read-write
do this as required by the automated tests
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-08-21 14:38:21 +02:00
Matthieu Gallien
abde33e7e5
add automated test for deletion of child items in read-only folders
...
should ensure we are able to get files or dolders be deleted by sync
engine within read-only folders
would happen as the result of changes on server side being propagated
locally or when using selective sync
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-08-21 14:38:21 +02:00
Matthieu Gallien
dfe9ada124
Merge pull request #6965 from nextcloud/feature/server-forbidden-filenames
...
Feature/server forbidden filenames
2024-08-21 11:56:56 +02:00
Claudio Cambra
abb1f89119
When forbidden filename sync warning is encountered, add reason why the filename is forbidden to the item's error string
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-08-21 09:51:39 +02:00
Claudio Cambra
788067598d
Store forbidden filename match bools outside of if statement
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-08-21 09:51:39 +02:00
Claudio Cambra
598f2c95f5
Set invalid filename dialog mode in activity list model
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-08-21 09:51:39 +02:00
Claudio Cambra
aaf06535d2
Provide different message and explanation strings in invalid filename dialog depending on invalid mode
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-08-21 09:51:39 +02:00
Claudio Cambra
f07b49288b
Add invalid mode enum to invalid filename dialog
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-08-21 09:51:39 +02:00
Claudio Cambra
94d62e0203
Handle invalid filename activities button verb in activity list model
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-08-21 09:51:39 +02:00
Claudio Cambra
a9dfc6ebfc
Add rename file link/button to invalid filename activities
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-08-21 09:51:39 +02:00
Claudio Cambra
eb189f8fb4
Also provide notification for items that have file name invalid on server
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-08-21 09:51:39 +02:00
Claudio Cambra
1578cb1938
Assign invalid filename on server syncfileitem status to items with forbidden filenames
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-08-21 09:51:39 +02:00
Claudio Cambra
eee3a090cc
Provide Windows-compatible forbidden filename character in forbidden filenames test
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-08-21 09:51:39 +02:00
Claudio Cambra
071ab937af
Add test for new forbidden filename capabilities
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-08-21 09:51:39 +02:00
Claudio Cambra
29ab9ec95d
Check for new forbidden filename-related capabilities during exclusion handling in discovery
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-08-21 09:51:39 +02:00
Claudio Cambra
8f7ad48e96
Parse forbidden filename related capability features
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-08-21 09:51:39 +02:00
Matthieu Gallien
a29bd8ce6d
Merge pull request #7006 from nextcloud/fix/bug-issue-template-package-list
...
fix: Update bug reporting package list + misc tweaks
2024-08-21 09:49:33 +02:00
Josh
676112d210
fix: Update bug reporting package list + misc tweaks
...
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-08-21 09:49:23 +02:00
Matthieu Gallien
17eafb1221
Merge pull request #7011 from nextcloud/dependabot/github_actions/cpp-linter/cpp-linter-action-2.12.1
...
Bump cpp-linter/cpp-linter-action from 2.12.0 to 2.12.1
2024-08-20 16:50:35 +02:00
dependabot[bot]
09cf350b91
Bump cpp-linter/cpp-linter-action from 2.12.0 to 2.12.1
...
Bumps [cpp-linter/cpp-linter-action](https://github.com/cpp-linter/cpp-linter-action ) from 2.12.0 to 2.12.1.
- [Release notes](https://github.com/cpp-linter/cpp-linter-action/releases )
- [Commits](https://github.com/cpp-linter/cpp-linter-action/compare/v2.12.0...v2.12.1 )
---
updated-dependencies:
- dependency-name: cpp-linter/cpp-linter-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2024-08-20 16:50:26 +02:00
Matthieu Gallien
3d9ed8a7bd
Merge pull request #6855 from raldone01/fix/cropped_thumbnails
...
Keep aspect ratio for thumbnails
2024-08-20 15:15:52 +02:00
raldone01
e75d77c27c
Fixes cropped thumbnails #6154
...
Signed-off-by: raldone01 <raldone01@gmail.com>
2024-08-20 15:15:41 +02:00
Matthieu Gallien
db604b8193
Merge pull request #7004 from nextcloud/fix/issue-6723-http-icon
...
fix(settings): Use broken lock icon when not using https
2024-08-20 11:01:09 +02:00
Josh
83d1ed4869
fix(settings): Use broken lock icon when not using https
...
Fixes #6723
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-08-20 10:04:52 +02:00
Nextcloud bot
0de5c75cd9
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-08-20 02:50:39 +00:00
Nextcloud bot
274a0e7cde
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-08-19 02:43:53 +00:00
Nextcloud bot
198412e669
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-08-17 02:47:00 +00:00
Nextcloud bot
2133debf54
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-08-16 02:47:15 +00:00
Nextcloud bot
d67bc50e5d
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-08-15 02:58:21 +00:00
Nextcloud bot
b780cec6af
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-08-14 02:46:06 +00:00
Nextcloud bot
19a5085f07
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-08-13 02:47:01 +00:00