APPLICATION_SERVER_URL can be either empty or be specified. This commit adds the new CMake option APPLICATION_SERVER_URL_ENFORCE to decide whether to enforce the
URL's unmodified use (like before, default: ON) or to allow modification by the user (new).
By default APPLICATION_SERVER_URL_ENFORCE is set to ON, to no break with the previous implementation's expectations.
If APPLICATION_SERVER_URL is empty, APPLICATION_SERVER_URL_ENFORCE will be ignored by the Account Wizard.
The previous behaviour confused me a bit with branded builds. When the URL was (usually) specified but not forced, it was simply discarded, forcing the user to
manually supply it.
Signed-off-by: Michael Schuster <michael@schuster.ms>
Removes all Explorer Navigation Pane entries for a given ApplicationName, specified in NavRemove.ini in the working directory.
Also compiles a DLL with the same behaviour that exports:
- RemoveNavigationPaneEntries
Both tool variants are Mutex-protected.
Statically linked, optimized for binary size, no Qt dependencies.
Signed-off-by: Michael Schuster <michael@schuster.ms>
The helper DLL will be utilized by Windows Installer with Custom Actions defined in the NCMsiHelper.wxs WiX fragment.
Exports:
- ExecNsisUninstaller
- RemoveNavigationPaneEntries
Signed-off-by: Michael Schuster <michael@schuster.ms>
The Upgrade Code is a GUID (specified without brackets) for the MSI package to allow Windows Installer identify existing installations.
New build options (default: OFF):
- BUILD_WIN_MSI: Build all MSI scripts and a required helper DLL (to uninstall NSIS legacy installations and remove Explorer Navigation Pane entries)
- BUILD_WIN_TOOLS: Build additional migration tools (currently NCNavRemove, a stand-alone tool for Explorer entries removal)
The helper DLL and migration tools are set to be statically linked and optimized for binary size.
Signed-off-by: Michael Schuster <michael@schuster.ms>
Otherwise we get lots of "No description available" lines in the
activity list which is basically noise. Also trains the user to ignore
the secondary line.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Fix for #1793: The problem seems to be related enabling hardened runtime.
This exception allows the webview to load.
Signed-off-by: Camila San <hello@camila.codes>
The last translation update from Transifex was done in 2017, so the scripts and settings were never used for Nextcloud.
This commit removes the unused scripts and "Auto-generated" comments in the translation files.
Some files have been modified over time either way and MSI will replace NSIS soon.
Signed-off-by: Michael Schuster <michael@schuster.ms>
Turns out this clang-tidy check can give false positives coming from
headers outside the project while it shouldn't.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Indee the MenuItem might not be linked to its Menu at creation time
which will make the binding fail and give a warning. Delay for the menu
availability.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Now that we depend on Qt 5.12 anyway, the count property is available
just fine on the Menu item.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
Under Wayland QCursor::pos() is unlikely to give us anything meaningful,
so fallback to the primary screen information.
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
