Commit graph

15137 commits

Author SHA1 Message Date
Kevin Ottens
14993d4de6
Merge pull request #2417 from nextcloud/fix_menu_popup_in_main_dialog
Fix menu popup in main dialog
2020-09-15 11:03:07 +02:00
Kevin Ottens
6ee37b5975 Make sure menu are closed when button is clicked again
This way we also made sure all the Menu are currently on the same close
policy.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-15 08:46:10 +00:00
Kevin Ottens
f7efe6a902 Delay binding on the menu width
Indee the MenuItem might not be linked to its Menu at creation time
which will make the binding fail and give a warning. Delay for the menu
availability.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-15 08:46:10 +00:00
Kevin Ottens
eb0cedebfa Remove pre-QQC2.3 workaround
Now that we depend on Qt 5.12 anyway, the count property is available
just fine on the Menu item.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-15 08:46:09 +00:00
Kevin Ottens
4f5d707e44
Merge pull request #2418 from nextcloud/use_primary_screen_as_fallback_when_qcursor_pos_search_failed
Use QGuiApplication::primaryScreen() as fallback for Systray::currentScreen()
2020-09-15 10:44:54 +02:00
Kevin Ottens
7ccb016397 Use QGuiApplication::primaryScreen() as fallback for Systray::currentScreen()
Under Wayland QCursor::pos() is unlikely to give us anything meaningful,
so fallback to the primary screen information.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-15 07:17:03 +00:00
Nextcloud bot
54b09a1fbb
[tx-robot] updated from transifex 2020-09-15 03:22:14 +00:00
Nextcloud bot
9d3a905cc5
[tx-robot] updated from transifex 2020-09-12 03:19:44 +00:00
Nextcloud bot
88a573a643
[tx-robot] updated from transifex 2020-09-11 03:20:37 +00:00
Kevin Ottens
01986df8ca Don't use a confusing "royal you" in the sync messages
Users get rightfully confused with the "You changed ..." messages in the
activity list for syncs. Indeed, some of those changes might be coming
from the server in which case we don't really know who did the change.

So now we use the old "Synced ..." messages for changes pulled from the
server and we have a more precise "You changed ..." (renamed, deleted,
created) when the changes were initiated locally (since there we know
the user reading the message did it).

Also changed how the messages are constructed so that they can be
properly translated.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-10 15:40:05 +02:00
Nextcloud bot
9ab256b4b4
[tx-robot] updated from transifex 2020-09-10 03:25:52 +00:00
Camila
95f634ce28 Click on activity list in systray open file in the file manager.
Clean up code, add more const and auto.

Signed-off-by: Camila <hello@camila.codes>
2020-09-09 20:06:46 +02:00
Camila
c1086c9886 Fix tooltip for activity info.
Also improves readability of the items in the list.

Signed-off-by: Camila <hello@camila.codes>
2020-09-09 20:06:46 +02:00
Valdnet
a432501d80 l10n: Add a period 2020-09-09 10:07:10 +02:00
Nextcloud bot
301a926f4d
[tx-robot] updated from transifex 2020-09-09 03:19:56 +00:00
Valdnet
9822079cae l10n: Extract the button name 2020-09-08 16:44:51 +02:00
Valdnet
528fa92e86 l10n: Delete unnecessary sentence 2020-09-08 16:44:51 +02:00
Valdnet
1444500f77 l10n: A few more fixes 2020-09-08 16:44:51 +02:00
Valdnet
e2737b5067 l10n: Word correction 2020-09-08 16:44:51 +02:00
Valdnet
f931bc832c l10n: Corrected translation 2020-09-08 16:44:51 +02:00
Kevin Ottens
fdb35e5f9f Leave the implicit uint to int cast
I wrongly (and stupidly) assumed the int in QBitArray was treated as a
hash as well but it is an index so it must be positive. Also to make
things even worse I misread on which expression clang-tidy was
complaining regarding the implementation specific narrowing
conversion... This is happening after the modulo operator and not
before. We're in a safe range of values at that point, so it's fine to
let the narrowing happen.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-08 16:44:31 +02:00
Kevin Ottens
de3ba2721b
Merge pull request #2387 from nextcloud/update-troubleshooting
Update troubleshooting
2020-09-08 15:46:55 +02:00
Camila
0f03e3091d Add README with instructions on how to build the documentation.
Signed-off-by: Camila <hello@camila.codes>
2020-09-08 13:44:26 +00:00
Camila
fecc62b7e1 Update troubleshooting instructions with the newly added config file options.
Signed-off-by: Camila <hello@camila.codes>
2020-09-08 13:44:26 +00:00
Nextcloud bot
5adb720630
[tx-robot] updated from transifex 2020-09-08 03:19:49 +00:00
Nextcloud bot
a61dd7cf46
[tx-robot] updated from transifex 2020-09-06 03:28:59 +00:00
Nextcloud bot
2db125dca0
[tx-robot] updated from transifex 2020-09-05 03:29:13 +00:00
Nextcloud bot
6c69ac6602
[tx-robot] updated from transifex 2020-09-04 03:29:47 +00:00
Kevin Ottens
a4cb7e3040
Merge pull request #2357 from thaytan/metadata-index-e2eMangledName
syncjournaldb: index e2eMangledName column in metadata
2020-09-03 16:20:48 +02:00
Jan Schmidt
3077a1378b syncjournaldb: index e2eMangledName column in metadata
Add an index on the e2eMangledName column in the metadata table
to speed up file sync by orders of magnitude on directories with
a large number of files.

Signed-off-by: Jan Schmidt <jan@centricular.com>
2020-09-03 22:56:14 +10:00
Nextcloud bot
fd29a0ae57
[tx-robot] updated from transifex 2020-09-03 03:29:13 +00:00
Kevin Ottens
18b16a3ede
Merge pull request #2351 from nextcloud/fix_clang_tidy_errors_in_csync_tests
Fix clang tidy errors in csync tests
2020-09-02 08:25:24 +02:00
Kevin Ottens
ee92e5af9a Switch to newer CI image to build csync tests
This new image brings the cmocka dependency and thus will make the CI
build the csync tests which depend on it.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-02 06:12:46 +00:00
Kevin Ottens
2916144fe3 Fix bugprone-narrowing-conversion errors in csync tests
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-02 06:12:46 +00:00
Kevin Ottens
c7c37f9bef Fix modernize-use-nullptr errors in csync tests
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-02 06:12:46 +00:00
Kevin Ottens
9a0713fab7 Fix modernize-use-auto errors in csync tests
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-02 06:12:46 +00:00
Kevin Ottens
f323f8b4bc Fix modernize-deprecated-headers errors in csync tests
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-02 06:12:45 +00:00
Nextcloud bot
9ec4e772eb
[tx-robot] updated from transifex 2020-09-02 03:31:47 +00:00
Kevin Ottens
b6591be973
Merge pull request #2283 from nextcloud/enable_bugprone_clang_tidy_checks
Enable bugprone clang tidy checks
2020-09-01 08:47:41 +02:00
Kevin Ottens
310693be2c Enable all the other bugprone clang-tidy checks
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-01 06:37:03 +00:00
Kevin Ottens
aa63889e5b Enable bugprone-terminating-continue clang-tidy check
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-01 06:37:03 +00:00
Kevin Ottens
0909f00a8b Enable bugprone-too-small-loop-variable clang-tidy check
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-01 06:37:03 +00:00
Kevin Ottens
80cc196f6f Enable bugprone-narrowing-conversions clang-tidy check
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-01 06:37:03 +00:00
Kevin Ottens
5cec1373ad Enable bugprone-macro-parentheses clang-tidy check
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-01 06:37:03 +00:00
Kevin Ottens
608bf025e6 Enable bugprone-forward-declaration-namespace clang-tidy check
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-01 06:37:03 +00:00
Kevin Ottens
c8ea848596 Enable the bugprone-branch-clone clang-tidy check
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-01 06:37:03 +00:00
Kevin Ottens
4cb9bec23a Enable the bugprone-argument-comment clang-tidy check
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-09-01 06:37:03 +00:00
Nextcloud bot
4e61181b45
[tx-robot] updated from transifex 2020-09-01 03:26:29 +00:00
Kevin Ottens
4ee80bfe2e
Merge pull request #2345 from nextcloud/use_httpd_unix-directory_mimetype_for_e2ee_folders
Use httpd/unix-directory mimetype for E2EE folders
2020-08-31 13:11:51 +02:00
Kevin Ottens
eb76682b1e Use httpd/unix-directory mimetype for E2EE folders
We don't do much with that mimetype on our end, but other clients
somehow don't expect inode/directory to let's lie. ;-)

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-08-31 10:08:48 +00:00