Commit graph

18314 commits

Author SHA1 Message Date
Claudio Cambra
77fb0c4808
Filter out sharees that already have active shares
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:09 +01:00
Claudio Cambra
0826e8d6ba
Improve server error handling in the ShareModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:09 +01:00
Claudio Cambra
c707dd0ccc
Check for state of file record retrieval in fileactivitylistmodel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:09 +01:00
Claudio Cambra
79c0f3464a
Fix default date parser handling of timezones
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:09 +01:00
Claudio Cambra
ff4a4c63a1
Renamed _userStoppedTypingTimer to searchRateLimitingTimer
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:09 +01:00
Claudio Cambra
ce53c8439f
Add trailing comma to shareemodel enum
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:08 +01:00
Claudio Cambra
639fb21a13
Replace manual index bound checks with calls to checkIndex
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:08 +01:00
Claudio Cambra
fb4bb95b91
Perform inactive qquickwindow garbage collection when generating new file detail dialogs, raise existing dialog instead of always deleting
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:08 +01:00
Claudio Cambra
d2552ba439
Use auto where possible
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:08 +01:00
Claudio Cambra
b7d96781de
Add minimum size to file details window
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:08 +01:00
Claudio Cambra
121ab38177
Remove default cases in switches, rely on compiler warnings for missed cases
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:08 +01:00
Claudio Cambra
31afb02c84
Eliminate unneeded parent Item in FileActivityView
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:08 +01:00
Claudio Cambra
0ca927843f
Add early return checks for setter methods
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:08 +01:00
Claudio Cambra
685a0362fc
Refactor generation of dialogs, remove need for QSharedPointer and reduce use of pointers
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:07 +01:00
Claudio Cambra
f97f39375b
Remove Q_REQUIRED_RESULT from method with side-effect where result not always required, and viceversa
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:07 +01:00
Claudio Cambra
de0831c297
Use [[nodiscard]] more broadly in methods returning values, and respect it elsewhere
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:07 +01:00
Claudio Cambra
ec3c361c89
Show password set errors in the popup where passwords are set rather than in the main dialog
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:07 +01:00
Claudio Cambra
d92bc91bdf
Improve share view tab buttons
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:07 +01:00
Claudio Cambra
eda0328e9c
Change 'Link share' to 'Share link', matching server
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:07 +01:00
Claudio Cambra
6adefb572a
Improve flat buttons in share delegates
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:07 +01:00
Claudio Cambra
7971789112
Add a file details window/page, QMLify file sharing
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:03 +01:00
Matthieu Gallien
1dbdd8853f
add mising namespace
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-31 12:23:52 +01:00
Matthieu Gallien
10d022582c
Merge pull request #5116 from nextcloud/ci/fixMacCompilationEditLocallly
use new public API to open an edit locally URL
2022-10-31 11:00:07 +01:00
Matthieu Gallien
521054dbf0
use new public API to open an edit locally URL
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-31 10:28:47 +01:00
Nextcloud bot
95776abb7a
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-31 03:19:19 +00:00
Nextcloud bot
bdbf65c6f0
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-30 03:23:26 +00:00
Claudio Cambra
09c6f5a115
Merge pull request #5097 from nextcloud/bugfix/sync-now-visible-connected
Only show Sync Now button if account is connected
2022-10-29 17:03:46 +02:00
Claudio Cambra
09997b189f Only show Sync Now button if account is connected
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-29 15:54:19 +02:00
Claudio Cambra
6f67c2ec88
Merge pull request #5105 from nteodosio/master
Fix compatibility with newer python3-nautilus
2022-10-29 15:44:21 +02:00
Nathan Pratta Teodosio
2ba08206af Fix compatibility with newer python3-nautilus
Signed-off-by: Nathan Pratta Teodosio <nathan.teodosio@canonical.com>
2022-10-29 14:37:41 +02:00
Claudio Cambra
bbfe9ca411
Merge pull request #5027 from nextcloud/bugfix/modernise-accountsettings-code
Modernise and improve code in AccountSettings
2022-10-29 14:37:29 +02:00
Claudio Cambra
ff3eab1275 Modernise QString-related construction
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-29 14:03:58 +02:00
Claudio Cambra
b4be56c267 Add braces to all if statements missing them
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-29 14:03:58 +02:00
Claudio Cambra
7d05d8471b Expand use of const and auto, improve readability of accountsettings
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-10-29 14:03:58 +02:00
Claudio Cambra
7ac4898840
Merge pull request #5107 from nextcloud/bugfix/refactor-folderman-edit-locally
Refactor FolderMan's "Edit Locally" capabilities as separate class
2022-10-29 14:02:04 +02:00
Claudio Cambra
72e154def1 Rename EditLocallyHandler to EditLocallyJob
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-29 13:32:48 +02:00
Claudio Cambra
ee8b12009a Ensure the checkTokenJob object gets deallocated
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-29 13:32:48 +02:00
Claudio Cambra
ae12519dd5 Show edit locally loading dialog sooner, improve feedback for user
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-29 13:32:48 +02:00
Claudio Cambra
9f7a699ad9 Refactor edit locally handler management away from application and into own class
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-29 13:32:48 +02:00
Claudio Cambra
4b6fdcc550 Don't show the user any potenitally questionable remote data
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-29 13:32:48 +02:00
Claudio Cambra
9438d3f1c7 Verify token before checking disk or modifying state
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-29 13:32:48 +02:00
Claudio Cambra
9a00aa6e66 Refactor edit locally into its own class, rather than bolting onto FolderMan
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-29 13:32:48 +02:00
Claudio Cambra
224621bb85 Refactor large editFileLocally FolderMan method into smaller, clearer separate methods
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-29 13:32:48 +02:00
Nextcloud bot
3449dba0a8
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-29 03:31:52 +00:00
Claudio Cambra
b6deeecfda
Merge pull request #5093 from nextcloud/work/validate-edit-locally-token
Validate and sanitise edit locally token and relpath before sending to server
2022-10-28 13:11:01 +02:00
Claudio Cambra
734c986cd1
Use addQueryParams for checkTokenForEditLocally SimpleApiJob
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-28 12:38:46 +02:00
Claudio Cambra
0b33ce2b40
Make sure to check relPath and compare to canonical cleaned path
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-28 12:38:18 +02:00
Claudio Cambra
0c6127de44
Make sure to encode the relPath
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-28 12:38:14 +02:00
Claudio Cambra
8683ee08e7
Validate edit locally token before sending to server
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-28 12:37:26 +02:00
Nextcloud bot
8c37bf2711
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-28 03:20:17 +00:00