Matthieu Gallien
311469a0e5
Merge pull request #4992 from nextcloud/ci/useNoDiscard
...
Ci/use no discard
2022-10-04 11:44:46 +02:00
Matthieu Gallien
565a5f0999
add [[nodiscard]] attribute via clang-tidy
...
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,modernize-use-nodiscard' -fix
under linux with most part of our code covered
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-04 11:14:45 +02:00
Matthieu Gallien
5fc017575b
fix [[nodiscard]] single warning
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-04 11:14:45 +02:00
Matthieu Gallien
17e2f1de03
Merge pull request #4993 from nextcloud/ci/useUsing
...
apply modernize-use-using via clang-tidy
2022-10-04 11:14:27 +02:00
Matthieu Gallien
9b7d1add52
apply modernize-use-using via clang-tidy
...
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,modernize-use-using' -fix
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-04 01:32:46 +02:00
Claudio Cambra
e5d5471fb6
Merge pull request #4982 from nextcloud/bugfix/enforced-max-expire-date-link-share-fix
...
Fix link shares default expire date being enforced as maximum expire date even when maximum date enforcement is disabled on the server
2022-10-04 01:13:20 +02:00
Claudio Cambra
c67141430b
Fix link shares default expire date being enforced as maximum expire date even when maximum date enforcement is disabled on the server
...
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-10-03 22:27:18 +02:00
Matthieu Gallien
15bfccd6a7
Merge pull request #5004 from nextcloud/configure-clang-tidy-checks
...
configure a list of checks for clang-tidy
2022-10-03 22:01:51 +02:00
Matthieu Gallien
4e3e8be4f6
configure a list of checks for clang-tidy
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-03 21:05:50 +02:00
Matthieu Gallien
ca30859831
Merge pull request #5003 from nextcloud/update-client-appimage-image
...
switch AppImage CI to latest tag: client-appimage-6
2022-10-03 20:53:22 +02:00
Matthieu Gallien
a0065d1511
switch AppImage CI to latest tag: client-appimage-6
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-03 17:22:02 +02:00
Matthieu Gallien
6bb768f889
Merge pull request #4994 from nextcloud/ci/cppcoreguidelines-pro-type-static-cast-downcast
...
avoid possibly crashing static_cast
2022-10-03 13:50:22 +02:00
Matthieu Gallien
ecc588c27a
avoid possibly crashing static_cast
...
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,cppcoreguidelines-pro-type-static-cast-downcast' -fix
this can prevent casting to a type that is unrelated to the real type
and later cause a crash because you go into undefined behavior domain
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-03 10:23:24 +02:00
Matthieu Gallien
c40d948b56
Merge pull request #4996 from nextcloud/cleanConfigFileConstants
...
alway use constexpr for all text constants
2022-10-03 10:22:45 +02:00
Matthieu Gallien
0b4128eede
Merge branch 'master' into cleanConfigFileConstants
2022-10-02 15:48:20 +02:00
Matthieu Gallien
ee98244877
Merge pull request #4999 from nextcloud/ci/checkClangTidyInCi
...
check our code with clang-tidy
2022-10-02 15:48:07 +02:00
Matthieu Gallien
43e7308164
check our code with clang-tidy
...
should allow to keep our code tidy and maybe simplify reviews
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-02 15:36:25 +02:00
Matthieu Gallien
bfe0b3067e
Merge pull request #4995 from nextcloud/ci/checkClangTidyInCi
...
Ci/check clang tidy in ci
2022-10-02 15:14:06 +02:00
Matthieu Gallien
88629737c1
check our code with clang-tidy
...
should allow to keep our code tidy and maybe simplify reviews
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-02 15:09:47 +02:00
Matthieu Gallien
3193937e50
use auto
...
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,modernize-use-auto' -fix
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-02 14:56:37 +02:00
Matthieu Gallien
9f1b6c261d
alway use constexpr for all text constants
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-02 14:42:01 +02:00
Nextcloud bot
a7dcbada22
[tx-robot] Update transifex configuration
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-01 16:14:41 +00:00
Claudio Cambra
a1d0684f8f
Merge pull request #4988 from nextcloud/bugfix/macos-no-context-menu
...
Don't set up tray context menu on macOS, even if not building app bundle
2022-10-01 00:06:54 +02:00
Claudio Cambra
7a1dbcf2fe
Don't set up tray context menu on macOS, even if not building app bundle
...
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-30 21:45:30 +02:00
Claudio Cambra
fc03d73f74
Merge pull request #4987 from nextcloud/bugfix/fix-predefined-status-text
2022-09-30 19:37:07 +02:00
Claudio Cambra
652c0dcff7
Fix predefined status text formatting
...
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-30 16:24:36 +02:00
Nextcloud bot
d74057835c
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-09-30 05:44:39 +00:00
Claudio Cambra
9078cca682
Merge pull request #4986 from nextcloud/bugfix/sync-progress-bar-dark
...
Fix sync progress bar colours in dark mode
2022-09-29 22:37:43 +02:00
Claudio Cambra
6137fe246e
Fix sync progress bar colours in dark mode
...
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-29 21:55:44 +02:00
Camila
31478bbd63
Merge pull request #4985 from nextcloud/bugfix/primary-buttons
...
Fix 'Reply' primay property.
2022-09-29 18:34:01 +02:00
Camila
1ccc170f91
Update tests to follow 'Reply' change of primary action.
...
Signed-off-by: Camila <hello@camila.codes>
2022-09-29 17:15:50 +02:00
Camila
7633cc490d
Fix 'Reply' action primary property.
...
Primary is set to true when object type is 'room' or 'chat' and it set to
false when object type is 'call'.
Signed-off-by: Camila <hello@camila.codes>
2022-09-29 15:20:56 +02:00
Camila
cbe22d8c1e
Remove unused property.
...
Signed-off-by: Camila <hello@camila.codes>
2022-09-29 15:17:10 +02:00
Claudio Cambra
53573745a3
Merge pull request #4976 from nextcloud/feature/nicer-errorbox
...
Improve the error box QML component
2022-09-29 12:48:47 +02:00
Claudio Cambra
9781e896a1
Improve the error box QML component
...
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-29 12:14:37 +02:00
Nextcloud bot
0d8a70eec7
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-09-29 04:35:11 +00:00
Claudio Cambra
00e118b9c6
Merge pull request #4784 from nextcloud/bugfix/activity-action-button
...
Make activity action button an actual button, clean up contents
2022-09-28 13:43:17 +02:00
Claudio Cambra
db861e1ade
Make activity action button an actual button, clean up contents
...
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-28 13:07:08 +02:00
Claudio Cambra
5dfd605049
Merge pull request #4960 from nextcloud/bugfix/emoji-picker-placeholder-wrap
...
Ensure placeholder message in emoji picker wraps correctly
2022-09-28 13:06:45 +02:00
Claudio Cambra
be2c0ddbc8
Ensure placeholder message in emoji picker wraps correctly
...
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-28 12:33:09 +02:00
Nextcloud bot
a4dde43089
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-09-28 04:32:38 +00:00
Camila
71032ca7ef
Merge pull request #4967 from nextcloud/bugfix/issue-4841
...
Fix two factor authentication notification
2022-09-27 16:52:25 +02:00
Camila
348c9ea915
Fix persistent two factor auth notification.
...
The server app returns a 202 code when the request succeeded, which was
not taken into account.
Signed-off-by: Camila <hello@camila.codes>
2022-09-27 14:49:29 +00:00
Camila
f3513aaafe
Fix two factor auth notification: 'Approve' link is a primary action.
...
Signed-off-by: Camila <hello@camila.codes>
2022-09-27 14:49:29 +00:00
Simon L
1f5ce39e6c
Merge pull request #4968 from nextcloud/bugfix/bring-back-lnk-files
...
Bring back .lnk files on Windows and always treat them as non-virtual files.
2022-09-27 16:42:46 +02:00
alex-z
225c2dda4c
Bring back .lnk files on Windows and always treat them as non-virtual files.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-09-27 10:12:03 +03:00
Nextcloud bot
9f952e32e4
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-09-27 03:28:55 +00:00
Claudio Cambra
56fe6a1f30
Merge pull request #4933 from nextcloud/bugfix/sorted-activity-model
2022-09-26 19:19:33 +02:00
Claudio Cambra
e721b03106
Remove sorting code in activitylistmodel as not needed with sortedactivitylistmodel
...
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-26 18:18:34 +02:00
Claudio Cambra
f71ddc4d43
Add a sortedactivitylistmodel that automatically handles sorting of activities
...
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-26 18:18:28 +02:00