mirrors/nextcloud-desktop
1
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2024-12-21 13:14:30 +03:00
Code Issues Projects Releases Packages Wiki Activity
20050 commits 486 branches 258 tags 464 MiB
Commit graph

4196 commits

Author SHA1 Message Date
Claudio Cambra
5a56584fba Deallocate call notification dialog objects when closed 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-14 12:34:47 +02:00
Claudio Cambra
14303d0eb6 Make account setup wizard's adjustWizardSize resize to current page size instead of largest wizard page 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-13 23:00:05 +02:00
Claudio Cambra
1a5fa50fbb Refactor ActivityListModel population mechanisms 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-13 19:34:41 +02:00
Claudio Cambra
4c9e0873a3 Fix low-resolution file changed overlay icons in activities 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-13 18:55:47 +02:00
Claudio Cambra
66198055d3 Fix add account text clipping, enlarge text 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-10 20:16:17 +02:00
Claudio Cambra
871ad24e28 Fix ActivityItem activityHover error 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-10 12:11:23 +02:00
Claudio Cambra
b1caa45929 Fix menu bar height calculation on macOS 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-10 11:52:29 +02:00
Claudio Cambra
b3ccbe2808 Fix fileactivitylistmodel QML registration 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-10 11:17:10 +02:00
alex-z
2a529eef3c Make sure Folder is deleted from the list and the SyncJournalDB is closed for every folder of the account that has been removed. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-09-10 10:34:34 +02:00
alex-z
f0b9ecd747 Check folder invalidity reson when deciding to enable or disable the 'Finish' button in a Wizard page. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-09-10 10:34:34 +02:00
Claudio Cambra
9a0753dabb Replace private API QZipWriter with KArchive 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-07 19:10:03 +02:00
Claudio Cambra
b7b374c442 Fix rebase issue with activity list keyboard navigation PR 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-07 18:45:58 +02:00
Claudio Cambra
b820df90b9 Improve activity list highlighting/keyboard item selection 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-07 18:27:14 +02:00
Claudio Cambra
85c5002d34 Simplify activity list delegates by making them ItemDelegates, clean up 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-07 18:19:49 +02:00
Claudio Cambra
e79ced22ae Clean up QML registration 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-07 17:00:44 +02:00
Claudio Cambra
7882e224fd Set UnifiedSearchResultNothingFound visibility less messily 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-07 15:01:07 +02:00
alex-z
1b98733b1a Start sync immediately after modifying the selective sync settings. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-09-07 13:38:09 +03:00
alex-z
7ba681544c Fix wrong estimated time when doing sync. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-09-07 09:31:05 +03:00
Claudio Cambra
316f3981ab Align, resize, and layout everything uniformly in the unified search view 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-06 09:02:17 +02:00
Claudio Cambra
5acb0b272a Use same tooltip component everywhere 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-06 08:40:03 +02:00
Claudio Cambra
2fe4bc5403 Add a ScrollView to the predefined statuses area of the UserStatusSelector 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-05 12:33:19 +02:00
Matthieu Gallien
d1408df7ba let Qt use OpenGLES instead of desktop OpenGL to workaround bugs 
should help picking a working rendering pipeline on windows

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-09-04 22:20:38 +02:00
Matthieu Gallien
0092ad15c7 sets special configuration to webengine to work around bugs 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-09-04 22:20:38 +02:00
alex-z
ba9a39856b Change Activities dialog show and Systray.forceWindowInit call sequence to fix the issue of Activities dialog not being shown. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-08-29 10:59:55 +03:00
alex-z
22a3b6cc16 Fix File Activities dialog not showing up. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-08-29 10:59:55 +03:00
Claudio Cambra
27f28d781e Prevent the 'Cancel' button of the user status selector getting squashed 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-17 21:08:25 +02:00
Claudio Cambra
ecab3d76ee Ensure that clear status message combo box is at least implicit width 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-17 20:34:17 +02:00
Claudio Cambra
bedcfbd14c Fix alignment of predefined status contents regardless of emoji fonts 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-17 20:01:12 +02:00
Claudio Cambra
fc5e9db839 Prevent crashing when trying to create error-ing QML component in systray.cpp, output error to log 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-17 15:31:04 +02:00
Claudio Cambra
2ab95a30f9 Ensure file activity dialog is centered on screen and appears at top of window stack 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-17 14:01:32 +02:00
Claudio Cambra
7d41530284 Fix account switching and hover issues with UserLine component 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-10 18:07:02 +03:00
Claudio Cambra
37bd55b232 Fix unified seach item placeholder image source 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-10 13:31:45 +02:00
Claudio Cambra
387dfa96a1 Refactor user line 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-10 12:10:20 +02:00
Claudio Cambra
d86f25d215 Make UserStatusSelector a dismissible page pushed onto the tray window 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-10 09:22:33 +00:00
Claudio Cambra
0a89bf2335 Fix QML warnings 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-09 14:45:18 +03:00
Claudio Cambra
81bb290e4c Eliminate padding around the menu separator in the account menu 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-08 16:14:32 +02:00
Matthieu Gallien
8551a14c48 ensure SyncEngine use an initialized instance of SyncOptions 
will prevent nextcloudcmd command line client from ignoring the settings
handled by SyncOptions

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-08-08 12:36:37 +03:00
Claudio Cambra
e9e482b174 Restyle unified search skeleton items animation and simplify their code 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-05 18:40:13 +02:00
allexzander
ff0a058f66 Fix crash: 'Failed to create OpenGL context'. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2022-08-05 16:29:21 +03:00
Valdnet
443ec4bfac
i18n: Spelling unification 
Spelling unification in Transifex.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2022-08-05 12:04:36 +02:00
Valdnet
0e703c57c2
i18n: Spelling unification 
Spelling unification in Transifex.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2022-08-05 12:03:03 +02:00
Valdnet
ee950435c9
i18n: Spelling unification 
Spelling unification in Transifex.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2022-08-05 11:26:03 +02:00
Valdnet
42854355ad
i18n: Spelling unification 
Spelling unification in Transifex.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2022-08-05 11:23:31 +02:00
alex-z
d42d3c057f Implement URI handler for local file editing 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-08-03 11:38:33 +03:00
Claudio Cambra
2b598d1820 Double-clicking tray icon opens currently-selected user's local folder (if available) 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-02 19:06:44 +02:00
Claudio Cambra
c74c466725
Merge branch 'master' into bugfix/clean-up-talkreplytextfield 2022-08-02 18:28:28 +02:00
Claudio Cambra
789179214f Clicking on an activity list item for a file opens the local file if available 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-02 17:43:18 +02:00
Matthieu Gallien
7180b09807 mark unused variable as bein unused to avoid clang warning 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-08-02 16:28:50 +02:00
Matthieu Gallien
fe7a62bc77 remove variables set but never read 
will fix a clang compilation error

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-08-02 16:28:50 +02:00
alex-z
f3c10ac3a4 Always run MSI with full UI. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-08-02 15:27:01 +03:00
Claudio Cambra
b1deb6cd1d Replace unified search text field busy indicator with custom indicator 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-02 13:23:33 +02:00
allexzander
250faf027f Do not reboot PC when running an MSI via autoupdate. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2022-08-02 09:26:17 +03:00
alex-z
001deace2d Implement COM Dll for CfApi shell extensins. Implement Thumbnail Provider. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-07-29 19:26:53 +03:00
Claudio Cambra
78b3e09f3b Clean up TalkReplyTextField, remove unnecessary parent Item 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-29 12:47:08 +02:00
Claudio Cambra
061f443920 Make apps menu scrollable when content taller than available vertical space, preventing borking of layout 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-27 12:19:10 +02:00
Claudio Cambra
7a78f2b19f Ensure that throttled notifications still appear in tray activity model 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-25 13:15:50 +02:00
Claudio Cambra
8d0df62c49 Stop styling QML unified search items hierarchically, use global Style constants 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-21 15:38:18 +02:00
Claudio Cambra
bb034b8bf4 Ensure debug archive contents are readable by any user 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-21 13:47:49 +02:00
Claudio Cambra
8dfe1647ed Stop clearing notifications when new notifications are received 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-21 13:14:51 +02:00
Claudio Cambra
e3d897cb7f Fix ActivityItemContent QML paintedWidth errors 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-18 15:13:58 +02:00
Claudio Cambra
539ba93fd1 QMLify the UserModel, use properties rather than setter methods 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-15 16:47:17 +02:00
Claudio Cambra
f8d79c389c Use preprocessor directive rather than normal 'if' for UNNotification types 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-15 16:21:16 +02:00
Claudio Cambra
f2dbceaee0 Respect skipAutoUpdateCheck in nextcloud.cfg with Sparkle on macOS 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-15 15:49:13 +02:00
Claudio Cambra
6872e1a75b Take ints by value rather than reference in UserModel methods 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-15 15:01:48 +02:00
Claudio Cambra
bc01db7cff
Merge branch 'master' into bugfix/limit-concurrent-notifications 2022-07-13 00:18:08 +02:00
Claudio Cambra
ce9e4a99c0 Refactor tray window opening code for clarity and efficiency 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-12 22:54:00 +02:00
Claudio Cambra
cf372b43ac Properly adapt the userstatusselectormodel, eliminate hacks, make code more declarative 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-12 21:10:26 +02:00
Claudio Cambra
7d087026ca Limit concurrent notifications 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-12 20:24:50 +02:00
Claudio Cambra
f892d24717 Fix bad quote in PNG generation message 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-12 20:20:30 +02:00
Claudio Cambra
e0041feca0 Add a placeholder message for the recents tab of the emoji picker 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-12 15:19:57 +02:00
Claudio Cambra
b712eb95e2 Clean up systray methods, make more QML-friendly 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-06 11:26:53 +02:00
Claudio Cambra
5e67405b45 Add a custom back button to the account wizard's advanced setup page 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-06 09:57:30 +02:00
Claudio Cambra
22464f5005 Work around issues with window positioning on Linux DEs, hardcode tray window to screen center when new account added 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-04 14:11:19 +02:00
Claudio Cambra
ada355061a Increase the call state checking interval to not overload the server 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-01 14:44:46 +02:00
Claudio Cambra
a504dbf965 Close call notifications when the call has been joined by the user, or the call has ended 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-01 11:39:50 +02:00
szaimen
d81d3b188a use an en-dash for the userstatus panel 
Signed-off-by: szaimen <szaimen@e.mail.de>
 2022-06-30 14:34:20 +02:00
Camila
fae5b5573c Clean up code, move values to Style.qml. 
Signed-off-by: Camila <hello@camila.codes>
 2022-06-28 09:25:48 +02:00
Camila
3ff781ee17 Talk reply field should now have the same height as the 'Reply' button. 
Signed-off-by: Camila <hello@camila.codes>
 2022-06-28 09:25:48 +02:00
Valdnet
b214b87491 i18n: Add dot 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2022-06-28 08:55:54 +02:00
Valdnet
2fb1aab655 i18n: Fix for "end-to-end" 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2022-06-28 08:55:54 +02:00
Claudio Cambra
749f5dee82 Fix the system tray menu not being correctly replaced in setupContextMenu 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-06-24 18:22:54 +02:00
Claudio Cambra
ee3e0d3351 User dialog now looks in line with the rest of the desktop client tray 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-06-24 16:29:18 +02:00
Claudio Cambra
b7c2e16aa9 Make client language gender-neutral and more clear 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-06-24 14:36:36 +02:00
Claudio Cambra
2fe6e075b6 Share dialog is now resizeable 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-06-24 13:45:56 +02:00
Claudio Cambra
0658d7227e Remove Q_ASSERTs for userstatusconnector 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-06-24 12:34:52 +02:00
Claudio Cambra
e873f3b348 Fix crashing when selecting user status 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-06-24 12:34:52 +02:00
Claudio Cambra
d8d72e81bb Redesign local folder information in the account adding wizard 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-06-24 10:19:47 +02:00
Matthieu Gallien
e581805138 set OpenGL software rendering and set similar options for webview 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-06-24 08:00:48 +02:00
Camila
ac0c227263 Remove unused signal fileActivityButtonClicked. 
Signed-off-by: Camila <hello@camila.codes>
 2022-06-23 10:10:55 +02:00
Camila
55d6035f1e absolutePath was undefined. 
It was not part of the model, the correct one was path (PathRole).

Signed-off-by: Camila <hello@camila.codes>
 2022-06-23 10:10:55 +02:00
Camila
7744ad29a9 Remove tooltip because it is only repeating the label of the link. 
It is bad for accessibility.

Signed-off-by: Camila <hello@camila.codes>
 2022-06-23 08:56:23 +02:00
Claudio Cambra
0d26929d41 Ensure call notification stays on top of other windows 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-06-22 10:25:51 +02:00
Camila
fc2408cf41 Add contrast to the text/icon of buttons if the server defined color is light. 
Signed-off-by: Camila <hello@camila.codes>
 2022-06-21 11:49:30 +02:00
Claudio Cambra
8267136013 Rephrase button text to be in line with clients on other platforms 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-06-15 12:52:12 +02:00
Claudio Cambra
281e50f4cd Prevent call dialogs from being presented when do not disturb is set as the user status 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-06-10 11:30:16 +02:00
allexzander
d7217d1c07
Merge pull request #4622 from nextcloud/feature/generate-state-icons-from-svg 
Feature/generate state icons from svg
 2022-06-10 12:15:45 +03:00
Claudio Cambra
9dd9c46493 Do not compile things that require the app bundle when building the client without the app bundle on macOS 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-06-10 10:43:36 +02:00
alex-z
6ef296d823 Generate state icons from SVG in CMake. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-06-10 11:37:29 +03:00
Claudio Cambra
4bdfe59270 Fix builds on macOS versions pre-11 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-05-31 11:10:17 +02:00
rakekniven
276616d211 l10n: Fixed grammar 
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2022-05-30 10:12:33 +02:00
Camila
6ff82659ac Change color of text field to ncTextColor instead of ncSecondaryTextColor. 
Signed-off-by: Camila <hello@camila.codes>
 2022-05-25 12:08:53 +02:00
Camila
f911c546d9 Add a transparent background to the send reply button. 
Signed-off-by: Camila <hello@camila.codes>
 2022-05-25 12:08:53 +02:00
Camila
282aadb7e9 Reduce spacing above the notification buttons. 
Spacing is now the  same as space between lines in the text above.

Signed-off-by: Camila <hello@camila.codes>
 2022-05-25 10:01:38 +02:00
Camila
2fa834446a Fix 'TypeError: Cannot readproperty 'messageSent' of undefined'. 
Signed-off-by: Camila <hello@camila.codes>
 2022-05-24 11:51:55 +02:00
alex-z
43a37637cf Display chat message inside the OS notification. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-05-23 17:01:22 +03:00
alex-z
e40142847b Add and use DO_NOT_REBOOT_IN_SILENT=1 parameter for MSI to not reboot automatically when running from the updater. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-05-19 12:52:40 +03:00
Claudio Cambra
a2cc2ace4a Explicitly ask user for notification authorisation on launch 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-05-19 10:59:12 +02:00
alex-z
be23e747de Stretch WebView to fit dialog's height. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-05-18 10:57:10 +03:00
Matthieu Gallien
d622999971 add explicit capture for lambda 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-05-17 13:33:22 +02:00
Valdnet
f4931026d7
i18n: Add a space 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2022-05-17 09:08:37 +02:00
Valdnet
83415062ba
i18n: Change three dots to an ellipsis 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2022-05-17 09:06:20 +02:00
Claudio Cambra
2d74a5752e Fix label borking and wrong icon colours in the share dialog 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-05-16 22:59:00 +02:00
Camila
290851c33a Convert primary, WEB and DELETE notification links to action buttons. 
Signed-off-by: Camila <hello@camila.codes>
 2022-05-16 22:03:53 +02:00
Camila
9c63615a78 Do not add a second DELETE to the list of actions in one notification. 
Signed-off-by: Camila <hello@camila.codes>
 2022-05-16 22:03:53 +02:00
Claudio Cambra
31f3800d0d Fixed share link expiration box being ineditable and always reloading invalid date 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-05-16 18:51:12 +02:00
alex-z
53654b2a50 Allow manual renaming of files and folders with spaces. Allow uploading invalid file name via the InvalidFileName dialog. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-05-16 18:07:26 +03:00
Claudio Cambra
463496153a Fixed several issues with activity items relating to icon colouration and activity item sizing + layout 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-05-16 16:42:53 +02:00
Claudio Cambra
364d02a13f Actually reset menu when user accounts are added or removed 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-05-16 16:42:20 +02:00
alex-z
101a92faf3 Bugfix. Take root folder's files size into account when displaying the total size in selective sync dialog. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-05-16 17:40:30 +03:00
Claudio Cambra
b6def51945 Fix notifications not being shown when they should be 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-05-16 14:28:33 +02:00
alex-z
514f72f975 Use proper online status for user ('dnd', 'online', 'invisible', etc.) to enable or disable desktop notifications. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-05-16 10:47:05 +03:00
Camila
e4a0d57bc8
Do not replace strings in action links coming from the notification api. 
Signed-off-by: Camila <hello@camila.codes>
 2022-05-12 12:47:48 +02:00
Claudio Cambra
c22d5959b8 Reimplement notifications for macOS and add support for actionable update notifications 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-05-11 17:33:33 +02:00
Matthieu Gallien
553d324d3d only add OCS-APIREQUEST header for 1st request of webflow v1 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-05-10 09:39:35 +02:00
rakekniven
ad17d39817 l10n: Remove string from translation 
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2022-05-06 08:48:55 +02:00
Philip Allgaier
e75f37bf2e Remove "…" from "Create Debug Archive" button 
Looks like an ellipsis (as if some text is cut off), but that is not the case => clearer without the dots

Signed-off-by: Philip Allgaier <philip.allgaier@gmx.de>
 2022-05-05 22:26:58 +02:00
Claudio Cambra
cdae0a56d5 Stop dumping cache data in home dir, cache in default cache location 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-05-05 14:31:31 +02:00
rakekniven
994c2e02d8 l10n: Changed triple dot to ellipsis 
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2022-05-04 11:33:47 +02:00
Claudio Cambra
7129bf2489 Add user avatars in talk notifications in activity list 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-05-02 15:12:45 +02:00
Claudio Cambra
a5019f1f8e Add some logging 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-05-02 14:57:47 +02:00
Claudio Cambra
22e42ac6d3 Fix macOS autoupdater 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-05-02 14:57:47 +02:00
Matthieu Gallien
702e9abe4b display lock info in share dialog 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-05-02 13:52:05 +02:00
Matthieu Gallien
2d27a68e73 show errors on lock/unlock actions 
use a native dialog to show users errors when trying to lock/unlock
files

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-05-02 13:52:05 +02:00
Matthieu Gallien
b55a099b61 allow lock/unlock of files from files explorer integration 
add new commands to the contextual menu provided by our files explorer
plugins to allow locking/unlocking a file

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-05-02 13:52:05 +02:00
alex-z
7b441a0f6e Optimize activities fetch requests. Do not fetch when the Tray is not open. Fetch next subset only when scrolling. Fix duplicate notifications. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-04-29 20:59:56 +03:00
Matthieu Gallien
558c6cb1f6
adjust API of retry count to have everything private and simpler 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-04-29 12:53:38 +02:00
Matthieu Gallien
6798f2ca31
obsolete and no longer needed 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-04-29 12:31:32 +02:00
Matthieu Gallien
a6571e2d8a
improve readability of computation of currentDelay recoonect time 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-04-29 12:29:45 +02:00
Matthieu Gallien
4e348db1d0
increase time between connection tries 
each time we do a failed attempt to connect increase the time until the
next try

use an elapsed timer to ensure we do properly wait between each attempt

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-04-29 12:15:15 +02:00
Claudio Cambra
3f5243aaee Add an incoming talk call notification to the desktop client 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>

Co-authored-by: Camila <hello@camila.codes>
 2022-04-28 09:13:13 +02:00
Claudio Cambra
010f49a392
Realigned and resized thumbnails 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-04-27 18:02:37 +02:00
Claudio Cambra
15078260b4
Removed spacing between activies, labels now centre-aligned 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-04-20 18:07:41 +02:00
Claudio Cambra
7b65c1ceed
Fix thumbnails for new files made while client open 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-04-19 10:16:43 +02:00
Claudio Cambra
5ce736222e Use header text color to improve contrast with header colours when hovering on themed elements 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-04-15 13:17:09 +02:00
Camila
74d214726c
Remove unused function parameter. 
Signed-off-by: Camila <hello@camila.codes>
 2022-04-06 10:38:01 +02:00
Camila
6189b2115e
Adress design issues. 
- The input field was not using the  theming.
- After submitting the reply, the text and icon on the left were moving.

Signed-off-by: Camila <hello@camila.codes>
 2022-04-06 10:38:01 +02:00
Camila
f524635cf4
Do not hide'View chat' link. 
This logic was also hiding 'Answer call'.

Signed-off-by: Camila <hello@camila.codes>
 2022-04-06 10:38:01 +02:00
Camila
ead4eeda1e
Windows fix: activityIndex was not being passed to the lambda slot function. 
Signed-off-by: Camila <hello@camila.codes>
 2022-04-06 10:38:00 +02:00
Camila
c254572e80
Add 'Reply' as activity link instead of changing the 'View chat' link. 
- Align 'Reply' button.
- Do not display 'View chat' as a link: the 'View chat' action is active when
the user clickcs on the notification item in the tray window.
- Convert the QByteArray verb value to String.
- Handle logic to toggle the reply textfield in the QML code.

Signed-off-by: Camila <hello@camila.codes>
 2022-04-06 10:38:00 +02:00
Claudio Cambra
a2e1c68c26 Fix broken activity icon and loading entries colour in unified search 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-04-05 16:41:11 +00:00
alex-z
71b610eee3 Remove redundant _guiAppInstance 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-04-01 08:41:35 +00:00
Camila
7cc2486d79
Address PR comments. 
Signed-off-by: Camila <hello@camila.codes>
 2022-03-28 16:04:54 +02:00
Camila
9b00e5268e
Rename functions. 
Signed-off-by: Camila <hello@camila.codes>
 2022-03-28 16:04:54 +02:00
Camila
a46482ca91
Fix background color so it switches with light/dark theme. 
Signed-off-by: Camila <hello@camila.codes>
 2022-03-28 16:04:54 +02:00
Camila
0890a78262
Display input once user clicked on Reply. 
Signed-off-by: Camila <hello@camila.codes>
 2022-03-28 16:04:54 +02:00
Camila
b2056187a0
Let qml know the message reply was sent. 
Signed-off-by: Camila <hello@camila.codes>
 2022-03-28 16:04:54 +02:00
Camila
94530b6305
Rename data role. 
Signed-off-by: Camila <hello@camila.codes>
 2022-03-28 16:04:53 +02:00
Claudio Cambra
3d086ae305 Fix dark mode stuff relating to unified search, fix macOS auto dark/light theme switching not always working, fix Windows detection of dark/light theme switching 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-03-28 09:21:35 +00:00
Matthieu Gallien
99c0aadabe
ensure we only store update channel not localized in settings 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-03-23 17:35:39 +01:00
Claudio Cambra
bbd988d8c5 Fixes to UI issues 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-03-20 16:32:43 +00:00
Claudio Cambra
98e297bf0b Fix for VFS crashes 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-03-19 23:31:24 +01:00
Claudio Cambra
c342c304ac Added dark mode 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-03-18 16:43:15 +00:00
Claudio Cambra
97801a5acb Fix warn colour in dark mode 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-03-18 12:08:12 +01:00
Matthieu Gallien
541447723a remove all usage of QDateTime::toTime_t() to avoid overflow 
QDateTime::toTime_t() can overflow if called with a date outside its
domain of working

this method is obsolete and QDateTime::toSecsSinceEpoch() is the
replacement

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-03-17 23:28:02 +00:00
Camila
73bae8cd30
Add TalkReply class and tests. 
- Add struct TalkNotificationData to handle token and messageId.
- Handle chat and call notifications with the new struct.
- Add talk token and messageId to data roles in ActivityListModel.
- Add Talk Reply component to the ActivityList.
- User Loader to display the TalkReply component.
- Move Talk Reply from ActivityItem to ActivityItemContent due to PR #4186.
- Use TextField instead of Text.
- Disable send reply button instead of changing border color when field is empty.

Signed-off-by: Camila <hello@camila.codes>
 2022-03-17 17:50:33 +01:00
Claudio Cambra
628ee10008 Implement local socket to communicate with finder extension 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-03-17 11:46:57 +00:00
Claudio Cambra
65f2bada3e Add thumbnails for files in the activity view 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-03-17 10:46:09 +00:00
Claudio Cambra
f585b8bd48 Add support for server color theming by using server color as accent 
color

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-03-16 13:57:45 +01:00
Claudio Cambra
02f3a1aed6 File activity dialog now works for all file actions activities (e.g. deleted files) 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-03-16 08:38:14 +01:00
Claudio Cambra
ead4cc6fe3 Increase max line of text in activity item text to two 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-03-15 09:22:11 +00:00
Claudio Cambra
2f795df701 Ensure file activity dialog appears in centre of screen 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-03-13 22:11:26 +00:00
Matthieu Gallien
11e7ebd5fa properly ask Qt to create qml opengl surface with proper options 
should prevent context losses error with some opengl drivers

should prevent corruptions to occur with come opengl drivers

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-03-10 14:19:46 +00:00
Camila
2c20f81a53 Add 'Help' action back. 
I think it was a mistake that caused this.

Signed-off-by: Camila <hello@camila.codes>
 2022-03-03 11:16:09 +00:00
Claudio Cambra
f6b377ab17 Simplify currentScreen 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-03-02 13:37:30 +00:00
Claudio Cambra
655a2e1c39 No longer assume status bar height, calculate, fixing notch borking 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-03-02 13:22:55 +01:00
Matthieu Gallien
4371c0cbfe add headers in cmake files to get them properly detected 
qt creator for example requires that headers are explcitly given in the
source lists

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-02-11 14:31:22 +00:00
alex-z
ae44dd5978 Adjust icons for activity entries in main dialog. Refactor the dialog by splitting it to separate components. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-02-04 17:52:37 +02:00
alex-z
0776df65c3 Always build with updater. Use 'beta/stable' channel seletor in 'General Settins' dialog with default 'stable'. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-02-02 10:46:11 +00:00
alex-z
0ea7e8d3a6 Cmake option to disable proxy 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-02-02 10:02:34 +00:00
Claudio Cambra
a2524763c8
Merge branch 'master' into bugfix/account-menu-scroll 2022-02-01 17:01:51 +01:00
Claudio Cambra
ce5494b4ec Add testing for ActivityListModel 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-02-01 13:57:08 +00:00
Claudio Cambra
7a1eae45d3 Account menu can now scroll 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-01-31 15:06:55 +00:00
Claudio Cambra
624213956e Add ability to copy internal link from share dialog 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-01-24 09:40:28 +00:00
Felix Weilbach
12610baeba Replace Text with Label 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2022-01-17 11:11:57 +00:00
Felix Weilbach
f4bf4da44d Remove commented out code 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2022-01-17 11:11:57 +00:00
Felix Weilbach
99457e8c38 Use the font size that Qt suggest 
Fixes: https://github.com/nextcloud/desktop/issues/3797

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2022-01-17 11:11:57 +00:00
Claudio Cambra
2a27882307 Show only filenames in tray activity items, with full path in tooltip 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-01-14 08:02:08 +00:00
Camila
fd8186ff0e ShareDialog: group links and users in one scrollbar. 
- Remove the scrollbar used only for user shares
- Resize share dialog when removing share links
- Fix widget margins and max height of the share dialog
- slotAdjustScrollWidgetSize => adjustScrollWidgetSize

Signed-off-by: Camila <hello@camila.codes>
 2022-01-13 10:39:11 +00:00
Camila
82aed71d09 Just trying to make the sahre dialog look nicer. 
Signed-off-by: Camila <hello@camila.codes>
 2022-01-13 10:39:11 +00:00
Camila
c08a291742 Remove unused slots. 
Signed-off-by: Camila <hello@camila.codes>
 2022-01-13 10:39:11 +00:00
Camila
a10f84b5c1 Add scroll area for share links. 
Signed-off-by: Camila <hello@camila.codes>
 2022-01-13 10:39:11 +00:00
alex-z
3aaaaaf2d0 Bugfix. Re-init sharing manager to enable link sharing UI when receiving sharing permissions. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-01-13 10:42:48 +02:00
alex-z
39d1ca3a3c Fix review comments. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-01-12 10:36:25 +00:00
alex-z
39e2292acd Fix review comments. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-01-12 10:36:25 +00:00
alex-z
3d7fc166b4 Fix review comments. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-01-12 10:36:25 +00:00
alex-z
4a8433d297 Display error message when creating a link share with compromised password. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-01-12 10:36:25 +00:00
Claudio Cambra
f23c7007a5 Fix space 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-01-07 17:48:31 +00:00
Claudio Cambra
a1d42b4177 Make compiler required when option is on, removed unused def 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-01-07 17:48:31 +00:00
Claudio Cambra
8ad04f5a5e Remove AUTORCC 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-01-07 17:48:31 +00:00
Claudio Cambra
e25140d72e Add option of enabling QtQuick compiler 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-01-07 17:48:31 +00:00
alex-z
62b0a9b9f1 Try to sign-in after being signed-out due to SslHandshakeFailedError 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-01-05 10:01:13 +02:00
Claudio Cambra
8c091a2daa Hide share button for deleted and ignored files in tray activity 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2021-12-20 16:07:11 +00:00
alex-z
2482ca7ea7 Fix CMake error in ECMAddAppIcon for mac. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-12-14 17:31:21 +00:00
alex-z
3f3b752e44 Save folder settings to config when force-switching VFS. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-12-14 16:33:35 +02:00
alex-z
1244e96681 Enforce VFS. Disable 'Make always available locally'. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-12-14 15:03:57 +02:00
alex-z
77bf892809 Use different icon for a sync folder on Windows depending on zoom level. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-12-07 15:48:16 +00:00
alex-z
25785841a3 Always prefill username from Windows login name based on server version 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-12-03 11:08:35 +02:00
alex-z
b03bf1c1f0 Pass username from Windows to login page. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-11-24 10:04:22 +00:00
alex-z
b3914f627d Cleanup system bindings from Windows when removing a local sync folder 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-11-23 08:32:55 +00:00
Matthieu Gallien
684d70985e fix button that should be disabled when force VFS 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-22 14:22:59 +01:00
Matthieu Gallien
12c6d6e3bd add a network access factory to qml engine 
ensure network access made via qml are using our user agent

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-22 12:21:58 +00:00
Carl Schwan
38ac585e7c Add WheelHandler to the Search result list too 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2021-11-22 11:18:18 +00:00
Carl Schwan
892d289f38 [tray] Makes scrolling with a touchpad in activiy list more natural 
This basically use the same method that is used in Kirigami and Plasma
Components3.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2021-11-22 11:18:18 +00:00
Matthieu Gallien
f1d834df8e properly query sync journal DB to know when to run fix for VFS 
the new method added to query the db is not working and so the fix for
vfs is executed at each sync run

the new method for bool was not really needed so let's just remove it
(and that will make the usage of SqlQuery be correct

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-19 14:19:04 +01:00
alex-z
911e35bc50 Use QUrl::fromLocalFile to open local files in Unified Search results. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-11-18 09:34:54 +00:00
Felix Weilbach
c76a77e431 Correct virtual files placeholder files if needed 
In the past not all files were converted to placeholder files when
converting an existing sync folder to a virtual files folder. Because
some files were not converted to placeholder files, the status would
be wrong on the files. This code makes sure that every file in a
virtual files folder is a placeholder file. It could be removed in the
future.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-11-17 09:53:26 +00:00
Matthieu Gallien
c59f88ca82 avoid adding icon data in a cache we never use 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-16 16:11:44 +01:00
Carl Schwan
d84673376d More fixes to the menu implementation 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2021-11-16 09:27:10 +00:00
Carl Schwan
69def04ec2 Fix focus indicator 
This improve considerably the keyboard navigation in the SystemTray.
But this is still not as good as the golden standard that is recommended
by this article: https://www.sarasoueidan.com/blog/focus-indicators/

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2021-11-16 09:27:10 +00:00
Felix Weilbach
07a8e8c91d Check if the server has user status app enabled 
According to
https://docs.nextcloud.com/server/latest/developer_manual/client_apis/OCS/ocs-status-api.html#user-status-retrieve-statuses
we should check the user status capability, not the the end points.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-11-15 16:20:58 +00:00
Alexander Batischev
d8560dcb19
CMake: fail if Qt5::GuiPrivate is not found 
`nextcloud` and `nextcloudCore` depend on three Qt5 components which
aren't mentioned in `find_library`: `Xml`, `Network`, and `GuiPrivate`.
The first two are omitted by mistake, apparently, so this commit just
adds them.

`GuiPrivate` is a special case: it doesn't have its own CMake config, so
adding it to "required components" in `find_package` will always fail
the build. Thus, we implement our own check instead.

Signed-off-by: Alexander Batischev <eual.jp@gmail.com>
 2021-11-15 13:57:18 +03:00
Felix Weilbach
3e368ee4df IconJob: Send request through the accounts NAS 
This helps tracking requests on the server

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-11-10 13:11:49 +01:00
Felix Weilbach
db337c4457 Add profile page 
Fix: #3889

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-11-10 13:11:47 +01:00
Matthieu Gallien
5ab13b2adc add an option to enforce use of virtual files sync folder 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-05 16:56:24 +01:00
alex-z
2f3c58daac Fix review comments. Use QImage for QML and QPixmap for rest of code. Do not cache images for QML. Fix tests. Use signal in QML. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-11-04 20:50:51 +00:00
alex-z
0b8ab5c079 Use SvgRenderer for Unified Search input icons. Refactor IconUtils. Extend unit tests. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-11-04 20:50:51 +00:00
alex-z
0d8375e798 Clear Unified Search Input Field in a proper way 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-11-04 20:50:51 +00:00
Felix Weilbach
d661e91a58 Don't do a connection checks when using push notifications 
When using push notifications, it is not necessary to do regular
connection checks because the push notifications will take care of it.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-11-04 18:07:22 +00:00
Matthieu Gallien
9658aea963 on switch to VFS real plugin, convert existing files to placeholders 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-04 15:02:27 +01:00
alex-z
d88e086b94 ShareLinkWidget. Fix incorrect calendar mindate. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-11-03 13:23:00 +02:00
alex-z
6c3c45dadd Implement expiration date for federated shares 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-11-03 10:54:18 +00:00
alex-z
c52718c104 Replace deprecated QRegExp with QRegularExpression. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-11-02 08:54:06 +00:00
Matthieu Gallien
8226c30d84 by default we produce debug logs because we need them 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-28 13:48:55 +00:00
Camila
d68b8604ac Refactor toggleButtonAnimation function. 
Signed-off-by: Camila <hello@camila.codes>
 2021-10-28 12:59:28 +00:00
Camila
ab524d2392 Fix display of deleted note. 
Even after removing note from share link,
the previous text was being displayed.

Signed-off-by: Camila <hello@camila.codes>
 2021-10-28 12:59:28 +00:00
Camila
72c91362f2 Refactor ShareLinkWidget show/hide widgets functions. 
- Remove unecessary call to setupUiOptions after saving share password.
- Slot to create label: do not set it if nothing changed.
- Refactor showPasswordOptions, toggle/PasswordOptions/ExpireDateOptions/NoteOptions.
- Add const, auto and {} whenever possible.
- Refactor slotToggleButtonAnimation => toggleButtonAnimation.

Signed-off-by: Camila <hello@camila.codes>
 2021-10-28 12:59:28 +00:00
alex-z
db4e54025a Forbid trusting the untrusted certificate. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-10-27 07:23:42 +00:00
alex-z
907ebc1959 Request OCSP validation data from the server during the SSL handshake. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-10-27 07:23:42 +00:00
rakekniven
c39b97adb3
Update UnifiedSearchInputContainer.qml 
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2021-10-26 10:44:07 +02:00
rakekniven
beffd63512
Changed triple dot to ellipsis 
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2021-10-26 07:35:47 +02:00
Matthieu Gallien
69d6f4acec our source code files have lower case names 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-25 15:38:21 +02:00
alex-z
c1dab7e4cb Unified Search via Tray window 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-10-25 14:45:05 +03:00
rakekniven
91884eef4a Changed wording to suggestion 
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2021-10-23 07:06:23 +00:00
rakekniven
fb3c740129 Changed wording of status message 
The files themselves have no problem. The sync process has problems. 

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2021-10-23 07:06:23 +00:00
Felix Weilbach
9f35fa6d3d Also update sync state summary based on connectivity 
Otherwise, with zero folders configured, the state will stay at
offline.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-10-20 12:31:55 +02:00
alex-z
bd731a9cda Windows. Remove CWD from DLL search paths. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-10-19 06:40:56 +00:00
Felix Weilbach
d51bfec61d Remove unnecessary braces 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-10-14 19:56:39 +00:00
Felix Weilbach
f27ef02273 Set dialog max and min width and height before width and height 
Otherwise, resize events will not be processed correctly.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-10-14 19:56:39 +00:00
Felix Weilbach
0792dc36c2 Check if current user exists before getting it's account state 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-10-13 11:25:13 +02:00
Felix Weilbach
4c11f6763e Show sync progress in main dialog 
Fixes #3662

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-10-12 16:14:24 +00:00
Matthieu Gallien
d76778e3ee fix macOs build after targets name are not changed by branding 
target names used to be variable depending on branding
now the target names are always constant but generated output file names
are set according to active branding

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-11 07:41:29 +00:00
Felix Weilbach
2da6dab403 Add missing copyright headers 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-10-08 13:19:10 +02:00
Kevin Ottens
5fe63a4d9a Display the right endpoint in the warning in case of error 
At that point in time _pollEndpoint isn't set yet. All the checks are
against pollEndpoint so display that one in the warning. Otherwise one
always end up with an empty URL in the logs which is not very useful for
debugging purposes.

Signed-off-by: Kevin Ottens <kevin.ottens@enioka.com>
 2021-10-06 10:17:38 +00:00
Matthieu Gallien
833237b2e4 use alias target for internal libraries 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-10-06 07:56:33 +00:00
Felix Weilbach
0c9dce1154 Add file activity dialog 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-10-05 12:41:34 +00:00
Camila
df38e5c08b Apply server default permissions for federated file sharing too. 
See nextcloud/server#24729 comments.

Signed-off-by: Camila <hello@camila.codes>
 2021-09-27 08:53:45 +00:00
Camila
8f847906c6 Check server capabilities for file sharing default permissions. 
Signed-off-by: Camila <hello@camila.codes>
 2021-09-27 08:53:45 +00:00
rakekniven
68e02bc62d Fixed context 
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2021-09-27 07:25:08 +00:00
rakekniven
49e1b12eb1 Fixed grammar 
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2021-09-27 07:25:08 +00:00
Felix Weilbach
d3d8b1c631 Add dialog to resolve invalid filenames 
Fixes #3751

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-23 10:45:15 +00:00
Matthieu Gallien
ac28cc1cf5 set default format for QSurface to handle NVidia context loss events 
should fix wrong OpenGL rendering after suspend on Linux with NVidia
binary OpenGL driver

close #3759

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-09-22 08:56:16 +00:00
alex-z
59199fc907 General Settings window. Allow opening the update URL via mouse. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-09-21 16:21:38 +02:00
Camila
db447c4676 Refactor OcsShareJob creation. 
Signed-off-by: Camila <hello@camila.codes>
 2021-09-21 10:01:20 +00:00
Camila
ba8ec56e65 Add option to create label for share link. 
Signed-off-by: Camila <hello@camila.codes>
 2021-09-21 10:01:20 +00:00
Matthieu Gallien
19b77416da TextInput by default do not allow selecting text by mouse 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-09-21 08:07:19 +00:00
Felix Weilbach
0074d6c40a Disable Qt deprecation warnings 
They don't help us during regular development and some of them are not
fixable (e.g. QNetworkMangerConfiguration) in the open source variant
of Qt5.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-17 13:32:26 +00:00
Felix Weilbach
fb1b3481d1 Fix warnings 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-17 13:32:26 +00:00
Camila
e4e74ff38f Display share note when there is one associated with a share link. 
Signed-off-by: Camila <hello@camila.codes>
 2021-09-17 06:57:08 +00:00
Camila
4581279d23 Fix indentation sharelinkwidget.h. 
Signed-off-by: Camila <hello@camila.codes>
 2021-09-17 06:57:08 +00:00
Felix Weilbach
8370c9c1ca Accept nc scheme in provider page 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-14 09:01:18 +00:00
Felix Weilbach
9aee46b3a4 Remove unnecessary logging statements 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-14 07:26:46 +00:00
Valdnet
a441d733dc l10n: Correct two typo 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-09-10 12:25:34 +02:00
Felix Weilbach
8a8d488454 Add dialog to set user status 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-09 11:18:22 +02:00
alex-z
4018f8d554 Prompt reboot when runing the auto update. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-09-09 07:20:19 +00:00
Felix Weilbach
5622c33f40 Fix various deprecated warnings 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-08 08:54:00 +00:00
Felix Weilbach
b6e3c6d718 Replace deprecated use of QProcess::start() 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-08 08:54:00 +00:00
Felix Weilbach
6fd0adda52 Close wizard if done 
This is needed because of the changes in 02bb5db544

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-07 06:43:27 +00:00
allexzander
a3fc812539 Enable share to Talk and Email. Display correct icon. Added unit tests. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-09-06 13:27:39 +00:00
Hannah von Reth
02bb5db544 Remove wizard page that has been dead for 4 years 2021-09-03 16:08:37 +02:00
Felix Weilbach
fa37f5c2bc Don't create binding loop 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-03 11:48:42 +00:00
Felix Weilbach
8a2097e7b9 Implicitly defined onFoo properties in Connections are deprecated 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-03 11:48:42 +00:00
Felix Weilbach
ba2d8e8201 Only set dav user after login. 
Setting the credentials of the account inside the auth widget is not a
good idea as that will destroy the previous credentials object which
may wait for a signal to be emitted by the credentials dialog that
was created by the credentials that are going to be deleted. Uff.

It should be enough to set the dav user only after login because the
dav user will never change.

See also the discussion here
https://github.com/nextcloud/desktop/issues/3677#issuecomment-907976839

Fixes #3677

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-09-03 08:32:15 +00:00
Nicolas Fella
bc3eb7845d Remove unneeded target_link_libraries 
OS_SPECIFIC_LINK_LIBRARIES is always empty here

Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
 2021-09-01 11:43:03 +00:00
Nicolas Fella
18ddb9df4a Use CMAKE_INSTALL_DATADIR instead of custom DATADIR 
CMake provides what we wan out of the box

Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
 2021-09-01 11:43:03 +00:00
Heinz Wiesinger
727de34879 Allow using rsvg-convert to generate pngs instead of inkscape 
Signed-off-by: Heinz Wiesinger <pprkut@liwjatan.org>
 2021-08-31 14:52:46 +02:00
Matthieu Gallien
25669938fd let clang-tidy add missing override after enabling again the check 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-08-31 08:35:56 +00:00
Felix Weilbach
44df9283fe Handle every enum value in switch statement 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-08-26 15:52:25 +00:00
Matthieu Gallien
23bd4675fd fix build socket api Mac specific file is now in a subdirectory 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-08-25 14:02:05 +00:00
Valdnet
86cb56757e l10n: Remove line break 
A line break is unnecessary in this message.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-08-25 09:11:06 +00:00
Hannah von Reth
c273c8f71b Ensure the socket listener still exists 2021-08-23 09:44:34 +02:00
Hannah von Reth
4b0122093a Add socket command to upload a selection of files based on a regex 
(cherry picked from commit 0ded3a56a9f3470a951b18eaa9d3c1b5e8db1135)
 2021-08-23 09:44:34 +02:00
Hannah von Reth
010fccb4fa Remove dead code 2021-08-23 09:44:34 +02:00
Christian Kamm
ebaa98fa7a owncloudcmd: Use env vars for chunk sizes #7078 
Moves a bunch of env var reading from Folder into SyncOptions.
 2021-08-23 09:44:34 +02:00
Hannah von Reth
5b457a1663 Use byte array for etag 2021-08-23 09:44:33 +02:00
Hannah von Reth
d16befd1fd Align MkColJob finish signal with the other jobs 2021-08-23 09:40:27 +02:00
Hannah von Reth
c4f4fb48a4 Minor cleanup of socket api 2021-08-23 09:40:27 +02:00
Hannah von Reth
baa571018e Log invocation, useful for debugging startup issues 2021-08-23 09:40:27 +02:00
Nicolas Fella
43cccb0a73 Don't use variables for CMake target identifiers 
This makes the code a bit nicer to read and maybe a bit more robust.

Set the relevant OUTPUT_NAME target properties to keep the ability to
customize the names of the installed binaries.

Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
 2021-08-19 10:30:23 +00:00
Felix Weilbach
d706125b15 Return the login name instead of user id 
App password and login name need to match. If authResult() returns the
user id the user id will be stored in webdav_user

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-08-12 14:32:07 +02:00
Felix Weilbach
ccd27870a7 Don't compare integers with different signs 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-08-11 20:20:39 +00:00
Felix Weilbach
acf6cc0527 Remove unused functions and variables 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-08-11 20:20:39 +00:00
Felix Weilbach
d72f7e9109 Check result of setPinState() 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-08-11 20:20:39 +00:00
Felix Weilbach
f9daa27a5d Enforce fetching of user id 
With the change of commit 3e61bdc431 and
the relase of v3.3.0 users that had their email address used as login
are not able to login anymore. The dav_user should be empty if users
tried to create a account in the meantime. Therefore we fetch the user
id in the case dav_user (and then Account::_davUser) is empty. We then
store the user id in dav_user.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-08-11 16:16:12 +00:00
Felix Weilbach
5195264a20 Ensure that the users id is used for accessing webdav 
https://docs.nextcloud.com/server/latest/developer_manual/client_apis/LoginFlow/index.html#obtaining-the-login-credentials
states that the email address can be used for login but it's not
allowed to use the email address to access webdav.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-08-11 15:26:39 +02:00
allexzander
c930d8e30f Delete apptoken after account removal. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-08-04 09:37:40 +00:00
Valdnet
dbd061c44b l10n: Replace apostrophe with double quotation. Remove double space and sort sentence. 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-08-03 15:00:53 +03:00
allexzander
fc75b94524 Fix clang-tidy errors. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-07-30 06:21:05 +00:00
Valdnet
7ebbb499e0 l10n: Replace apostrophe with double quotation 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-07-30 06:21:05 +00:00
Felix Weilbach
7bb0c588c1 Don't constrain size of hover background 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-07-28 10:29:04 +00:00
allexzander
98ae715905 Fix crash in Folder::isSyncRunning() 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-07-28 08:58:00 +00:00
Valdnet
9dee4b1a7a
Merge branch 'master' into Valdnet-patch-3 2021-07-23 09:07:18 +02:00
Valdnet
bc9d3c5936 l10n: Change to uppercase 2021-07-22 15:47:52 +00:00
Valdnet
7db51e9029 l10n: Change to uppercase 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-07-22 15:47:52 +00:00
Felix Weilbach
a421ebf01c Make main dialog normal window when displayed as regular window 
This will enable users to minimize the dialog.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-07-22 10:34:13 +02:00
Felix Weilbach
302651620b Use Q_UNUSED instead of commenting out arg names 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-07-21 17:15:11 +00:00
Felix Weilbach
3f6bb4a929 Use QStringLiteral instead of plain strings 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-07-21 17:15:11 +00:00
Felix Weilbach
ee49a7ed52 Fix review comments 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-07-21 17:15:11 +00:00
Felix Weilbach
e4f92ad1a1 Enforce https in flow1 and flow2 for https connections 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-07-21 17:15:11 +00:00
Camila
6886d6213a
Add custom component ActivityItem. 
That also addresses QML warnings.

Signed-off-by: Camila <hello@camila.codes>
 2021-07-21 17:03:26 +02:00
Camila
79dd4f73fe Fix QML warning: Unable to assign [undefined] to QFont. 
Signed-off-by: Camila <hello@camila.codes>
 2021-07-21 14:46:04 +00:00
Matthieu Gallien
a8ef8bdcb8 do not block account menu: availability checking can be slow 
ignore availability that can be very slow to check with CfApi virtual
files plugin

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-07-21 12:58:23 +00:00
allexzander
801e4ad363 Create QMessageBox on heap when the update is ready. Do not return true from OCUpdater to allow for a proper app::quit 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-07-21 14:23:43 +03:00
Felix Weilbach
4e95e32791 Call setClosed() on correct Object 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-07-20 12:56:00 +02:00
Felix Weilbach
89fea30a3b Remove Q_INVOKABLE from signals because it's not needed 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-07-20 12:55:37 +02:00
Felix Weilbach
12bdd8742b Remove unnused variable 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-07-20 07:43:36 +00:00
Felix Weilbach
38467b2e30 Remove unused pushNotifications variable 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-07-20 07:43:36 +00:00
Matthieu Gallien
064f64f06d fix width of user status message to not overlap other elements 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-07-16 15:19:20 +00:00
Matthieu Gallien
260e1d77f5 clean indentation in UserLine.qml 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-07-16 15:19:20 +00:00
Matthieu Gallien
c2602135ab fix size of the Label with user status 
ensure the label width is not higher than the parent to ensure log
string get elided as expected

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-07-16 13:04:33 +00:00
Felix Weilbach
3e61bdc431 Use dav instead of webdav 
Fixes #3342

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-07-16 12:42:02 +00:00
allexzander
de627a9b7c Remove request to config for userVisibleURL. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-07-16 06:45:41 +00:00
Felix Weilbach
036db9d22d Position main dialog on at tray icon if not a regular window 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-07-14 18:27:50 +02:00
Felix Weilbach
efaccbd6fd Show main dialog as normal window if tray icons not available 
Fixes #3307

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-07-12 14:10:26 +00:00
Matthieu Gallien
c27fc1be4a use fallback icons for activities without icons 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-06-30 11:28:13 +00:00
Matthieu Gallien
269d225511 directly send the icon url for activities to teh qml component 
should allow usage of default cache from Image qml standard component

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-06-30 11:28:12 +00:00
Felix Weilbach
015a5ae235 Don't display account name in italic 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-06-25 20:13:06 +00:00
Felix Weilbach
40065dc6dc Disable QtWebEngine automatic if not found 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-06-24 15:43:51 +00:00
Felix Weilbach
991f79c123 Open provider page in browser when compiling without webengine 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-06-24 15:43:51 +00:00
Felix Weilbach
8376b99ec5 Allow to compile without QWebEngine 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-06-24 15:43:51 +00:00
Felix Weilbach
216a57c74e Remove dead code 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-06-24 15:43:51 +00:00
Felix Weilbach
cb5e8398c4 Fix review comment 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-06-21 12:04:11 +02:00
Felix Weilbach
ab9784374f Fix review comments 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-06-21 12:04:11 +02:00
Felix Weilbach
52342e5710 Prevent crash in dialog that warns user about vfs and e2ee 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-06-21 12:04:03 +02:00
Valdnet
33bdfe687f l10n: Spelling unification 
Spelling unification in Transifex.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-06-17 12:18:00 +00:00
Camila
7ddc4ca170 Remove extra RowLayout. 
Signed-off-by: Camila <hello@camila.codes>
 2021-06-16 07:55:33 +00:00
Camila
449fda16e1 Fix QML Warning: ReferenceError: PopupMenu is not defined. 
Signed-off-by: Camila <hello@camila.codes>
 2021-06-16 07:55:33 +00:00
Camila
19e581657d Fix QML warning: Cannot specify left, right... anchors for items inside Row. 
Signed-off-by: Camila <hello@camila.codes>
 2021-06-16 07:55:33 +00:00
Camila
5585f61cc0 Fix QML warning: Detected anchors on an item that is managed by a layout. 
Signed-off-by: Camila <hello@camila.codes>
 2021-06-16 07:55:33 +00:00
Camila
c8edb11228 Fix QML warning: Accessible must be attached to an Item. 
Signed-off-by: Camila <hello@camila.codes>
 2021-06-16 07:55:33 +00:00
Felix Weilbach
7850551cad Start macOS app bundle name with uppercase letter 
It's a convention on macOS that app bundle names start with an uppercase
letter. Also this aligns the app name with Windows and Linux.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-06-15 12:19:55 +00:00
allexzander
a3d12a616b Add error message to GUI. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-06-15 14:33:45 +03:00
Felix Weilbach
d4b0273792 Generate application png icons from svg icons 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-06-14 10:14:28 +00:00
Felix Weilbach
e7c65a71b8 Remove conditional logic for OEM.cmake 
This file is not used in Brander and in the desktop client and just
confused people.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-06-14 10:14:28 +00:00
Felix Weilbach
03610cb706 Set button on QMessageBox before changing the text 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-05-27 07:39:50 +00:00
Camila
f758157973 Fix aligment emoji + message on Windows. 
Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:53 +00:00
Camila
8d2264e027 Display the user status emoji separated from the message. 
It allows to align the emoji with the message.

Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:53 +00:00
Camila
1cb7f63575 Remove signal refreshCurrentUserGui. 
Use only QML property bindings to refresh the UI.

Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:53 +00:00
Camila
46f7cd3884 User property isConnected instead of a invokable. 
Remove unnecessary connection to refreshCurrentUserGui signal.

Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:53 +00:00
Camila
1adde8d547 serverUserStatus => serverHasUserStatus. 
Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:53 +00:00
Camila
2caa9ccfc6 Add Q_UNREACHABLE() after switch statements in UserStatus. 
Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:53 +00:00
Camila
73da14040b Rename ServerUserStatusRole to ServerHasUserStatusRole. 
- serverHasUserStatus Q_PROPERTY is CONSTANT.
- Fix code style.

Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:53 +00:00
Camila
828881d82a Do not display the folder status if there are no folders being synced. 
Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:53 +00:00
Camila
4326eb53ba Fix margins and sizes to align both avatar + user status displays. 
Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:52 +00:00
Camila
dc01b76066 Fix code style. 
Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:52 +00:00
Camila
93227ab08b Check if new value is different from the current one. 
In AccountState::setDesktopNotificationsAllowed.

Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:52 +00:00
Camila
f7e9e31bc9 Rename isDesktopNotificationsAllowed property to desktopNotificationsAllowed. 
- User !== instead of !=.
- Fix code style.

Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:52 +00:00
Camila
820e97cd9b Do not display the user status if there is no pre defined message. 
Display the server url instead.

Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:52 +00:00
Camila
c793cbe593 Always display the server url in the drop down account menu. 
Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:52 +00:00
Camila
419595ce5e Use DesktopNotificationsAllowedRole to check if user is online. 
Rename ServerUserStatus to ServerUserStatusRole.

Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:52 +00:00
Camila
bd65eee278 Remove unused methods in UserModel. 
Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:52 +00:00
Camila
671b099c98 Check if the user is connected and if the server supports user status. 
Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:52 +00:00
Camila
e3b96ddc85 Move stringToEnum and enumToString to an anonymous namespace. 
Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:52 +00:00
Camila
1f61d258bb Fix user status message alignment. 
Signed-off-by: Camila <hello@camila.codes>
 2021-05-25 06:55:52 +00:00
rakekniven
793c211232
Merge branch 'master' into Valdnet-patch-3 2021-05-20 07:47:17 +02:00
Felix Weilbach
32b7e62359 Warn user if using e2ee and vfs together 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-05-18 11:50:18 +00:00
Valdnet
a3b2dc669c
One more apostrophe change 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-05-12 12:45:33 +02:00
Valdnet
dadddd7ea2 l10n: Replace apostrophe with double quotation 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-05-12 12:34:22 +02:00
allexzander
bbf11d7e7a Temporary! Windows. VFS. Block Virtual Files for partition root sync folders. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-05-11 18:53:35 +03:00
Matthieu Gallien
54d91cdd7b also update ownCloud years interval in copyright notice 
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
 2021-05-10 10:29:22 +00:00
Matthieu Gallien
86dda5675f send OS name and version to auto updater to allow selective upgrades 
in order to be able to suuport legacy OS, also sends the OS name and
version

will be used to detect Windows 8.1 and similar legacy versions

Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
 2021-05-06 09:32:09 +00:00
Hannah von Reth
adb56178b9 GetLastError() needs to be called when the error happens 
qDebug might clear it already

Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
 2021-05-06 07:35:59 +00:00
rakekniven
6d23e93d31
Changed copyright year to 2021 
Fix for #3258 

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2021-05-05 13:37:31 +02:00
Felix Weilbach
aadee15008 Fallback to primary screen if screen under pointer not found 
Fixes #3252

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-05-05 11:56:46 +02:00
rakekniven
33ef3a1d1e
Merge branch 'master' into rakekniven-patch-2 2021-04-30 14:38:23 +02:00
Valdnet
dc6518a4ee
l10n: Translation of ellipse 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-04-30 13:57:02 +02:00
rakekniven
0e12b0323e
No need to translate ellipsis 
Here another PR for the same code line as #3238 

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2021-04-30 13:27:18 +02:00
Valdnet
f431649bad l10n: Change to an ellipsis 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-04-30 08:19:25 +00:00
allexzander
e72013fed1 Fix Felix's comments. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-04-29 07:43:21 +00:00
allexzander
19e2d70c53 Final corrections and refactoring. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-04-29 07:43:21 +00:00
allexzander
deb9ba89f0 Only show password option for email shares. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-04-29 07:43:21 +00:00
allexzander
526fa399dc Fix review comments. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-04-29 07:43:20 +00:00
allexzander
c908183044 Use separate progress indicator for password and replace a button with it while running. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-04-29 07:43:20 +00:00
allexzander
0072d39ca0 Fix review comments. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-04-29 07:43:20 +00:00
allexzander
2d88fc6c99 Obey enforced password for share by email. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-04-29 07:43:20 +00:00
Valdnet
8aedc74838 l10n: Delete space and change capital letter 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-04-28 11:41:06 +00:00
allexzander
e7e5542d3e Improve public link sharing UI. Fix UX issues. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-04-27 13:51:52 +03:00
Felix Weilbach
9a88e38121 Call finish() if going to remove all files 
While investigating #3172, I discoverd that the sync will hang forever
if the user has deleted all files on the server. Calling the callback
resolves the problem.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-04-26 12:50:14 +00:00
Valdnet
796b4e4e72 l10n: Change to an ellipsis 
Reported on Transifex.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-04-22 07:40:15 +00:00
Felix Weilbach
275e46f0db Show progess indicator 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-04-20 07:13:23 +00:00
Felix Weilbach
c3fac23903 Don't delete note and expiration date on toggle 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-04-20 07:13:23 +00:00
Felix Weilbach
8711d5bf49 Don't use unnecessary layout element 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-04-20 07:13:23 +00:00
Felix Weilbach
2851528595 Show user/group note on share if already set 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-04-20 07:13:23 +00:00
Felix Weilbach
22a3b19e08 Add expire date to user and group share 
Fixes #3100

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-04-20 07:13:23 +00:00
Felix Weilbach
946a51e4c1 Add note to user and group share 
Fixes #3104

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-04-20 07:13:23 +00:00
Matthieu Gallien
20357ca7fa Revert "Add CMake option to enable address sanitizers" 
This reverts commit 3000e26640.

This was not intended for a direct push

Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
 2021-04-19 17:54:09 +02:00
Felix Weilbach
3000e26640 Add CMake option to enable address sanitizers 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-04-19 15:38:59 +02:00
allexzander
d65c91ea36 Display VFS sync folder within the navigation panel on Windows. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-04-16 07:18:44 +00:00
Nicolas Fella
2548455f45 Copy FindSharedMimeInfo from ECM 
Instead of relying on ECM being installed.

We copy other stuff from ECM so be consistent.

Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
 2021-04-15 14:32:46 +00:00
rakekniven
03e7d8da28
Merge branch 'master' into patch-1 2021-04-14 17:11:27 +02:00
Nicolas Fella
70033cda1f Use imported target for Threads 
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
 2021-04-14 11:07:04 +00:00
castillo92
98a4bb8cce
Update sharedialog.cpp 
The original sentence uses the word "share" three times and is too redundant when translated into other languages
 2021-04-14 09:24:35 +02:00
Felix Weilbach
696979cb0e Display invalid filenames as warning 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-04-13 14:58:51 +00:00
Felix Weilbach
b736355985 Add notification cache 
The notification cache helps to not display duplicate desktop
notifications to the user.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-04-13 14:58:50 +00:00
Felix Weilbach
b256c6e694 Ping websocket server 
This helps the client to recognize if the websocket server is still alive.

Fixes #2983

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-04-13 12:19:40 +00:00
Valdnet
e628a51735 l10n: Unify spelling 
Spelling unification in Nextcloud applications.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-04-13 12:24:57 +02:00
Nicolas Fella
b34a901838 Use FindPkgConfig to find libcloudproviders and related libs 
Instead of using custom find modules.

This allows using imported targets which make the code much nicer.

Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
 2021-04-12 10:00:08 +00:00
Felix Weilbach
c49dc440bb Embed version and icon into windows executable 
These changes are necessary because of changing the compilation
process for the gui from a single executable to static lib +
executable in commit 0521dce174.
Otherwise the version and icon information will be lost.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-04-09 13:53:12 +02:00
Camila
1ca0ea49dd Remove unnecessary local variable. 
Signed-off-by: Camila <hello@camila.codes>
 2021-04-08 07:10:59 +00:00
Camila
29f4a3857b Reposition qml elements for the folder status icon. 
Signed-off-by: Camila <hello@camila.codes>
 2021-04-08 07:10:59 +00:00
Camila
050bd49373 Rename enumToUserString => enumToString. 
Signed-off-by: Camila <hello@camila.codes>
 2021-04-08 07:10:59 +00:00
Camila
8986975a17 Use enum class instead of enum. 
Signed-off-by: Camila <hello@camila.codes>
 2021-04-08 07:10:59 +00:00
Camila
50de12b3c3 Undo unnecessary removal of lines. 
Signed-off-by: Camila <hello@camila.codes>
 2021-04-08 07:10:59 +00:00
Camila
163015492a Fix #3067: missing apps icon. 
Signed-off-by: Camila <hello@camila.codes>
 2021-04-08 07:10:59 +00:00
Camila
c8ac99c8cf Align status text with server url. 
Cleans the space in the beginning of the string when there is no emoji
set.

Signed-off-by: Camila <hello@camila.codes>
 2021-04-08 07:10:59 +00:00
Camila
e51dad79a2 Refactor UserStatus. 
- Make preDefinedStatus a local var.
- Add function to get the status user string.

Signed-off-by: Camila <hello@camila.codes>
 2021-04-08 07:10:59 +00:00
Camila
d2b762aa66 Move curly brackets to the correct line. 
Signed-off-by: Camila <hello@camila.codes>
 2021-04-08 07:10:59 +00:00
Camila
98cfc362f7 Remove const and reference of base types. 
Signed-off-by: Camila <hello@camila.codes>
 2021-04-08 07:10:58 +00:00
Matthieu Gallien
d6752c96b1 use QFileInfo to check if path is absolute to avoid assert on windows 
on windos absolute path does not have to start with / . Remove failing assert
when editing ignored files list.

Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
 2021-04-07 07:40:07 +00:00
allexzander
e15045977e Reduce Socket API logging. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-04-06 09:34:20 +03:00
Felix Weilbach
b2377ff64f Remove html tags from strings that may appear in notifications 
The content of notifications on MacOS are not allowed to contain HTML
tags in it. Linux (Free Desktop) notifications may contain HTML tags
in their content. However, it is optional that the notification daemon
interprets the tags. The GNOME notification daemon does not interpret
HTML tags and even does not strip them off. KDE's daemon interprets
the tags. For now I think it's the best solution to remove the HTML
tags. In the future we should fire a action if the user clicks on the
notification and react on it and open the link then. This should work
on all platforms. But as this change involves working with the native
MacOS api and I don't have hardware for that at the moment for that I
will postpone it.

Fixes #2200

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-03-31 16:23:42 +02:00
Felix Weilbach
354f4c02ee Don't deploy bearer plugin on MacOS 
Fixes #2944, #2237

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-03-29 13:46:07 +00:00
Camila
9219926a74
Add checks in case userStatus is not available/fails on the server side. 
Signed-off-by: Camila <hello@camila.codes>
 2021-03-24 15:42:26 +01:00
Camila
d9a0778e52
Add UserStatus enum with the pre defined status. 
- User QHash to map status strings and Status enum.

Signed-off-by: Camila <hello@camila.codes>
 2021-03-24 15:41:31 +01:00
Camila
974e2fb718
Do not display notifications when user status is do not disturb. 
- This information is retrieved from the notifications endpoint.
- Add icons for the different pre defined status.
- Make functions available to QML to decide which status icon to display.
- Display the user status icon on the avatar and
move the online/offline connection status to the folder icon.

Signed-off-by: Camila <hello@camila.codes>
 2021-03-24 15:40:05 +01:00
Camila
f4d8699db8
Add UserStatus class to retrieve the user status. 
- AccountState controls UserStatus.
- Display user status in the system tray menu next to user's avatar.

Signed-off-by: Camila <hello@camila.codes>
 2021-03-24 15:39:13 +01:00
Valdnet
519dee9104 l10n: Change sync message #3027 2021-03-24 13:13:40 +00:00
allexzander
193e50311b Refresh Windows download dialog progress when hydrating a placeholder 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-03-24 14:09:06 +02:00
Felix Weilbach
c296a93cee Enable high dpi scaling on all platforms 
Fixes #2295, #1079, #914

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-03-23 08:36:11 +00:00
Felix Weilbach
f4853da2ab Fix crash when trying to open the folder creation dialog 
The bug does seem to just appear in special compiler
constellations. We're unsure why this fix works. To better see if this
fix works or if crashes still occur, we added some logging.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-03-17 08:43:32 +01:00
Felix Weilbach
ff7932bb54 Display the content of the login dialog correct 
This adjustment is necessary because of the changes of the new account
wizard that were introduced with:
e0b7ef15b2

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-03-16 13:34:34 +00:00
Kevin Ottens
7ad0208800 Finish cleaning up shibboleth 
There were a couple of shibboleth related enums left, since that auth
method isn't supported anymore remove the code tied to those enums. It
was dead code anyway.

Signed-off-by: Kevin Ottens <kevin.ottens@enioka.com>
 2021-03-15 09:38:15 +00:00
Felix Weilbach
cdc2e4c56e Don't customize settings dialog palette 
Customizing of the palette will prevent the settings dialog from
display a dark theme correct.

Fixes #2993

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-03-12 11:47:16 +01:00
Felix Weilbach
e3ac63e9ff Rename isActivityIgnored() to isUnsolvableconflict() 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-03-11 09:42:38 +00:00
Felix Weilbach
05d31e2e53 Split content of User::isValueableActivity() 
Refactoring of User::isValueableactivity() because of changes
introduced with merge commit f17c52d.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-03-11 09:42:38 +00:00
Felix Weilbach
e0b7ef15b2 Restyle wizard pages 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-03-10 09:55:40 +01:00
Felix Weilbach
f55e5b1885 Restyle wizard 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-03-10 09:55:40 +01:00
Felix Weilbach
9185956069 Split out wizard welcome page 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-03-10 09:55:40 +01:00
István Váradi
2e7cc96228 Do not include glib.h with extern C (2) 
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu>
 2021-03-10 07:48:23 +01:00
István Váradi
db321d25ef Do no include glib.h with extern C 
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu>
 2021-03-09 10:29:14 +01:00
Felix Weilbach
63dbb90bbd Iteration 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-03-05 11:32:44 +00:00
Felix Weilbach
ef5abac567 Fix crashes with conflict dialog 
When the client runs and a conflict gets detected, the sync engine runs
two times.

On the first run, the sync engine detects the conflict, marks the
file as a conflict and propagates that to the GUI. This leads to an
error notification with the original filename in the main dialog.

The sync engine runs then a second time. On this second run, the file
that originally caused the conflict is not anymore a conflict
file. Instead, the sync engine detects the conflicted copy and
propagates that file as a conflict to the GUI.

When opening the conflict dialog with the original file name (not the
conflicted copy) a crash happens. Usually, the two sync runs are really
fast, so the user does not notice the first notification. However, a
problem can occur if a conflict gets created while the client is not
running. Since then, the client does not do two sync runs. It does only
run once.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-03-05 11:32:44 +00:00
allexzander
88a21c0665 Do not add debug build to startup programs. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-02-18 13:19:06 +00:00
Felix Weilbach
29e1a82f56 Add missing override specifer to WebFlowCredentials 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-02-13 10:22:01 +00:00
Felix Weilbach
74d07e28cf Validate the providers ssl certificate 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-02-12 08:25:59 +00:00
allexzander
013f3cea70 Validate sensitive URLs to onle allow http(s) schemes. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-02-09 15:00:35 +02:00
allexzander
e97b7d8a25 Default parameter nullptr widget for openBrowser. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-02-09 08:40:51 +00:00
István Váradi
92f1074fcc Put FolderCreationDialog into the OCC namespace. 
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu>
 2021-02-05 16:27:25 +01:00
allexzander
81a090b362 Allow creation of new folders from the Settings Dialog. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-02-04 10:05:18 +02:00
Kevin Ottens
55fd0562de
Load the theme resource explictly 
Otherwise they won't be loaded automatically at startup leading to lots
of missing icons. Since they're now in a static library they need that
explicit loading.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2021-02-02 18:33:45 +01:00
Felix Weilbach
d8493a9b3b Add automoc property to updater 
Signed-off-by: Felix Weilbach <felix.weilbach@t-online.de>
 2021-02-02 13:35:04 +00:00
Felix Weilbach
73a41d8e34 Compile nextcoud gui as separate library 
Compiling nextcoud gui as a separate library. This is needed to more
easily write tests. The whole nextcloud application can now be linked
against the tests.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-02-02 13:35:04 +00:00
allexzander
8c4d5333c1 Use push notifications for Tray activities/notifications fetch trigger. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2021-01-27 19:53:28 +02:00
Felix Weilbach
51d8cf8102 Start file conflict resolve dialog asynchronous 
Fixes #2804

Signed-off-by: Felix Weilbach <felix.weilbach@t-online.de>
 2021-01-27 08:01:25 +00:00
Valdnet
d8a88fd047 Replace dots with ellipses and add spaces. 2021-01-27 07:36:52 +00:00
Valdnet
817d460b84 Move space in "owncloudadvancedsetuppage.cpp" 2021-01-26 16:40:46 +00:00
Kevin Ottens
4168c0d082 Avoid keeping Account alive via a shared ptr in ClientSideEncryption 
This account object was really only used during the initialization phase
or for forgetting the sensitive data. So let's receive it as parameter
there and pass it on from job to job as needed.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2021-01-26 11:20:13 +00:00
Valdnet
f365ec1e4c Move space in "folderwizard.cpp" 2021-01-25 17:42:38 +00:00
Valdnet
8539dc7dc6 Change the quotation marks 2021-01-25 17:33:46 +00:00
Felix Weilbach
78f00acaa2 Add push notifications for file changes 
Resolves #2802

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-01-25 17:01:09 +00:00
Kevin Ottens
4992bfa8ef
Ensure the right radio is selected when selective sync is picked 
This got broken previously when trying to reconcile during a
cherry-pick. This also repairs the case when the theme tells us the
default is to not select anything (not that we're using this right now
but in case we'd like to brand this).

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2021-01-25 16:53:21 +01:00
Kevin Ottens
2b2dac10ef
It's not really recommended anymore at least not on Windows 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2021-01-25 16:24:44 +01:00
Felix Weilbach
db0f1e245d Remove NO_SHIBBOLETH flag and dead code 
Signed-off-by: Felix Weilbach <felix.weilbach@t-online.de>
 2021-01-05 12:58:58 +01:00
Hannah von Reth
09cc988026
Fix a possible crash with the remove all files dialog 2020-12-30 16:20:43 +01:00
Hannah von Reth
552427ffc3
Update windows launch on start binary location 
Fixes: #7672
 2020-12-30 16:17:47 +01:00
Kevin Ottens
e37a5f36b0
Don't look at virtual files data for the mimetype matches 
Otherwise this would attempt to download the file everytime we check the
direct editor for a given file which wouldn't be adequate. Would also
lead to a deadlock in our case since that would happen in the main
thread and implicit hydration is driven from there as well.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-12-30 09:44:58 +01:00
rakekniven
29d968ab15 Changed triple dot to ellipsis 
Reported at Transifex.

Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>
 2020-12-21 08:00:29 +00:00
Camila
0e0ea9d81a Update the settings dialog window title. 
Signed-off-by: Camila <hello@camila.codes>
 2020-12-17 07:04:07 +00:00
Camila
625752f85d General settings: move buttons to the bottom left of their group boxes. 
Signed-off-by: Camila <hello@camila.codes>
 2020-12-17 07:04:07 +00:00
Kevin Ottens
c57eff6fd8
Please the clang-tidy overlord 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-12-15 11:01:53 +01:00
Hannah von Reth
9d9eadba8e
Use time the request was send,.. 
not when it was processed by the client, to determine the quality of the connection.
 2020-12-15 11:01:08 +01:00
Hannah von Reth
96eaef6dba
Pause sync when remove all dialog is displayed 
Fixes: #8263
 2020-12-15 10:59:27 +01:00
Hannah von Reth
c253b51249
Use enum instead of int 2020-12-15 10:59:27 +01:00
Hannah von Reth
befc373ea6
Fix test on systems where C:\ is not writeable 2020-12-15 10:59:27 +01:00
Hannah von Reth
0eb8b01f0a
Fix usePlaceholders migration 2020-12-15 10:59:26 +01:00
Hannah von Reth
a083a37126
Fix vfs experimental text 2020-12-15 10:59:26 +01:00
Hannah von Reth
b2934a68bc
Fix folder permission check on NTFS 
Fixes: #8187
 2020-12-15 10:59:26 +01:00
Hannah von Reth
8dbdaed5c3
Fix condition 2020-12-15 10:59:26 +01:00
Hannah von Reth
e4a0222954
Append .exe to crashreporter path so it is better located 2020-12-15 10:59:25 +01:00
Hannah von Reth
f6faba48e2
Don`t block main thread when displaying all files removed dialog 
Fixes: #8170
 2020-12-15 10:59:25 +01:00
Hannah von Reth
b4cb3ecb5a
Don't use exec() on dialogs 2020-12-15 10:59:25 +01:00
Hannah von Reth
7c65d38ba4
Draw active progressbar 
Pass a widget to the progressbar in the folder delegate to draw the correct active state
 2020-12-15 10:59:25 +01:00
Kevin Ottens
7e5f81ea81
Allow to control availability of folders in the settings dialog 
It felt odd to be able to control the encryption status in the settings
dialog but not the availability. Also availability was controllable on
the root, so let's make it widely available.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-12-15 10:59:24 +01:00
Kevin Ottens
70c2dc70a1
Resurrect the display of subfolders for VFS sync folders 
This got removed from the settings since in that case selective sync
isn't supported. Unfortunately that's also necessary to display them to
allow encrypting folders via the context menu.

So we display the subfolders again but in the case of VFS we disable the
ability to (un)check them. They just have an icon, a name and a context
menu.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-12-15 10:59:24 +01:00
Kevin Ottens
9f0e0b0f6a
Update the FolderStatusModel when a folder encryption ends 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-12-15 10:59:24 +01:00
Kevin Ottens
596bfab6e1
Set the account state after E2EE is setup in the GUI 
Otherwise we would not display the E2EE message if the account was
connected before the creation of the settings dialog. This was likely
caused by the delayed creation of the settings dialog.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-12-15 10:59:24 +01:00
Kevin Ottens
f45e84f2ee
Remove empty action in the settings toolbar 
This was causing an unwanted line in the middle of the bar.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-12-15 10:59:24 +01:00
Kevin Ottens
d63097475c
Fix typo and style 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-12-15 10:59:23 +01:00
Kevin Ottens
ce5edfdf4d
Stop using e2e()->isFolderEncrypted() in the folder wizard 
We used the same approach than for the FolderStatusModel by getting the
is-encrypted property straight from the LSCOL job.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-12-15 10:59:23 +01:00
Kevin Ottens
4fde05b8b6
FolderStatusModel now uses the LSCOL job result for encryption status 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-12-15 10:59:22 +01:00
Kevin Ottens
8e5a8d9fb9
FolderStatusModel LSCOL job now gets the is-encrypted property 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-12-15 10:59:22 +01:00
Kevin Ottens
37a51872e1
Set the encrypted flag in the database when EncryptFolderJob succeeds 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-12-15 10:59:22 +01:00
Kevin Ottens
b667bdda14
Change EncryptFolderJob path convention 
It had a different path convention than all the other jobs, most likely
for legacy reasons because of the tight coupling it had to the settings
dialog.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-12-15 10:59:22 +01:00
Hannah von Reth
dd3e70b667
VirtualFiles: Ensure the target location supports vfs 
Fixes: #8131
 2020-12-15 10:59:20 +01:00
Hannah von Reth
60011e8003
Remove vfs warning in the delegate, indicate them in the description instead 
Fixes: #8139
 2020-12-15 10:59:20 +01:00
Hannah von Reth
356192fb1d
Don't show 404 errors when manually creating folder sync pair. 
Fixes: #7724
 2020-12-15 10:59:20 +01:00
Hannah von Reth
1619cd5dcc
Use winvfs by default when adding folder sync connection 
Fixes: #8083
 2020-12-15 10:59:19 +01:00
Hannah von Reth
8460526df9
Clear cookies on logout 2020-12-15 10:59:19 +01:00
Hannah von Reth
020c6d6424
Fix placeholders are reverted to OnlineOnly 
Fixes: #7779
 2020-12-15 10:59:19 +01:00
Hannah von Reth
f1f6257b5d
Windows VFS: Enable Windows VFS by default 2020-12-15 10:59:18 +01:00
Hannah von Reth
bd62615aab
Clazy: Fix some warnigns 2020-12-15 10:59:17 +01:00
Hannah von Reth
d109d49b49
Ui: Hide selective sync settings if vfs is active 
Fixes: #7976
 2020-12-15 10:59:17 +01:00
Hannah von Reth
54cc2be00f
Fix assertion introduced by e1ca612c5d3087e02f6b7f8e454224e0b88e82ad 
[ fatal default ]:ASSERT: "last < rowCount(parent)" in file C:\_\17a9f6ae\qtbase-everywhere-src-5.12.9\src\corelib\itemmodels\qabstractitemmodel.cpp, line 2787

e1ca612c5d3087e02f6b7f8e454224e0b88e82ad stopped adding sub folders so we can return the actual size.
 2020-12-15 10:59:17 +01:00
Hannah von Reth
93281c8560
Use const access where possible 2020-12-15 10:59:17 +01:00
Hannah von Reth
2887a93c40
Win: Use full Windows paths in file watcher and improve logging 2020-12-15 10:59:16 +01:00
Hannah von Reth
b9638bc778
Fix warning 
warning C4573: the usage of 'QObject::disconnect' requires the compiler to capture 'this' but the current default capture mode does not allow it
 2020-12-15 10:59:15 +01:00
Hannah von Reth
e38b43123c
Log: Only print 'Saved account settings' in debug mode 
Don't log that there was no error...
 2020-12-15 10:59:15 +01:00
Hannah von Reth
c9ee0a0343
Log: Improve log message [ info gui.folder ]: Folder sync result: 4... 
by including the name of the folder and print the name of the result
 2020-12-15 10:59:15 +01:00
Hannah von Reth
fb34f8ea85
Gui: Don't try to display the wizard during shutdown 
Fixes: #7936
 2020-12-15 10:59:14 +01:00
Hannah von Reth
4f8928d35e
Remove dead code 2020-12-15 10:59:14 +01:00
Hannah von Reth
c5b59bf3b1
Make ownCloud accassible on the Application object 2020-12-15 10:59:14 +01:00
Hannah von Reth
4645e69147
Remove ifdef(Q_OS_X11) code, there never was such a define. 
As noone complained since I don't think anyone will miss the code
 2020-12-15 10:59:14 +01:00
Hannah von Reth
f932dfc648
VFS: Tell the vfs plugin whether we have multiple accounts 
This allows us to decide on the presentation of the account
 2020-12-15 10:59:14 +01:00
Hannah von Reth
7fdb842ed2
VFS: Prevent duplicated navigation panel icon 
Issue: #7748
 2020-12-15 10:59:13 +01:00
Hannah von Reth
c92f70d4ff
Beautify flags 2020-12-15 10:59:13 +01:00
Hannah von Reth
2b95f919ad
Fix 3aeca58b316363dc12ad4b392750fc57e7a2965a 2020-12-15 10:59:13 +01:00
Hannah von Reth
6d2526a67d
Fix warning C4715: 'OCC::Utility::vfsCurrentAvailabilityText': not all control paths return a value 2020-12-15 10:59:12 +01:00
Hannah von Reth
b492b69dfd
Fix 150a5b4d06600d140ddf05383fb74cda6ae6e941 2020-12-15 10:59:12 +01:00
Hannah von Reth
6fde08d9f7
Fix crash on settings migration 
Fixes: #7878
 2020-12-15 10:59:12 +01:00
Hannah von Reth
fa87b899fb
Fix usage of QMessageBox 
Fixes: #7874
 2020-12-15 10:59:12 +01:00
Hannah von Reth
11b9e3fa61
Fix order of pluginkit commands and modernise 2020-12-15 10:59:12 +01:00
Hannah von Reth
eed4ffb823
Wizard: Raise own window 
The OAuth authentication brings the broweser to the front, once thats done the wizard continues.
But the wizard ist now most probably hidden behind the browser
 2020-12-15 10:59:11 +01:00
Hannah von Reth
baff0a6986
VFS Dialog: Don't enable on close button clicked 
Issue: #7710
 2020-12-15 10:59:11 +01:00
Hannah von Reth
b15c308170
Remvoe now unneeded SyncRunFileLog::directionToStr 2020-12-15 10:59:11 +01:00
Hannah von Reth
4681421b62
Remvoe now unneeded SyncRunFileLog::instructionToStr 2020-12-15 10:59:11 +01:00
Hannah von Reth
4d615c31da
Rename csync_instructions_e -> SyncInsturctions 2020-12-15 10:59:10 +01:00
Hannah von Reth
bcceb5c33d
[Gui] Implement raiseDialog on Windows 
Issue: #7774
 2020-12-15 10:59:09 +01:00
Hannah von Reth
12ae1e97c6
[SocketApi] Ensure listener still exists 2020-12-15 10:59:08 +01:00
Hannah von Reth
d63d4cdf62
Don't insert items into the folder model if selectiveSync is not supported 
This fixes an assertion in FolderStatusModel::SubFolderInfo::resetSubs
rowCount reported 0 but we actually had items in the model
 2020-12-15 10:59:08 +01:00
Hannah von Reth
9176afe263
Make sure all cases are handled 2020-12-15 10:59:08 +01:00
Hannah von Reth
9b0788bdf8
[Gui] Fix vfs dialog not showing on Windows 2020-12-15 10:59:08 +01:00
Olivier Goffart
b7193e6a0e
Folder Wizard: warn when adding a folder which is the parent of a sync'ed folder 
issue #7741
 2020-12-15 10:59:07 +01:00
Hannah von Reth
13c9d6431d
Fix expansion of tree view on newly added accounts 
The change is based on 97ce20ac028660e6ae3dd0b98d4b487999d8768a

I removed a few lines of code there which are already part of fetchMore()

Fixes: #7336
 2020-12-15 10:59:07 +01:00
Hannah von Reth
fdc3b7c8da
[Wizard] Make vfs dialog blocking 
Calling the callback after the receiver was deleted caused a crash
Fixes: #7709
Fixes: #7711
 2020-12-15 10:59:07 +01:00
Hannah von Reth
ba87fc9e78
[SSL] Properly restore user accepted certificats 2020-12-15 10:59:06 +01:00
Hannah von Reth
c8dd333e31
[Sanity] Remove old ifdef 2020-12-15 10:59:06 +01:00
Hannah von Reth
9564e5e92e
Fix saving of cookies 
Fixes: #7700
 2020-12-15 10:59:06 +01:00
Hannah von Reth
3a3ccb0834
Don't hardcode PLUGINDIR 2020-12-15 10:59:06 +01:00
Olivier Goffart
f81f96915f
ProxyAuthHandler Use QPointer instead of QWeakPointer 
QWeakPointer::data is deprecated.
In this case we should use QPointer
 2020-12-15 10:59:05 +01:00
Hannah von Reth
edb51abdfd
Don't ignore file sync notification after an unlock 
For a usual file sync event we check for actual changes in the local file,
after an unlock the local file might be unchanged so we need to sync it anyhow.

Fixes: owncloud/enterprise#3609
 2020-12-15 10:59:05 +01:00
Hannah von Reth
3317e354f2
Prepend PLUGINDIR else its pointless 2020-12-15 10:59:05 +01:00
Hannah von Reth
dabf7aaebc
Application: Allow to quit running instances by commandline 2020-12-15 10:59:04 +01:00
Hannah von Reth
fa82a4aff3
Cleanup 2020-12-15 10:59:04 +01:00
Olivier Goffart
4424eb7f07
AccountSettings: limit the clickable region of the 'add folder' button 
Issue #7326
 2020-12-15 10:59:03 +01:00
Olivier Goffart
b97c0ed8a2
Network Settings: Show a warning that proxy settings do not apply to localhost 
Only show this if at least one account is detected to have an url that looks
like localhost, because this could otherwise be confusing

Issue #7169
 2020-12-15 10:59:03 +01:00
Hannah von Reth
9807285abd
[Gui] Set proper hdpi attributes 2020-12-15 10:59:03 +01:00
Olivier Goffart
513b0c723c
Account Settings: change the color of info message from green to blue 
To avoid confusion with the color of "success"

Issue #7403
 2020-12-15 10:59:02 +01:00
Olivier Goffart
4d7ed8f62c
Wizard: fix compilation warnings about unused variables 2020-12-15 10:59:01 +01:00
Hannah von Reth
dc55617144
Ensure the url is complete before we validate it 
Fixes: #6722
 2020-12-15 10:59:00 +01:00
Christian Kamm
a5c6612883
ConnectionValidator: increase timeout to 57s #7456 
When the gui thread blocks for several seconds it's possible for the
ConnectionValidator to timeout and decide that the account is
unreachable. It will then terminate all sync runs.

Increasing the timeout makes this less likely to happen. The tradeoff is
that real disconnects will not be detected as quickly.

This does not address the root cause but makes the symptom less likely
to appear.
 2020-12-15 10:58:59 +01:00
Hannah von Reth
f78c4f851b
Change Windows virtual files description to tech preview 2020-12-15 10:58:57 +01:00
Hannah von Reth
afc9cd2f46
OwncloudWizard: Mark vfs as tech preview instead of experimental 2020-12-15 10:58:57 +01:00
Dominik Schmidt
7e4d24de2b
SocketApi: Avoid unneccessary conversions 2020-12-15 10:58:57 +01:00
Dominik Schmidt
06ac1c33e8
SocketApi: cleanup debug output 2020-12-15 10:58:57 +01:00
Dominik Schmidt
25cd52dd9f
Add ASYNC_ASSERT_ICON_IS_EQUAL command to SocketApi 2020-12-15 10:58:57 +01:00
Dominik Schmidt
d1f9b1a4f8
Make findWidget more powerful 2020-12-15 10:58:56 +01:00
Dominik Schmidt
67656fb136
Add Q_PROPERTYs for gui testing 2020-12-15 10:58:56 +01:00
Dominik Schmidt
596154a01a
Switch GUI Testing SocketApi to Utf8 2020-12-15 10:58:56 +01:00
Dominik Schmidt
3288a36da6
Add GUI testing SocketApi extension 2020-12-15 10:58:56 +01:00
Hannah von Reth
0f92713ce5
AccountSettings: Use switch, case to ensure we handle all cases 2020-12-15 10:58:55 +01:00
Christian Kamm
a587cd3a13
AccountSettings: Fetch subitems after wiping them 
That helps avoid empty lists after account creation #7336
 2020-12-15 10:58:54 +01:00
Christian Kamm
38c466efbf
Vfs: Require local discovery after disabling vfs 
Without it local files aren't guaranteed to be downloaded #6936.
 2020-12-15 10:58:54 +01:00
Christian Kamm
b34df4413b
Vfs: Improve strings for availability states 2020-12-15 10:58:53 +01:00
Christian Kamm
fc52c5d0cd
Vfs: Retain existing data when enabling vfs #7302 
Previously all local data was deleted because the root folder was marked
as OnlineOnly.
 2020-12-15 10:58:53 +01:00
Christian Kamm
5acb157a7e
VfsSuffix: Wipe stale pin states #7273 
Previously the pin states of deleted files stayed in the 'flags'
database and could be inadvertently reused when a new file with the same
name appeared. Now they are deleted.

To make this work right, the meaning of the 'path' column in the 'flags'
table was changed: Previously it never had the .owncloud file suffix.
Now it's the same as in metadata.path.

This takes the safe parts from #7274 for inclusion in 2.6. The more
elaborate database schema changes (why use 'path' the join the two
tables in the first place?) shall go into master.
 2020-12-15 10:58:52 +01:00
Markus Goetz
62d876b09a
OAuth2: Better error logging 
This does not fix a bug, just was found while spotting a bug that was no bug.
For https://github.com/owncloud/enterprise/issues/2951
 2020-12-15 10:58:51 +01:00
Olivier Goffart
2c975b1e70
SocketAPI: Fix string claiming a folder is a file 
Issue #7206
 2020-12-15 10:58:51 +01:00
Markus Goetz
46c336503a
Log Window: Create and open folder properly #7166 2020-12-15 10:58:50 +01:00
Christian Kamm
edad7ce7d7
Vfs: Mark sqlite temporaries excluded on db-open #7141 
The previous patch ensured that the sqlite temporaries weren't deleted
and recreated for every sync run, but there was still time between
client startup and the first sync run where they would have the
"needs-sync" icon.
 2020-12-15 10:58:50 +01:00
Christian Kamm
7774b8049e
Vfs: Distinguish availability error kinds #7143 
Previously "no-availability" meant db-error and querying the
availability of a nonexistant path returned AllHydrated.

Now, the availability has a DbError and a NoSuchItem error case.
 2020-12-15 10:58:49 +01:00
Christian Kamm
1e5ae77994
Fix logic for duration that an etag reply indicates connectivity 
This got inverted accidentally when std::chrono was introduced.

For #7160
 2020-12-15 10:58:49 +01:00
Christian Kamm
7f3f13fd97
Vfs: "free space" only shows when it has an effect #7143 
To do this, introduce AllDehydrated availability and rename
SomeDehydrated to Mixed - it now guarantees there are also hydrated
items.
 2020-12-15 10:58:49 +01:00
Christian Kamm
40d9fc4f4b
Vfs: Adjust and centralise action text #7143 
Saying "Currently available locally" sounds more like an indicator than
"Availably locally" does. Centralizing translations avoids consistency
issues between shell context menus and sync folder context menu.
 2020-12-15 10:58:49 +01:00
Christian Kamm
021f994584
FolderWizard: Don't crash when typing invalid drive #7041 
When the user typed "x:" where the drive x didn't exist, the validation
function would loop forever. Now it shows a "path doesn't exist" error.
 2020-12-15 10:58:49 +01:00
Christian Kamm
076e24f465
Log: Start logging immediately when "permanent logs" enabled #7146 
Previously one would need to wait for the next sync run to create the
first log file.
 2020-12-15 10:58:48 +01:00
Christian Kamm
772a210cc9
Mention selective sync when switching on vfs 2020-12-15 10:58:48 +01:00
Christian Kamm
22234e0e73
LogWindow: Remove output, add "go to log folder" button #6475 2020-12-15 10:58:47 +01:00
Christian Kamm
dcf34316fd
Vfs: Add 'availability', a simplified, user-facing pin state #7111 
The idea is that the user's question is "is this folder's data available
offline?" and not "does this folder have AlwaysLocal pin state?".
The the answers to the two questions can differ: an always-local
folder can have subitems that are not always-local and are dehydrated.

The new availability enum intends to describe the answer to the user's
actual question and can be derived from pin states. If pin states aren't
stored in the database the way of calculating availability will depend
on the vfs plugin.
 2020-12-15 10:58:47 +01:00
Christian Kamm
590db28541
Vfs: Clear up relationship between _type and pin state 
The pin state is a per-item attribute that has an effect on _type:
AlwaysLocal dehydrated files will be marked for hydration and OnlineOnly
hydrated files will be marked for dehydration.

Where exactly this effect materializes depends on how the pin states are
stored. If they're stored in the db (suffix) the dbEntry._type is
changed during the discovery.

If the pin state is stored in the filesystem, the localEntry._type must
be adjusted by the plugin's stat callback.

This patch makes pin states behave more consistently between plugins.
Previously with suffix-vfs pin states only had an effect on new remote
files. Now the effect of pinning or unpinning files or directories is as
documented and similar to other plugins.
 2020-12-15 10:58:46 +01:00
Christian Kamm
3f55f9302e
Vfs: Hydrating a virtual is SYNC not NEW #7101 
Previously it'd be NEW(ItemTypeFile), but now it has changed to be
SYNC(ItemTypeVirtualFileDownload) which allows better classification.
 2020-12-15 10:58:45 +01:00
Christian Kamm
e0c8acc195
Notifications: Don't say "downloaded" for new files #7101 
These files may very well just be new virtual files that were explicitly
*not* downloaded.
 2020-12-15 10:58:45 +01:00
Christian Kamm
04e0e22513
Protocol, Notifications: Show destination() instead of _file 
destination() now consistently points to the file after the successful
sync operation. _file might be the place the item was moved from.
 2020-12-15 10:58:45 +01:00
Markus Goetz
5da48a5239
SocketApi: Fix owncloud/enterprise#2938 2020-12-15 10:58:43 +01:00
Christian Kamm
2f7cdb81cf
Tray: Try to establish tray after 10s if failed initially #6518 
When owncloud is started during desktop startup the tray may not yet
be running when the client starts. This will make the client attempt
to create a tray icon again after 10 seconds if there's no tray
during initial startup.
 2020-12-15 10:58:43 +01:00
Christian Kamm
ee6a48b3dc
Client certs: Store pkcs12 in config, password in keychain 
It still reads and writes the old format too, but all newly stored
client certs will be in the new form.

For #6776 because Windows limits credential data to 512 bytes in older
versions.
 2020-12-15 10:58:43 +01:00
Christian Kamm
cc840534c0
Add PLUGINDIR cmake setting and define #7027 
By default, plugins are only searched next to the binary or next to the
other Qt plugins. This optional build variable allows another path to be
configured.

The idea is that on linux the oC packaging probably wants the binary in
something like /opt/owncloud/bin and the plugins in
/opt/owncloud/lib/plugins.

Similarly, distribution packagers probably don't want the plugins next
to the binary or next to the other Qt plugins. This flag allows them to
configure another path that the executable will look in.
 2020-12-15 10:58:43 +01:00
Olivier Goffart
87bd26bf6c
AccountManager: load the cookies 
For issue #7054
 2020-12-15 10:58:43 +01:00
Christian Kamm
a72bf89779
Selective sync: Don't collapse tree when entering mode #7055 
doExpand() is called when the selective sync editing mode is enabled in
the folder settings view. Previously it'd set the expansion to be
exactly the root items. Now, it just expands any root items that are
currently collapsed, leaving all other item expansion unchanged.
 2020-12-15 10:58:42 +01:00
Christian Kamm
2e11f14a6b
SocketApi: Fix crash with readyRead() after disconnected() #7044 
With the recent bugfix to avoid sending messages on dead connections
0bfe7ac250c54f5415c0a794c7b271428e83c3cf
the client now crashed if readyRead() was received after disconnected()
for the socket as the listener for that connection was already removed.

This code fixes it by still invoking the handler from readyRead() but
passing a SocketListener that won't attempt to send messages.
 2020-12-15 10:58:42 +01:00
Christian Kamm
6199e140a5
Wizard: Avoid cert dialog multiple connection 
This could lead to odd behavior when slotCertificateAccepted
was called multiple times.
 2020-12-15 10:58:42 +01:00
Christian Kamm
83268c255a
Folder wizard: Fix infinite loop for bad paths #7041 2020-12-15 10:58:42 +01:00
Christian Kamm
238ac53666
Ensure local discovery on selective sync changes 
As far as I'm aware local discovery can be skipped on folders that are
selective-sync blacklisted, so a local discovery is required when an
entry is removed from the blacklist.

Also rename
avoidReadFromDbOnNextSync() -> schedulePathForRemoteDiscovery()
since the old name might also imply it's not read from db in the local
discovery - which is not the case. Use Folder::
schedulePathForLocalDiscovery() for that.
 2020-12-15 10:58:41 +01:00
Christian Kamm
4c04351360
Fix warnings about signedness 
Sizes are always qint64, not unsigned.
TransferIds are always uint.
 2020-12-15 10:58:41 +01:00
Christian Kamm
e9cbe13598
Vfs: Add option to hide socketapi pin actions 
Because some plugins provide alternative ui.
 2020-12-15 10:58:40 +01:00
Christian Kamm
d8873c18a1
File watcher: Pin state attribute changes are valid notifications 
Previously they would be discarded since the file's mtime or size hadn't
changed.
 2020-12-15 10:58:39 +01:00
Christian Kamm
83a818678f
PinStates cleanup 
- SyncJournalDB functions now behind internalPinStates() to avoid
accidental usage, when nearly everyone should go through Vfs.
- Rename Vfs::getPinState() to Vfs::pinState()
 2020-12-15 10:58:39 +01:00
Christian Kamm
0eb4065197
Folder: Add remoteFolderTrailingSlash() 
There were cases where the "/" exception wasn't handled correctly
and there'd be extra slashes in generated paths.
 2020-12-15 10:58:39 +01:00
Christian Kamm
41f1ddb5fc
Vfs: Call unregisterFolder() when folder is removed 2020-12-15 10:58:39 +01:00
Christian Kamm
7f400e3226
Pin state updates 
- unspecified and inherited are different
- move enum to header in common/
- access through Vfs instead of directly in Journal
 2020-12-15 10:58:38 +01:00
Christian Kamm
e2eea24a03
Vfs: Send SyncFileStatusTracker data to vfs plugins 2020-12-15 10:58:37 +01:00
Christian Kamm
fe27804afb
Move SyncFileStatus to libcommon 
It'll be needed in vfs plugins so they can connect to the data coming
out of SyncFileStatusTracker.
 2020-12-15 10:58:37 +01:00
Christian Kamm
848b869cdf
SocketAPI: Remove listener immediately on lost connection 
To avoid situations where messages are attempted to be sent to dead
connections.
 2020-12-15 10:58:36 +01:00
Christian Kamm
0eebd77d2c
SocketAPI OSX: Forbid further sends on connectionDidDie 
Also release the remote end immediately.
 2020-12-15 10:58:36 +01:00
Christian Kamm
f3be99e5b2
vfs: Update pinning context menu to be less confusing 
Seeing "Currently available online only" for a currently hydrated file
was odd. It makes sense since current hydration status and pin state are
independent.

The new text will say something like "Currently available, but marked
online only" to better indicate that the file might be dehydrated later
since it wasn't pinned.
 2020-12-15 10:58:35 +01:00
Christian Kamm
b7079289c2
Vfs: Switch on/off only when sync isn't running #6936 
Avoids some situations that might cause data loss.
 2020-12-15 10:58:34 +01:00
Christian Kamm
5728256763
Folder: Add selective sync / ui related flags 
supportsSelectiveSync(): clearer than !supportsVirtualFiles() and allows
  extra logic

isVfsOnOffSwitchPending(): Somewhat awkward way of dealing with the
  phase between a user requesting vfs state to be switched and it
  actually happening
 2020-12-15 10:58:34 +01:00
Christian Kamm
22255e4976
vfs: Add vfs migration options to folder context menu 
This allows enabling and disabling vfs.

To distinguish this operation from setting the root pin state, the
availability setting is adjusted as well to be similar to the
menu that shows in the shell extensions.
 2020-12-15 10:58:33 +01:00
Christian Kamm
3b923e2afe
vfs: Change per-folder message on vfs support 
I'm unsure this note is all that useful. Remove entirely?
 2020-12-15 10:58:33 +01:00
Christian Kamm
4df101ed84
vfs: Allow (de-)hydrating the full sync folder 2020-12-15 10:58:33 +01:00
Christian Kamm
47e21bfc60
vfs: Don't assume suffix mode for old folders 
That would break with old folders that use selective sync.
 2020-12-15 10:58:33 +01:00
Christian Kamm
cbb32edee2
vfs: Disable selective sync if vfs support is available 2020-12-15 10:58:32 +01:00
Christian Kamm
aa23058d76
Wizard: Ensure client cert doesn't get lost #6911 2020-12-15 10:58:32 +01:00
Christian Kamm
c470825c8f
Wizard: Drop unused function 2020-12-15 10:58:32 +01:00
Markus Goetz
4fcad0d8b0
Sync: Display theme in debug log 2020-12-15 10:58:32 +01:00
Olivier Goffart
c31d3f277f
HttpCredentials: Do not re-enter the event loop 
https://sentry.io/owncloud/desktop-win-and-mac/issues/777907931/
mention a crash in OCC::HttpCredentialsGui::showDialog
One possible explaination is that this is caused by re-entring the event loop.
So don't do that.
 2020-12-15 10:58:31 +01:00
Olivier Goffart
0e56dfe3a4
Gui: do not show the settings when opening a virtual file 
Issue #6764
 2020-12-15 10:58:31 +01:00
Christian Kamm
c4dfa82661
SocketAPI: Overhaul ui for 'available locally' vs 'online only' 
For #6815
 2020-12-15 10:58:30 +01:00
Christian Kamm
d956f518a8
vfs: Remove newFilesAreVirtual - use root PinState instead 
This unifies how to deal with pin states.

Also enable reading a folders direct pin state vs its effective pin
state.
 2020-12-15 10:58:30 +01:00
Christian Kamm
cdf61b9e82
vfs: Show "new files are virtual" option only with vfs 
If there's no vfs possibility, showing it makes little sense.
 2020-12-15 10:58:30 +01:00
Christian Kamm
8f895fc83c
vfs: SocketAPI actions adjust pin state of directories #6815 
Downloading a folder also sets its pin state; releasing a folder sets
its pin state.
 2020-12-15 10:58:29 +01:00
Christian Kamm
69144566ce
Database: Change path for new dbs to .sync_* #5904 
This is to avoid issues on OSX, where the ._ prefix has special meaning.

Originally (before 2.3.2) ._ was necessary to guarantee exclusion. But
since then the .sync_ prefix is excluded as well.

This does not affect existing database files.
 2020-12-15 10:58:28 +01:00
Christian Kamm
75b9976526
Vfs: Ensure older versions gracefully ignore winvfs folders 
Previously there'd likely be a mess if a 2.6 winvfs folder was attempted
to be used with a 2.5 client. Now the older clients will ignore these
folders.
 2020-12-15 10:58:28 +01:00
Olivier Goffart
feb770eca7
Allow to open log window via command line to already running client 
Issue: #4098
 2020-12-15 10:58:27 +01:00
Christian Kamm
305d439c41
vfs: Separate vfs availability from new-files-virtual 
This helps support 2.5 settings where there are virtual files in the
tree but new files aren't created virtual.

It's also a prelude for #6815

There's currently no way of
- upgrading vfs plugins (a silent suffix->winvfs upgrade is attempted
  once only, when moving to master)
- disabling vfs capabilities outright
 2020-12-15 10:58:27 +01:00
Christian Kamm
cc912f4d02
vfs: ensure backwards-compatible settings value is always set 2020-12-15 10:58:26 +01:00
Christian Kamm
b30f79edf6
vfs: Ensure SyncOptions::_vfs is never null 
- Create a VfsOff derived class
- Make it a shared pointer shared with Folder::_vfs
 2020-12-15 10:58:26 +01:00
Christian Kamm
d7ad7854c1
vfs: Ensure local discovery is done on dehydration request 2020-12-15 10:58:26 +01:00
Christian Kamm
f2b78b5efb
Folder settings: Keep "usePlaceholders" to be backwards compatible 2020-12-15 10:58:25 +01:00
Christian Kamm
fa2450cf11
vfs: Be more careful about Vfs instance ownership 2020-12-15 10:58:25 +01:00
Christian Kamm
9ced8dd836
vfs: Improve modeFromString() signature 2020-12-15 10:58:24 +01:00
Christian Kamm
85dd10eb9b
vfs: Fix dealing with missing vfs instance 
Maybe there should just be a VfsOff instance to make this less error
prone.
 2020-12-15 10:58:24 +01:00
Christian Kamm
4bef96afe7
vfs: Make switching vfs on/off work again 2020-12-15 10:58:23 +01:00
Christian Kamm
fa6f3cd847
vfs: Fix plugin decision in wizards, sanitize loading 2020-12-15 10:58:23 +01:00
Christian Kamm
e0ae6012b1
vfs: Allow folders without vfs 2020-12-15 10:58:22 +01:00
Christian Kamm
2b20985875
winvfs: initial work 
Done by ckamm and dschmidt
 2020-12-15 10:58:21 +01:00
Christian Kamm
c3b1a872aa
FolderMan: Remove assumption of unique running sync 2020-12-15 10:58:21 +01:00
Olivier Goffart
a6614c18f1
IgnoreListEditor: increase a bit the size 
Should Help for issue #6641
 2020-12-15 10:58:21 +01:00
Christian Kamm
6b0bb66b17
LockWatcher: Add chrono header 2020-12-15 10:58:20 +01:00
Christian Kamm
0d49056a13
Add Ctrl-L as log window shortcut 
F12 is taken on OSX and there's no other way of showing it.
 2020-12-15 10:58:17 +01:00
Christian Kamm
9d55590d10
Test: Add test for locked file tracking and propagation 2020-12-15 10:58:17 +01:00
Christian Kamm
da178c1352
Folder: Treat file unlock similar to external change #6822 
For consistent handling of incoming notifications.
 2020-12-15 10:58:17 +01:00
Olivier Goffart
60b17cd128
Folder: update the folder version 
Since the new index would crash old version of the client, we need to
upgrade folder version so they do not load in the client 2.5.0
 2020-12-15 10:58:15 +01:00
Christian Kamm
7de453d439
Settings: Make FoldersWithPlaceholders group sticky 
If virtual files are disabled on a folder it might still have db entries
or local virtual files that would confuse older client versions.
 2020-12-15 10:58:15 +01:00
Olivier Goffart
ec8c02dad0
Sharing: add the shareWithAdditionalInfo string in autocompletion results 
Issue #6749
 2020-12-15 10:58:15 +01:00
Olivier Goffart
380d7b8028
Migration from 2.4: fallback to move file by file if directory move failled (#6807) 
Migration from 2.4: fallback to move file by file if directory move failed

This can happen if the directory already exist because, say, it was
created by the ownCloud outlook plugin which save its file in the same directory
 2020-12-15 10:58:15 +01:00
Olivier Goffart
dcfbde2a67
Wizard: Reset the QSslConfiguration before checking the server 
Because a previous call with another demain might have set some
config for another server.

Issue #6832
 2020-12-15 10:58:14 +01:00
Dominik Schmidt
5d9370594d
Disable autostartCheckBox if autostart is configured system wide 2020-12-15 10:58:14 +01:00
Olivier Goffart
8490664860
Account Settings: fix progress being written in white when there are errors 2020-12-15 10:58:12 +01:00
Christian Kamm
dd34cbc751
Virtual files: Wipe selective sync settings when enabled 2020-12-15 10:58:12 +01:00
Christian Kamm
60de1c9720
virtual files: show option only when branding allows it 2020-12-15 10:58:12 +01:00
Christian Kamm
251e01a440
Virtual files: Use theme to check for option availability 2020-12-15 10:58:12 +01:00
Olivier Goffart
94e63ef7b9
Account Settings: Add a context menu entry to enable or disable virtual files 
Issue #6725
 2020-12-15 10:58:12 +01:00
Olivier Goffart
15eab07866
OAuth2: Store 'Account::davUser' in the config, and use that user for connecting 
We need to use the user id to check if we are connected to the right account.
These might be different from the HTTP Basic Auth login. (LDAP setups)

When the account was configured as an oauth2 account form the wisard, the
http_user was already set correctly to the user id. But when the server is
upgrading from basic auth to oauth2, we need to pick the right login.

Note that Account::davUser() already defaults to the HTTP user when none
is set, so this means the upgrade will be fine if this is not set in the
config.

Issues:
https://github.com/owncloud/oauth2/issues/109
https://github.com/owncloud/enterprise/issues/2781
 2020-12-15 10:58:11 +01:00
Olivier Goffart
b86e1efc9a
Remove the backup deteciton code which was used for server < 9.1 2020-12-15 10:58:10 +01:00
Olivier Goffart
afed46afcc
New discovery algorithm: Parallel PROPFIND 2020-12-15 10:58:08 +01:00
Olivier Goffart
3289675b8d
Folder Wizard: Disable the 'choose what to sync' treeview if virtual files are selected 
Don't allow to configure virtual files with a selective sync blacklist
 2020-12-15 10:58:07 +01:00
Olivier Goffart
d8fa8e270f
AccountSetting: Fix Small Memoy leak 2020-12-15 10:58:06 +01:00
Olivier Goffart
0ba9dc7dd1
AccountSettings: Force sync should wipe the blacklist 
Issue #6757
 2020-12-15 10:58:06 +01:00
Olivier Goffart
75a57778d9
Virtual files: Don't show selective sync 
Issue #6724
 2020-12-15 10:58:06 +01:00
Olivier Goffart
46aa8fd1f8
Socket API: add an option to replace existing files with virtual files 
Issue #6726
 2020-12-15 10:58:06 +01:00
Olivier Goffart
afc953b649
Update the minimum supported version 
We want to warn if the server version is not supported and did not get
appropriate QA for this client version.

https://github.com/owncloud/enterprise/issues/2687
 2020-12-15 10:58:05 +01:00
Olivier Goffart
358aadfb98
Account Settings: Add a text for folder using vierual files 
Issue #6723
 2020-12-15 10:58:04 +01:00
Olivier Goffart
a17a2a9c06
Virtual Files Mime Type: use "vnd." prefix instead of "x-" 
As reported in https://github.com/owncloud/client/issues/6717#issuecomment-413703567
 2020-12-15 10:58:03 +01:00
Olivier Goffart
4837bc8d60
FolderStatusModel: Do not abort applying selective sync if one folder has an error 
Issue #6675
 2020-12-15 10:58:03 +01:00
Olivier Goffart
ca32eb1cf7
More cleanup of csync remains 2020-12-15 10:58:01 +01:00
Dominik Schmidt
aad928a6be
Install libocsync to lib/ without subfolder. 
Installing to lib/${APPLICATION_EXECUTABLE} has caused a bunch of
irritations in the past and subtle annoying to fix bugs. To avoid name
clashes with branded clients ${APPLICATION_EXECUTABLE} becomes now
part of the filename instead of the subfolder.

The concrete motivation to change this now is that on Windows there
is no RPATH and it's not possible to run owncloud directly from the
Craft Root folder, which is nice when you're developing on Windows.

It would have been possible to change this just for Windows but as
written earlier this has caused lots of issues and thus I think it's
a good idea to just stay consistent accross platforms when touching it.
 2020-12-15 10:57:56 +01:00
Olivier Goffart
0155a4fa73
Wizard + OAuth: Make opening a new browser after clicking back works again 
Issue #6574

When there is an error in the advanced page, OwncloudAdvancedSetupPage::updateStatus
(and others) call completeChanged(), which is connected to
QWizardPrivate::_q_updateButtonStates which will re-enable the back button from the
last page.

When the user click "back" and re-open the browser, the account's credentials
already have a oauth token set. So the call to the API to get a new token fails
because we use the previous token instead of using the client's secret_id.
Fix this with the HttpCredentials::DontAddCredentialsAttribute.

Now, this is still not working because the session cookies are confusing the
server.  So we'll clear the cookies when re-opening the browser
 2020-12-15 10:57:55 +01:00
Olivier Goffart
0d21936e95
FolderStatusModel: Fix crash when there is an error while expanding folders 
In FolderStatusModel::slotLscolFinishedWithError, the call to parentInfo->resetSubs
deleted the 'job' and the reply 'r' which we accessed later to get the error code.

Fix this problem twice by
 1) Get the error code before caling resetSubs
 2) in FolderStatusModel::SubFolderInfo::resetSubs, call deleteLater instead of delete

Regression introduced in commit d69936e0

Issue #6562
 2020-12-15 10:57:55 +01:00
Olivier Goffart
4ee244190b
Virtual Files: Allow to download a folder recursively from the socket API 
Issue: #6466
 2020-12-15 10:57:54 +01:00
Olivier Goffart
530614bf78
Rename SocketApi::FileData::accountRelativePath to serverRelativePath 
As discussed in issue #6552
 2020-12-15 10:57:54 +01:00
Olivier Goffart
ced5dfb8ee
Share dialog: use the original name and not the virtual file name 
When sharing a virtual file, we should actually use the original file name
not the virtual file name

Issue: #6461
 2020-12-15 10:57:54 +01:00
Christian Kamm
97f7b5abeb
Settings migration: Preserve future settings where possible 
See discussion in #6506
 2020-12-15 10:57:54 +01:00
Christian Kamm
87ba4e6b9c
Config: Add version flags to accounts and folders 
Also, if there is too-new configuration, backup the file, show a
warning message asking the user whether it's ok to discard the
configuration from the future.

See #6504
 2020-12-15 10:57:53 +01:00
Christian Kamm
aa6f5f59c4
Rename Placeholders to Virtual Files in code #6531 2020-12-15 10:57:53 +01:00
Olivier Goffart
a877a9d472
SyncRunFileLog: Add the requestid 
https://github.com/owncloud/client/pull/6427#issuecomment-383879509
 2020-12-15 10:57:53 +01:00
Christian Kamm
7da4bb4c20
Wizard: Add a "(recommended)" to the main option #6470 2020-12-15 10:57:53 +01:00
Christian Kamm
ddeeecd061
Rename "placeholder" feature 2020-12-15 10:57:53 +01:00
Christian Kamm
4e3f2f755a
Placeholder: Stop adding ignore pattern 
Because we can't make older clients preserve the version directive that
was attached to it.

See #6504 and #6498
 2020-12-15 10:57:52 +01:00
Christian Kamm
27b65cbc69
Placeholders: Save to key that's invisible to <2.5 clients #6504 2020-12-15 10:57:52 +01:00
Olivier Goffart
3272f3b72b
FolderWizard: fix crash when experimental feature are disabled 
The _placeholderCheckBox only exists if the experimental features are enabled

Found via the crash reporter
https://sentry.io/owncloud/desktop-win-and-mac/issues/556407777/
 2020-12-15 10:57:52 +01:00
Markus Goetz
215afba89e
Share Dialog: Disable workaround for macOS too #6185 2020-12-15 10:57:52 +01:00
Markus Goetz
8dcfd50a7d
Placeholders: Support for macOS #6290 2020-12-15 10:57:51 +01:00
Christian Kamm
765c12dae1
LocalDiscoveryTracker: Separate from Folder and move to libsync 
To allow relevant code to be closer together and for testing in
unittests without having to get a gui Folder.

See #6120
 2020-12-15 10:57:51 +01:00
Christian Kamm
27c8bce0b9
Wizards: Show placeholder option only if showExperimentalOptions is set 
This config file option will also control other features in the future.
 2020-12-15 10:57:50 +01:00
Christian Kamm
aee8b9f3c5
Wizards: Add placeholder option and warning to account wizard 
Also add the warning dialog to the option in the folder wizard.
 2020-12-15 10:57:50 +01:00
Christian Kamm
7dc65b060d
NSIS: Register placeholder extension 
Also change the placeholder suffix config option to not include the dot,
the dotless form is needed in the nsis script.
 2020-12-15 10:57:50 +01:00
Christian Kamm
12d6f680f2
Placeholders: Ignore placeholder files in older clients 
To do this, we add the placeholder extension to the user exclude file
automatically. However, newer clients shouldn't use that exclude
pattern: so we also add version directives that allow making exclude
patterns dependent on the client version.
 2020-12-15 10:57:49 +01:00
Christian Kamm
d6078f958b
Placeholders: Download from shell integration 2020-12-15 10:57:49 +01:00
Olivier Goffart
91f53521ae
Placeholder: The extension is now a branding option 2020-12-15 10:57:49 +01:00
Olivier Goffart
a2bdd5b9a5
Placeholders: Fixup clicking on placeholder after previous change 
Now that the name in the db is the name of the placeholder file,
we need to adjust the call to downloadPlaceholder
 2020-12-15 10:57:49 +01:00
Christian Kamm
b1de184bc8
Placeholders: Safe migration to older client versions 
Now the db entries for placeholders will have the full placeholder
paths. That way older clients will, on remote discovery, delete the
placeholders and download the real files.
 2020-12-15 10:57:48 +01:00
Olivier Goffart
d233e5f8d7
Placeholders: install mimetype on linux 2020-12-15 10:57:48 +01:00
Olivier Goffart
7eeb99ba24
Placeholders: Add an checkbox in the FolderWizard to enable the placeholder feature 2020-12-15 10:57:48 +01:00
Olivier Goffart
1049fb74d9
Placeholders: Move the placeholder option from the account to the folder 2020-12-15 10:57:48 +01:00
Olivier Goffart
6ce7c7a56b
PlaceHolders: Trigger a download of the placeholder and open it 2020-12-15 10:57:48 +01:00
Kevin Ottens
8c4bd2bb52 Ensure a sync happens after a conflict resolution 
You'd expect that after a conflict resolution the file watcher would
pick up the change and trigger a sync. For some reason it doesn't seem
to happen on at least some Ubuntu systems. In such cases the user would
then still have a stale conflict entry in the activity list and wouldn't
be able to do anything with it.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-12-15 09:40:57 +00:00
Kevin Ottens
d640076454 UserModel: check indices are inside the user list 
The model was just checking for the user list being empty or not which
is overly optimistic. Indeed there might be cases where the id is
actually outside the boundaries so properly check for this.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-12-15 08:43:32 +00:00
Kevin Ottens
5ed397a430
Have the new account wizard open again 
UserModel can't be connected to AccountSettings if the settings dialog
doesn't exist. This is the case now since we delay the creation of that
dialog and free it after use.

Instead it should be properly channeled through the Systray object all
the way up to OwncloudGui which knows how to handle this properly.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-12-14 15:58:52 +01:00
Camila
b4dc682690
Handle the warning message when unchecking folders for syncing. 
Split widgets and slot to handle the refreshing of the view:
- refreshSelectiveSyncStatus is connected to signal dirtyChanged
and will handle big folder warning.
- slotSelectiveSyncChanged  which is connected to dataChanged signal
and will handle the selective sync warning. It fixes #1029 because
it looks for the checkbox state before showing the warning.

Signed-off-by: Camila <hello@camila.codes>
 2020-12-14 12:36:51 +01:00
Camila
cfbd22b5e7
Use the icon color property to color the icons in the tray window header. 
The icon color is set with APPLICATION_WIZARD_HEADER_TITLE_COLOR in the
theme.

Signed-off-by: Camila <hello@camila.codes>
 2020-12-10 17:43:45 +01:00
allexzander
9266ecc2e8 Fixed slow sharee search in the share dialog 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2020-12-08 13:48:43 +00:00
allexzander
6e8658dc2c Added sharing via email. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2020-12-08 11:08:45 +02:00
Camila
5517ff2c02
Add debug log to check which folders are being skipped during syncing. 
Signed-off-by: Camila <hello@camila.codes>
 2020-12-03 12:24:25 +01:00
allexzander
f04281cb69 Implemented notification action buttons and context menu for confirm/dismiss and other actions. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2020-12-02 08:08:37 +00:00
Brian Kendall
f9991e180c Fix macOS bug where tray window causes spaces to switch 
Signed-off-by: Brian Kendall <brian@briankendall.net>
 2020-12-02 06:54:16 +00:00
Dominik Schmidt
a50c665051
Simplify Sparkle handling in CMake 2020-11-25 09:43:59 +01:00
Chih-Hsuan Yen
6962cbf582
Fix build without Sparkle.framework 
(PR #6567)
 2020-11-25 09:40:20 +01:00
Christian Kamm
60d3696ccd
Settings: Add warning when switching update channel 2020-11-25 09:39:16 +01:00
Kevin Ottens
4906353f2e Please the clang-tidy overlord 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-11-24 18:22:33 +00:00
Hannah von Reth
038644f378 Don't scare users with critical parser log messages 2020-11-24 18:22:33 +00:00
Hannah von Reth
d30cd0f0fd Include architecture in updater query 
Fixes: #8074
 2020-11-24 18:22:33 +00:00
Hannah von Reth
c76095859a Cleanup stirngs 2020-11-24 18:22:33 +00:00
Olivier Goffart
a7f010c370 Updater: Fix crash when there is an XML error 
The problem was accessing the lines with an off by one error, while printing
the log.

Other problem included the fact that QDebug added spaces, quotes, and other
things which made the error lot look right in the console.

Issue #7545
 2020-11-24 18:22:33 +00:00
Olivier Goffart
1bf895cadc Updater: Fix Version numer not shown in the user visible string 
There was one argument too many in the string.
Bug was introduced in commit 21ac396b

Issue: #7288
 2020-11-24 18:22:33 +00:00
Christian Kamm
c58f00abc7 Updater: Improved logging output #7388 2020-11-24 18:22:33 +00:00
Hannah von Reth
1df3f5b6df NSISUpdater: Improve logging for version comparison 2020-11-24 18:22:33 +00:00
Hannah von Reth
1aca005267 Updater: Log parsing issues in autoupdatLog parsing issues in autoupdatee 2020-11-24 18:22:33 +00:00
Markus Goetz
9a375211d7 Autoupdater: Log the URL #3475 2020-11-24 18:22:33 +00:00
Christian Kamm
d2991210c5 Updater: Preserve target version string 
For #7217
 2020-11-24 18:22:33 +00:00
Christian Kamm
aa7409f401 Updater: Make "Update manually" not also "skip this version" 
See #7217
 2020-11-24 18:22:33 +00:00
Christian Kamm
0b3512f49c WinUpdater: More useful options on update failure #7217 
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-11-24 18:22:33 +00:00
Olivier Goffart
9596eb7f20 Updater: show the human readable version in the settings 
The xml looks like this:

   <version>2.5.0.328</version>
   <versionstring>ownCloud Client 2.5.0 alpha1 (build 238)</versionstring>

And we should show the version string

Issue #6602
 2020-11-24 18:22:33 +00:00
Olivier Goffart
f2c3ef741b Updater: remove unused function 2020-11-24 18:22:33 +00:00
Dominik Schmidt
ae38b88d1c Remove unused installers before copying new ones into the appdata dir 2020-11-24 18:22:33 +00:00
Olivier Goffart
e93972824d MSI: Fix crash in the auto updater 
'auto' here is a QStringBuilder referencing a temporary

Ammend commit 150d4f5935
(MSI: Always with logfile #6609)

Found in the crash reporter:
https://sentry.io/owncloud/desktop-win-and-mac/issues/623245771/
 2020-11-24 18:22:33 +00:00
Markus Goetz
5e518419de MSI: Always with logfile #6609 2020-11-24 18:22:33 +00:00
Dominik Schmidt
d069fda9ab Extract filename of updateFile without leading slash 2020-11-24 18:22:33 +00:00
Dominik Schmidt
dfac8c0e59 Escape msi and owncloud.exe path (who knows...) 2020-11-24 18:22:33 +00:00
Dominik Schmidt
ed0dc68db2 Run msi properly and restart client after update 2020-11-24 18:22:33 +00:00
Dominik Schmidt
08b5981fb6 Implement basic .msi support in updater 2020-11-24 18:22:33 +00:00
Markus Goetz
412e43b696 Updater: Comments 2020-11-24 18:22:33 +00:00
Christian Kamm
4b39731c27 Updater: Make sparkle updater respect release channel 2020-11-24 18:22:33 +00:00
Markus Goetz
311e3a3bd8 Auto Updater: Show UI element also on macOS 
(cherry picked from commit dfdc2e1e87f99d387a042f4983c999fbb7fcf3d9)
 2020-11-24 18:22:33 +00:00
Christian Kamm
a8ad946758 Settings: Add update channel combobox #6259 2020-11-24 18:22:33 +00:00
Markus Goetz
65035d1990 Sparkle: Delegate calls work now with 1.18.1 (maybe even before) 
We can extend on this to give UI feedback.
 2020-11-24 18:22:33 +00:00
Christian Kamm
08014b6dc3 FolderWatcher: Disable test on OSX #7305 2020-11-24 16:56:49 +00:00
Olivier Goffart
5a432a193f FolderWatcher: Usage of QTime for elapsed time is deprecated 2020-11-24 16:56:49 +00:00
Christian Kamm
28e4fc54a1 FolderWatcher: Wait for ready before testing #7305 2020-11-24 16:56:49 +00:00
Christian Kamm
e97fc430bf FolderWatcher: Become unreliable if test notification fails #7241 
Necessary for some filesystems on windows that don't have full file
watching capabilities.
 2020-11-24 16:56:49 +00:00
Christian Kamm
74382ddcc0 FolderWatcher linux: Make automatically recursive #7068 
Previously it depended on addFolder() / removeFolder() calls to adjust
watchers when new folders were added or removed. There also needed to be
complex move handling.

Now, any folder creation/move-in notifications automatically trigger
watcher additions and folder deletion/move-out triggers removal.
 2020-11-24 16:56:49 +00:00
Christian Kamm
21b931dc6b FolderWatcher: Always notify about conflict files #7073 
This makes sure that the conflict list can be updated if a user resolves
a conflict by deleting the local conflict file. Previously one had to
wait for the next sync run.
 2020-11-24 16:56:49 +00:00