Commit graph

3804 commits

Author SHA1 Message Date
Camila
fc2408cf41 Add contrast to the text/icon of buttons if the server defined color is light.
Signed-off-by: Camila <hello@camila.codes>
2022-06-21 11:49:30 +02:00
Claudio Cambra
8267136013 Rephrase button text to be in line with clients on other platforms
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-06-15 12:52:12 +02:00
Claudio Cambra
281e50f4cd Prevent call dialogs from being presented when do not disturb is set as the user status
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-06-10 11:30:16 +02:00
allexzander
d7217d1c07
Merge pull request #4622 from nextcloud/feature/generate-state-icons-from-svg
Feature/generate state icons from svg
2022-06-10 12:15:45 +03:00
Claudio Cambra
9dd9c46493 Do not compile things that require the app bundle when building the client without the app bundle on macOS
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-06-10 10:43:36 +02:00
alex-z
6ef296d823 Generate state icons from SVG in CMake.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-06-10 11:37:29 +03:00
Claudio Cambra
4bdfe59270 Fix builds on macOS versions pre-11
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-31 11:10:17 +02:00
rakekniven
276616d211 l10n: Fixed grammar
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2022-05-30 10:12:33 +02:00
Camila
6ff82659ac Change color of text field to ncTextColor instead of ncSecondaryTextColor.
Signed-off-by: Camila <hello@camila.codes>
2022-05-25 12:08:53 +02:00
Camila
f911c546d9 Add a transparent background to the send reply button.
Signed-off-by: Camila <hello@camila.codes>
2022-05-25 12:08:53 +02:00
Camila
282aadb7e9 Reduce spacing above the notification buttons.
Spacing is now the  same as space between lines in the text above.

Signed-off-by: Camila <hello@camila.codes>
2022-05-25 10:01:38 +02:00
Camila
2fa834446a Fix 'TypeError: Cannot readproperty 'messageSent' of undefined'.
Signed-off-by: Camila <hello@camila.codes>
2022-05-24 11:51:55 +02:00
alex-z
43a37637cf Display chat message inside the OS notification.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-05-23 17:01:22 +03:00
alex-z
e40142847b Add and use DO_NOT_REBOOT_IN_SILENT=1 parameter for MSI to not reboot automatically when running from the updater.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-05-19 12:52:40 +03:00
Claudio Cambra
a2cc2ace4a Explicitly ask user for notification authorisation on launch
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-19 10:59:12 +02:00
alex-z
be23e747de Stretch WebView to fit dialog's height.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-05-18 10:57:10 +03:00
Matthieu Gallien
d622999971 add explicit capture for lambda
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-05-17 13:33:22 +02:00
Valdnet
f4931026d7
i18n: Add a space
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-05-17 09:08:37 +02:00
Valdnet
83415062ba
i18n: Change three dots to an ellipsis
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-05-17 09:06:20 +02:00
Claudio Cambra
2d74a5752e Fix label borking and wrong icon colours in the share dialog
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-16 22:59:00 +02:00
Camila
290851c33a Convert primary, WEB and DELETE notification links to action buttons.
Signed-off-by: Camila <hello@camila.codes>
2022-05-16 22:03:53 +02:00
Camila
9c63615a78 Do not add a second DELETE to the list of actions in one notification.
Signed-off-by: Camila <hello@camila.codes>
2022-05-16 22:03:53 +02:00
Claudio Cambra
31f3800d0d Fixed share link expiration box being ineditable and always reloading invalid date
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-16 18:51:12 +02:00
alex-z
53654b2a50 Allow manual renaming of files and folders with spaces. Allow uploading invalid file name via the InvalidFileName dialog.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-05-16 18:07:26 +03:00
Claudio Cambra
463496153a Fixed several issues with activity items relating to icon colouration and activity item sizing + layout
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-16 16:42:53 +02:00
Claudio Cambra
364d02a13f Actually reset menu when user accounts are added or removed
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-16 16:42:20 +02:00
alex-z
101a92faf3 Bugfix. Take root folder's files size into account when displaying the total size in selective sync dialog.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-05-16 17:40:30 +03:00
Claudio Cambra
b6def51945 Fix notifications not being shown when they should be
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-16 14:28:33 +02:00
alex-z
514f72f975 Use proper online status for user ('dnd', 'online', 'invisible', etc.) to enable or disable desktop notifications.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-05-16 10:47:05 +03:00
Camila
e4a0d57bc8
Do not replace strings in action links coming from the notification api.
Signed-off-by: Camila <hello@camila.codes>
2022-05-12 12:47:48 +02:00
Claudio Cambra
c22d5959b8 Reimplement notifications for macOS and add support for actionable update notifications
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-11 17:33:33 +02:00
Matthieu Gallien
553d324d3d only add OCS-APIREQUEST header for 1st request of webflow v1
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-05-10 09:39:35 +02:00
rakekniven
ad17d39817 l10n: Remove string from translation
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2022-05-06 08:48:55 +02:00
Philip Allgaier
e75f37bf2e Remove "…" from "Create Debug Archive" button
Looks like an ellipsis (as if some text is cut off), but that is not the case => clearer without the dots

Signed-off-by: Philip Allgaier <philip.allgaier@gmx.de>
2022-05-05 22:26:58 +02:00
Claudio Cambra
cdae0a56d5 Stop dumping cache data in home dir, cache in default cache location
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-05 14:31:31 +02:00
rakekniven
994c2e02d8 l10n: Changed triple dot to ellipsis
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2022-05-04 11:33:47 +02:00
Claudio Cambra
7129bf2489 Add user avatars in talk notifications in activity list
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-02 15:12:45 +02:00
Claudio Cambra
a5019f1f8e Add some logging
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-02 14:57:47 +02:00
Claudio Cambra
22e42ac6d3 Fix macOS autoupdater
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-02 14:57:47 +02:00
Matthieu Gallien
702e9abe4b display lock info in share dialog
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-05-02 13:52:05 +02:00
Matthieu Gallien
2d27a68e73 show errors on lock/unlock actions
use a native dialog to show users errors when trying to lock/unlock
files

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-05-02 13:52:05 +02:00
Matthieu Gallien
b55a099b61 allow lock/unlock of files from files explorer integration
add new commands to the contextual menu provided by our files explorer
plugins to allow locking/unlocking a file

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-05-02 13:52:05 +02:00
alex-z
7b441a0f6e Optimize activities fetch requests. Do not fetch when the Tray is not open. Fetch next subset only when scrolling. Fix duplicate notifications.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-04-29 20:59:56 +03:00
Matthieu Gallien
558c6cb1f6
adjust API of retry count to have everything private and simpler
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-04-29 12:53:38 +02:00
Matthieu Gallien
6798f2ca31
obsolete and no longer needed
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-04-29 12:31:32 +02:00
Matthieu Gallien
a6571e2d8a
improve readability of computation of currentDelay recoonect time
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-04-29 12:29:45 +02:00
Matthieu Gallien
4e348db1d0
increase time between connection tries
each time we do a failed attempt to connect increase the time until the
next try

use an elapsed timer to ensure we do properly wait between each attempt

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-04-29 12:15:15 +02:00
Claudio Cambra
3f5243aaee Add an incoming talk call notification to the desktop client
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>

Co-authored-by: Camila <hello@camila.codes>
2022-04-28 09:13:13 +02:00
Claudio Cambra
010f49a392
Realigned and resized thumbnails
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-04-27 18:02:37 +02:00
Claudio Cambra
15078260b4
Removed spacing between activies, labels now centre-aligned
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-04-20 18:07:41 +02:00
Claudio Cambra
7b65c1ceed
Fix thumbnails for new files made while client open
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-04-19 10:16:43 +02:00
Claudio Cambra
5ce736222e Use header text color to improve contrast with header colours when hovering on themed elements
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-04-15 13:17:09 +02:00
Camila
74d214726c
Remove unused function parameter.
Signed-off-by: Camila <hello@camila.codes>
2022-04-06 10:38:01 +02:00
Camila
6189b2115e
Adress design issues.
- The input field was not using the  theming.
- After submitting the reply, the text and icon on the left were moving.

Signed-off-by: Camila <hello@camila.codes>
2022-04-06 10:38:01 +02:00
Camila
f524635cf4
Do not hide'View chat' link.
This logic was also hiding 'Answer call'.

Signed-off-by: Camila <hello@camila.codes>
2022-04-06 10:38:01 +02:00
Camila
ead4eeda1e
Windows fix: activityIndex was not being passed to the lambda slot function.
Signed-off-by: Camila <hello@camila.codes>
2022-04-06 10:38:00 +02:00
Camila
c254572e80
Add 'Reply' as activity link instead of changing the 'View chat' link.
- Align 'Reply' button.
- Do not display 'View chat' as a link: the 'View chat' action is active when
the user clickcs on the notification item in the tray window.
- Convert the QByteArray verb value to String.
- Handle logic to toggle the reply textfield in the QML code.

Signed-off-by: Camila <hello@camila.codes>
2022-04-06 10:38:00 +02:00
Claudio Cambra
a2e1c68c26 Fix broken activity icon and loading entries colour in unified search
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-04-05 16:41:11 +00:00
alex-z
71b610eee3 Remove redundant _guiAppInstance
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-04-01 08:41:35 +00:00
Camila
7cc2486d79
Address PR comments.
Signed-off-by: Camila <hello@camila.codes>
2022-03-28 16:04:54 +02:00
Camila
9b00e5268e
Rename functions.
Signed-off-by: Camila <hello@camila.codes>
2022-03-28 16:04:54 +02:00
Camila
a46482ca91
Fix background color so it switches with light/dark theme.
Signed-off-by: Camila <hello@camila.codes>
2022-03-28 16:04:54 +02:00
Camila
0890a78262
Display input once user clicked on Reply.
Signed-off-by: Camila <hello@camila.codes>
2022-03-28 16:04:54 +02:00
Camila
b2056187a0
Let qml know the message reply was sent.
Signed-off-by: Camila <hello@camila.codes>
2022-03-28 16:04:54 +02:00
Camila
94530b6305
Rename data role.
Signed-off-by: Camila <hello@camila.codes>
2022-03-28 16:04:53 +02:00
Claudio Cambra
3d086ae305 Fix dark mode stuff relating to unified search, fix macOS auto dark/light theme switching not always working, fix Windows detection of dark/light theme switching
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-03-28 09:21:35 +00:00
Matthieu Gallien
99c0aadabe
ensure we only store update channel not localized in settings
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-03-23 17:35:39 +01:00
Claudio Cambra
bbd988d8c5 Fixes to UI issues
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-03-20 16:32:43 +00:00
Claudio Cambra
98e297bf0b Fix for VFS crashes
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-03-19 23:31:24 +01:00
Claudio Cambra
c342c304ac Added dark mode
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-03-18 16:43:15 +00:00
Claudio Cambra
97801a5acb Fix warn colour in dark mode
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-03-18 12:08:12 +01:00
Matthieu Gallien
541447723a remove all usage of QDateTime::toTime_t() to avoid overflow
QDateTime::toTime_t() can overflow if called with a date outside its
domain of working

this method is obsolete and QDateTime::toSecsSinceEpoch() is the
replacement

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-03-17 23:28:02 +00:00
Camila
73bae8cd30
Add TalkReply class and tests.
- Add struct TalkNotificationData to handle token and messageId.
- Handle chat and call notifications with the new struct.
- Add talk token and messageId to data roles in ActivityListModel.
- Add Talk Reply component to the ActivityList.
- User Loader to display the TalkReply component.
- Move Talk Reply from ActivityItem to ActivityItemContent due to PR #4186.
- Use TextField instead of Text.
- Disable send reply button instead of changing border color when field is empty.

Signed-off-by: Camila <hello@camila.codes>
2022-03-17 17:50:33 +01:00
Claudio Cambra
628ee10008 Implement local socket to communicate with finder extension
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-03-17 11:46:57 +00:00
Claudio Cambra
65f2bada3e Add thumbnails for files in the activity view
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-03-17 10:46:09 +00:00
Claudio Cambra
f585b8bd48 Add support for server color theming by using server color as accent
color

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-03-16 13:57:45 +01:00
Claudio Cambra
02f3a1aed6 File activity dialog now works for all file actions activities (e.g. deleted files)
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-03-16 08:38:14 +01:00
Claudio Cambra
ead4cc6fe3 Increase max line of text in activity item text to two
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-03-15 09:22:11 +00:00
Claudio Cambra
2f795df701 Ensure file activity dialog appears in centre of screen
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-03-13 22:11:26 +00:00
Matthieu Gallien
11e7ebd5fa properly ask Qt to create qml opengl surface with proper options
should prevent context losses error with some opengl drivers

should prevent corruptions to occur with come opengl drivers

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-03-10 14:19:46 +00:00
Camila
2c20f81a53 Add 'Help' action back.
I think it was a mistake that caused this.

Signed-off-by: Camila <hello@camila.codes>
2022-03-03 11:16:09 +00:00
Claudio Cambra
f6b377ab17 Simplify currentScreen
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-03-02 13:37:30 +00:00
Claudio Cambra
655a2e1c39 No longer assume status bar height, calculate, fixing notch borking
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-03-02 13:22:55 +01:00
Matthieu Gallien
4371c0cbfe add headers in cmake files to get them properly detected
qt creator for example requires that headers are explcitly given in the
source lists

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-02-11 14:31:22 +00:00
alex-z
ae44dd5978 Adjust icons for activity entries in main dialog. Refactor the dialog by splitting it to separate components.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-02-04 17:52:37 +02:00
alex-z
0776df65c3 Always build with updater. Use 'beta/stable' channel seletor in 'General Settins' dialog with default 'stable'.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-02-02 10:46:11 +00:00
alex-z
0ea7e8d3a6 Cmake option to disable proxy
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-02-02 10:02:34 +00:00
Claudio Cambra
a2524763c8
Merge branch 'master' into bugfix/account-menu-scroll 2022-02-01 17:01:51 +01:00
Claudio Cambra
ce5494b4ec Add testing for ActivityListModel
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-02-01 13:57:08 +00:00
Claudio Cambra
7a1eae45d3 Account menu can now scroll
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-01-31 15:06:55 +00:00
Claudio Cambra
624213956e Add ability to copy internal link from share dialog
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-01-24 09:40:28 +00:00
Felix Weilbach
12610baeba Replace Text with Label
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2022-01-17 11:11:57 +00:00
Felix Weilbach
f4bf4da44d Remove commented out code
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2022-01-17 11:11:57 +00:00
Felix Weilbach
99457e8c38 Use the font size that Qt suggest
Fixes: https://github.com/nextcloud/desktop/issues/3797

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2022-01-17 11:11:57 +00:00
Claudio Cambra
2a27882307 Show only filenames in tray activity items, with full path in tooltip
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-01-14 08:02:08 +00:00
Camila
fd8186ff0e ShareDialog: group links and users in one scrollbar.
- Remove the scrollbar used only for user shares
- Resize share dialog when removing share links
- Fix widget margins and max height of the share dialog
- slotAdjustScrollWidgetSize => adjustScrollWidgetSize

Signed-off-by: Camila <hello@camila.codes>
2022-01-13 10:39:11 +00:00
Camila
82aed71d09 Just trying to make the sahre dialog look nicer.
Signed-off-by: Camila <hello@camila.codes>
2022-01-13 10:39:11 +00:00
Camila
c08a291742 Remove unused slots.
Signed-off-by: Camila <hello@camila.codes>
2022-01-13 10:39:11 +00:00
Camila
a10f84b5c1 Add scroll area for share links.
Signed-off-by: Camila <hello@camila.codes>
2022-01-13 10:39:11 +00:00
alex-z
3aaaaaf2d0 Bugfix. Re-init sharing manager to enable link sharing UI when receiving sharing permissions.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-01-13 10:42:48 +02:00
alex-z
39d1ca3a3c Fix review comments.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-01-12 10:36:25 +00:00
alex-z
39e2292acd Fix review comments.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-01-12 10:36:25 +00:00
alex-z
3d7fc166b4 Fix review comments.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-01-12 10:36:25 +00:00
alex-z
4a8433d297 Display error message when creating a link share with compromised password.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-01-12 10:36:25 +00:00
Claudio Cambra
f23c7007a5 Fix space
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-01-07 17:48:31 +00:00
Claudio Cambra
a1d42b4177 Make compiler required when option is on, removed unused def
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-01-07 17:48:31 +00:00
Claudio Cambra
8ad04f5a5e Remove AUTORCC
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-01-07 17:48:31 +00:00
Claudio Cambra
e25140d72e Add option of enabling QtQuick compiler
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-01-07 17:48:31 +00:00
alex-z
62b0a9b9f1 Try to sign-in after being signed-out due to SslHandshakeFailedError
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-01-05 10:01:13 +02:00
Claudio Cambra
8c091a2daa Hide share button for deleted and ignored files in tray activity
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2021-12-20 16:07:11 +00:00
alex-z
2482ca7ea7 Fix CMake error in ECMAddAppIcon for mac.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2021-12-14 17:31:21 +00:00
alex-z
3f3b752e44 Save folder settings to config when force-switching VFS.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2021-12-14 16:33:35 +02:00
alex-z
1244e96681 Enforce VFS. Disable 'Make always available locally'.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2021-12-14 15:03:57 +02:00
alex-z
77bf892809 Use different icon for a sync folder on Windows depending on zoom level.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2021-12-07 15:48:16 +00:00
alex-z
25785841a3 Always prefill username from Windows login name based on server version
Signed-off-by: alex-z <blackslayer4@gmail.com>
2021-12-03 11:08:35 +02:00
alex-z
b03bf1c1f0 Pass username from Windows to login page.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2021-11-24 10:04:22 +00:00
alex-z
b3914f627d Cleanup system bindings from Windows when removing a local sync folder
Signed-off-by: alex-z <blackslayer4@gmail.com>
2021-11-23 08:32:55 +00:00
Matthieu Gallien
684d70985e fix button that should be disabled when force VFS
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-11-22 14:22:59 +01:00
Matthieu Gallien
12c6d6e3bd add a network access factory to qml engine
ensure network access made via qml are using our user agent

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-11-22 12:21:58 +00:00
Carl Schwan
38ac585e7c Add WheelHandler to the Search result list too
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-11-22 11:18:18 +00:00
Carl Schwan
892d289f38 [tray] Makes scrolling with a touchpad in activiy list more natural
This basically use the same method that is used in Kirigami and Plasma
Components3.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-11-22 11:18:18 +00:00
Matthieu Gallien
f1d834df8e properly query sync journal DB to know when to run fix for VFS
the new method added to query the db is not working and so the fix for
vfs is executed at each sync run

the new method for bool was not really needed so let's just remove it
(and that will make the usage of SqlQuery be correct

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-11-19 14:19:04 +01:00
alex-z
911e35bc50 Use QUrl::fromLocalFile to open local files in Unified Search results.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2021-11-18 09:34:54 +00:00
Felix Weilbach
c76a77e431 Correct virtual files placeholder files if needed
In the past not all files were converted to placeholder files when
converting an existing sync folder to a virtual files folder. Because
some files were not converted to placeholder files, the status would
be wrong on the files. This code makes sure that every file in a
virtual files folder is a placeholder file. It could be removed in the
future.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-11-17 09:53:26 +00:00
Matthieu Gallien
c59f88ca82 avoid adding icon data in a cache we never use
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-11-16 16:11:44 +01:00
Carl Schwan
d84673376d More fixes to the menu implementation
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-11-16 09:27:10 +00:00
Carl Schwan
69def04ec2 Fix focus indicator
This improve considerably the keyboard navigation in the SystemTray.
But this is still not as good as the golden standard that is recommended
by this article: https://www.sarasoueidan.com/blog/focus-indicators/

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-11-16 09:27:10 +00:00
Felix Weilbach
07a8e8c91d Check if the server has user status app enabled
According to
https://docs.nextcloud.com/server/latest/developer_manual/client_apis/OCS/ocs-status-api.html#user-status-retrieve-statuses
we should check the user status capability, not the the end points.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-11-15 16:20:58 +00:00
Alexander Batischev
d8560dcb19
CMake: fail if Qt5::GuiPrivate is not found
`nextcloud` and `nextcloudCore` depend on three Qt5 components which
aren't mentioned in `find_library`: `Xml`, `Network`, and `GuiPrivate`.
The first two are omitted by mistake, apparently, so this commit just
adds them.

`GuiPrivate` is a special case: it doesn't have its own CMake config, so
adding it to "required components" in `find_package` will always fail
the build. Thus, we implement our own check instead.

Signed-off-by: Alexander Batischev <eual.jp@gmail.com>
2021-11-15 13:57:18 +03:00
Felix Weilbach
3e368ee4df IconJob: Send request through the accounts NAS
This helps tracking requests on the server

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-11-10 13:11:49 +01:00
Felix Weilbach
db337c4457 Add profile page
Fix: #3889

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-11-10 13:11:47 +01:00
Matthieu Gallien
5ab13b2adc add an option to enforce use of virtual files sync folder
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-11-05 16:56:24 +01:00
alex-z
2f3c58daac Fix review comments. Use QImage for QML and QPixmap for rest of code. Do not cache images for QML. Fix tests. Use signal in QML.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2021-11-04 20:50:51 +00:00
alex-z
0b8ab5c079 Use SvgRenderer for Unified Search input icons. Refactor IconUtils. Extend unit tests.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2021-11-04 20:50:51 +00:00
alex-z
0d8375e798 Clear Unified Search Input Field in a proper way
Signed-off-by: alex-z <blackslayer4@gmail.com>
2021-11-04 20:50:51 +00:00
Felix Weilbach
d661e91a58 Don't do a connection checks when using push notifications
When using push notifications, it is not necessary to do regular
connection checks because the push notifications will take care of it.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-11-04 18:07:22 +00:00
Matthieu Gallien
9658aea963 on switch to VFS real plugin, convert existing files to placeholders
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-11-04 15:02:27 +01:00
alex-z
d88e086b94 ShareLinkWidget. Fix incorrect calendar mindate.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2021-11-03 13:23:00 +02:00
alex-z
6c3c45dadd Implement expiration date for federated shares
Signed-off-by: alex-z <blackslayer4@gmail.com>
2021-11-03 10:54:18 +00:00
alex-z
c52718c104 Replace deprecated QRegExp with QRegularExpression.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2021-11-02 08:54:06 +00:00
Matthieu Gallien
8226c30d84 by default we produce debug logs because we need them
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-10-28 13:48:55 +00:00
Camila
d68b8604ac Refactor toggleButtonAnimation function.
Signed-off-by: Camila <hello@camila.codes>
2021-10-28 12:59:28 +00:00
Camila
ab524d2392 Fix display of deleted note.
Even after removing note from share link,
the previous text was being displayed.

Signed-off-by: Camila <hello@camila.codes>
2021-10-28 12:59:28 +00:00
Camila
72c91362f2 Refactor ShareLinkWidget show/hide widgets functions.
- Remove unecessary call to setupUiOptions after saving share password.
- Slot to create label: do not set it if nothing changed.
- Refactor showPasswordOptions, toggle/PasswordOptions/ExpireDateOptions/NoteOptions.
- Add const, auto and {} whenever possible.
- Refactor slotToggleButtonAnimation => toggleButtonAnimation.

Signed-off-by: Camila <hello@camila.codes>
2021-10-28 12:59:28 +00:00
alex-z
db4e54025a Forbid trusting the untrusted certificate.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2021-10-27 07:23:42 +00:00
alex-z
907ebc1959 Request OCSP validation data from the server during the SSL handshake.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2021-10-27 07:23:42 +00:00
rakekniven
c39b97adb3
Update UnifiedSearchInputContainer.qml
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2021-10-26 10:44:07 +02:00
rakekniven
beffd63512
Changed triple dot to ellipsis
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2021-10-26 07:35:47 +02:00
Matthieu Gallien
69d6f4acec our source code files have lower case names
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-10-25 15:38:21 +02:00
alex-z
c1dab7e4cb Unified Search via Tray window
Signed-off-by: alex-z <blackslayer4@gmail.com>
2021-10-25 14:45:05 +03:00
rakekniven
91884eef4a Changed wording to suggestion
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2021-10-23 07:06:23 +00:00
rakekniven
fb3c740129 Changed wording of status message
The files themselves have no problem. The sync process has problems. 

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2021-10-23 07:06:23 +00:00
Felix Weilbach
9f35fa6d3d Also update sync state summary based on connectivity
Otherwise, with zero folders configured, the state will stay at
offline.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-10-20 12:31:55 +02:00
alex-z
bd731a9cda Windows. Remove CWD from DLL search paths.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2021-10-19 06:40:56 +00:00
Felix Weilbach
d51bfec61d Remove unnecessary braces
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-10-14 19:56:39 +00:00
Felix Weilbach
f27ef02273 Set dialog max and min width and height before width and height
Otherwise, resize events will not be processed correctly.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-10-14 19:56:39 +00:00
Felix Weilbach
0792dc36c2 Check if current user exists before getting it's account state
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-10-13 11:25:13 +02:00
Felix Weilbach
4c11f6763e Show sync progress in main dialog
Fixes #3662

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-10-12 16:14:24 +00:00
Matthieu Gallien
d76778e3ee fix macOs build after targets name are not changed by branding
target names used to be variable depending on branding
now the target names are always constant but generated output file names
are set according to active branding

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-10-11 07:41:29 +00:00
Felix Weilbach
2da6dab403 Add missing copyright headers
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-10-08 13:19:10 +02:00
Kevin Ottens
5fe63a4d9a Display the right endpoint in the warning in case of error
At that point in time _pollEndpoint isn't set yet. All the checks are
against pollEndpoint so display that one in the warning. Otherwise one
always end up with an empty URL in the logs which is not very useful for
debugging purposes.

Signed-off-by: Kevin Ottens <kevin.ottens@enioka.com>
2021-10-06 10:17:38 +00:00
Matthieu Gallien
833237b2e4 use alias target for internal libraries
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-10-06 07:56:33 +00:00
Felix Weilbach
0c9dce1154 Add file activity dialog
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-10-05 12:41:34 +00:00
Camila
df38e5c08b Apply server default permissions for federated file sharing too.
See nextcloud/server#24729 comments.

Signed-off-by: Camila <hello@camila.codes>
2021-09-27 08:53:45 +00:00
Camila
8f847906c6 Check server capabilities for file sharing default permissions.
Signed-off-by: Camila <hello@camila.codes>
2021-09-27 08:53:45 +00:00
rakekniven
68e02bc62d Fixed context
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2021-09-27 07:25:08 +00:00
rakekniven
49e1b12eb1 Fixed grammar
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2021-09-27 07:25:08 +00:00
Felix Weilbach
d3d8b1c631 Add dialog to resolve invalid filenames
Fixes #3751

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-23 10:45:15 +00:00
Matthieu Gallien
ac28cc1cf5 set default format for QSurface to handle NVidia context loss events
should fix wrong OpenGL rendering after suspend on Linux with NVidia
binary OpenGL driver

close #3759

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-09-22 08:56:16 +00:00
alex-z
59199fc907 General Settings window. Allow opening the update URL via mouse.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2021-09-21 16:21:38 +02:00
Camila
db447c4676 Refactor OcsShareJob creation.
Signed-off-by: Camila <hello@camila.codes>
2021-09-21 10:01:20 +00:00
Camila
ba8ec56e65 Add option to create label for share link.
Signed-off-by: Camila <hello@camila.codes>
2021-09-21 10:01:20 +00:00
Matthieu Gallien
19b77416da TextInput by default do not allow selecting text by mouse
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-09-21 08:07:19 +00:00
Felix Weilbach
0074d6c40a Disable Qt deprecation warnings
They don't help us during regular development and some of them are not
fixable (e.g. QNetworkMangerConfiguration) in the open source variant
of Qt5.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-17 13:32:26 +00:00
Felix Weilbach
fb1b3481d1 Fix warnings
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-17 13:32:26 +00:00
Camila
e4e74ff38f Display share note when there is one associated with a share link.
Signed-off-by: Camila <hello@camila.codes>
2021-09-17 06:57:08 +00:00
Camila
4581279d23 Fix indentation sharelinkwidget.h.
Signed-off-by: Camila <hello@camila.codes>
2021-09-17 06:57:08 +00:00
Felix Weilbach
8370c9c1ca Accept nc scheme in provider page
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-14 09:01:18 +00:00
Felix Weilbach
9aee46b3a4 Remove unnecessary logging statements
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-14 07:26:46 +00:00
Valdnet
a441d733dc l10n: Correct two typo
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-09-10 12:25:34 +02:00
Felix Weilbach
8a8d488454 Add dialog to set user status
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-09 11:18:22 +02:00
alex-z
4018f8d554 Prompt reboot when runing the auto update.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2021-09-09 07:20:19 +00:00
Felix Weilbach
5622c33f40 Fix various deprecated warnings
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-08 08:54:00 +00:00
Felix Weilbach
b6e3c6d718 Replace deprecated use of QProcess::start()
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-08 08:54:00 +00:00
Felix Weilbach
6fd0adda52 Close wizard if done
This is needed because of the changes in 02bb5db544

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-07 06:43:27 +00:00
allexzander
a3fc812539 Enable share to Talk and Email. Display correct icon. Added unit tests.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-09-06 13:27:39 +00:00
Hannah von Reth
02bb5db544 Remove wizard page that has been dead for 4 years 2021-09-03 16:08:37 +02:00
Felix Weilbach
fa37f5c2bc Don't create binding loop
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-03 11:48:42 +00:00
Felix Weilbach
8a2097e7b9 Implicitly defined onFoo properties in Connections are deprecated
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-03 11:48:42 +00:00
Felix Weilbach
ba2d8e8201 Only set dav user after login.
Setting the credentials of the account inside the auth widget is not a
good idea as that will destroy the previous credentials object which
may wait for a signal to be emitted by the credentials dialog that
was created by the credentials that are going to be deleted. Uff.

It should be enough to set the dav user only after login because the
dav user will never change.

See also the discussion here
https://github.com/nextcloud/desktop/issues/3677#issuecomment-907976839

Fixes #3677

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-03 08:32:15 +00:00
Nicolas Fella
bc3eb7845d Remove unneeded target_link_libraries
OS_SPECIFIC_LINK_LIBRARIES is always empty here

Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
2021-09-01 11:43:03 +00:00
Nicolas Fella
18ddb9df4a Use CMAKE_INSTALL_DATADIR instead of custom DATADIR
CMake provides what we wan out of the box

Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
2021-09-01 11:43:03 +00:00
Heinz Wiesinger
727de34879 Allow using rsvg-convert to generate pngs instead of inkscape
Signed-off-by: Heinz Wiesinger <pprkut@liwjatan.org>
2021-08-31 14:52:46 +02:00
Matthieu Gallien
25669938fd let clang-tidy add missing override after enabling again the check
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-08-31 08:35:56 +00:00
Felix Weilbach
44df9283fe Handle every enum value in switch statement
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-08-26 15:52:25 +00:00
Matthieu Gallien
23bd4675fd fix build socket api Mac specific file is now in a subdirectory
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-08-25 14:02:05 +00:00
Valdnet
86cb56757e l10n: Remove line break
A line break is unnecessary in this message.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-08-25 09:11:06 +00:00
Hannah von Reth
c273c8f71b Ensure the socket listener still exists 2021-08-23 09:44:34 +02:00
Hannah von Reth
4b0122093a Add socket command to upload a selection of files based on a regex
(cherry picked from commit 0ded3a56a9f3470a951b18eaa9d3c1b5e8db1135)
2021-08-23 09:44:34 +02:00
Hannah von Reth
010fccb4fa Remove dead code 2021-08-23 09:44:34 +02:00
Christian Kamm
ebaa98fa7a owncloudcmd: Use env vars for chunk sizes #7078
Moves a bunch of env var reading from Folder into SyncOptions.
2021-08-23 09:44:34 +02:00
Hannah von Reth
5b457a1663 Use byte array for etag 2021-08-23 09:44:33 +02:00
Hannah von Reth
d16befd1fd Align MkColJob finish signal with the other jobs 2021-08-23 09:40:27 +02:00
Hannah von Reth
c4f4fb48a4 Minor cleanup of socket api 2021-08-23 09:40:27 +02:00
Hannah von Reth
baa571018e Log invocation, useful for debugging startup issues 2021-08-23 09:40:27 +02:00
Nicolas Fella
43cccb0a73 Don't use variables for CMake target identifiers
This makes the code a bit nicer to read and maybe a bit more robust.

Set the relevant OUTPUT_NAME target properties to keep the ability to
customize the names of the installed binaries.

Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
2021-08-19 10:30:23 +00:00
Felix Weilbach
d706125b15 Return the login name instead of user id
App password and login name need to match. If authResult() returns the
user id the user id will be stored in webdav_user

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-08-12 14:32:07 +02:00
Felix Weilbach
ccd27870a7 Don't compare integers with different signs
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-08-11 20:20:39 +00:00
Felix Weilbach
acf6cc0527 Remove unused functions and variables
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-08-11 20:20:39 +00:00
Felix Weilbach
d72f7e9109 Check result of setPinState()
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-08-11 20:20:39 +00:00
Felix Weilbach
f9daa27a5d Enforce fetching of user id
With the change of commit 3e61bdc431 and
the relase of v3.3.0 users that had their email address used as login
are not able to login anymore. The dav_user should be empty if users
tried to create a account in the meantime. Therefore we fetch the user
id in the case dav_user (and then Account::_davUser) is empty. We then
store the user id in dav_user.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-08-11 16:16:12 +00:00
Felix Weilbach
5195264a20 Ensure that the users id is used for accessing webdav
https://docs.nextcloud.com/server/latest/developer_manual/client_apis/LoginFlow/index.html#obtaining-the-login-credentials
states that the email address can be used for login but it's not
allowed to use the email address to access webdav.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-08-11 15:26:39 +02:00
allexzander
c930d8e30f Delete apptoken after account removal.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-08-04 09:37:40 +00:00
Valdnet
dbd061c44b l10n: Replace apostrophe with double quotation. Remove double space and sort sentence.
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-08-03 15:00:53 +03:00
allexzander
fc75b94524 Fix clang-tidy errors.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-07-30 06:21:05 +00:00
Valdnet
7ebbb499e0 l10n: Replace apostrophe with double quotation
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-07-30 06:21:05 +00:00
Felix Weilbach
7bb0c588c1 Don't constrain size of hover background
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-07-28 10:29:04 +00:00
allexzander
98ae715905 Fix crash in Folder::isSyncRunning()
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-07-28 08:58:00 +00:00
Valdnet
9dee4b1a7a
Merge branch 'master' into Valdnet-patch-3 2021-07-23 09:07:18 +02:00
Valdnet
bc9d3c5936 l10n: Change to uppercase 2021-07-22 15:47:52 +00:00
Valdnet
7db51e9029 l10n: Change to uppercase
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-07-22 15:47:52 +00:00
Felix Weilbach
a421ebf01c Make main dialog normal window when displayed as regular window
This will enable users to minimize the dialog.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-07-22 10:34:13 +02:00
Felix Weilbach
302651620b Use Q_UNUSED instead of commenting out arg names
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-07-21 17:15:11 +00:00
Felix Weilbach
3f6bb4a929 Use QStringLiteral instead of plain strings
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-07-21 17:15:11 +00:00
Felix Weilbach
ee49a7ed52 Fix review comments
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-07-21 17:15:11 +00:00
Felix Weilbach
e4f92ad1a1 Enforce https in flow1 and flow2 for https connections
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-07-21 17:15:11 +00:00
Camila
6886d6213a
Add custom component ActivityItem.
That also addresses QML warnings.

Signed-off-by: Camila <hello@camila.codes>
2021-07-21 17:03:26 +02:00
Camila
79dd4f73fe Fix QML warning: Unable to assign [undefined] to QFont.
Signed-off-by: Camila <hello@camila.codes>
2021-07-21 14:46:04 +00:00
Matthieu Gallien
a8ef8bdcb8 do not block account menu: availability checking can be slow
ignore availability that can be very slow to check with CfApi virtual
files plugin

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-07-21 12:58:23 +00:00
allexzander
801e4ad363 Create QMessageBox on heap when the update is ready. Do not return true from OCUpdater to allow for a proper app::quit
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-07-21 14:23:43 +03:00
Felix Weilbach
4e95e32791 Call setClosed() on correct Object
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-07-20 12:56:00 +02:00
Felix Weilbach
89fea30a3b Remove Q_INVOKABLE from signals because it's not needed
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-07-20 12:55:37 +02:00
Felix Weilbach
12bdd8742b Remove unnused variable
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-07-20 07:43:36 +00:00
Felix Weilbach
38467b2e30 Remove unused pushNotifications variable
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-07-20 07:43:36 +00:00
Matthieu Gallien
064f64f06d fix width of user status message to not overlap other elements
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-07-16 15:19:20 +00:00
Matthieu Gallien
260e1d77f5 clean indentation in UserLine.qml
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-07-16 15:19:20 +00:00
Matthieu Gallien
c2602135ab fix size of the Label with user status
ensure the label width is not higher than the parent to ensure log
string get elided as expected

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-07-16 13:04:33 +00:00
Felix Weilbach
3e61bdc431 Use dav instead of webdav
Fixes #3342

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-07-16 12:42:02 +00:00
allexzander
de627a9b7c Remove request to config for userVisibleURL.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-07-16 06:45:41 +00:00
Felix Weilbach
036db9d22d Position main dialog on at tray icon if not a regular window
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-07-14 18:27:50 +02:00
Felix Weilbach
efaccbd6fd Show main dialog as normal window if tray icons not available
Fixes #3307

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-07-12 14:10:26 +00:00
Matthieu Gallien
c27fc1be4a use fallback icons for activities without icons
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-06-30 11:28:13 +00:00
Matthieu Gallien
269d225511 directly send the icon url for activities to teh qml component
should allow usage of default cache from Image qml standard component

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-06-30 11:28:12 +00:00
Felix Weilbach
015a5ae235 Don't display account name in italic
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-06-25 20:13:06 +00:00
Felix Weilbach
40065dc6dc Disable QtWebEngine automatic if not found
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-06-24 15:43:51 +00:00
Felix Weilbach
991f79c123 Open provider page in browser when compiling without webengine
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-06-24 15:43:51 +00:00
Felix Weilbach
8376b99ec5 Allow to compile without QWebEngine
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-06-24 15:43:51 +00:00
Felix Weilbach
216a57c74e Remove dead code
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-06-24 15:43:51 +00:00
Felix Weilbach
cb5e8398c4 Fix review comment
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-06-21 12:04:11 +02:00
Felix Weilbach
ab9784374f Fix review comments
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-06-21 12:04:11 +02:00
Felix Weilbach
52342e5710 Prevent crash in dialog that warns user about vfs and e2ee
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-06-21 12:04:03 +02:00
Valdnet
33bdfe687f l10n: Spelling unification
Spelling unification in Transifex.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-06-17 12:18:00 +00:00
Camila
7ddc4ca170 Remove extra RowLayout.
Signed-off-by: Camila <hello@camila.codes>
2021-06-16 07:55:33 +00:00
Camila
449fda16e1 Fix QML Warning: ReferenceError: PopupMenu is not defined.
Signed-off-by: Camila <hello@camila.codes>
2021-06-16 07:55:33 +00:00
Camila
19e581657d Fix QML warning: Cannot specify left, right... anchors for items inside Row.
Signed-off-by: Camila <hello@camila.codes>
2021-06-16 07:55:33 +00:00
Camila
5585f61cc0 Fix QML warning: Detected anchors on an item that is managed by a layout.
Signed-off-by: Camila <hello@camila.codes>
2021-06-16 07:55:33 +00:00
Camila
c8edb11228 Fix QML warning: Accessible must be attached to an Item.
Signed-off-by: Camila <hello@camila.codes>
2021-06-16 07:55:33 +00:00
Felix Weilbach
7850551cad Start macOS app bundle name with uppercase letter
It's a convention on macOS that app bundle names start with an uppercase
letter. Also this aligns the app name with Windows and Linux.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-06-15 12:19:55 +00:00
allexzander
a3d12a616b Add error message to GUI.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-06-15 14:33:45 +03:00
Felix Weilbach
d4b0273792 Generate application png icons from svg icons
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-06-14 10:14:28 +00:00
Felix Weilbach
e7c65a71b8 Remove conditional logic for OEM.cmake
This file is not used in Brander and in the desktop client and just
confused people.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-06-14 10:14:28 +00:00
Felix Weilbach
03610cb706 Set button on QMessageBox before changing the text
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-05-27 07:39:50 +00:00
Camila
f758157973 Fix aligment emoji + message on Windows.
Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:53 +00:00
Camila
8d2264e027 Display the user status emoji separated from the message.
It allows to align the emoji with the message.

Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:53 +00:00
Camila
1cb7f63575 Remove signal refreshCurrentUserGui.
Use only QML property bindings to refresh the UI.

Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:53 +00:00
Camila
46f7cd3884 User property isConnected instead of a invokable.
Remove unnecessary connection to refreshCurrentUserGui signal.

Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:53 +00:00
Camila
1adde8d547 serverUserStatus => serverHasUserStatus.
Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:53 +00:00
Camila
2caa9ccfc6 Add Q_UNREACHABLE() after switch statements in UserStatus.
Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:53 +00:00
Camila
73da14040b Rename ServerUserStatusRole to ServerHasUserStatusRole.
- serverHasUserStatus Q_PROPERTY is CONSTANT.
- Fix code style.

Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:53 +00:00
Camila
828881d82a Do not display the folder status if there are no folders being synced.
Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:53 +00:00
Camila
4326eb53ba Fix margins and sizes to align both avatar + user status displays.
Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:52 +00:00
Camila
dc01b76066 Fix code style.
Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:52 +00:00
Camila
93227ab08b Check if new value is different from the current one.
In AccountState::setDesktopNotificationsAllowed.

Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:52 +00:00
Camila
f7e9e31bc9 Rename isDesktopNotificationsAllowed property to desktopNotificationsAllowed.
- User !== instead of !=.
- Fix code style.

Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:52 +00:00
Camila
820e97cd9b Do not display the user status if there is no pre defined message.
Display the server url instead.

Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:52 +00:00
Camila
c793cbe593 Always display the server url in the drop down account menu.
Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:52 +00:00
Camila
419595ce5e Use DesktopNotificationsAllowedRole to check if user is online.
Rename ServerUserStatus to ServerUserStatusRole.

Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:52 +00:00
Camila
bd65eee278 Remove unused methods in UserModel.
Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:52 +00:00
Camila
671b099c98 Check if the user is connected and if the server supports user status.
Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:52 +00:00
Camila
e3b96ddc85 Move stringToEnum and enumToString to an anonymous namespace.
Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:52 +00:00
Camila
1f61d258bb Fix user status message alignment.
Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:52 +00:00
rakekniven
793c211232
Merge branch 'master' into Valdnet-patch-3 2021-05-20 07:47:17 +02:00
Felix Weilbach
32b7e62359 Warn user if using e2ee and vfs together
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-05-18 11:50:18 +00:00
Valdnet
a3b2dc669c
One more apostrophe change
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-05-12 12:45:33 +02:00
Valdnet
dadddd7ea2 l10n: Replace apostrophe with double quotation
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-05-12 12:34:22 +02:00
allexzander
bbf11d7e7a Temporary! Windows. VFS. Block Virtual Files for partition root sync folders.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-05-11 18:53:35 +03:00
Matthieu Gallien
54d91cdd7b also update ownCloud years interval in copyright notice
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
2021-05-10 10:29:22 +00:00
Matthieu Gallien
86dda5675f send OS name and version to auto updater to allow selective upgrades
in order to be able to suuport legacy OS, also sends the OS name and
version

will be used to detect Windows 8.1 and similar legacy versions

Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
2021-05-06 09:32:09 +00:00
Hannah von Reth
adb56178b9 GetLastError() needs to be called when the error happens
qDebug might clear it already

Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
2021-05-06 07:35:59 +00:00
rakekniven
6d23e93d31
Changed copyright year to 2021
Fix for #3258 

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2021-05-05 13:37:31 +02:00
Felix Weilbach
aadee15008 Fallback to primary screen if screen under pointer not found
Fixes #3252

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-05-05 11:56:46 +02:00
rakekniven
33ef3a1d1e
Merge branch 'master' into rakekniven-patch-2 2021-04-30 14:38:23 +02:00
Valdnet
dc6518a4ee
l10n: Translation of ellipse
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-04-30 13:57:02 +02:00
rakekniven
0e12b0323e
No need to translate ellipsis
Here another PR for the same code line as #3238 

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2021-04-30 13:27:18 +02:00
Valdnet
f431649bad l10n: Change to an ellipsis
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-04-30 08:19:25 +00:00
allexzander
e72013fed1 Fix Felix's comments.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-04-29 07:43:21 +00:00
allexzander
19e2d70c53 Final corrections and refactoring.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-04-29 07:43:21 +00:00
allexzander
deb9ba89f0 Only show password option for email shares.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-04-29 07:43:21 +00:00
allexzander
526fa399dc Fix review comments.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-04-29 07:43:20 +00:00
allexzander
c908183044 Use separate progress indicator for password and replace a button with it while running.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-04-29 07:43:20 +00:00
allexzander
0072d39ca0 Fix review comments.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-04-29 07:43:20 +00:00
allexzander
2d88fc6c99 Obey enforced password for share by email.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-04-29 07:43:20 +00:00
Valdnet
8aedc74838 l10n: Delete space and change capital letter
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-04-28 11:41:06 +00:00
allexzander
e7e5542d3e Improve public link sharing UI. Fix UX issues.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-04-27 13:51:52 +03:00
Felix Weilbach
9a88e38121 Call finish() if going to remove all files
While investigating #3172, I discoverd that the sync will hang forever
if the user has deleted all files on the server. Calling the callback
resolves the problem.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-04-26 12:50:14 +00:00
Valdnet
796b4e4e72 l10n: Change to an ellipsis
Reported on Transifex.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-04-22 07:40:15 +00:00
Felix Weilbach
275e46f0db Show progess indicator
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-04-20 07:13:23 +00:00
Felix Weilbach
c3fac23903 Don't delete note and expiration date on toggle
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-04-20 07:13:23 +00:00
Felix Weilbach
8711d5bf49 Don't use unnecessary layout element
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-04-20 07:13:23 +00:00
Felix Weilbach
2851528595 Show user/group note on share if already set
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-04-20 07:13:23 +00:00
Felix Weilbach
22a3b19e08 Add expire date to user and group share
Fixes #3100

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-04-20 07:13:23 +00:00
Felix Weilbach
946a51e4c1 Add note to user and group share
Fixes #3104

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-04-20 07:13:23 +00:00
Matthieu Gallien
20357ca7fa Revert "Add CMake option to enable address sanitizers"
This reverts commit 3000e26640.

This was not intended for a direct push

Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
2021-04-19 17:54:09 +02:00
Felix Weilbach
3000e26640 Add CMake option to enable address sanitizers
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-04-19 15:38:59 +02:00
allexzander
d65c91ea36 Display VFS sync folder within the navigation panel on Windows.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-04-16 07:18:44 +00:00
Nicolas Fella
2548455f45 Copy FindSharedMimeInfo from ECM
Instead of relying on ECM being installed.

We copy other stuff from ECM so be consistent.

Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
2021-04-15 14:32:46 +00:00
rakekniven
03e7d8da28
Merge branch 'master' into patch-1 2021-04-14 17:11:27 +02:00
Nicolas Fella
70033cda1f Use imported target for Threads
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
2021-04-14 11:07:04 +00:00
castillo92
98a4bb8cce
Update sharedialog.cpp
The original sentence uses the word "share" three times and is too redundant when translated into other languages
2021-04-14 09:24:35 +02:00
Felix Weilbach
696979cb0e Display invalid filenames as warning
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-04-13 14:58:51 +00:00
Felix Weilbach
b736355985 Add notification cache
The notification cache helps to not display duplicate desktop
notifications to the user.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-04-13 14:58:50 +00:00
Felix Weilbach
b256c6e694 Ping websocket server
This helps the client to recognize if the websocket server is still alive.

Fixes #2983

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-04-13 12:19:40 +00:00
Valdnet
e628a51735 l10n: Unify spelling
Spelling unification in Nextcloud applications.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-04-13 12:24:57 +02:00
Nicolas Fella
b34a901838 Use FindPkgConfig to find libcloudproviders and related libs
Instead of using custom find modules.

This allows using imported targets which make the code much nicer.

Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
2021-04-12 10:00:08 +00:00
Felix Weilbach
c49dc440bb Embed version and icon into windows executable
These changes are necessary because of changing the compilation
process for the gui from a single executable to static lib +
executable in commit 0521dce174.
Otherwise the version and icon information will be lost.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-04-09 13:53:12 +02:00
Camila
1ca0ea49dd Remove unnecessary local variable.
Signed-off-by: Camila <hello@camila.codes>
2021-04-08 07:10:59 +00:00
Camila
29f4a3857b Reposition qml elements for the folder status icon.
Signed-off-by: Camila <hello@camila.codes>
2021-04-08 07:10:59 +00:00
Camila
050bd49373 Rename enumToUserString => enumToString.
Signed-off-by: Camila <hello@camila.codes>
2021-04-08 07:10:59 +00:00
Camila
8986975a17 Use enum class instead of enum.
Signed-off-by: Camila <hello@camila.codes>
2021-04-08 07:10:59 +00:00
Camila
50de12b3c3 Undo unnecessary removal of lines.
Signed-off-by: Camila <hello@camila.codes>
2021-04-08 07:10:59 +00:00
Camila
163015492a Fix #3067: missing apps icon.
Signed-off-by: Camila <hello@camila.codes>
2021-04-08 07:10:59 +00:00
Camila
c8ac99c8cf Align status text with server url.
Cleans the space in the beginning of the string when there is no emoji
set.

Signed-off-by: Camila <hello@camila.codes>
2021-04-08 07:10:59 +00:00
Camila
e51dad79a2 Refactor UserStatus.
- Make preDefinedStatus a local var.
- Add function to get the status user string.

Signed-off-by: Camila <hello@camila.codes>
2021-04-08 07:10:59 +00:00
Camila
d2b762aa66 Move curly brackets to the correct line.
Signed-off-by: Camila <hello@camila.codes>
2021-04-08 07:10:59 +00:00
Camila
98cfc362f7 Remove const and reference of base types.
Signed-off-by: Camila <hello@camila.codes>
2021-04-08 07:10:58 +00:00
Matthieu Gallien
d6752c96b1 use QFileInfo to check if path is absolute to avoid assert on windows
on windos absolute path does not have to start with / . Remove failing assert
when editing ignored files list.

Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
2021-04-07 07:40:07 +00:00
allexzander
e15045977e Reduce Socket API logging.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-04-06 09:34:20 +03:00
Felix Weilbach
b2377ff64f Remove html tags from strings that may appear in notifications
The content of notifications on MacOS are not allowed to contain HTML
tags in it. Linux (Free Desktop) notifications may contain HTML tags
in their content. However, it is optional that the notification daemon
interprets the tags. The GNOME notification daemon does not interpret
HTML tags and even does not strip them off. KDE's daemon interprets
the tags. For now I think it's the best solution to remove the HTML
tags. In the future we should fire a action if the user clicks on the
notification and react on it and open the link then. This should work
on all platforms. But as this change involves working with the native
MacOS api and I don't have hardware for that at the moment for that I
will postpone it.

Fixes #2200

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-03-31 16:23:42 +02:00
Felix Weilbach
354f4c02ee Don't deploy bearer plugin on MacOS
Fixes #2944, #2237

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-03-29 13:46:07 +00:00
Camila
9219926a74
Add checks in case userStatus is not available/fails on the server side.
Signed-off-by: Camila <hello@camila.codes>
2021-03-24 15:42:26 +01:00
Camila
d9a0778e52
Add UserStatus enum with the pre defined status.
- User QHash to map status strings and Status enum.

Signed-off-by: Camila <hello@camila.codes>
2021-03-24 15:41:31 +01:00
Camila
974e2fb718
Do not display notifications when user status is do not disturb.
- This information is retrieved from the notifications endpoint.
- Add icons for the different pre defined status.
- Make functions available to QML to decide which status icon to display.
- Display the user status icon on the avatar and
move the online/offline connection status to the folder icon.

Signed-off-by: Camila <hello@camila.codes>
2021-03-24 15:40:05 +01:00
Camila
f4d8699db8
Add UserStatus class to retrieve the user status.
- AccountState controls UserStatus.
- Display user status in the system tray menu next to user's avatar.

Signed-off-by: Camila <hello@camila.codes>
2021-03-24 15:39:13 +01:00
Valdnet
519dee9104 l10n: Change sync message #3027 2021-03-24 13:13:40 +00:00
allexzander
193e50311b Refresh Windows download dialog progress when hydrating a placeholder
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-03-24 14:09:06 +02:00
Felix Weilbach
c296a93cee Enable high dpi scaling on all platforms
Fixes #2295, #1079, #914

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-03-23 08:36:11 +00:00
Felix Weilbach
f4853da2ab Fix crash when trying to open the folder creation dialog
The bug does seem to just appear in special compiler
constellations. We're unsure why this fix works. To better see if this
fix works or if crashes still occur, we added some logging.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-03-17 08:43:32 +01:00
Felix Weilbach
ff7932bb54 Display the content of the login dialog correct
This adjustment is necessary because of the changes of the new account
wizard that were introduced with:
e0b7ef15b2

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-03-16 13:34:34 +00:00
Kevin Ottens
7ad0208800 Finish cleaning up shibboleth
There were a couple of shibboleth related enums left, since that auth
method isn't supported anymore remove the code tied to those enums. It
was dead code anyway.

Signed-off-by: Kevin Ottens <kevin.ottens@enioka.com>
2021-03-15 09:38:15 +00:00
Felix Weilbach
cdc2e4c56e Don't customize settings dialog palette
Customizing of the palette will prevent the settings dialog from
display a dark theme correct.

Fixes #2993

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-03-12 11:47:16 +01:00
Felix Weilbach
e3ac63e9ff Rename isActivityIgnored() to isUnsolvableconflict()
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-03-11 09:42:38 +00:00
Felix Weilbach
05d31e2e53 Split content of User::isValueableActivity()
Refactoring of User::isValueableactivity() because of changes
introduced with merge commit f17c52d.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-03-11 09:42:38 +00:00
Felix Weilbach
e0b7ef15b2 Restyle wizard pages
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-03-10 09:55:40 +01:00
Felix Weilbach
f55e5b1885 Restyle wizard
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-03-10 09:55:40 +01:00
Felix Weilbach
9185956069 Split out wizard welcome page
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-03-10 09:55:40 +01:00
István Váradi
2e7cc96228 Do not include glib.h with extern C (2)
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu>
2021-03-10 07:48:23 +01:00
István Váradi
db321d25ef Do no include glib.h with extern C
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu>
2021-03-09 10:29:14 +01:00
Felix Weilbach
63dbb90bbd Iteration
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-03-05 11:32:44 +00:00
Felix Weilbach
ef5abac567 Fix crashes with conflict dialog
When the client runs and a conflict gets detected, the sync engine runs
two times.

On the first run, the sync engine detects the conflict, marks the
file as a conflict and propagates that to the GUI. This leads to an
error notification with the original filename in the main dialog.

The sync engine runs then a second time. On this second run, the file
that originally caused the conflict is not anymore a conflict
file. Instead, the sync engine detects the conflicted copy and
propagates that file as a conflict to the GUI.

When opening the conflict dialog with the original file name (not the
conflicted copy) a crash happens. Usually, the two sync runs are really
fast, so the user does not notice the first notification. However, a
problem can occur if a conflict gets created while the client is not
running. Since then, the client does not do two sync runs. It does only
run once.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-03-05 11:32:44 +00:00
allexzander
88a21c0665 Do not add debug build to startup programs.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-02-18 13:19:06 +00:00
Felix Weilbach
29e1a82f56 Add missing override specifer to WebFlowCredentials
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-02-13 10:22:01 +00:00
Felix Weilbach
74d07e28cf Validate the providers ssl certificate
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-02-12 08:25:59 +00:00
allexzander
013f3cea70 Validate sensitive URLs to onle allow http(s) schemes.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-02-09 15:00:35 +02:00
allexzander
e97b7d8a25 Default parameter nullptr widget for openBrowser.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-02-09 08:40:51 +00:00
István Váradi
92f1074fcc Put FolderCreationDialog into the OCC namespace.
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu>
2021-02-05 16:27:25 +01:00
allexzander
81a090b362 Allow creation of new folders from the Settings Dialog.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-02-04 10:05:18 +02:00
Kevin Ottens
55fd0562de
Load the theme resource explictly
Otherwise they won't be loaded automatically at startup leading to lots
of missing icons. Since they're now in a static library they need that
explicit loading.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2021-02-02 18:33:45 +01:00
Felix Weilbach
d8493a9b3b Add automoc property to updater
Signed-off-by: Felix Weilbach <felix.weilbach@t-online.de>
2021-02-02 13:35:04 +00:00
Felix Weilbach
73a41d8e34 Compile nextcoud gui as separate library
Compiling nextcoud gui as a separate library. This is needed to more
easily write tests. The whole nextcloud application can now be linked
against the tests.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-02-02 13:35:04 +00:00
allexzander
8c4d5333c1 Use push notifications for Tray activities/notifications fetch trigger.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-01-27 19:53:28 +02:00
Felix Weilbach
51d8cf8102 Start file conflict resolve dialog asynchronous
Fixes #2804

Signed-off-by: Felix Weilbach <felix.weilbach@t-online.de>
2021-01-27 08:01:25 +00:00
Valdnet
d8a88fd047 Replace dots with ellipses and add spaces. 2021-01-27 07:36:52 +00:00
Valdnet
817d460b84 Move space in "owncloudadvancedsetuppage.cpp" 2021-01-26 16:40:46 +00:00
Kevin Ottens
4168c0d082 Avoid keeping Account alive via a shared ptr in ClientSideEncryption
This account object was really only used during the initialization phase
or for forgetting the sensitive data. So let's receive it as parameter
there and pass it on from job to job as needed.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2021-01-26 11:20:13 +00:00
Valdnet
f365ec1e4c Move space in "folderwizard.cpp" 2021-01-25 17:42:38 +00:00
Valdnet
8539dc7dc6 Change the quotation marks 2021-01-25 17:33:46 +00:00
Felix Weilbach
78f00acaa2 Add push notifications for file changes
Resolves #2802

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-01-25 17:01:09 +00:00
Kevin Ottens
4992bfa8ef
Ensure the right radio is selected when selective sync is picked
This got broken previously when trying to reconcile during a
cherry-pick. This also repairs the case when the theme tells us the
default is to not select anything (not that we're using this right now
but in case we'd like to brand this).

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2021-01-25 16:53:21 +01:00
Kevin Ottens
2b2dac10ef
It's not really recommended anymore at least not on Windows
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2021-01-25 16:24:44 +01:00
Felix Weilbach
db0f1e245d Remove NO_SHIBBOLETH flag and dead code
Signed-off-by: Felix Weilbach <felix.weilbach@t-online.de>
2021-01-05 12:58:58 +01:00
Hannah von Reth
09cc988026
Fix a possible crash with the remove all files dialog 2020-12-30 16:20:43 +01:00
Hannah von Reth
552427ffc3
Update windows launch on start binary location
Fixes: #7672
2020-12-30 16:17:47 +01:00
Kevin Ottens
e37a5f36b0
Don't look at virtual files data for the mimetype matches
Otherwise this would attempt to download the file everytime we check the
direct editor for a given file which wouldn't be adequate. Would also
lead to a deadlock in our case since that would happen in the main
thread and implicit hydration is driven from there as well.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-30 09:44:58 +01:00
rakekniven
29d968ab15 Changed triple dot to ellipsis
Reported at Transifex.

Signed-off-by: rakekniven <mark.ziegler@rakekniven.de>
2020-12-21 08:00:29 +00:00
Camila
0e0ea9d81a Update the settings dialog window title.
Signed-off-by: Camila <hello@camila.codes>
2020-12-17 07:04:07 +00:00
Camila
625752f85d General settings: move buttons to the bottom left of their group boxes.
Signed-off-by: Camila <hello@camila.codes>
2020-12-17 07:04:07 +00:00
Kevin Ottens
c57eff6fd8
Please the clang-tidy overlord
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 11:01:53 +01:00
Hannah von Reth
9d9eadba8e
Use time the request was send,..
not when it was processed by the client, to determine the quality of the connection.
2020-12-15 11:01:08 +01:00
Hannah von Reth
96eaef6dba
Pause sync when remove all dialog is displayed
Fixes: #8263
2020-12-15 10:59:27 +01:00
Hannah von Reth
c253b51249
Use enum instead of int 2020-12-15 10:59:27 +01:00
Hannah von Reth
befc373ea6
Fix test on systems where C:\ is not writeable 2020-12-15 10:59:27 +01:00
Hannah von Reth
0eb8b01f0a
Fix usePlaceholders migration 2020-12-15 10:59:26 +01:00
Hannah von Reth
a083a37126
Fix vfs experimental text 2020-12-15 10:59:26 +01:00
Hannah von Reth
b2934a68bc
Fix folder permission check on NTFS
Fixes: #8187
2020-12-15 10:59:26 +01:00
Hannah von Reth
8dbdaed5c3
Fix condition 2020-12-15 10:59:26 +01:00
Hannah von Reth
e4a0222954
Append .exe to crashreporter path so it is better located 2020-12-15 10:59:25 +01:00
Hannah von Reth
f6faba48e2
Don`t block main thread when displaying all files removed dialog
Fixes: #8170
2020-12-15 10:59:25 +01:00
Hannah von Reth
b4cb3ecb5a
Don't use exec() on dialogs 2020-12-15 10:59:25 +01:00
Hannah von Reth
7c65d38ba4
Draw active progressbar
Pass a widget to the progressbar in the folder delegate to draw the correct active state
2020-12-15 10:59:25 +01:00
Kevin Ottens
7e5f81ea81
Allow to control availability of folders in the settings dialog
It felt odd to be able to control the encryption status in the settings
dialog but not the availability. Also availability was controllable on
the root, so let's make it widely available.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 10:59:24 +01:00
Kevin Ottens
70c2dc70a1
Resurrect the display of subfolders for VFS sync folders
This got removed from the settings since in that case selective sync
isn't supported. Unfortunately that's also necessary to display them to
allow encrypting folders via the context menu.

So we display the subfolders again but in the case of VFS we disable the
ability to (un)check them. They just have an icon, a name and a context
menu.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 10:59:24 +01:00
Kevin Ottens
9f0e0b0f6a
Update the FolderStatusModel when a folder encryption ends
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 10:59:24 +01:00
Kevin Ottens
596bfab6e1
Set the account state after E2EE is setup in the GUI
Otherwise we would not display the E2EE message if the account was
connected before the creation of the settings dialog. This was likely
caused by the delayed creation of the settings dialog.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 10:59:24 +01:00
Kevin Ottens
f45e84f2ee
Remove empty action in the settings toolbar
This was causing an unwanted line in the middle of the bar.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 10:59:24 +01:00
Kevin Ottens
d63097475c
Fix typo and style
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 10:59:23 +01:00
Kevin Ottens
ce5edfdf4d
Stop using e2e()->isFolderEncrypted() in the folder wizard
We used the same approach than for the FolderStatusModel by getting the
is-encrypted property straight from the LSCOL job.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 10:59:23 +01:00
Kevin Ottens
4fde05b8b6
FolderStatusModel now uses the LSCOL job result for encryption status
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 10:59:22 +01:00
Kevin Ottens
8e5a8d9fb9
FolderStatusModel LSCOL job now gets the is-encrypted property
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 10:59:22 +01:00
Kevin Ottens
37a51872e1
Set the encrypted flag in the database when EncryptFolderJob succeeds
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 10:59:22 +01:00
Kevin Ottens
b667bdda14
Change EncryptFolderJob path convention
It had a different path convention than all the other jobs, most likely
for legacy reasons because of the tight coupling it had to the settings
dialog.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-12-15 10:59:22 +01:00
Hannah von Reth
dd3e70b667
VirtualFiles: Ensure the target location supports vfs
Fixes: #8131
2020-12-15 10:59:20 +01:00
Hannah von Reth
60011e8003
Remove vfs warning in the delegate, indicate them in the description instead
Fixes: #8139
2020-12-15 10:59:20 +01:00
Hannah von Reth
356192fb1d
Don't show 404 errors when manually creating folder sync pair.
Fixes: #7724
2020-12-15 10:59:20 +01:00
Hannah von Reth
1619cd5dcc
Use winvfs by default when adding folder sync connection
Fixes: #8083
2020-12-15 10:59:19 +01:00
Hannah von Reth
8460526df9
Clear cookies on logout 2020-12-15 10:59:19 +01:00
Hannah von Reth
020c6d6424
Fix placeholders are reverted to OnlineOnly
Fixes: #7779
2020-12-15 10:59:19 +01:00
Hannah von Reth
f1f6257b5d
Windows VFS: Enable Windows VFS by default 2020-12-15 10:59:18 +01:00
Hannah von Reth
bd62615aab
Clazy: Fix some warnigns 2020-12-15 10:59:17 +01:00
Hannah von Reth
d109d49b49
Ui: Hide selective sync settings if vfs is active
Fixes: #7976
2020-12-15 10:59:17 +01:00
Hannah von Reth
54cc2be00f
Fix assertion introduced by e1ca612c5d3087e02f6b7f8e454224e0b88e82ad
[ fatal default ]:ASSERT: "last < rowCount(parent)" in file C:\_\17a9f6ae\qtbase-everywhere-src-5.12.9\src\corelib\itemmodels\qabstractitemmodel.cpp, line 2787

e1ca612c5d3087e02f6b7f8e454224e0b88e82ad stopped adding sub folders so we can return the actual size.
2020-12-15 10:59:17 +01:00
Hannah von Reth
93281c8560
Use const access where possible 2020-12-15 10:59:17 +01:00
Hannah von Reth
2887a93c40
Win: Use full Windows paths in file watcher and improve logging 2020-12-15 10:59:16 +01:00
Hannah von Reth
b9638bc778
Fix warning
warning C4573: the usage of 'QObject::disconnect' requires the compiler to capture 'this' but the current default capture mode does not allow it
2020-12-15 10:59:15 +01:00
Hannah von Reth
e38b43123c
Log: Only print 'Saved account settings' in debug mode
Don't log that there was no error...
2020-12-15 10:59:15 +01:00
Hannah von Reth
c9ee0a0343
Log: Improve log message [ info gui.folder ]: Folder sync result: 4...
by including the name of the folder and print the name of the result
2020-12-15 10:59:15 +01:00
Hannah von Reth
fb34f8ea85
Gui: Don't try to display the wizard during shutdown
Fixes: #7936
2020-12-15 10:59:14 +01:00
Hannah von Reth
4f8928d35e
Remove dead code 2020-12-15 10:59:14 +01:00
Hannah von Reth
c5b59bf3b1
Make ownCloud accassible on the Application object 2020-12-15 10:59:14 +01:00
Hannah von Reth
4645e69147
Remove ifdef(Q_OS_X11) code, there never was such a define.
As noone complained since I don't think anyone will miss the code
2020-12-15 10:59:14 +01:00
Hannah von Reth
f932dfc648
VFS: Tell the vfs plugin whether we have multiple accounts
This allows us to decide on the presentation of the account
2020-12-15 10:59:14 +01:00
Hannah von Reth
7fdb842ed2
VFS: Prevent duplicated navigation panel icon
Issue: #7748
2020-12-15 10:59:13 +01:00
Hannah von Reth
c92f70d4ff
Beautify flags 2020-12-15 10:59:13 +01:00
Hannah von Reth
2b95f919ad
Fix 3aeca58b316363dc12ad4b392750fc57e7a2965a 2020-12-15 10:59:13 +01:00
Hannah von Reth
6d2526a67d
Fix warning C4715: 'OCC::Utility::vfsCurrentAvailabilityText': not all control paths return a value 2020-12-15 10:59:12 +01:00
Hannah von Reth
b492b69dfd
Fix 150a5b4d06600d140ddf05383fb74cda6ae6e941 2020-12-15 10:59:12 +01:00
Hannah von Reth
6fde08d9f7
Fix crash on settings migration
Fixes: #7878
2020-12-15 10:59:12 +01:00
Hannah von Reth
fa87b899fb
Fix usage of QMessageBox
Fixes: #7874
2020-12-15 10:59:12 +01:00
Hannah von Reth
11b9e3fa61
Fix order of pluginkit commands and modernise 2020-12-15 10:59:12 +01:00
Hannah von Reth
eed4ffb823
Wizard: Raise own window
The OAuth authentication brings the broweser to the front, once thats done the wizard continues.
But the wizard ist now most probably hidden behind the browser
2020-12-15 10:59:11 +01:00
Hannah von Reth
baff0a6986
VFS Dialog: Don't enable on close button clicked
Issue: #7710
2020-12-15 10:59:11 +01:00
Hannah von Reth
b15c308170
Remvoe now unneeded SyncRunFileLog::directionToStr 2020-12-15 10:59:11 +01:00
Hannah von Reth
4681421b62
Remvoe now unneeded SyncRunFileLog::instructionToStr 2020-12-15 10:59:11 +01:00
Hannah von Reth
4d615c31da
Rename csync_instructions_e -> SyncInsturctions 2020-12-15 10:59:10 +01:00
Hannah von Reth
bcceb5c33d
[Gui] Implement raiseDialog on Windows
Issue: #7774
2020-12-15 10:59:09 +01:00
Hannah von Reth
12ae1e97c6
[SocketApi] Ensure listener still exists 2020-12-15 10:59:08 +01:00
Hannah von Reth
d63d4cdf62
Don't insert items into the folder model if selectiveSync is not supported
This fixes an assertion in FolderStatusModel::SubFolderInfo::resetSubs
rowCount reported 0 but we actually had items in the model
2020-12-15 10:59:08 +01:00
Hannah von Reth
9176afe263
Make sure all cases are handled 2020-12-15 10:59:08 +01:00
Hannah von Reth
9b0788bdf8
[Gui] Fix vfs dialog not showing on Windows 2020-12-15 10:59:08 +01:00
Olivier Goffart
b7193e6a0e
Folder Wizard: warn when adding a folder which is the parent of a sync'ed folder
issue #7741
2020-12-15 10:59:07 +01:00
Hannah von Reth
13c9d6431d
Fix expansion of tree view on newly added accounts
The change is based on 97ce20ac028660e6ae3dd0b98d4b487999d8768a

I removed a few lines of code there which are already part of fetchMore()

Fixes: #7336
2020-12-15 10:59:07 +01:00