Claudio Cambra
6431d66aeb
Remove unnecessary signalling response to start edit locally, just start it within the job
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-04-23 22:48:41 +08:00
alex-z
3a00c1d43f
Edit locally. Elide loading dialog filename label middle.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-04-20 14:16:07 +02:00
Camila
6a4d6b9c97
Alway add the item at the end of the layout.
...
Signed-off-by: Camila <hello@camila.codes>
2023-04-12 10:16:47 +02:00
Matthieu Gallien
5cb3266f7f
fix compilation with clazy and fully-qualified-moc-types checks enabled
...
will make all signals and slots be using fully qualified data types
makes code safer
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-04-11 11:34:00 +02:00
alex-z
54c13a560d
Edit locally. Restart current folder sync immediately after file opened.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-04-11 09:50:51 +02:00
Valdnet
1f8239b13f
i18n: Separate words
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2023-04-07 10:35:51 +02:00
Valdnet
8ed69d1e95
i18n: Separate words
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2023-04-07 10:35:51 +02:00
Valdnet
06b2f2b736
i18n: Add dot
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2023-04-07 10:35:51 +02:00
alex-z
a428c17c37
Do not display error status and messages when aborting a sync during hydration request in VFS mode.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-04-06 22:26:35 +02:00
Matthieu Gallien
7c655cf679
use a getter to query encryption status
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-03-31 17:18:28 +02:00
Matthieu Gallien
20422f0247
when local sync folder is overriden, respect this choice
...
may lead to inadvertant data loss, not sure if that could be an issue
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-03-31 09:21:48 +02:00
Matthieu Gallien
d2cd4efaaa
fix the logic generating the config file
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-03-22 10:17:28 +01:00
Matthieu Gallien
903c475d5a
store in config file that we want to enable vfs when generating config
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-03-22 10:17:28 +01:00
Matthieu Gallien
e0bdbd1387
follow shouldNotify flag to hide notifications when needed
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-03-21 09:10:12 +01:00
alkl58
1e37697152
Show server name in tray main window
...
Signed-off-by: Alkl58 <alkl58@protonmail.com>
2023-03-10 16:51:22 +01:00
Camila
ec7b5481d4
Fix display of 2FA notification.
...
Fix for issue #5421 : add server notifications to the activities list
when the user needs to act on it.
Signed-off-by: Camila <hello@camila.codes>
2023-03-08 10:53:51 +01:00
Axel Lender
664e0c18ec
Resize WebView widget once the loginpage rendered
...
When the login dialogue displays the login page itself
the WebView widget did not resize according to
the dimensions of the login page.
Signed-off-by: Axel Lender <lender@b1-systems.de>
2023-03-07 09:55:04 +01:00
alex-z
31de652d9b
Display 'Search globally' as the last sharees list element
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-03-03 18:01:05 +01:00
alex-z
b6ba1fe0d6
Implement Secure filedrop link share. Move data from 'filedrop' to 'files' when syncing E2EE folders.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-03-02 19:29:11 +01:00
Claudio Cambra
2e69a9c59a
Move sharesChanged signal emission to handlePlaceholderLinkShare rather than repeating each time this method is called
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-03-01 18:40:29 +01:00
Claudio Cambra
f05e44a24a
Don't display the placeholder link share of public link shares are not available
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-03-01 18:40:29 +01:00
Claudio Cambra
3560263472
Don't block loading if public link shares are disabled
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-03-01 18:40:29 +01:00
Claudio Cambra
4bbe851da1
Fix text labels in Sync Status component
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-28 23:07:09 +01:00
Claudio Cambra
a0107c43f1
Fetch account avatar info on account action construction, fixing avatar only showing up when action is clicked
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-28 18:08:29 +01:00
Claudio Cambra
f676979b29
Set placeholder image always as account action icon, as at app start there will not be a valid avatar to use ever
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-28 18:08:29 +01:00
Matthieu Gallien
01ecb639ab
use new connect syntax
...
mainly done using clazy and old-style-connect check
close #5426
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-28 09:36:27 +01:00
Matthieu Gallien
c0549c5c03
fix issues reported by compiling windows code with clang-tidy
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-22 16:50:20 +01:00
Claudio Cambra
89ebfcae8e
Try to initialise share manager again if we receive updated sharing permissions that would have previously prevented sharing
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-16 13:06:35 +01:00
Claudio Cambra
2fbdf1be8f
Simplify check for file record sharing permission
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-16 13:06:35 +01:00
Claudio Cambra
893adb8280
Remove unused slotDeleteAccount in AccountSettings
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-14 20:22:51 +01:00
Claudio Cambra
7084310a9f
Remove unused AccountState::writeToSettings
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-14 20:22:51 +01:00
Claudio Cambra
69d73d1333
Respond to folder creation at specific creation path on macOS
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-14 18:27:03 +01:00
Claudio Cambra
30ce2eab02
Notify when folder is created with full folder path in FolderCreationDialog
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-14 18:27:03 +01:00
Claudio Cambra
89d3022649
Do not search for folder twice
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-14 18:27:03 +01:00
Claudio Cambra
6c548145a2
Make sure to manually call folderwatcher when creating new folder from settings menu in macOS
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-14 18:27:03 +01:00
Claudio Cambra
1d525911f1
Make ShareModel's accountState and folder pointers QPointers to guard against crashes
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-06 12:30:50 +01:00
Claudio Cambra
bf8cb8305e
Create common validCapabilities used by several ShareModel methods checking account capabilities
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-06 12:29:35 +01:00
Matthieu Gallien
079d392d36
move init to default value in class declaration
...
done via clang-tidy and manual tuning
run-clang-tidy -p build -header-filter='.*' -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,modernize-use-default-member-init' -fix
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-06 10:43:05 +01:00
Matthieu Gallien
76e88572d6
more fixes for attributes without init value
...
done with clang-tidy
run-clang-tidy -p build -header-filter='.*' -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,cppcoreguidelines-pro-type-member-init' -fix
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-06 10:43:05 +01:00
Matthieu Gallien
ca932fe093
init attributes
...
discovered at runtime using valgrind
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-06 10:43:05 +01:00
Matthieu Gallien
b4a8981c03
initialize all variables
...
done with clang-tidy
run-clang-tidy -p build -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,cppcoreguidelines-init-variables' -fix
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-06 10:43:04 +01:00
Matthieu Gallien
82b062d2e9
prefer initialization of attribute inline
...
done with clang-tidy
run-clang-tidy -p build -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,modernize-use-default-member-init' -fix
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-06 10:43:04 +01:00
Matthieu Gallien
d2f5c6a5c7
initialize many attributes that could have been left without init value
...
done with clang-tidy
run-clang-tidy -p build -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,cppcoreguidelines-pro-type-member-init' -fix
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-06 10:43:04 +01:00
Camila
e533c6047c
Update code style.
...
Signed-off-by: Camila <hello@camila.codes>
2023-02-02 08:43:51 +01:00
Camila
e0c1c67306
Fix: if the config did not exist, overrideserverurl had no effect.
...
When the client runs for the first time, setting the value was done before
the config file was created. It had no effect.
Signed-off-by: Camila <hello@camila.codes>
2023-02-02 08:43:51 +01:00
Camila
3596562101
Do not exit application when overrideserverurl param is a valid url.
...
Signed-off-by: Camila <hello@camila.codes>
2023-02-02 08:43:51 +01:00
Camila
9101e0a7f8
Only accept folder setup page if overrideLocalDir is set.
...
Fix for #5383 .
Signed-off-by: Camila <hello@camila.codes>
2023-02-02 08:43:51 +01:00
Camila
72fe5f643c
By default do not display warning about backups made of the config file.
...
Use the setting showConfigBackupWarning to change the default value.
Signed-off-by: Camila <hello@camila.codes>
2023-02-01 19:00:40 +01:00
Camila
9ead33ab93
Improve warning message code readability.
...
Signed-off-by: Camila <hello@camila.codes>
2023-02-01 16:21:25 +01:00
Matthieu Gallien
76af889937
use QVersionNumber to compare versions and improve upgrade warning
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-01 13:28:01 +01:00