Matthieu Gallien
fb062f2dd7
fix wrong detectiion of current config file as a config migration
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-01 13:28:01 +01:00
allexzander
810fced476
Merge pull request #5378 from nextcloud/Valdnet-patch-4
...
l10n: Correct word
2023-01-31 17:06:48 +01:00
Claudio Cambra
dfdc23e240
Fix displaying of file details button for local syncfileitem activities
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-31 13:03:52 +01:00
Valdnet
bca915a230
l10n: Correct word
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2023-01-31 12:59:01 +01:00
Camila
a3e08aae3b
Address PR comments.
...
Signed-off-by: Camila <hello@camila.codes>
2023-01-30 09:44:17 +01:00
Camila
9a3f2efa58
Fix rename.
...
Signed-off-by: Camila <hello@camila.codes>
2023-01-30 09:44:17 +01:00
Camila
ea903b1316
Backup all config files in the config folder if there was a version change of the client.
...
Signed-off-by: Camila <hello@camila.codes>
2023-01-30 09:44:17 +01:00
Camila
dbce267feb
Look for a previous config file with a different name.
...
Signed-off-by: Camila <hello@camila.codes>
2023-01-30 09:44:17 +01:00
Camila
bf258542cd
Update code style.
...
Signed-off-by: Camila <hello@camila.codes>
2023-01-30 09:44:17 +01:00
Camila
e68b4595e7
Remove obsolete QDesktopServices::storageLocation.
...
Use QStandardPaths::writableLocation instead.
Signed-off-by: Camila <hello@camila.codes>
2023-01-30 09:44:17 +01:00
Camila
b525de8a97
Open calendar notifications in the browser.
...
Signed-off-by: Camila <hello@camila.codes>
2023-01-27 12:30:01 +00:00
Claudio Cambra
68c785e25c
Revert "Merge pull request #5366 from nextcloud/bugfix/remove-mono-icons-setting"
...
This reverts commit 5c42da4de5
, reversing
changes made to e4b2449030
.
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-27 12:23:11 +01:00
alex-z
bb8bdab19c
Edit locally. Do not lock if locking is disabled on the server.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-01-26 17:00:14 +01:00
Matthieu Gallien
07c292eaf5
fix copyright notice of new files
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-01-25 16:37:37 +01:00
Claudio Cambra
4c4e8707da
Improve wording in the case clash resolution dialog
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-25 16:37:36 +01:00
Claudio Cambra
64e585e5a2
Display both files and some metadata in the case clash conflict resolution dialog
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-25 16:37:36 +01:00
Claudio Cambra
2359c80c13
Fix case clash dialog sizing issues
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-25 16:37:36 +01:00
Claudio Cambra
cf6794c180
Clarify letter casing message in case clash conflict dialog
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-25 16:37:36 +01:00
Claudio Cambra
5908ac4176
Display action button for conflict files in activity
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-25 16:37:35 +01:00
Matthieu Gallien
602b8db5e2
handle case clash conflicts in a similar way to content conflicts
...
introduce a new type of conflict for case clash filename conflicts
add proper handling including a new utility class to solve them and a
new dialog for the user to pick a fix
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-01-25 16:37:35 +01:00
Claudio Cambra
0aee2bc2eb
Remove monoIcons-related functionality from theme
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-25 12:42:47 +01:00
Claudio Cambra
688126c003
Remove mono icons setting from generalsettings
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-25 12:32:06 +01:00
Claudio Cambra
6df08af61a
Remove 'Use monochrome icons' checkbox from settings UI
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-25 12:27:42 +01:00
Claudio Cambra
3e00df4732
Don't shadow rec variable in removeLocalE2eFiles
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:16 +01:00
Claudio Cambra
95aa3ee53b
Make encrypted folder paths to delete non-relative when checking if they are encrypted
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:16 +01:00
Claudio Cambra
4c1a9f787a
Ensure blacklists get updated when removing folder sync
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:16 +01:00
Claudio Cambra
d93fc8eb3d
Don't use foreach in Folder::removeLocalE2eFiles
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:15 +01:00
alex-z
ad258473c4
Fix issue of e2ee folders not disappearing when disabling the e2e. Properly process blacklisted e2ee folders instead of ignoring them.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-01-24 17:00:15 +01:00
Claudio Cambra
efcd23eb06
Ensure blacklisted e2ee files get deleted
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:15 +01:00
Claudio Cambra
b333310ffe
Clean up sync termination and restart procedure after file blacklisting done
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:15 +01:00
Claudio Cambra
fdaedc4914
Only add root-most encrypted folder to the blacklist
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:15 +01:00
Claudio Cambra
7d208ec06e
Make sure to add e2ee files to normal blacklist too
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:15 +01:00
Claudio Cambra
093810f6b9
Only shedule affected paths for remote discovery after disabling e2ee
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:15 +01:00
Claudio Cambra
1fc1e95161
Use e2ee folder blacklist instead of deleting folders directly
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:15 +01:00
Claudio Cambra
12b2673ac2
Add test for deleting encrypted files
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:15 +01:00
Claudio Cambra
c59ab85e22
Make accountstate fakeable for tests
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:14 +01:00
Claudio Cambra
b57b35e7a4
Delete E2EE files/folders for accounts that have had E2EE disabled
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:14 +01:00
Claudio Cambra
cc6bdc9bd5
Add ability to remove local encryption keys through settings
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:14 +01:00
Claudio Cambra
f9fb03bdc9
Clean up declarations in AccountSettings
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:14 +01:00
Claudio Cambra
96cd78264d
Fix fetch more unified search result item not being clickable
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 12:24:01 +01:00
Claudio Cambra
0ab2bd849b
Don't try to lock folders when editing locally
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-23 17:46:43 +01:00
Claudio Cambra
c496e73200
Correctly parse account server url when migration from legacy config
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-23 16:29:01 +01:00
Claudio Cambra
174a486428
Stop checking config to migrate at current path if could not read file
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-23 16:29:01 +01:00
Claudio Cambra
39914e5166
More concisely clean paths of trailing slash URLs in restore old config migration method of AccountManager
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-23 16:29:01 +01:00
Claudio Cambra
dd4b7b6c26
Update legal notice text
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-23 15:37:56 +01:00
alex-z
d8980a8567
Fix bad string for translation.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-01-23 13:07:41 +01:00
alex-z
2bd1c272a6
Allow specifying the server force override URL and local sync folder path via command line.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-01-17 17:27:19 +01:00
Claudio Cambra
481298997c
Extract makeResourceUrl lambda into separate static openableUrl method
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-06 18:49:13 +01:00
Claudio Cambra
37830c4bc4
Simplify makeResourceUrl
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-06 18:49:13 +01:00
Claudio Cambra
92667560ab
Fix existing check and completion for relative resource URLs
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-06 18:49:13 +01:00
Florian Schmaus
14cbd836ab
Drop dependency on Qt Quick Controls 1
...
Qt Quick Controls 1 where deprecated with Qt 5.11 [1]. Nextcloud still
depends on Quick Controls 1 by importing QtQuick.Dialogs. Removing
those imports will cause the QMl script to use the according API from
Quick Controls 2, which are, fortunately largely API-comptible.
This helps distribution to deprecate and remove Quick Controls 1 [2].
1: https://doc.qt.io/qt-6/qtquickcontrols-changes-qt6.html#migrating-from-qt-quick-controls-1
2: https://bugs.gentoo.org/889772
Signed-off-by: Florian Schmaus <flo@geekplace.eu>
2023-01-06 17:22:56 +01:00
Claudio Cambra
784327f489
Replace now deprecated FSEventStreamScheduleWithRunLoop with FSEventStreamSetDispatchQueue
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-02 18:05:54 +01:00
Claudio Cambra
403f43b3e8
Fix currentPage QPROPERTY missing NOTIFY in settingsdialog class
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-02 17:04:30 +01:00
Claudio Cambra
0495c6567a
Fix interval QPROPERTY missing NOTIFY in slideshow class
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-02 17:04:30 +01:00
alex-z
cecd24b6c5
Fix review comments from Claudio III.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-12-30 14:46:06 +01:00
alex-z
07be556eca
Fix review comments from Claudio II.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-12-30 14:46:06 +01:00
alex-z
e53d08fedb
Fix review comments from Claudio. Refactoring.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-12-30 14:46:06 +01:00
alex-z
94df6769dc
Allow setting up an account with apppasword and folder via command-line arguments. For deployment.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-12-30 14:46:06 +01:00
Valdnet
c9bae27bf8
l10n: Remove space
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-12-24 12:56:08 +01:00
Claudio Cambra
ce57d3b3ab
Declare all QRegularExpressions statically
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-20 18:38:24 +01:00
Claudio Cambra
bf85c2d093
Remove unused QStrings from remotewipe
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-20 12:59:08 +01:00
Claudio Cambra
ad2841d963
Remove HACK for Windows Vista as this OS is no longer supported
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-20 12:59:08 +01:00
Claudio Cambra
50fa4cbb63
Remove unused variables in folderstatusdelegate
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-20 12:59:08 +01:00
Claudio Cambra
1dfb9b26f2
Remove use of emit keyword where used for non signals
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-20 12:07:55 +01:00
Claudio Cambra
6146f7d5cf
Add 'emit' keyword to signal emissions that were missing them
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-20 12:07:55 +01:00
Claudio Cambra
f6c4c32b6e
Use QFileInfo::exists where we are only creating a QFileInfo to check if file exists, as it is faster
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-20 09:44:13 +01:00
Claudio Cambra
b0d048b0b8
Fix conflicting definitions in anonymous namespace in Unity build
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-15 16:58:00 +01:00
Claudio Cambra
3b7bd6d26c
Constify groups variable
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-15 16:58:00 +01:00
Claudio Cambra
14bd744df6
Use std::make_unique rather than manually build unique_ptr for oCSettings
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-15 16:58:00 +01:00
Claudio Cambra
f4bca991e1
Make checks for config file more concise, warn when file not readable
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-15 16:58:00 +01:00
Claudio Cambra
d8e8a43cff
Constify config file QFileInfo, create directly in if statement
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-15 16:58:00 +01:00
Claudio Cambra
0f9ddcddcb
Fix includes in accountmanager.cpp
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-15 16:58:00 +01:00
Claudio Cambra
5548a4181b
Replace QDesktopServices datalocation with emulated version of it
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-15 16:58:00 +01:00
Claudio Cambra
98be5fdd18
Add full list of possible legacy config locations
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-15 16:58:00 +01:00
Matthieu Gallien
39f85219b9
fix migration from old settings configuration files
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-12-15 16:58:00 +01:00
alex-z
867249f339
Do not sync encrypted folders if the E2EE mnemonic is not entered. Automatically blacklist them. Remove from blacklist once the E2EE mnemonic is provided.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-12-15 15:09:25 +01:00
Claudio Cambra
4ab7d6484a
Remove unused headerbanner component
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-15 12:30:41 +01:00
Matthieu Gallien
a8025dc06a
use .nextcloudsync.log to perform file monitoring test at start
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-12-15 11:11:20 +01:00
Claudio Cambra
b4ea35e95c
Clean up data section for internal link in model
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-13 17:40:20 +01:00
Claudio Cambra
bdfa923f8a
Fix copy link button
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-13 17:40:20 +01:00
Claudio Cambra
4af2a8f9de
Remove unneeded property from ShareDetailsPage
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-13 17:40:20 +01:00
Claudio Cambra
59d84759e4
Add an internal link share to the share dialog
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-13 17:33:33 +01:00
Claudio Cambra
2a77dc4529
Check socketlistener is valid before trying to send encryption menu item message
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-13 13:27:56 +01:00
Claudio Cambra
a23db4688a
Don't show Encrypt menu entry if server does not support E2EE
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-13 13:27:56 +01:00
Claudio Cambra
01334e40f9
Improve folder encryption dialog info boxes
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-13 13:27:56 +01:00
Claudio Cambra
2b09281594
Add encryption success message box
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-13 13:27:56 +01:00
Claudio Cambra
39a48bf822
Move encrypt menu entry declaration to own method
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-13 13:27:56 +01:00
Claudio Cambra
bf1f718a65
Don't allow encryption if account is not correctly configured for it
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-13 13:27:56 +01:00
Claudio Cambra
1d4c634c54
Add context menu entry to encrypt folders
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-13 13:27:56 +01:00
Christian Göttsche
1a83894074
Fix typo
...
Found by Lintian.
Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
2022-12-13 09:22:58 +01:00
alex-z
f7ef2e5f44
Silence sync termination errors when running EditLocallyJob.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-12-12 17:39:48 +01:00
Claudio Cambra
5930fb4ac9
Adapt changes from share details page changes
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-09 15:06:35 +01:00
Claudio Cambra
373a001774
Replace share button with file details button
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-09 15:06:35 +01:00
Claudio Cambra
a16fc9ffcc
Replace drawer 'Done' button at bottom-right with close button at top-right
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-09 15:06:35 +01:00
Claudio Cambra
ca74c2b27f
Make drawer modal, reduce width
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-09 15:06:35 +01:00
Claudio Cambra
d25ce28a1b
Show file details within the tray dialog, rather than in a separate dialog
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-09 15:06:35 +01:00
Claudio Cambra
4a42aee17e
Remove semicolons from Q_UNUSED macros
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-09 14:36:12 +01:00
Claudio Cambra
8913f88c50
Differentiate between normal normal and Talk notifications, invoke macOS text reply notifications
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-09 14:36:12 +01:00
Claudio Cambra
d2e0afa070
Add Talk message type of notifications to native macOS notifications
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-09 14:36:12 +01:00
Claudio Cambra
2261615f69
Use EnforcedPlainTextLabel in new ShareDetailsPage
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-09 12:54:09 +01:00