Commit graph

11160 commits

Author SHA1 Message Date
Álvaro Brey Vilas
d720ae7f3f
Unified search: createNextcloudClient should not be called from main thread
Fixes #9244

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-15 16:40:08 +01:00
Álvaro Brey Vilas
18c6baaff0
manifest: Even more intent queries
Fixes #9270

These are hard to find, man

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-15 13:37:39 +01:00
Álvaro Brey Vilas
fa432834e7
Expand intent query declarations in AndroidManifest
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-15 13:37:29 +01:00
Álvaro Brey
f6a1f4a0f1
Merge pull request #9262 from gmotzespina/master
Prevent app crash when listening to audio files.
2021-11-15 11:41:07 +01:00
Álvaro Brey Vilas
a6f3bdceeb
Keep track of PlayerService state instead of restarting it before closing
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-15 10:31:20 +01:00
Guillermo Mtz Espina
12b75dce7b Starts foreground service before stopping it to avoid app crash when listening to an audio file
Signed-off-by: Guillermo Mtz Espina <gmotzespina@icloud.com>
2021-11-14 11:40:40 +00:00
tobiasKaminsky
9751de3934
Query Param needs serial uid
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-11-14 08:17:42 +01:00
Nextcloud bot
507f0ae9be
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-13 03:50:49 +00:00
Nextcloud bot
7a8845777c
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-12 03:45:57 +00:00
Nextcloud bot
a1ce4fd57e
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-11 03:50:41 +00:00
Tobias Kaminsky
cce56c4b2f
Merge pull request #9237 from nextcloud/fix/view-files
Manifest: allow app to query for apps that can resolve VIEW or SEND intents
2021-11-10 07:56:36 +01:00
Nextcloud bot
e25c82126f
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-10 03:54:32 +00:00
Álvaro Brey Vilas
80f3f09bd1
Manifest: allow app to query for apps that can resolve VIEW or SEND intents
This is otherwise limited by default in sdk 30 and above

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-09 16:28:12 +01:00
Álvaro Brey Vilas
fc7f91add8
Remove some unused resources
Slipped through on MANAGE_EXTERNAL_STORAGE pr

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-09 14:08:08 +01:00
Álvaro Brey
38e78b3f37
Merge pull request #9228 from nextcloud/manage-all-files
Ditch scoped storage in favor of MANAGE_EXTERNAL_STORAGE
2021-11-09 12:25:33 +01:00
Álvaro Brey
f0ee7d719e
Merge pull request #9186 from nextcloud/strictMode
Enable StrictMode during development
2021-11-09 09:59:03 +01:00
Álvaro Brey Vilas
361ed24bb4
Add dialog to inform the user of storage permission
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-09 09:46:38 +01:00
tobiasKaminsky
9b0db8a355
Enable StrictMode during development
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-11-09 09:04:25 +01:00
Nextcloud bot
6e9dc44e71
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-09 07:52:44 +00:00
Álvaro Brey
7bd0190c4b
Merge pull request #9225 from nextcloud/wording
rename "read only" -> "view only"
2021-11-09 08:30:19 +01:00
Álvaro Brey Vilas
7966fa7923
Re-try to get file management permission if user does not enable it, and show toast.
Does not allow any usage of the app if permission is not granted.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-08 16:56:22 +01:00
Álvaro Brey Vilas
44968b20ad
PermissionUtil: fix version conditional
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-08 16:26:44 +01:00
tobiasKaminsky
f4f0c22492
rename "read only" -> "view only"
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-11-08 14:05:45 +01:00
Álvaro Brey Vilas
3c80a05354
Revert "Use internalTemporalPath instead of temporalPath"
This reverts commit 1811d040f7.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-08 13:50:43 +01:00
Álvaro Brey Vilas
41dbdaf3ed
Revert "DownloadFileOperation: use moveFile instead of File.renameTo"
This reverts commit f18f72abcd.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-08 13:50:26 +01:00
Álvaro Brey Vilas
5eeb8c0343
Remove What's New screens for scoped storage
Not needed if we get the manage permission

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-08 13:46:23 +01:00
Álvaro Brey Vilas
6a76372fde
GrantStoragePermissionRule: grant MANAGE_EXTERNAL_STORAGE on sdk >=30
Feels a bit hacky but it's the actual recommended way:
https://developer.android.com/training/data-storage/manage-all-files#enable-manage-external-storage-for-testing

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-08 13:40:17 +01:00
Álvaro Brey Vilas
a0b85cac71
Ditch scoped storage, try MANAGE_EXTERNAL_STORAGE
We _are_ a file-managing app, after all.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-08 13:13:02 +01:00
Valdnet
a638101359
i18n: Minor changes to sentence
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-11-08 09:02:27 +01:00
Nextcloud bot
dce7eb713a
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-08 06:34:35 +00:00
tobiasKaminsky
915b764f36
Translation files must be one line
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-11-08 07:04:59 +01:00
Álvaro Brey
518343c4e4
Merge pull request #9195 from nextcloud/whats-new-sdk-30
Add What's New view to warn users of changes in storage after sdk 30
2021-11-04 14:35:29 +01:00
Álvaro Brey
35a2324482
Merge pull request #9175 from nextcloud/fix/url-parse-search-result
Unified search: skip local file check for non-file results
2021-11-04 14:27:25 +01:00
Álvaro Brey
a994ebc3f4
Merge pull request #9044 from nextcloud/target-sdk-30
Target SDK 30
2021-11-04 13:46:16 +01:00
Álvaro Brey Vilas
cb6d9a6c07
What's new: add second page of info for sdk30 storage update
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-04 13:03:14 +01:00
Álvaro Brey Vilas
40860d98be
AppInfo: add getVersionName, remove getFormattedVersionCode
Only used for WhatsNewActivity, and showing the human-readable string makes more sense.
Also convert the appinfo package to kotlin, since we're at it

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-04 12:44:28 +01:00
tobiasKaminsky
c15f64308b Use package specific action
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-11-04 08:21:12 +00:00
Álvaro Brey Vilas
be43a629fd
Add What's New view to warn users of changes in storage after sdk 30
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-03 16:49:20 +01:00
Álvaro Brey Vilas
6d4b3b8444
Fix ktlint
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-03 10:30:10 +01:00
Álvaro Brey Vilas
5e00733912
Add missing copyright header to PermissionUtil
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-03 09:16:22 +01:00
Nextcloud bot
6822cfda6a
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-03 03:50:54 +00:00
Álvaro Brey Vilas
f18f72abcd
DownloadFileOperation: use moveFile instead of File.renameTo
File.renameTo fails if both files aren't under the same mountpoint.
As the tmp file is in internal storage now, it has to be move differently if the target dir is in external storage.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 16:31:46 +01:00
Álvaro Brey Vilas
1811d040f7
Use internalTemporalPath instead of temporalPath
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 12:59:06 +01:00
Álvaro Brey
578da09f05
Merge pull request #9179 from sryze/contact-settings-back-fix
Prevent duplicate Settings activity on back stack
2021-11-02 09:40:28 +01:00
Sergey Zolotarev
f08ad758cd Prevent duplicate Settings activity on back stack
Signed-off-by: Sergey Zolotarev <sryze@protonmail.com>
2021-11-02 14:05:59 +06:00
Álvaro Brey Vilas
063ef4f8df
Fix PermissionUtil after rebase
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:44 +01:00
Álvaro Brey Vilas
0ad8c4350d
Fix storage permissions in debug manifest too
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:43 +01:00
Álvaro Brey Vilas
886c2574fb
MediaProvider: remove useless parens
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:43 +01:00
Álvaro Brey Vilas
95c31750a7
AbstractIT: adaptations to make integration tests work in sdk 30
- Use internal temporal path, as external temporal path is broken in sdk 30
- Don't take snapshots in sdk30 as they crash

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:43 +01:00
Álvaro Brey Vilas
c1316da717
Request READ_EXTERNAL_STORAGE in API >= 30
Although scoped storage is in effect and WRITE_EXTERNAL_STORAGE does not do anything,
we still need READ_EXTERNAL_STORAGE to read files from folders we don't own.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:42 +01:00
Álvaro Brey Vilas
2cb05a17a5
androidTest: Don't request WRITE_EXTERNAL_STORAGE on sdk>=30
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:42 +01:00
Álvaro Brey Vilas
1154b439fe
ContentResolverHelperTest: use mockitokotlin instead of mockk
MockK doesn't work properly on android < 27. Lesson learned.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:42 +01:00
Álvaro Brey Vilas
be830a66c8
COntentResolverHelper: sort column must be an array
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:42 +01:00
Álvaro Brey Vilas
8860bd4b52
Fix OCFIleListFragmentIT on sdk 30
Can no longer open /sdcard/ directly, let's use the external files dir

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:41 +01:00
Álvaro Brey Vilas
aa7b5617ab
ContentResolverHelper: add tests and proper copyright headers
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:41 +01:00
Álvaro Brey Vilas
6e645f7f06
MediaProvider: solve crash on Android 11 due to invalid contentProvider queries
This manifested mostly when trying to open "auto upload"

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:40 +01:00
Álvaro Brey Vilas
d92e3cbfaa
Fix some type errors after sdk 30 bump
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 08:29:40 +01:00
Álvaro Brey Vilas
ac9f516027 Unified search: skip local file check for non-file results
Fixes https://github.com/nextcloud/android/issues/9171

Needs https://github.com/nextcloud/android-library/pull/739

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-11-02 07:23:33 +00:00
Nextcloud bot
0558b25ee3
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-02 03:49:39 +00:00
Nextcloud bot
346fc512a2
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-11-01 03:48:17 +00:00
Nextcloud bot
3abf27f947
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-30 03:50:46 +00:00
Nextcloud bot
f9bfb044dc
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-29 03:49:55 +00:00
Álvaro Brey Vilas
9a94ddc1cc
ConnectivityService: handle SecurityException in getNetworkCapabilities
Bug on Android implementation

See: https://stackoverflow.com/questions/66652819/getting-security-exception-while-trying-to-fetch-networkcapabilities-on-android

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-28 10:13:30 +02:00
Nextcloud bot
da095ddfb6
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-28 03:51:04 +00:00
tobiasKaminsky
3823eccfe6
AccountManagerService needs to be exported
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-10-27 08:49:05 +02:00
Nextcloud bot
8c0e77ae93
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-27 03:55:09 +00:00
tobiasKaminsky
bbcfdbe98d
Remove unneeded checks for M build target
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-10-26 07:57:01 +02:00
Nextcloud bot
a946385603
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-26 03:50:35 +00:00
Nextcloud bot
2c7c571fca
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-25 14:25:18 +00:00
Tobias Kaminsky
6176998a0e
Merge pull request #9141 from nextcloud/bump-outdated-server-version
Bump versions before RC
2021-10-25 16:13:56 +02:00
Tobias Kaminsky
6e76954fcf
Merge pull request #8848 from nextcloud/sharingDialog
Sharing dialog improvement
2021-10-25 16:08:23 +02:00
Álvaro Brey Vilas
0984213b62
AndroidManifest: remove resources with maxSDK=22
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:44:36 +02:00
Álvaro Brey Vilas
e99960c59d
TestPowerManagementService: Bump SDK version used for test
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:39:25 +02:00
Álvaro Brey Vilas
16b83131c8
Bump OUTDATED_SERVER_VERSION to 19
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:25:44 +02:00
tobiasKaminsky
0cdfd7a906
Optimize imports
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-10-25 15:18:31 +02:00
tobiasKaminsky
3965f22e7c
remove unused foreground (which was working only on API23+)
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-10-25 15:17:58 +02:00
Álvaro Brey Vilas
6fe72782fe
FileDisplayActivity: fix new spotbugs warning
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:58 +02:00
Álvaro Brey Vilas
d7d3157410
Unified search: solve RTL symmetry warnings
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:58 +02:00
Álvaro Brey Vilas
631db66da7
Unified search: show context leak in UnifiedSearchViewModel
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:57 +02:00
Álvaro Brey Vilas
8cadb2b5de
Unified search: add placeholder icon for Deck
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:57 +02:00
Álvaro Brey Vilas
c51df6fb5b
Unified search: better placeholder icons
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:57 +02:00
Álvaro Brey Vilas
16100677bb
Unified search: fix inverted success value for "load more"
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:56 +02:00
Álvaro Brey Vilas
f927cfe2d8
Unified search: Round thumbnails when requested by server
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:56 +02:00
Álvaro Brey Vilas
b6cd8af18a
GetRemoteFileTask: pass User directly instead of account
Needed after model changes in master

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:56 +02:00
Álvaro Brey Vilas
2387545119
Unified search: Fix broken integration test
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:55 +02:00
Álvaro Brey Vilas
18cbdfa93c
Unified search: minor UI improvements
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:55 +02:00
Álvaro Brey Vilas
61c2242896
Unified search: cleanup viewmodel usage with interface
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:54 +02:00
Álvaro Brey Vilas
fdf1abd0fd
Unified search: fix opening non-file results (open in a browser)
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:54 +02:00
Álvaro Brey Vilas
c3a1656781
Unified search: fix existing tests to make CI happy
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:54 +02:00
tobiasKaminsky
73e4f3cf05
fix loading message
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-10-25 15:17:53 +02:00
Álvaro Brey Vilas
146650c0c6
Unified search: bind search view on US fragment to allow subsequent searches
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:53 +02:00
Álvaro Brey Vilas
361e81ea9c
Unified search: set toolbar title to search query
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:53 +02:00
Álvaro Brey Vilas
3fc6fc8bdf
Unified search: several UI and navigation improvements
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:53 +02:00
Álvaro Brey Vilas
fac2958788
Unified search: Show error messages, loading anim, click animations. Implement refresh.
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:52 +02:00
Álvaro Brey Vilas
e898965dc1
Unified search: transform results in ViewModel and fix "load more" behaviour
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:52 +02:00
Álvaro Brey Vilas
484a506688
Unified search: do not show "load more" if there are no more results
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:52 +02:00
Álvaro Brey Vilas
e8feb412a4
Unified search: basic "Load more" functionality
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:51 +02:00
Álvaro Brey Vilas
02d133a1c7
Unified search: always show files results first
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:51 +02:00
Álvaro Brey Vilas
6c98b4cb8d
Unified seach: allow querying different providers asynchronously, and get their IDs in the result
First step towards getting "Load more" working for a single provider

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:50 +02:00
Álvaro Brey Vilas
b0b9d3a3e3
Unified search: get search to fetch and show multiple providers
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:50 +02:00
Álvaro Brey Vilas
decfc91d58
FileDisplayActivity: Restore showFile function that was lost in the rebase
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:50 +02:00
Álvaro Brey Vilas
7d3fbe47d0
Suppress detekt at UnifiedSearchItemViewHolder
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:49 +02:00
Álvaro Brey Vilas
276b8d7b28
Fix build errors after rebase
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:17:49 +02:00
Andy Scherzinger
57732aceb9
ktlint: proper code formatting
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-10-25 15:17:49 +02:00
tobiasKaminsky
1136aa3748
wip
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-10-25 15:17:48 +02:00
tobiasKaminsky
232ffe7d5c
wip
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-10-25 15:17:48 +02:00
tobiasKaminsky
96ea22525e
wip
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-10-25 15:17:48 +02:00
tobiasKaminsky
3a39b041de
wip
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-10-25 15:17:46 +02:00
Álvaro Brey Vilas
dc5756246a
Sharing dialog: fix spotbugs
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:13:08 +02:00
Álvaro Brey Vilas
295c24aa78
File sharing: remove unused background parameters that were triggering lint
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:13:07 +02:00
Álvaro Brey Vilas
80327fc3b9
Sharing dialog IT: add retries and sleeps
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:13:07 +02:00
Álvaro Brey Vilas
5afcad3fed
FileSharingFragmentIT: fix test and delete unused variables
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:13:07 +02:00
tobiasKaminsky
891146eb8a
Reduce lint
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-10-25 15:13:06 +02:00
Álvaro Brey Vilas
b367684e21
Patch up integration tests for file sharing
This requires a lot of dodgy code, unfortunately. A refactor is greatly needed here.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:13:06 +02:00
Álvaro Brey Vilas
42ac3bcb11
Sharing dialog: fix accessibility in bottom sheet
Add min height for touchable area.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-25 15:13:06 +02:00
tobiasKaminsky
80b8173e45
fix ktlint
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-10-25 15:13:06 +02:00
A117870935
df6d590196
Sharing dialog improvement
changed overflow menu items for sharing files and folders

completed NMCLOUD-350 for share permissions and fixed test cases as per new changes

permission menu code optimisation

added permission display to share fragment list items

fixed permission issue for files, added strings for german

changed sharing process for internal and external share by creating new full screen permission and note ui.
created new remote operation to share the file/folder with permissions

changed sharing menu options from popup to bottom sheet for all shares, modified options for link share

test cases written for updated sharing process

updated PR as per Tobias feedback:
1. Failed test cases reverted
2. Quick permissions sheet modified
3. Minor UI changes done.
4. Commented code removed

copyright header added

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-10-25 15:12:58 +02:00
Tobias Kaminsky
215c1c90db
Merge pull request #9015 from nextcloud/calendarSync
Calendar backup/import
2021-10-25 15:09:11 +02:00
Tobias Kaminsky
d544e18960
Merge pull request #9112 from nextcloud/profilePage
Profile page
2021-10-25 15:07:32 +02:00
Tobias Kaminsky
765e2ca442
Merge pull request #9125 from eckR/bugfix/fix-email-type
Bugfix/fix email type
2021-10-25 14:33:56 +02:00
tobiasKaminsky
6d07584a54
Profile page
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-10-25 14:05:33 +02:00
tobiasKaminsky
042c413569
Calendar backup/import
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-10-25 13:02:12 +02:00
Tobias Kaminsky
2693c103b3
Merge pull request #9139 from nextcloud/suppress-walled-network-test-on-metered-wifi
Suppress walled network check when on metered wifi
2021-10-25 09:55:55 +02:00
Tobias Kaminsky
344a12d95a
Merge pull request #8916 from tom-bowles/master
Handle 'Stream with...' option in PreviewMediaFragment
2021-10-25 09:18:05 +02:00
tobiasKaminsky
d064352011
Fix test
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-10-25 09:10:21 +02:00
Tobias Kaminsky
aa1f1add49
Merge pull request #9137 from nextcloud/fix-npe-in-conflict-resolution-activity
Fix NPE in ConflictsResolveActivity
2021-10-25 07:59:01 +02:00
Tobias Kaminsky
9f64cba2b9
Merge pull request #9138 from nextcloud/fix-npe-during-contacts-backup
Fix NPE during contacts backup
2021-10-25 07:57:30 +02:00
Nextcloud bot
b423b42b89
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-25 03:47:09 +00:00
Chris Narkiewicz
57b2a8ef1a
Removed deprecated FileDataStorageManager constructors entirely
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2021-10-25 03:41:59 +01:00
Chris Narkiewicz
8cf4ed7b71
Suppress walled network check when on metered wifi
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2021-10-25 03:34:56 +01:00
Chris Narkiewicz
8e5c8dd840
Fix NPE during contacts backup
Fixes #9080

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2021-10-25 02:00:17 +01:00
Chris Narkiewicz
53eea6d08e Deprecate FileDataStorageManager constructors depending on legacy Account
This commit deprecates constructors using legacy platform Account type
and wraps them using new API accepting User model.

All calls to FileDataStorageManager constructors that were trivially
portable without are updated as well. Places where passing new type
requires more risku work were left out for now.

FileDataStorageManager still uses Account internally - modifying this
requires getting rid of all legacy constructors first.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2021-10-25 00:30:11 +01:00
Chris Narkiewicz
b3e280bce5
Fix NPE in ConflictsResolveActivity
Fixes #9133

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2021-10-24 23:23:17 +01:00
Nextcloud bot
ea92f8432c
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-24 03:49:18 +00:00
Chris Narkiewicz
130c05e4ca Fix NPE crash when uploading files
Fixes #9099
2021-10-23 14:26:29 +01:00
Nextcloud bot
7c03e0f453
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-23 03:53:17 +00:00
Lisa Kirchhofer
0051189017 Bugfix: Issue #9060 (Status bar with sorting/view mode disappears after playing video)
Signed-off-by: Lisa Kirchhofer <lisa.kirchhofer@bawagpsk.com>
2021-10-22 16:12:09 +02:00
Harald Ecker
b5825d73c4 remove icon mapping
Signed-off-by: Harald Ecker <harald.ecker@squer.at>
2021-10-22 14:48:07 +02:00
Harald Ecker
1217466fa5 add rfc822 to mimetypeutil
Signed-off-by: Harald Ecker <harald.ecker@squer.at>
2021-10-22 14:48:07 +02:00
Tobias Kaminsky
ca49423faf
Merge pull request #9114 from nextcloud/strugee/cleanup-notification-channels
Clean up notification channels
2021-10-22 08:45:00 +02:00
Tobias Kaminsky
34906df398
Merge pull request #9072 from nextcloud/deprecate-file-storage-manager-constructors-using-platform-account
Deprecate FileDataStorageManager constructors depending on legacy Account
2021-10-22 08:38:24 +02:00
Nextcloud bot
48668c96d0
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-22 03:49:36 +00:00
AJ Jordan
bbf7441715 Delete unused "File observer" notification channel
Signed-off-by: AJ Jordan <alex@strugee.net>
2021-10-21 12:02:57 -07:00
AJ Jordan
ebd5b6f1d6 Fix notification channel strings not being updated
NotificationManager#createNotificationChannel() is safe to run again
even if the notification channel has already been created - in this case
it simply updates the name and description, which is what we want.

Signed-off-by: AJ Jordan <alex@strugee.net>
2021-10-21 12:02:57 -07:00
AJ Jordan
beef71974c Make notification channel names less technical
Signed-off-by: AJ Jordan <alex@strugee.net>
2021-10-21 12:02:57 -07:00
Tobias Kaminsky
2ceb34ae97
Merge pull request #9087 from nextcloud/circularSearchBar
Make search bar fully circular rounded
2021-10-21 12:23:53 +02:00
tobiasKaminsky
b6ecf515b3
Fix GHSL-2021-1008 by using permission instead of readPermission
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-10-20 09:56:18 +02:00
Nextcloud bot
8857ea7ddf
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-20 04:10:43 +00:00
tobiasKaminsky
6e1dbaad33
Explicitly specify exported="true/false" for all
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-10-18 11:48:39 +02:00
Nextcloud bot
c98003e21f
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-18 03:51:24 +00:00
Andy Scherzinger
b96b2f2ff8
align search bar text with items
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-10-14 16:06:25 +02:00
Andy Scherzinger
dd00998c1a
make search bar more circular
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-10-14 16:06:21 +02:00
Nextcloud bot
6b855fb2f9
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-10 03:51:38 +00:00
Álvaro Brey Vilas
e579dabe7d
Revert "AndroidManifest: don't request WRITE_EXTERNAL_STORAGE above api 29"
Wrong branch!

This reverts commit 91cf4ef271.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-08 15:43:27 +02:00
Álvaro Brey Vilas
91cf4ef271
AndroidManifest: don't request WRITE_EXTERNAL_STORAGE above api 29
Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-08 15:29:53 +02:00
Chris Narkiewicz
ee4808213b
Deprecate FileDataStorageManager constructors depending on legacy Account
This commit deprecates constructors using legacy platform Account type
and wraps them using new API accepting User model.

All calls to FileDataStorageManager constructors that were trivially
portable without are updated as well. Places where passing new type
requires more risku work were left out for now.

FileDataStorageManager still uses Account internally - modifying this
requires getting rid of all legacy constructors first.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2021-10-08 00:04:54 +01:00
Chris Narkiewicz
0af07dd015
Check if UI bindings are valid when selecting preview text
Moved text marking logic into a separate method and extracted
preconditions out from the ifology ladder.

Fixes #9018

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2021-10-07 21:27:34 +01:00
Álvaro Brey
302c927bec
Merge pull request #8727 from nextcloud/migrate-synchronize-folder-operation-to-new-user-model
Migrate SynchronizeFolderOperation to new User model
2021-10-07 16:43:48 +02:00
Álvaro Brey
c71f7d235e
Merge pull request #9064 from nextcloud/chore/more-test-retry
LoginIT: Add retry test rule
2021-10-07 09:50:31 +02:00
Álvaro Brey
f7216cfbca
Merge pull request #9068 from nextcloud/fix-npe-in-file-detail-fragment
Do not mark comments as read when FileDetailActivitiesFragment is detached
2021-10-07 09:20:10 +02:00
Álvaro Brey Vilas
81b133adc7 LoginIT: Add retry test rule
Flaaaaaaky.

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-10-07 07:15:31 +00:00
Álvaro Brey
65f6c194ce
Merge pull request #9065 from nextcloud/suppress-fullscreen-option-for-audio-preview
Suppress fullscreen option when previewing audio files
2021-10-07 08:40:39 +02:00
Nextcloud bot
80f4bf8be8
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-07 03:52:52 +00:00
Chris Narkiewicz
e1ce779f04
Do not mark comments as read when FileDetailActivitiesFragment is detached
Fixes #8994

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2021-10-06 23:02:55 +01:00
Chris Narkiewicz
3db40786e0
Migrate SynchronizeFolderOperation to new User model
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2021-10-06 22:17:45 +01:00
Chris Narkiewicz
3250c5c3fe
Suppress fullscreen option when previewing audio files
Fixes #8903

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2021-10-06 22:14:26 +01:00
Andy Scherzinger
d42b86c0eb spotbugs: remove primitive boxing
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-10-06 08:26:25 +00:00
Andy Scherzinger
c2a6e587e8 spotbugs: remove redundant nullcheck of doubleCheck
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-10-06 08:26:25 +00:00
Andy Scherzinger
2fc814bf39 lint: Using android:onClick on older version of the platform is broken
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2021-10-06 08:26:25 +00:00
Nextcloud bot
1b0f9bbbf0
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-10-05 03:50:29 +00:00
tobiasKaminsky
68caad4b39
Remove setHasFixedSize as it is not needed
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-09-30 07:07:21 +02:00
Álvaro Brey
4ec71da7a1
Merge pull request #9032 from nextcloud/reAddRetryTestRule
Re-add retryTestRule
2021-09-29 12:52:51 +02:00
Tobias Kaminsky
ecbb64bbba
Merge pull request #8831 from hrk/spotbugs-boxed-primitive-for-compare
Fix: boxed primitive for compare
2021-09-29 12:18:03 +02:00
Álvaro Brey Vilas
c1092d15c4 EndToEndRandomIT: also add RetryTestRule
Flaaaky

Signed-off-by: Álvaro Brey Vilas <alvaro.brey@nextcloud.com>
2021-09-29 09:27:08 +00:00
tobiasKaminsky
aee16ec64a Re-add retryTestRule
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-09-29 09:27:08 +00:00
tobiasKaminsky
a57f8eb989
Enhance screenshot handling
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2021-09-29 09:16:10 +02:00
Nextcloud bot
545197d68c
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-28 03:57:17 +00:00
Andy Scherzinger
cfae25c137
Merge pull request #8818 from binsky08/add-sso-patch-method
add custom PatchMethod class to use http PATCH requests with the Nextcloud SSO api
2021-09-27 12:09:28 +02:00
Nextcloud bot
c5a06b7225
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-26 03:58:45 +00:00
Nextcloud bot
5b44ea2408
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-25 03:57:30 +00:00
Nextcloud bot
27dd912bff
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-23 04:16:07 +00:00
Nextcloud bot
7a003bcdab
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-22 03:59:48 +00:00
Timo Triebensky
5e6e3d4800
Merge branch 'master' into add-sso-patch-method 2021-09-21 11:39:25 +02:00
Nextcloud bot
ede8995e3b
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-20 03:56:02 +00:00
Nextcloud bot
aa415e6b55
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-19 03:56:30 +00:00
Nextcloud bot
f1cb45ab30
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-18 04:01:05 +00:00
Nextcloud bot
3e6c9627d1
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-17 03:55:56 +00:00
Nextcloud bot
2866bc3898
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-15 03:58:40 +00:00
Nextcloud bot
70daf0b327
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-14 04:03:14 +00:00
Nextcloud bot
00fa174b38
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-13 03:58:38 +00:00
Nextcloud bot
81799410be
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-12 04:00:37 +00:00
Nextcloud bot
a057dafab3
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-11 03:57:15 +00:00
Valdnet
eaf9f0ca80
l10n: Spelling unification
Spelling unification in Transifex.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-09-10 12:11:47 +02:00
Nextcloud bot
77d0b06105
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-10 04:08:54 +00:00
Andy Scherzinger
865a59336b
Merge pull request #8656 from nextcloud/remove-account-from-thumbnail-task
Migrate ThumbnailCacheManager to User model
2021-09-09 13:58:59 +02:00
Nextcloud bot
6517be09df
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-09 03:57:32 +00:00
Chris Narkiewicz
f134cf4cd3 Migrate ThumbnailCacheManager to User model
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2021-09-08 10:39:22 +00:00
Nextcloud bot
c6610937f7
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-08 03:54:26 +00:00
Nextcloud bot
7ad1cce4df
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2021-09-07 03:58:10 +00:00
t-m-w
3fc5be9b07 Fix opening downloaded files when offline (#5265)
Signed-off-by: t-m-w <7275539+t-m-w@users.noreply.github.com>
2021-09-06 13:26:04 +00:00