mirrors/nextcloud-android
1
0
Fork 0
mirror of https://github.com/nextcloud/android.git synced 2024-11-26 07:05:49 +03:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #9068 from nextcloud/fix-npe-in-file-detail-fragment

Browse source 
Do not mark comments as read when FileDetailActivitiesFragment is detached
This commit is contained in:
Álvaro Brey 2021-10-07 09:20:10 +02:00 committed by GitHub
commit f7216cfbca
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/main/java/com/owncloud/android/ui/fragment/FileDetailFragment.java
View file

@ -237,10 +237,10 @@ public class FileDetailFragment extends FileFragment implements OnClickListener,
binding.pager.addOnPageChangeListener(new TabLayout.TabLayoutOnPageChangeListener(binding.tabLayout) {
@Override
public void onPageScrolled(int position, float positionOffset, int positionOffsetPixels) {
if (activeTab == 0) {
getFileDetailActivitiesFragment().markCommentsAsRead();
final FileDetailActivitiesFragment fragment = getFileDetailActivitiesFragment();
if (activeTab == 0 && fragment != null) {
fragment.markCommentsAsRead();
}
super.onPageScrolled(position, positionOffset, positionOffsetPixels);
}
});
@ -248,10 +248,8 @@ public class FileDetailFragment extends FileFragment implements OnClickListener,
@Override
public void onTabSelected(TabLayout.Tab tab) {
binding.pager.setCurrentItem(tab.getPosition());
if (tab.getPosition() == 0) {
FileDetailActivitiesFragment fragment = getFileDetailActivitiesFragment();
final FileDetailActivitiesFragment fragment = getFileDetailActivitiesFragment();
if (fragment != null) {
fragment.markCommentsAsRead();
}