Commit graph

13549 commits

Author SHA1 Message Date
Jens Mueller
332e67c72d
refactor/cleanup
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:37 +02:00
Jens Mueller
8d24d80fdc
Revert "reduce contentresolver/sql queries"
This reverts commit ec5a73142dee30cd909db9e68b97ef65456f7c48.

Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:36 +02:00
Jens Mueller
5de451fa98
fix initialization of storage manager collection
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:35 +02:00
Jens Mueller
fa5e5dd8cd
notify storageprovider on account creation/removal
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:35 +02:00
Jens Mueller
cfd3aab952
reduce contentresolver/sql queries
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:34 +02:00
Jens Mueller
a2350598da
fix isChildDocument()
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:33 +02:00
tobiasKaminsky
b2eacc46b4
- fix error when temp folder does not yet exist
- do not use FileUploader for uploads

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-23 17:27:32 +02:00
Jens Mueller
a14747623d
move checks into toDocument()
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:32 +02:00
Jens Mueller
65655c5753
fix build
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:31 +02:00
Jens Mueller
3693ad88c1
remove unused imports
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:30 +02:00
Jens Mueller
fbff63bb02
fix lint warnings
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:30 +02:00
Jens Mueller
dddffce2a1
fix review comments
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:29 +02:00
Jens Mueller
e62879ac91
cleanup
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:28 +02:00
Jens Mueller
fe43e503a3
cleanup/fix review comments
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:28 +02:00
Jens Mueller
7f157a9ff1
enhance documents storage provider
Signed-off-by: Jens Mueller <tschenser@gmx.de>
2019-10-23 17:27:24 +02:00
Andy Scherzinger
3dcbfa1236
Merge pull request #4712 from nextcloud/fetchRemoteFile
Fix possible IndexOutOfBoundsException if returned array is empty
2019-10-23 14:24:52 +02:00
dependabot-preview[bot]
3e34679dcf Bump daggerVersion from 2.24 to 2.25 (#4721)
Bumps `daggerVersion` from 2.24 to 2.25.

Updates `dagger` from 2.24 to 2.25
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](https://github.com/google/dagger/compare/dagger-2.24...dagger-2.25)

Updates `dagger-android` from 2.24 to 2.25
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](https://github.com/google/dagger/compare/dagger-2.24...dagger-2.25)

Updates `dagger-android-support` from 2.24 to 2.25
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](https://github.com/google/dagger/compare/dagger-2.24...dagger-2.25)

Updates `dagger-compiler` from 2.24 to 2.25
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](https://github.com/google/dagger/compare/dagger-2.24...dagger-2.25)

Updates `dagger-android-processor` from 2.24 to 2.25
- [Release notes](https://github.com/google/dagger/releases)
- [Changelog](https://github.com/google/dagger/blob/master/CHANGELOG.md)
- [Commits](https://github.com/google/dagger/compare/dagger-2.24...dagger-2.25)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-23 10:15:01 +02:00
Nextcloud bot
e9cf6be691
[tx-robot] updated from transifex 2019-10-23 03:07:48 +00:00
Nextcloud bot
59c3690c87
[tx-robot] updated from transifex 2019-10-22 03:08:34 +00:00
Tobias Kaminsky
5fe1835b14 daily dev 20191022
adc74c1e4 Bump fb-contrib from 7.4.6 to 7.4.7 (#4711)
123e708b7 Merge pull request #4710 from nextcloud/ezaquarii/eliminate-account-status-flags-from-base-activity
148cef835 [tx-robot] updated from transifex
b7cdaf310 Eliminate account status flags from BaseActivity
17a6ba2d2 daily dev 20191019
2019-10-22 03:37:17 +02:00
dependabot-preview[bot]
adc74c1e41 Bump fb-contrib from 7.4.6 to 7.4.7 (#4711)
* Bump fb-contrib from 7.4.6 to 7.4.7

Bumps [fb-contrib](https://github.com/mebigfatguy/fb-contrib) from 7.4.6 to 7.4.7.
- [Release notes](https://github.com/mebigfatguy/fb-contrib/releases)
- [Commits](https://github.com/mebigfatguy/fb-contrib/compare/v7.4.6...v7.4.7)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Drone: update FindBugs results to reflect reduced error/warning count [skip ci]

Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2019-10-22 00:30:55 +02:00
Tobias Kaminsky
123e708b7a
Merge pull request #4710 from nextcloud/ezaquarii/eliminate-account-status-flags-from-base-activity
Eliminate account status flags from BaseActivity
2019-10-21 16:02:12 +02:00
tobiasKaminsky
750c0a7677
Fix possible IndexOutOfBoundsException if returned array is empty
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-21 08:27:10 +02:00
Nextcloud bot
148cef835f
[tx-robot] updated from transifex 2019-10-21 03:08:30 +00:00
Chris Narkiewicz
b7cdaf310b
Eliminate account status flags from BaseActivity
onAccountSet(stateWasRecovered) is no longer used anywhere,
so the flag mAccountWasRestored can be safely removed.

This intermediary step opens path to eliminating
out of band calls to onAccountSet().

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-20 23:27:41 +01:00
Tobias Kaminsky
17a6ba2d2f daily dev 20191019
954c76b11 Merge pull request #4692 from nextcloud/markdownPreview
2a8164acf Merge pull request #4700 from nextcloud/account-cleanup-receive-external-file-activity
76622c886 [tx-robot] updated from transifex
8fa348f80 Bump findsecbugs-plugin from 1.9.0 to 1.10.0 (#4703)
e31ff9901 daily dev 20191018
2019-10-19 03:38:21 +02:00
Tobias Kaminsky
954c76b11b
Merge pull request #4692 from nextcloud/markdownPreview
Markdown rendering
2019-10-18 10:21:01 +02:00
Tobias Kaminsky
2a8164acf1
Merge pull request #4700 from nextcloud/account-cleanup-receive-external-file-activity
Remove onAccountSet from ReceiveExternalFilesActivity
2019-10-18 10:17:48 +02:00
Nextcloud bot
76622c8861
[tx-robot] updated from transifex 2019-10-18 07:12:22 +00:00
dependabot-preview[bot]
8fa348f801 Bump findsecbugs-plugin from 1.9.0 to 1.10.0 (#4703)
* Bump findsecbugs-plugin from 1.9.0 to 1.10.0

Bumps [findsecbugs-plugin](https://github.com/find-sec-bugs/find-sec-bugs) from 1.9.0 to 1.10.0.
- [Release notes](https://github.com/find-sec-bugs/find-sec-bugs/releases)
- [Changelog](https://github.com/find-sec-bugs/find-sec-bugs/blob/master/CHANGELOG.md)
- [Commits](https://github.com/find-sec-bugs/find-sec-bugs/compare/version-1.9.0...version-1.10.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

* Drone: update FindBugs results to reflect reduced error/warning count [skip ci]

Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2019-10-18 08:45:20 +02:00
Tobias Kaminsky
e31ff9901f daily dev 20191018
16cc46f4e Merge pull request #4687 from nextcloud/account-cleanup-upload-files-activity
d9567a2bb Merge pull request #4686 from nextcloud/account-cleanup-image-video-preview
2d9afe36c Merge pull request #4688 from nextcloud/account-cleanup-share-activity
f4a27cc5d Merge pull request #4693 from nextcloud/account-cleanup-file-display-activity
d237a834b Merge pull request #4699 from nextcloud/removeUploadPathActivity
64c986eaf Merge pull request #4689 from nextcloud/account-cleanup-folder-picker-activity
56d188086 Bump powermock-core from 2.0.2 to 2.0.4 (#4695)
ca77c7a2d Bump powermock-api-mockito2 from 2.0.2 to 2.0.4 (#4696)
baaf5d4f4 Bump powermock-module-junit4 from 2.0.2 to 2.0.4 (#4697)
ab904e336 We do not use UploadPathActivity anymore(?)
9773dc43c Merge pull request #4694 from nextcloud/account-cleanup-conflicts-resolve-activity
ae6cfb34c daily dev 20191017
2019-10-18 03:36:24 +02:00
Andy Scherzinger
95e14df1d7
Add markdown rendering to TextPreview
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2019-10-17 19:57:51 +02:00
Chris Narkiewicz
5d6e316570
Remove onAccountSet from ReceiveExternalFilesActivity
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-17 15:45:00 +01:00
Tobias Kaminsky
16cc46f4ed
Merge pull request #4687 from nextcloud/account-cleanup-upload-files-activity
Remove onAccountSet from UploadFilesActivity
2019-10-17 15:22:10 +02:00
Tobias Kaminsky
d9567a2bb6
Merge pull request #4686 from nextcloud/account-cleanup-image-video-preview
Remove onAccountSet from image and video preview activities
2019-10-17 15:21:54 +02:00
Tobias Kaminsky
2d9afe36c9
Merge pull request #4688 from nextcloud/account-cleanup-share-activity
Remove onAccountSet from ShareActivity
2019-10-17 15:21:44 +02:00
Tobias Kaminsky
f4a27cc5dc
Merge pull request #4693 from nextcloud/account-cleanup-file-display-activity
Remove onAccountSet from FileDisplayActivity
2019-10-17 14:58:13 +02:00
Tobias Kaminsky
d237a834b8
Merge pull request #4699 from nextcloud/removeUploadPathActivity
We do not use UploadPathActivity anymore(?)
2019-10-17 11:39:12 +02:00
Tobias Kaminsky
64c986eaf2
Merge pull request #4689 from nextcloud/account-cleanup-folder-picker-activity
Remove onAccountSet from FolderPickerActivity
2019-10-17 11:38:08 +02:00
dependabot-preview[bot]
56d1880860 Bump powermock-core from 2.0.2 to 2.0.4 (#4695)
Bumps [powermock-core](https://github.com/powermock/powermock) from 2.0.2 to 2.0.4.
- [Release notes](https://github.com/powermock/powermock/releases)
- [Changelog](https://github.com/powermock/powermock/blob/release/2.x/docs/changelog.txt)
- [Commits](https://github.com/powermock/powermock/compare/powermock-2.0.2...powermock-2.0.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-17 10:58:56 +02:00
dependabot-preview[bot]
ca77c7a2da Bump powermock-api-mockito2 from 2.0.2 to 2.0.4 (#4696)
Bumps [powermock-api-mockito2](https://github.com/powermock/powermock) from 2.0.2 to 2.0.4.
- [Release notes](https://github.com/powermock/powermock/releases)
- [Changelog](https://github.com/powermock/powermock/blob/release/2.x/docs/changelog.txt)
- [Commits](https://github.com/powermock/powermock/compare/powermock-2.0.2...powermock-2.0.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-17 10:57:16 +02:00
dependabot-preview[bot]
baaf5d4f46 Bump powermock-module-junit4 from 2.0.2 to 2.0.4 (#4697)
Bumps [powermock-module-junit4](https://github.com/powermock/powermock) from 2.0.2 to 2.0.4.
- [Release notes](https://github.com/powermock/powermock/releases)
- [Changelog](https://github.com/powermock/powermock/blob/release/2.x/docs/changelog.txt)
- [Commits](https://github.com/powermock/powermock/compare/powermock-2.0.2...powermock-2.0.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-10-17 10:46:22 +02:00
tobiasKaminsky
ab904e336b
We do not use UploadPathActivity anymore(?)
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2019-10-17 08:23:15 +02:00
Tobias Kaminsky
9773dc43cf
Merge pull request #4694 from nextcloud/account-cleanup-conflicts-resolve-activity
Remove onAccountSet from ConflictsResolveActivity
2019-10-17 07:48:30 +02:00
Tobias Kaminsky
ae6cfb34ce daily dev 20191017
e47daaffd Merge pull request #4684 from nextcloud/codacy2
3ef96f887 Merge pull request #4677 from nextcloud/deprecate-set-account-logic
4f815e47b daily dev 20191016
2019-10-17 03:36:14 +02:00
Chris Narkiewicz
451cec9f3a
Remove onAccountSet from ConflictsResolveActivity
Deprecated onAccountSet logic simply inlined in onStart.
No change of control flow.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-16 21:12:09 +01:00
Chris Narkiewicz
e5a6accf66
Remove onAccountSet from FileDisplayActivity
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-16 21:07:50 +01:00
Chris Narkiewicz
b199a62b78
Remove onAccountSet from image and video preview activities
Both callbacks are directly called from onStart().
Since callback parameter is unused, inline the
callback code in onStart().

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-16 19:57:11 +01:00
Chris Narkiewicz
f428fb5810
Remove onAccountSet from UploadFilesActivity
Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-16 19:55:39 +01:00
Chris Narkiewicz
6a88a02f94
Remove onAccountSet from ShareActivity
Since onAccountSet is called directly from onStart,
we can inline the code in onStart safely.

Signed-off-by: Chris Narkiewicz <hello@ezaquarii.com>
2019-10-16 19:54:30 +01:00