682 commits

Author	SHA1	Message	Date
Chocobo1	d8401c76f5	Avoid holding encoded resume data in memory ... Now it the encoded resume data will be streamed to file instead of a temporary buffer holding the whole of it.	2020-04-07 16:02:09 +08:00
Vladimir Golovnev	fe81633403	Merge pull request #12436 from glassez/fix-savepath ... Save "resume data" when torrent storage is moved	2020-04-07 09:54:51 +03:00
an0n666	026aad2c04	Remove deprecated strict super seeding mode from advanced settings	2020-04-07 09:54:32 +06:00
Mike Tzou	f58f425175	Merge pull request #12430 from rwasef1830/add-outgoing-interfaces ... Fix outgoing interfaces not getting assigned in case addr is not null.	2020-04-07 10:10:32 +08:00
Raif Atef	bf1c9e34d7	Fix outgoing interface is not getting assigned ... Assignment was missing in main branch of condition statement. Closes https://github.com/qbittorrent/qBittorrent/issues/12421	2020-04-06 14:45:44 +02:00
Vladimir Golovnev (Glassez)	0a8c2f75af	Save "resume data" when torrent storage is moved	2020-04-06 12:16:27 +03:00
Mike Tzou	cc090c8e37	Merge pull request #12416 from NotTsunami/master ... Set disk cache size for older libtorrent versions	2020-04-06 12:12:12 +08:00
NotTsunami	e48612a703	Set disk cache size for older libtorrent versions ... Libtorrent versions older than 1.2.6 have a bug when setting disk cache size to auto. See 6c880159c9.	2020-04-04 21:36:01 -04:00
Mike Tzou	a10cee0f2b	Merge pull request #12364 from Chocobo1/fileOutIter ... Avoid holding entire file in memory	2020-04-04 11:07:59 +08:00
Chocobo1	9f281c2d25	Avoid holding entire file in memory ... Previously we need a file buffer that is as large as the file size and this could be a problem when user has less free memory available or having very large data. Now with the help of `FileOutputIterator`, we can have a much smaller, fixed size immediate file buffer and also the code looks nice with `lt::bencode()`.	2020-04-03 18:27:13 +08:00
Chocobo1	17f608685d	Improve logging for errors ... This commit also allows the strings to be translated.	2020-04-02 11:20:09 +08:00
Vladimir Golovnev	96c5af7ae9	Merge pull request #12363 from glassez/fix-unexpected-resume ... Fix unexpected torrent resume after app restart	2020-04-01 20:20:44 +03:00
Vladimir Golovnev (Glassez)	8bd9a97f6f	Fix unexpected torrent resume after app restart ... Closes #12322.	2020-04-01 18:01:18 +03:00
sledgehammer999	bbe5465ba6	Merge pull request #12317 from sledgehammer999/fix_broken_save_path ... Fix broken UNC paths in fastresumes on Windows	2020-03-31 18:34:31 +03:00
sledgehammer999	13af503003	Fix broken UNC paths in fastresumes on Windows ... See #12245 and #12282	2020-03-30 15:21:15 +03:00
Mike Tzou	59f99bb984	Merge pull request #12282 from Tester798/fix-12245 ... Fix regression when fastresume contains network path	2020-03-30 12:53:17 +08:00
Mike Tzou	8a8607bf93	Merge pull request #12175 from NotTsunami/upnp ... Add UPnP lease duration advanced option	2020-03-29 12:29:10 +08:00
NotTsunami	6b4925d222	Add UPnP lease duration advanced option ... This is a new setting added that is pending addition to libtorrent 1.2.6. This setting is important because some routers do not support expiration times on port-maps and do not return an error either, silently failing. The previous default of permanent leases is retained.	2020-03-28 00:32:32 -04:00
Tester798	1c6b4c0a79	Fix regression when fastresume contains network path ... Closes #12245 after regression was introduced in #11785.	2020-03-26 18:54:13 +02:00
Chocobo1	54a685e953	Add logging for SOCKS5 proxy errors	2020-03-26 21:51:05 +08:00
Chocobo1	7de8a4d6e0	Construct QString more efficiently	2020-03-25 12:00:11 +08:00
Chocobo1	2c23840947	Allow to translate error messages	2020-03-25 12:00:11 +08:00
thalieht	18289f2395	Append new move storage job to queue ... fixup e4ff206e3c	2020-03-16 22:39:31 +02:00
Vladimir Golovnev	5127156ba4	Merge pull request #12035 from glassez/move-storage ... Move torrent storages one by one	2020-03-13 15:59:05 +03:00
Mike Tzou	73ee901c45	Merge pull request #12113 from Chocobo1/smart_ptr ... Use helper functions to construct smart pointers	2020-03-06 13:12:41 +08:00
Chocobo1	290d198977	Use proper type for piece index	2020-03-06 01:47:28 +08:00
Chocobo1	2157e500ef	Use helper functions to construct smart pointers	2020-03-05 19:32:28 +08:00
Mike Tzou	ca01b049a6	Merge pull request #12108 from Chocobo1/bits ... Avoid unnecessary memory writes	2020-03-04 23:50:12 +08:00
Mike Tzou	949daf6c73	Merge pull request #12037 from an0n666/seed-mode-fix ... Check if file exists in seed mode	2020-03-04 23:49:47 +08:00
an0n666	f7d2085b0a	Check if file exists in seed mode	2020-03-04 17:38:00 +06:00
Chocobo1	24cd7c3611	Avoid unnecessary memory writes ... Before this change, qbt spent ~1% in these two functions, now it only spends about ~0.5% in my naive testing.	2020-03-04 03:18:39 +08:00
Vladimir Golovnev	b519ece18b	Merge pull request #12095 from glassez/resume-torrent ... Let libtorrent decide whether to resume a torrent	2020-03-01 19:54:16 +03:00
Vladimir Golovnev (Glassez)	74884d57ec	Let libtorrent decide whether to resume a torrent	2020-03-01 08:08:01 +03:00
Mike Tzou	9649c2a163	Merge pull request #12043 from FranciscoPombal/fix-embedded-tracker ... Fix embedded tracker	2020-02-27 21:06:58 +08:00
Vladimir Golovnev	4d2943a782	Merge pull request #12033 from glassez/save-torrent ... Allow to save downloaded metadata as torrent file	2020-02-27 08:49:40 +03:00
FranciscoPombal	966f891d91	Fix response to event=stopped ... BEP-3 says all tracker responses to valid announce requests should be bencoded dictionaries with at least the "peers" and "interval" keys; the "peers" key can be empty. Also clarify support for BEP-21.	2020-02-26 20:47:33 +00:00
FranciscoPombal	af6f63f82c	Don't use IPv4-mapped IPv6 ... Always register peers with either IPv4 or IPv6. Fixes potential connection issues. Also clarify related BEP-24 support.	2020-02-26 20:44:09 +00:00
FranciscoPombal	abc69dfd20	Fix BEP-23 support ... The embedded tracker was returning a non-compliant response. The peer lists should be packed strings instead of lists. Also clarify level of compliance with BEP-7.	2020-02-26 20:42:14 +00:00
FranciscoPombal	9f045500d1	Fix IPv6 endianness	2020-02-26 20:42:07 +00:00
Vladimir Golovnev (Glassez)	e4ff206e3c	Move torrent storages one by one	2020-02-26 10:20:04 +03:00
Vladimir Golovnev (Glassez)	dd0cee44c1	Allow to save downloaded metadata as torrent file	2020-02-26 08:10:11 +03:00
FranciscoPombal	dc6a56afcb	Revert using random port by default ... Revert change introduced in https://github.com/qbittorrent/qBittorrent/pull/11637 and also revert the associated follow-up https://github.com/qbittorrent/qBittorrent/pull/12000. Reason: https://github.com/arvidn/libtorrent/pull/4335	2020-02-21 14:47:37 +00:00
Chocobo1	e825473289	Simplify TrackerEntry::status() logic	2020-02-17 18:46:30 +08:00
Mike Tzou	04132f6266	Merge pull request #11999 from an0n666/fix-not-contacted-tracker ... Do not list not contacted trackers as error	2020-02-16 20:27:41 +08:00
an0n666	8423f43209	Do not list not contacted trackers as error	2020-02-15 19:44:14 +00:00
Chocobo1	45c357dfe2	Include resume folder path in exception message ... The message in RuntimeError exception will be displayed to the users and users would be clueless if we don't show the path.	2020-02-15 02:48:55 +08:00
Tester798	58711cbe7e	Fix portable mode ... Try to fix portable mode bug. Closes #11706, #11178, #7765.	2020-02-12 19:56:25 +02:00
Chocobo1	5de75eff05	Unify singleton pattern in Profile class ... 1. Use unified function names `initInstance()` and `freeInstance()` and make them public. 2. Add `freeInstance()` to avoid noise from memory leak detectors. 3. Let `instance()`return a pointer directly to avoid unnecessary indirections when invoking functions.	2020-02-11 15:30:59 +08:00
NotTsunami	6748e8d787	Remove redundant null checks ... Attempting to delete a null pointer is a noop in C++. Closes #2864. [1] https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null	2020-02-03 16:38:51 -05:00
Mike Tzou	11bea8d393	Merge pull request #11918 from thalieht/peerssameip ... Show any multiple connections from the same IP in peer list	2020-01-30 12:59:17 +08:00
thalieht	5f415c292d	Show any multiple connections from the same IP in peer list ... The uniqueness of peers is now determined by their IP, port and connection type (uTP etc.) instead of just their IP	2020-01-29 20:40:10 +02:00
Chocobo1	5905c085c6	Use systematic approach to generate hash ... The basic idea is to hash each class member and then mix them with xor operation. However the `seed` must be handled with care, it should only be introduced once when mixing the hashes of each class member, otherwise under some circumstances the `seed` might xor with itself and thus break the intended effect.	2020-01-27 18:14:27 +08:00
Chocobo1	1740f968df	Revise qHash function ... Instead of xor and narrowing the integers ourselves, now we let qHash() from Qt do the job properly.	2020-01-27 12:53:22 +08:00
Chocobo1	2b4490d8a7	Use faster hash function ... qHash(QString) will need to hash/loop through all the data while the new code will only need one memcpy() and a few bit manipulations.	2020-01-27 12:53:13 +08:00
Vladimir Golovnev	89e72b38ea	Merge pull request #11881 from glassez/extension ... Simplify torrent startup handling	2020-01-22 06:11:33 +03:00
Vladimir Golovnev (Glassez)	f2285e1b63	Redesign torrent startup handling	2020-01-21 10:14:59 +03:00
Chocobo1	3fce1db2eb	Migrate away from deprecated settings ... Libtorrent has deprecated `upnp_ignore_nonrouters` in https://github.com/arvidn/libtorrent/pull/4251	2020-01-16 23:44:54 +08:00
Mike Tzou	146e8213a5	Merge pull request #11781 from FranciscoPombal/piece_extent_affinity ... Add piece_extent_affinity to AdvancedSettings	2020-01-14 12:53:39 +08:00
FranciscoPombal	ed96a07a75	Add piece_extent_affinity to AdvancedSettings ... Expose option in WebUI settings and WebAPI. Requires WebAPI version bump. Closes #11436.	2020-01-13 00:11:29 +00:00
An0n	bf32e90c40	Change placement of stop tracker timeout	2020-01-09 19:01:05 +00:00
Mike Tzou	057860584c	Merge pull request #11834 from an0n666/an0n666-expose-stop-tracker-timeout ... Expose stop tracker timeout in Advanced Settings (GUI + WebUI)	2020-01-08 17:30:21 +08:00
an0n666	3f223c3a45	Expose stop_tracker_timeout in advanced settings	2020-01-08 08:21:55 +00:00
sledgehammer999	02a027144b	Tracker is errored only if all local endpoints fail ... Closes #11691	2020-01-05 17:59:54 +02:00
Vladimir Golovnev (Glassez)	f56f817c77	Save resume data after recheck ... Closes #11774.	2020-01-01 14:29:58 +03:00
Mike Tzou	5c3c1e07df	Merge pull request #11739 from Chocobo1/qt5_14 ... Migrate away from deprecated API in Qt 5.14	2019-12-26 12:43:04 +08:00
Chocobo1	2422d81de1	Migrate away from deprecated API in Qt 5.14	2019-12-25 19:23:37 +08:00
FranciscoPombal	30502de960	Change some settings defaults for better behaviour out of the box ... - CheckingMemUsageSize (16 MiB -> 32 MiB): a 16 MiB increase in memory consumption seems worthwhile for a nice performance boost in most cases. - DiskCacheSize (64 MiB -> Auto): auto yields the best performance without committing to a huge fixed value. - UseRandomPort (false -> true): The initial port chosen by qBittorrent may clash with something else the user already has that is aways using that port (low probability, but still). Thus, qBittorrent will always fail listening on that port, causing unexpected problems for the user. Users who know they want a fixed port will go to the settings anyway.	2019-12-19 16:46:22 +00:00
sledgehammer999	18de63f743	Merge pull request #11433 from jagannatharjun/colors ... Allow transfer list text color changes through QSS	2019-12-19 18:20:49 +02:00
Prince Gupta	d3aa45526a	Allow transfer list text color changes through QSS	2019-12-19 12:45:26 +05:30
Mike Tzou	1e4c837d6c	Merge pull request #11678 from an0n666/patch-1 ... Disable Torrent Queue by default	2019-12-18 13:47:04 +08:00
sledgehammer999	3d43f1c800	Merge pull request #11642 from sledgehammer999/fix_save_path ... Use the incomplete folder where appropriate	2019-12-17 20:37:57 +02:00
an0n666	e0d7876990	Disable Torrent Queue by default ... It should remain disabled by default. Anyone that needs to Queue torrents for seeding/downloading should go to settings and change it to their preference.	2019-12-16 18:16:27 +06:00
sledgehammer999	564d845d87	Use the incomplete folder where appropriate ... Restored torrents already have the correct path saved in their fastresume. Don't override it. Magnets and new torrents have to be set explicitly to the incomplete folder if it is enabled. Closes #11552	2019-12-13 20:31:38 +02:00
sledgehammer999	d09c5e529c	Merge pull request #11592 from sledgehammer999/refactor_listeningAddr ... Rework the listening IP/interface selection code	2019-12-12 20:24:45 +02:00
Chocobo1	796595ffb6	Enable "Apply rate limit to peers on LAN" option by default ... Because some ISP will deploy Carrier Grade NAT (means assigning private IP address to user) and thus accidentally circumvent the speed limiter. https://www.a10networks.com/blog/carrier-grade-nat/	2019-12-11 21:44:45 +08:00
sledgehammer999	8200ef6bd5	Rework the listening IP/interface selection code ... Closes #11561	2019-12-11 09:56:45 +02:00
Mike Tzou	2e8b17e498	Merge pull request #11521 from Chocobo1/errorStatus ... Fix stuck in wrong torrent state	2019-12-03 19:22:39 +08:00
Chocobo1	bf58555a7a	Migrate away from deprecated API	2019-11-29 02:57:31 +08:00
sledgehammer999	56c0f39593	Merge pull request #11520 from sledgehammer999/revert_fastresume_functionality ... Revert fastresume functionality	2019-11-27 22:38:21 +02:00
Chocobo1	2ca70cf6cc	Fix stuck in wrong torrent state ... Before this patch, adding the torrent in https://github.com/qbittorrent/qBittorrent/issues/11511 and the torrrent state will stay in torrent_status::checking_resume_data forever. This is not the correct state since the `torrent_status.errc` field is non-zero and this commit fixes it.	2019-11-26 03:15:48 +08:00
sledgehammer999	7aa01a1b51	Revert "Always save info dict when saving fastresume" ... This reverts commit 4aab44e779.	2019-11-25 15:35:06 +02:00
sledgehammer999	005f0010ec	Revert "Fix unable to remove web seeds" ... This reverts commit d657c87243.	2019-11-25 15:34:37 +02:00
Vladimir Golovnev (Glassez)	a4b9a4d9da	Fix compilation for Windows 7 with MinGW	2019-11-22 13:03:52 +03:00
Chocobo1	af52a18f82	Avoid session reconfiguration when limit has not changed ... Fix up 5d46c9b2d6.	2019-11-20 12:22:18 +08:00
Mike Tzou	1bd739dd4a	Merge pull request #11493 from Chocobo1/speed ... Revise "speed limits" related code	2019-11-18 18:40:31 +08:00
thalieht	4ffc0cff12	Reallow to force recheck torrents that aren't fully started	2019-11-16 22:13:35 +02:00
Chocobo1	5d46c9b2d6	Revise "speed limits" related code ... The old code has a wrong comparison which compares speed limits in different magnitude: bytes vs KiB. The comparison is removed. Also the old code treats values that are smaller than 1024 as unlimited speed which is clearly wrong.	2019-11-17 02:27:59 +08:00
Chocobo1	640f52c05f	Let eta function return signed integer ... We already use signed integer internally so it make sense to return it as-is.	2019-11-14 12:14:29 +08:00
Chocobo1	9ef2cd48e0	Fix translation not applied	2019-11-11 16:39:55 +08:00
Mike Tzou	d12468ffb5	Merge pull request #11354 from thalieht/pausechecking ... Reallow to pause checking torrents	2019-11-09 09:28:18 +08:00
thalieht	f150b3077d	Reallow to pause checking torrents	2019-11-08 19:14:50 +02:00
Chocobo1	b408a09755	Remove unused type alias	2019-11-04 13:47:30 +08:00
Chocobo1	1b47350952	Remove anonymous function forward declarations ... Also reorder the functions slightly to make it compile.	2019-11-04 12:21:16 +08:00
Mike Tzou	2fb1182700	Merge pull request #11317 from Chocobo1/preview ... Fix "preview file" action not working	2019-11-04 11:32:14 +08:00
Mike Tzou	6da39d9279	Merge pull request #11422 from Chocobo1/buffer ... Reserve memory for file data buffers	2019-11-02 13:16:21 +08:00
Mike Tzou	565eb4cdc8	Merge pull request #11430 from Chocobo1/qt ... Fix integer narrowing on x86	2019-11-01 10:34:56 +08:00
Chocobo1	e262b86c44	Reserve memory for file data buffers	2019-10-31 23:09:28 +08:00
Chocobo1	6fd678195c	Replace deprecated Qt functions ... QSet::toList() is replaced by QSet::values()	2019-10-31 12:40:24 +08:00
Chocobo1	0f60121b94	Add option to control qBittorrent process memory priority ... This is to avoid Windows swapping out other application data from OS cache and put in torrent data which hinders other program responsiveness. The default value "Below normal" is choosen because casual users have other higher priority apps (such as browser) running and they don't expect OS to swap out its data. Dedicated seeders most probably will not have other app running on their system and would expect qbt has priority over other background services. The option only has effect on Windows >= 8.	2019-10-31 03:18:43 +08:00
Chocobo1	29fe0029f0	Rename variables in Session class	2019-10-30 11:56:16 +08:00