mirrors/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2024-11-27 03:39:39 +03:00
Code Issues Projects Releases Packages Wiki Activity

Avoid unnecessary memory writes

Browse source 
Before this change, qbt spent ~1% in these two functions, now it
only spends about ~0.5% in my naive testing.
This commit is contained in:
Chocobo1 2020-03-04 02:53:31 +08:00
parent b519ece18b
commit 24cd7c3611
No known key found for this signature in database
GPG key ID: 210D9C873253A68C
2 changed files with 8 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/base/bittorrent/peerinfo.cpp
View file

@ -208,11 +208,10 @@ qlonglong PeerInfo::totalDownload() const
QBitArray PeerInfo::pieces() const
{
QBitArray result(m_nativeInfo.pieces.size());
int i = 0;
for (const bool bit : m_nativeInfo.pieces)
result.setBit(i++, bit);
for (int i = 0; i < result.size(); ++i) {
if (m_nativeInfo.pieces[i])
result.setBit(i, true);
}
return result;
}

8
src/base/bittorrent/torrenthandle.cpp
View file

@ -1202,10 +1202,10 @@ QVector<PeerInfo> TorrentHandle::peers() const
QBitArray TorrentHandle::pieces() const
{
QBitArray result(m_nativeStatus.pieces.size());
for (int i = 0; i < m_nativeStatus.pieces.size(); ++i)
result.setBit(i, m_nativeStatus.pieces.get_bit(LTPieceIndex {i}));
for (int i = 0; i < result.size(); ++i) {
if (m_nativeStatus.pieces[LTPieceIndex {i}])
result.setBit(i, true);
}
return result;
}