mirrors/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2025-01-07 15:47:25 +03:00
Code Issues Projects Releases Packages Wiki Activity
8875 commits 16 branches 245 tags 255 MiB
Commit graph

7810 commits

Author SHA1 Message Date
Chocobo1
727800ef2c
Improve DownloadFromURL behavior 
URL should be considered case sensitive.
 2018-05-29 09:36:08 +08:00
Chocobo1
34ed0cba08
Move DownloadFromURLDialog to its own file 
Simplify code, no functionality changes.
Remove debug messages.
Capitalize dialog name.
Capitalize class name.
Update license text.
 2018-05-29 09:36:03 +08:00
Chocobo1
817b7bb4f2
Add missing header include 2018-05-29 02:07:55 +08:00
Mike Tzou
1d25d95740
Merge pull request #8953 from Chocobo1/constexpr 
Add constexpr to various classes
 2018-05-29 00:21:52 +08:00
Mike Tzou
4a51f14328
Merge pull request #8967 from Chocobo1/protect 
Add options to control WebUI security measures
 2018-05-28 14:21:53 +08:00
sledgehammer999
2ef7adec89
Sync translations from Transifex and run lupdate 2018-05-27 21:01:16 +03:00
sledgehammer999
6ad8d730cc
Bump Web API version 2018-05-27 19:23:25 +03:00
sledgehammer999
a1a6a7ef56
Merge pull request #8868 from Chocobo1/macos 
Fix GUI scaling factor on macOS
 2018-05-27 17:39:00 +03:00
Vladimir Golovnev (Glassez)
200f4d0f07
Don't use RSS feed URLs as base for file names 
RSS feed URLs can be too long and exceed max path limit.
Add RSS feed UIDs and use UIDs as base for file names instead of URLs.
Closes #8399.
 2018-05-26 10:37:32 +03:00
sledgehammer999
8a976d40be
Merge pull request #8979 from sledgehammer999/comp_dbus 
Fix compilation without D-Bus support
 2018-05-25 18:23:45 +03:00
Chocobo1
4751b79f42
Initialize variables properly 
The warnings are emitted when compiling on msys2, mingw

The warning was:
gui/torrentcontentmodel.cpp:135:33: warning: missing initializer for
member '_SHFILEINFOW::iIcon' [-Wmissing-field-initializers]

..\..\qBittorrent\src\app\stacktrace_win.h:141:30: warning: missing
initializer for member '_IMAGEHLP_LINE64::Key'
[-Wmissing-field-initializers]
 2018-05-25 21:22:31 +08:00
sledgehammer999
80e93e23f9
Fix compilation without D-Bus support 
Closes #8977
 2018-05-24 17:40:23 +03:00
sledgehammer999
7c6a5afbff
Merge pull request #8962 from sledgehammer999/suppress_errors 
Suppress multiple I/O errors for the same torrent
 2018-05-24 16:35:03 +03:00
Vladimir Golovnev
935bb5bd1c
Merge pull request #8966 from glassez/rss-date 
Use RSS feed update time as a fallback. Closes #8959
 2018-05-23 17:20:46 +03:00
Chocobo1
e099f6ad33
Add constexpr to IndexInterval class 
Add const to IndexRange private members.
Remove redundant inline specifier.
Add missing parentheses.
 2018-05-23 14:30:56 +08:00
Chocobo1
9631a9c2ad
Add constexpr to TriStateBool class 2018-05-23 14:30:56 +08:00
Chocobo1
b38925413d
Improve Utils::Version class 
Add operator>=() and operator<=().
More methods are suitable to be constexpr.
Remove redundant boundary checking.
 2018-05-23 13:47:41 +08:00
Mike Tzou
cd21071c69
Merge pull request #8954 from Chocobo1/firstlast 
Relax behavior of "Download first and last piece first"
 2018-05-23 13:26:02 +08:00
Mike Tzou
84df2794dc
Merge pull request #8944 from Chocobo1/literal 
Make use of QStringLiteral
 2018-05-23 13:23:41 +08:00
sledgehammer999
1bcbe65819
Merge pull request #8908 from adem4ik/master 
Update Windows icons
 2018-05-22 22:42:41 +03:00
sledgehammer999
b9546ccd4c
Suppress multiple I/O errors for the same torrent 
When a file error happens libtorrent spews a ton of `file_error_alert`
which result in log floods and notification balloon floods. The later
might render the program inaccessible because the constant
notifications prevent the user from interacting with the tray icon.

Closes #8934
 2018-05-22 21:29:50 +03:00
sledgehammer999
9df6ecafd0
Merge pull request #8961 from sledgehammer999/stats_dialog 
Fix Stats dialog size
 2018-05-22 20:24:50 +03:00
Chocobo1
9eeef0be97
Add option to control CSRF protection 
Some users are using WebUI with simple port-forwarding from their router,
providing an option to control the protection will save them from setting up an
non-trival web proxy.
Closes #7274.
 2018-05-22 12:57:03 +08:00
Vladimir Golovnev (Glassez)
4f8ed09183
Add missing 'return' statement 2018-05-21 21:24:02 +03:00
Chocobo1
bad4d94f77
Add option to control WebUI clickjacking protection 
Some users actually want embedding WebUI into their custom build iframe.
Closes #7370.
 2018-05-22 01:07:25 +08:00
Chocobo1
e8a69dd60c
Update Options dialog layout in WebUI 2018-05-21 23:57:11 +08:00
Vladimir Golovnev (Glassez)
9b80c4f7eb
Use RSS feed update time as a fallback 
Some sites omit publication date in its RSS feed articles
that prevents "Ignore Subsequent Matches" to work properly.
Closes #8959.
 2018-05-21 15:47:14 +03:00
Vladimir Golovnev
1b14706b08
Merge pull request #8955 from glassez/initial-rename 
Rename torrent if content was initially renamed. Closes #8910
 2018-05-21 08:04:43 +03:00
Vladimir Golovnev
0aee1cf7d0
Merge pull request #8945 from glassez/rss-rule 
Improve code of  RSS auto-downloading rule. Closes #8933
 2018-05-21 08:04:12 +03:00
Vladimir Golovnev
12e40ca865
Merge pull request #8948 from glassez/save-path 
Add last used save path to the front of history. Fixes #8922
 2018-05-21 08:03:29 +03:00
sledgehammer999
b4c1a949cc
Fix Stats dialog size 
Partially reverts e31ec20ec4.
Closes #8870.
 2018-05-20 23:35:20 +03:00
Vladimir Golovnev (Glassez)
a54f57611c
Rename torrent if content was initially renamed 
Closes #8910.
 2018-05-19 20:21:21 +03:00
Vladimir Golovnev (Glassez)
3be945a401
Add last used save path to the front of history 2018-05-19 19:43:01 +03:00
Chocobo1
95b19ec303
Relax behavior of "Download first and last piece first" 
Now it applies the setting to all files in torrent, no matter whether
the file is previewable or not.

Torrent client shouldn't be smart by deciding which file this
option will be applied to, i.e. it should just follow the user's decision.
 2018-05-19 21:48:13 +08:00
Chocobo1
da75a010c7
Refactor code 
Add const to variables.
Add Logger message.
Simplify code logic.
 2018-05-19 21:48:13 +08:00
Chocobo1
eb72b9ca7d
Simplify the saving & loading of a setting 
Remove excessive usage of constexpr.
 2018-05-19 20:56:43 +08:00
Vladimir Golovnev
c29e5c76dc
Merge pull request #8936 from surfernsk/master 
Fix open destination folder with Nautilus > 3.28. Closes #8923
 2018-05-19 15:06:03 +03:00
Vladimir Golovnev (Glassez)
53b9bcaaac
Place "Use Smart Episode Filter" more correctly 2018-05-19 14:52:38 +03:00
Vladimir Golovnev (Glassez)
844f76c2ca
Make "Ignoring days" to behave like other filters 
This prevents confusing in GUI when it shows matched RSS
articles which be really ignored by the rule.
 2018-05-19 14:52:24 +03:00
Evgeny Lensky
c7601d7a43 Fix open destination folder with Nautilus > 3.28 
Closes #8923.
 2018-05-19 18:45:26 +07:00
Mike Tzou
07c15127ba
Merge pull request #8915 from Chocobo1/runext4 
Improve "Run External Program" behavior
 2018-05-19 14:58:45 +08:00
Vladimir Golovnev (Glassez)
256f6954c5
Improve code of RSS auto-downloading rule 
Closes #8933.
 2018-05-18 13:26:04 +03:00
Chocobo1
ceaf755ac6
Make use of QStringLiteral 
Only changed instances that are initialized at program start.
 2018-05-18 02:14:49 +08:00
Vladimir Golovnev
e157ca2430
Merge pull request #8932 from glassez/rss-settings 
Properly set RSS settings via API. Closes #8925
 2018-05-17 06:07:25 +03:00
Chocobo1
fcbcf4039b
Use smaller type 2018-05-17 10:57:12 +08:00
Vladimir Golovnev (Glassez)
90f09e7570
Properly fill UploadedFile::filename field 
Closes #8928.
 2018-05-16 20:13:55 +03:00
Mike Tzou
7bfe08d466
Merge pull request #8926 from Chocobo1/lint 
Detect endianness at compile time
 2018-05-16 20:07:03 +08:00
Vladimir Golovnev
e2da7928b1
Merge pull request #8922 from glassez/save-path 
Add option to remember last used save path. Closes #7323
 2018-05-15 19:30:09 +03:00
Vladimir Golovnev (Glassez)
98ca274169
Rename RSS properties to follow other names 2018-05-15 16:05:51 +03:00
Chocobo1
0a49f76c0a
Detect endianness at compile time 2018-05-15 21:02:00 +08:00
Vladimir Golovnev (Glassez)
2a0b104e5e
Properly set RSS settings via API 
Closes #8925.
 2018-05-15 15:59:28 +03:00
Vladimir Golovnev (Glassez)
71e5a40857
Add option to remember last used save path 
Replace in "Add new torrent" dialog confusing "Set as default save path" option
with "Remember last used save path" option that affects only selected value in
"Save path" combo box.
Closes #7323.
 2018-05-15 10:38:24 +03:00
Mike Tzou
3b1fa19ea8
Merge pull request #8895 from Chocobo1/locale 
Apply locale changes immediately in WebUI
 2018-05-15 00:29:45 +08:00
Mike Tzou
a0f200be0d
Merge pull request #8894 from Chocobo1/tr 
Make strings translatable
 2018-05-14 12:53:40 +08:00
sledgehammer999
e3ce9b2645
Merge pull request #8903 from sledgehammer999/fix_upgrade_artifacts 
Delete non-commited fastresume files
 2018-05-13 17:24:47 +03:00
Vladimir Golovnev
7afbc346d5
Merge pull request #8906 from glassez/fix-webui 
Fix WebUI bugs
 2018-05-13 17:02:24 +03:00
sledgehammer999
35eee0b590
Don't migrate torrents that have newer fastresumes 2018-05-13 15:50:10 +03:00
sledgehammer999
7626ebe7a6
Delete non-commited fastresume files 
Old v3.3.x format had a number at the end indicating the queue position.
The naming scheme was '<infohash>.fastresume.<queueposition>'.
However, QSaveFile, which uses QTemporaryFile internally, might leave
non-commited files behind eg after a crash. These files have the
naming scheme '<infohash>.fastresume.XXXXXX' where each X is a random
character. We try to detect the latter and remove it without "migrating"
the fastresume to the new saving system.
 2018-05-13 15:50:10 +03:00
sledgehammer999
bde736c18a
Merge pull request #8900 from sledgehammer999/fix_delete_logs 
Fix deletion of old logs
 2018-05-13 15:00:39 +03:00
Chocobo1
61e61a1fd5
Rename variables 
Variable name should not start with underscore as C++ standard stated it
is reserved.
 2018-05-13 19:24:59 +08:00
Vladimir Golovnev
8906c47798
Merge pull request #8782 from mj-p/filterByHashes 
Filter torrent info endpoint by hashes
 2018-05-13 13:20:00 +03:00
sledgehammer999
8a99e29122
Merge pull request #8716 from sledgehammer999/move_progress 
Move and recheck progress
 2018-05-13 13:02:03 +03:00
sledgehammer999
375b15727d
Show rechecking progress 
When having big torrents, the rechecking might take a while to
complete. Users need some sort of feedback that progress is being made.
Also, I changed the float to qreal since that's the return type.
 2018-05-13 12:32:17 +03:00
sledgehammer999
7484889836
Fix deletion of old logs 2018-05-13 12:11:19 +03:00
Chocobo1
263524e856
Improve "Run External Program" behavior 
This follows utorrent behavior: they don't append backslash character at
the end of path variables.
Closes #8836.
 2018-05-13 15:21:27 +08:00
Chocobo1
5ae926a376
Refactor code 
Add const to variables.
No functionality change.
 2018-05-13 15:05:30 +08:00
Chocobo1
92a4e73a22
Apply locale changes immediately in WebUI 2018-05-13 15:05:29 +08:00
Mike Tzou
2230d96705
Merge pull request #8808 from Chocobo1/save 
Improve SettingsStorage behavior
 2018-05-13 14:24:14 +08:00
sledgehammer999
e5c73cee4a
Log successful torrent move 2018-05-12 20:49:33 +03:00
sledgehammer999
565ffa7d1e
Add 'Moving' state for torrents being relocated/moved 
This is another indication to the user that something is happening
behind the scenes.
Uses the same icon/color as "Checking" status.
Torrents in the `Moving` state are considered as "Active". This should
prevent accidental program exit from the user and inhibit system sleep.
 2018-05-12 20:49:33 +03:00
adem
b3f98fc975 Update Windows icons 2018-05-12 11:34:53 +04:00
Vladimir Golovnev (Glassez)
88f2a66aac
Fix params handling for some legacy API methods 
Closes #8880.
 2018-05-12 07:35:35 +03:00
Vladimir Golovnev (Glassez)
0fda49c060
Improve legacy API params handling 2018-05-12 07:35:31 +03:00
Vladimir Golovnev (Glassez)
afcf232bd8
Fix invalid API calls in WebUI 
Closes #8899.
 2018-05-12 07:35:27 +03:00
Vladimir Golovnev (Glassez)
32e2791f56
Fix compilation with MinGW 2018-05-12 06:24:05 +03:00
Chocobo1
b1304057ec
Fix i18n in WebUI 
Closes #8844.
 2018-05-11 20:20:51 +08:00
Chocobo1
c26ff40029
Make strings translatable 
Closes #8866.
 2018-05-11 19:29:02 +08:00
thalieht
4cfa163bbd Use qt5 syntax for a few remaining SLOT() 2018-05-11 08:19:41 +03:00
thalieht
20ca90800d Fix coding style 2018-05-09 17:06:22 +03:00
thalieht
586e1a0830 Move some connect() from propertieswidget to their corresponding widget 2018-05-09 16:08:22 +03:00
thalieht
6b4455e13d Use qt5 connect() syntax 2018-05-09 16:08:22 +03:00
Chocobo1
4d04af4043
Replace raster qbt logo with vector version 
Add helper function for svg icons.
 2018-05-09 16:33:17 +08:00
Chocobo1
f934042a98
Fix GUI scaling factor on macOS 
macOS seems have an unique way to handle widget size, that is, it doesn't require
application to resize widgets manually, Qt will handle the resize job
automatically.

Closes #8841.
 2018-05-09 16:33:14 +08:00
Chocobo1
0b63f35a54
Use 32px icons for favicon 
One less resource to manage and 16px size can be downsampled from 32px
on-the-fly anyway.
 2018-05-09 15:53:34 +08:00
Mike Tzou
7af83ab704
Merge pull request #8807 from Chocobo1/tracker_msg 
Fix displayed tracker message
 2018-05-09 14:38:17 +08:00
Mike Tzou
99a1343b9d
Merge pull request #8862 from Chocobo1/cleanup 
Code cleanups
 2018-05-09 14:33:49 +08:00
Vladimir Golovnev
eab5dad32d
Merge pull request #8860 from Kolcha/mac_warning 
Add missing "override"
 2018-05-08 17:14:21 +03:00
Vladimir Golovnev
3a0e5e51df
Merge pull request #8761 from thalieht/nullptr 
Replace the zeroing of pointers with nullptr
 2018-05-08 17:10:37 +03:00
Nick Korotysh
0b8c620fd3
Add missing "override" 2018-05-08 08:33:07 +03:00
Chocobo1
c0df292567
Remove debug messages 2018-05-08 12:18:18 +08:00
Chocobo1
defba23d61
Refactor code 
Remove forward declarations of Qt types.
Fix header include order.
 2018-05-08 12:18:18 +08:00
Vladimir Golovnev
48bdd5fa86
Merge pull request #8855 from glassez/fix-prio-api 
Fix wrong API method names. Closes #8828
 2018-05-08 07:07:31 +03:00
Vladimir Golovnev (Glassez)
85dd446198
Fix wrong API method names 
Closes #8828.
 2018-05-07 17:46:01 +03:00
Chocobo1
6d923f703a
Fix displayed tracker messages 
Before this change, we were displaying debug messages constructed by
libtorrent, now we show messages returned by trackers.

Closes #8739.
 2018-05-07 21:49:31 +08:00
Chocobo1
90f42e6737
Refactor functions 
Add const to variables
Remove debug messages
 2018-05-07 21:49:31 +08:00
Chocobo1
58861c35b0
Fix compile warnings on gcc 8 
The warning was:
warning: catching polymorphic type ‘class std::exception’ by value
[-Wcatch-value=]
 2018-05-07 21:39:54 +08:00
Chocobo1
203bafc4c3
Revert commit 
Apparently the translations were working in previous state, but affected by
lupdate issue:
https://github.com/qbittorrent/qBittorrent/issues/8220#issuecomment-385712673

The reverts commit fb698896c9.
Closes #8831.
 2018-05-05 21:46:36 +08:00
Chocobo1
9f809114f0
Really fix translation in fspathedit 
QT_TRANSLATE_NOOP3 is a macro, so we cannot use a runtime string for the context
argument.
Fix up 1d778676cd.
 2018-05-05 21:09:47 +08:00
Chocobo1
d20f40184f
Fix translation strings not found 
The translation context doesn't exist, so the translations were not found, fixed
now.
Closes #8829.
 2018-05-05 21:08:47 +08:00
Mike Tzou
d8c14ffe97
Merge pull request #8814 from Chocobo1/tr_fix 
Fix tr() related issues
 2018-05-05 13:48:09 +08:00
sledgehammer999
ea8c57be23
Sync translations from Transifex and run lupdate 2018-05-05 00:39:47 +03:00
sledgehammer999
90bb67c654
Add RSS/Log widgets to the QTabWidget on macOS 
Fixes commit a468c84b30
 2018-05-04 19:56:42 +03:00
Marcel Petersen
fc58e8a0c6 Filter torrent info endpoint by hashes 
Added hashes parameter to info action.
Allows filtering seralized torrents by passing it into the TorrentFilter.
 2018-05-02 10:07:48 +02:00
sledgehammer999
8f7fda492c
Sync translations from Transifex and run lupdate 
Closes #8220 #8169
 2018-05-01 18:50:24 +03:00
Chocobo1
e423314ac2
Work around false-positive warning from lupdate 
In short, lupdate will get confused when seeing `template <class T>`,
see: QTBUG-55478
 2018-05-01 23:28:34 +08:00
sledgehammer999
f92d85c536
Merge pull request #8813 from Chocobo1/tr 
Fix untranslated string
 2018-05-01 17:59:49 +03:00
Chocobo1
9fabe59b80
Fix usage of Q_DECLARE_TR_FUNCTIONS() 
The context parameter shouldn't be enclosed in double quotes.
 2018-05-01 22:42:55 +08:00
sledgehammer999
6e94b03c13
Fix compilation against libtorrent 1.0.x 
Closes #8798
 2018-05-01 10:39:53 +03:00
Chocobo1
c61f641613
Fix untranslated string 
Closes #8809.
 2018-05-01 11:49:10 +08:00
Chocobo1
f6d74e3996
Retry saving settings when operation failed 2018-04-30 13:01:10 +08:00
Chocobo1
099314d17f
Make settings file recovery more robust 
We should not blindly remove the leftover settings file, as the following write()
operation could fail and the user would lost all settings.
We should try renaming it instead.
 2018-04-30 13:01:10 +08:00
Chocobo1
708b5a6904
Refactor SettingsStorage class 
Make use of (i.e. returning) QFile::rename operation status
Make log message more verbose
Add const
Remove empty lines
Inline typedef
 2018-04-30 13:01:10 +08:00
sledgehammer999
fb346e15e8
Sync translations from Transifex and run lupdate 2018-04-27 02:04:37 +03:00
Chocobo1
8b575484e6
Fix path separator in log messages 2018-04-24 01:02:54 +08:00
sledgehammer999
b78899cb9a
Merge pull request #8724 from Chocobo1/rand 
Use RNG provided by OS
 2018-04-22 22:33:16 +03:00
Mike Tzou
0dec7b9f4f
Merge pull request #8742 from tostercx/master 
Add "Preserve file order" option to torrent creator. Closes #5652
 2018-04-22 23:33:25 +08:00
Chocobo1
81a4f3ced0
Use RNG provided by OS 
The general consensus is to use random facility provided by OS instead
of using other software random generators.
 2018-04-20 23:34:46 +08:00
Chocobo1
970ad7cf28 Sort filenames when creating torrent 
First all dir paths are retrieved, then filenames in each path
are retrieved and sorted, then concatenate the sorted filenames together.
 2018-04-20 14:35:48 +03:00
toster
c4625f50a8 Pass isAlignmentOptimized flag to piece size calculation 2018-04-20 14:31:20 +03:00
Vladimir Golovnev (Glassez)
001bd38557
Fix pauseAll/resumeAll legacy API methods 
Closes #8766.
 2018-04-20 14:30:25 +03:00
Chocobo1
68c2d81072
Fix memory leak 2018-04-17 20:34:01 +08:00
Chocobo1
4dea03fc74
Remove unused constants 2018-04-17 20:29:43 +08:00
thalieht
3e4099fe5b Replace the zeroing of pointers with nullptr 2018-04-15 13:06:31 +03:00
Mike Tzou
a70942ed53
Merge pull request #8598 from Piccirello/limit-share-ratio 
WebUI Add Limit Share Ratio context menu option
 2018-04-15 00:39:27 +08:00
toster
e538eae726 Make alignment optimization optional 
Disabling alignment optimization allows preserving file order in torrent
files and closes #5652
 2018-04-14 06:46:41 +03:00
Chocobo1
898239a42e
Fix renaming completed files 
Check whether the file is already downloaded before appending QB_EXT to
filename.

Closes #8039.
 2018-04-12 14:13:59 +08:00
Mike Tzou
1055cc0f45
Merge pull request #8691 from Chocobo1/js 
Partially revert "Remove unused JavaScript library"
 2018-04-12 00:07:37 +08:00
Thomas Piccirello
9f36b54b04
WebUI Add Limit Share Ratio context menu option 
Closes #6815, #7602.
 2018-04-11 23:45:54 +08:00
Thomas Piccirello
1f42ab8c4f
Remove unused/superfluous variables 2018-04-11 23:45:54 +08:00
Thomas Piccirello
3f0fbc0810
WebUI rename property to match its definition 2018-04-11 23:45:54 +08:00
sledgehammer999
7e4b62c68d
Merge pull request #8701 from Kolcha/musl-support 
Allow to disable Stacktrace support
 2018-04-11 17:10:01 +03:00
sledgehammer999
ddba79ef3d
Fix wrong QString::arg() usage that leads to crash 
We need to be careful when using the multi-arg version of
QString::arg() and passing as 2nd, 3rd etc parameter an int.
It doesn't do the same as passing multiple QStrings.
 2018-04-11 17:01:43 +03:00
Nick Korotysh
7712d0ada0
Allow to disable Stacktrace support 
Enable backtrace stuff only if GNU C library used, because current
backtrace implementation based  on  <execinfo.h> , which is not a
part of standard C library, it is a GNU extension.

This will be usefull when building  with  custom POSIX-compilant C
library (like musl) and no <execinfo.h> available.

Note: configure script will detect presence of  <execinfo.h>  and
enable/disable feature depending on it.

Feature is enabled by default.
 2018-04-10 20:51:11 +03:00
Mike Tzou
38837db8de
Merge pull request #8699 from Chocobo1/linking 
Add helper for loading Windows system functions
 2018-04-11 00:13:55 +08:00
sledgehammer999
d997d887e5
Merge pull request #8650 from luis-pereira/fix-invalid-iterator-crash 
Fix crashes due to invalid iterator use
 2018-04-10 16:18:44 +03:00
sledgehammer999
341a971cd3
Merge pull request #8711 from sledgehammer999/recheck_paused 
Avoid data corruption when rechecking paused torrents
 2018-04-10 16:18:12 +03:00
Mike Tzou
fa380c8b2c
Merge pull request #8622 from Chocobo1/formatter 
Unify coding style for WebUI files
 2018-04-10 14:51:32 +08:00
Luís Pereira
758c70283f
Fix crashes due to invalid iterator use 
Although the iterators are constant we are indirectly changing them.
Introduced by commit ac42ccb5e4.
Closes #8633
 2018-04-09 23:40:08 +03:00
sledgehammer999
747c70a58e
Avoid data corruption when rechecking paused torrents 
Libtorrent can recheck only unpaused torrents. We get around this by
unpausing the torrent, issuing the recheck and pausing again after we
get alerted by libtorrent that the recheck has finished. This alert is
asyncronous. There is a small time frame where the program might start
downloading and writing data to the file before we pause it. This can
lead to data corruption if the file on disk is totally different that
the one expected by the torrent AND the file on disk is a valid file on
its own. OR in case the user points the new torrent to the wrong
directory by mistake.
To get around this the torrent is placed in upload_mode and out of
automanagement.
 2018-04-09 23:25:52 +03:00
Vladimir Golovnev (Glassez)
cb505a07fe
Fix setting preferences via WebAPI 
Closes #7335.
 2018-04-09 18:54:43 +03:00
Chocobo1
5819b6dd39
Use Unicode version of InitiateSystemShutdown 2018-04-09 21:18:07 +08:00
Chocobo1
644e7d0450
Use dynamic linking for SetSuspendState function 2018-04-09 21:18:07 +08:00
Chocobo1
b0e3d77975
Add helper for loading Windows system functions 2018-04-09 21:18:04 +08:00
Chocobo1
643a209812
Sort include headers 
Also add anonymous namespace.
 2018-04-09 21:16:00 +08:00
Mike Tzou
c3311e83a0
Merge pull request #8687 from Chocobo1/folder 
Stop creating Download folder on start
 2018-04-09 13:20:48 +08:00
Chocobo1
cf2c0bd47e
Apply formatting to Web UI files 2018-04-07 21:45:56 +08:00
Chocobo1
59e6757242
Avoid showing an empty row in AdvancedSettings 
Fixup 543cbc6d1c.
 2018-04-05 21:34:07 +08:00
Chocobo1
6bbcf9b3d6
Stop creating Download folder on start 
The existence of this folder isn't required to run qbt and it can be
created when adding torrent.
Closes #8290.
 2018-04-05 14:12:47 +08:00
Chocobo1
208d21ff73
Add js-beautify config 
Try to standardize coding style for HTML & JavaScript via this tool
 2018-04-05 12:19:54 +08:00
Chocobo1
2df71dbde5
Partially revert "Remove unused JavaScript library" 
This reverts commit 470e993c2d.
 2018-04-05 03:22:34 +08:00
Mike Tzou
9e4f246c89
Merge pull request #8672 from Chocobo1/js 
Move JavaScript libraries to its own folder
 2018-04-04 19:23:10 +08:00
Mike Tzou
e4fc8e4156
Merge pull request #8669 from Chocobo1/runext 
Split args manually in runExternalProgram()
 2018-04-03 22:19:29 +08:00
Chocobo1
470e993c2d
Remove unused JavaScript library 2018-04-02 01:34:49 +08:00
Chocobo1
cbf10ebb7f
Update clipboard.js to v2.0.0 2018-04-02 01:34:49 +08:00
Chocobo1
89f06274bb
Move JavaScript libraries to its own folder 2018-04-02 01:34:43 +08:00
Chocobo1
c07cd440cd
Split args manually in runExternalProgram() 
Need to split arguments manually because QProcess::startDetached(QString)
will strip off empty parameters.
E.g. `python.exe "1" "" "3"` will become `python.exe "1" "3"`.
Closes #8454.
 2018-04-01 18:42:42 +08:00
Chocobo1
37ea01bd44
Use lightweight printf instead of iostream 
Using iostream usually adds a lot of other operators (<<, endl), whereas
*printf takes only 1 function call.

Also use qUtf8Printable whenever possible.
 2018-03-31 03:21:53 +08:00
Chocobo1
65921eaf7b
Remove QPointer wrapper 2018-03-25 15:53:31 +08:00
Chocobo1
bfbd978d3f
Move helper function to Utils::Fs 2018-03-25 13:26:03 +08:00
Chocobo1
1876dbd523
Fix typo 2018-03-25 13:26:02 +08:00
Chocobo1
ea7eb7c0ec
Add delay before processing FS changes 
This prevents file renaming errors in monitored folder on linux, for
example: ABC.torrent.part -> ABC.torrent
 2018-03-25 13:26:02 +08:00
Chocobo1
19c733ce95
Use specific name for rejected files 2018-03-25 13:26:02 +08:00
Chocobo1
2ba5dd1344
Reduce debug messages 2018-03-25 13:26:02 +08:00
Chocobo1
61eddfce90
Refactor functions in FileSystemWatcher 
Use c++11 range-loop
Add const
Better ifdef placement
Inline functions
 2018-03-25 13:26:02 +08:00
Chocobo1
0840556f77
Do cleanups in FileSystemWatcher 
Use Qt5 connect syntax
Sort headers
Add license
Add anonymous namespace
Replace macro defines with const variables
 2018-03-25 13:25:28 +08:00
Chocobo1
ed03456999
Update WebUI to be more compliant with HTML5 standard 
Use modern and shorter "charset" attribute.
Remove "type", "charset" attributes in script/style tags, these are redundant in HTML5.
 2018-03-23 00:04:43 +08:00
Thomas Piccirello
a15cfae03a Fix spacing 2018-03-21 00:04:21 -04:00
Thomas Piccirello
c2a195360a Resolve JavaScript errors 2018-03-21 00:04:21 -04:00
Thomas Piccirello
a4f99995bb Consolidate CSS into style.css 2018-03-21 00:04:18 -04:00
Thomas Piccirello
16616f4e0e Remove unused CSS from WebUI login page 2018-03-20 15:25:04 -04:00
Vladimir Golovnev
a5294e1e08
Merge pull request #8558 from luis-pereira/containter-anti-pattern 
Don't create temporary containers just to iterate over them
 2018-03-19 13:06:01 +03:00
Vladimir Golovnev
a8dbff06a3
Merge pull request #8607 from glassez/rss 
Process loaded RSS articles in case of parsing error
 2018-03-19 09:35:30 +03:00
Vladimir Golovnev (Glassez)
d9cd5d4680
Resolve (X)HTML entities in RSS content 
Many sites include various HTML entities in the content of RSS feeds.
The most of these entities are not declared in the underlying XML,
so the documents are considered by parser to be malformed.
This patch allows you to successfully parse such soft-malformed
RSS feeds.
Closes #8527.
Closes #8569.
 2018-03-18 18:59:55 +03:00
Luís Pereira
ac42ccb5e4
Don't create temporary containers just to iterate over them 
Stops temporary containers being created needlessly due to API misuse.
For example, it’s common for developers to assume QHash::values() and
QHash::keys() are free and abuse them, failing to realize their
implementation internally actually iterates the whole container, allocates
memory, and fills a new QList.

Added a removeIf generic algorithm, similar to std ones. We can't use std
algorithms with Qt dictionaries because Qt iterators have different
behavior from the std ones.

Found using clazy.
 2018-03-18 16:22:12 +03:00
Mike Tzou
68ca95faf0
Merge pull request #8603 from Chocobo1/typo 
Fix typo
 2018-03-17 00:49:41 +08:00
Vladimir Golovnev (Glassez)
8d285c66aa
Process loaded RSS articles in case of error 
For some reason, the RSS feed may contain malformed XML data and it may not be
successfully parsed by the XML parser. We are still trying to load as many articles
as possible until we encounter corrupted data. So we can have some articles even in
case of parsing error.
Closes #8527.
Closes #8569.
 2018-03-16 18:29:38 +03:00
Mike Tzou
1f28122428
Merge pull request #8595 from Chocobo1/runExt 
Add Tags parameter to "Run External Program"
 2018-03-16 19:37:34 +08:00
Mike Tzou
6ec179e0f7
Merge pull request #8594 from Chocobo1/ui 
Properly align text label
 2018-03-15 13:41:23 +08:00
Chocobo1
423511765a
Fix typo 2018-03-14 23:37:08 +08:00
Thomas Piccirello
4863078744 Use correct API method URL in WebUI 
Fix up 27d8dbf.
Closes #8596.
 2018-03-14 03:08:46 -04:00
Chocobo1
88881de8c6
Add Tags parameter to "Run External Program" 
Closes #8586.
Also sort headers.
 2018-03-14 10:12:32 +08:00
Chocobo1
690c439ae6
Properly align text label 2018-03-14 00:35:20 +08:00
Mike Tzou
e78b5202bc
Merge pull request #8585 from Chocobo1/lint 
Fix compiler/clazy warnings
 2018-03-13 22:36:10 +08:00
Vladimir Golovnev
c9be1d0a19
Merge pull request #8494 from paolo-sz/master 
Fix for "Content" panel messed up
 2018-03-13 16:54:05 +03:00
Vladimir Golovnev
3348eef423
Merge pull request #8488 from thalieht/fix 
Move suffix-labels inside the corresponding spinboxes
 2018-03-12 16:58:05 +03:00
Vladimir Golovnev
931af6c97e
Merge pull request #8313 from Piccirello/search-categories 
Calculate search categories based on selected plugin
 2018-03-12 14:29:51 +03:00
Vladimir Golovnev
cea2948593
Merge pull request #8556 from Piccirello/compiler-warnings 
Fix missing initializer warning during build
 2018-03-12 14:28:38 +03:00
Chocobo1
a468c84b30
Fix warnings from unused variables 2018-03-12 14:36:28 +08:00
Thomas Piccirello
7278625f53 Calculate supported categories based on selected plugin 2018-03-12 01:33:45 -04:00
Thomas Piccirello
7b3e692f68 Fix missing initializer warning 
This issue occurs when using gcc versions < 5.
 2018-03-12 01:21:21 -04:00
Chocobo1
fdb0d97b28
Remove unused function 2018-03-11 23:27:04 +08:00
Chocobo1
08a2439f46
Check directly if container is empty or not 2018-03-11 23:12:16 +08:00
Chocobo1
6767487e40
Remove unused variable 2018-03-11 22:31:17 +08:00
Chocobo1
141a2d2856
Prevent detach from containers 2018-03-11 22:25:07 +08:00
thalieht
2eea57e609 Use spinbox suffix to display time unit 2018-03-11 12:08:00 +02:00
thalieht
0b185e347b Use spinbox suffix to display rate unit 2018-03-11 12:07:38 +02:00
thalieht
1e1db31ab5 Use unique layout names 2018-03-11 12:07:24 +02:00
Mike Tzou
7233274110
Merge pull request #8562 from Chocobo1/lint 
Fix warnings from clazy
 2018-03-11 12:41:58 +08:00
paolo-sz
d4e2b21534 Fix Content widget misbehavior 
Starting from QT 5.10.1 Content widget is messed up and its settings are
lost while restarting.
Setting StretchLastSection property to false seems to solve the issue.
(Closes #8439).
 2018-03-10 18:56:18 +01:00
Vladimir Golovnev
4f206f987a
Merge pull request #8561 from glassez/tracker 
Properly reply to announce request
 2018-03-10 17:08:29 +03:00
Vladimir Golovnev (Glassez)
dfddda57b9
Properly reply to announce request 2018-03-09 17:41:06 +03:00
Mike Tzou
0cacd71503
Merge pull request #8403 from Piccirello/webui-download-height 
Make WebUI iframe windows scrollable on iOS. Closes #8401, #7932.
 2018-03-09 19:46:29 +08:00
Chocobo1
fdf3ebbb6c
Remove usage of deprecated functions 
Also use proper type for storing date/time data
 2018-03-09 19:20:58 +08:00
Chocobo1
a3d9e457a0
Add context parameter in connect() 2018-03-09 13:44:17 +08:00
Chocobo1
ffb5c0635e
Remove unused slot declaration for function 2018-03-09 01:50:23 +08:00
Chocobo1
b4f23d8154
Use faster code path 
From Qt doc: Using this function is faster than using QFileInfo(file).exists() for
file system access.
 2018-03-09 01:34:35 +08:00
Chocobo1
ed310c2dac
Avoid temporary QString allocations 
Fix up 0457fd260e
 2018-03-09 01:34:35 +08:00
Chocobo1
50167d40d7
Allow ADL lookup for helper function 2018-03-09 01:34:19 +08:00
Mike Tzou
5261d4375f
Merge pull request #8551 from Chocobo1/override 
Fix warnings from linters
 2018-03-09 00:36:52 +08:00
Thomas Piccirello
0b56cd5fa0 Make WebUI iframe windows scrollable on iOS 
Closes #8401, #7932.
 2018-03-08 01:30:13 -05:00
Vladimir Golovnev
e22946ef61
Merge pull request #8525 from glassez/url-query 
Parse URL query string at application level
 2018-03-07 17:16:21 +03:00
Chocobo1
0457fd260e
Avoid temporary QString allocations 
This fixes clazy warning: Use multi-arg instead [-Wclazy-qstring-arg]
 2018-03-07 20:06:00 +08:00
Chocobo1
c60b7b213e
Add missing 'override' specifier 
This fixes clang warning:
'notify' overrides a member function but is not marked 'override'
[-Winconsistent-missing-override]
 2018-03-07 20:05:52 +08:00
Chocobo1
307736e263
Fix broken WebUI 
Fix up c47e4efade.
Closes #8545.
 2018-03-06 14:03:01 +08:00
Mike Tzou
7aa5bc4bc1
Merge pull request #8484 from Piccirello/improve-webui-stats 
Improve WebUI stats dialog (addendum to #8349)
 2018-03-06 00:49:49 +08:00
Thomas Piccirello
c47e4efade Save WebUI Statistics window size 2018-03-05 01:40:21 -05:00
Vladimir Golovnev (Glassez)
1aca3b0adc
Parse URL query string at application level 2018-03-04 17:08:48 +03:00
Chocobo1
20c4b0ee0c
Use original scheme when downloading favicons 
Previously was always using http, now we only drop back to http when
scheme is absent
 2018-03-03 12:53:27 +08:00
Chocobo1
3df4a7ac2e
Use https for documentation links 2018-03-03 12:43:59 +08:00
Vladimir Golovnev (Glassez)
34295a78f2
Move ByteArray utils into Utils::ByteArray namespace 2018-03-02 17:23:21 +03:00
Mike Tzou
57163612ff
Merge pull request #8427 from Chocobo1/server2 
Rewrite RequestParser
 2018-03-02 16:07:12 +08:00
Tom Piccirello
1a9b009951 Enable Statistics window to be scrolled and resized 
Text may go offscreen due to translations.
 2018-03-02 02:18:42 -05:00
Vladimir Golovnev
9406b4b226
Merge pull request #8515 from glassez/webapi 
Fix Legacy Web API to be fully available
 2018-03-01 09:44:06 +03:00
Mike Tzou
38dc6ab8cf
Merge pull request #8441 from Chocobo1/runExt 
Revert back to QLineEdit for "Run external program". Closes #7800.
 2018-03-01 13:23:42 +08:00
Mike Tzou
55c3db339b
Merge pull request #8455 from Chocobo1/large_torrent 
Fix loading very large torrents. Closes #8449
 2018-03-01 13:22:43 +08:00
Vladimir Golovnev (Glassez)
34456a7459
Fix Legacy Web API to be fully available 2018-02-28 18:25:48 +03:00
Vladimir Golovnev
b26eb3d146
Merge pull request #8373 from glassez/search 
Improve Search handling
 2018-02-28 10:46:33 +03:00
Vladimir Golovnev
7cb6100c9c
Merge pull request #8471 from luis-pereira/use-qstring-ref 
Don't create temporary substrings
 2018-02-28 10:44:59 +03:00
sledgehammer999
1c2d9c1fe4
Merge pull request #8510 from adem4ik/patch-2 
Fix typo in filelogger.cpp message
 2018-02-27 17:38:52 +02:00
Mike Tzou
6f7f7d87c6
Merge pull request #8218 from Piccirello/webui-selection-bug 
Reselect webui torrents after full_update. Temporary fix for #8209.
 2018-02-27 13:33:39 +08:00
Andrei Stepanov
817aadd52d
Fix typo in filelogger.cpp message 2018-02-27 02:00:43 +04:00
Luís Pereira
0e421ae415 Don't create temporary substrings 
Avoid temporary string allocations. They are only used to convert to
something else.
QString::xxxRef() returns a QStringRef. QStringRef avoids the memory
allocation and reference counting overhead of a standard QString by simply
referencing a part of the original string.
 2018-02-26 11:39:36 +00:00
Thomas Piccirello
2227c3afc1 Reselect torrents in WebUI after full update 
Temp fix for #8209.
 2018-02-25 01:09:06 -05:00
Mike Tzou
050af8a793
Merge pull request #7894 from Piccirello/auto-management 
Disable options when Force Proxy is enabled
 2018-02-25 01:44:58 +08:00
Vladimir Golovnev
6207855f3b
Merge pull request #8372 from thalieht/inactiverate 
Expose the libtorrent fields for "dont_count_slow_torrents" to GUI.
Closes #5713.
 2018-02-24 14:13:39 +03:00
Vladimir Golovnev
a65a70ab48
Merge pull request #8479 from thalieht/ratioLimitsCrash 
Fix possible crash when using both share limits
 2018-02-24 14:11:09 +03:00
Thomas Piccirello
4110bb874f Right align stat values 2018-02-23 14:54:31 -05:00
Thomas Piccirello
5c74f374af Re-order and rename stats 2018-02-23 14:54:24 -05:00
Thomas Piccirello
a8420a43f9 Format Read cache hits as percentage 2018-02-23 14:46:47 -05:00
Vladimir Golovnev (Glassez)
279bce2014
Make SearchManager singleton 2018-02-23 20:26:32 +03:00
Vladimir Golovnev (Glassez)
f3d370870d
Improve Search handling 
Legacy SearchEngine class really has three roles:
  1. Manage search plugins,
  2. Handle the search job, and
  3. Handle the download of the torrent file using the search plugin.
Now it is splitted into 3 classes: SearchManager, SearchHandler and
SearchDownloadHandler.
Search GUI is also improved.
 2018-02-23 20:15:25 +03:00
thalieht
0e30659c26 Fix possible crash when using both share limits 
Avoid possible crash in "torrent->name()" when processing seeding time of the torrent that already reached the ratio limit.
 2018-02-23 17:13:56 +02:00
Chocobo1
f34dfca5e6
Enable Http/1.1 persistence connection 
This enables reusing existing TCP connection instead of opening a new connection
for every request
 2018-02-23 14:46:22 +08:00
Chocobo1
cec68c3fd7
Rewrite RequestParser 
* Add more checks and also more strict checks for invalid conditions
* Add http version field
* Raise max request size to 64 MB
* Add author in license
* Use Qt5 new connect syntax
 2018-02-23 14:46:17 +08:00
Vladimir Golovnev
5c2f698cb4
Merge pull request #8325 from luis-pereira/prevent-c++11-range-loop-detach 
Prevent possible c++11 range-loop container detach
 2018-02-22 16:28:04 +03:00
Chocobo1
f5fc2d52b8
Fix loading very large torrents. Closes #8449. 
`torrent_info` constructor has default limits that can't be changed via
parameters, so we handle the loading process manually and explicitly
specifiy the limits to `bdecode()`.
The token_limit is also changed to 10000000.
 2018-02-22 18:52:10 +08:00
Mike Tzou
edef85fa3e
Merge pull request #8456 from vit9696/patch-1 
Fix compilation with Qt 5.11 on macOS
 2018-02-21 23:00:55 +08:00
Mike Tzou
6244ad5fa8
Merge pull request #8458 from luis-pereira/qgetenv 
Use qEnvironmentVariableIsEmpty
 2018-02-21 23:00:30 +08:00
Chocobo1
aba23f67a0
Revert back to QLineEdit for "Run external program". Closes #7800 
1. Using FileSystemPathEdit is not entirely correct, as it only always
shows false warnings when parameters are present.
2. FileSystemPathEdit::selectedPath() modifies the path to unix format,
in this specific case, we need to faithfully execute what user inputted.
3. Given the above it is reasonable to revert back to QLineEdit, as it
is just sufficient in functionality and doesn't modifiy the inputs.
 2018-02-21 10:16:32 +08:00
Luís Pereira
1a913c502b Prevent possible c++11 range-loop container detach 
Explicit or implicit calls to begin() and end() cause a non-const
container to detach from shared data, ie. to perform a deep-copy to gain
a unique copy of the data.
That can be a expensive although unneeded operation.

In order to assist the developer a copyAsConst function is added.
copyAsConst returns a const copy of the object.

For lvalues just use qAsConst. It's only available on Qt 5.7.0. But we
added also for earlier versions. The developer can always use qAsConst.

Intended uses:

    QString s = ...;
    for (const auto &ch : qAsConst(s))
          process(ch);

    for (const auto &ch : copyAsConst(funcReturningQString()))
        process(ch);
 2018-02-20 19:28:51 +00:00