mirrors/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2025-01-07 15:47:25 +03:00
Code Issues Projects Releases Packages Wiki Activity
8875 commits 16 branches 245 tags 255 MiB
Commit graph

7810 commits

Author SHA1 Message Date
Chocobo1
51e82762c5
Move related functions to Utils::Python 2018-06-24 06:21:15 +08:00
Goshik
1daadfc4ec Create non-existing path in setLocationAction() 
When using qbittorrent-nox it is not always possible to manually create
the target path for torrent moving. This commit allows automatic path
creation. It also allows to display error messages in the
'Set location' window.
 2018-06-19 14:10:11 +03:00
Mike Tzou
8f6e066332
Merge pull request #9092 from hannsen/patch-1 
PEP 8 compliant version comments in search plugins
 2018-06-18 00:56:28 +08:00
Mike Tzou
40f4223d02
Merge pull request #9083 from Chocobo1/qrc 
Move files to where it belongs
 2018-06-18 00:51:19 +08:00
Vladimir Golovnev
7d9cc04c88
Merge pull request #9090 from thalieht/renamefiles 
Rename files and classes to match them
 2018-06-16 13:08:38 +03:00
Mike Tzou
dc20fff6e4
Merge pull request #9059 from Piccirello/meta-key 
Add WebUI support for Mac ⌘ (Command) key
 2018-06-16 12:21:20 +08:00
thalieht
d34ddb2e3c Change file names and classes names to match them 2018-06-15 20:12:59 +03:00
hannsen
a162550d7f
Properly normalize version string before parsing it 
This allows python scripts to be formatted in PEP 8 style.
 2018-06-14 13:00:31 +08:00
Vladimir Golovnev
0433d5f074
Merge pull request #9042 from thalieht/codingstyle 
Fix coding style final
 2018-06-13 12:41:56 +03:00
Mike Tzou
fd2fc65ba9
Merge pull request #9018 from Chocobo1/boostDef 
Revise usage of BOOST_NO_CXX11_RVALUE_REFERENCES
 2018-06-13 14:20:01 +08:00
Chocobo1
8be949fec3
Revise usage of BOOST_NO_CXX11_RVALUE_REFERENCES 
Now the flag will be present when building with boost version <= 1.59.
Closes #8990.
 2018-06-13 13:51:58 +08:00
Thomas Piccirello
232f0f4b0b Add WebUI support for Mac ⌘ (Command) key 
The Command key will now be recognized for WebUI Table multi-selection, as Ctrl is.
 2018-06-12 20:32:24 -04:00
Thomas Piccirello
091ad6103e Implement key functions in Class and refactor 2018-06-12 20:32:07 -04:00
Mike Tzou
c66738dc05
Merge pull request #9066 from AltruisticCompany/setlocation 
Show current save path in 'Set location' window
 2018-06-13 02:46:56 +08:00
Mike Tzou
4100282673
Merge pull request #9073 from Chocobo1/apple 
Replace deprecated function on macOS
 2018-06-12 12:19:54 +08:00
thalieht
4022799881 Fix coding style 2018-06-12 07:17:05 +03:00
Chocobo1
5b7c089dd2
Move qm_gen.pri 2018-06-11 21:02:45 +08:00
Chocobo1
5d94db9c79
Move .desktop file 2018-06-11 20:01:33 +08:00
Chocobo1
6203f23f06
Move .ico files into icons dir 2018-06-11 20:01:33 +08:00
Chocobo1
26a4703398
Move .qrc files into its own directory 2018-06-11 20:01:33 +08:00
Mike Tzou
c8c7ed4a2e
Merge pull request #9053 from Chocobo1/optionWheel 
Disable certain mouse wheel events in Options dialog
 2018-06-10 13:06:04 +08:00
Chocobo1
0073f2c8ab
Replace deprecated function on macOS 
Closes #8993.
 2018-06-09 13:49:20 +08:00
Mike Tzou
da87c2d9ae
Merge pull request #9060 from Chocobo1/preinc 
Replace post-increment with pre-increment
 2018-06-09 12:40:30 +08:00
Goshik
682ef9e2a8 Show current save path in 'Set location' window 
The feature is useful when the user needs to move their torrent to a
sub or parent folder. If more than one torrent is chosen, the path
of the first selected torrent is used. The window was made wider to
allow more convenient editing of long paths.
 2018-06-08 18:34:14 +03:00
Chocobo1
5ddbf9bba9
Replace post-increment with pre-increment 
And post-decrement with pre-decrement.
 2018-06-08 08:44:06 +08:00
Eugene Shalygin
04aea413ba
Merge pull request #9055 from zeule/cmake 
Update CMake build scripts
 2018-06-07 21:31:09 +02:00
Chocobo1
96819f3798
Disable certain mouse wheel events in Options dialog 
The mouse wheel events for QComboBox & QSpinBox widgets in Options
dialog are filtered out.
 2018-06-06 15:17:49 +08:00
Eugene Shalygin
fa770871e9 Refactor CMake build scripts 
1. Use FeatureSummary module to show configuration results.

2. Invert option()/find_package() relationship: instead of
calling find_package(... REQUIRED) when option is set, rely on optional
find package call and PackageName_FOUND variable.

3. Refactor handling options that result in simple preprocessor defines
(actually copy the snippet from libtorrent) so that everything is done
in a single function call.

4. Populate target properties in order to get rid of
include_directories() calls.
 2018-06-05 11:39:11 +02:00
Chocobo1
0b050e2a30
Remove duplicate private sections in class 
And group related methods & variables together.
 2018-06-05 12:22:32 +08:00
Mike Tzou
40330c4606
Merge pull request #9027 from Chocobo1/cache 
Send Cache-Control header in WebUI responses
 2018-06-05 01:04:42 +08:00
Mike Tzou
731865427e
Merge pull request #9008 from Chocobo1/changelog 
Add changelog URL link in updater
 2018-06-04 20:51:18 +08:00
Chocobo1
eaa276b284
Fix WebUI cache behavior for css files 
The style.css in public & private folders share the same URI, this
confuses the browser cache, so rename one of them.
 2018-06-04 20:50:09 +08:00
Chocobo1
050b78f378
Send Cache-Control header in WebUI responses 
Tune the caching time to be shorter, in case there is a program
update.
Change the cacheability to private, as WebUI resources are not intended
to be cached at proxy.
For uncacheable responses, send out "no-store" explicitly to halt
browser caching.
 2018-06-04 20:50:08 +08:00
Mike Tzou
5f8feec1c1
Merge pull request #9013 from Piccirello/strengthen-csp 
More restrictive Content Security Policy
 2018-06-03 21:43:39 +08:00
Vladimir Golovnev
e61c882fee
Merge pull request #9015 from thalieht/style 
Fix coding style
 2018-06-03 14:48:04 +03:00
Mike Tzou
c4e4e7432d
Merge pull request #9009 from Chocobo1/login 
Add logging messages in WebUI login action
 2018-06-03 19:47:05 +08:00
thalieht
356d6a6589 Fix coding style 2018-05-31 19:45:09 +03:00
Chocobo1
09f759355f
Replace QRegExp with QRegularExpression 
Revise `static` keyword usage, static is added to frequently used
instances.
 2018-05-31 22:56:49 +08:00
Chocobo1
c22e6b4502
Cleanup header include order 
Add missing header.
Cleanup license.
 2018-05-31 22:56:25 +08:00
Chocobo1
5c72a52ea2
Reset WebUI ban counter on login success 2018-05-31 22:55:54 +08:00
Chocobo1
d782d62b34
Add logging messages in WebUI login action 2018-05-31 22:55:54 +08:00
Thomas Piccirello
9b874b8941 Rename variables for clarity 2018-05-31 00:54:57 -04:00
Thomas Piccirello
43656aaa1e Add form-action to CSP 
This option restricts all form submissions to the WebUI's origin.
qBittorrent only ever submits forms to the origin, so this is intended as a security measure.
 2018-05-31 00:54:57 -04:00
Thomas Piccirello
8f98f87d12 Add upgrade-insecure-requests to CSP when HTTPS is enabled 
This option automatically upgrades all http connections to https.
It ensures http urls cannot be accessed when in https mode, and is intended as a security measure.
 2018-05-31 00:54:57 -04:00
Mike Tzou
6e96bbb2e9
Merge pull request #9001 from Chocobo1/csp 
Improve WebUI security measures
 2018-05-31 00:34:21 +08:00
Mike Tzou
93d4f2d595
Merge pull request #8984 from Chocobo1/magnetDialog 
Refactor DownloadFromURLDialog
 2018-05-30 13:55:42 +08:00
Chocobo1
68c6ddf05d
Add changelog link in program updater 
Closes #8997.
 2018-05-30 13:54:15 +08:00
Vladimir Golovnev
15153a4446
Merge pull request #8976 from glassez/feed-uid 
Don't use RSS feed URLs as base for file names. Closes #8399
 2018-05-29 14:30:23 +03:00
Chocobo1
e8d378e167
Improve WebUI security measures 
CSP was erroneously disabled in bad4d94f77
when clickjacking protection is off, now it is back.
Also added CSP 'frame-ancestors' directive when clickjacking
protection is enabled.
 2018-05-29 13:40:52 +08:00
Chocobo1
ee202b721d
Refactor function 2018-05-29 09:36:08 +08:00
Chocobo1
727800ef2c
Improve DownloadFromURL behavior 
URL should be considered case sensitive.
 2018-05-29 09:36:08 +08:00
Chocobo1
34ed0cba08
Move DownloadFromURLDialog to its own file 
Simplify code, no functionality changes.
Remove debug messages.
Capitalize dialog name.
Capitalize class name.
Update license text.
 2018-05-29 09:36:03 +08:00
Chocobo1
817b7bb4f2
Add missing header include 2018-05-29 02:07:55 +08:00
Mike Tzou
1d25d95740
Merge pull request #8953 from Chocobo1/constexpr 
Add constexpr to various classes
 2018-05-29 00:21:52 +08:00
Mike Tzou
4a51f14328
Merge pull request #8967 from Chocobo1/protect 
Add options to control WebUI security measures
 2018-05-28 14:21:53 +08:00
sledgehammer999
2ef7adec89
Sync translations from Transifex and run lupdate 2018-05-27 21:01:16 +03:00
sledgehammer999
6ad8d730cc
Bump Web API version 2018-05-27 19:23:25 +03:00
sledgehammer999
a1a6a7ef56
Merge pull request #8868 from Chocobo1/macos 
Fix GUI scaling factor on macOS
 2018-05-27 17:39:00 +03:00
Vladimir Golovnev (Glassez)
200f4d0f07
Don't use RSS feed URLs as base for file names 
RSS feed URLs can be too long and exceed max path limit.
Add RSS feed UIDs and use UIDs as base for file names instead of URLs.
Closes #8399.
 2018-05-26 10:37:32 +03:00
sledgehammer999
8a976d40be
Merge pull request #8979 from sledgehammer999/comp_dbus 
Fix compilation without D-Bus support
 2018-05-25 18:23:45 +03:00
Chocobo1
4751b79f42
Initialize variables properly 
The warnings are emitted when compiling on msys2, mingw

The warning was:
gui/torrentcontentmodel.cpp:135:33: warning: missing initializer for
member '_SHFILEINFOW::iIcon' [-Wmissing-field-initializers]

..\..\qBittorrent\src\app\stacktrace_win.h:141:30: warning: missing
initializer for member '_IMAGEHLP_LINE64::Key'
[-Wmissing-field-initializers]
 2018-05-25 21:22:31 +08:00
sledgehammer999
80e93e23f9
Fix compilation without D-Bus support 
Closes #8977
 2018-05-24 17:40:23 +03:00
sledgehammer999
7c6a5afbff
Merge pull request #8962 from sledgehammer999/suppress_errors 
Suppress multiple I/O errors for the same torrent
 2018-05-24 16:35:03 +03:00
Vladimir Golovnev
935bb5bd1c
Merge pull request #8966 from glassez/rss-date 
Use RSS feed update time as a fallback. Closes #8959
 2018-05-23 17:20:46 +03:00
Chocobo1
e099f6ad33
Add constexpr to IndexInterval class 
Add const to IndexRange private members.
Remove redundant inline specifier.
Add missing parentheses.
 2018-05-23 14:30:56 +08:00
Chocobo1
9631a9c2ad
Add constexpr to TriStateBool class 2018-05-23 14:30:56 +08:00
Chocobo1
b38925413d
Improve Utils::Version class 
Add operator>=() and operator<=().
More methods are suitable to be constexpr.
Remove redundant boundary checking.
 2018-05-23 13:47:41 +08:00
Mike Tzou
cd21071c69
Merge pull request #8954 from Chocobo1/firstlast 
Relax behavior of "Download first and last piece first"
 2018-05-23 13:26:02 +08:00
Mike Tzou
84df2794dc
Merge pull request #8944 from Chocobo1/literal 
Make use of QStringLiteral
 2018-05-23 13:23:41 +08:00
sledgehammer999
1bcbe65819
Merge pull request #8908 from adem4ik/master 
Update Windows icons
 2018-05-22 22:42:41 +03:00
sledgehammer999
b9546ccd4c
Suppress multiple I/O errors for the same torrent 
When a file error happens libtorrent spews a ton of `file_error_alert`
which result in log floods and notification balloon floods. The later
might render the program inaccessible because the constant
notifications prevent the user from interacting with the tray icon.

Closes #8934
 2018-05-22 21:29:50 +03:00
sledgehammer999
9df6ecafd0
Merge pull request #8961 from sledgehammer999/stats_dialog 
Fix Stats dialog size
 2018-05-22 20:24:50 +03:00
Chocobo1
9eeef0be97
Add option to control CSRF protection 
Some users are using WebUI with simple port-forwarding from their router,
providing an option to control the protection will save them from setting up an
non-trival web proxy.
Closes #7274.
 2018-05-22 12:57:03 +08:00
Vladimir Golovnev (Glassez)
4f8ed09183
Add missing 'return' statement 2018-05-21 21:24:02 +03:00
Chocobo1
bad4d94f77
Add option to control WebUI clickjacking protection 
Some users actually want embedding WebUI into their custom build iframe.
Closes #7370.
 2018-05-22 01:07:25 +08:00
Chocobo1
e8a69dd60c
Update Options dialog layout in WebUI 2018-05-21 23:57:11 +08:00
Vladimir Golovnev (Glassez)
9b80c4f7eb
Use RSS feed update time as a fallback 
Some sites omit publication date in its RSS feed articles
that prevents "Ignore Subsequent Matches" to work properly.
Closes #8959.
 2018-05-21 15:47:14 +03:00
Vladimir Golovnev
1b14706b08
Merge pull request #8955 from glassez/initial-rename 
Rename torrent if content was initially renamed. Closes #8910
 2018-05-21 08:04:43 +03:00
Vladimir Golovnev
0aee1cf7d0
Merge pull request #8945 from glassez/rss-rule 
Improve code of  RSS auto-downloading rule. Closes #8933
 2018-05-21 08:04:12 +03:00
Vladimir Golovnev
12e40ca865
Merge pull request #8948 from glassez/save-path 
Add last used save path to the front of history. Fixes #8922
 2018-05-21 08:03:29 +03:00
sledgehammer999
b4c1a949cc
Fix Stats dialog size 
Partially reverts e31ec20ec4.
Closes #8870.
 2018-05-20 23:35:20 +03:00
Vladimir Golovnev (Glassez)
a54f57611c
Rename torrent if content was initially renamed 
Closes #8910.
 2018-05-19 20:21:21 +03:00
Vladimir Golovnev (Glassez)
3be945a401
Add last used save path to the front of history 2018-05-19 19:43:01 +03:00
Chocobo1
95b19ec303
Relax behavior of "Download first and last piece first" 
Now it applies the setting to all files in torrent, no matter whether
the file is previewable or not.

Torrent client shouldn't be smart by deciding which file this
option will be applied to, i.e. it should just follow the user's decision.
 2018-05-19 21:48:13 +08:00
Chocobo1
da75a010c7
Refactor code 
Add const to variables.
Add Logger message.
Simplify code logic.
 2018-05-19 21:48:13 +08:00
Chocobo1
eb72b9ca7d
Simplify the saving & loading of a setting 
Remove excessive usage of constexpr.
 2018-05-19 20:56:43 +08:00
Vladimir Golovnev
c29e5c76dc
Merge pull request #8936 from surfernsk/master 
Fix open destination folder with Nautilus > 3.28. Closes #8923
 2018-05-19 15:06:03 +03:00
Vladimir Golovnev (Glassez)
53b9bcaaac
Place "Use Smart Episode Filter" more correctly 2018-05-19 14:52:38 +03:00
Vladimir Golovnev (Glassez)
844f76c2ca
Make "Ignoring days" to behave like other filters 
This prevents confusing in GUI when it shows matched RSS
articles which be really ignored by the rule.
 2018-05-19 14:52:24 +03:00
Evgeny Lensky
c7601d7a43 Fix open destination folder with Nautilus > 3.28 
Closes #8923.
 2018-05-19 18:45:26 +07:00
Mike Tzou
07c15127ba
Merge pull request #8915 from Chocobo1/runext4 
Improve "Run External Program" behavior
 2018-05-19 14:58:45 +08:00
Vladimir Golovnev (Glassez)
256f6954c5
Improve code of RSS auto-downloading rule 
Closes #8933.
 2018-05-18 13:26:04 +03:00
Chocobo1
ceaf755ac6
Make use of QStringLiteral 
Only changed instances that are initialized at program start.
 2018-05-18 02:14:49 +08:00
Vladimir Golovnev
e157ca2430
Merge pull request #8932 from glassez/rss-settings 
Properly set RSS settings via API. Closes #8925
 2018-05-17 06:07:25 +03:00
Chocobo1
fcbcf4039b
Use smaller type 2018-05-17 10:57:12 +08:00
Vladimir Golovnev (Glassez)
90f09e7570
Properly fill UploadedFile::filename field 
Closes #8928.
 2018-05-16 20:13:55 +03:00
Mike Tzou
7bfe08d466
Merge pull request #8926 from Chocobo1/lint 
Detect endianness at compile time
 2018-05-16 20:07:03 +08:00
Vladimir Golovnev
e2da7928b1
Merge pull request #8922 from glassez/save-path 
Add option to remember last used save path. Closes #7323
 2018-05-15 19:30:09 +03:00
Vladimir Golovnev (Glassez)
98ca274169
Rename RSS properties to follow other names 2018-05-15 16:05:51 +03:00
Chocobo1
0a49f76c0a
Detect endianness at compile time 2018-05-15 21:02:00 +08:00
Vladimir Golovnev (Glassez)
2a0b104e5e
Properly set RSS settings via API 
Closes #8925.
 2018-05-15 15:59:28 +03:00
Vladimir Golovnev (Glassez)
71e5a40857
Add option to remember last used save path 
Replace in "Add new torrent" dialog confusing "Set as default save path" option
with "Remember last used save path" option that affects only selected value in
"Save path" combo box.
Closes #7323.
 2018-05-15 10:38:24 +03:00
Mike Tzou
3b1fa19ea8
Merge pull request #8895 from Chocobo1/locale 
Apply locale changes immediately in WebUI
 2018-05-15 00:29:45 +08:00
Mike Tzou
a0f200be0d
Merge pull request #8894 from Chocobo1/tr 
Make strings translatable
 2018-05-14 12:53:40 +08:00
sledgehammer999
e3ce9b2645
Merge pull request #8903 from sledgehammer999/fix_upgrade_artifacts 
Delete non-commited fastresume files
 2018-05-13 17:24:47 +03:00
Vladimir Golovnev
7afbc346d5
Merge pull request #8906 from glassez/fix-webui 
Fix WebUI bugs
 2018-05-13 17:02:24 +03:00
sledgehammer999
35eee0b590
Don't migrate torrents that have newer fastresumes 2018-05-13 15:50:10 +03:00
sledgehammer999
7626ebe7a6
Delete non-commited fastresume files 
Old v3.3.x format had a number at the end indicating the queue position.
The naming scheme was '<infohash>.fastresume.<queueposition>'.
However, QSaveFile, which uses QTemporaryFile internally, might leave
non-commited files behind eg after a crash. These files have the
naming scheme '<infohash>.fastresume.XXXXXX' where each X is a random
character. We try to detect the latter and remove it without "migrating"
the fastresume to the new saving system.
 2018-05-13 15:50:10 +03:00
sledgehammer999
bde736c18a
Merge pull request #8900 from sledgehammer999/fix_delete_logs 
Fix deletion of old logs
 2018-05-13 15:00:39 +03:00
Chocobo1
61e61a1fd5
Rename variables 
Variable name should not start with underscore as C++ standard stated it
is reserved.
 2018-05-13 19:24:59 +08:00
Vladimir Golovnev
8906c47798
Merge pull request #8782 from mj-p/filterByHashes 
Filter torrent info endpoint by hashes
 2018-05-13 13:20:00 +03:00
sledgehammer999
8a99e29122
Merge pull request #8716 from sledgehammer999/move_progress 
Move and recheck progress
 2018-05-13 13:02:03 +03:00
sledgehammer999
375b15727d
Show rechecking progress 
When having big torrents, the rechecking might take a while to
complete. Users need some sort of feedback that progress is being made.
Also, I changed the float to qreal since that's the return type.
 2018-05-13 12:32:17 +03:00
sledgehammer999
7484889836
Fix deletion of old logs 2018-05-13 12:11:19 +03:00
Chocobo1
263524e856
Improve "Run External Program" behavior 
This follows utorrent behavior: they don't append backslash character at
the end of path variables.
Closes #8836.
 2018-05-13 15:21:27 +08:00
Chocobo1
5ae926a376
Refactor code 
Add const to variables.
No functionality change.
 2018-05-13 15:05:30 +08:00
Chocobo1
92a4e73a22
Apply locale changes immediately in WebUI 2018-05-13 15:05:29 +08:00
Mike Tzou
2230d96705
Merge pull request #8808 from Chocobo1/save 
Improve SettingsStorage behavior
 2018-05-13 14:24:14 +08:00
sledgehammer999
e5c73cee4a
Log successful torrent move 2018-05-12 20:49:33 +03:00
sledgehammer999
565ffa7d1e
Add 'Moving' state for torrents being relocated/moved 
This is another indication to the user that something is happening
behind the scenes.
Uses the same icon/color as "Checking" status.
Torrents in the `Moving` state are considered as "Active". This should
prevent accidental program exit from the user and inhibit system sleep.
 2018-05-12 20:49:33 +03:00
adem
b3f98fc975 Update Windows icons 2018-05-12 11:34:53 +04:00
Vladimir Golovnev (Glassez)
88f2a66aac
Fix params handling for some legacy API methods 
Closes #8880.
 2018-05-12 07:35:35 +03:00
Vladimir Golovnev (Glassez)
0fda49c060
Improve legacy API params handling 2018-05-12 07:35:31 +03:00
Vladimir Golovnev (Glassez)
afcf232bd8
Fix invalid API calls in WebUI 
Closes #8899.
 2018-05-12 07:35:27 +03:00
Vladimir Golovnev (Glassez)
32e2791f56
Fix compilation with MinGW 2018-05-12 06:24:05 +03:00
Chocobo1
b1304057ec
Fix i18n in WebUI 
Closes #8844.
 2018-05-11 20:20:51 +08:00
Chocobo1
c26ff40029
Make strings translatable 
Closes #8866.
 2018-05-11 19:29:02 +08:00
thalieht
4cfa163bbd Use qt5 syntax for a few remaining SLOT() 2018-05-11 08:19:41 +03:00
thalieht
20ca90800d Fix coding style 2018-05-09 17:06:22 +03:00
thalieht
586e1a0830 Move some connect() from propertieswidget to their corresponding widget 2018-05-09 16:08:22 +03:00
thalieht
6b4455e13d Use qt5 connect() syntax 2018-05-09 16:08:22 +03:00
Chocobo1
4d04af4043
Replace raster qbt logo with vector version 
Add helper function for svg icons.
 2018-05-09 16:33:17 +08:00
Chocobo1
f934042a98
Fix GUI scaling factor on macOS 
macOS seems have an unique way to handle widget size, that is, it doesn't require
application to resize widgets manually, Qt will handle the resize job
automatically.

Closes #8841.
 2018-05-09 16:33:14 +08:00
Chocobo1
0b63f35a54
Use 32px icons for favicon 
One less resource to manage and 16px size can be downsampled from 32px
on-the-fly anyway.
 2018-05-09 15:53:34 +08:00
Mike Tzou
7af83ab704
Merge pull request #8807 from Chocobo1/tracker_msg 
Fix displayed tracker message
 2018-05-09 14:38:17 +08:00
Mike Tzou
99a1343b9d
Merge pull request #8862 from Chocobo1/cleanup 
Code cleanups
 2018-05-09 14:33:49 +08:00
Vladimir Golovnev
eab5dad32d
Merge pull request #8860 from Kolcha/mac_warning 
Add missing "override"
 2018-05-08 17:14:21 +03:00
Vladimir Golovnev
3a0e5e51df
Merge pull request #8761 from thalieht/nullptr 
Replace the zeroing of pointers with nullptr
 2018-05-08 17:10:37 +03:00
Nick Korotysh
0b8c620fd3
Add missing "override" 2018-05-08 08:33:07 +03:00
Chocobo1
c0df292567
Remove debug messages 2018-05-08 12:18:18 +08:00
Chocobo1
defba23d61
Refactor code 
Remove forward declarations of Qt types.
Fix header include order.
 2018-05-08 12:18:18 +08:00
Vladimir Golovnev
48bdd5fa86
Merge pull request #8855 from glassez/fix-prio-api 
Fix wrong API method names. Closes #8828
 2018-05-08 07:07:31 +03:00
Vladimir Golovnev (Glassez)
85dd446198
Fix wrong API method names 
Closes #8828.
 2018-05-07 17:46:01 +03:00
Chocobo1
6d923f703a
Fix displayed tracker messages 
Before this change, we were displaying debug messages constructed by
libtorrent, now we show messages returned by trackers.

Closes #8739.
 2018-05-07 21:49:31 +08:00
Chocobo1
90f42e6737
Refactor functions 
Add const to variables
Remove debug messages
 2018-05-07 21:49:31 +08:00
Chocobo1
58861c35b0
Fix compile warnings on gcc 8 
The warning was:
warning: catching polymorphic type ‘class std::exception’ by value
[-Wcatch-value=]
 2018-05-07 21:39:54 +08:00
Chocobo1
203bafc4c3
Revert commit 
Apparently the translations were working in previous state, but affected by
lupdate issue:
https://github.com/qbittorrent/qBittorrent/issues/8220#issuecomment-385712673

The reverts commit fb698896c9.
Closes #8831.
 2018-05-05 21:46:36 +08:00
Chocobo1
9f809114f0
Really fix translation in fspathedit 
QT_TRANSLATE_NOOP3 is a macro, so we cannot use a runtime string for the context
argument.
Fix up 1d778676cd.
 2018-05-05 21:09:47 +08:00
Chocobo1
d20f40184f
Fix translation strings not found 
The translation context doesn't exist, so the translations were not found, fixed
now.
Closes #8829.
 2018-05-05 21:08:47 +08:00
Mike Tzou
d8c14ffe97
Merge pull request #8814 from Chocobo1/tr_fix 
Fix tr() related issues
 2018-05-05 13:48:09 +08:00
sledgehammer999
ea8c57be23
Sync translations from Transifex and run lupdate 2018-05-05 00:39:47 +03:00
sledgehammer999
90bb67c654
Add RSS/Log widgets to the QTabWidget on macOS 
Fixes commit a468c84b30
 2018-05-04 19:56:42 +03:00
Marcel Petersen
fc58e8a0c6 Filter torrent info endpoint by hashes 
Added hashes parameter to info action.
Allows filtering seralized torrents by passing it into the TorrentFilter.
 2018-05-02 10:07:48 +02:00
sledgehammer999
8f7fda492c
Sync translations from Transifex and run lupdate 
Closes #8220 #8169
 2018-05-01 18:50:24 +03:00
Chocobo1
e423314ac2
Work around false-positive warning from lupdate 
In short, lupdate will get confused when seeing `template <class T>`,
see: QTBUG-55478
 2018-05-01 23:28:34 +08:00
sledgehammer999
f92d85c536
Merge pull request #8813 from Chocobo1/tr 
Fix untranslated string
 2018-05-01 17:59:49 +03:00
Chocobo1
9fabe59b80
Fix usage of Q_DECLARE_TR_FUNCTIONS() 
The context parameter shouldn't be enclosed in double quotes.
 2018-05-01 22:42:55 +08:00
sledgehammer999
6e94b03c13
Fix compilation against libtorrent 1.0.x 
Closes #8798
 2018-05-01 10:39:53 +03:00
Chocobo1
c61f641613
Fix untranslated string 
Closes #8809.
 2018-05-01 11:49:10 +08:00
Chocobo1
f6d74e3996
Retry saving settings when operation failed 2018-04-30 13:01:10 +08:00
Chocobo1
099314d17f
Make settings file recovery more robust 
We should not blindly remove the leftover settings file, as the following write()
operation could fail and the user would lost all settings.
We should try renaming it instead.
 2018-04-30 13:01:10 +08:00
Chocobo1
708b5a6904
Refactor SettingsStorage class 
Make use of (i.e. returning) QFile::rename operation status
Make log message more verbose
Add const
Remove empty lines
Inline typedef
 2018-04-30 13:01:10 +08:00
sledgehammer999
fb346e15e8
Sync translations from Transifex and run lupdate 2018-04-27 02:04:37 +03:00
Chocobo1
8b575484e6
Fix path separator in log messages 2018-04-24 01:02:54 +08:00
sledgehammer999
b78899cb9a
Merge pull request #8724 from Chocobo1/rand 
Use RNG provided by OS
 2018-04-22 22:33:16 +03:00
Mike Tzou
0dec7b9f4f
Merge pull request #8742 from tostercx/master 
Add "Preserve file order" option to torrent creator. Closes #5652
 2018-04-22 23:33:25 +08:00
Chocobo1
81a4f3ced0
Use RNG provided by OS 
The general consensus is to use random facility provided by OS instead
of using other software random generators.
 2018-04-20 23:34:46 +08:00
Chocobo1
970ad7cf28 Sort filenames when creating torrent 
First all dir paths are retrieved, then filenames in each path
are retrieved and sorted, then concatenate the sorted filenames together.
 2018-04-20 14:35:48 +03:00
toster
c4625f50a8 Pass isAlignmentOptimized flag to piece size calculation 2018-04-20 14:31:20 +03:00
Vladimir Golovnev (Glassez)
001bd38557
Fix pauseAll/resumeAll legacy API methods 
Closes #8766.
 2018-04-20 14:30:25 +03:00
Chocobo1
68c2d81072
Fix memory leak 2018-04-17 20:34:01 +08:00
Chocobo1
4dea03fc74
Remove unused constants 2018-04-17 20:29:43 +08:00
thalieht
3e4099fe5b Replace the zeroing of pointers with nullptr 2018-04-15 13:06:31 +03:00
Mike Tzou
a70942ed53
Merge pull request #8598 from Piccirello/limit-share-ratio 
WebUI Add Limit Share Ratio context menu option
 2018-04-15 00:39:27 +08:00
toster
e538eae726 Make alignment optimization optional 
Disabling alignment optimization allows preserving file order in torrent
files and closes #5652
 2018-04-14 06:46:41 +03:00
Chocobo1
898239a42e
Fix renaming completed files 
Check whether the file is already downloaded before appending QB_EXT to
filename.

Closes #8039.
 2018-04-12 14:13:59 +08:00
Mike Tzou
1055cc0f45
Merge pull request #8691 from Chocobo1/js 
Partially revert "Remove unused JavaScript library"
 2018-04-12 00:07:37 +08:00
Thomas Piccirello
9f36b54b04
WebUI Add Limit Share Ratio context menu option 
Closes #6815, #7602.
 2018-04-11 23:45:54 +08:00
Thomas Piccirello
1f42ab8c4f
Remove unused/superfluous variables 2018-04-11 23:45:54 +08:00
Thomas Piccirello
3f0fbc0810
WebUI rename property to match its definition 2018-04-11 23:45:54 +08:00
sledgehammer999
7e4b62c68d
Merge pull request #8701 from Kolcha/musl-support 
Allow to disable Stacktrace support
 2018-04-11 17:10:01 +03:00
sledgehammer999
ddba79ef3d
Fix wrong QString::arg() usage that leads to crash 
We need to be careful when using the multi-arg version of
QString::arg() and passing as 2nd, 3rd etc parameter an int.
It doesn't do the same as passing multiple QStrings.
 2018-04-11 17:01:43 +03:00
Nick Korotysh
7712d0ada0
Allow to disable Stacktrace support 
Enable backtrace stuff only if GNU C library used, because current
backtrace implementation based  on  <execinfo.h> , which is not a
part of standard C library, it is a GNU extension.

This will be usefull when building  with  custom POSIX-compilant C
library (like musl) and no <execinfo.h> available.

Note: configure script will detect presence of  <execinfo.h>  and
enable/disable feature depending on it.

Feature is enabled by default.
 2018-04-10 20:51:11 +03:00
Mike Tzou
38837db8de
Merge pull request #8699 from Chocobo1/linking 
Add helper for loading Windows system functions
 2018-04-11 00:13:55 +08:00
sledgehammer999
d997d887e5
Merge pull request #8650 from luis-pereira/fix-invalid-iterator-crash 
Fix crashes due to invalid iterator use
 2018-04-10 16:18:44 +03:00
sledgehammer999
341a971cd3
Merge pull request #8711 from sledgehammer999/recheck_paused 
Avoid data corruption when rechecking paused torrents
 2018-04-10 16:18:12 +03:00
Mike Tzou
fa380c8b2c
Merge pull request #8622 from Chocobo1/formatter 
Unify coding style for WebUI files
 2018-04-10 14:51:32 +08:00
Luís Pereira
758c70283f
Fix crashes due to invalid iterator use 
Although the iterators are constant we are indirectly changing them.
Introduced by commit ac42ccb5e4.
Closes #8633
 2018-04-09 23:40:08 +03:00
sledgehammer999
747c70a58e
Avoid data corruption when rechecking paused torrents 
Libtorrent can recheck only unpaused torrents. We get around this by
unpausing the torrent, issuing the recheck and pausing again after we
get alerted by libtorrent that the recheck has finished. This alert is
asyncronous. There is a small time frame where the program might start
downloading and writing data to the file before we pause it. This can
lead to data corruption if the file on disk is totally different that
the one expected by the torrent AND the file on disk is a valid file on
its own. OR in case the user points the new torrent to the wrong
directory by mistake.
To get around this the torrent is placed in upload_mode and out of
automanagement.
 2018-04-09 23:25:52 +03:00
Vladimir Golovnev (Glassez)
cb505a07fe
Fix setting preferences via WebAPI 
Closes #7335.
 2018-04-09 18:54:43 +03:00
Chocobo1
5819b6dd39
Use Unicode version of InitiateSystemShutdown 2018-04-09 21:18:07 +08:00
Chocobo1
644e7d0450
Use dynamic linking for SetSuspendState function 2018-04-09 21:18:07 +08:00
Chocobo1
b0e3d77975
Add helper for loading Windows system functions 2018-04-09 21:18:04 +08:00
Chocobo1
643a209812
Sort include headers 
Also add anonymous namespace.
 2018-04-09 21:16:00 +08:00
Mike Tzou
c3311e83a0
Merge pull request #8687 from Chocobo1/folder 
Stop creating Download folder on start
 2018-04-09 13:20:48 +08:00
Chocobo1
cf2c0bd47e
Apply formatting to Web UI files 2018-04-07 21:45:56 +08:00
Chocobo1
59e6757242
Avoid showing an empty row in AdvancedSettings 
Fixup 543cbc6d1c.
 2018-04-05 21:34:07 +08:00
Chocobo1
6bbcf9b3d6
Stop creating Download folder on start 
The existence of this folder isn't required to run qbt and it can be
created when adding torrent.
Closes #8290.
 2018-04-05 14:12:47 +08:00
Chocobo1
208d21ff73
Add js-beautify config 
Try to standardize coding style for HTML & JavaScript via this tool
 2018-04-05 12:19:54 +08:00
Chocobo1
2df71dbde5
Partially revert "Remove unused JavaScript library" 
This reverts commit 470e993c2d.
 2018-04-05 03:22:34 +08:00