mirrors/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2025-01-07 15:47:25 +03:00
Code Issues Projects Releases Packages Wiki Activity
11718 commits 16 branches 245 tags 255 MiB
Commit graph

1808 commits

Author SHA1 Message Date
Vladimir Golovnev (Glassez)
8cfd803222
Drop implicit conversions between InfoHash and QString 2021-03-06 12:35:42 +03:00
Chocobo1
f00f552369
Properly stop torrent creation if aborted 
Closes #11346.
 2021-03-04 14:54:02 +08:00
Vladimir Golovnev
a2b0531d5f
Merge pull request #14189 from glassez/libtorrent-1.2.12 
Raise minimum libtorrent version to 1.2.12 (2.0.2)
 2021-03-01 20:43:28 +03:00
Mike Tzou
7400284cff
Merge pull request #14437 from Chocobo1/mime 
Improve detection of filename extension of audio/video files
 2021-02-23 12:35:17 +08:00
Chocobo1
e1f9083c81
Improve detection of filename extension of audio/video files 2021-02-21 17:38:21 +08:00
Michał Kopeć
614376ed64 Add an option to disable icons in menus 2021-02-20 18:12:02 +01:00
Chocobo1
4a0b36a50b
Use std::optional to return results 2021-02-10 12:25:26 +08:00
Chocobo1
fffe5e7003
Fix potential out-of-bounds access 2021-02-10 12:25:15 +08:00
Chocobo1
e46c88580a
Revise getter function for torrrent queue position 
This addresses https://github.com/qbittorrent/qBittorrent/pull/14335#issuecomment-774667836

The WebAPI is not affected as a workaround is added.
 2021-02-08 14:24:16 +08:00
Mike Tzou
e6033c952e
Merge pull request #14351 from Chocobo1/avail 
Show proper string when torrent availability is not available
 2021-02-08 12:12:22 +08:00
Vladimir Golovnev
3dfd0ff3b3
Merge pull request #14354 from glassez/missing-files 
Improve handling of "missing files" torrents
 2021-02-08 06:34:15 +03:00
Chocobo1
6a45919b25
Clean up coding style 2021-02-07 16:08:20 +08:00
Vladimir Golovnev (Glassez)
c3f02d833c
Restart "missing files" torrents after changing location 2021-02-06 14:59:51 +03:00
Vladimir Golovnev (Glassez)
e273ac3a0d
Allow "missing files" torrents to save more resume data 2021-02-06 14:30:33 +03:00
Vladimir Golovnev (Glassez)
459d02abc8
Allow change-case-only file renaming on Windows 2021-02-06 11:33:46 +03:00
dyumin
12d396ffc5 Treat errored torrents as finished 2021-01-29 12:36:25 +03:00
an0n666
24d7d599f1
Validate HTTPS Tracker Certificate by default 2021-01-20 13:33:10 +06:00
Vladimir Golovnev (Glassez)
ae29e8bbab
Drop extension from generated content folder name 
Try to detect whether generated content folder name contains extension
and drop it to avoid possible conflicts between file/folder names.
 2021-01-18 10:37:19 +03:00
Chocobo1
1479b61214
Simplify code for checking free disk space 
`QStorageInfo::bytesAvailable()` is guaranteed to return `-1` for an
invalid path.
https://doc.qt.io/qt-5/qstorageinfo.html#bytesAvailable
 2021-01-17 11:51:33 +08:00
Chocobo1
15a249eb54
Improve detection of file extension string 2021-01-17 00:10:18 +08:00
Vladimir Golovnev (Glassez)
f9e286123f
Raise minimum libtorrent version to 1.2.12 2021-01-10 14:38:58 +03:00
sledgehammer999
613fd1bcf0
Merge pull request #14162 from Chocobo1/flags 
Disable compiler flags
 2021-01-09 14:08:55 +02:00
Mike Tzou
d7fb2e6403
Merge pull request #14176 from Chocobo1/pack_src_2 
Add script for generating project tarball
 2021-01-09 12:51:46 +08:00
Vladimir Golovnev
e3119b457c
Merge pull request #14179 from lbilli/patch-1 
On Linux use legacy 'data' directory only as a fallback
 2021-01-08 22:15:34 +03:00
Chocobo1
302cb27e98
Add script for generating project tarball 2021-01-07 23:31:05 +08:00
lbilli
2d3481b9a9
On Linux use legacy 'data' directory only as a fallback 2021-01-07 10:04:08 -05:00
Chocobo1
24fa9e32b0
Set source character sets to UTF-8 
This suppress warning C4819.
https://docs.microsoft.com/en-us/cpp/build/reference/utf-8-set-source-and-executable-character-sets-to-utf-8?view=msvc-160
 2021-01-07 11:51:24 +08:00
Vladimir Golovnev (Glassez)
0b4fef19f6
Remove redundant suffix from TorrentHandle class 
Originally, it was just a wrapper for libtorrent::torrent_handle class, so it mimicked its name.
It was then transformed into a more complex aggregate, but the name was retained (just by inertia).
Unlike libtorrent::torrent_handle class in whose name "handle" means the pattern used,
it does not matter for qBittorrent classes and just eats up space in the source code.
 2021-01-06 16:28:17 +03:00
Mike Tzou
b79a1b5755
Merge pull request #14145 from Chocobo1/define 
Generate version header when configuring project
 2021-01-06 11:38:55 +08:00
Vladimir Golovnev
8771e1a339
Merge pull request #14138 from glassez/add-torrent 
Use single parameter to accept torrent source
 2021-01-05 09:17:08 +03:00
Vladimir Golovnev (Glassez)
531ae501ad
Use std::optional<bool> instead of custom TriStateBool 2021-01-04 23:10:24 +03:00
Vladimir Golovnev (Glassez)
d0cac421bb
Change parseBool() to return optional bool value 2021-01-04 23:10:24 +03:00
Vladimir Golovnev (Glassez)
4429a16ca8
Use std::optional instead of boost::optional 2021-01-04 23:10:03 +03:00
Chocobo1
c669401767
Generate version header when configuring project 
The basic idea is we create a version header template at
"src/base/version.h.in" and the build systems are expected to replace
strings that are enclosed with @ symbols and generate
"src/base/version.h" for other source files to consume/include.
 2021-01-04 22:28:41 +08:00
Vladimir Golovnev (Glassez)
ee5fe424e8
Use single parameter to accept torrent source 2021-01-03 17:01:20 +03:00
Vladimir Golovnev (Glassez)
552ff0489d
Use nested namespaces definition syntax 2021-01-03 16:53:24 +03:00
Mike Tzou
04a9ce6e81
Merge pull request #14074 from Chocobo1/dialog_size 
Remember dialog sizes
 2021-01-03 13:20:21 +08:00
Mike Tzou
586bdc0567
Merge pull request #14121 from Chocobo1/settingsStorage 
Improve load data behavior of SettingsStorage class
 2021-01-03 13:19:53 +08:00
Vladimir Golovnev
4bb3d13921
Merge pull request #14123 from glassez/restart-missing-files 
Don't re-check "missing files" torrents when re-start
 2021-01-02 15:20:50 +03:00
Vladimir Golovnev
7c02630186
Merge pull request #14116 from glassez/drop-move-notify 
Drop notification about move storage finished
 2021-01-02 10:34:09 +03:00
Chocobo1
bdf1fb6db8
Revise store/load state operations of Options Dialog 2021-01-02 13:25:23 +08:00
Chocobo1
be5af2796d
Revise SettingsStorage store/load value interface 2021-01-02 12:48:26 +08:00
Chocobo1
b1020c599f
Improve load data behavior of SettingsStorage class 
Previously it only handle the case of failed lookup, now it discard
invalid values when deserializing the database from disk.
Also checks whether the data is convertible to the intended type.
 2021-01-01 22:57:50 +08:00
Vladimir Golovnev (Glassez)
b2199202ab
Reload "missing files" torrent instead of re-checking 2021-01-01 16:16:52 +03:00
Vladimir Golovnev (Glassez)
06105072f9
Extract torrent reloading logic into separate method 2021-01-01 16:08:01 +03:00
Chocobo1
e022c371ff
Move parsing of TriStateBool to a static class function 2021-01-01 12:59:48 +08:00
Vladimir Golovnev (Glassez)
df2bbe129d
Drop notification about move storage failed 2020-12-31 21:53:43 +03:00
Vladimir Golovnev (Glassez)
f7cae610a4
Drop notification about move storage finished 2020-12-31 21:49:18 +03:00
Chocobo1
5bd6ff2285
Migrate away from deprecated std::iterator class 2020-12-31 13:28:48 +08:00
Chocobo1
d70b893852
Bump project requirement to C++17 2020-12-31 13:28:48 +08:00
Mike Tzou
a579b4a519
Merge pull request #14085 from Chocobo1/settingvalue 
Add a thin layer around SettingsStorage class
 2020-12-31 10:46:32 +08:00
sledgehammer999
fffa2f097e
Merge pull request #14069 from sledgehammer999/new_languages 
Add new languages
 2020-12-30 23:43:43 +02:00
Vladimir Golovnev
348109a1f9
Merge pull request #13995 from glassez/rename-files 
Improve content file/folder names handling
 2020-12-29 22:27:58 +03:00
Chocobo1
0b0597be0c
Add a thin layer around SettingsStorage class 
This new layer would be handy for saving GUI widget states as they don't
need the value cached and they store/load rarely.
 2020-12-30 00:10:22 +08:00
Mike Tzou
cc9b1ea8a1
Merge pull request #14073 from Chocobo1/locale 
Capitalize locale names
 2020-12-29 17:32:37 +08:00
sledgehammer999
ffebe82586
Add new languages 
* Azerbaijani
* Estonian
 2020-12-28 21:58:44 +02:00
Vladimir Golovnev (Glassez)
4453e7fcdd
Improve content file/folder names handling 
Move files/folders renaming functions to core classes.
Query file/folder for renaming by its current path.
Add ability to rename content folders from WebAPI/WebUI.
 2020-12-28 21:18:28 +03:00
Mike Tzou
60d65d8137
Merge pull request #13885 from thalieht/torrentOptionsDialog 
Rework global speed limit dialog and introduce torrent options dialog
 2020-12-28 11:34:38 +08:00
Chocobo1
c8eefe749f
Capitalize locale names 2020-12-28 11:25:25 +08:00
Vladimir Golovnev (Glassez)
79048812e9
Fix folder name extraction functions 
It should return empty string if there is no parent folder.
 2020-12-26 14:47:06 +03:00
Vladimir Golovnev
70b242f190
Merge pull request #13955 from glassez/content-policy 
Improve content root folder handling
 2020-12-26 14:44:51 +03:00
thalieht
8db4bde15d Group several torrent options into one dialog 
Speed limits, share limits and the new options to disable DHT, PeX, LSD per torrent
 2020-12-25 20:37:43 +02:00
thalieht
fbb8f0cbf5 Save fastresume when setting torrent speed limits 2020-12-25 20:37:43 +02:00
Chocobo1
4180db601d
Use a helper function to look up stat indexes 2020-12-24 23:20:21 +08:00
Chocobo1
90a1ea4281
Don't use removed stat metric in libtorrent 2.0 
For now, the metric is not entirely removed due to WebAPI still needs to
access it.
 2020-12-24 12:04:14 +08:00
Chocobo1
0ebd864db9
Initialize stat indices to -1 
When the index is initialized it will be set to a number >= 0, so we use
-1 to denote its uninitialized status.
 2020-12-24 11:30:48 +08:00
Vladimir Golovnev (Glassez)
1d5dc283fe
Allow to add root folder to torrent content 2020-12-23 13:07:33 +03:00
Vladimir Golovnev (Glassez)
f6d1fea9b7
Fix bug of "move storage job" can be performed multiple times 2020-12-21 20:11:01 +03:00
Vladimir Golovnev (Glassez)
d4a51979bb
Extract enum serialization/parsing functions 2020-12-15 10:18:39 +03:00
Vladimir Golovnev (Glassez)
77555cd5c2
Improve torrent name handling 2020-12-15 10:18:39 +03:00
Vladimir Golovnev
c01d28a471
Merge pull request #13948 from FranciscoPombal/pragmatism 
Use #pragma once instead of include guards
 2020-12-14 13:51:02 +03:00
Chocobo1
20ae89c2a1
Add support for allow_idna option 
Upstream PR: https://github.com/arvidn/libtorrent/pull/5316
 2020-12-13 12:12:24 +08:00
Chocobo1
0baa23f553
Update "HTTPS tracker validation" enablement conditional 
https://github.com/arvidn/libtorrent/pull/5313
 2020-12-13 12:12:24 +08:00
Mike Tzou
10fbb6a2a8
Merge pull request #13953 from Chocobo1/cmp 
Migrate away from deprecated QVariant comparison operators
 2020-12-13 11:49:52 +08:00
FranciscoPombal
6152b83405 Use #pragma once instead of include guards 2020-12-12 19:41:32 +00:00
Vladimir Golovnev (Glassez)
5f94238d23
Fix bug of torrents don't save "stopped" state 2020-12-11 17:33:37 +03:00
Chocobo1
4d1d5d6b20
Revise Utils::Version comparison operators 2020-12-11 12:50:12 +08:00
Chocobo1
5ba6a5fca1
Add operator< for InfoHash class 2020-12-10 20:11:15 +08:00
Chocobo1
498da509db
Use Qt provided forward declaration header 2020-12-09 18:21:02 +08:00
Mike Tzou
d484c0e7ce
Merge pull request #13912 from Chocobo1/infohash 
Use the correct type when referring to info hash
 2020-12-08 20:53:12 +08:00
Vladimir Golovnev
5c1c561d7d
Merge pull request #13905 from glassez/handle-metadata 
Fix received metadata handling
 2020-12-07 08:39:06 +03:00
Chocobo1
9f0429ca6f
Use the correct type when referring to info hash 2020-12-06 22:04:28 +08:00
Vladimir Golovnev
3485ad39d9
Merge pull request #13511 from FranciscoPombal/bump_versions 
Bump minimum dependency versions
 2020-12-05 13:27:21 +03:00
Vladimir Golovnev (Glassez)
4e04cd27c9
Fix received metadata handling 2020-12-05 10:03:27 +03:00
FranciscoPombal
7e4b428a3e Fix method invocation on Qt < 5.10 
Fixup 0c3fe54b0b
 2020-12-04 22:46:49 +00:00
Vladimir Golovnev
2f6ed86c78 Drop support for building with libtorrent < 1.2.11 
Co-authored-by: Vladimir Golovnev <glassez@yandex.ru>
 2020-12-04 14:30:12 +00:00
Vladimir Golovnev (Glassez)
a93b675cb8
Search for existing files in separate thread 2020-12-03 07:58:34 +03:00
Vladimir Golovnev (Glassez)
9497300a4a
Don't rewrite TorrentInfo instance if it's valid 2020-12-01 08:15:26 +03:00
Vladimir Golovnev (Glassez)
acab62e345
Properly handle "Append extension" option changing 2020-12-01 08:15:25 +03:00
Vladimir Golovnev (Glassez)
0e8feed2f2
Clean up metadata downloading code 2020-12-01 08:15:12 +03:00
sledgehammer999
82716d8014
Merge pull request #13871 from sledgehammer999/magnet_delete 
Don't try to remove folders for a torrent without metadata
 2020-12-01 02:14:51 +02:00
sledgehammer999
9721acbf63
Don't try to remove folders for a torrent without metadata 2020-11-29 02:41:47 +02:00
sledgehammer999
be5cb1683b
Fix status of torrents without metadata 2020-11-29 00:32:53 +02:00
Vladimir Golovnev (Glassez)
c41df9ffbd
Improve coding style 2020-11-17 21:02:37 +03:00
sledgehammer999
6ec07d744e
Add Latgalian translation 
Closes #12415
 2020-11-16 20:26:54 +02:00
Chocobo1
0be2567d97
Don't use deprecated torrent state "allocating" 
Closes #13737.
 2020-11-12 00:17:42 +08:00
Vladimir Golovnev (Glassez)
85bd0feee0
Handle torrent "paused" state at application level 2020-11-02 10:09:14 +03:00
Mike Tzou
b249216db6
Merge pull request #13659 from FranciscoPombal/whitespacev2 
File health: trailing newlines, whitespace, etc fixes and GitHub Actions workflow
 2020-11-02 11:33:21 +08:00
Chocobo1
7ddd5e9bc3
Remove unused function 2020-11-01 14:25:33 +08:00
NotTsunami
a5f8f1f0f5 Fix mingw64 build error 
mingw64 defines interface, so revert back to previous naming scheme

Fixes: 87864531ab
Closes #13649
 2020-10-29 18:25:19 -04:00
FranciscoPombal
4bdf9eda41 Fix extra/missing trailing new lines in files 2020-10-28 14:20:18 +00:00
Vladimir Golovnev
571aaea3e0
Merge pull request #13658 from glassez/recheck 
Don't resume "paused" torrents when put into "checking" state by libtorrent
 2020-10-28 08:45:35 +03:00
Vladimir Golovnev (Glassez)
80ca7796ca
Fix torrent state calculation 2020-10-27 17:41:40 +03:00
Vladimir Golovnev (Glassez)
9f0edde12b
Don't resume "paused" torrents when checking by libtorrent 2020-10-26 11:08:22 +03:00
Chocobo1
480832318c
Add support for tracker scrape in libtorrent 2.0 2020-10-26 00:37:53 +08:00
Chocobo1
7a3e397949
Migrate away from deprecated functions in libtorrent 2.0 2020-10-26 00:37:53 +08:00
Chocobo1
c95e450b8d
Improve compatibility with libtorrent 2.0 
In libtorrent 2.0, the `connection_type` was changed to a flag type and
hence it cannot be used in a switch statement directly. Also our use of
`connection_type` is limited so that a single equality comparison
would cover all of our use cases.
 2020-10-26 00:36:59 +08:00
Mike Tzou
172eda5471
Merge pull request #13620 from Chocobo1/qhash 
Move qHash helper for libtorrent types to its own file
 2020-10-24 12:34:26 +08:00
Chocobo1
3971a12f0e
Remove redundant checking before remove 2020-10-23 12:58:57 +08:00
Chocobo1
70c4eb44fd
Fix class name 2020-10-23 12:58:11 +08:00
Vladimir Golovnev (Glassez)
92c6fc04a8
Prevent resume data to be saved for removed torrent 2020-10-22 20:16:52 +03:00
Chocobo1
71827fe4e6
Move qHash helper for libtorrent types to its own file 2020-10-22 03:12:48 +08:00
Mike Tzou
39c61327b5
Merge pull request #13567 from Chocobo1/typo 
Fix typos
 2020-10-21 11:04:17 +08:00
Chocobo1
7e258bfe38
Fix typos 2020-10-20 18:56:30 +08:00
Andrei Stepanov
04306a544f
Fix typo in connection.cpp 
limiation -> limitation
 2020-10-20 11:10:51 +04:00
Vladimir Golovnev
720c1c8216
Merge pull request #13395 from glassez/disk_io 
Implement disk IO thread wrapper
 2020-10-17 12:53:25 +03:00
lbilli
1c7bfcac46
Don't create 'data' subdirectory on Linux 2020-10-15 14:02:28 -04:00
Anton Bershanskiy
b4bfdd6f7a Add option for hashing_threads, use 10 asyc IO threads 
Add option for setting lt::settings_pack::hashing_threads
introduced by libtorrent 2.0. It has no effect for earlier
libtorrent versions.
Use 10 async IO threads, as per #11461.
Closes #11461.
 2020-10-13 00:58:13 +03:00
Chocobo1
19d77b0881
Add support for creating v2 torrents 2020-10-10 23:21:26 +08:00
Vladimir Golovnev
bad5e1f887
Merge pull request #12086 from FranciscoPombal/code-cleanup 
Clean ups
 2020-10-09 07:13:18 +03:00
FranciscoPombal
2c10b3936b Change some types (uint -> int) in RSS subsystem 2020-10-07 23:26:13 +01:00
FranciscoPombal
deffdbe881 Change some types (uint -> int) in Session class 2020-10-07 23:26:13 +01:00
FranciscoPombal
87864531ab Clean up in Session class 2020-10-07 23:26:13 +01:00
FranciscoPombal
f502f60f7c Avoid unessary QString allocation 2020-10-07 15:34:26 +01:00
Mike Tzou
2bfaa8229a
Merge pull request #13431 from Chocobo1/namespace 
Fix code defects
 2020-09-26 11:20:10 +08:00
Chocobo1
ef9765cea1
Remove meaningless const on pointers 
This only apply to signals.
 2020-09-25 15:13:14 +08:00
Chocobo1
ac3ab2432a
Remove redundant namespace prefix 2020-09-25 15:10:20 +08:00
Chocobo1
f487d32594
Fix initialization order 2020-09-25 12:25:09 +08:00
Mike Tzou
1a3091a980
Merge pull request #13419 from silverqx/patch-1 
Fix fully-qualified-moc-types clazy warning
 2020-09-22 22:34:52 +08:00
Silver Zachara
97df5667e7
Use fully-qualified type names 
Fixed fully-qualified-moc-types clazy warnings
 2020-09-21 18:30:02 +02:00
Mike Tzou
c3b5668a07
Merge pull request #12577 from NotTsunami/peer 
Allow users to configure no_connect_privileged_ports
 2020-09-22 00:02:20 +08:00
NotTsunami
2eb3ff7f06 Allow users to configure no_connect_privileged_ports 
Don't hardcode lt::settings_pack::no_connect_privileged_ports. We
support the peer alert for it already, so connections blocked by this
setting should be logged.
 2020-09-20 22:46:28 -04:00
Vladimir Golovnev
04d345251e
Merge pull request #13400 from glassez/sequential 
Improve sequentialDownload/firstLastPiecePriority handling
 2020-09-20 08:00:33 +03:00
FranciscoPombal
2534909d3b CMake: fix linking against OpenSSL 
This should have been there from the start,
but for some reason, the lack of it didn't cause any issued
for many systems.
 2020-09-18 17:53:14 +01:00
Vladimir Golovnev (Glassez)
39d32063c1
Implement disk IO thread wrapper 2020-09-18 15:56:29 +03:00
Vladimir Golovnev (Glassez)
ff36356be0
Improve sequentialDownload/firstLastPiecePriority handling 
Always store firstLastPiecePriority in resume data.
Don't recalculate firstLastPiecePriority value each time it is accessed.
Always store sequentialDownload in resume data as native libtorrent field.
 2020-09-18 13:33:55 +03:00
FranciscoPombal
46123b9989 CMake: overhaul and improve scripts 
- Bump minimum required version and
make use of more modern language features
- Rely more on target_...() commands to establish dependency
relationships between targets rather than directory property commands
- Improve libtorrent package discovery
- Enable and handle application features more explicitly
- Improve user-facing output
- Fix various compilation issues on Windows (MSVC and MinGW) and macOS
- Improve handling of translations
- Add explanatory comments where relevant
- Make CMake scripts fully independent of qmake files/details
- Remove old functions/macros
 2020-09-17 13:13:26 +01:00
FranciscoPombal
e0c62827a8 Fix peer blocked message 2020-09-16 16:59:51 +01:00
Mike Tzou
49e55d5a5d
Merge pull request #13268 from ngosang/feature/python35- 
Update minimum Python version to 3.5.0
 2020-09-14 12:03:20 +08:00
Chocobo1
8cfac795c6
Avoid using libtorrent internal functions 
`char const* socket_type_name(socket_type_t);` is decided to be not
exported and thus it is internal:
https://github.com/arvidn/libtorrent/pull/4859/files#r452925563
 2020-09-13 12:22:31 +08:00
Mike Tzou
8d57a6527b
Merge pull request #13355 from Chocobo1/allocate 
Enable faster disk space allocation by default
 2020-09-12 23:39:49 +08:00
Mike Tzou
2d1855dc05
Merge pull request #13354 from Chocobo1/libt2 
Disable deprecated settings in libtorrent 2.0
 2020-09-12 11:02:12 +08:00
Chocobo1
01603c1f62
Enable faster disk space allocation by default 
In libtorrent > 2.0, the setting is turned off by default, now we just
re-enable it to preserve the behavior as in earlier versions.
 2020-09-10 22:12:35 +08:00
Chocobo1
2fd69a21b0
Initialize session with session_params class 
The old way of initialization is deprecated in libtorrent 2.0.
 2020-09-09 16:16:08 +08:00
Chocobo1
554eab50bb
Disable deprecated libtorrent settings 2020-09-09 16:16:08 +08:00
Vladimir Golovnev
defdd5121c
Merge pull request #13340 from glassez/fix-magnet 
Improve adding torrent using Magnet URI
 2020-09-09 10:06:39 +03:00
Mike Tzou
c967bf31ff
Merge pull request #13336 from Chocobo1/webui 
Minor WebUI improvements
 2020-09-09 11:48:55 +08:00
Mike Tzou
6e971c47e7
Merge pull request #13319 from an0n666/tracker-queue 
Expose libtorrent max_concurrent_http_announces in advanced settings
 2020-09-09 11:48:25 +08:00
Vladimir Golovnev (Glassez)
20206ec92a
Improve adding torrent using Magnet URI 
Closes #13249.
 2020-09-08 14:56:38 +03:00
Chocobo1
2f1016494b
Specify UTF-8 charset when forming data from plain text 
This suppresses a browser warning about unspecified character encoding
of an HTTP response.
 2020-09-08 14:30:55 +08:00
an0n666
73b39a8dec Expose libtorrent max_concurrent_http_announces in advanced settings 2020-09-08 06:05:45 +06:00
Chocobo1
79bb8227d0
Migrate away from deprecated address::to_string(error_code) 
The other overload require users to handle exceptions themselves.
 2020-09-07 14:48:13 +08:00
Chocobo1
25a47dadeb
Migrate away from deprecated address::from_string() 2020-09-07 14:27:18 +08:00
Chocobo1
2a2ae2a566
Add helper function to convert to string from lt::socket_type_t type 2020-09-07 13:48:57 +08:00
FranciscoPombal
9b43d260a7 Fix GeoDB download in systems with non-C locales 
Closes #13318.
 2020-09-05 23:21:05 +01:00
Mike Tzou
3c6e6ae872
Merge pull request #13294 from Chocobo1/openFile 
Fix open path won't work correctly
 2020-08-30 11:28:46 +08:00
Chocobo1
307ca61c86
Code clean up 2020-08-29 19:56:05 +08:00
Sophist
4c37c229d9 Expose LibTorrent peer_turnover settings 
This PR exposes the LibTorrent Peer Turnover Settings in qBT Advanced Settings in order to allow users to adjust how frequently slow and uninteresting connections are closed to allow potentially better / faster connections to be made.

The default settings are to turnover peers when the number of connections is at least 90% of allowed global or per torrent connections, and to disconnect the least attractive 4% of these connections every 5 minutes.

See https://www.libtorrent.org/reference-Settings.html#peer_turnover
 2020-08-19 20:11:58 +01:00
ngosang
71be4f03be Update minimum Python version to 3.5.0 2020-08-18 20:56:39 +02:00
Vladimir Golovnev (Glassez)
b77568839d
Remove legacy/unused torrent property 2020-08-09 12:11:13 +03:00
Vladimir Golovnev (Glassez)
dc3d23c045
Improve torrent loading code 2020-08-09 12:11:07 +03:00
Vladimir Golovnev (Glassez)
eb99bfe20f
Remove deprecated and unused code 2020-08-05 08:27:14 +03:00
Mike Tzou
3a61042e40
Merge pull request #13206 from an0n666/revert-seed-mode-patch 
Read piece for torrents added with skip hash only for older libtorrent
 2020-08-03 19:56:37 +08:00
an0n666
dc211f69ac Read piece for torrents added with skip hash only for older libtorrent 2020-08-02 16:33:55 +06:00
Mike Tzou
a2a5c28c9f
Merge pull request #13188 from jagannatharjun/fix-speed 
Fix impossible speed in graph
 2020-07-30 11:20:03 +08:00
jagannatharjun
f1edda2c81 Only enqueue session refresh request once previous request is completed 
Fixes impossible speed in graph
 2020-07-29 10:00:56 +05:30
Vladimir Golovnev (Glassez)
bac7fbc68e
Notify user when torrent moving finished 2020-07-26 14:31:58 +03:00
Vladimir Golovnev (Glassez)
c3104e0210
Update torrent status on move enqueued 2020-07-22 15:22:29 +03:00
Vladimir Golovnev (Glassez)
d77c6321d3
Always allow to save resume data in checking state 2020-07-21 14:26:31 +03:00
Vladimir Golovnev (Glassez)
f35dbdfb8b
Fix crash on exit when compiled using MinGW 2020-07-21 13:56:07 +03:00
Vladimir Golovnev (Glassez)
cdc2b8d79b
Improve "move torrent storage" handling 2020-07-19 15:04:42 +03:00
FranciscoPombal
8f8f7ebd15 Remove DISABLE_COUNTRIES_RESOLUTION define 2020-07-08 01:07:50 +01:00
Chocobo1
8ebb6dc559
Initialize variable at better place 2020-06-26 17:17:29 +08:00
Chocobo1
40e432b127
Bump requirement to libtorrent 1.2 
Closes #12258.
 2020-06-26 17:17:29 +08:00
Vladimir Golovnev
06e1b07274
Merge pull request #13042 from FranciscoPombal/fix_request_parser 
Fix truncation when parsing HTTP request query
 2020-06-24 11:15:54 +03:00
FranciscoPombal
0fa7fca31e Fix truncation when parsing HTTP request query 
Closes #13029.

Fixes an issue with truncation of a QByteArray at the first '\0' byte
when parsing HTTP request query strings.

Previously, the operands of the ternary expression were of
different types. Most likely this was leading to a conversion
of the result to some kind of '\0'-terminated string type somewhere
along the way, in turn causing its truncation at the first '\0' byte
once converted back to QByteArray.

For some reason this bug was only present on Windows (MSVC).
 2020-06-23 11:45:30 +01:00
Vladimir Golovnev (Glassez)
b4f65ca080
Don't modify source URL when wait for download status 2020-06-19 12:16:31 +03:00
Vladimir Golovnev (Glassez)
1e86c76e8a
Emit signal when redirected to Magnet 2020-06-19 12:15:15 +03:00
Vladimir Golovnev (Glassez)
b28436c871
Find complete files when moving torrent storage 2020-06-12 12:58:17 +03:00
Vladimir Golovnev (Glassez)
6a0a78f3f7
Drop ".unwanted folder" feature 2020-06-10 11:35:09 +03:00
Mike Tzou
5ebe4e4c70
Merge pull request #12956 from arvidn/storage-include 
Correct libtorrent header include in torrentcreatorthread.cpp
 2020-06-07 20:17:59 +08:00
Mike Tzou
96f9a657f1
Merge pull request #12978 from arvidn/plugin-lt2-compat 
support changes to plugin API in libtorrent-2.0
 2020-06-07 11:39:08 +08:00
arvidn
d2cc01f65c Support changes to plugin API in libtorrent-2.0 
libtorrent-2.0 introduced a type-safe alternative to void* (lt::client_data_t)
for passing user-data into plugins. qBT doesn't use any user data in its
plugins, but the signatures have changed nevertheless, and qBT need to update to
be compatible with libtorrent-2.0.
 2020-06-06 10:58:07 +02:00
arvidn
af05990bc9 Fix libtorrent include to a more precise header 
torrentcreatorthread.cpp does not need to include libtorrent/storage.hpp, but
just needs libtorrent/file_storage.hpp. The former header is for implementing a
custom storage. Change include to libtorrent/file_storage.hpp
 2020-06-05 23:48:08 +02:00
Chocobo1
4971cb9a27
Don't use deprecated QAbstractSocket::error() 2020-06-04 20:20:50 +08:00
Chocobo1
9c330812cc
Don't use deprecated QSet::iterator::operator+(int) 2020-06-04 20:20:50 +08:00
Mike Tzou
788d2729db
Merge pull request #12877 from an0n666/private-torrents 
Address some issues regarding private torrents
 2020-05-30 19:29:02 +08:00
Mike Tzou
9d135441db
Merge pull request #12942 from Chocobo1/cacheCountry 
Cache country lookup result in PeerInfo class
 2020-05-30 12:36:15 +08:00
Vladimir Golovnev (Glassez)
a6ad95278c
Fix invalid assertion 
Closes #12938.
 2020-05-29 09:35:19 +03:00
Chocobo1
472dd96716
Cache country lookup result in PeerInfo class 
The country lookup happens quite often when "Resolve peer countries"
option is enabled.
 2020-05-29 13:49:52 +08:00
an0n666
6d85ae8f62 Address some issues regarding private torrents 2020-05-26 14:18:15 +06:00
Vladimir Golovnev (Glassez)
f4efa530dc
Create header for common BitTorrent declarations 2020-05-25 20:32:35 +03:00
Vladimir Golovnev (Glassez)
4a1e3de06d
Find complete files when checking torrent 2020-05-25 20:31:59 +03:00
Vladimir Golovnev
dde7421f59
Merge pull request #12848 from jagannatharjun/move-icons 
Move all icon resources in icons folder root
 2020-05-19 07:39:55 +03:00
jagannatharjun
ab91d546e5 Move all icon resources to icon folder root 2020-05-18 20:30:51 +05:30
Mike Tzou
774c0276f0
Merge pull request #12847 from Chocobo1/deprecated 
Don't use deprecated Qt function options
 2020-05-18 11:41:11 +08:00
Chocobo1
7c8846fc53
Don't use deprecated QRegularExpression option 
The following is the warning from compiler:
rss_item.cpp:70:79: warning: ‘QRegularExpression::OptimizeOnFirstUsageOption’ is deprecated: This option does not have any effect since Qt 5.12 [-Wdeprecated-declarations]
 2020-05-16 21:05:15 +08:00
Vladimir Golovnev
306499f7a8
Merge pull request #12843 from glassez/fix-rename-rule 
Fix renaming RSS autodownload rule
 2020-05-15 21:40:23 +03:00
Vladimir Golovnev (Glassez)
1b5dd0aa2d
Fix renaming RSS autodownload rule 2020-05-15 09:41:40 +03:00
Vladimir Golovnev
841536c9c5
Merge pull request #12805 from glassez/move-storage 
Wait for storage to be moved when removing torrent
 2020-05-12 07:34:45 +03:00
Chocobo1
be152f45c9
Define and use Http::HeaderMap type 2020-05-11 00:34:28 +08:00
Vladimir Golovnev (Glassez)
53fd0e1607
Wait for storage to be moved when removing torrent 2020-05-10 14:31:33 +03:00
Chocobo1
d57b9be706
Rename function 2020-05-10 02:53:32 +08:00
Chocobo1
74a2168bc1
Define and use a proper HTTP header structure 2020-05-10 02:53:11 +08:00
Vladimir Golovnev (Glassez)
378a863611
Remove unwanted files after torrent removed 2020-05-09 19:19:13 +03:00
Vladimir Golovnev (Glassez)
e49c554044
Improve "move torrent storage" queue 2020-05-09 19:19:13 +03:00
Vladimir Golovnev (Glassez)
b6bf09fc0f
Fix calculation of torrent current state 
Some actions can be performed despite of other states
(e.g. "Errored" torrent can check its files currently)
so the states that relate to such actions should override
other (so-called "static") states.
 2020-05-09 19:19:13 +03:00
Vladimir Golovnev (Glassez)
a8c333ff25
Drop "private" subfolders 
"private" subfolders violate the structure of the project,
since the existence of all other subfolders is based on a
different principle.
In addition, there is no clear line between "private" and
"non private".
 2020-05-08 14:59:18 +03:00
Vladimir Golovnev (Glassez)
642bf7b8a6
CMake: Don't split GUI code into several libraries 2020-05-01 17:03:00 +03:00
Mike Tzou
2aa80fe9ba
Merge pull request #12689 from thalieht/subfolder 
Rename "Create subfolder" option to "Keep subfolder"
 2020-05-01 14:09:17 +08:00
Chocobo1
5ca26516eb
Handle empty piece range properly 
Related: #12677.
 2020-04-30 13:18:57 +08:00
Chocobo1
f6eb341b32
Clean up code 2020-04-30 13:18:24 +08:00
Mike Tzou
4f820163ff
Merge pull request #12691 from Chocobo1/iterator 
Support range-based iteration in IndexRange class
 2020-04-30 13:10:13 +08:00
Mike Tzou
7061242681
Merge pull request #12176 from NotTsunami/ssl 
Add HTTPS tracker certificate validation option
 2020-04-30 13:09:31 +08:00
Chocobo1
6d167e9a28
Remove const from class variables 
It prohibits copy construction, copy assignment and move semantics.
 2020-04-29 21:32:34 +08:00
Chocobo1
21581141f6
Support range-based iteration in IndexRange class 2020-04-29 21:15:24 +08:00
thalieht
1bdffe1729 Rename "Create subfolder" to "Keep top-level folder" 
Closes #12673
 2020-04-29 03:09:38 +03:00
Mike Tzou
7bc572afb9
Merge pull request #12602 from Chocobo1/metatype 2020-04-24 22:13:27 +08:00
Vladimir Golovnev
4b897e7702
Merge pull request #12603 from glassez/fix-crash 
Fix crash when torrent is deleted on limit reached
 2020-04-24 07:45:35 +03:00
Vladimir Golovnev (Glassez)
22bda12d6c
Fix crash when torrent is deleted on limit reached 2020-04-23 16:56:53 +03:00
Chocobo1
9efd5eaed3
Register datatype properly 
Qt 5.9.5 doesn't seem to recognize it, this patch fixes it.
Fix up: d8401c76f5.
Related: #12601.
 2020-04-23 21:42:51 +08:00
Chocobo1
bb80b378c1
Add ability to send custom HTTP headers 2020-04-23 12:13:01 +08:00
NotTsunami
cc1ebbf379 Add HTTPS tracker certificate validation option 
This commit adds a new libtorrent setting to validate HTTPS tracker
certificates. When enabled, libtorrent will validate the certificate
of HTTPS trackers against the system's certificate store. This option
is only enabled on libtorrent versions >= 1.2.6 and on non-Windows
systems, as OpenSSL does not use the system's certificate store on
Windows.
 2020-04-22 15:50:17 -04:00
sledgehammer999
f758b24486
Merge pull request #12487 from an0n666/no-localhost-on-invalid 
Use configured net interface even when it is missing
 2020-04-22 17:49:08 +03:00
an0n666
e3e5da7a71 Use configured net interface even when it is missing 2020-04-21 19:04:43 +06:00
Chocobo1
1b80890696
Reduce padding in class 
TorrentHandleImpl size is reduced from 768 bytes to 736 bytes.
CreateTorrentParams size didn't change.
Size numbers are from x64.
 2020-04-19 11:44:41 +08:00
Chocobo1
ac2d063add
Move initialization default values to header 2020-04-19 11:42:49 +08:00
Mike Tzou
30ce2dfdf3
Merge pull request #12530 from Chocobo1/logger 
Reduce padding in structure
 2020-04-19 10:17:18 +08:00
Mike Tzou
b06d44b242
Merge pull request #12526 from Chocobo1/pr_12162 
Change default upload slot choking limits
 2020-04-19 10:17:04 +08:00
Mike Tzou
349a07a443
Merge pull request #12531 from Chocobo1/final 
Add final specifier to classes
 2020-04-19 10:16:44 +08:00
sledgehammer999
a17b1f2b78
Use static_cast for explicit type conversions 2020-04-18 18:22:40 +03:00
Chocobo1
648d44d9b9
Reduce padding in structure 
Log::Msg originally takes 32 bytes, now shrinks to 24 bytes.
Log::Peer originally takes 40 bytes, now shrinks to 32 bytes.
 2020-04-18 18:33:46 +08:00
Chocobo1
d3d3f7dbb3
Add final specifier to classes 
This allow compilers to generate more efficient code.
 2020-04-17 13:18:40 +08:00
Vladimir Golovnev
2681093d27
Merge pull request #12513 from glassez/torrent-impl 
Split TorrentHandle interface and implementation
 2020-04-17 07:40:28 +03:00
Mike Tzou
a5fe96f793
Merge pull request #12458 from jagannatharjun/log 
Convert the Log widget to use custom View/Model
 2020-04-17 11:27:35 +08:00
Vladimir Golovnev (Glassez)
1132b84548
Split TorrentHandle interface and implementation 2020-04-16 20:22:26 +03:00
an0n666
ec6b249509
Change default upload slot choking limits 2020-04-16 23:46:48 +08:00
jagannatharjun
fd89717330 Convert the Log widget to use custom View/Model 
Co-authored-by: sledgehammer999 <hammered999@gmail.com>
 2020-04-15 22:18:00 +05:30
Mike Tzou
e030fc067b
Merge pull request #12422 from an0n666/increase-timeout 
Change default stop_tracker_timeout settings
 2020-04-15 11:44:29 +08:00
an0n666
1168387df0 Change default stop_tracker_timeout settings 2020-04-13 16:05:36 +06:00
Raif Atef
1549b782e6 Do not use 0.0.0.0 or [::] for outgoing interfaces 
Fixes #12443
 2020-04-12 08:41:18 +02:00
Mike Tzou
c25b3e623c
Merge pull request #12423 from an0n666/remove-strict-superseeding 
Remove deprecated strict super seeding mode from advanced settings
 2020-04-12 00:41:28 +08:00
Mike Tzou
43e5e242ff
Merge pull request #12450 from Chocobo1/noBuffer 
Avoid holding encoded resume data in memory
 2020-04-09 13:21:32 +08:00
Chocobo1
e7890fb727
Preallocate output buffer 2020-04-08 13:06:39 +08:00
Chocobo1
d476ae4f14
Fix header inclusion order 2020-04-08 11:58:12 +08:00
Vladimir Golovnev
eb0295197c
Merge pull request #12301 from jozsefsallai/master 
Better Python path detection on Windows
 2020-04-07 22:29:26 +03:00
Chocobo1
d8401c76f5
Avoid holding encoded resume data in memory 
Now it the encoded resume data will be streamed to file instead of a
temporary buffer holding the whole of it.
 2020-04-07 16:02:09 +08:00
Vladimir Golovnev
fe81633403
Merge pull request #12436 from glassez/fix-savepath 
Save "resume data" when torrent storage is moved
 2020-04-07 09:54:51 +03:00
an0n666
026aad2c04 Remove deprecated strict super seeding mode from advanced settings 2020-04-07 09:54:32 +06:00
Mike Tzou
f58f425175
Merge pull request #12430 from rwasef1830/add-outgoing-interfaces 
Fix outgoing interfaces not getting assigned in case addr is not null.
 2020-04-07 10:10:32 +08:00
Raif Atef
bf1c9e34d7 Fix outgoing interface is not getting assigned 
Assignment was missing in main branch of condition statement.
Closes https://github.com/qbittorrent/qBittorrent/issues/12421
 2020-04-06 14:45:44 +02:00
Vladimir Golovnev (Glassez)
0a8c2f75af
Save "resume data" when torrent storage is moved 2020-04-06 12:16:27 +03:00
Mike Tzou
26941a5b02
Merge pull request #12427 from Chocobo1/io 
Avoid inefficient behavior
 2020-04-06 12:13:30 +08:00
Mike Tzou
3021b99a50
Merge pull request #12420 from Chocobo1/locale 
Sort locale language list
 2020-04-06 12:12:50 +08:00
Mike Tzou
cc090c8e37
Merge pull request #12416 from NotTsunami/master 
Set disk cache size for older libtorrent versions
 2020-04-06 12:12:12 +08:00
Chocobo1
2fa6a7f6f5
Avoid inefficient behavior 
Since the class needs to be copy-constructible, there may be many
copies of an instance. So instead of writing to the device on every
destructor call, only flush buffer on the last destructor call.
 2020-04-06 01:04:12 +08:00
Chocobo1
5eaedb13e5
Sort locale language list 2020-04-05 19:21:37 +08:00
NotTsunami
e48612a703 Set disk cache size for older libtorrent versions 
Libtorrent versions older than 1.2.6 have a bug when setting disk
cache size to auto.

See 6c880159c9.
 2020-04-04 21:36:01 -04:00
Mike Tzou
a10cee0f2b
Merge pull request #12364 from Chocobo1/fileOutIter 
Avoid holding entire file in memory
 2020-04-04 11:07:59 +08:00
Chocobo1
9f281c2d25
Avoid holding entire file in memory 
Previously we need a file buffer that is as large as the file size and
this could be a problem when user has less free memory available or
having very large data. Now with the help of `FileOutputIterator`,
we can have a much smaller, fixed size immediate file buffer and also
the code looks nice with `lt::bencode()`.
 2020-04-03 18:27:13 +08:00
Chocobo1
17f608685d
Improve logging for errors 
This commit also allows the strings to be translated.
 2020-04-02 11:20:09 +08:00
József Sallai
f9564564f8 Detect python3 executable on Windows 2020-04-02 00:31:41 +03:00
Vladimir Golovnev
96c5af7ae9
Merge pull request #12363 from glassez/fix-unexpected-resume 
Fix unexpected torrent resume after app restart
 2020-04-01 20:20:44 +03:00
Vladimir Golovnev (Glassez)
8bd9a97f6f
Fix unexpected torrent resume after app restart 
Closes #12322.
 2020-04-01 18:01:18 +03:00
sledgehammer999
bbe5465ba6
Merge pull request #12317 from sledgehammer999/fix_broken_save_path 
Fix broken UNC paths in fastresumes on Windows
 2020-03-31 18:34:31 +03:00
sledgehammer999
13af503003
Fix broken UNC paths in fastresumes on Windows 
See #12245 and #12282
 2020-03-30 15:21:15 +03:00
Mike Tzou
59f99bb984
Merge pull request #12282 from Tester798/fix-12245 
Fix regression when fastresume contains network path
 2020-03-30 12:53:17 +08:00
Mike Tzou
8a8607bf93
Merge pull request #12175 from NotTsunami/upnp 
Add UPnP lease duration advanced option
 2020-03-29 12:29:10 +08:00
NotTsunami
6b4925d222 Add UPnP lease duration advanced option 
This is a new setting added that is pending addition to
libtorrent 1.2.6. This setting is important because some routers do
not support expiration times on port-maps and do not return an error
either, silently failing. The previous default of permanent leases is
retained.
 2020-03-28 00:32:32 -04:00
Mike Tzou
82c23e67a4
Merge pull request #12299 from Chocobo1/initialize 
Initialize struct variables
 2020-03-28 10:53:38 +08:00
Mike Tzou
c6e26f5dd0
Merge pull request #12232 from Chocobo1/warning 
Add logging for SOCKS5 proxy errors
 2020-03-27 22:22:13 +08:00
Chocobo1
af430d6635
Initialize struct variables 
clang static analyzer was emitting some warning about uninitialized
variable usage and this patch fixes it.
 2020-03-27 16:01:01 +08:00
Mike Tzou
c0b0c6dcfc
Merge pull request #12259 from Chocobo1/dtor 
Rely on Qt ownership to free resources
 2020-03-27 01:06:39 +08:00
Tester798
1c6b4c0a79 Fix regression when fastresume contains network path 
Closes #12245 after regression was introduced in #11785.
 2020-03-26 18:54:13 +02:00
Chocobo1
54a685e953
Add logging for SOCKS5 proxy errors 2020-03-26 21:51:05 +08:00
Chocobo1
9630e7b689
Rely on Qt ownership to free resources 
The m_reply has already changed parent in
DownloadHandlerImpl::assignNetworkReply() and thus we can rely on Qt
ownership to delete the object.
 2020-03-26 14:39:18 +08:00
Chocobo1
7de8a4d6e0
Construct QString more efficiently 2020-03-25 12:00:11 +08:00
Chocobo1
2c23840947
Allow to translate error messages 2020-03-25 12:00:11 +08:00
Mike Tzou
ab30cfcdb0
Merge pull request #12207 from FranciscoPombal/fix-webapi 
WebAPI: fix matching uncategorized torrents
 2020-03-22 21:23:56 +08:00
FranciscoPombal
7d24e1c063 WebAPI: fix matching uncategorized torrents 
Closes #11748.
 2020-03-22 03:49:06 +00:00
Mike Tzou
f44f1ffc97
Merge pull request #12206 from thalieht/monitoredTMM 
Disable Auto TMM when not using default savepath from monitored folder
 2020-03-21 12:23:40 +08:00
thalieht
598c856c88 Disable Auto TMM when not using default savepath from monitored folder 2020-03-19 21:13:44 +02:00
Vladimir Golovnev
c323f64c96
Merge pull request #12188 from thalieht/queuemove 
Append new move storage job to queue
 2020-03-17 07:18:27 +03:00
thalieht
18289f2395 Append new move storage job to queue 
fixup e4ff206e3c
 2020-03-16 22:39:31 +02:00
Chocobo1
6c307774f1
Get library version strings at runtime 
We mostly use boost in header-only mode, so it is a non-trivial job to
get the version string at runtime.
 2020-03-16 21:27:42 +08:00
Vladimir Golovnev
5127156ba4
Merge pull request #12035 from glassez/move-storage 
Move torrent storages one by one
 2020-03-13 15:59:05 +03:00
Mike Tzou
dc4e9e3779
Merge pull request #11813 from Chocobo1/python 
Drop python2 support
 2020-03-07 10:18:45 +08:00
Mike Tzou
73ee901c45
Merge pull request #12113 from Chocobo1/smart_ptr 
Use helper functions to construct smart pointers
 2020-03-06 13:12:41 +08:00
Chocobo1
290d198977
Use proper type for piece index 2020-03-06 01:47:28 +08:00
Chocobo1
2157e500ef
Use helper functions to construct smart pointers 2020-03-05 19:32:28 +08:00
Mike Tzou
ca01b049a6
Merge pull request #12108 from Chocobo1/bits 
Avoid unnecessary memory writes
 2020-03-04 23:50:12 +08:00
Mike Tzou
949daf6c73
Merge pull request #12037 from an0n666/seed-mode-fix 
Check if file exists in seed mode
 2020-03-04 23:49:47 +08:00
an0n666
f7d2085b0a Check if file exists in seed mode 2020-03-04 17:38:00 +06:00
Chocobo1
24cd7c3611
Avoid unnecessary memory writes 
Before this change, qbt spent ~1% in these two functions, now it
only spends about ~0.5% in my naive testing.
 2020-03-04 03:18:39 +08:00
Vladimir Golovnev
b519ece18b
Merge pull request #12095 from glassez/resume-torrent 
Let libtorrent decide whether to resume a torrent
 2020-03-01 19:54:16 +03:00
Vladimir Golovnev (Glassez)
74884d57ec
Let libtorrent decide whether to resume a torrent 2020-03-01 08:08:01 +03:00
Mike Tzou
9649c2a163
Merge pull request #12043 from FranciscoPombal/fix-embedded-tracker 
Fix embedded tracker
 2020-02-27 21:06:58 +08:00
Vladimir Golovnev
4d2943a782
Merge pull request #12033 from glassez/save-torrent 
Allow to save downloaded metadata as torrent file
 2020-02-27 08:49:40 +03:00
FranciscoPombal
966f891d91 Fix response to event=stopped 
BEP-3 says all tracker responses to valid announce requests should be bencoded dictionaries with at least the "peers" and "interval" keys; the "peers" key can be empty.

Also clarify support for BEP-21.
 2020-02-26 20:47:33 +00:00
FranciscoPombal
af6f63f82c Don't use IPv4-mapped IPv6 
Always register peers with either IPv4 or IPv6.
Fixes potential connection issues.

Also clarify related BEP-24 support.
 2020-02-26 20:44:09 +00:00
FranciscoPombal
abc69dfd20 Fix BEP-23 support 
The embedded tracker was returning a non-compliant response.
The peer lists should be packed strings instead of lists.

Also clarify level of compliance with BEP-7.
 2020-02-26 20:42:14 +00:00
FranciscoPombal
9f045500d1 Fix IPv6 endianness 2020-02-26 20:42:07 +00:00
Vladimir Golovnev (Glassez)
e4ff206e3c
Move torrent storages one by one 2020-02-26 10:20:04 +03:00
Vladimir Golovnev (Glassez)
dd0cee44c1
Allow to save downloaded metadata as torrent file 2020-02-26 08:10:11 +03:00
FranciscoPombal
dc6a56afcb Revert using random port by default 
Revert change introduced in https://github.com/qbittorrent/qBittorrent/pull/11637 and also revert the associated follow-up https://github.com/qbittorrent/qBittorrent/pull/12000.

Reason: https://github.com/arvidn/libtorrent/pull/4335
 2020-02-21 14:47:37 +00:00
sledgehammer999
193da7f2f9
Merge pull request #12014 from sledgehammer999/alt_IP_db_provider 
Use IP geolocation database by DB-IP instead of MaxMind
 2020-02-18 17:05:52 +02:00
sledgehammer999
ea1481beef
Use IP geolocation database by DB-IP instead of MaxMind 
Closes #11792
 2020-02-18 16:11:28 +02:00
Mike Tzou
bf6a88b3d2
Merge pull request #12021 from Chocobo1/trackerentry 
Simplify TrackerEntry::status() logic
 2020-02-18 02:22:05 +08:00
Chocobo1
e825473289
Simplify TrackerEntry::status() logic 2020-02-17 18:46:30 +08:00
sledgehammer999
322ae3e0bc
Merge pull request #11825 from FranciscoPombal/stalled_filter 
Add stalled filters to GUI and Web API/UI
 2020-02-16 18:32:37 +02:00
Mike Tzou
04132f6266
Merge pull request #11999 from an0n666/fix-not-contacted-tracker 
Do not list not contacted trackers as error
 2020-02-16 20:27:41 +08:00
an0n666
8423f43209 Do not list not contacted trackers as error 2020-02-15 19:44:14 +00:00
sledgehammer999
385d7247b7
Merge pull request #12016 from Chocobo1/errMsg 
Include resume folder path in exception message
 2020-02-15 19:41:39 +02:00
Vladimir Golovnev
362305f339
Merge pull request #12013 from glassez/fix-rss 
Don't access download handler after it's finished
 2020-02-15 07:02:59 +03:00
Mike Tzou
dbea2d95f9
Merge pull request #12004 from Chocobo1/authCount 
Add configurable ban options for WebUI
 2020-02-15 09:43:16 +08:00
Chocobo1
45c357dfe2
Include resume folder path in exception message 
The message in RuntimeError exception will be displayed to the users and
users would be clueless if we don't show the path.
 2020-02-15 02:48:55 +08:00
Chocobo1
6eb190c373
Expose WebUI ban duration to users 2020-02-14 16:23:30 +08:00
Vladimir Golovnev (Glassez)
3762514662
Don't access download handler after it's finished 2020-02-14 08:24:49 +03:00
Chocobo1
f88d6b2e55
Expose WebUI ban counter to users 2020-02-14 12:31:12 +08:00
Tester798
58711cbe7e Fix portable mode 
Try to fix portable mode bug. Closes #11706, #11178, #7765.
 2020-02-12 19:56:25 +02:00
Mike Tzou
316f34cbf5
Merge pull request #11994 from Chocobo1/profile 
Unify singleton pattern in Profile class
 2020-02-12 23:59:47 +08:00
Chocobo1
5de75eff05
Unify singleton pattern in Profile class 
1. Use unified function names `initInstance()` and `freeInstance()` and
make them public.
2. Add `freeInstance()` to avoid noise from memory leak detectors.
3. Let `instance()`return a pointer directly to avoid unnecessary
indirections when invoking functions.
 2020-02-11 15:30:59 +08:00
Vladimir Golovnev (Glassez)
8bb34482ea
Handle HTTP redirections manually 
Qt doesn't support Magnet protocol so we need to handle all redirections
manually to allow redirections to Magnet URIs.
 2020-02-11 09:31:42 +03:00
Chocobo1
baa13c044a
Drop python2 support 
Closes #11811.
 2020-02-08 12:36:45 +08:00
Chocobo1
a6cdba17f0
Fix singleton class ownership 
We shouldn't allow Qt parent ownership in here.
 2020-02-07 15:34:04 +08:00
NotTsunami
6748e8d787 Remove redundant null checks 
Attempting to delete a null pointer is a noop in C++.

Closes #2864.

[1] https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null
 2020-02-03 16:38:51 -05:00
Chocobo1
b2ab6c1858
Let ReverseResolution always return/emit a result 2020-01-30 19:24:18 +08:00
Chocobo1
a2ebd77eac
Manually abort lookup on class destruction 
Some lookup might take longer so instead of waiting them, we abort them
manually.
 2020-01-30 14:11:03 +08:00
Chocobo1
86e3d0d816
Improve ReverseResolution class 
* Use QHostAddress type for IP
* Avoid double lookup
* Use larger cache size
 2020-01-30 14:11:03 +08:00
Mike Tzou
11bea8d393
Merge pull request #11918 from thalieht/peerssameip 
Show any multiple connections from the same IP in peer list
 2020-01-30 12:59:17 +08:00
thalieht
5f415c292d Show any multiple connections from the same IP in peer list 
The uniqueness of peers is now determined by their
IP, port and connection type (uTP etc.) instead of just their IP
 2020-01-29 20:40:10 +02:00
Chocobo1
5905c085c6
Use systematic approach to generate hash 
The basic idea is to hash each class member and then mix them with xor
operation.
However the `seed` must be handled with care, it should only be
introduced once when mixing the hashes of each class member, otherwise
under some circumstances the `seed` might xor with itself and thus break
the intended effect.
 2020-01-27 18:14:27 +08:00
Chocobo1
1740f968df
Revise qHash function 
Instead of xor and narrowing the integers ourselves, now we let qHash()
from Qt do the job properly.
 2020-01-27 12:53:22 +08:00
Chocobo1
2b4490d8a7
Use faster hash function 
qHash(QString) will need to hash/loop through all the data while the new
code will only need one memcpy() and a few bit manipulations.
 2020-01-27 12:53:13 +08:00
Vladimir Golovnev
89e72b38ea
Merge pull request #11881 from glassez/extension 
Simplify torrent startup handling
 2020-01-22 06:11:33 +03:00
Vladimir Golovnev (Glassez)
f2285e1b63
Redesign torrent startup handling 2020-01-21 10:14:59 +03:00
Chocobo1
3fce1db2eb
Migrate away from deprecated settings 
Libtorrent has deprecated `upnp_ignore_nonrouters` in
https://github.com/arvidn/libtorrent/pull/4251
 2020-01-16 23:44:54 +08:00
Mike Tzou
146e8213a5
Merge pull request #11781 from FranciscoPombal/piece_extent_affinity 
Add piece_extent_affinity to AdvancedSettings
 2020-01-14 12:53:39 +08:00
FranciscoPombal
f4742a98c5 Add stalled filters to GUI and Web API/UI 
`/api/v2/torrents/info` can now take the following new values for the`filter` parameter: `stalled`, `stalled_uploading` and `stalled_downloading`.

Requires Web API version bump.

Closes #11787
 2020-01-13 11:41:37 +00:00
FranciscoPombal
ed96a07a75 Add piece_extent_affinity to AdvancedSettings 
Expose option in WebUI settings and WebAPI.

Requires WebAPI version bump.

Closes #11436.
 2020-01-13 00:11:29 +00:00
An0n
bf32e90c40 Change placement of stop tracker timeout 2020-01-09 19:01:05 +00:00
Mike Tzou
057860584c
Merge pull request #11834 from an0n666/an0n666-expose-stop-tracker-timeout 
Expose stop tracker timeout in Advanced Settings (GUI + WebUI)
 2020-01-08 17:30:21 +08:00
an0n666
3f223c3a45 Expose stop_tracker_timeout in advanced settings 2020-01-08 08:21:55 +00:00
sledgehammer999
02a027144b
Tracker is errored only if all local endpoints fail 
Closes #11691
 2020-01-05 17:59:54 +02:00
Vladimir Golovnev (Glassez)
f56f817c77
Save resume data after recheck 
Closes #11774.
 2020-01-01 14:29:58 +03:00
Mike Tzou
5c3c1e07df
Merge pull request #11739 from Chocobo1/qt5_14 
Migrate away from deprecated API in Qt 5.14
 2019-12-26 12:43:04 +08:00
Chocobo1
2422d81de1
Migrate away from deprecated API in Qt 5.14 2019-12-25 19:23:37 +08:00
Mike Tzou
fea39fbcf2
Merge pull request #11726 from FranciscoPombal/fix_#11724 
WebUI: Implement "Secure" flag for session cookie. Closes #11724
 2019-12-25 13:06:40 +08:00
Mike Tzou
c94417b589
Merge pull request #11637 from FranciscoPombal/new_defaults 
Change some settings defaults for better behaviour out of the box
 2019-12-24 12:27:11 +08:00
FranciscoPombal
691d5e5d89 WebUI: Implement "Secure" flag for session cookie 
Closes #11724.

Option is enabled by default for users using qBittorrent's built-in HTTPS capabilities. This flag will never be set if qBittorrent is using plain HTTP.

Users using HTTPS reverse proxies, like "qbt <-> (http) <-> proxy <-> (https) <-> user" should override the flag in the proxy in order to set it, if they wish to do so.
 2019-12-23 17:58:08 +00:00