mirrors/qBittorrent
1
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2025-01-10 00:57:24 +03:00
Code Issues Projects Releases Packages Wiki Activity
9568 commits 16 branches 245 tags 256 MiB
Commit graph

8393 commits

Author SHA1 Message Date
Mike Tzou
17c601e8b8
Merge pull request #10835 from Chocobo1/exec 
Avoid creating unnecessary event loops
 2019-06-22 11:24:20 +08:00
Mike Tzou
5e76f7d699
Merge pull request #10838 from Piccirello/webui-rename-char-encoding 
Fix WebUI encoding of special characters
 2019-06-22 11:23:44 +08:00
Prince Gupta
ece70daaa5 Fix CMake Windows compilation 2019-06-21 18:05:19 +05:30
Tom Piccirello
368fbd9e7d
Fix encoding of special characters 
Special characters would get html encoded (& -> &amp;). This has been tested against several payloads (e.g. <script>alert(0)</script>) to ensure it's not vulnerable to XSS.
 2019-06-20 22:15:32 -07:00
Chocobo1
11fdf91196
Suppress compiler warning 
The debug message is emitting a format mismatch warning.
Fixup 4880dc812c.

And add curly brackets to if statement.
 2019-06-21 00:32:12 +08:00
Chocobo1
88c3ffbef8
Avoid creating unnecessary event loops 
This is part 2.
 2019-06-20 11:42:54 +08:00
Chocobo1
e31c1ca780
Use functor based QMetaObject::invokeMethod 2019-06-20 11:36:38 +08:00
Chocobo1
4880dc812c
Use appropriate type 2019-06-19 18:52:24 +08:00
Chocobo1
516c968373
Support year unit in userFriendlyDuration() 2019-06-19 18:52:24 +08:00
Chocobo1
1de4c2497c
Fix wrong "Time Active" value displayed 
Closes #9612.
 2019-06-19 18:52:24 +08:00
Chocobo1
19f50a363d
Fix crash when removing phantom tags 
Normally a tag is stored in both session and torrent's fastresume.
A phantom tag is a tag that is stored in fastresume but not in
session.
This crash can occur when user resets his config file and choose
to remove tag from torrent.

Closes #10569.
 2019-06-19 18:52:24 +08:00
Chocobo1
e83019bdfa
Set wheel event to accepted only if we handle it 2019-06-19 18:52:24 +08:00
Chocobo1
a6c5a90630
Remove redundant variable 2019-06-19 18:52:24 +08:00
Chocobo1
3b015db77d
Add comparison operators for ProxyConfiguration 2019-06-19 18:52:24 +08:00
Chocobo1
623210df58
Improve handleFileErrorAlert error message 2019-06-19 18:52:23 +08:00
Mike Tzou
cfd02a4355
Merge pull request #10786 from Chocobo1/dialog 
Avoid creating unnecessary event loops
 2019-06-19 11:02:09 +08:00
Vladimir Golovnev (Glassez)
8e65317d61
Rename "fromNativePath" to "toUniformPath" 
Unlike "toNativePath" which name clearly reflects the function result
"fromNativePath" has no such clear meaning.
Since this function converts path into uniform format "toUniformPath"
is better name.
 2019-06-17 15:55:49 +03:00
Chocobo1
3748b995ff
Avoid creating unnecessary event loops 
The `exec()` method will create another event loop and transfer
control over there which might introduce unexpected bugs.
 2019-06-17 20:44:57 +08:00
Mike Tzou
206bb018dd
Merge pull request #10801 from Chocobo1/timeout 
Add WebAPI session timeout settings
 2019-06-17 00:18:01 +08:00
Mike Tzou
46d445d042
Merge pull request #10792 from Chocobo1/rename2 
Remove empty leftover folders after rename properly
 2019-06-16 12:22:22 +08:00
Chocobo1
a64f3bbc6a
Reorder if conditions slightly 2019-06-15 19:08:24 +08:00
Chocobo1
9893a415c0
Fix updated save path not saved for paused torrents 2019-06-15 19:08:23 +08:00
Chocobo1
7d860b6c24
Log save_resume_data_failed_alert 2019-06-15 19:08:23 +08:00
Chocobo1
4e87aebf55
Don't remove parent directories 
QDir::rmpath removes *all* parent directories while QDir::rmdir removes
the specified directory.
 2019-06-15 19:08:23 +08:00
Chocobo1
440860c4a9
Properly remove empty leftover folders after rename 
TorrentInfo::origFilePath will return the very original path from
.torrent file, not the most recent file path before the rename operation
and thus the code would not be working as we expected.
 2019-06-15 19:08:23 +08:00
Chocobo1
89124bdcc8
Add WebAPI session timeout settings 
Raise default timeout to 1 hour.
 2019-06-15 18:57:19 +08:00
silverqx
3e97793ef1
Focus behavior row in Options dialog 2019-06-13 17:31:54 +02:00
silverqx
4f4f435e76
Add zlib version to GUI & stackdump 2019-06-12 08:02:24 +02:00
Mike Tzou
3a0f0c2f58
Merge pull request #10769 from Chocobo1/rename 
Fix unable to rename folder on Windows. Closes #9151.
 2019-06-10 10:30:01 +08:00
Chocobo1
8191f1498a
Log file rename failed errors 2019-06-09 19:07:43 +08:00
Chocobo1
eabcae1018
Fix unable to rename folder on Windows 
The bug occurs when the new path and old path only differ by letter case.
 2019-06-09 19:07:43 +08:00
Chocobo1
9c747d3c6d
Move renameSelectedFile(BitTorrent::TorrentInfo &) 2019-06-09 19:07:43 +08:00
Chocobo1
62ccfd37b2
Move renameSelectedFile(BitTorrent::TorrentHandle *) 2019-06-09 19:07:43 +08:00
Chocobo1
5b9ff4a015
Avoid double lookup 2019-06-09 18:56:52 +08:00
Mike Tzou
63b0a5b78c
Merge pull request #10775 from Chocobo1/speed 
Misc. improvements
 2019-06-09 01:57:20 +08:00
Mike Tzou
370544764e
Merge pull request #10750 from Chocobo1/modal 
Fix unable to control add torrent dialogs when opened simultaneously
 2019-06-06 23:16:35 +08:00
Mike Tzou
f3c0cc3cee
Merge pull request #10763 from Chocobo1/connect 
Use Qt5 connect syntax
 2019-06-06 10:18:46 +08:00
Mike Tzou
c95650c4f3
Merge pull request #10752 from thalieht/fw-declare 
Forward declare and remove some unused #include
 2019-06-06 10:18:26 +08:00
Chocobo1
431e7179ac
Remove redundant variable 2019-06-06 00:20:57 +08:00
Chocobo1
fbd5699786
Use switch statement 2019-06-06 00:15:09 +08:00
Chocobo1
e071c31a4e
Use Qt5 connect syntax 2019-06-05 14:17:44 +08:00
Chocobo1
dc9d0ed76f
Fix unable to control add torrent dialogs when opened simultaneously 2019-06-05 13:24:49 +08:00
Chocobo1
03fdc0e1c4
Remove redundant disconnect() 
The dialog is going out-of-scope in these instance and the signal-slot connection will disconnect
automatically.
 2019-06-05 13:22:50 +08:00
Chocobo1
014273d7ec
Drop support for "BC Link" format 
Fixup 19d6de795c.
 2019-06-05 00:42:46 +08:00
thalieht
70f8882f87 Group Qt forward declarations separately from the others 2019-06-04 17:48:55 +03:00
thalieht
9995967fbf Remove some unused #include 2019-06-04 17:48:55 +03:00
thalieht
4370a7eb12 Forward declare in a few places 2019-06-04 17:48:55 +03:00
Vladimir Golovnev
6f6033cf1c
Merge pull request #10754 from glassez/fix-magnet 
Disable "Upload mode" when start preloaded torrent. Closes #10751
 2019-06-04 10:56:11 +03:00
Vladimir Golovnev (Glassez)
b644d6685f
Disable "Upload mode" when start preloaded torrent 2019-06-04 07:14:21 +03:00
Vladimir Golovnev (Glassez)
4ae4ae3cfc
Fix wrong indentation 2019-06-04 06:55:45 +03:00
Vladimir Golovnev (Glassez)
2c145fa57c
Fix incorrectly set torrent startup flag 2019-06-04 06:53:17 +03:00
Mike Tzou
b8e205c048
Merge pull request #10741 from Chocobo1/limit 
Fix speed limit not applying to IPv6 peers
 2019-06-04 11:09:16 +08:00
Vladimir Golovnev
ecb4a76db7
Merge pull request #10742 from glassez/fix-rss 
Ignore RSS articles with non-unique identifiers
 2019-06-03 17:26:57 +03:00
Vladimir Golovnev (Glassez)
68ee071331
Ignore RSS articles with non-unique identifiers 2019-06-02 13:30:00 +03:00
Vladimir Golovnev (Glassez)
d710bbd9ef
Perform more RSS parsing in working thread 2019-06-02 13:29:41 +03:00
Chocobo1
411b956009
Fix speed limit not applying to IPv6 peers 
`TORRENT_USE_IPV6` is not used by libtorrent 1.2 anymore.
 2019-06-02 15:00:27 +08:00
Mike Tzou
4d92c7e094
Merge pull request #10737 from Chocobo1/time 
Use timestamp from alert
 2019-06-02 09:40:45 +08:00
Mike Tzou
87dcbbbd23
Merge pull request #10734 from Chocobo1/folder 
Use native folder icon in content tree
 2019-06-02 09:40:17 +08:00
Chocobo1
3f2ce8a2b7
Remove unused stats_alert handler 
Fixup 0fe9cd05c4.
 2019-06-01 11:43:00 +08:00
Chocobo1
39830986c2
Use alert's timestamp 
This way has better accuracy than running our own timer.
 2019-06-01 11:40:23 +08:00
Chocobo1
f52dcc08eb
Use native folder icon in content tree 
This icon is used in content tree where all icons should be OS native
and not the ones from qbt.
 2019-06-01 10:00:42 +08:00
Chocobo1
49df1cd3c7
Use less operations when building strings 2019-05-31 14:52:08 +08:00
Chocobo1
0fe9cd05c4
Avoid using deprecated stats_alert 
From libtorrent doc:
This alert has been superseded by calling post_torrent_updates() regularly on the session object.
 2019-05-31 10:58:23 +08:00
Mike Tzou
db88c2d6a5
Merge pull request #10721 from Chocobo1/sort 
Fix wrong comparison result
 2019-05-31 10:50:55 +08:00
Mike Tzou
683196f916
Merge pull request #10720 from Chocobo1/arrow 
Fix arrow too large on macOS
 2019-05-31 10:50:29 +08:00
Mike Tzou
bb3634c382
Merge pull request #10711 from Chocobo1/alert 
Log performance alerts from libtorrent
 2019-05-31 10:50:03 +08:00
Vladimir Golovnev (Glassez)
05fd0b5859
Fix sequential downloading when redirected 2019-05-29 15:50:02 +03:00
Chocobo1
36cf689432
Fix wrong comparison result 
The QString::toInt() might overflow when the string is long.

Closes #10706.
 2019-05-29 00:03:04 +08:00
Chocobo1
0d9fcb0c1d
Fix arrow too large on macOS 
By changing to use natvie UI tree controls.

Closes #10709.
 2019-05-28 22:35:22 +08:00
Chocobo1
45bafab4e0
Log performance alerts from libtorrent 2019-05-27 14:46:33 +08:00
Chocobo1
9232dd30dc
Sort function declarations 2019-05-27 09:29:59 +08:00
Mike Tzou
c5430030e3
Merge pull request #10690 from Chocobo1/rtl 
Various visual tweaks
 2019-05-26 09:23:22 +08:00
Chocobo1
1b0ffd7781
Fix wrong logic 
The error is caused by silly copy-paste error.
Fixup 09ff735007.
 2019-05-25 14:55:27 +08:00
Mike Tzou
485fdf910e
Merge pull request #10637 from Chocobo1/ngen3 
Use newer libtorrent API (part 3)
 2019-05-25 14:50:59 +08:00
Chocobo1
09ff735007
Use newer libtorrent API 
This commit covers trackerentry.cpp only.
 2019-05-25 11:22:57 +08:00
Mike Tzou
ebdf5225a8
Merge pull request #10684 from jagannatharjun/arrow-transfercategory 
Replace CheckBox with Arrow in transferlistfilterswidget
 2019-05-25 11:21:06 +08:00
Chocobo1
ccbb4576b6
Tweak visuals in Options dialog 2019-05-23 21:27:50 +08:00
Chocobo1
d7afc91975
Avoid combo boxes extending to the right in Options dialog 2019-05-23 21:07:44 +08:00
Prince Gupta
e283026a3c Replace CheckBox with Arrow in transferlistfilterswidget.cpp 2019-05-22 21:08:04 +05:30
Chocobo1
1e029da5ad
Fix search icon placement when using RTL languages 2019-05-22 22:22:12 +08:00
Chocobo1
ed6bb0efdc
Replace QList by QVector for tracker related operations 2019-05-22 12:57:22 +08:00
Chocobo1
802af70e2f
Fix typos 2019-05-19 18:51:09 +08:00
Chocobo1
cb4c53c848
Follow the type used in libtorrent 2019-05-19 18:51:09 +08:00
Chocobo1
e92209475e
Use range-based for loops 2019-05-19 18:51:09 +08:00
Chocobo1
10e1c35998
Avoid unnecessary double lookup 2019-05-19 12:06:18 +08:00
Chocobo1
c75500670d
Use forwarding reference when passing function objects 
So instead of passing every function objects by value (a copy is made), now function objects
will be handled properly by reference (for lvalues) or by value (for rvalues).
 2019-05-19 12:06:18 +08:00
Chocobo1
6738cdd715
Constify exception references 2019-05-19 12:06:18 +08:00
Chocobo1
e288de7ec1
Forward declare as much as possible 2019-05-19 12:06:18 +08:00
Chocobo1
401bdbf3d9
Remove unused functions 2019-05-19 12:06:18 +08:00
Chocobo1
ff707ea5af
Change splitToViews() return type to QVector 2019-05-19 12:06:18 +08:00
Mike Tzou
3d6dccc689
Merge pull request #10627 from Chocobo1/alg 
Improve removeIf() to support other types
 2019-05-16 10:45:55 +08:00
Chocobo1
459cdf6071
Fix assertion fail 
When fileSize == 0, the second index could be smaller than the first index,
thus trigger the assert check in IndexInterval constructor.

Closes #10611.
 2019-05-15 10:22:21 +08:00
Evgeny Lensky
62c72091ce
Change "Add new torrent" dialog to horizontal layout 2019-05-14 11:03:56 +08:00
Chocobo1
c6f3da1097
Improve removeIf() to support set types 
We can now replace QMutable*Iterator by removeIf() which usage is more consistent with other
algorithm functions.
 2019-05-14 01:26:01 +08:00
Chocobo1
5aaf040300
Remove libtorrentfwd.h 2019-05-13 11:20:42 +08:00
Chocobo1
3955eef50d
Change to lt namespace 
Quoting from libtorrent doc:
> In the future, libtorrent will be the alias and lt the namespace name.
 2019-05-13 11:20:41 +08:00
Chocobo1
4b263f057d
Use newer libtorrent API 
This commit covers session.cpp only.
 2019-05-13 11:20:41 +08:00
Chocobo1
677a419f0b
Use upstream defined namespace 
`lt` namespace is defined since libtorrent 1.1.6 and our master branch requires >= 1.1.10,
so there is no need to add #if condition for it.
 2019-05-13 11:20:41 +08:00
Mike Tzou
6d73a7ef0a
Merge pull request #10618 from jerrymakesjelly/master 
Replace Bytes/s with KiB/s in the adding torrent dialogs in WebUI
 2019-05-12 13:50:46 +08:00
Vladimir Golovnev
af7d8f6a43
Merge pull request #10514 from Mataniko/rss-enclosure-type 
Download RSS "enclosure" element if no proper MIME type is found
 2019-05-11 13:31:46 +03:00
jerrymakesjelly
4b9f0a87cd Change the speed unit from Bytes/s to KiB/s 
Updated the adding torrent dialogs in WebUI. Closes #10017.
 2019-05-11 12:25:07 +08:00
Mike Tzou
ca0dad7356
Merge pull request #10590 from onlined/fix/close-system-tray-blank-screen 
Don't turn screen blank when closed to system tray
 2019-05-11 12:24:43 +08:00
Chocobo1
bd8d70bf60
Refactor HTTP query parsing 2019-05-09 12:41:30 +08:00
Chocobo1
69d29af097
Fix '+' char not decoded to space correctly 
Closes #10606.
 2019-05-09 11:17:41 +08:00
Matan Bareket
bd2d636bb5 Download RSS enclosure element if no proper MIME type is found 
In the case where an RSS feed doesn't have the "enclosure" element
with type "application/x-bittorrent", fallback to the last enclosure
element which has no "type" attribute.
 2019-05-08 13:46:13 -04:00
Mike Tzou
412b51fb3c
Merge pull request #10552 from CoryG89/webui-magnet-handler 
Register protocol handler in WebUI for magnet links
 2019-05-07 11:12:55 +08:00
Ekin Dursun
c0c2fe247b Don't turn screen blank when closed to system tray 
Closes #9240 and possibly #9121, as @zeule suggested here: https://github.com/qbittorrent/qBittorrent/issues/9240#issuecomment-408025722.
 2019-05-07 02:08:46 +03:00
Chocobo1
ae793b7395
Use upstream defined namespace alias 2019-05-06 20:26:15 +08:00
Chocobo1
56434fc8b9
Replace obsoleted QDateTime::fromTime_t() 2019-05-06 20:26:15 +08:00
Chocobo1
3f962ba336
Fix displaying invalid creation date 
The bug is only observed when using libtorrent 1.2.
 2019-05-06 20:26:14 +08:00
Chocobo1
3f10ac55a3
Migrate to update-to-date libtorrent functions 2019-05-06 20:26:14 +08:00
Cory
d49379789a Register protocol handler in WebUI for magnet links 2019-05-05 11:26:17 -07:00
Mike Tzou
3a3dec1707
Merge pull request #10445 from Chocobo1/crash 
Work around crashing in Qt networking library
 2019-05-03 22:54:25 +08:00
Chocobo1
8aa8b19f37
Fix "Create subfolder" option is not working in WebUI 
Closes #10392.
 2019-05-02 20:55:50 +08:00
Mike Tzou
2d7b833ae6
Merge pull request #10537 from Chocobo1/template 
Minor cleanups
 2019-05-01 23:51:23 +08:00
Chocobo1
aaed5f7fe0
Remove unused headers 2019-05-01 11:09:25 +08:00
Chocobo1
375de4f8a6
Replace QMap with QHash when sensible 2019-05-01 11:09:25 +08:00
Chocobo1
44e4a5b13a
Avoid performance penalty from type erasure 
On average the affected code path is 0.1% faster and the result binary
is 10 KB smaller.
 2019-05-01 11:09:25 +08:00
Mike Tzou
f9ac1d4cd5
Merge pull request #10518 from dzmat/more_graphs 
Add 12 hour and 24 hour speed graphs. Closes #9686
 2019-04-28 18:57:40 +08:00
dzmat
7de0f9abed Change number of time axis divisions from 5 to 6 for convenience 2019-04-22 00:15:13 +07:00
dzmat
0af17bf7e9 Add 12 hour and 24 hour speed graphs 2019-04-22 00:15:13 +07:00
Chocobo1
49b57904f9
Use a random number for WebUI cache busting 
Also fetch qbt version info via WebAPI properly.
 2019-04-18 12:31:23 +08:00
Chocobo1
d022457e0c
Use force refresh on WebUI logout 
Regardless of the cache header settings, the logout action should never be
allowed to load from cache.
 2019-04-17 20:17:26 +08:00
Chocobo1
6e1e7a45a1
Align WebUI login button to the right 2019-04-17 13:34:32 +08:00
Mike Tzou
18be4732b3
Merge pull request #10476 from Piccirello/webui-table-cell-hover 
Set title attribute for all WebUI table cells
 2019-04-17 13:13:45 +08:00
Thomas Piccirello
238ca03936 Set title attribute for all WebUI table cells 
Except the Progress Bar
 2019-04-15 22:44:28 -07:00
Mike Tzou
7db2d1b8cf
Merge pull request #10492 from Chocobo1/server 
Remove closed connections immediately
 2019-04-16 12:25:40 +08:00
Mike Tzou
c7f89f55d0
Merge pull request #10473 from Chocobo1/warning 
Fix unsafe type narrowing (MSVC C4267 warning)
 2019-04-16 12:23:30 +08:00
Chocobo1
a2a669572c
Use QSet for tracking server connections 
We don't need to maintain order between connections so QSet would be more suitable.
 2019-04-15 21:35:35 +08:00
Chocobo1
a35b6cc8dd
Remove closed connections immediately 
Previously it relied on a timer to drop dead connections but that proved to
be too slow when there is an incoming burst of connections.

Fixes #10487.
 2019-04-15 21:35:10 +08:00
Chocobo1
41773a5465
Fix unsafe type narrowing 
Appending the warning below:
qBittorrent\src\base/utils/version.h(176): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data
qBittorrent\src\base/utils/version.h(185): note: see reference to function template instantiation 'std::array<T,2> Utils::Version<T,2,2>::parseList<StringsList>(const StringsList &)' being compiled
        with
        [
            T=unsigned short,
            StringsList=QList<QByteArray>
        ]
 2019-04-15 20:23:26 +08:00
CzBiX
d254a98662 Always use index.html as default page 2019-04-13 18:41:29 +08:00
Mike Tzou
19dfec1e0a
Merge pull request #10464 from thalieht/torrent-size-limit 
Increase the download request size limit from 10 to 100 MiB
 2019-04-11 10:14:49 +08:00
thalieht
2f3b7642c2 Show user friendly size in error 2019-04-10 11:39:27 +03:00
thalieht
25102b9c5d Increase the download size limit to 100 MiB 2019-04-10 11:39:27 +03:00
Mike Tzou
460b73ebda
Merge pull request #10438 from Chocobo1/timer 
Work around the crash occurred in QTimer
 2019-04-09 13:53:48 +08:00
Mike Tzou
4a02922bfb
Merge pull request #10458 from Chocobo1/post 
Correctly handle '+' sign in x-www-form-urlencoded data
 2019-04-09 13:53:12 +08:00
Chocobo1
4bf4313862
Initialize class variable via constructor 2019-04-08 23:29:14 +08:00
Chocobo1
94aeeed95f
Work around the crash occurred in QTimer 
See Qt commit:
https://code.qt.io/cgit/qt/qtbase.git/commit/src/corelib/kernel/qtimer.cpp?id=a623fe8d2a60ff333d5779f877e3b20f0e141ff1

Fixes #9985.
 2019-04-07 15:13:33 +08:00
Chocobo1
d86a984e25
Correctly handle '+' sign in x-www-form-urlencoded data 
Fixes #10451.
 2019-04-07 13:58:16 +08:00
thalieht
371a090cec Rename "Prefer encryption" to "Allow encryption" 
Because it actually prefers non-encryption but allows it if requested.
 2019-04-05 14:18:49 +03:00
Chocobo1
1ea61db1fb
Disable downloading tracker favicons by default 
Workaround for a crash in Qt networking library, source:
https://github.com/qbittorrent/qBittorrent/issues/9667#issuecomment-464445025

Closes #9667.
 2019-04-05 13:54:40 +08:00
Mike Tzou
e499317695
Merge pull request #10396 from Chocobo1/webui 
Document current WebUI browser compatibility
 2019-03-26 13:02:14 +08:00
Chocobo1
7e99ce6d7f
Document current WebUI browser compatibility 2019-03-23 12:32:20 +08:00
thalieht
3731a3ea65 Make num enter key work the same as return in searchjobwidget 2019-03-22 20:01:48 +02:00
Vladimir Golovnev
6de02b0f2a
Merge pull request #10373 from glassez/libtorrent-1.2 
Add preliminary support of libtorrent v1.2
 2019-03-19 06:08:22 +03:00
Vladimir Golovnev (Glassez)
ead078a38e
Add preliminary support of libtorrent v1.2 
libtorrent v1.2 should be built with deprecated features enabled.
 2019-03-18 15:17:03 +03:00
sledgehammer999
f403fdb2e8
Remove wrong ifdef 2019-03-17 14:15:50 +02:00
Mike Tzou
20f2c86d25
Merge pull request #10214 from AceLewis/master 
Remove autocorrect/autocapitalise in WebUI
 2019-03-17 15:05:19 +08:00
Mike Tzou
d1b0c230ed
Merge pull request #10366 from Chocobo1/logger 
Avoid performance penalty when logger is full
 2019-03-17 15:04:53 +08:00