Ignore RSS articles with non-unique identifiers

This commit is contained in:
Vladimir Golovnev (Glassez) 2019-06-02 13:30:00 +03:00
parent d710bbd9ef
commit 68ee071331
No known key found for this signature in database
GPG key ID: 52A2C7DEE2DFA6F7
2 changed files with 19 additions and 2 deletions

View file

@ -583,6 +583,7 @@ void Parser::parse_impl(const QByteArray &feedData)
emit finished(m_result);
m_result.articles.clear(); // clear articles only
m_articleIDs.clear();
}
void Parser::parseRssArticle(QXmlStreamReader &xml)
@ -774,6 +775,20 @@ void Parser::addArticle(QVariantHash article)
if (localId.toString().isEmpty())
localId = article.value(Article::KeyTitle);
if (!localId.toString().isEmpty())
m_result.articles.prepend(article);
if (localId.toString().isEmpty()) {
// The article could not be uniquely identified
// since it has no appropriate data.
// Just ignore it.
return;
}
if (m_articleIDs.contains(localId.toString())) {
// The article could not be uniquely identified
// since the Feed has duplicate identifiers.
// Just ignore it.
return;
}
m_articleIDs.insert(localId.toString());
m_result.articles.prepend(article);
}

View file

@ -31,6 +31,7 @@
#include <QList>
#include <QObject>
#include <QSet>
#include <QString>
#include <QVariantHash>
@ -69,6 +70,7 @@ namespace RSS
QString m_baseUrl;
ParsingResult m_result;
QSet<QString> m_articleIDs;
};
}
}