Commit graph

6011 commits

Author SHA1 Message Date
Andy Scherzinger
76b708489c
Merge pull request #2643 from nextcloud/dependabot/gradle/net.zetetic-android-database-sqlcipher-4.5.3
Bump android-database-sqlcipher from 4.5.2 to 4.5.3
2022-12-21 10:43:46 +01:00
dependabot[bot]
150c5f846f
Bump android-database-sqlcipher from 4.5.2 to 4.5.3
Bumps [android-database-sqlcipher](https://github.com/sqlcipher/android-database-sqlcipher) from 4.5.2 to 4.5.3.
- [Release notes](https://github.com/sqlcipher/android-database-sqlcipher/releases)
- [Commits](https://github.com/sqlcipher/android-database-sqlcipher/compare/v4.5.2...v4.5.3)

---
updated-dependencies:
- dependency-name: net.zetetic:android-database-sqlcipher
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-12-21 09:36:48 +00:00
Nextcloud bot
e8711dfdc4
Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-21 03:54:32 +00:00
Nextcloud bot
400858dee5
Fix(l10n): 🛠️ Update Transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-21 03:54:09 +00:00
Nextcloud bot
bd4484a486
Fix(l10n): 🔠 Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-20 11:13:10 +00:00
Nextcloud bot
7f2d8bcbd9
Fix(l10n): 🛠️ Update Transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-20 11:12:50 +00:00
Andy Scherzinger
536a9bdf36
Merge pull request #2641 from nextcloud/dependabot/github_actions/cirrus-actions/rebase-1.8
Bump cirrus-actions/rebase from 1.7 to 1.8
2022-12-20 08:48:12 +01:00
Andy Scherzinger
34765bc61a
Merge pull request #2642 from nextcloud/dependabot/github_actions/ossf/scorecard-action-2.1.1
Bump ossf/scorecard-action from 2.0.6 to 2.1.1
2022-12-20 08:47:49 +01:00
Nextcloud bot
62079df94e
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-20 03:38:36 +00:00
Nextcloud bot
02c51c5032
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-20 03:38:25 +00:00
dependabot[bot]
6c017f90a9
Bump ossf/scorecard-action from 2.0.6 to 2.1.1
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.0.6 to 2.1.1.
- [Release notes](https://github.com/ossf/scorecard-action/releases)
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md)
- [Commits](99c53751e0...15c10fcf1c)

---
updated-dependencies:
- dependency-name: ossf/scorecard-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-12-19 23:04:33 +00:00
dependabot[bot]
384940817d
Bump cirrus-actions/rebase from 1.7 to 1.8
Bumps [cirrus-actions/rebase](https://github.com/cirrus-actions/rebase) from 1.7 to 1.8.
- [Release notes](https://github.com/cirrus-actions/rebase/releases)
- [Commits](6e572f08c2...b87d48154a)

---
updated-dependencies:
- dependency-name: cirrus-actions/rebase
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2022-12-19 23:04:27 +00:00
Andy Scherzinger
33dd8fb7cb
Merge pull request #2639 from nextcloud/fix/2638/wrong-dateutils-injection
RepositoryModule: fix wrong injection for dateUtils
2022-12-19 18:13:42 +01:00
Álvaro Brey
8bc5735751
RepositoryModule: fix wrong injection for dateUtils
The module class is not supposed to have things injected into it. @Provides-annotated methods
will have their parameters injected, instead.

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-12-19 17:35:19 +01:00
Marcel Hibbe
349844391e
Merge pull request #2635 from nextcloud/chore/noid/spotbugsBadPractice
Spotbugs: fix all bad practice warnings
2022-12-19 13:42:37 +01:00
Andy Scherzinger
54b1427471
Implement closing for file input/output streams
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-12-19 09:37:06 +01:00
Andy Scherzinger
ae6b7156c0
Implement hasCode based on equals() elements to fullfil hasCode/equals contract
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-12-19 09:37:01 +01:00
Andy Scherzinger
35fec87aaa
Merge pull request #2637 from nextcloud/chore/changelog1503
Add 15.0.3 changelog
2022-12-19 09:35:53 +01:00
Andy Scherzinger
0de79bab75
Added 15.0.3
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-12-19 09:35:06 +01:00
Nextcloud bot
a4dabd1fed
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-19 03:41:01 +00:00
Nextcloud bot
7670a88d51
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-19 03:40:49 +00:00
Nextcloud Android Bot
7b91dfa41f Weekly 15.2.0 Alpha 02 2022-12-19 03:11:46 +00:00
Nextcloud bot
3b964670c4
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-18 03:33:25 +00:00
Nextcloud bot
9974ed59d5
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-18 03:33:13 +00:00
Nextcloud bot
27fa92b7ff
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-17 03:34:28 +00:00
Nextcloud bot
62d6a1793f
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-17 03:34:16 +00:00
Andy Scherzinger
dfc36e49c6
Merge pull request #2636 from nextcloud/increase-version-to-15.2
Bump version to 15.2
2022-12-16 18:21:08 +01:00
Nextcloud bot
d8d3847d89
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-16 15:05:34 +00:00
Nextcloud bot
6aede24349
[tx-robot] Update transifex configuration
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-12-16 15:05:20 +00:00
Tim Krüger
b71bc9867a
Bump version to 15.2
Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-12-16 15:57:57 +01:00
Andy Scherzinger
46687a2f75
Merge pull request #2634 from nextcloud/chore/noid/ghActionHashes
Add hashes to github action versions
2022-12-16 15:47:03 +01:00
Álvaro Brey
9d341c2c19
Pin remaining vactions
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-12-16 15:13:55 +01:00
Andy Scherzinger
0f89f5f477
add hashes to github action versions
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-12-16 15:01:10 +01:00
Andy Scherzinger
0df576ba07
Merge pull request #2632 from nextcloud/repo-sync/android-config/master
🔄 Synced file(s) with nextcloud/android-config
2022-12-16 11:46:49 +01:00
nextcloud-android-bot
b8bf158e56 🔄 Synced local '.github/workflows/' with remote 'config/workflows/'
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2022-12-16 09:37:19 +00:00
Tim Krüger
69827575c7
Merge pull request #2621 from nextcloud/dependabot/gradle/com.google.firebase-firebase-messaging-23.1.1
Bump firebase-messaging from 23.1.0 to 23.1.1
2022-12-16 10:03:52 +01:00
Andy Scherzinger
77c888fd91
Merge pull request #2581 from nextcloud/bugfix/2446/fixDisappearingAccounts
Bugfix/2446/fix disappearing accounts
2022-12-15 13:58:07 +01:00
Andy Scherzinger
20ad889206
remove unneeded class cast
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-12-15 13:23:06 +01:00
Andy Scherzinger
d858169668
prevent NPE
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-12-15 13:22:47 +01:00
Marcel Hibbe
eff4b912bd
fix Spot Bugs warning
Possible null pointer dereference in com.nextcloud.talk.utils.PushUtils.updatePushStateForUser(Map, User) due to return value of called method

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-12-15 13:11:42 +01:00
Marcel Hibbe
da8148a134
fix spotbug warning "PRMC: Possibly Redundant Method Calls"
PRMC: In class com.nextcloud.talk.utils.ssl.MagicKeyManager
In class com.nextcloud.talk.utils.ssl.MagicKeyManager
In method com.nextcloud.talk.utils.ssl.MagicKeyManager.chooseClientAlias(String[], Principal[], Socket)
At MagicKeyManager.java:[line 68]
Value getCurrentUser()Lio/reactivex/Maybe;
Method com.nextcloud.talk.utils.ssl.MagicKeyManager.chooseClientAlias(String[], Principal[], Socket) appears to call the same method on the same object redundantly

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-12-15 13:11:41 +01:00
Marcel Hibbe
e238c4c9e5
ensure that there is always a current user
this should also fix the app to start after it always crashed on startup because of https://github.com/nextcloud/talk-android/issues/2531

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-12-15 13:11:41 +01:00
Marcel Hibbe
dd155db6ab
rename method to update PushState for a user
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-12-15 13:11:41 +01:00
Álvaro Brey
a37f947eb9
PushUtils: update only pushState when updating users
This is to work around a race condition where this class would asynchronously overwrite other user attributes
with old values after a user switch.

Co-authored-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-12-15 13:11:40 +01:00
Álvaro Brey
2e2d4a9ca3
CurrentUserProviderImpl: ensure only one observer is set up for all threads
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-12-15 13:11:40 +01:00
Álvaro Brey
25dd46f95a
UsersDao: fix wrong attribute used in setUserAsActive
Co-authored-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-12-15 13:11:40 +01:00
Marcel Hibbe
962b1d4e3a
WIP. replace loop to set current state of users by single UPDATE query
i was able to see that the loop was somehow interrupted during debugging which caused two users to have current =true

this should avoid the problem with the loop.

anyway, this doesn't seem to solve the issue completely as i was able to reproduce it again with the new solution. so maybe there are still more methods/scenarios which can cause this.

additionally, i managed to have all users to have current =false with this new query (while switching accounts very fast and often in ChooseAccountDialogFragment..)

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-12-15 13:11:39 +01:00
Marcel Hibbe
f73d1c14fc
add logging and toasts if current user was null
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-12-15 13:11:39 +01:00
Marcel Hibbe
e9dbcc554a
set user.current by value from userAttributes
this should have no effect but it should ensure "current" is not falsely set to true if the method storeProfile will be used for more scenarios in the future.

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-12-15 13:11:39 +01:00
Marcel Hibbe
d4e545e67d
use setUserAsActive instead of userManager.disableAllUsersWithoutId
just refactoring for now. this doesn't solve the bug!

Problem that needs to be solved:
When adding a new Account (User), it is marked as "current", while for the other logged in users "current" must be unset (-> disabled).

The problem is, that for the old active user, "current" is not unset so there were multiple accounts marked as "current".

In the ChooseAccountDialogFragment, only one of the current accounts is shown at the top. Below the set status field, all accounts are listed that are not marked with "current". So as a result, there can be accounts hidden that were marked as "current".

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-12-15 13:11:35 +01:00