Andy Scherzinger
34f8bb5ab7
use fixed strings where possible to limit lint score bump
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-06-18 15:25:11 +02:00
Andy Scherzinger
cd44de757c
code reformatting
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-06-18 15:17:08 +02:00
Andy Scherzinger
08f5274af9
add cipher migration for version 4 of sqlcipher
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-06-18 14:44:45 +02:00
Tim Krüger
dedbe40cc0
Launch 'MagicBluetoothManager' independently
...
This change is needed to make the 'MagicBluetoothManager' startable
after the from Android SDK 31 introduced BLUETOOTH_CONNECT is granted by
the user.
Before this change the 'MagicBluetoothManager' was only started in
'MagicAudioManager#start'. Now the new method
'MagicAudioManager#startBluetoothManager' can be used to start the
'MagicBluetoothManager'.
This change is also a preperation to fix #1309 and #2114 .
See: #2132 , #1309 , #2124
Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-06-17 15:51:44 +02:00
Tim Krüger
4821b02729
Add Android build switch for checking bluetooth permissions
...
Refactored method 'hasPermission' to 'hasNoBluetoothPermission'. The new method
respect the in SKD 31 introduced permission BLUETOOTH_CONNECT. For older SDK
versions the permission BLUETOOTH will be used.
Additionaly make methods private which need bluetooth permissions and only
called locally. For public methods which need bluetooth permissions the method
'hasNoBluetoothPermission' is called to check them.
Also add suppress lint annotation for 'MissingPermission'.
From SDK 30 to SDK 31 the bluetooth related permissions changed and it
is suggested to add the attribute 'android:maxSdkVersion="30"' to the
legacy BLUETOOTH permission in the 'AndroidManifest.xml' [1]:
> For your legacy Bluetooth-related permission declarations, set
> android:maxSdkVersion to 30. This app compatibility step helps the system
> grant your app only the Bluetooth permissions that it needs when installed
> on devices that run Android 12 or higher.
This is explicitly not done here!
During runtime (on Android 12) while starting the 'MagicBluetoothManger' the
following part in 'android.bluetooth.BluetootHeadset' constructor will be
executed and results in the previous exception:
// Preserve legacy compatibility where apps were depending on
// registerStateChangeCallback() performing a permissions check which
// has been relaxed in modern platform versions
if (context.getApplicationInfo().targetSdkVersion <= Build.VERSION_CODES.R
&& context.checkSelfPermission(android.Manifest.permission.BLUETOOTH)
!= PackageManager.PERMISSION_GRANTED) {
throw new SecurityException("Need BLUETOOTH permission");
}
In the 'build.gradle' the 'targetSdkVersion 30' and 'compileSdkVersion 31' is
configured. Because the 'MagicBluetoothManager' checks for the 'targetSdkVersion'
instead of 'Build.VERSION.SDK_INT' also on a Android 12 (SDK 31) the 'BLUETOOTH'
permission is needed.
So the solution is to don't set `android:maxSdkVersion="30"' for the BLUETOOTH
permission and request the BLUETOOTH_CONNECT permission.
Resolves : #2132
See:
[1] https://web.archive.org/web/20220416121005/https://developer.android.com/guide/topics/connectivity/bluetooth/permissions#declare-android12-or-higher
Signed-off-by: Tim Krüger <t@timkrueger.me>
2022-06-17 15:51:44 +02:00
dependabot[bot]
a7751124a1
Bump android-database-sqlcipher from 3.5.9 to 4.5.1
...
Bumps [android-database-sqlcipher](https://github.com/sqlcipher/android-database-sqlcipher ) from 3.5.9 to 4.5.1.
- [Release notes](https://github.com/sqlcipher/android-database-sqlcipher/releases )
- [Commits](https://github.com/sqlcipher/android-database-sqlcipher/compare/v3.5.9...v4.5.1 )
---
updated-dependencies:
- dependency-name: net.zetetic:android-database-sqlcipher
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-06-17 13:47:36 +02:00
Andy Scherzinger
2b937f5f51
Merge pull request #2151 from nextcloud/repo-sync/android-common/master
...
🔄 Synced file(s) with nextcloud/android-common
2022-06-17 13:23:40 +02:00
nextcloud-android-bot
12e6862ccd
🔄 Synced local '.github/workflows/' with remote 'config/workflows/'
...
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2022-06-17 10:53:15 +00:00
Álvaro Brey
c9706089d6
Merge pull request #2145 from nextcloud/dependabot/gradle/okhttpVersion-4.10.0
...
Bump okhttpVersion from 4.9.3 to 4.10.0
2022-06-16 12:26:52 +02:00
Nextcloud bot
83fd3c85a8
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-16 04:16:12 +00:00
dependabot[bot]
3b996c43f7
Bump okhttpVersion from 4.9.3 to 4.10.0
...
Bumps `okhttpVersion` from 4.9.3 to 4.10.0.
Updates `okhttp` from 4.9.3 to 4.10.0
- [Release notes](https://github.com/square/okhttp/releases )
- [Changelog](https://github.com/square/okhttp/blob/master/CHANGELOG.md )
- [Commits](https://github.com/square/okhttp/compare/parent-4.9.3...parent-4.10.0 )
Updates `okhttp-urlconnection` from 4.9.3 to 4.10.0
- [Release notes](https://github.com/square/okhttp/releases )
- [Changelog](https://github.com/square/okhttp/blob/master/CHANGELOG.md )
- [Commits](https://github.com/square/okhttp/compare/parent-4.9.3...parent-4.10.0 )
Updates `logging-interceptor` from 4.9.3 to 4.10.0
- [Release notes](https://github.com/square/okhttp/releases )
- [Changelog](https://github.com/square/okhttp/blob/master/CHANGELOG.md )
- [Commits](https://github.com/square/okhttp/compare/parent-4.9.3...parent-4.10.0 )
---
updated-dependencies:
- dependency-name: com.squareup.okhttp3:okhttp
dependency-type: direct:production
update-type: version-update:semver-minor
- dependency-name: com.squareup.okhttp3:okhttp-urlconnection
dependency-type: direct:production
update-type: version-update:semver-minor
- dependency-name: com.squareup.okhttp3:logging-interceptor
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-06-16 01:06:55 +00:00
Marcel Hibbe
c9be148223
Merge pull request #2142 from nextcloud/bugfix/2123/continueWithoutUserStatus
...
fix to load conversation list (restricted user status)
2022-06-15 16:37:23 +02:00
Marcel Hibbe
c628c23557
fix to load conversation list (restricted user status)
...
when the user status app on server is restricted to only some groups, the capabilities for users that are excluded still contains the "user_status" capability.
For the android talk app, this caused that the conversations were not shown.
With this fix, the conversations will be loaded also if the "user_status" is mistakenly set. Additionally, the option to set the status will be hidden.
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
2022-06-15 13:45:53 +00:00
Andy Scherzinger
bb99161e63
Merge pull request #2149 from nextcloud/dependabot/gradle/com.bluelinelabs-conductor-3.1.5
...
Bump conductor from 3.1.4 to 3.1.5
2022-06-15 14:54:04 +02:00
Andy Scherzinger
7c360b5a93
Merge pull request #2147 from nextcloud/repo-sync/android-common/master
...
🔄 Synced file(s) with nextcloud/android-common
2022-06-15 14:43:33 +02:00
Nextcloud bot
7543e74d2f
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-15 04:19:02 +00:00
dependabot[bot]
43853e1896
Bump conductor from 3.1.4 to 3.1.5
...
Bumps [conductor](https://github.com/bluelinelabs/Conductor ) from 3.1.4 to 3.1.5.
- [Release notes](https://github.com/bluelinelabs/Conductor/releases )
- [Commits](https://github.com/bluelinelabs/Conductor/compare/3.1.4...3.1.5 )
---
updated-dependencies:
- dependency-name: com.bluelinelabs:conductor
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-06-15 01:09:14 +00:00
Álvaro Brey
bb7e82fbcb
Use custom permission for unfiltered broadcast receiver in CallActivity
...
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-06-14 15:51:04 +02:00
Nextcloud bot
67298a63e6
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-14 04:21:37 +00:00
nextcloud-android-bot
99a0002da8
🔄 Synced local '.github/workflows/' with remote 'config/workflows/'
...
Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
2022-06-13 11:42:51 +00:00
Nextcloud Android Bot
d0ea659845
Weekly 14.1.0 Alpha 09
2022-06-13 03:23:43 +00:00
Nextcloud bot
1419abd101
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-12 04:21:58 +00:00
Andy Scherzinger
99b3575b43
Merge pull request #2144 from nextcloud/feat/workflow-auto-update-command-rebase.yml
...
Updating command-rebase.yml workflow from template
2022-06-11 19:53:13 +02:00
Nextcloud bot
cd68ddb0ed
Updating command-rebase.yml workflow from template
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-11 15:42:34 +00:00
Andy Scherzinger
f1566e23a0
Merge pull request #2141 from nextcloud/chore/noid/bumpBuildToolsTo33
...
Bump buildToolsVersion from 32.0.0 to 33.0.0
2022-06-10 17:39:18 +02:00
Andy Scherzinger
c0100c5a16
bump buildToolsVersion from 32.0.0 to 33.0.0
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-06-10 13:33:34 +02:00
Andy Scherzinger
07c30f0993
Merge pull request #2140 from nextcloud/chore/noid/MimetypeCentralization
...
Centralize mime type definitions
2022-06-10 13:32:33 +02:00
Andy Scherzinger
dd129b4e6c
further centralize mimetype definitions
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-06-10 13:13:37 +02:00
Andy Scherzinger
444ff05cf5
centralize mime type definitions
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-06-09 21:02:31 +02:00
Andy Scherzinger
24fe07f561
Merge pull request #2137 from nextcloud/dependabot/gradle/org.jetbrains.kotlin-kotlin-gradle-plugin-1.7.0
...
Bump kotlin-gradle-plugin from 1.6.21 to 1.7.0
2022-06-09 21:01:17 +02:00
Álvaro Brey
49d2f40e3f
ProfileController: fix non-exhaustive when
...
Crashes Kotlin 1.7.0
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
2022-06-09 17:57:01 +00:00
dependabot[bot]
58febdd682
Bump kotlin-gradle-plugin from 1.6.21 to 1.7.0
...
Bumps [kotlin-gradle-plugin](https://github.com/JetBrains/kotlin ) from 1.6.21 to 1.7.0.
- [Release notes](https://github.com/JetBrains/kotlin/releases )
- [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md )
- [Commits](https://github.com/JetBrains/kotlin/commits )
---
updated-dependencies:
- dependency-name: org.jetbrains.kotlin:kotlin-gradle-plugin
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-06-09 17:57:01 +00:00
Andy Scherzinger
c6f8c60550
Merge pull request #2086 from nextcloud/chore/noid/RemoteBrowserMigration
...
Remote files browser migration
2022-06-09 15:40:14 +02:00
Tobias Kaminsky
dbd1cead87
Merge pull request #2138 from nextcloud/codeql
...
Create codeql.yml
2022-06-09 15:30:10 +02:00
Tobias Kaminsky
3c402cd381
Update .github/workflows/codeql.yml
...
Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-06-09 13:23:31 +02:00
Andy Scherzinger
3e99dc065b
improve code base from review comments
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-06-09 12:03:03 +02:00
Andy Scherzinger
3d0f154d7d
simplify worker call
...
Co-authored-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-06-09 12:03:03 +02:00
Tobias Kaminsky
b7a464713f
Create codeql.yml
2022-06-09 10:47:55 +02:00
Nextcloud bot
45c33de776
[tx-robot] updated from transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-06-09 04:25:53 +00:00
drone
8717314531
Drone: update Lint results to reflect reduced error/warning count [skip ci]
...
Signed-off-by: drone <drone@nextcloud.com>
2022-06-08 22:23:37 +00:00
Andy Scherzinger
8c9cf2e06f
remove unused string
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-06-09 00:19:29 +02:00
Andy Scherzinger
d96ca1eb67
block selection of encrypted files as well as files that are not allowed to be re-shared
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-06-09 00:18:27 +02:00
drone
472304c4a6
Drone: update Lint results to reflect reduced error/warning count [skip ci]
...
Signed-off-by: drone <drone@nextcloud.com>
2022-06-08 21:58:32 +00:00
Andy Scherzinger
d30653fc99
remove unused style after removing bottom sheet
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-06-08 23:53:41 +02:00
Andy Scherzinger
6bc007151a
make avatar buttons clickable min-sized for a11y
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-06-08 23:53:40 +02:00
drone
07620f3a65
Drone: update FindBugs results to reflect reduced error/warning count [skip ci]
...
Signed-off-by: drone <drone@nextcloud.com>
2022-06-08 21:47:21 +00:00
Andy Scherzinger
df61a4df87
replace share files remote item chooser with new implementation and remove any legacy implementation
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-06-08 23:40:09 +02:00
Andy Scherzinger
41694b64bb
fix copyright year in header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-06-08 18:16:37 +02:00
Andy Scherzinger
aa353f064f
fix selection on click for new implementation, move sorting dialog references to new sorting class references
...
... needs duplication of the layout file
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-06-08 18:15:39 +02:00
Andy Scherzinger
7f85a2f228
Rename ReadFilesystemOperation
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2022-06-08 18:15:39 +02:00