💻 Desktop sync client for Nextcloud
Find a file
Olivier Goffart f4495c5c80 ActivityListModel: fix possible crash in slotActivitiesReceived
Backtrace from the crash reporter:

Crash: EXCEPTION_ACCESS_VIOLATION_READ at 0x401
  File "moc_activitylistmo_M5OEXJ7XGJYTWT.cpp", line 92, in OCC::ActivityListModel::qt_static_metacall
  File "qobject.cpp", line 3730, in QMetaObject::activate
  File "moc_networkjobs_7AMNCW4BBANVRK.cpp", line 1342, in OCC::JsonApiJob::jsonReceived
  File "networkjobs.cpp", line 714, in OCC::JsonApiJob::finished
  File "abstractnetworkjob.cpp", line 207, in OCC::AbstractNetworkJob::slotFinished
  File "moc_abstractnetwor_PFI2TXGQHRE33H.cpp", line 98, in OCC::AbstractNetworkJob::qt_static_metacall
  File "qobject.cpp", line 3730, in QMetaObject::activate
  File "moc_qnetworkreply.cpp", line 367, in QNetworkReply::finished
  File "qnetworkreplyhttpimpl.cpp", line 2100, in QNetworkReplyHttpImplPrivate::finished
  File "qnetworkreplyhttpimpl.cpp", line 279, in QNetworkReplyHttpImpl::abort

My theory is that the AccountState stored in a property of the job was destroyed.
before the job timed out.
Therefore, the qobject_cast within the qvariant_cast would call the metaObject()
virtual function on a dangling pointer.

Fix it by storing a QPointer instead which will track the deletion.
2017-03-06 17:25:22 +01:00
admin Update windows docker file to use 2.3 OBS repo 2017-02-15 09:49:29 +01:00
binary@741b49156b shell/Windows: Update binaries to build 44 2017-01-18 13:34:02 +01:00
cmake NSIS: Don't display link on finish page 2017-03-06 15:40:10 +01:00
csync Fix the UNIT_TESTING build on Windows 2017-02-14 14:32:41 +01:00
doc Doc: For conflicts, the local file is renamed #5521 2017-02-10 12:50:35 +01:00
resources Added temporar icon for notifications. 2016-03-10 17:22:36 +01:00
shell_integration shell/Windows: Update binaries to build 44 2017-01-18 13:34:02 +01:00
src ActivityListModel: fix possible crash in slotActivitiesReceived 2017-03-06 17:25:22 +01:00
test Propagator: Fix finished signal of directory being emited twice and causing crash 2017-03-06 16:14:04 +01:00
theme Run optipng on existing non-mono state icons 2015-09-11 13:45:57 +02:00
translations [tx-robot] updated from transifex 2017-03-05 02:18:29 +01:00
.gitattributes git: fix entry in .gitattributes to not export binary dir. 2014-09-22 11:24:24 +02:00
.gitignore Add Dockerfile that allows cross compiling the client 2016-02-05 12:17:31 +01:00
.gitmodules Submodule: Use https path 2016-03-15 11:55:28 +01:00
.tag Export repo revision indicator 2012-10-12 14:44:21 +02:00
.travis.yml Travis coverity: Enforce Ubuntu 14.04 env, fix repo 2016-05-24 11:30:03 +02:00
ChangeLog 2.3.0 was released: Update version 2017-03-03 10:48:47 +01:00
client.qrc Added temporar icon for notifications. 2016-03-10 17:22:36 +01:00
CMakeLists.txt Fix the UNIT_TESTING build on Windows 2017-02-14 14:32:41 +01:00
config.h.in Add TestSyncEngine and TestSyncFileStatusTracker auto tests 2016-08-17 15:39:30 +02:00
CONTRIBUTING.md Minor build etc typos 2015-09-10 13:20:11 +05:45
COPYING Correct COPYING file from FSF website, rpmlint found an old address 2011-11-22 22:45:14 +01:00
COPYING.documentation Add doc cmake targets (HTML, PDF, QtHelp, CHM, man) 2012-11-25 00:38:47 +01:00
CPackOptions.cmake.in Mirall -> (Desktop) Client 2014-12-08 17:54:32 +01:00
issue_template.md Update issue_template.md 2017-01-20 16:00:50 +01:00
Jenkinsfile Modify Jenkinsfile for 2.3 2017-02-13 14:47:51 +01:00
mirall.desktop.in [tx-robot] updated from transifex 2017-03-05 02:18:29 +01:00
OWNCLOUD.cmake Minor build etc typos 2015-09-10 13:20:11 +05:45
OwnCloudCPack.cmake CPack: Use APPLICATION_SHORTNAME rather than APPLICATION_NAME 2015-07-16 14:38:59 +02:00
README.md updated link for documentation and added more info to osx build 2016-11-09 08:59:14 +01:00
sync-exclude.lst Ignoring "System Volume Information" 2017-01-16 19:11:56 +01:00
theme.qrc Add changes theme.qrc 2015-09-11 15:31:56 +02:00
VERSION.cmake 2.3.0 was released: Update version 2017-03-03 10:48:47 +01:00

ownCloud Desktop Client

Job State
client-build-matrix Build Status
client-test-matrix-linux-no-build Build Status
coverity_scan Build Status

Introduction

The ownCloud Desktop Client is a tool to synchronize files from ownCloud Server with your computer.

Download

Binary packages

Source code

The ownCloud Desktop Client is developed in Git. Since Git makes it easy to fork and improve the source code and to adapt it to your need, many copies can be found on the Internet, in particular on GitHub. However, the authoritative repository maintained by the developers is located at https://github.com/owncloud/client.

Building the source code

Building the Client in the ownCloud Desktop Client manual.

Maintainers and Contributors

The maintainers of this repository are:

ownCloud Desktop Client is developed by the ownCloud community and receives patches from a variety of authors.

Reporting issues and contributing

If you find any bugs or have any suggestion for improvement, please file an issue at https://github.com/owncloud/client/issues. Do not contact the authors directly by mail, as this increases the chance of your report being lost.

If you created a patch, please submit a Pull Request. For non-trivial patches, we need you to sign the Contributor Agreement before we can accept your patch.

If you want to contact us, e.g. before starting a more complex feature, you can join us at #owncloud-client-dev.

License

This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful, but
WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
for more details.