Claudio Cambra
f676979b29
Set placeholder image always as account action icon, as at app start there will not be a valid avatar to use ever
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-28 18:08:29 +01:00
Matthieu Gallien
444a116c96
Merge pull request #5474 from nextcloud/bugfix/dehydrateCfapiFiles
...
with cfapi when dehydrating files add missing flag
2023-02-28 14:14:51 +01:00
Matthieu Gallien
41dc09b9a2
with cfapi when dehydrating files add missing flag
...
CF_UPDATE_FLAG_DEHYDRATE is apparently needed to get dehydration to
always succeed
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-28 13:27:52 +01:00
Matthieu Gallien
a5d0d66925
Merge pull request #5451 from nextcloud/bugfix/connectNormalizedArgs
...
use new connect syntax
2023-02-28 13:27:22 +01:00
Matthieu Gallien
01ecb639ab
use new connect syntax
...
mainly done using clazy and old-style-connect check
close #5426
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-28 09:36:27 +01:00
Nextcloud bot
56b47870d7
Fix(l10n): 🔠 Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-28 03:45:48 +00:00
Nextcloud bot
d9d33b7c23
Fix(l10n): 🔠 Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-27 03:44:19 +00:00
Nextcloud bot
60a2bd002d
Fix(l10n): 🔠 Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-26 03:42:06 +00:00
Nextcloud bot
c05b0b13be
Fix(l10n): 🔠 Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-24 03:52:45 +00:00
Nextcloud bot
1335a98a5e
Fix(l10n): 🔠 Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-23 11:40:53 +00:00
Matthieu Gallien
206a7ef5a3
Merge pull request #5459 from nextcloud/bugfix/discover-blacklisted-folders
...
Always discover blacklisted folders to avoid data loss when modifying selectivesync list.
2023-02-23 12:36:57 +01:00
alex-z
5574ddb744
Always discover blacklisted folders locally, to avoid data loss of non-uploaded files when modifying selectivesync list.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-02-23 10:58:57 +01:00
Nextcloud bot
23bc404290
Fix(l10n): 🔠 Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-23 03:44:32 +00:00
Matthieu Gallien
73ae8a11c2
Merge pull request #5436 from nextcloud/ci/clangTidyChecksInitVariables
...
Ci/clang tidy checks init variables
2023-02-22 17:53:45 +01:00
Matthieu Gallien
151d17aed4
fix ignored return values in windows specific code
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-22 16:50:21 +01:00
Matthieu Gallien
5b2a691f4c
use of QStringLiteral() is invalid: QString() must be used
...
fix windows specific code compilation warnings
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-22 16:50:20 +01:00
Matthieu Gallien
c0549c5c03
fix issues reported by compiling windows code with clang-tidy
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-22 16:50:20 +01:00
Matthieu Gallien
c895359e6b
manually fix some variables without init values
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-22 16:50:20 +01:00
Matthieu Gallien
a4f8837233
do not use static_cast to downcast: can generate runtime issues
...
using a static_cast like this means that the compiler will not check the
validity of the cast
this could lead now or later to crash and other issues if the real type
is not the one in the cast
done with clang-tidy
run-clang-tidy -p build -header-filter='.*' -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,cppcoreguidelines-pro-type-static-cast-downcast' -fix
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-22 16:50:20 +01:00
Matthieu Gallien
011d668a23
modernize use auto
...
done with clang-tidy
run-clang-tidy -p build -header-filter='.*' -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,modernize-use-auto' -fix
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-22 16:50:20 +01:00
Matthieu Gallien
6df6c8d44c
sets clang-tidy configuration in cmake to get automatic checking
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-22 16:50:19 +01:00
Nextcloud bot
41a24b4971
Fix(l10n): 🔠 Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-22 15:12:55 +00:00
Nextcloud bot
616d7c1661
Fix(l10n): 🔠 Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-22 03:43:20 +00:00
Nextcloud bot
df19b79a69
Fix(l10n): 🔠 Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-21 13:22:50 +00:00
Matthieu Gallien
ee4b38277d
Merge pull request #5427 from nextcloud/rakekniven-patch-1
...
l10n: Added dot to end of sentence
2023-02-21 10:09:26 +01:00
rakekniven
c195513049
l10n: Added dot to end of sentence
...
Aligned end of sentences in about dialog.
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2023-02-21 08:51:10 +01:00
Nextcloud bot
7ef5ca81a7
Fix(l10n): 🔠 Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-21 03:42:21 +00:00
Matthieu Gallien
96dfa7add0
Merge pull request #5448 from nextcloud/bugfix/ignoreInvalidE2EMetadata
...
skip e2e encrypted files with empty filename in metadata
2023-02-20 18:49:33 +01:00
Matthieu Gallien
a8a5dfe6c6
skip e2e encrypted files with empty filename in metadata
...
we cannot decrypt a file without a name
for now we will ignore them
we should probably do much more for the user but I fail to see how to
generate errors from e2ee module
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-20 09:50:34 +01:00
Nextcloud bot
b99775bb23
Fix(l10n): 🔠 Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-20 03:41:31 +00:00
Nextcloud bot
f6901fa065
Fix(l10n): 🔠 Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-19 03:41:02 +00:00
Matthieu Gallien
ec7fd9542c
Merge pull request #5444 from nextcloud/bugfix/useProperUserIdForEditLocally
...
fix edit locally job not finding the user account: wrong user id
2023-02-17 11:21:56 +01:00
Matthieu Gallien
24fc49f99d
fix edit locally job not finding the user account: wrong user id
...
the only correct id for an user is Account::_davUser
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-17 09:47:06 +01:00
Nextcloud bot
8843ea7882
Fix(l10n): 🔠 Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-17 03:41:54 +00:00
Claudio Cambra
7deef8fce3
Merge pull request #5442 from nextcloud/bugfix/fix-share-load
...
Fix share dialog infinite loading
2023-02-16 13:47:32 +01:00
Claudio Cambra
89ebfcae8e
Try to initialise share manager again if we receive updated sharing permissions that would have previously prevented sharing
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-16 13:06:35 +01:00
Claudio Cambra
2fbdf1be8f
Simplify check for file record sharing permission
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-16 13:06:35 +01:00
Nextcloud bot
9bd5823bac
Fix(l10n): 🔠 Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-16 03:40:49 +00:00
allexzander
be0bd5e332
Merge pull request #5430 from nextcloud/rakekniven-patch-2
...
l10n: Fixed grammar
2023-02-15 22:35:58 +01:00
rakekniven
09a0fa7908
l10n: Fixed grammar
...
Reported at Transifex.
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2023-02-15 19:58:23 +01:00
Nextcloud bot
b2ce28d52e
Fix(l10n): 🔠 Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2023-02-15 03:40:36 +00:00
Claudio Cambra
ccedff3272
Merge pull request #5416 from nextcloud/bugfix/remove-account-crash
...
Clean up account creation and deletion code
2023-02-14 21:18:36 +01:00
Claudio Cambra
72fb279508
More accurately log what happens when deleteAppPassword is complete in Account
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-14 20:22:51 +01:00
Claudio Cambra
893adb8280
Remove unused slotDeleteAccount in AccountSettings
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-14 20:22:51 +01:00
Claudio Cambra
7084310a9f
Remove unused AccountState::writeToSettings
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-14 20:22:51 +01:00
Claudio Cambra
446bb29155
Avoid trying to delete keychain encryption data if there is no encryption data configured
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-14 20:22:51 +01:00
Claudio Cambra
2c17305864
Add sensitiveDataRemaining convenience method to clientsideencryption
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-14 20:22:51 +01:00
Claudio Cambra
e7c978551d
Make sure to return in checkAllSensitiveDataDeleted
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-14 20:22:51 +01:00
Claudio Cambra
4ded5e1b38
Don't early return in sensitive data deletion for clientsideencryption if the entries were never stored in keychain
...
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-14 20:22:51 +01:00
Claudio Cambra
8483a4553a
Merge pull request #5435 from nextcloud/bugfix/create-folders-settings-menu
...
Fix "Create new folder" menu entries in settings not working correctly on macOS
2023-02-14 20:13:11 +01:00