mirrors/nextcloud-desktop
1
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2024-12-21 05:13:04 +03:00
Code Issues Projects Releases Packages Wiki Activity
19859 commits 486 branches 258 tags 463 MiB
Commit graph

4116 commits

Author SHA1 Message Date
Claudio Cambra
9df47cf1cc
Simplify loop to write bytes to password 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-07-20 23:32:28 +08:00
Claudio Cambra
4c8007e461
Use std::array to store hash bytes 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-07-20 23:32:28 +08:00
Claudio Cambra
b404f1a546
Replace use of std::rand with improved C++11 random 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-07-20 23:32:28 +08:00
Claudio Cambra
f9ded784b5
Guarantee that the generated password for share will have all the types of characters needed to pass server check 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-07-20 23:32:28 +08:00
Claudio Cambra
32acf504cb
Simplify password generation in sharemodel 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-07-20 23:32:28 +08:00
Claudio Cambra
c4d1bdf46f
Generate better passwords for shares 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-07-20 23:32:27 +08:00
Claudio Cambra
d0e8e67c72
Track invalid input in ShareDetailsPage expireDateSpinBoxTextField 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-07-20 23:17:30 +08:00
Claudio Cambra
00ec93f031
Add ability for NCInputTextField to display red border when invalid input provided 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-07-20 23:17:29 +08:00
Claudio Cambra
da7d8c1f0a
Ensure the text for the expire date spin box is updated even in situations when the expire date is forced back down to the same one being currently held 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-07-20 23:17:29 +08:00
Claudio Cambra
aaeaad9918
Make sure to imperatively set text for spinbox textfield after user breaks binding by editing 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-07-20 23:17:29 +08:00
Claudio Cambra
e84a5dcb5f
Rename "moreMenu" ColumnLayout to "scrollContentsColumn" in ShareView, stop treating like menu which it used to be 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-07-20 23:17:29 +08:00
Dries Mys
55f27cdb96 Small coding improvements 
Signed-off-by: Dries Mys <dries.mys@my-dreams.be>
 2023-07-20 13:44:55 +02:00
Dries Mys
76376aa052 Set VFS PinState to Excluded for ignored files. 
Setting PinState to Excluded ensures the syncing icon is not shown for ignored items.
If the PinState is not set to Excluded, also all parent directories are shown as being synced, which is very inconvenient for the end user as it seems that some folder are never fully synced by Nextcloud which isn't the case.
As long as .lnk files are not converted to placeholder files, also set them to Excluded to hide the syncing icon.

Closes #5524
Closes #5594

Co-authored-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
Signed-off-by: Dries Mys <dries.mys@my-dreams.be>
 2023-07-20 13:44:55 +02:00
Claudio Cambra
d6125ca3a1 Swap folder nullness assert for return 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-07-18 15:49:17 +02:00
Claudio Cambra
c1b2e07e8c Compress share page tab button width and height when sharing API is disabled 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-07-18 15:49:17 +02:00
Claudio Cambra
bccdb0e8f7 Make swipeIndex properties readonly 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-07-18 15:49:17 +02:00
Claudio Cambra
98ec8ff302 Fix background of tabbar in file details page 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-07-18 15:49:17 +02:00
Claudio Cambra
3fda519050 Do not handle setting page to sharing page if sharing not available 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-07-18 15:49:17 +02:00
Claudio Cambra
ea5397865d Do not display sharing entry if sharing is not available on server 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-07-18 15:49:17 +02:00
Claudio Cambra
4bcff7d991 Set sharingAvailable property in FileDetails from Folder account capabilities 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-07-18 15:49:17 +02:00
Claudio Cambra
38d82dfb5f Add sharingAvailable property to FileDetails class 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-07-18 15:49:17 +02:00
alex-z
6ea828936f
Fix crash in _finalList removal loop. Fix incorrect implementation of seen chat notifications removal. Improved notifications fetch code to avoid multiple calls from different threads. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-07-18 09:57:13 +02:00
alex-z
71f1d1aad4 Added new state and new job to check if /index.php/204 is being redirected. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-07-17 11:31:15 +02:00
alex-z
b56200e0d7 Remove seen Talk notificatios from Tray window. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-07-06 09:15:26 +02:00
Matthieu Gallien
fad55470d5 ensure e2ee can be disabled from client 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-30 15:32:03 +02:00
Matthieu Gallien
da8fa7bfa7 prevent crash by resetting common pointer after deleting gobject menu 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-30 10:19:59 +02:00
Matthieu Gallien
0e002f35f4 add more metadata to sync errors to allow filtering 
in order to be able to filter some errors when showing them into the
main dialog activity list, add some more info about the error to know
the origin (like a network issue or a sync issue)

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-28 11:21:50 +02:00
Matthieu Gallien
431ccfec5a ActivityListModel now keeps track of the account connection state 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-28 11:21:50 +02:00
Matthieu Gallien
8cf778ba94 declare state property in AccountState 
should make it more logic to find the property when needed

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-28 11:21:50 +02:00
Dimitri Papadopoulos
fa96e0d31a Fix typos found by codespell 
These change actual variable names.

Signed-off-by: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com>
 2023-06-21 08:47:13 +02:00
Dimitri Papadopoulos
9d830e94f9 Fix typos found by codespell 
Signed-off-by: Dimitri Papadopoulos <3234522+DimitriPapadopoulos@users.noreply.github.com>
 2023-06-21 08:47:13 +02:00
allexzander
63470c0e21 Correctly handle errors for unsupported filenames on the server. Allow user to rename those via dialog. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2023-06-14 12:48:56 +02:00
Matthieu Gallien
257bebb790
avoid info level for new entries in ActivityListModel 
should also decrease the number of log lines during heavy sync

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-12 17:54:03 +02:00
Matthieu Gallien
40b1987287
downgrade some log lines to be less verbose 
those log lines can easily be skipped from info level as they are needed
in very rare occasion

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-12 17:54:03 +02:00
Claudio Cambra
d986b47a21 Fix reply button visibility after reply field opened and reply text sent 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-06-09 08:34:45 +02:00
Claudio Cambra
beb651fb05 Fix colouring of NCRadioButton 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-06-08 18:05:42 +02:00
Matthieu Gallien
91ea14d49e addd a cmake option to enable single account desktop client 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-08 11:11:47 +02:00
alex-z
cc65f89d4c Fix UnifiedSearch text field placeholder text color for light and dark theme. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-06-08 09:00:48 +02:00
Matthieu Gallien
fe748fafa5 use a better user message for network errors 
tell users this is a network error and the client wll retry
automatically

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-07 17:25:44 +02:00
Matthieu Gallien
5372276779 add more metadata to sync errors to allow filtering 
in order to be able to filter some errors when showing them into the
main dialog activity list, add some more info about the error to know
the origin (like a network issue or a sync issue)

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-07 17:25:44 +02:00
Matthieu Gallien
34dde88f0e
display subject when we have sync issues like network errors 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-07 12:48:05 +02:00
alex-z
fd69e6daca Bugfix. Conflict resolution button not clickable. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-06-07 10:56:32 +02:00
Matthieu Gallien
b28e635368
by default disable debug log level 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-06 16:32:15 +02:00
Claudio Cambra
fe427364c2 Fix progress bar palette 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-06-06 22:13:26 +08:00
Claudio Cambra
be84b2cf09
Use Style constants for UnifiedSearchInputContainer measurements 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-31 15:47:45 +08:00
Claudio Cambra
ca64951a6c
Fix switching from dark/light mode for checkboxes in file details window 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-31 15:36:07 +08:00
Claudio Cambra
27f5d826bb
Fix faulty dark/light mode switching in UnifiedSearchInputContainer 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-31 14:02:33 +08:00
Claudio Cambra
43a21717fa Fix macOS build when file provider module build is disabled 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 11:11:08 +02:00
Claudio Cambra
4c096a885c Declare hoverEnabled: true explicitly in CustomButton 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
97cf9390fa Fix highlight in activity list 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
1dc83bfbd3 Fix caret colour in basic combo box 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
24e6435289 Remove unnecessary background components 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
d195922d17 Always use palette colours for colouring UI elements 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
46f54891e4 Define all QML windows as ApplicationWindows, define palettes here 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
10560f8b03 Fix contentwidth of dialogbuttonbox in ShareDetailsPage 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
1aa4cd0dc5 Fix dark mode in ResolveConflictsDialog 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
de7697d6c7 Fix outline for progress bar in fusion 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
c2c3484306 Fix checkbox palettes in share details 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
313592645d Unify small icon sizes in file details components 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
fef9f3b643 Fix dark mode switching issues with main tray window 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
cde52f03fa Fix large number of warnings related to unavailable property 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
c18fba6366 Fix image sizing and positioning in NCButtonContents 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
6237898b73 Add darker hover to make hovering on an item within an item with lightHover visible 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
3145f9cf83 Respect icon.height and width in custom button contents 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
93efd2fb78 Respect icon.height and width in custom button contents 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
ea43ebfe91 Limit the max height of images inside CustomButton 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
97904d3b20 Simplify and fix activity content layout by going back to using RowLayout instead of Item 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
c37e077dac Use standard size instead of unncessary additional value 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
659ccc3f07 Fix text lines, don't leave only one line 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
95a8ecf013 Move filedetails button to activity top row 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
03631bb659 Fix more button icon when in dark mode 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
a106454b34 Use custombutton with filedetails button to make it not look horrible 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
a0909cea60 Hide second subject line in activity when nothing is visible 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
39b5e7653c Fix alignment of main subject line with time line in activity 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Claudio Cambra
97c33d396c Use custombutton for dismiss button, give hover feedback 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-30 10:00:10 +02:00
Matthieu Gallien
ad503d9fe3 ensure that the file to test monitoring is hidden 
we create a file inside the sync folder to test file system monitoring

ensure this file is hidden (i.e. has the proper hidden property)

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-25 08:25:56 +02:00
Matthieu Gallien
0ba16229c5 align activity text with "Sync now" text 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-23 11:15:56 +02:00
Claudio Cambra
bc64e990ce Fix colour of downward caret in tray folders button 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-22 09:58:07 +02:00
Claudio Cambra
623190c620 Fix colour of icon for tray folders button 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-22 09:58:07 +02:00
Matthieu Gallien
1accd60b86
just use padding to ensure a good width for "Sync now" button 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:11 +02:00
Matthieu Gallien
ce9540a252
do not color file details 3 dots button 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:11 +02:00
Matthieu Gallien
607d0da672
use a much more compact layout for activities 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:10 +02:00
Matthieu Gallien
ddeb629157
always enable entries in activity list to have consistent look and feel 
disable items will have weird look and behavior

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:10 +02:00
Matthieu Gallien
39c70c1f22
make highlight indicator in activity list have rounded corners 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:10 +02:00
Matthieu Gallien
f8feb6403f
to dismiss an activity use a round button with hover enabled 
change size of dismiss button for items in activity list

fix #5275

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:10 +02:00
Matthieu Gallien
4c1ab7092b
use Fusion qml style 
allows use of more standard qml styling and components

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:09 +02:00
Matthieu Gallien
7d03007fa8
use standard and existing property to set icon url in buttons 
replace custom property imageSource by the use of the standard
icon.source

will make our code closer to Qt Quick Controls v2 and less our own
controls toolkit

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:09 +02:00
Matthieu Gallien
e69a544b71
improve again qml bindings to notifications data 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:09 +02:00
Matthieu Gallien
98ec08097b
make the API easier to read 
make a protected method overriding a public method be a public method
also

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:09 +02:00
Matthieu Gallien
0d2742d88a
provide the full OCC::Activity instance to ActivityItemContent 
should allow accessing the required properties of teh activity to fine
tune the display of it

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:09 +02:00
Matthieu Gallien
f51af1734d
expose some properties of OCC::Activity gadget class 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:09 +02:00
Matthieu Gallien
ce69856bfa
improve qml binding for more element of OCC::Activity 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:09 +02:00
Matthieu Gallien
10f9ef5cd5
to store subjectRichParameters use a QVariantMap that is qml friendly 
will make it much easier to access fom qml in order to use the data
inside to improve activity list items

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:08 +02:00
Matthieu Gallien
bc9b7a05f4
repay some desbt in ActivityListModel::data 
only valid index are sent to QAbstractItemModel::data

we may want to do more checks in debug mode, let's do it

if we are going to show data, let's use a const variable to contain the
current activity item

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:08 +02:00
Matthieu Gallien
9a90f15ceb
remove scary warning that is a false alarm 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:08 +02:00
Matthieu Gallien
ad868daebe
remove custom property to set a source model in a sort proxy model 
custom property for source model is not needed

remove code that is not needed

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:08 +02:00
Matthieu Gallien
32ee1a962f
remove custom property and use standard sourceModel for our proxy model 
a QSortFilterProxyModel will trigger a new sort whenever needed, so
custom code is not needed

we might have someone that would use the standard property and loose teh
side effects of setting the source model via thet non standard property

this makes it more complicated to read as one might wonder why a custom
property was needed

deletes a bunch of code not really needed

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:08 +02:00
Matthieu Gallien
9bbabd3baa
prevent a 0 size to assert when creating icon from svg 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:08 +02:00
Matthieu Gallien
d6d1a6dcd2
fix a few debug logs to use proper categorized logging 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:08 +02:00
Matthieu Gallien
dc66a1254d
add missing copyright notices and upgrade qml module imports 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:07 +02:00