mirrors/nextcloud-desktop
1
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2024-10-24 21:35:47 +03:00
Code Issues Projects Releases Packages Wiki Activity

repay some desbt in ActivityListModel::data

Browse source 
only valid index are sent to QAbstractItemModel::data

we may want to do more checks in debug mode, let's do it

if we are going to show data, let's use a const variable to contain the
current activity item

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
This commit is contained in:
Matthieu Gallien 2023-02-13 19:12:58 +01:00
parent 9a90f15ceb
commit bc9b7a05f4
No known key found for this signature in database
GPG key ID: 7D0F74F05C22F553
1 changed files with 2 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/gui/tray/activitylistmodel.cpp
View file

@ -130,12 +130,9 @@ void ActivityListModel::setDisplayActions(bool value)
QVariant ActivityListModel::data(const QModelIndex &index, int role) const
{
Activity a;
Q_ASSERT(checkIndex(index, QAbstractItemModel::CheckIndexOption::IndexIsValid | QAbstractItemModel::CheckIndexOption::ParentIsInvalid));
if (!index.isValid())
return QVariant();
a = _finalList.at(index.row());
const auto a = _finalList.at(index.row());
AccountStatePtr ast = AccountManager::instance()->account(a._accName);
if (!ast && _accountState != ast.data())
return QVariant();