Commit graph

22424 commits

Author SHA1 Message Date
Camila Ayres
df84d12b58
wiz => owncloudSetupWizard.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-11-22 10:51:04 +01:00
Camila Ayres
77597af3ae
acc => account.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-11-22 10:51:04 +01:00
Camila Ayres
9649bd99f6
Add {} to single line if.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-11-22 10:51:03 +01:00
Camila Ayres
9634f4ed1f
Use saveAccount for adding single account.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-11-22 10:51:03 +01:00
Camila Ayres
f130e39cbc
Rename vars: _am => _networkAccessManager, a => newAccountData.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-11-22 10:51:03 +01:00
Camila Ayres
1847a2e95c
Diferentiate between display name and dav display name.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-11-22 10:51:03 +01:00
Camila Ayres
fc6ecf8186
Use slots as slots.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-11-22 10:51:02 +01:00
Camila Ayres
27ad53810e
Modernize Account::displayName().
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-11-22 10:50:11 +01:00
Camila Ayres
fc75626b58
Fix warning "Calling C++ methods with 'this' objects different from the one they were retrieved from is broken"
https://doc.qt.io/qt-6/qtqml-documents-structure.html#nativemethodbehavior

Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-11-22 10:50:11 +01:00
Camila Ayres
72f68aa9af
Use slotComputeOverallSyncStatus as a slot.
- Use qAsConst.

Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-11-22 10:50:10 +01:00
Matthieu Gallien
14581d266a
Merge pull request #7464 from nextcloud/bugfix/debug-archive-aio
Bundle macOS File Provider module logs into main debug archive
2024-11-22 10:08:41 +01:00
Claudio Cambra
a69a9a3064 Move file provider header include into file provider ifdef
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-22 10:08:32 +01:00
Claudio Cambra
3f0e75b944 Just use davUser as account identifier for macOS log filename
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-22 10:08:32 +01:00
Claudio Cambra
985043490c Move debug archive for vfs creation out of log entry creation
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-22 10:08:32 +01:00
Claudio Cambra
580420c28e Ensure we are not halting the entire application when trying to generate the debug archive for macOS vfs
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-22 10:08:32 +01:00
Claudio Cambra
a647b5fb07 Remove create debug archive button from individual vfs account settings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-22 10:08:32 +01:00
Claudio Cambra
e78353939f Directly bundle macOS vfs logs within standard debug archive
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-22 10:08:32 +01:00
Matthieu Gallien
f1c6b65265
Merge pull request #7477 from nextcloud/bugfix/readOnlyVirtualFilesFixes
Improve read only virtual files support on Windows
2024-11-22 10:06:19 +01:00
Matthieu Gallien
85e71d47bf
ensure lnk shortcut files are converted to virtual files
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-11-22 09:54:16 +01:00
Matthieu Gallien
2d0529c423
remote permissions of a view-only folder: no new file or folder
change the way we evaluate a folder permissions to be read-only when no
new file or new folders can be created

if those permissions are lacking, client will make the local folder
read-only

if those permissions are granted, client will make local folder
read-write

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-11-22 09:53:25 +01:00
Matthieu Gallien
d705cad6b9
improve logs for CfAPI handle requests in erroneous cases
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-11-22 09:50:09 +01:00
Matthieu Gallien
9c23be3434
never use QFileInfo on possibly pure virtual placeholder file
will prevent some type of activity being added to the list from
triggering implicit hydration during synchronization

most probably breaks existing open actions on those activities

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-11-22 09:50:09 +01:00
Matthieu Gallien
b6b0a9d4a3
prevent implicit hydration when setting file permissions on shortcuts
we were using specialized API to set the file permissions on the windows
shortcut and later falling back to the generic code path due to the
mising return

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-11-22 09:50:08 +01:00
Matthieu Gallien
caf1d492b1
provide proper log when we block a self hydration request
should make the existing log more useful when tracking the
self requested implicit hydration bugs

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-11-22 09:50:08 +01:00
Matthieu Gallien
8ac293bfd4
fix migration of existing windows shortcut files to placeholder
we cannot do a single call to convert the plain old file to be a
dehydrated virtual file placeholder

split the conversion into a separate initial API call

fix transition from releases < 3.14 to current releases that have first
class support for windows shortcuts (so called link files)

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-11-22 09:50:08 +01:00
Matthieu Gallien
3c021166fa
use proper item type when converting existing windows shortcuts
we need to make shortcut files be proper virtual placeholder files

let the sync engine use the proper item type for that

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-11-22 09:50:08 +01:00
Matthieu Gallien
1f21a934db
fix computation of availability for empty folders
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-11-22 09:50:08 +01:00
Matthieu Gallien
efe686992e
do not move to trash online only files/folders: going to fail
ensure that even if move to trash is enabled, we do not erroneously try
to move online only files or folders to trash bin

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-11-22 09:50:08 +01:00
Matthieu Gallien
16a2f0d5c4
Merge pull request #7373 from nextcloud/feature/display-sharedwithme-info
Show received share information in share view
2024-11-22 09:46:26 +01:00
Claudio Cambra
8baf105270 Ensure avatarJob is run on the respective account's QNAM thread
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-22 16:33:49 +08:00
Claudio Cambra
a8b0f23530 Match definition of shared_with_me with other properties in OcsShareJob getShares
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-22 16:33:49 +08:00
Claudio Cambra
0c32d78c42 Clean up whitespace in ShareModel::slotPropfindReceived
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-22 16:33:49 +08:00
Claudio Cambra
aa60f44251 Ensure account pointer is valid when fetching avatars
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-22 16:33:49 +08:00
Claudio Cambra
3957a305c2 Ensure requestedSize for avatars is valid
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-22 16:33:49 +08:00
Claudio Cambra
f0e88c769e Display image for sharedWithMe share owner in share view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-22 16:33:49 +08:00
Claudio Cambra
97ae48e17d Build shareOwnerAvatar image provider string when handling sharedWithMe share in ShareModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-22 16:33:49 +08:00
Claudio Cambra
380fe4a172 Add shareOwnerAvatar property to ShareModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-22 16:33:49 +08:00
Claudio Cambra
bc74c5a887 Add ability to fetch remote server avatars in usermodel avatar ImageResponse
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-22 16:33:49 +08:00
Claudio Cambra
c38a51079e Convert ImageProvider in an async image provider using an internal image response
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-22 16:33:49 +08:00
Claudio Cambra
1645912ce9 Bolden string showing who owns the share that was shared with me
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-22 16:33:49 +08:00
Claudio Cambra
b325686ddc Display share owner rather than file owner (this is more relevant to user)
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-22 16:33:49 +08:00
Claudio Cambra
6620bf2dd2 Display shared with me file's share expiry in share view if relevant
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-22 16:33:49 +08:00
Claudio Cambra
cfc4c26f74 Display file owner information (if not self) in share view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-22 16:33:49 +08:00
Claudio Cambra
4a1fa9228a When handling fetched shares, record shared-with-me related information in sharemodel properties
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-22 16:33:49 +08:00
Claudio Cambra
4dcf545948 Also fetch shared with me share on target path
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-22 16:33:49 +08:00
Claudio Cambra
e0d3fc5b20 Add sharedWithMe-related properties to sharemodel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-22 16:33:49 +08:00
Claudio Cambra
117e2cf91a Set if the file owner should be displayed and the file owner display name on propfind in sharemodel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-22 16:33:49 +08:00
Claudio Cambra
2e765c6fef Add fileOwnerDisplayName property to ShareModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-22 16:33:49 +08:00
Claudio Cambra
f0533a5ab1 Add displayFileOwner property to ShareModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-22 16:33:49 +08:00
Matthieu Gallien
f5be72019b
Merge pull request #7547 from nextcloud/bugfix/general-settings-ui-fix
Fix broken general settings UI file
2024-11-22 09:14:52 +01:00