mirrors/nextcloud-desktop
1
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2024-12-19 20:32:03 +03:00
Code Issues Projects Releases Packages Wiki Activity
21985 commits 488 branches 258 tags 463 MiB
Commit graph

604 commits

Author SHA1 Message Date
Matthieu Gallien
39c70c1f22
make highlight indicator in activity list have rounded corners 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:10 +02:00
Matthieu Gallien
f8feb6403f
to dismiss an activity use a round button with hover enabled 
change size of dismiss button for items in activity list

fix #5275

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:10 +02:00
Matthieu Gallien
7d03007fa8
use standard and existing property to set icon url in buttons 
replace custom property imageSource by the use of the standard
icon.source

will make our code closer to Qt Quick Controls v2 and less our own
controls toolkit

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:09 +02:00
Matthieu Gallien
98ec08097b
make the API easier to read 
make a protected method overriding a public method be a public method
also

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:09 +02:00
Matthieu Gallien
0d2742d88a
provide the full OCC::Activity instance to ActivityItemContent 
should allow accessing the required properties of teh activity to fine
tune the display of it

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:09 +02:00
Matthieu Gallien
f51af1734d
expose some properties of OCC::Activity gadget class 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:09 +02:00
Matthieu Gallien
ce69856bfa
improve qml binding for more element of OCC::Activity 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:09 +02:00
Matthieu Gallien
10f9ef5cd5
to store subjectRichParameters use a QVariantMap that is qml friendly 
will make it much easier to access fom qml in order to use the data
inside to improve activity list items

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:08 +02:00
Matthieu Gallien
bc9b7a05f4
repay some desbt in ActivityListModel::data 
only valid index are sent to QAbstractItemModel::data

we may want to do more checks in debug mode, let's do it

if we are going to show data, let's use a const variable to contain the
current activity item

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:08 +02:00
Matthieu Gallien
32ee1a962f
remove custom property and use standard sourceModel for our proxy model 
a QSortFilterProxyModel will trigger a new sort whenever needed, so
custom code is not needed

we might have someone that would use the standard property and loose teh
side effects of setting the source model via thet non standard property

this makes it more complicated to read as one might wonder why a custom
property was needed

deletes a bunch of code not really needed

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:08 +02:00
Matthieu Gallien
dc66a1254d
add missing copyright notices and upgrade qml module imports 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 18:16:07 +02:00
Matthieu Gallien
6c7f810095 improve code in activity list model 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 08:43:54 +02:00
Matthieu Gallien
8f60518d6f small qml cleanup to make code faster to read 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 08:43:54 +02:00
Matthieu Gallien
8d52d4e4cc implement more feedback 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 08:43:54 +02:00
Matthieu Gallien
789ca7230a plug models into the dialog 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 08:43:54 +02:00
Matthieu Gallien
f799d8c697 tune the pipes to really get a dialog to show for many conflicts 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 08:43:54 +02:00
Matthieu Gallien
c118958d3d do not show many conflicts dialog for a single conflict 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 08:43:54 +02:00
Matthieu Gallien
72b78c9011 replace "Sync now" button by "Solve all conflicts" for many conflicts 
offer an easy way to open a dialog to solve all conflicts at once
replacing the "Sync now" button

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 08:43:54 +02:00
Matthieu Gallien
1491c134c3 basic implementation of a dialog to resolve conflicts as a batch 
will allow solving all conflicts at once

FIX #2786

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 08:43:54 +02:00
Matthieu Gallien
7b4245a3c3 fix #include header style 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-05-17 08:43:54 +02:00
Camila
d6db8fcbd6 Add a dismiss link for notifications without it. 
- Fix for #5606 and #5585.
- That is how it is done in the server and other clients.
- Update tests.

Signed-off-by: Camila <hello@camila.codes>
 2023-05-16 11:17:37 +02:00
Valdnet
cd69b0d03f
i18n: Word separation 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2023-05-10 16:53:03 +02:00
alex-z
3be820d9a3 Group folder visibility improvements. Show dropdown in tray window. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-05-09 12:25:05 +02:00
Claudio Cambra
385c13e405 Fix setting [undefined] to QFont in 'Sync now' button 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-05-08 21:18:22 +08:00
alex-z
3a00c1d43f Edit locally. Elide loading dialog filename label middle. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-04-20 14:16:07 +02:00
Matthieu Gallien
5cb3266f7f fix compilation with clazy and fully-qualified-moc-types checks enabled 
will make all signals and slots be using fully qualified data types

makes code safer

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-04-11 11:34:00 +02:00
Matthieu Gallien
7c655cf679
use a getter to query encryption status 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-03-31 17:18:28 +02:00
Matthieu Gallien
e0bdbd1387
follow shouldNotify flag to hide notifications when needed 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-03-21 09:10:12 +01:00
alkl58
1e37697152 Show server name in tray main window 
Signed-off-by: Alkl58 <alkl58@protonmail.com>
 2023-03-10 16:51:22 +01:00
Camila
ec7b5481d4 Fix display of 2FA notification. 
Fix for issue #5421: add server notifications to the activities list
when the user needs to act on it.

Signed-off-by: Camila <hello@camila.codes>
 2023-03-08 10:53:51 +01:00
Claudio Cambra
4bbe851da1 Fix text labels in Sync Status component 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-02-28 23:07:09 +01:00
Matthieu Gallien
079d392d36
move init to default value in class declaration 
done via clang-tidy and manual tuning

run-clang-tidy -p build -header-filter='.*' -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,modernize-use-default-member-init' -fix

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-02-06 10:43:05 +01:00
Matthieu Gallien
76e88572d6
more fixes for attributes without init value 
done with clang-tidy

run-clang-tidy -p build -header-filter='.*' -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,cppcoreguidelines-pro-type-member-init' -fix

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-02-06 10:43:05 +01:00
Matthieu Gallien
ca932fe093
init attributes 
discovered at runtime using valgrind

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-02-06 10:43:05 +01:00
Claudio Cambra
dfdc23e240
Fix displaying of file details button for local syncfileitem activities 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-31 13:03:52 +01:00
Camila
b525de8a97 Open calendar notifications in the browser. 
Signed-off-by: Camila <hello@camila.codes>
 2023-01-27 12:30:01 +00:00
Claudio Cambra
5908ac4176
Display action button for conflict files in activity 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-25 16:37:35 +01:00
Matthieu Gallien
602b8db5e2
handle case clash conflicts in a similar way to content conflicts 
introduce a new type of conflict for case clash filename conflicts

add proper handling including a new utility class to solve them and a
new dialog for the user to pick a fix

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-01-25 16:37:35 +01:00
Claudio Cambra
96cd78264d Fix fetch more unified search result item not being clickable 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-24 12:24:01 +01:00
Claudio Cambra
481298997c Extract makeResourceUrl lambda into separate static openableUrl method 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-06 18:49:13 +01:00
Claudio Cambra
37830c4bc4 Simplify makeResourceUrl 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-06 18:49:13 +01:00
Claudio Cambra
92667560ab Fix existing check and completion for relative resource URLs 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-06 18:49:13 +01:00
Claudio Cambra
f6c4c32b6e Use QFileInfo::exists where we are only creating a QFileInfo to check if file exists, as it is faster 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-20 09:44:13 +01:00
Claudio Cambra
5930fb4ac9 Adapt changes from share details page changes 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-09 15:06:35 +01:00
Claudio Cambra
373a001774 Replace share button with file details button 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-09 15:06:35 +01:00
Claudio Cambra
a16fc9ffcc Replace drawer 'Done' button at bottom-right with close button at top-right 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-09 15:06:35 +01:00
Claudio Cambra
ca74c2b27f Make drawer modal, reduce width 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-09 15:06:35 +01:00
Claudio Cambra
d25ce28a1b Show file details within the tray dialog, rather than in a separate dialog 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-09 15:06:35 +01:00
Claudio Cambra
8913f88c50
Differentiate between normal normal and Talk notifications, invoke macOS text reply notifications 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-09 14:36:12 +01:00
Claudio Cambra
5e0a2672fb Make unshare button less prominent, move out of bottom button box 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-09 12:54:09 +01:00
Claudio Cambra
2ec1da22ed Remove now redundant use of textFormat 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-05 15:21:09 +01:00
Claudio Cambra
6c4070e786 Introduce EnforcedPlainTextLabel, convert all Label or Text labels to use this 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-05 15:21:09 +01:00
Claudio Cambra
00fcb6e01d Ensure more QML text components are rendering things as plain text 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-01 14:20:15 +01:00
Claudio Cambra
d24a40012e Fix bad custom button alignments, sizings, etc. 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-24 17:46:20 +01:00
Claudio Cambra
9a01480fcc Fix tray window margins, stop cutting into window border 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-24 15:02:37 +01:00
Matthieu Gallien
b5adbf3ab0 fix instances of: c++11 range-loop might detach Qt container warnings 
analyzed via clazy

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-11-18 16:02:21 +01:00
Claudio Cambra
e281c46fa5 Fix ActivityList delegate warnings· 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-15 11:51:39 +01:00
Claudio Cambra
561b55800c Remove reference to inexistent property in NCCustomButton 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-15 11:48:24 +01:00
Matthieu Gallien
61c792c6f4
fully qualify types in signals and slots 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-11-15 09:57:54 +01:00
Claudio Cambra
8315770467 Make user status selector modal, show user header 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-09 17:39:28 +01:00
Claudio Cambra
ddc14a844d Remove unused remotePath in User::processCompletedSyncItem 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-09 16:29:21 +01:00
Claudio Cambra
1a0903f178 Ensure 'Sync now' button doesn't have its text elided 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-08 16:32:04 +01:00
allexzander
6cb988b667 Fix accounts avatar issue when it becomes completely white due to non-changing account id member with changing account index in the list. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2022-11-03 10:14:44 +01:00
alex-z
b00007e07d Fix incorrect current user index when removing and adding an account. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-11-03 10:14:44 +01:00
Claudio Cambra
31afb02c84
Eliminate unneeded parent Item in FileActivityView 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:08 +01:00
Claudio Cambra
6adefb572a
Improve flat buttons in share delegates 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:07 +01:00
Claudio Cambra
7971789112
Add a file details window/page, QMLify file sharing 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:03 +01:00
Claudio Cambra
09997b189f Only show Sync Now button if account is connected 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-29 15:54:19 +02:00
Claudio Cambra
ae12519dd5 Show edit locally loading dialog sooner, improve feedback for user 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-29 13:32:48 +02:00
Claudio Cambra
c0baf5c93c Add a 'Sync now' button to the sync status header in the tray window 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-25 19:14:40 +02:00
Claudio Cambra
1a6326ed97 Create commonly accessible properties for current user colours in Style.qml 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-25 19:14:40 +02:00
Claudio Cambra
9edc7357f7
Fix call notification dialog buttons 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-20 14:11:10 +02:00
Claudio Cambra
8de5b0ffa5
Use prettyName more widely, instead of duplicating fallback string code 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-19 13:31:48 +02:00
Camila
b55d71dffe The dismiss button is now a CustomButton component. 
Signed-off-by: Camila <hello@camila.codes>
 2022-10-17 11:29:23 +00:00
Camila
0624bec007 Fix the dismiss button: display it whenever possible. 
Signed-off-by: Camila <hello@camila.codes>
 2022-10-17 11:29:23 +00:00
Matthieu Gallien
ec1fb6209a improve logs when adding sync errors in activity list of main dialog 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-12 08:25:45 +02:00
alex-z
7672cb7903 Improve 'Handle local file editing' feature. Add loading popup. Add force sync before opening a file.' 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-10-10 17:13:06 +03:00
Matthieu Gallien
565a5f0999 add [[nodiscard]] attribute via clang-tidy 
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,modernize-use-nodiscard' -fix
under linux with most part of our code covered

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-04 11:14:45 +02:00
Matthieu Gallien
ecc588c27a avoid possibly crashing static_cast 
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,cppcoreguidelines-pro-type-static-cast-downcast' -fix

this can prevent casting to a type that is unrelated to the real type
and later cause a crash because you go into undefined behavior domain

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-03 10:23:24 +02:00
Claudio Cambra
6137fe246e Fix sync progress bar colours in dark mode 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-29 21:55:44 +02:00
Camila
7633cc490d
Fix 'Reply' action primary property. 
Primary is set to true when object type is 'room' or 'chat' and it set to
false when object type is 'call'.

Signed-off-by: Camila <hello@camila.codes>
 2022-09-29 15:20:56 +02:00
Camila
cbe22d8c1e
Remove unused property. 
Signed-off-by: Camila <hello@camila.codes>
 2022-09-29 15:17:10 +02:00
Claudio Cambra
db861e1ade Make activity action button an actual button, clean up contents 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-28 13:07:08 +02:00
Camila
348c9ea915 Fix persistent two factor auth notification. 
The server app returns a 202 code when the request succeeded, which was
not taken into account.

Signed-off-by: Camila <hello@camila.codes>
 2022-09-27 14:49:29 +00:00
Camila
f3513aaafe Fix two factor auth notification: 'Approve' link is a primary action. 
Signed-off-by: Camila <hello@camila.codes>
 2022-09-27 14:49:29 +00:00
Claudio Cambra
e721b03106 Remove sorting code in activitylistmodel as not needed with sortedactivitylistmodel 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-26 18:18:34 +02:00
Claudio Cambra
f71ddc4d43 Add a sortedactivitylistmodel that automatically handles sorting of activities 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-26 18:18:28 +02:00
Claudio Cambra
664a80cbb5 Clicking on file name clash activities now opens file in web UI were the clash can be resolved 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-26 12:10:38 +02:00
Claudio Cambra
6fa2542a10 Categorise file name clash sync file issues as separate FileNameClash enum treated as warning 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-26 12:10:38 +02:00
Claudio Cambra
80fcb6d95f Ensure strings in main window QML are presented as plain text and not HTML 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-26 10:57:18 +02:00
Claudio Cambra
bc08559655 Add a placeholder item for empty activity list 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-22 12:17:21 +02:00
Camila
7db68ad2c5
Fix two factor auth notification: activity item was disabled. 
User couldn't click on the links.

Signed-off-by: Camila <hello@camila.codes>
 2022-09-20 18:56:31 +02:00
Claudio Cambra
547e5a4675 Do not format text in QML components as HTML 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-17 15:05:22 +02:00
allexzander
65cd8d06bc Do not ignore return values for SyncJournalDB in accountsettings folderstatusmodel activitylistmodel abstractpropagateremotedeleteyncrypted lockgilejobs and propagator jobs 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2022-09-17 09:47:15 +02:00
Claudio Cambra
5a56584fba Deallocate call notification dialog objects when closed 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-14 12:34:47 +02:00
Claudio Cambra
1a5fa50fbb Refactor ActivityListModel population mechanisms 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-13 19:34:41 +02:00
Claudio Cambra
4c9e0873a3 Fix low-resolution file changed overlay icons in activities 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-13 18:55:47 +02:00
Claudio Cambra
871ad24e28 Fix ActivityItem activityHover error 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-10 12:11:23 +02:00
Claudio Cambra
b7b374c442 Fix rebase issue with activity list keyboard navigation PR 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-07 18:45:58 +02:00
Claudio Cambra
b820df90b9 Improve activity list highlighting/keyboard item selection 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-07 18:27:14 +02:00
Claudio Cambra
85c5002d34 Simplify activity list delegates by making them ItemDelegates, clean up 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-07 18:19:49 +02:00
Claudio Cambra
7882e224fd Set UnifiedSearchResultNothingFound visibility less messily 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-07 15:01:07 +02:00
Claudio Cambra
316f3981ab Align, resize, and layout everything uniformly in the unified search view 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-06 09:02:17 +02:00
Claudio Cambra
5acb0b272a Use same tooltip component everywhere 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-06 08:40:03 +02:00
alex-z
ba9a39856b Change Activities dialog show and Systray.forceWindowInit call sequence to fix the issue of Activities dialog not being shown. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-08-29 10:59:55 +03:00
alex-z
22a3b6cc16 Fix File Activities dialog not showing up. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-08-29 10:59:55 +03:00
Claudio Cambra
2ab95a30f9 Ensure file activity dialog is centered on screen and appears at top of window stack 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-17 14:01:32 +02:00
Claudio Cambra
7d41530284 Fix account switching and hover issues with UserLine component 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-10 18:07:02 +03:00
Claudio Cambra
37bd55b232 Fix unified seach item placeholder image source 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-10 13:31:45 +02:00
Claudio Cambra
387dfa96a1 Refactor user line 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-10 12:10:20 +02:00
Claudio Cambra
d86f25d215 Make UserStatusSelector a dismissible page pushed onto the tray window 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-10 09:22:33 +00:00
Claudio Cambra
0a89bf2335 Fix QML warnings 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-09 14:45:18 +03:00
Claudio Cambra
81bb290e4c Eliminate padding around the menu separator in the account menu 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-08 16:14:32 +02:00
Claudio Cambra
e9e482b174 Restyle unified search skeleton items animation and simplify their code 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-05 18:40:13 +02:00
Claudio Cambra
c74c466725
Merge branch 'master' into bugfix/clean-up-talkreplytextfield 2022-08-02 18:28:28 +02:00
Claudio Cambra
789179214f Clicking on an activity list item for a file opens the local file if available 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-02 17:43:18 +02:00
Claudio Cambra
b1deb6cd1d Replace unified search text field busy indicator with custom indicator 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-02 13:23:33 +02:00
Claudio Cambra
78b3e09f3b Clean up TalkReplyTextField, remove unnecessary parent Item 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-29 12:47:08 +02:00
Claudio Cambra
061f443920 Make apps menu scrollable when content taller than available vertical space, preventing borking of layout 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-27 12:19:10 +02:00
Claudio Cambra
7a78f2b19f Ensure that throttled notifications still appear in tray activity model 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-25 13:15:50 +02:00
Claudio Cambra
8d0df62c49 Stop styling QML unified search items hierarchically, use global Style constants 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-21 15:38:18 +02:00
Claudio Cambra
8dfe1647ed Stop clearing notifications when new notifications are received 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-21 13:14:51 +02:00
Claudio Cambra
e3d897cb7f Fix ActivityItemContent QML paintedWidth errors 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-18 15:13:58 +02:00
Claudio Cambra
539ba93fd1 QMLify the UserModel, use properties rather than setter methods 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-15 16:47:17 +02:00
Claudio Cambra
6872e1a75b Take ints by value rather than reference in UserModel methods 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-15 15:01:48 +02:00
Claudio Cambra
bc01db7cff
Merge branch 'master' into bugfix/limit-concurrent-notifications 2022-07-13 00:18:08 +02:00
Claudio Cambra
ce9e4a99c0 Refactor tray window opening code for clarity and efficiency 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-12 22:54:00 +02:00
Claudio Cambra
7d087026ca Limit concurrent notifications 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-12 20:24:50 +02:00
Claudio Cambra
b712eb95e2 Clean up systray methods, make more QML-friendly 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-06 11:26:53 +02:00
Claudio Cambra
22464f5005 Work around issues with window positioning on Linux DEs, hardcode tray window to screen center when new account added 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-04 14:11:19 +02:00
Claudio Cambra
a504dbf965 Close call notifications when the call has been joined by the user, or the call has ended 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-01 11:39:50 +02:00
Camila
fae5b5573c Clean up code, move values to Style.qml. 
Signed-off-by: Camila <hello@camila.codes>
 2022-06-28 09:25:48 +02:00
Camila
3ff781ee17 Talk reply field should now have the same height as the 'Reply' button. 
Signed-off-by: Camila <hello@camila.codes>
 2022-06-28 09:25:48 +02:00
Claudio Cambra
b7c2e16aa9 Make client language gender-neutral and more clear 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-06-24 14:36:36 +02:00
Claudio Cambra
e873f3b348 Fix crashing when selecting user status 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-06-24 12:34:52 +02:00
Camila
ac0c227263 Remove unused signal fileActivityButtonClicked. 
Signed-off-by: Camila <hello@camila.codes>
 2022-06-23 10:10:55 +02:00
Camila
55d6035f1e absolutePath was undefined. 
It was not part of the model, the correct one was path (PathRole).

Signed-off-by: Camila <hello@camila.codes>
 2022-06-23 10:10:55 +02:00
Camila
7744ad29a9 Remove tooltip because it is only repeating the label of the link. 
It is bad for accessibility.

Signed-off-by: Camila <hello@camila.codes>
 2022-06-23 08:56:23 +02:00
Claudio Cambra
0d26929d41 Ensure call notification stays on top of other windows 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-06-22 10:25:51 +02:00
Camila
fc2408cf41 Add contrast to the text/icon of buttons if the server defined color is light. 
Signed-off-by: Camila <hello@camila.codes>
 2022-06-21 11:49:30 +02:00
Claudio Cambra
281e50f4cd Prevent call dialogs from being presented when do not disturb is set as the user status 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-06-10 11:30:16 +02:00
Camila
6ff82659ac Change color of text field to ncTextColor instead of ncSecondaryTextColor. 
Signed-off-by: Camila <hello@camila.codes>
 2022-05-25 12:08:53 +02:00
Camila
f911c546d9 Add a transparent background to the send reply button. 
Signed-off-by: Camila <hello@camila.codes>
 2022-05-25 12:08:53 +02:00
Camila
282aadb7e9 Reduce spacing above the notification buttons. 
Spacing is now the  same as space between lines in the text above.

Signed-off-by: Camila <hello@camila.codes>
 2022-05-25 10:01:38 +02:00
Camila
2fa834446a Fix 'TypeError: Cannot readproperty 'messageSent' of undefined'. 
Signed-off-by: Camila <hello@camila.codes>
 2022-05-24 11:51:55 +02:00
alex-z
43a37637cf Display chat message inside the OS notification. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-05-23 17:01:22 +03:00
Matthieu Gallien
d622999971 add explicit capture for lambda 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-05-17 13:33:22 +02:00
Valdnet
f4931026d7
i18n: Add a space 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2022-05-17 09:08:37 +02:00
Camila
290851c33a Convert primary, WEB and DELETE notification links to action buttons. 
Signed-off-by: Camila <hello@camila.codes>
 2022-05-16 22:03:53 +02:00
Camila
9c63615a78 Do not add a second DELETE to the list of actions in one notification. 
Signed-off-by: Camila <hello@camila.codes>
 2022-05-16 22:03:53 +02:00
alex-z
53654b2a50 Allow manual renaming of files and folders with spaces. Allow uploading invalid file name via the InvalidFileName dialog. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-05-16 18:07:26 +03:00
Claudio Cambra
463496153a Fixed several issues with activity items relating to icon colouration and activity item sizing + layout 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-05-16 16:42:53 +02:00
Claudio Cambra
b6def51945 Fix notifications not being shown when they should be 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-05-16 14:28:33 +02:00
alex-z
514f72f975 Use proper online status for user ('dnd', 'online', 'invisible', etc.) to enable or disable desktop notifications. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-05-16 10:47:05 +03:00
Camila
e4a0d57bc8
Do not replace strings in action links coming from the notification api. 
Signed-off-by: Camila <hello@camila.codes>
 2022-05-12 12:47:48 +02:00
rakekniven
994c2e02d8 l10n: Changed triple dot to ellipsis 
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2022-05-04 11:33:47 +02:00
Claudio Cambra
7129bf2489 Add user avatars in talk notifications in activity list 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-05-02 15:12:45 +02:00
Matthieu Gallien
2d27a68e73 show errors on lock/unlock actions 
use a native dialog to show users errors when trying to lock/unlock
files

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-05-02 13:52:05 +02:00
alex-z
7b441a0f6e Optimize activities fetch requests. Do not fetch when the Tray is not open. Fetch next subset only when scrolling. Fix duplicate notifications. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-04-29 20:59:56 +03:00
Claudio Cambra
3f5243aaee Add an incoming talk call notification to the desktop client 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>

Co-authored-by: Camila <hello@camila.codes>
 2022-04-28 09:13:13 +02:00
Claudio Cambra
010f49a392
Realigned and resized thumbnails 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-04-27 18:02:37 +02:00
Claudio Cambra
15078260b4
Removed spacing between activies, labels now centre-aligned 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-04-20 18:07:41 +02:00
Claudio Cambra
7b65c1ceed
Fix thumbnails for new files made while client open 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-04-19 10:16:43 +02:00
Claudio Cambra
5ce736222e Use header text color to improve contrast with header colours when hovering on themed elements 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-04-15 13:17:09 +02:00
Camila
74d214726c
Remove unused function parameter. 
Signed-off-by: Camila <hello@camila.codes>
 2022-04-06 10:38:01 +02:00
Camila
6189b2115e
Adress design issues. 
- The input field was not using the  theming.
- After submitting the reply, the text and icon on the left were moving.

Signed-off-by: Camila <hello@camila.codes>
 2022-04-06 10:38:01 +02:00
Camila
f524635cf4
Do not hide'View chat' link. 
This logic was also hiding 'Answer call'.

Signed-off-by: Camila <hello@camila.codes>
 2022-04-06 10:38:01 +02:00
Camila
ead4eeda1e
Windows fix: activityIndex was not being passed to the lambda slot function. 
Signed-off-by: Camila <hello@camila.codes>
 2022-04-06 10:38:00 +02:00
Camila
c254572e80
Add 'Reply' as activity link instead of changing the 'View chat' link. 
- Align 'Reply' button.
- Do not display 'View chat' as a link: the 'View chat' action is active when
the user clickcs on the notification item in the tray window.
- Convert the QByteArray verb value to String.
- Handle logic to toggle the reply textfield in the QML code.

Signed-off-by: Camila <hello@camila.codes>
 2022-04-06 10:38:00 +02:00
Claudio Cambra
a2e1c68c26 Fix broken activity icon and loading entries colour in unified search 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-04-05 16:41:11 +00:00
Camila
7cc2486d79
Address PR comments. 
Signed-off-by: Camila <hello@camila.codes>
 2022-03-28 16:04:54 +02:00
Camila
9b00e5268e
Rename functions. 
Signed-off-by: Camila <hello@camila.codes>
 2022-03-28 16:04:54 +02:00
Camila
a46482ca91
Fix background color so it switches with light/dark theme. 
Signed-off-by: Camila <hello@camila.codes>
 2022-03-28 16:04:54 +02:00
Camila
0890a78262
Display input once user clicked on Reply. 
Signed-off-by: Camila <hello@camila.codes>
 2022-03-28 16:04:54 +02:00
Camila
b2056187a0
Let qml know the message reply was sent. 
Signed-off-by: Camila <hello@camila.codes>
 2022-03-28 16:04:54 +02:00
Camila
94530b6305
Rename data role. 
Signed-off-by: Camila <hello@camila.codes>
 2022-03-28 16:04:53 +02:00
Claudio Cambra
3d086ae305 Fix dark mode stuff relating to unified search, fix macOS auto dark/light theme switching not always working, fix Windows detection of dark/light theme switching 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-03-28 09:21:35 +00:00
Claudio Cambra
bbd988d8c5 Fixes to UI issues 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-03-20 16:32:43 +00:00
Claudio Cambra
98e297bf0b Fix for VFS crashes 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-03-19 23:31:24 +01:00
Claudio Cambra
c342c304ac Added dark mode 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-03-18 16:43:15 +00:00
Camila
73bae8cd30
Add TalkReply class and tests. 
- Add struct TalkNotificationData to handle token and messageId.
- Handle chat and call notifications with the new struct.
- Add talk token and messageId to data roles in ActivityListModel.
- Add Talk Reply component to the ActivityList.
- User Loader to display the TalkReply component.
- Move Talk Reply from ActivityItem to ActivityItemContent due to PR #4186.
- Use TextField instead of Text.
- Disable send reply button instead of changing border color when field is empty.

Signed-off-by: Camila <hello@camila.codes>
 2022-03-17 17:50:33 +01:00
Claudio Cambra
65f2bada3e Add thumbnails for files in the activity view 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-03-17 10:46:09 +00:00
Claudio Cambra
f585b8bd48 Add support for server color theming by using server color as accent 
color

Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-03-16 13:57:45 +01:00
Claudio Cambra
02f3a1aed6 File activity dialog now works for all file actions activities (e.g. deleted files) 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-03-16 08:38:14 +01:00
Claudio Cambra
ead4cc6fe3 Increase max line of text in activity item text to two 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-03-15 09:22:11 +00:00
Claudio Cambra
2f795df701 Ensure file activity dialog appears in centre of screen 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-03-13 22:11:26 +00:00
alex-z
ae44dd5978 Adjust icons for activity entries in main dialog. Refactor the dialog by splitting it to separate components. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-02-04 17:52:37 +02:00
Claudio Cambra
a2524763c8
Merge branch 'master' into bugfix/account-menu-scroll 2022-02-01 17:01:51 +01:00
Claudio Cambra
ce5494b4ec Add testing for ActivityListModel 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-02-01 13:57:08 +00:00
Claudio Cambra
7a1eae45d3 Account menu can now scroll 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-01-31 15:06:55 +00:00
Felix Weilbach
99457e8c38 Use the font size that Qt suggest 
Fixes: https://github.com/nextcloud/desktop/issues/3797

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2022-01-17 11:11:57 +00:00
Claudio Cambra
2a27882307 Show only filenames in tray activity items, with full path in tooltip 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-01-14 08:02:08 +00:00
Claudio Cambra
8c091a2daa Hide share button for deleted and ignored files in tray activity 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2021-12-20 16:07:11 +00:00
Carl Schwan
38ac585e7c Add WheelHandler to the Search result list too 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2021-11-22 11:18:18 +00:00
Carl Schwan
892d289f38 [tray] Makes scrolling with a touchpad in activiy list more natural 
This basically use the same method that is used in Kirigami and Plasma
Components3.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2021-11-22 11:18:18 +00:00
alex-z
911e35bc50 Use QUrl::fromLocalFile to open local files in Unified Search results. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-11-18 09:34:54 +00:00
Matthieu Gallien
c59f88ca82 avoid adding icon data in a cache we never use 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-16 16:11:44 +01:00
Carl Schwan
d84673376d More fixes to the menu implementation 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2021-11-16 09:27:10 +00:00
Carl Schwan
69def04ec2 Fix focus indicator 
This improve considerably the keyboard navigation in the SystemTray.
But this is still not as good as the golden standard that is recommended
by this article: https://www.sarasoueidan.com/blog/focus-indicators/

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2021-11-16 09:27:10 +00:00
Felix Weilbach
07a8e8c91d Check if the server has user status app enabled 
According to
https://docs.nextcloud.com/server/latest/developer_manual/client_apis/OCS/ocs-status-api.html#user-status-retrieve-statuses
we should check the user status capability, not the the end points.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-11-15 16:20:58 +00:00