Commit graph

18196 commits

Author SHA1 Message Date
Matthieu Gallien
bde2f90de9
Merge pull request #4998 from nextcloud/ci/removeOneWarningOnWindows
do not ignore return value
2022-10-11 23:48:09 +02:00
Matthieu Gallien
74f35191e0 do not ignore return value
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-11 21:54:38 +02:00
Matthieu Gallien
4ddfaa72e6
Merge pull request #5024 from nextcloud/bugfix/filesLockFailMetadata
Bugfix/files lock fail metadata
2022-10-11 21:54:17 +02:00
Matthieu Gallien
a096bbd1ff ensure we do not loose data when syncing locked files
fixes #5014

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-11 16:01:58 +02:00
Matthieu Gallien
a378c4d80a add extra tests for lock files to better capture desired behavior
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-11 16:01:58 +02:00
Matthieu Gallien
d371855e56 test that files soon to be expired will be synced automatically
try to ensure that we properly sync again files for which lock has
expired

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-11 16:01:58 +02:00
allexzander
42f6a63361
Merge pull request #5022 from nextcloud/bugfix/cmdclient-do-not-trust-certs-by-default
Command-line client. Do not trust SSL certificates by default, unless '--trust' option is set.
2022-10-11 14:15:31 +03:00
alex-z
564a3ad987 Fix error in logic.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-10-11 09:43:31 +03:00
allexzander
4930531949 Command-line client. Do not trust SSL certificates by default, unlss '--trust' option is set.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2022-10-11 09:43:31 +03:00
Nextcloud bot
256aa52202
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-11 03:17:10 +00:00
allexzander
35dec82616
Merge pull request #4990 from nextcloud/bugfix/local-editing-sync-and-loading-indicator
Improve 'Handle local file editing' feature. Add loading popup. Add force sync before opening a file.
2022-10-10 17:57:27 +03:00
alex-z
7672cb7903 Improve 'Handle local file editing' feature. Add loading popup. Add force sync before opening a file.'
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-10-10 17:13:06 +03:00
Nextcloud bot
c334d57a28
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-10 03:23:59 +00:00
Nextcloud bot
dc34a76e43
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-09 03:34:50 +00:00
Nextcloud bot
dec66ae081
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-10-07 13:36:55 +00:00
Tobias Kaminsky
47b2cc3d31
Merge pull request #5019 from nextcloud/transifexUpdate
Update after tx migrate
2022-10-07 15:26:33 +02:00
tobiasKaminsky
1af12fbf75
Update after tx migrate
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2022-10-07 15:23:56 +02:00
allexzander
de27a2ffd7
Merge pull request #4942 from nextcloud/feature/vfs-windows-sharing-and-lock-state
Feature/vfs windows sharing and lock state
2022-10-04 22:40:15 +03:00
allexzander
289a641d74 VFS Windows: Display the sharing state and lock state in the 'Status' column of Windows Explorer
Signed-off-by: allexzander <blackslayer4@gmail.com>
2022-10-04 18:32:51 +02:00
Matthieu Gallien
af0764d5b2
Merge pull request #4991 from nextcloud/ci/checkFormatWithClangFormat
let's check the format via some github action
2022-10-04 18:32:07 +02:00
Matthieu Gallien
57e4053216 only test format on changed files and changed lines
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-04 18:31:50 +02:00
Matthieu Gallien
44eb234469 pick up clang-format conf files from KDE community
takes it from current extra-cmake-modules repository

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-04 18:31:50 +02:00
Matthieu Gallien
27485e2e66 let's check the format via some github action
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-04 18:31:50 +02:00
Camila
3796e03492
Merge pull request #5002 from nextcloud/update-client-image
Update client image
2022-10-04 15:35:16 +02:00
Camila
b1d8390dfe
Remove clang-tidy from .drone.yml.
It is being replaced by GH actions.

Signed-off-by: Camila <hello@camila.codes>
2022-10-04 13:41:57 +02:00
Camila
f6f650c85c
Update to docker image to client-5.15-11.
Signed-off-by: Camila <hello@camila.codes>
2022-10-04 13:41:57 +02:00
Claudio Cambra
b9f6d914d9
Merge pull request #4962 from nextcloud/bugfix/files-not-unlocking 2022-10-04 12:58:34 +02:00
Claudio Cambra
2f571337f1 Ensure we are checking lock state without affecting sync behaviour
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-10-04 11:52:23 +02:00
Claudio Cambra
ff5261eaf1 Check local file locked and unlocked correctly in testlocaldiscovery
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-10-04 11:52:23 +02:00
Claudio Cambra
80d0245acb Unschedule previously scheduled sync runs for locked files if it is found the sync run is no longer needed
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-10-04 11:52:23 +02:00
Claudio Cambra
bbbfe3f1c4 More efficiently schedule sync runs for files that need delayed sync runs
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-10-04 11:52:23 +02:00
Claudio Cambra
fd332a52e2 Fix files not unlocking after lock time expired
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-10-04 11:52:23 +02:00
Matthieu Gallien
311469a0e5
Merge pull request #4992 from nextcloud/ci/useNoDiscard
Ci/use no discard
2022-10-04 11:44:46 +02:00
Matthieu Gallien
565a5f0999 add [[nodiscard]] attribute via clang-tidy
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,modernize-use-nodiscard' -fix
under linux with most part of our code covered

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-04 11:14:45 +02:00
Matthieu Gallien
5fc017575b fix [[nodiscard]] single warning
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-04 11:14:45 +02:00
Matthieu Gallien
17e2f1de03
Merge pull request #4993 from nextcloud/ci/useUsing
apply modernize-use-using via clang-tidy
2022-10-04 11:14:27 +02:00
Matthieu Gallien
9b7d1add52 apply modernize-use-using via clang-tidy
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,modernize-use-using' -fix

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-04 01:32:46 +02:00
Claudio Cambra
e5d5471fb6
Merge pull request #4982 from nextcloud/bugfix/enforced-max-expire-date-link-share-fix
Fix link shares default expire date being enforced as maximum expire date even when maximum date enforcement is disabled on the server
2022-10-04 01:13:20 +02:00
Claudio Cambra
c67141430b Fix link shares default expire date being enforced as maximum expire date even when maximum date enforcement is disabled on the server
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-10-03 22:27:18 +02:00
Matthieu Gallien
15bfccd6a7
Merge pull request #5004 from nextcloud/configure-clang-tidy-checks
configure a list of checks for clang-tidy
2022-10-03 22:01:51 +02:00
Matthieu Gallien
4e3e8be4f6
configure a list of checks for clang-tidy
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-03 21:05:50 +02:00
Matthieu Gallien
ca30859831
Merge pull request #5003 from nextcloud/update-client-appimage-image
switch AppImage CI to latest tag: client-appimage-6
2022-10-03 20:53:22 +02:00
Matthieu Gallien
a0065d1511
switch AppImage CI to latest tag: client-appimage-6
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-03 17:22:02 +02:00
Matthieu Gallien
6bb768f889
Merge pull request #4994 from nextcloud/ci/cppcoreguidelines-pro-type-static-cast-downcast
avoid possibly crashing static_cast
2022-10-03 13:50:22 +02:00
Matthieu Gallien
ecc588c27a avoid possibly crashing static_cast
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,cppcoreguidelines-pro-type-static-cast-downcast' -fix

this can prevent casting to a type that is unrelated to the real type
and later cause a crash because you go into undefined behavior domain

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-03 10:23:24 +02:00
Matthieu Gallien
c40d948b56
Merge pull request #4996 from nextcloud/cleanConfigFileConstants
alway use constexpr for all text constants
2022-10-03 10:22:45 +02:00
Matthieu Gallien
0b4128eede
Merge branch 'master' into cleanConfigFileConstants 2022-10-02 15:48:20 +02:00
Matthieu Gallien
ee98244877
Merge pull request #4999 from nextcloud/ci/checkClangTidyInCi
check our code with clang-tidy
2022-10-02 15:48:07 +02:00
Matthieu Gallien
43e7308164
check our code with clang-tidy
should allow to keep our code tidy and maybe simplify reviews

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-02 15:36:25 +02:00
Matthieu Gallien
bfe0b3067e
Merge pull request #4995 from nextcloud/ci/checkClangTidyInCi
Ci/check clang tidy in ci
2022-10-02 15:14:06 +02:00