mirrors/nextcloud-desktop
1
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2024-12-22 05:34:33 +03:00
Code Issues Projects Releases Packages Wiki Activity
19224 commits 486 branches 258 tags 464 MiB
Commit graph

3874 commits

Author SHA1 Message Date
Claudio Cambra
fdaedc4914
Only add root-most encrypted folder to the blacklist 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-24 17:00:15 +01:00
Claudio Cambra
7d208ec06e
Make sure to add e2ee files to normal blacklist too 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-24 17:00:15 +01:00
Claudio Cambra
093810f6b9
Only shedule affected paths for remote discovery after disabling e2ee 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-24 17:00:15 +01:00
Claudio Cambra
1fc1e95161
Use e2ee folder blacklist instead of deleting folders directly 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-24 17:00:15 +01:00
Claudio Cambra
12b2673ac2
Add test for deleting encrypted files 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-24 17:00:15 +01:00
Claudio Cambra
c59ab85e22
Make accountstate fakeable for tests 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-24 17:00:14 +01:00
Claudio Cambra
b57b35e7a4
Delete E2EE files/folders for accounts that have had E2EE disabled 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-24 17:00:14 +01:00
Claudio Cambra
cc6bdc9bd5
Add ability to remove local encryption keys through settings 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-24 17:00:14 +01:00
Claudio Cambra
f9fb03bdc9
Clean up declarations in AccountSettings 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-24 17:00:14 +01:00
Claudio Cambra
96cd78264d Fix fetch more unified search result item not being clickable 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-24 12:24:01 +01:00
Claudio Cambra
0ab2bd849b Don't try to lock folders when editing locally 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-23 17:46:43 +01:00
Claudio Cambra
c496e73200 Correctly parse account server url when migration from legacy config 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-23 16:29:01 +01:00
Claudio Cambra
174a486428 Stop checking config to migrate at current path if could not read file 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-23 16:29:01 +01:00
Claudio Cambra
39914e5166 More concisely clean paths of trailing slash URLs in restore old config migration method of AccountManager 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-23 16:29:01 +01:00
Claudio Cambra
dd4b7b6c26
Update legal notice text 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-23 15:37:56 +01:00
alex-z
d8980a8567 Fix bad string for translation. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-01-23 13:07:41 +01:00
alex-z
2bd1c272a6 Allow specifying the server force override URL and local sync folder path via command line. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-01-17 17:27:19 +01:00
Claudio Cambra
481298997c Extract makeResourceUrl lambda into separate static openableUrl method 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-06 18:49:13 +01:00
Claudio Cambra
37830c4bc4 Simplify makeResourceUrl 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-06 18:49:13 +01:00
Claudio Cambra
92667560ab Fix existing check and completion for relative resource URLs 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-06 18:49:13 +01:00
Florian Schmaus
14cbd836ab Drop dependency on Qt Quick Controls 1 
Qt Quick Controls 1 where deprecated with Qt 5.11 [1]. Nextcloud still
depends on Quick Controls 1 by importing QtQuick.Dialogs. Removing
those imports will cause the QMl script to use the according API from
Quick Controls 2, which are, fortunately largely API-comptible.

This helps distribution to deprecate and remove Quick Controls 1 [2].

1: https://doc.qt.io/qt-6/qtquickcontrols-changes-qt6.html#migrating-from-qt-quick-controls-1
2: https://bugs.gentoo.org/889772

Signed-off-by: Florian Schmaus <flo@geekplace.eu>
 2023-01-06 17:22:56 +01:00
Claudio Cambra
784327f489 Replace now deprecated FSEventStreamScheduleWithRunLoop with FSEventStreamSetDispatchQueue 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-02 18:05:54 +01:00
Claudio Cambra
403f43b3e8 Fix currentPage QPROPERTY missing NOTIFY in settingsdialog class 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-02 17:04:30 +01:00
Claudio Cambra
0495c6567a Fix interval QPROPERTY missing NOTIFY in slideshow class 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-02 17:04:30 +01:00
alex-z
cecd24b6c5 Fix review comments from Claudio III. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-12-30 14:46:06 +01:00
alex-z
07be556eca Fix review comments from Claudio II. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-12-30 14:46:06 +01:00
alex-z
e53d08fedb Fix review comments from Claudio. Refactoring. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-12-30 14:46:06 +01:00
alex-z
94df6769dc Allow setting up an account with apppasword and folder via command-line arguments. For deployment. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-12-30 14:46:06 +01:00
Valdnet
c9bae27bf8
l10n: Remove space 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2022-12-24 12:56:08 +01:00
Claudio Cambra
ce57d3b3ab Declare all QRegularExpressions statically 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-20 18:38:24 +01:00
Claudio Cambra
bf85c2d093 Remove unused QStrings from remotewipe 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-20 12:59:08 +01:00
Claudio Cambra
ad2841d963 Remove HACK for Windows Vista as this OS is no longer supported 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-20 12:59:08 +01:00
Claudio Cambra
50fa4cbb63 Remove unused variables in folderstatusdelegate 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-20 12:59:08 +01:00
Claudio Cambra
1dfb9b26f2 Remove use of emit keyword where used for non signals 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-20 12:07:55 +01:00
Claudio Cambra
6146f7d5cf Add 'emit' keyword to signal emissions that were missing them 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-20 12:07:55 +01:00
Claudio Cambra
f6c4c32b6e Use QFileInfo::exists where we are only creating a QFileInfo to check if file exists, as it is faster 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-20 09:44:13 +01:00
Claudio Cambra
b0d048b0b8 Fix conflicting definitions in anonymous namespace in Unity build 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-15 16:58:00 +01:00
Claudio Cambra
3b7bd6d26c Constify groups variable 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-15 16:58:00 +01:00
Claudio Cambra
14bd744df6 Use std::make_unique rather than manually build unique_ptr for oCSettings 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-15 16:58:00 +01:00
Claudio Cambra
f4bca991e1 Make checks for config file more concise, warn when file not readable 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-15 16:58:00 +01:00
Claudio Cambra
d8e8a43cff Constify config file QFileInfo, create directly in if statement 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-15 16:58:00 +01:00
Claudio Cambra
0f9ddcddcb Fix includes in accountmanager.cpp 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-15 16:58:00 +01:00
Claudio Cambra
5548a4181b Replace QDesktopServices datalocation with emulated version of it 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-15 16:58:00 +01:00
Claudio Cambra
98be5fdd18 Add full list of possible legacy config locations 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-15 16:58:00 +01:00
Matthieu Gallien
39f85219b9 fix migration from old settings configuration files 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-12-15 16:58:00 +01:00
alex-z
867249f339 Do not sync encrypted folders if the E2EE mnemonic is not entered. Automatically blacklist them. Remove from blacklist once the E2EE mnemonic is provided. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-12-15 15:09:25 +01:00
Claudio Cambra
4ab7d6484a Remove unused headerbanner component 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-15 12:30:41 +01:00
Matthieu Gallien
a8025dc06a use .nextcloudsync.log to perform file monitoring test at start 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-12-15 11:11:20 +01:00
Claudio Cambra
b4ea35e95c
Clean up data section for internal link in model 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-13 17:40:20 +01:00
Claudio Cambra
bdfa923f8a
Fix copy link button 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-13 17:40:20 +01:00
Claudio Cambra
4af2a8f9de
Remove unneeded property from ShareDetailsPage 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-13 17:40:20 +01:00
Claudio Cambra
59d84759e4
Add an internal link share to the share dialog 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-13 17:33:33 +01:00
Claudio Cambra
2a77dc4529 Check socketlistener is valid before trying to send encryption menu item message 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-13 13:27:56 +01:00
Claudio Cambra
a23db4688a Don't show Encrypt menu entry if server does not support E2EE 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-13 13:27:56 +01:00
Claudio Cambra
01334e40f9 Improve folder encryption dialog info boxes 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-13 13:27:56 +01:00
Claudio Cambra
2b09281594 Add encryption success message box 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-13 13:27:56 +01:00
Claudio Cambra
39a48bf822 Move encrypt menu entry declaration to own method 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-13 13:27:56 +01:00
Claudio Cambra
bf1f718a65 Don't allow encryption if account is not correctly configured for it 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-13 13:27:56 +01:00
Claudio Cambra
1d4c634c54 Add context menu entry to encrypt folders 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-13 13:27:56 +01:00
Christian Göttsche
1a83894074 Fix typo 
Found by Lintian.

Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
 2022-12-13 09:22:58 +01:00
alex-z
f7ef2e5f44 Silence sync termination errors when running EditLocallyJob. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-12-12 17:39:48 +01:00
Claudio Cambra
5930fb4ac9 Adapt changes from share details page changes 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-09 15:06:35 +01:00
Claudio Cambra
373a001774 Replace share button with file details button 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-09 15:06:35 +01:00
Claudio Cambra
a16fc9ffcc Replace drawer 'Done' button at bottom-right with close button at top-right 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-09 15:06:35 +01:00
Claudio Cambra
ca74c2b27f Make drawer modal, reduce width 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-09 15:06:35 +01:00
Claudio Cambra
d25ce28a1b Show file details within the tray dialog, rather than in a separate dialog 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-09 15:06:35 +01:00
Claudio Cambra
4a42aee17e
Remove semicolons from Q_UNUSED macros 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-09 14:36:12 +01:00
Claudio Cambra
8913f88c50
Differentiate between normal normal and Talk notifications, invoke macOS text reply notifications 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-09 14:36:12 +01:00
Claudio Cambra
d2e0afa070
Add Talk message type of notifications to native macOS notifications 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-09 14:36:12 +01:00
Claudio Cambra
2261615f69 Use EnforcedPlainTextLabel in new ShareDetailsPage 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-09 12:54:09 +01:00
Claudio Cambra
6ae41c0759 Add copy share link button to share details page footer, remove unneeded columnlayout in contentitem 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-09 12:54:09 +01:00
Claudio Cambra
e723b75919 Make 'Add another link' button less prominent 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-09 12:54:09 +01:00
Claudio Cambra
5e0a2672fb Make unshare button less prominent, move out of bottom button box 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-09 12:54:09 +01:00
Claudio Cambra
4d837bd027 Set main file details page as initial item of stack view 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-09 12:54:09 +01:00
Claudio Cambra
79ec0e9748 Match design of expire date spinbox to other text fields 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-09 12:54:09 +01:00
Claudio Cambra
cfccd02a26 Improve layout of share details page 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-09 12:54:09 +01:00
Claudio Cambra
046f8ea910 Convert share details menu into a page pushed onto stackview 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-09 12:54:09 +01:00
Claudio Cambra
e42188274c Add stackview to file details view 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-09 12:54:09 +01:00
Claudio Cambra
31876926ac Only request mnemonic when user explicitly wants to enable E2EE 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-09 12:12:37 +01:00
Claudio Cambra
cc159e0117 Explicitly size and align user status selector text input to avoid bugs with alternate QtQuick styles 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-08 13:07:55 +01:00
Claudio Cambra
1cf2b59be2
Fix BasicComboBox internal layout, take proper account of insets 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-08 12:21:28 +01:00
Matthieu Gallien
2c94490b9c
do not create GUI from a random thread and show error on real error 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-12-08 10:58:58 +01:00
Claudio Cambra
135cab152b Format some QLabels as plain text 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-07 17:18:57 +01:00
Claudio Cambra
58f91072a5
Remove redundant openUrl variable 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-07 13:48:51 +01:00
Claudio Cambra
7eb31c31e5
Fix loss of integer precision in parameters for fileLockTimeRemainingMinutes 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-07 13:47:48 +01:00
Claudio Cambra
1b5b30d222
Make fileLockTimeRemainingMinutes a static method 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-07 13:46:21 +01:00
Claudio Cambra
4e508d0276
Run locking procedure on main thread, open file after file has been locked remotely 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-07 12:45:32 +01:00
Claudio Cambra
d3fa0066d0
Ensure we are using up-to-date item ptr instead of potentially un-update file record when checking lock state in fileLockSuccess, separate case with lock already pre-existing 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-07 12:45:32 +01:00
Claudio Cambra
6dbdcccb0f
Ensure we are using folder relative paths for synced folders that are not root to work correctly 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-07 12:45:31 +01:00
Claudio Cambra
3f20f192e9
Ensure we are checking lock state once file has been synced after setting lock 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-07 12:45:31 +01:00
Claudio Cambra
10746d8441
Notify user when file is locked when local editing begins 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-07 12:45:31 +01:00
Claudio Cambra
ff6ab38826
Lock file when editing locally 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-07 12:45:31 +01:00
alex-z
838817239a Fix CI errors for Edit Locally. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-12-06 15:31:24 +01:00
alex-z
b673ab996e Edit locally job will only sync a specific file by modifying the state of the Sync Engine. All other running syncs will get terminated. Syncing is now optimized to run faster and it checks if the file has changed on the server before syncing it. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-12-06 09:37:03 +01:00
Claudio Cambra
2ec1da22ed Remove now redundant use of textFormat 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-05 15:21:09 +01:00
Claudio Cambra
6c4070e786 Introduce EnforcedPlainTextLabel, convert all Label or Text labels to use this 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-05 15:21:09 +01:00
Valdnet
e2ff8715f4 l10n: Correct spelling 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2022-12-01 15:33:15 +01:00
Claudio Cambra
00fcb6e01d Ensure more QML text components are rendering things as plain text 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-01 14:20:15 +01:00
Claudio Cambra
83fd752981 Address capitalisation of End-to-end 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-01 11:50:18 +01:00
Claudio Cambra
70468be5e5 Differentiate between E2EE not being enabled at all vs. E2EE being enabled already through another device in account settings message 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-01 11:50:18 +01:00
Claudio Cambra
0262c77d27 Remove close/dismiss button from encryption message 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-28 18:24:40 +01:00
Claudio Cambra
a243f7c4d1 Prevent bad encrypting of folder if E2EE has not been correctly set up 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-28 17:48:53 +01:00
rakekniven
5353f4f92d l10n: Fixed grammar 
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2022-11-28 14:37:24 +01:00
Claudio Cambra
2459a3a9f3 Rename 'Enable encryption' button to 'Setup encryption' 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-25 11:53:41 +01:00
Claudio Cambra
5a0d253187 Fix capitalisation of End-to-end 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-25 11:53:41 +01:00
Claudio Cambra
719a8f38bf Use material icons for lock and state-info 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-25 11:53:41 +01:00
Claudio Cambra
f6687c491d Change the colour of the encryption message box when encryption enabled 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-25 11:53:41 +01:00
Claudio Cambra
c1d6482c69 Add info icon when encryption not yet enabled 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-25 11:53:41 +01:00
Claudio Cambra
ef97200ac0 Show tick icon when encryption is enabled for account 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-25 11:53:41 +01:00
Claudio Cambra
89a66a98d8 Clearly tell user that E2EE has been enabled for an account 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-25 11:53:41 +01:00
Claudio Cambra
d24a40012e Fix bad custom button alignments, sizings, etc. 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-24 17:46:20 +01:00
Claudio Cambra
9a01480fcc Fix tray window margins, stop cutting into window border 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-24 15:02:37 +01:00
Claudio Cambra
53abfb4785 Add an end to end test utils file 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-23 08:40:46 +01:00
allexzander
6affc6e6ab Implement 'Leave this share' context menu entry. Fix incorrect sharing state for incoming and my shares in custom state icons and local database. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2022-11-22 12:14:20 +01:00
Matthieu Gallien
26fd4d2226 tidy some loop related code: avoid one letter variable names 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-11-18 16:02:21 +01:00
Matthieu Gallien
b5adbf3ab0 fix instances of: c++11 range-loop might detach Qt container warnings 
analyzed via clazy

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-11-18 16:02:21 +01:00
Claudio Cambra
58660b82f8 Ensure forcing a folder to be synced unpauses syncing on said folder 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-15 12:32:13 +01:00
Claudio Cambra
e281c46fa5 Fix ActivityList delegate warnings· 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-15 11:51:39 +01:00
Claudio Cambra
561b55800c Remove reference to inexistent property in NCCustomButton 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-15 11:48:24 +01:00
Matthieu Gallien
61c792c6f4
fully qualify types in signals and slots 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-11-15 09:57:54 +01:00
hefee
14292ec867 Fix typo of connector 
Signed-off-by: hefee <hefee@debian.org>
 2022-11-14 09:43:36 +01:00
tnixeu
d0d666d084 exclude kmessagewidget.cpp and wheelhandler.cpp from unity build 
Signed-off-by: tnixeu <4436784+tnixeu@users.noreply.github.com>
 2022-11-14 08:41:47 +01:00
tnixeu
e3adb90d60 skip unity build for files which fail to compile 
Signed-off-by: tnixeu <4436784+tnixeu@users.noreply.github.com>
 2022-11-14 08:41:47 +01:00
tnixeu
0b98f471ed add guards around string constants and into an anonymous namespace 
Signed-off-by: tnixeu <4436784+tnixeu@users.noreply.github.com>
 2022-11-14 08:41:47 +01:00
Claudio Cambra
8315770467 Make user status selector modal, show user header 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-09 17:39:28 +01:00
Claudio Cambra
ddc14a844d Remove unused remotePath in User::processCompletedSyncItem 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-09 16:29:21 +01:00
alex-z
4b6ce9f951 Do not use copy-assignment of QDialog. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-11-09 16:01:17 +01:00
Claudio Cambra
31a89c68d7 Fix share delegate button icon colors in dark mode 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-08 17:33:25 +01:00
Claudio Cambra
1a0903f178 Ensure 'Sync now' button doesn't have its text elided 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-08 16:32:04 +01:00
Claudio Cambra
161ed1ec9b Remove unused app pointer in CocoaInitializer 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-08 15:43:25 +01:00
Claudio Cambra
e45a023961 Remove unused internal link widget from old share dialog 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-03 14:03:38 +01:00
allexzander
6cb988b667 Fix accounts avatar issue when it becomes completely white due to non-changing account id member with changing account index in the list. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2022-11-03 10:14:44 +01:00
alex-z
b00007e07d Fix incorrect current user index when removing and adding an account. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-11-03 10:14:44 +01:00
allexzander
9ab89daedd E2EE. Do not generate keypair without user request. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2022-11-01 09:18:28 +01:00
Claudio Cambra
d79312b2f7
Change liveDialog to nullDialog 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:13 +01:00
Claudio Cambra
7ba6969e65
Moved all server mocking code for share model test to independent ShareTestUtils file 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:10 +01:00
Claudio Cambra
e021f25634
Add a suite of tests for ShareModel 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Test ShareModel error handling

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Improve testing of user/group shares in ShareModel

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add testing for maximum share expire date enforcement in ShareModel

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:09 +01:00
Claudio Cambra
77fb0c4808
Filter out sharees that already have active shares 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:09 +01:00
Claudio Cambra
0826e8d6ba
Improve server error handling in the ShareModel 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:09 +01:00
Claudio Cambra
c707dd0ccc
Check for state of file record retrieval in fileactivitylistmodel 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:09 +01:00
Claudio Cambra
79c0f3464a
Fix default date parser handling of timezones 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:09 +01:00
Claudio Cambra
ff4a4c63a1
Renamed _userStoppedTypingTimer to searchRateLimitingTimer 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:09 +01:00
Claudio Cambra
ce53c8439f
Add trailing comma to shareemodel enum 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:08 +01:00
Claudio Cambra
639fb21a13
Replace manual index bound checks with calls to checkIndex 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:08 +01:00
Claudio Cambra
fb4bb95b91
Perform inactive qquickwindow garbage collection when generating new file detail dialogs, raise existing dialog instead of always deleting 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:08 +01:00
Claudio Cambra
d2552ba439
Use auto where possible 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:08 +01:00
Claudio Cambra
b7d96781de
Add minimum size to file details window 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:08 +01:00
Claudio Cambra
121ab38177
Remove default cases in switches, rely on compiler warnings for missed cases 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:08 +01:00
Claudio Cambra
31afb02c84
Eliminate unneeded parent Item in FileActivityView 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:08 +01:00
Claudio Cambra
0ca927843f
Add early return checks for setter methods 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:08 +01:00
Claudio Cambra
685a0362fc
Refactor generation of dialogs, remove need for QSharedPointer and reduce use of pointers 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:07 +01:00
Claudio Cambra
f97f39375b
Remove Q_REQUIRED_RESULT from method with side-effect where result not always required, and viceversa 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:07 +01:00
Claudio Cambra
de0831c297
Use [[nodiscard]] more broadly in methods returning values, and respect it elsewhere 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:07 +01:00
Claudio Cambra
ec3c361c89
Show password set errors in the popup where passwords are set rather than in the main dialog 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:07 +01:00
Claudio Cambra
d92bc91bdf
Improve share view tab buttons 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:07 +01:00
Claudio Cambra
eda0328e9c
Change 'Link share' to 'Share link', matching server 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:07 +01:00
Claudio Cambra
6adefb572a
Improve flat buttons in share delegates 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:07 +01:00
Claudio Cambra
7971789112
Add a file details window/page, QMLify file sharing 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:03 +01:00
Matthieu Gallien
1dbdd8853f
add mising namespace 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-31 12:23:52 +01:00
Matthieu Gallien
521054dbf0
use new public API to open an edit locally URL 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-31 10:28:47 +01:00
Claudio Cambra
09997b189f Only show Sync Now button if account is connected 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-29 15:54:19 +02:00
Claudio Cambra
ff3eab1275 Modernise QString-related construction 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-29 14:03:58 +02:00
Claudio Cambra
b4be56c267 Add braces to all if statements missing them 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-29 14:03:58 +02:00
Claudio Cambra
7d05d8471b Expand use of const and auto, improve readability of accountsettings 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-10-29 14:03:58 +02:00
Claudio Cambra
72e154def1 Rename EditLocallyHandler to EditLocallyJob 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-29 13:32:48 +02:00
Claudio Cambra
ee8b12009a Ensure the checkTokenJob object gets deallocated 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-29 13:32:48 +02:00
Claudio Cambra
ae12519dd5 Show edit locally loading dialog sooner, improve feedback for user 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-29 13:32:48 +02:00
Claudio Cambra
9f7a699ad9 Refactor edit locally handler management away from application and into own class 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-29 13:32:48 +02:00
Claudio Cambra
4b6fdcc550 Don't show the user any potenitally questionable remote data 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-29 13:32:48 +02:00
Claudio Cambra
9438d3f1c7 Verify token before checking disk or modifying state 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-29 13:32:48 +02:00
Claudio Cambra
9a00aa6e66 Refactor edit locally into its own class, rather than bolting onto FolderMan 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-29 13:32:48 +02:00
Claudio Cambra
224621bb85 Refactor large editFileLocally FolderMan method into smaller, clearer separate methods 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-29 13:32:48 +02:00
Claudio Cambra
734c986cd1
Use addQueryParams for checkTokenForEditLocally SimpleApiJob 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-28 12:38:46 +02:00
Claudio Cambra
0b33ce2b40
Make sure to check relPath and compare to canonical cleaned path 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-28 12:38:18 +02:00
Claudio Cambra
0c6127de44
Make sure to encode the relPath 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-28 12:38:14 +02:00
Claudio Cambra
8683ee08e7
Validate edit locally token before sending to server 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-28 12:37:26 +02:00
Claudio Cambra
16532375da Fix macOS autoupdater settings 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-27 14:30:33 +02:00
Claudio Cambra
a537df296b
Constexpr settings constant strings, expand use of const and auto, modernise, in accountsmanager 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-10-26 13:28:24 +02:00
Claudio Cambra
c0baf5c93c Add a 'Sync now' button to the sync status header in the tray window 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-25 19:14:40 +02:00
Claudio Cambra
94b45d6d68 Add forcefoldersync method to folder manager 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-25 19:14:40 +02:00
Claudio Cambra
1a6326ed97 Create commonly accessible properties for current user colours in Style.qml 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-25 19:14:40 +02:00
Claudio Cambra
57f8de9fb6 Make Systray's void methods slots 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-10-25 12:19:17 +02:00
Matthieu Gallien
81f33ef94c emit missing signal to update folder sync status icon 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-24 16:53:06 +02:00
Claudio Cambra
9edc7357f7
Fix call notification dialog buttons 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-20 14:11:10 +02:00
Claudio Cambra
0bce17425b
Change unchanging settings strings into constexpr auto in accountmanager 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-19 13:31:50 +02:00
Claudio Cambra
8de5b0ffa5
Use prettyName more widely, instead of duplicating fallback string code 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-19 13:31:48 +02:00
Claudio Cambra
359627007b
Display the user's 'pretty' name in the webflow credentials 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-19 13:31:44 +02:00
Claudio Cambra
29afd9d5f3
Save account's display name in config 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-19 13:31:41 +02:00
Claudio Cambra
25ca698ad5
Improve user-related strings in webflow credentials 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-19 13:31:34 +02:00
alex-z
4e2ea9c00c Fix account not found when doing local file editing. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-10-17 14:56:30 +03:00
Camila
b55d71dffe The dismiss button is now a CustomButton component. 
Signed-off-by: Camila <hello@camila.codes>
 2022-10-17 11:29:23 +00:00
Camila
0624bec007 Fix the dismiss button: display it whenever possible. 
Signed-off-by: Camila <hello@camila.codes>
 2022-10-17 11:29:23 +00:00
Matthieu Gallien
f9949ee0de
edit locally requires a valid token 
check on server that the token received during a request to open a local
file is indeed a valid one

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-17 09:02:26 +02:00
Matthieu Gallien
a36672c1a4 fix review comments 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-12 12:13:45 +02:00
Matthieu Gallien
146bd44b09 use correct version copmparison on NSIS updater: fix update from rc 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-12 12:13:45 +02:00
Matthieu Gallien
ad10d4bb9c remove support for skipping an update: hard to understand for users 
skiping an update is probably there for historical reasons to work
around broken updates in the past

this can lead to users not getting an update they should be getting

this can elad to user confusion and the current user interaction is
broken if you do not go read the settings file with a text editor

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-12 12:13:45 +02:00
Claudio Cambra
924d5df3c4 Fix invisible user status selector button not being checked when user is in Offline mode 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-10-12 11:50:54 +02:00
Matthieu Gallien
ec1fb6209a improve logs when adding sync errors in activity list of main dialog 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-12 08:25:45 +02:00
alex-z
7672cb7903 Improve 'Handle local file editing' feature. Add loading popup. Add force sync before opening a file.' 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-10-10 17:13:06 +03:00
allexzander
289a641d74 VFS Windows: Display the sharing state and lock state in the 'Status' column of Windows Explorer 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2022-10-04 18:32:51 +02:00