mirrors/nextcloud-desktop
1
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2024-12-19 12:22:16 +03:00
Code Issues Projects Releases Packages Wiki Activity
19424 commits 487 branches 258 tags 462 MiB
Commit graph

434 commits

Author SHA1 Message Date
Claudio Cambra
1a6326ed97 Create commonly accessible properties for current user colours in Style.qml 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-25 19:14:40 +02:00
Claudio Cambra
9edc7357f7
Fix call notification dialog buttons 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-20 14:11:10 +02:00
Claudio Cambra
8de5b0ffa5
Use prettyName more widely, instead of duplicating fallback string code 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-19 13:31:48 +02:00
Camila
b55d71dffe The dismiss button is now a CustomButton component. 
Signed-off-by: Camila <hello@camila.codes>
 2022-10-17 11:29:23 +00:00
Camila
0624bec007 Fix the dismiss button: display it whenever possible. 
Signed-off-by: Camila <hello@camila.codes>
 2022-10-17 11:29:23 +00:00
Matthieu Gallien
ec1fb6209a improve logs when adding sync errors in activity list of main dialog 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-12 08:25:45 +02:00
alex-z
7672cb7903 Improve 'Handle local file editing' feature. Add loading popup. Add force sync before opening a file.' 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-10-10 17:13:06 +03:00
Matthieu Gallien
565a5f0999 add [[nodiscard]] attribute via clang-tidy 
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,modernize-use-nodiscard' -fix
under linux with most part of our code covered

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-04 11:14:45 +02:00
Matthieu Gallien
ecc588c27a avoid possibly crashing static_cast 
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,cppcoreguidelines-pro-type-static-cast-downcast' -fix

this can prevent casting to a type that is unrelated to the real type
and later cause a crash because you go into undefined behavior domain

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-10-03 10:23:24 +02:00
Claudio Cambra
6137fe246e Fix sync progress bar colours in dark mode 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-29 21:55:44 +02:00
Camila
7633cc490d
Fix 'Reply' action primary property. 
Primary is set to true when object type is 'room' or 'chat' and it set to
false when object type is 'call'.

Signed-off-by: Camila <hello@camila.codes>
 2022-09-29 15:20:56 +02:00
Camila
cbe22d8c1e
Remove unused property. 
Signed-off-by: Camila <hello@camila.codes>
 2022-09-29 15:17:10 +02:00
Claudio Cambra
db861e1ade Make activity action button an actual button, clean up contents 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-28 13:07:08 +02:00
Camila
348c9ea915 Fix persistent two factor auth notification. 
The server app returns a 202 code when the request succeeded, which was
not taken into account.

Signed-off-by: Camila <hello@camila.codes>
 2022-09-27 14:49:29 +00:00
Camila
f3513aaafe Fix two factor auth notification: 'Approve' link is a primary action. 
Signed-off-by: Camila <hello@camila.codes>
 2022-09-27 14:49:29 +00:00
Claudio Cambra
e721b03106 Remove sorting code in activitylistmodel as not needed with sortedactivitylistmodel 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-26 18:18:34 +02:00
Claudio Cambra
f71ddc4d43 Add a sortedactivitylistmodel that automatically handles sorting of activities 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-26 18:18:28 +02:00
Claudio Cambra
664a80cbb5 Clicking on file name clash activities now opens file in web UI were the clash can be resolved 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-26 12:10:38 +02:00
Claudio Cambra
6fa2542a10 Categorise file name clash sync file issues as separate FileNameClash enum treated as warning 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-26 12:10:38 +02:00
Claudio Cambra
80fcb6d95f Ensure strings in main window QML are presented as plain text and not HTML 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-26 10:57:18 +02:00
Claudio Cambra
bc08559655 Add a placeholder item for empty activity list 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-22 12:17:21 +02:00
Camila
7db68ad2c5
Fix two factor auth notification: activity item was disabled. 
User couldn't click on the links.

Signed-off-by: Camila <hello@camila.codes>
 2022-09-20 18:56:31 +02:00
Claudio Cambra
547e5a4675 Do not format text in QML components as HTML 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-17 15:05:22 +02:00
allexzander
65cd8d06bc Do not ignore return values for SyncJournalDB in accountsettings folderstatusmodel activitylistmodel abstractpropagateremotedeleteyncrypted lockgilejobs and propagator jobs 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2022-09-17 09:47:15 +02:00
Claudio Cambra
5a56584fba Deallocate call notification dialog objects when closed 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-14 12:34:47 +02:00
Claudio Cambra
1a5fa50fbb Refactor ActivityListModel population mechanisms 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-13 19:34:41 +02:00
Claudio Cambra
4c9e0873a3 Fix low-resolution file changed overlay icons in activities 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-13 18:55:47 +02:00
Claudio Cambra
871ad24e28 Fix ActivityItem activityHover error 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-10 12:11:23 +02:00
Claudio Cambra
b7b374c442 Fix rebase issue with activity list keyboard navigation PR 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-07 18:45:58 +02:00
Claudio Cambra
b820df90b9 Improve activity list highlighting/keyboard item selection 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-07 18:27:14 +02:00
Claudio Cambra
85c5002d34 Simplify activity list delegates by making them ItemDelegates, clean up 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-07 18:19:49 +02:00
Claudio Cambra
7882e224fd Set UnifiedSearchResultNothingFound visibility less messily 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-07 15:01:07 +02:00
Claudio Cambra
316f3981ab Align, resize, and layout everything uniformly in the unified search view 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-06 09:02:17 +02:00
Claudio Cambra
5acb0b272a Use same tooltip component everywhere 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-09-06 08:40:03 +02:00
alex-z
ba9a39856b Change Activities dialog show and Systray.forceWindowInit call sequence to fix the issue of Activities dialog not being shown. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-08-29 10:59:55 +03:00
alex-z
22a3b6cc16 Fix File Activities dialog not showing up. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-08-29 10:59:55 +03:00
Claudio Cambra
2ab95a30f9 Ensure file activity dialog is centered on screen and appears at top of window stack 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-17 14:01:32 +02:00
Claudio Cambra
7d41530284 Fix account switching and hover issues with UserLine component 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-10 18:07:02 +03:00
Claudio Cambra
37bd55b232 Fix unified seach item placeholder image source 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-10 13:31:45 +02:00
Claudio Cambra
387dfa96a1 Refactor user line 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-10 12:10:20 +02:00
Claudio Cambra
d86f25d215 Make UserStatusSelector a dismissible page pushed onto the tray window 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-10 09:22:33 +00:00
Claudio Cambra
0a89bf2335 Fix QML warnings 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-09 14:45:18 +03:00
Claudio Cambra
81bb290e4c Eliminate padding around the menu separator in the account menu 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-08 16:14:32 +02:00
Claudio Cambra
e9e482b174 Restyle unified search skeleton items animation and simplify their code 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-05 18:40:13 +02:00
Claudio Cambra
c74c466725
Merge branch 'master' into bugfix/clean-up-talkreplytextfield 2022-08-02 18:28:28 +02:00
Claudio Cambra
789179214f Clicking on an activity list item for a file opens the local file if available 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-02 17:43:18 +02:00
Claudio Cambra
b1deb6cd1d Replace unified search text field busy indicator with custom indicator 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-08-02 13:23:33 +02:00
Claudio Cambra
78b3e09f3b Clean up TalkReplyTextField, remove unnecessary parent Item 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-29 12:47:08 +02:00
Claudio Cambra
061f443920 Make apps menu scrollable when content taller than available vertical space, preventing borking of layout 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-27 12:19:10 +02:00
Claudio Cambra
7a78f2b19f Ensure that throttled notifications still appear in tray activity model 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-25 13:15:50 +02:00
Claudio Cambra
8d0df62c49 Stop styling QML unified search items hierarchically, use global Style constants 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-21 15:38:18 +02:00
Claudio Cambra
8dfe1647ed Stop clearing notifications when new notifications are received 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-21 13:14:51 +02:00
Claudio Cambra
e3d897cb7f Fix ActivityItemContent QML paintedWidth errors 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-18 15:13:58 +02:00
Claudio Cambra
539ba93fd1 QMLify the UserModel, use properties rather than setter methods 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-15 16:47:17 +02:00
Claudio Cambra
6872e1a75b Take ints by value rather than reference in UserModel methods 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-15 15:01:48 +02:00
Claudio Cambra
bc01db7cff
Merge branch 'master' into bugfix/limit-concurrent-notifications 2022-07-13 00:18:08 +02:00
Claudio Cambra
ce9e4a99c0 Refactor tray window opening code for clarity and efficiency 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-12 22:54:00 +02:00
Claudio Cambra
7d087026ca Limit concurrent notifications 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-12 20:24:50 +02:00
Claudio Cambra
b712eb95e2 Clean up systray methods, make more QML-friendly 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-06 11:26:53 +02:00
Claudio Cambra
22464f5005 Work around issues with window positioning on Linux DEs, hardcode tray window to screen center when new account added 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-04 14:11:19 +02:00
Claudio Cambra
a504dbf965 Close call notifications when the call has been joined by the user, or the call has ended 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-07-01 11:39:50 +02:00
Camila
fae5b5573c Clean up code, move values to Style.qml. 
Signed-off-by: Camila <hello@camila.codes>
 2022-06-28 09:25:48 +02:00
Camila
3ff781ee17 Talk reply field should now have the same height as the 'Reply' button. 
Signed-off-by: Camila <hello@camila.codes>
 2022-06-28 09:25:48 +02:00
Claudio Cambra
b7c2e16aa9 Make client language gender-neutral and more clear 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-06-24 14:36:36 +02:00
Claudio Cambra
e873f3b348 Fix crashing when selecting user status 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-06-24 12:34:52 +02:00
Camila
ac0c227263 Remove unused signal fileActivityButtonClicked. 
Signed-off-by: Camila <hello@camila.codes>
 2022-06-23 10:10:55 +02:00
Camila
55d6035f1e absolutePath was undefined. 
It was not part of the model, the correct one was path (PathRole).

Signed-off-by: Camila <hello@camila.codes>
 2022-06-23 10:10:55 +02:00
Camila
7744ad29a9 Remove tooltip because it is only repeating the label of the link. 
It is bad for accessibility.

Signed-off-by: Camila <hello@camila.codes>
 2022-06-23 08:56:23 +02:00
Claudio Cambra
0d26929d41 Ensure call notification stays on top of other windows 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-06-22 10:25:51 +02:00
Camila
fc2408cf41 Add contrast to the text/icon of buttons if the server defined color is light. 
Signed-off-by: Camila <hello@camila.codes>
 2022-06-21 11:49:30 +02:00
Claudio Cambra
281e50f4cd Prevent call dialogs from being presented when do not disturb is set as the user status 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-06-10 11:30:16 +02:00
Camila
6ff82659ac Change color of text field to ncTextColor instead of ncSecondaryTextColor. 
Signed-off-by: Camila <hello@camila.codes>
 2022-05-25 12:08:53 +02:00
Camila
f911c546d9 Add a transparent background to the send reply button. 
Signed-off-by: Camila <hello@camila.codes>
 2022-05-25 12:08:53 +02:00
Camila
282aadb7e9 Reduce spacing above the notification buttons. 
Spacing is now the  same as space between lines in the text above.

Signed-off-by: Camila <hello@camila.codes>
 2022-05-25 10:01:38 +02:00
Camila
2fa834446a Fix 'TypeError: Cannot readproperty 'messageSent' of undefined'. 
Signed-off-by: Camila <hello@camila.codes>
 2022-05-24 11:51:55 +02:00
alex-z
43a37637cf Display chat message inside the OS notification. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-05-23 17:01:22 +03:00
Matthieu Gallien
d622999971 add explicit capture for lambda 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-05-17 13:33:22 +02:00
Valdnet
f4931026d7
i18n: Add a space 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2022-05-17 09:08:37 +02:00
Camila
290851c33a Convert primary, WEB and DELETE notification links to action buttons. 
Signed-off-by: Camila <hello@camila.codes>
 2022-05-16 22:03:53 +02:00
Camila
9c63615a78 Do not add a second DELETE to the list of actions in one notification. 
Signed-off-by: Camila <hello@camila.codes>
 2022-05-16 22:03:53 +02:00
alex-z
53654b2a50 Allow manual renaming of files and folders with spaces. Allow uploading invalid file name via the InvalidFileName dialog. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-05-16 18:07:26 +03:00
Claudio Cambra
463496153a Fixed several issues with activity items relating to icon colouration and activity item sizing + layout 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-05-16 16:42:53 +02:00
Claudio Cambra
b6def51945 Fix notifications not being shown when they should be 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-05-16 14:28:33 +02:00
alex-z
514f72f975 Use proper online status for user ('dnd', 'online', 'invisible', etc.) to enable or disable desktop notifications. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-05-16 10:47:05 +03:00
Camila
e4a0d57bc8
Do not replace strings in action links coming from the notification api. 
Signed-off-by: Camila <hello@camila.codes>
 2022-05-12 12:47:48 +02:00
rakekniven
994c2e02d8 l10n: Changed triple dot to ellipsis 
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
 2022-05-04 11:33:47 +02:00
Claudio Cambra
7129bf2489 Add user avatars in talk notifications in activity list 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-05-02 15:12:45 +02:00
Matthieu Gallien
2d27a68e73 show errors on lock/unlock actions 
use a native dialog to show users errors when trying to lock/unlock
files

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-05-02 13:52:05 +02:00
alex-z
7b441a0f6e Optimize activities fetch requests. Do not fetch when the Tray is not open. Fetch next subset only when scrolling. Fix duplicate notifications. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-04-29 20:59:56 +03:00
Claudio Cambra
3f5243aaee Add an incoming talk call notification to the desktop client 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>

Co-authored-by: Camila <hello@camila.codes>
 2022-04-28 09:13:13 +02:00
Claudio Cambra
010f49a392
Realigned and resized thumbnails 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-04-27 18:02:37 +02:00
Claudio Cambra
15078260b4
Removed spacing between activies, labels now centre-aligned 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-04-20 18:07:41 +02:00
Claudio Cambra
7b65c1ceed
Fix thumbnails for new files made while client open 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-04-19 10:16:43 +02:00
Claudio Cambra
5ce736222e Use header text color to improve contrast with header colours when hovering on themed elements 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-04-15 13:17:09 +02:00
Camila
74d214726c
Remove unused function parameter. 
Signed-off-by: Camila <hello@camila.codes>
 2022-04-06 10:38:01 +02:00
Camila
6189b2115e
Adress design issues. 
- The input field was not using the  theming.
- After submitting the reply, the text and icon on the left were moving.

Signed-off-by: Camila <hello@camila.codes>
 2022-04-06 10:38:01 +02:00
Camila
f524635cf4
Do not hide'View chat' link. 
This logic was also hiding 'Answer call'.

Signed-off-by: Camila <hello@camila.codes>
 2022-04-06 10:38:01 +02:00
Camila
ead4eeda1e
Windows fix: activityIndex was not being passed to the lambda slot function. 
Signed-off-by: Camila <hello@camila.codes>
 2022-04-06 10:38:00 +02:00
Camila
c254572e80
Add 'Reply' as activity link instead of changing the 'View chat' link. 
- Align 'Reply' button.
- Do not display 'View chat' as a link: the 'View chat' action is active when
the user clickcs on the notification item in the tray window.
- Convert the QByteArray verb value to String.
- Handle logic to toggle the reply textfield in the QML code.

Signed-off-by: Camila <hello@camila.codes>
 2022-04-06 10:38:00 +02:00
Claudio Cambra
a2e1c68c26 Fix broken activity icon and loading entries colour in unified search 
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
 2022-04-05 16:41:11 +00:00