Commit graph

19424 commits

Author SHA1 Message Date
Claudio Cambra
b440e3011d Display tooltip showing names of overflowing tags in FileDetailsPage's overflow tag
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 18:23:33 +08:00
Claudio Cambra
30830b44cc Add overflow tag string property to filetagmodel which stringifies omitted tags
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 18:23:33 +08:00
Claudio Cambra
ce22c409e1 Test important properties in testfiletagmodel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 18:23:33 +08:00
Claudio Cambra
73b94bcf2f Add test for maxTags in FileTagModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 18:23:33 +08:00
Claudio Cambra
1bab57b176 Notify change in tags when maxTags set in filetagmodel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 18:23:33 +08:00
Claudio Cambra
6c68341422 Add test for tags in filetagmodel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 18:23:33 +08:00
Claudio Cambra
ccb07af56a Provide different propfind replies depending on request props in testfiletagmode
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 18:23:33 +08:00
Claudio Cambra
89d7e17674 Add FakePropfindReply that accepts raw QByteArray as payload
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 18:23:33 +08:00
Claudio Cambra
955f4de7d2 Add initial testing setup for file tag model
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 18:23:33 +08:00
Claudio Cambra
b79a038d92 Add support for system tags in filetagmodel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 18:23:33 +08:00
Claudio Cambra
045541d323 Implement support for system tags in propfindjob
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

fix
2023-05-16 18:23:33 +08:00
Claudio Cambra
bfb720fc35 Extract propfind tag xml node processing into separate method
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 18:23:33 +08:00
Claudio Cambra
29c17132e9 Properly parse tags in propfind request
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 18:23:33 +08:00
Claudio Cambra
b5cc4b41ce Extract propfind result data processing into separate method
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 18:23:33 +08:00
Claudio Cambra
6e9fed0198 Clean up includes in networkjobs
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

fix for header fix
2023-05-16 18:23:33 +08:00
Claudio Cambra
a386d8f008 Do not use magic string for propfind prop element tag name
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 18:23:33 +08:00
Claudio Cambra
9324fe0d78 Use constexpr in networkjobs notModifiedStatusCode
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 18:23:33 +08:00
Claudio Cambra
43bcecdeb0 Simplify Propfind XML parsing using QDomDocument instead of complex QXmlStreamReader-based parsing
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 18:23:33 +08:00
Claudio Cambra
06b3dc9cc8 Modernise PropfindJob with new for and const auto
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 18:23:33 +08:00
Claudio Cambra
e2bd9e69e1 Fix layout of tags with differing sizes and oversized tags
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 18:23:33 +08:00
Claudio Cambra
65e7f6da9c Simplify file tag model updating in filedetails, only require folder pointer
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 18:23:33 +08:00
Claudio Cambra
cb8cab6f41 Display filetags in file details window
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 18:23:33 +08:00
Claudio Cambra
a3fc467cf0 Simplify FileTag component
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 18:23:33 +08:00
Claudio Cambra
791eb87afc Instantiate FileTagModel in FileDetails
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 18:23:33 +08:00
Claudio Cambra
c6d29e7d77 Add ability to limit maximum amount of tags displayed
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 18:23:33 +08:00
Claudio Cambra
213e3743e1 Expose account and serverRelativePath of FileTagModel as QPROPERTYs
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 18:23:33 +08:00
Claudio Cambra
49b5fb32f9 Implement FileTagModel QAbstractListModel methods
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 18:23:33 +08:00
Claudio Cambra
9cc241bf96 Add capability for FileTagModel to fetch tags
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 18:23:33 +08:00
Claudio Cambra
84c8392491 Get account and relativeserverpath in constructor for FileTagModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 18:23:33 +08:00
Claudio Cambra
f763bd00fb Add a FileTagModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 18:23:33 +08:00
Claudio Cambra
0bdab1ee58 Add FileTag QML component
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-16 18:23:33 +08:00
Camila
2d27e4a0c9
Merge pull request #5687 from nextcloud/bugfix/notifications
Dismiss notifications
2023-05-16 07:12:24 -03:00
Camila
d6db8fcbd6 Add a dismiss link for notifications without it.
- Fix for #5606 and #5585.
- That is how it is done in the server and other clients.
- Update tests.

Signed-off-by: Camila <hello@camila.codes>
2023-05-16 11:17:37 +02:00
Claudio Cambra
6d6f9a8e9a
Merge pull request #5680 from nextcloud/bugfix/putmultifilejob-crash-mac
Fix unrecoverable freezing when PutMultiFileJob is used with upload rate limits enabled
2023-05-15 22:02:37 +08:00
Claudio Cambra
49bb5a005c Modernise BandwidthManager::absoluteLimitTimerExpired
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-15 20:46:21 +08:00
Claudio Cambra
23890b7d4c Use modern for loop in BandwidthManager::relativeDownloadDelayTimerExpired
getFileJobSigned-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-15 20:46:21 +08:00
Claudio Cambra
dbdce45797 Bring improvements of new cpp to BandwidthManager::relativeDownloadMeasuringTimerExpired
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-15 20:46:21 +08:00
Claudio Cambra
350fa72478 Modernise and improve readability of BandwidthManager::relativeUploadDelayTimerExpired
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-15 20:46:21 +08:00
Claudio Cambra
c8e78673c9 Modernise BandwidthManager::relativeUploadMeasuringTimerExpired with const auto, readability, etc
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-15 20:46:21 +08:00
Claudio Cambra
a547f55f2f Fix deadlock when using putmultifilejob with rate limits enabled
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-15 20:46:21 +08:00
Claudio Cambra
f28a1a368e Modernise BandwidthManager::switchingTimerExpired
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-15 20:46:21 +08:00
Claudio Cambra
7d763fa6bc Log if PutMultiFileJob oneDevice has error
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-15 20:46:21 +08:00
Claudio Cambra
651615ce94 Do not close putmultifilejob devices if not open, log when they are not open
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-15 20:46:21 +08:00
Claudio Cambra
35b05fca85 Increase logging around emission of putmultifilejobs
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-15 20:46:21 +08:00
Claudio Cambra
811a4036cb Don't bother creating a unique ptr for computeChecksum as we never use the guarded ptr 2023-05-15 20:46:21 +08:00
Claudio Cambra
afddc1bca0 Improve general readability of bulkpropagatorjob.cpp
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-15 20:46:21 +08:00
Claudio Cambra
98b8fde2f0 Remove unnecessary double declaration of namespace in bulkpropagatorjob
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-15 20:46:21 +08:00
Claudio Cambra
4375a24f0f Clean up and const autofy BulkPropagatorJob::scheduleSelfOrChild
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-15 20:46:21 +08:00
Claudio Cambra
37cf71a9a7 Don't bother creating a unique ptr for PutMultiFileJob as we never use the guarded ptr
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-15 20:46:21 +08:00
Claudio Cambra
311dcf29c6 Clean up putmultifilejob class definition
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-05-15 20:46:21 +08:00