15397 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
Christian Kamm	b431f4ef0c	Discovery: Fix log output for instructions	2020-12-15 10:58:13 +01:00
Christian Kamm	ce420d77a8	Discovery: Don't rebuild invalidFilname regex each call	2020-12-15 10:58:13 +01:00
Christian Kamm	113124cde5	Discovery: Introduce smaller functions	2020-12-15 10:58:13 +01:00
Christian Kamm	4f6f706f40	Excludes: drop csyncTraversalMatchFun() ... The new discovery can call the traversal match function directly.	2020-12-15 10:58:13 +01:00
Christian Kamm	1d4e4fafcc	Discovery: Add back virtual file instruction checks	2020-12-15 10:58:12 +01:00
Olivier Goffart	a4e139969c	Fix windows build	2020-12-15 10:58:12 +01:00
Olivier Goffart	8490664860	Account Settings: fix progress being written in white when there are errors	2020-12-15 10:58:12 +01:00
Christian Kamm	dd34cbc751	Virtual files: Wipe selective sync settings when enabled	2020-12-15 10:58:12 +01:00
Christian Kamm	60de1c9720	virtual files: show option only when branding allows it	2020-12-15 10:58:12 +01:00
Christian Kamm	251e01a440	Virtual files: Use theme to check for option availability	2020-12-15 10:58:12 +01:00
Olivier Goffart	94e63ef7b9	Account Settings: Add a context menu entry to enable or disable virtual files ... Issue #6725	2020-12-15 10:58:12 +01:00
Olivier Goffart	18f6e346b8	Upload: Do not error out if the server do not send the X-OC-MTime: accepted header ... If the server does not set the mtime, it is not a big problem for the synchronisation. The test was used before so we could do a PROPPATCH for server that did not support this header. But now that all server supports that we don't need to to the check. (We do not do the PROPPATCH since we got rid of the neon dependency) Apparently, it may happen that some backend don't support setting mtime and this can lead to this error. https://github.com/owncloud/client/issues/6797	2020-12-15 10:58:11 +01:00
Dominik Schmidt	a985ea8624	Do not select ownCloud in Finder after installation to fix #6781	2020-12-15 10:58:11 +01:00
Olivier Goffart	15eab07866	OAuth2: Store 'Account::davUser' in the config, and use that user for connecting ... We need to use the user id to check if we are connected to the right account. These might be different from the HTTP Basic Auth login. (LDAP setups) When the account was configured as an oauth2 account form the wisard, the http_user was already set correctly to the user id. But when the server is upgrading from basic auth to oauth2, we need to pick the right login. Note that Account::davUser() already defaults to the HTTP user when none is set, so this means the upgrade will be fine if this is not set in the config. Issues: https://github.com/owncloud/oauth2/issues/109 https://github.com/owncloud/enterprise/issues/2781	2020-12-15 10:58:11 +01:00
Olivier Goffart	75f66ddaa1	Local discovery: always recurse within touched directory ... If the file system watcher tells us a directory was modified, we should recurse into it because it means it is probably a new directory Issue #6804	2020-12-15 10:58:11 +01:00
Christian Kamm	e10e953c66	PropagateUpload: Avoid crash due to cascading aborts ... https://sentry.io/owncloud/desktop-win-and-mac/issues/698694072/activity/	2020-12-15 10:58:11 +01:00
Olivier Goffart	640cf0c71e	Fix leaks in tests ... As discovered by AddressSanitizer	2020-12-15 10:58:11 +01:00
Christian Kamm	d1aedcfd3c	Discovery: restructure processFileAnalyzeLocalInfo	2020-12-15 10:58:10 +01:00
Christian Kamm	a2839bd40a	Discovery: easy conditions first in processFileAnalyzeRemoteInfo ... Removing two levels of indent that way	2020-12-15 10:58:10 +01:00
Christian Kamm	76341904e9	Discovery: Add comments	2020-12-15 10:58:10 +01:00
Olivier Goffart	5a1c93d0ac	Discovery: make sure finished is not called twice, even in case of errors	2020-12-15 10:58:10 +01:00
Olivier Goffart	b86e1efc9a	Remove the backup deteciton code which was used for server < 9.1	2020-12-15 10:58:10 +01:00
Olivier Goffart	f666511a4b	Discovery: Remove stale DB entries ... And test the Remove/Remove case. This means we need to always query the database for all the entries. This showed another small bug in the test in which sync item for virtual files at the root could have a slash in front of them.	2020-12-15 10:58:10 +01:00
Christian Kamm	5683278fab	Discovery: Comments and visibility adjustments	2020-12-15 10:58:09 +01:00
Olivier Goffart	aa18e10ff5	Discovery: cleanups and comments	2020-12-15 10:58:09 +01:00
Olivier Goffart	b10b3e5eeb	Discovery: move checkMovePermissions to its own function	2020-12-15 10:58:09 +01:00
Olivier Goffart	edd866b32b	Discovery: Adjust the instruction in case of resolved conflict ... When resolving a conflict because the file was just updated on the server, we write all the metadata on the database immediatly, so INSTRUCITON_NONE is enough and UPDATE_METADATA is not needed	2020-12-15 10:58:09 +01:00
Olivier Goffart	7cddaf82ab	ProcessDirectoryJob: always set _childModified to true, regardless the direction ... This was like that to handle the case of CSYNC_INSTRUCTION_TYPE_CHANGE, but just add a condition in this location.	2020-12-15 10:58:09 +01:00
Olivier Goffart	46510c2f39	Discovery phase: refactor some code in DiscoveryPhase::findAndCancelDeletedJob ... Less code duplication	2020-12-15 10:58:09 +01:00
Olivier Goffart	1c2a3279bb	New Discovery Algorithm: more cleanups ... - rename progress() to be more explicit - Make some more member of the discovery phase private	2020-12-15 10:58:09 +01:00
Olivier Goffart	2f8c77c54f	Fixup commit 835c9163374f42003aa2f7795ade3f4ff62c8877 ... The previous code considered the also HTTP 207 code without the application/xml header to have this message. httpCode 0 does not make much sense anyway. This change the behavior to consider any 2xx without the xml header to show this error message	2020-12-15 10:58:08 +01:00
Olivier Goffart	c009dae1ce	New discovery algorithm: fixups ... Adapt reviews from ckamm in https://github.com/owncloud/client/pull/6738#pullrequestreview-164623532 - SyncJournalFileRecord: initialize everything inline - Add more comments - And some ENFORCE	2020-12-15 10:58:08 +01:00
Olivier Goffart	059f722b3b	Move Result to its own header	2020-12-15 10:58:08 +01:00
Olivier Goffart	afed46afcc	New discovery algorithm: Parallel PROPFIND	2020-12-15 10:58:08 +01:00
Olivier Goffart	c8eff3da2d	New Discovery algorithm: Remove the sync cleanup phase ... Since we do not recurse within some directories, many files are not seen. The stale entry will cleanup by themself as the sync engine try to remove the files that are already removed. Should we need to actually do this cleanup, it should be dotected in the discovery.	2020-12-15 10:58:08 +01:00
Olivier Goffart	35c0cf4e59	New discovery algorithm: Set the originalFile for ignored files ... This is used to show the name in the UI	2020-12-15 10:58:08 +01:00
Olivier Goffart	52dcfcb166	New Propagation algorithm: Fetch, and emit, the root etag ... Remove the feature to concatenate etags as servers that don't have a root etag are no longer suported	2020-12-15 10:58:07 +01:00
Olivier Goffart	d25d87e92c	New Discovery Algorithm: Ge tthe size of new folders ... Also add a test that this works properly	2020-12-15 10:58:07 +01:00
Olivier Goffart	ef542ac83d	New Discovery algorithm: Split the process function even further ... Move the finialization in its own function. This allow to save a bit of code duplication. Also change the order of the parameter in the constructor for consistency	2020-12-15 10:58:07 +01:00
Olivier Goffart	fc69dda246	New Discovery Algo: Refactor by splitting the processFile in two	2020-12-15 10:58:07 +01:00
Olivier Goffart	b7d827d6d0	New Discovery Algorithm: Handle rename of virtual files	2020-12-15 10:58:07 +01:00
Christian Kamm	e58a25d7c5	Virtual files: Renames propagate #6718	2020-12-15 10:58:07 +01:00
Olivier Goffart	3289675b8d	Folder Wizard: Disable the 'choose what to sync' treeview if virtual files are selected ... Don't allow to configure virtual files with a selective sync blacklist	2020-12-15 10:58:07 +01:00
Olivier Goffart	d8fa8e270f	AccountSetting: Fix Small Memoy leak	2020-12-15 10:58:06 +01:00
Olivier Goffart	f0ddf179a5	Fix tx.pl ... The conflict filename changed	2020-12-15 10:58:06 +01:00
Olivier Goffart	0ba9dc7dd1	AccountSettings: Force sync should wipe the blacklist ... Issue #6757	2020-12-15 10:58:06 +01:00
Olivier Goffart	68ace415d4	Virtual files: don't check for new big folders ... https://github.com/owncloud/client/issues/6724#issuecomment-417368475	2020-12-15 10:58:06 +01:00
Olivier Goffart	75a57778d9	Virtual files: Don't show selective sync ... Issue #6724	2020-12-15 10:58:06 +01:00
Olivier Goffart	46aa8fd1f8	Socket API: add an option to replace existing files with virtual files ... Issue #6726	2020-12-15 10:58:06 +01:00
Olivier Goffart	afc953b649	Update the minimum supported version ... We want to warn if the server version is not supported and did not get appropriate QA for this client version. https://github.com/owncloud/enterprise/issues/2687	2020-12-15 10:58:05 +01:00