mirrors/nextcloud-desktop
1
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2024-12-19 20:32:03 +03:00
Code Issues Projects Releases Packages Wiki Activity
19840 commits 488 branches 258 tags 463 MiB
Commit graph

370 commits

Author SHA1 Message Date
Claudio Cambra
ac218b000e
Use single convenience method to handle trailing slash in paths for Folder 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-08-04 17:40:36 +08:00
Dries Mys
243fcfedb9 Small coding improvements 
Signed-off-by: Dries Mys <dries.mys@my-dreams.be>
 2023-07-26 11:05:50 +02:00
Dries Mys
984d06e82a Convert VFS file to placeholder again if needed 
Note that Windows may convert a placeholder file to a regular file when
it is replaced by another file, even if the old and new file (inode,
modified time, file size) are identical.

WIN32_FIND_DATA::dwReserved0 is only initialised in case of
FILE_ATTRIBUTE_REPARSE_POINT is set. This field is not a bit set. Check
corrected to only include all cloud reparse points and not other special
reparse points.

Signed-off-by: Dries Mys <dries.mys@my-dreams.be>
 2023-07-26 11:05:50 +02:00
Dries Mys
55f27cdb96 Small coding improvements 
Signed-off-by: Dries Mys <dries.mys@my-dreams.be>
 2023-07-20 13:44:55 +02:00
Dries Mys
76376aa052 Set VFS PinState to Excluded for ignored files. 
Setting PinState to Excluded ensures the syncing icon is not shown for ignored items.
If the PinState is not set to Excluded, also all parent directories are shown as being synced, which is very inconvenient for the end user as it seems that some folder are never fully synced by Nextcloud which isn't the case.
As long as .lnk files are not converted to placeholder files, also set them to Excluded to hide the syncing icon.

Closes #5524
Closes #5594

Co-authored-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
Signed-off-by: Dries Mys <dries.mys@my-dreams.be>
 2023-07-20 13:44:55 +02:00
Matthieu Gallien
5372276779 add more metadata to sync errors to allow filtering 
in order to be able to filter some errors when showing them into the
main dialog activity list, add some more info about the error to know
the origin (like a network issue or a sync issue)

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-06-07 17:25:44 +02:00
alex-z
81ecba8daa Allow opening a file or folder in the local sync root. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-05-16 12:33:34 +02:00
alex-z
da6a7d3dac Unlock Office files when they are closed. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-04-25 12:54:37 +02:00
alex-z
a428c17c37 Do not display error status and messages when aborting a sync during hydration request in VFS mode. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-04-06 22:26:35 +02:00
Matthieu Gallien
7c655cf679
use a getter to query encryption status 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-03-31 17:18:28 +02:00
Matthieu Gallien
079d392d36
move init to default value in class declaration 
done via clang-tidy and manual tuning

run-clang-tidy -p build -header-filter='.*' -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,modernize-use-default-member-init' -fix

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-02-06 10:43:05 +01:00
Matthieu Gallien
602b8db5e2
handle case clash conflicts in a similar way to content conflicts 
introduce a new type of conflict for case clash filename conflicts

add proper handling including a new utility class to solve them and a
new dialog for the user to pick a fix

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2023-01-25 16:37:35 +01:00
Claudio Cambra
3e00df4732
Don't shadow rec variable in removeLocalE2eFiles 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-24 17:00:16 +01:00
Claudio Cambra
95aa3ee53b
Make encrypted folder paths to delete non-relative when checking if they are encrypted 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-24 17:00:16 +01:00
Claudio Cambra
4c1a9f787a
Ensure blacklists get updated when removing folder sync 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-24 17:00:16 +01:00
Claudio Cambra
d93fc8eb3d
Don't use foreach in Folder::removeLocalE2eFiles 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-24 17:00:15 +01:00
alex-z
ad258473c4
Fix issue of e2ee folders not disappearing when disabling the e2e. Properly process blacklisted e2ee folders instead of ignoring them. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2023-01-24 17:00:15 +01:00
Claudio Cambra
efcd23eb06
Ensure blacklisted e2ee files get deleted 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-24 17:00:15 +01:00
Claudio Cambra
b333310ffe
Clean up sync termination and restart procedure after file blacklisting done 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-24 17:00:15 +01:00
Claudio Cambra
fdaedc4914
Only add root-most encrypted folder to the blacklist 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-24 17:00:15 +01:00
Claudio Cambra
7d208ec06e
Make sure to add e2ee files to normal blacklist too 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-24 17:00:15 +01:00
Claudio Cambra
093810f6b9
Only shedule affected paths for remote discovery after disabling e2ee 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-24 17:00:15 +01:00
Claudio Cambra
1fc1e95161
Use e2ee folder blacklist instead of deleting folders directly 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-24 17:00:15 +01:00
Claudio Cambra
12b2673ac2
Add test for deleting encrypted files 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-24 17:00:15 +01:00
Claudio Cambra
b57b35e7a4
Delete E2EE files/folders for accounts that have had E2EE disabled 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2023-01-24 17:00:14 +01:00
Claudio Cambra
b0d048b0b8 Fix conflicting definitions in anonymous namespace in Unity build 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-12-15 16:58:00 +01:00
Matthieu Gallien
a8025dc06a use .nextcloudsync.log to perform file monitoring test at start 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-12-15 11:11:20 +01:00
alex-z
f7ef2e5f44 Silence sync termination errors when running EditLocallyJob. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-12-12 17:39:48 +01:00
alex-z
838817239a Fix CI errors for Edit Locally. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-12-06 15:31:24 +01:00
alex-z
b673ab996e Edit locally job will only sync a specific file by modifying the state of the Sync Engine. All other running syncs will get terminated. Syncing is now optimized to run faster and it checks if the file has changed on the server before syncing it. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-12-06 09:37:03 +01:00
tnixeu
0b98f471ed add guards around string constants and into an anonymous namespace 
Signed-off-by: tnixeu <4436784+tnixeu@users.noreply.github.com>
 2022-11-14 08:41:47 +01:00
allexzander
b40c2dfe01 Revert "Remove behavior changes." 
This reverts commit 84d06ce9906df7bb6d87bf7093dd11fac6a6057a.

Signed-off-by: allexzander <blackslayer4@gmail.com>
 2022-09-17 09:47:15 +02:00
allexzander
d425005a29 Remove behavior changes. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2022-09-17 09:47:15 +02:00
allexzander
0cb448cf8e Do not ignore return values for SyncJournalDB in folder, encryptfolderjob, hydrationjob, and vfs_suffix. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2022-09-17 09:47:15 +02:00
alex-z
2a529eef3c Make sure Folder is deleted from the list and the SyncJournalDB is closed for every folder of the account that has been removed. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-09-10 10:34:34 +02:00
Matthieu Gallien
8551a14c48 ensure SyncEngine use an initialized instance of SyncOptions 
will prevent nextcloudcmd command line client from ignoring the settings
handled by SyncOptions

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-08-08 12:36:37 +03:00
alex-z
001deace2d Implement COM Dll for CfApi shell extensins. Implement Thumbnail Provider. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-07-29 19:26:53 +03:00
alex-z
53654b2a50 Allow manual renaming of files and folders with spaces. Allow uploading invalid file name via the InvalidFileName dialog. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-05-16 18:07:26 +03:00
alex-z
3f3b752e44 Save folder settings to config when force-switching VFS. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2021-12-14 16:33:35 +02:00
Matthieu Gallien
f1d834df8e properly query sync journal DB to know when to run fix for VFS 
the new method added to query the db is not working and so the fix for
vfs is executed at each sync run

the new method for bool was not really needed so let's just remove it
(and that will make the usage of SqlQuery be correct

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-19 14:19:04 +01:00
Felix Weilbach
c76a77e431 Correct virtual files placeholder files if needed 
In the past not all files were converted to placeholder files when
converting an existing sync folder to a virtual files folder. Because
some files were not converted to placeholder files, the status would
be wrong on the files. This code makes sure that every file in a
virtual files folder is a placeholder file. It could be removed in the
future.

Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-11-17 09:53:26 +00:00
Matthieu Gallien
5ab13b2adc add an option to enforce use of virtual files sync folder 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-05 16:56:24 +01:00
Matthieu Gallien
9658aea963 on switch to VFS real plugin, convert existing files to placeholders 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2021-11-04 15:02:27 +01:00
Felix Weilbach
0c9dce1154 Add file activity dialog 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-10-05 12:41:34 +00:00
Hannah von Reth
4b0122093a Add socket command to upload a selection of files based on a regex 
(cherry picked from commit 0ded3a56a9f3470a951b18eaa9d3c1b5e8db1135)
 2021-08-23 09:44:34 +02:00
Hannah von Reth
010fccb4fa Remove dead code 2021-08-23 09:44:34 +02:00
Christian Kamm
ebaa98fa7a owncloudcmd: Use env vars for chunk sizes #7078 
Moves a bunch of env var reading from Folder into SyncOptions.
 2021-08-23 09:44:34 +02:00
Hannah von Reth
5b457a1663 Use byte array for etag 2021-08-23 09:44:33 +02:00
Felix Weilbach
d72f7e9109 Check result of setPinState() 
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
 2021-08-11 20:20:39 +00:00
Valdnet
7ebbb499e0 l10n: Replace apostrophe with double quotation 
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
 2021-07-30 06:21:05 +00:00