Commit graph

21842 commits

Author SHA1 Message Date
Claudio Cambra
94a783c482 Signal enumeration of locked/unlocked file
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
4012d43bb9 Do not provide items if account is not set up correctly
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
7413cf6735 Display checkmark when file lock completed
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
419035c275 Fix NSExtensionFileProviderActionActivationRules for locking menu items
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
19c9c199a6 Add warn image to locking view if there is an error
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
4348869684 Fix internal layouting of lock view by simply using a nsview rather than fumbling with a stack view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
616ac2e50c Fix XIB initialisation in LockViewController
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
4dbfbc3d96 Fix file lock server url in lockviewcontroller
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
f3e341c860 Make sure not to check for kit before we should in shares table view data source
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
7ae9f833aa Once finished locking/unlocking, stop loading indicator
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
d312d009f7 Pull out error handling from completionHandler for nckit lockunlock
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
516fc7cc10 Stop loading indicator when presenting error
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
65e4297e12 Add convenience function to stop/hide loading indicator in lock view controller
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
c7d2ed3fcb Perform lock/unlock procedure in lock view controller
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
3b33b2651b Process target item on init of lock view controller
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
fdbc52b83b Add method to simply provide file details in locking view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
05e5793f06 Add convenience method to present and log errors in lock view controller
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
81566eec09 Move item metadata fetch into util file in FileProviderUIExt
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
624b72bd80 Move service connection fetcher method into a utils file
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
4edbb4b50d Add close action to lock view controller
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
10f37d3af1 Design lock view in file provider ui
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
e3b6cd9935 Add basic properties to lock view controller
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
ec66bcd19b Handle new locking action identifiers in document action view controller of FileProviderUIExt
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
501c1c4d62 Add lock/unlock actions in FileProviderUIExt info plist
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
73674bf633 Add basic LockViewController components
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
1d0e3bc98e Move all sharing components for FileProviderUIExt into a Sharing folder
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Matthieu Gallien
3777a3b36d
Merge pull request #7102 from nextcloud/bugfix/fixOneRenameIssue
Bugfix/fix one rename issue
2024-09-12 09:50:36 +02:00
Matthieu Gallien
7a3ed38040 improve some log that are produced during discovery
would be usefull to track bugs during rename operations

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-12 09:50:27 +02:00
Matthieu Gallien
092175e23a avoid wrong tracking of renamed folders during discovery
ensure server rename operations are tracked as server rename operations

ensure local rename are tracked as local rename operations

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-12 09:50:27 +02:00
Matthieu Gallien
18bb41b410 add automated tests for complex move scenario
we rename the top folder and we rename a not direct child that is also
moved to another folder below the original renamed top folder

so
a/b/c
a/b/d/file

will be
e/b/c/f/file

with
a -> e
d-> f

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-12 09:50:27 +02:00
Matthieu Gallien
341263b97e
Merge pull request #7061 from nextcloud/bugfix/deleteReadOnlyRemnantsFolders
Bugfix/delete read only remnants folders
2024-09-12 09:42:46 +02:00
Matthieu Gallien
8faefc6fa2 delete invalid folders and restart sync automatically
users should then notice that the sync errors are gone

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-12 08:40:50 +02:00
Matthieu Gallien
34c25ecb43 let FileSystem::removeRecursively be able to delete read-only folders
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-12 08:40:50 +02:00
Matthieu Gallien
a118c0ad1e detect remnants read-only folders to delete: try to delete them
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-12 08:40:50 +02:00
Matthieu Gallien
155c61acbb let cancel sync and finish sync lambda be reusable methods
will enable implementation of other ways to interrupt sync after
discovery to get user feedback

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-12 08:40:50 +02:00
Matthieu Gallien
b7b72bf9f2 collect remnant read-only folders during discovery
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-12 08:40:50 +02:00
Tobias Kaminsky
9ffd0d455f
Merge pull request #7103 from nextcloud/bugfix/mac-crafter-codesign-notarisation
Code-sign client via mac-crafter so it may pass notarisation
2024-09-12 07:16:47 +02:00
Nextcloud bot
3facce2b46
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-12 02:44:51 +00:00
Claudio Cambra
7f3b13718a
Move building into separate subcommand, add subcommand just for codesigning
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 03:54:01 +08:00
Claudio Cambra
8620ff5127
Always move final product to product path in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 03:53:41 +08:00
Claudio Cambra
dcd640a504
Fix codesigning of qtwebengine related helper app in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-11 23:26:51 +08:00
Claudio Cambra
ad428c759f
Use deep codesigning by default in mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-11 23:26:30 +08:00
Claudio Cambra
9126b66ad4
Make sure to code-sign all binaries in app bundle
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-11 22:56:41 +08:00
Claudio Cambra
d51def6638
Remove get-task-allow entitlement when code-signing app extensions
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-11 22:56:40 +08:00
Claudio Cambra
b0c4f650fe
Fix notarisation issues for Sparkle in mac-crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-11 22:56:40 +08:00
Claudio Cambra
76fbf012ea
Add convenience method to save the entitlements of a bundle to a file as XML
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-11 21:54:49 +08:00
Claudio Cambra
e1df119bf3
Fix issue with placing app bundle in product directory if an existing build is there
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-11 21:54:18 +08:00
Tobias Kaminsky
ebe6880628
Merge pull request #7098 from nextcloud/bugfix/legacy-building-filesystem-mac
Fix building of client on macOS 10.13 and 10.14
2024-09-11 08:29:51 +02:00
Claudio Cambra
72ff92468b
Wrap use of folder permissions restore in mac ifdefs
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-11 14:21:25 +08:00
Claudio Cambra
6f393f1c63
Wrap all uses of FileSystem::setFolderPermissions in ifdefs for macOS
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-11 14:18:15 +08:00