Commit graph

4196 commits

Author SHA1 Message Date
alex-z
a428c17c37 Do not display error status and messages when aborting a sync during hydration request in VFS mode.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-04-06 22:26:35 +02:00
Matthieu Gallien
7c655cf679
use a getter to query encryption status
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-03-31 17:18:28 +02:00
Matthieu Gallien
20422f0247 when local sync folder is overriden, respect this choice
may lead to inadvertant data loss, not sure if that could be an issue

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-03-31 09:21:48 +02:00
Matthieu Gallien
d2cd4efaaa fix the logic generating the config file
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-03-22 10:17:28 +01:00
Matthieu Gallien
903c475d5a store in config file that we want to enable vfs when generating config
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-03-22 10:17:28 +01:00
Matthieu Gallien
e0bdbd1387
follow shouldNotify flag to hide notifications when needed
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-03-21 09:10:12 +01:00
alkl58
1e37697152 Show server name in tray main window
Signed-off-by: Alkl58 <alkl58@protonmail.com>
2023-03-10 16:51:22 +01:00
Camila
ec7b5481d4 Fix display of 2FA notification.
Fix for issue #5421: add server notifications to the activities list
when the user needs to act on it.

Signed-off-by: Camila <hello@camila.codes>
2023-03-08 10:53:51 +01:00
Axel Lender
664e0c18ec Resize WebView widget once the loginpage rendered
When the login dialogue displays the login page itself
the WebView widget did not resize according to
the dimensions of the login page.

Signed-off-by: Axel Lender <lender@b1-systems.de>
2023-03-07 09:55:04 +01:00
alex-z
31de652d9b Display 'Search globally' as the last sharees list element
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-03-03 18:01:05 +01:00
alex-z
b6ba1fe0d6 Implement Secure filedrop link share. Move data from 'filedrop' to 'files' when syncing E2EE folders.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-03-02 19:29:11 +01:00
Claudio Cambra
2e69a9c59a Move sharesChanged signal emission to handlePlaceholderLinkShare rather than repeating each time this method is called
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-03-01 18:40:29 +01:00
Claudio Cambra
f05e44a24a Don't display the placeholder link share of public link shares are not available
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-03-01 18:40:29 +01:00
Claudio Cambra
3560263472 Don't block loading if public link shares are disabled
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-03-01 18:40:29 +01:00
Claudio Cambra
4bbe851da1 Fix text labels in Sync Status component
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-28 23:07:09 +01:00
Claudio Cambra
a0107c43f1 Fetch account avatar info on account action construction, fixing avatar only showing up when action is clicked
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-28 18:08:29 +01:00
Claudio Cambra
f676979b29 Set placeholder image always as account action icon, as at app start there will not be a valid avatar to use ever
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-28 18:08:29 +01:00
Matthieu Gallien
01ecb639ab use new connect syntax
mainly done using clazy and old-style-connect check

close #5426

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-28 09:36:27 +01:00
Matthieu Gallien
c0549c5c03
fix issues reported by compiling windows code with clang-tidy
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-22 16:50:20 +01:00
Claudio Cambra
89ebfcae8e Try to initialise share manager again if we receive updated sharing permissions that would have previously prevented sharing
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-16 13:06:35 +01:00
Claudio Cambra
2fbdf1be8f Simplify check for file record sharing permission
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-16 13:06:35 +01:00
Claudio Cambra
893adb8280 Remove unused slotDeleteAccount in AccountSettings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-14 20:22:51 +01:00
Claudio Cambra
7084310a9f Remove unused AccountState::writeToSettings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-14 20:22:51 +01:00
Claudio Cambra
69d73d1333 Respond to folder creation at specific creation path on macOS
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-14 18:27:03 +01:00
Claudio Cambra
30ce2eab02 Notify when folder is created with full folder path in FolderCreationDialog
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-14 18:27:03 +01:00
Claudio Cambra
89d3022649 Do not search for folder twice
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-14 18:27:03 +01:00
Claudio Cambra
6c548145a2 Make sure to manually call folderwatcher when creating new folder from settings menu in macOS
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-14 18:27:03 +01:00
Claudio Cambra
1d525911f1
Make ShareModel's accountState and folder pointers QPointers to guard against crashes
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-06 12:30:50 +01:00
Claudio Cambra
bf8cb8305e
Create common validCapabilities used by several ShareModel methods checking account capabilities
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-02-06 12:29:35 +01:00
Matthieu Gallien
079d392d36
move init to default value in class declaration
done via clang-tidy and manual tuning

run-clang-tidy -p build -header-filter='.*' -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,modernize-use-default-member-init' -fix

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-06 10:43:05 +01:00
Matthieu Gallien
76e88572d6
more fixes for attributes without init value
done with clang-tidy

run-clang-tidy -p build -header-filter='.*' -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,cppcoreguidelines-pro-type-member-init' -fix

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-06 10:43:05 +01:00
Matthieu Gallien
ca932fe093
init attributes
discovered at runtime using valgrind

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-06 10:43:05 +01:00
Matthieu Gallien
b4a8981c03
initialize all variables
done with clang-tidy

run-clang-tidy -p build -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,cppcoreguidelines-init-variables' -fix

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-06 10:43:04 +01:00
Matthieu Gallien
82b062d2e9
prefer initialization of attribute inline
done with clang-tidy

run-clang-tidy -p build -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,modernize-use-default-member-init' -fix

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-06 10:43:04 +01:00
Matthieu Gallien
d2f5c6a5c7
initialize many attributes that could have been left without init value
done with clang-tidy

run-clang-tidy -p build -config="{Checks: '*', CheckOptions: [{key: UseAssignment, value: true}]}" -checks='-*,cppcoreguidelines-pro-type-member-init' -fix

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-06 10:43:04 +01:00
Camila
e533c6047c Update code style.
Signed-off-by: Camila <hello@camila.codes>
2023-02-02 08:43:51 +01:00
Camila
e0c1c67306 Fix: if the config did not exist, overrideserverurl had no effect.
When the client runs for the first time, setting the value was done before
the config file was created. It had no effect.

Signed-off-by: Camila <hello@camila.codes>
2023-02-02 08:43:51 +01:00
Camila
3596562101 Do not exit application when overrideserverurl param is a valid url.
Signed-off-by: Camila <hello@camila.codes>
2023-02-02 08:43:51 +01:00
Camila
9101e0a7f8 Only accept folder setup page if overrideLocalDir is set.
Fix for #5383.

Signed-off-by: Camila <hello@camila.codes>
2023-02-02 08:43:51 +01:00
Camila
72fe5f643c
By default do not display warning about backups made of the config file.
Use the setting showConfigBackupWarning to change the default value.

Signed-off-by: Camila <hello@camila.codes>
2023-02-01 19:00:40 +01:00
Camila
9ead33ab93
Improve warning message code readability.
Signed-off-by: Camila <hello@camila.codes>
2023-02-01 16:21:25 +01:00
Matthieu Gallien
76af889937
use QVersionNumber to compare versions and improve upgrade warning
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-01 13:28:01 +01:00
Matthieu Gallien
fb062f2dd7
fix wrong detectiion of current config file as a config migration
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-02-01 13:28:01 +01:00
allexzander
810fced476
Merge pull request #5378 from nextcloud/Valdnet-patch-4
l10n: Correct word
2023-01-31 17:06:48 +01:00
Claudio Cambra
dfdc23e240
Fix displaying of file details button for local syncfileitem activities
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-31 13:03:52 +01:00
Valdnet
bca915a230 l10n: Correct word
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2023-01-31 12:59:01 +01:00
Camila
a3e08aae3b Address PR comments.
Signed-off-by: Camila <hello@camila.codes>
2023-01-30 09:44:17 +01:00
Camila
9a3f2efa58 Fix rename.
Signed-off-by: Camila <hello@camila.codes>
2023-01-30 09:44:17 +01:00
Camila
ea903b1316 Backup all config files in the config folder if there was a version change of the client.
Signed-off-by: Camila <hello@camila.codes>
2023-01-30 09:44:17 +01:00
Camila
dbce267feb Look for a previous config file with a different name.
Signed-off-by: Camila <hello@camila.codes>
2023-01-30 09:44:17 +01:00
Camila
bf258542cd Update code style.
Signed-off-by: Camila <hello@camila.codes>
2023-01-30 09:44:17 +01:00
Camila
e68b4595e7 Remove obsolete QDesktopServices::storageLocation.
Use QStandardPaths::writableLocation instead.

Signed-off-by: Camila <hello@camila.codes>
2023-01-30 09:44:17 +01:00
Camila
b525de8a97 Open calendar notifications in the browser.
Signed-off-by: Camila <hello@camila.codes>
2023-01-27 12:30:01 +00:00
Claudio Cambra
68c785e25c
Revert "Merge pull request #5366 from nextcloud/bugfix/remove-mono-icons-setting"
This reverts commit 5c42da4de5, reversing
changes made to e4b2449030.

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-27 12:23:11 +01:00
alex-z
bb8bdab19c Edit locally. Do not lock if locking is disabled on the server.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-01-26 17:00:14 +01:00
Matthieu Gallien
07c292eaf5
fix copyright notice of new files
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-01-25 16:37:37 +01:00
Claudio Cambra
4c4e8707da
Improve wording in the case clash resolution dialog
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-25 16:37:36 +01:00
Claudio Cambra
64e585e5a2
Display both files and some metadata in the case clash conflict resolution dialog
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-25 16:37:36 +01:00
Claudio Cambra
2359c80c13
Fix case clash dialog sizing issues
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-25 16:37:36 +01:00
Claudio Cambra
cf6794c180
Clarify letter casing message in case clash conflict dialog
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-25 16:37:36 +01:00
Claudio Cambra
5908ac4176
Display action button for conflict files in activity
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-25 16:37:35 +01:00
Matthieu Gallien
602b8db5e2
handle case clash conflicts in a similar way to content conflicts
introduce a new type of conflict for case clash filename conflicts

add proper handling including a new utility class to solve them and a
new dialog for the user to pick a fix

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2023-01-25 16:37:35 +01:00
Claudio Cambra
0aee2bc2eb
Remove monoIcons-related functionality from theme
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-25 12:42:47 +01:00
Claudio Cambra
688126c003
Remove mono icons setting from generalsettings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-25 12:32:06 +01:00
Claudio Cambra
6df08af61a
Remove 'Use monochrome icons' checkbox from settings UI
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-25 12:27:42 +01:00
Claudio Cambra
3e00df4732
Don't shadow rec variable in removeLocalE2eFiles
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:16 +01:00
Claudio Cambra
95aa3ee53b
Make encrypted folder paths to delete non-relative when checking if they are encrypted
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:16 +01:00
Claudio Cambra
4c1a9f787a
Ensure blacklists get updated when removing folder sync
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:16 +01:00
Claudio Cambra
d93fc8eb3d
Don't use foreach in Folder::removeLocalE2eFiles
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:15 +01:00
alex-z
ad258473c4
Fix issue of e2ee folders not disappearing when disabling the e2e. Properly process blacklisted e2ee folders instead of ignoring them.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-01-24 17:00:15 +01:00
Claudio Cambra
efcd23eb06
Ensure blacklisted e2ee files get deleted
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:15 +01:00
Claudio Cambra
b333310ffe
Clean up sync termination and restart procedure after file blacklisting done
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:15 +01:00
Claudio Cambra
fdaedc4914
Only add root-most encrypted folder to the blacklist
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:15 +01:00
Claudio Cambra
7d208ec06e
Make sure to add e2ee files to normal blacklist too
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:15 +01:00
Claudio Cambra
093810f6b9
Only shedule affected paths for remote discovery after disabling e2ee
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:15 +01:00
Claudio Cambra
1fc1e95161
Use e2ee folder blacklist instead of deleting folders directly
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:15 +01:00
Claudio Cambra
12b2673ac2
Add test for deleting encrypted files
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:15 +01:00
Claudio Cambra
c59ab85e22
Make accountstate fakeable for tests
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:14 +01:00
Claudio Cambra
b57b35e7a4
Delete E2EE files/folders for accounts that have had E2EE disabled
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:14 +01:00
Claudio Cambra
cc6bdc9bd5
Add ability to remove local encryption keys through settings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:14 +01:00
Claudio Cambra
f9fb03bdc9
Clean up declarations in AccountSettings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 17:00:14 +01:00
Claudio Cambra
96cd78264d Fix fetch more unified search result item not being clickable
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-24 12:24:01 +01:00
Claudio Cambra
0ab2bd849b Don't try to lock folders when editing locally
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-23 17:46:43 +01:00
Claudio Cambra
c496e73200 Correctly parse account server url when migration from legacy config
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-23 16:29:01 +01:00
Claudio Cambra
174a486428 Stop checking config to migrate at current path if could not read file
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-23 16:29:01 +01:00
Claudio Cambra
39914e5166 More concisely clean paths of trailing slash URLs in restore old config migration method of AccountManager
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-23 16:29:01 +01:00
Claudio Cambra
dd4b7b6c26
Update legal notice text
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-23 15:37:56 +01:00
alex-z
d8980a8567 Fix bad string for translation.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-01-23 13:07:41 +01:00
alex-z
2bd1c272a6 Allow specifying the server force override URL and local sync folder path via command line.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2023-01-17 17:27:19 +01:00
Claudio Cambra
481298997c Extract makeResourceUrl lambda into separate static openableUrl method
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-06 18:49:13 +01:00
Claudio Cambra
37830c4bc4 Simplify makeResourceUrl
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-06 18:49:13 +01:00
Claudio Cambra
92667560ab Fix existing check and completion for relative resource URLs
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-06 18:49:13 +01:00
Florian Schmaus
14cbd836ab Drop dependency on Qt Quick Controls 1
Qt Quick Controls 1 where deprecated with Qt 5.11 [1]. Nextcloud still
depends on Quick Controls 1 by importing QtQuick.Dialogs. Removing
those imports will cause the QMl script to use the according API from
Quick Controls 2, which are, fortunately largely API-comptible.

This helps distribution to deprecate and remove Quick Controls 1 [2].

1: https://doc.qt.io/qt-6/qtquickcontrols-changes-qt6.html#migrating-from-qt-quick-controls-1
2: https://bugs.gentoo.org/889772

Signed-off-by: Florian Schmaus <flo@geekplace.eu>
2023-01-06 17:22:56 +01:00
Claudio Cambra
784327f489 Replace now deprecated FSEventStreamScheduleWithRunLoop with FSEventStreamSetDispatchQueue
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-02 18:05:54 +01:00
Claudio Cambra
403f43b3e8 Fix currentPage QPROPERTY missing NOTIFY in settingsdialog class
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-02 17:04:30 +01:00
Claudio Cambra
0495c6567a Fix interval QPROPERTY missing NOTIFY in slideshow class
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2023-01-02 17:04:30 +01:00
alex-z
cecd24b6c5 Fix review comments from Claudio III.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-12-30 14:46:06 +01:00
alex-z
07be556eca Fix review comments from Claudio II.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-12-30 14:46:06 +01:00
alex-z
e53d08fedb Fix review comments from Claudio. Refactoring.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-12-30 14:46:06 +01:00
alex-z
94df6769dc Allow setting up an account with apppasword and folder via command-line arguments. For deployment.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-12-30 14:46:06 +01:00
Valdnet
c9bae27bf8
l10n: Remove space
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-12-24 12:56:08 +01:00
Claudio Cambra
ce57d3b3ab Declare all QRegularExpressions statically
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-20 18:38:24 +01:00
Claudio Cambra
bf85c2d093 Remove unused QStrings from remotewipe
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-20 12:59:08 +01:00
Claudio Cambra
ad2841d963 Remove HACK for Windows Vista as this OS is no longer supported
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-20 12:59:08 +01:00
Claudio Cambra
50fa4cbb63 Remove unused variables in folderstatusdelegate
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-20 12:59:08 +01:00
Claudio Cambra
1dfb9b26f2 Remove use of emit keyword where used for non signals
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-20 12:07:55 +01:00
Claudio Cambra
6146f7d5cf Add 'emit' keyword to signal emissions that were missing them
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-20 12:07:55 +01:00
Claudio Cambra
f6c4c32b6e Use QFileInfo::exists where we are only creating a QFileInfo to check if file exists, as it is faster
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-20 09:44:13 +01:00
Claudio Cambra
b0d048b0b8 Fix conflicting definitions in anonymous namespace in Unity build
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-15 16:58:00 +01:00
Claudio Cambra
3b7bd6d26c Constify groups variable
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-15 16:58:00 +01:00
Claudio Cambra
14bd744df6 Use std::make_unique rather than manually build unique_ptr for oCSettings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-15 16:58:00 +01:00
Claudio Cambra
f4bca991e1 Make checks for config file more concise, warn when file not readable
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-15 16:58:00 +01:00
Claudio Cambra
d8e8a43cff Constify config file QFileInfo, create directly in if statement
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-15 16:58:00 +01:00
Claudio Cambra
0f9ddcddcb Fix includes in accountmanager.cpp
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-15 16:58:00 +01:00
Claudio Cambra
5548a4181b Replace QDesktopServices datalocation with emulated version of it
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-15 16:58:00 +01:00
Claudio Cambra
98be5fdd18 Add full list of possible legacy config locations
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-15 16:58:00 +01:00
Matthieu Gallien
39f85219b9 fix migration from old settings configuration files
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-12-15 16:58:00 +01:00
alex-z
867249f339 Do not sync encrypted folders if the E2EE mnemonic is not entered. Automatically blacklist them. Remove from blacklist once the E2EE mnemonic is provided.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-12-15 15:09:25 +01:00
Claudio Cambra
4ab7d6484a Remove unused headerbanner component
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-15 12:30:41 +01:00
Matthieu Gallien
a8025dc06a use .nextcloudsync.log to perform file monitoring test at start
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-12-15 11:11:20 +01:00
Claudio Cambra
b4ea35e95c
Clean up data section for internal link in model
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-13 17:40:20 +01:00
Claudio Cambra
bdfa923f8a
Fix copy link button
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-13 17:40:20 +01:00
Claudio Cambra
4af2a8f9de
Remove unneeded property from ShareDetailsPage
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-13 17:40:20 +01:00
Claudio Cambra
59d84759e4
Add an internal link share to the share dialog
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-13 17:33:33 +01:00
Claudio Cambra
2a77dc4529 Check socketlistener is valid before trying to send encryption menu item message
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-13 13:27:56 +01:00
Claudio Cambra
a23db4688a Don't show Encrypt menu entry if server does not support E2EE
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-13 13:27:56 +01:00
Claudio Cambra
01334e40f9 Improve folder encryption dialog info boxes
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-13 13:27:56 +01:00
Claudio Cambra
2b09281594 Add encryption success message box
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-13 13:27:56 +01:00
Claudio Cambra
39a48bf822 Move encrypt menu entry declaration to own method
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-13 13:27:56 +01:00
Claudio Cambra
bf1f718a65 Don't allow encryption if account is not correctly configured for it
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-13 13:27:56 +01:00
Claudio Cambra
1d4c634c54 Add context menu entry to encrypt folders
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-13 13:27:56 +01:00
Christian Göttsche
1a83894074 Fix typo
Found by Lintian.

Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
2022-12-13 09:22:58 +01:00
alex-z
f7ef2e5f44 Silence sync termination errors when running EditLocallyJob.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-12-12 17:39:48 +01:00
Claudio Cambra
5930fb4ac9 Adapt changes from share details page changes
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-09 15:06:35 +01:00
Claudio Cambra
373a001774 Replace share button with file details button
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-09 15:06:35 +01:00
Claudio Cambra
a16fc9ffcc Replace drawer 'Done' button at bottom-right with close button at top-right
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-09 15:06:35 +01:00
Claudio Cambra
ca74c2b27f Make drawer modal, reduce width
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-09 15:06:35 +01:00
Claudio Cambra
d25ce28a1b Show file details within the tray dialog, rather than in a separate dialog
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-09 15:06:35 +01:00
Claudio Cambra
4a42aee17e
Remove semicolons from Q_UNUSED macros
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-09 14:36:12 +01:00
Claudio Cambra
8913f88c50
Differentiate between normal normal and Talk notifications, invoke macOS text reply notifications
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-09 14:36:12 +01:00
Claudio Cambra
d2e0afa070
Add Talk message type of notifications to native macOS notifications
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-09 14:36:12 +01:00
Claudio Cambra
2261615f69 Use EnforcedPlainTextLabel in new ShareDetailsPage
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-09 12:54:09 +01:00
Claudio Cambra
6ae41c0759 Add copy share link button to share details page footer, remove unneeded columnlayout in contentitem
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-09 12:54:09 +01:00
Claudio Cambra
e723b75919 Make 'Add another link' button less prominent
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-09 12:54:09 +01:00
Claudio Cambra
5e0a2672fb Make unshare button less prominent, move out of bottom button box
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-09 12:54:09 +01:00
Claudio Cambra
4d837bd027 Set main file details page as initial item of stack view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-09 12:54:09 +01:00
Claudio Cambra
79ec0e9748 Match design of expire date spinbox to other text fields
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-09 12:54:09 +01:00
Claudio Cambra
cfccd02a26 Improve layout of share details page
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-09 12:54:09 +01:00
Claudio Cambra
046f8ea910 Convert share details menu into a page pushed onto stackview
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-09 12:54:09 +01:00
Claudio Cambra
e42188274c Add stackview to file details view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-09 12:54:09 +01:00
Claudio Cambra
31876926ac Only request mnemonic when user explicitly wants to enable E2EE
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-09 12:12:37 +01:00
Claudio Cambra
cc159e0117 Explicitly size and align user status selector text input to avoid bugs with alternate QtQuick styles
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-08 13:07:55 +01:00
Claudio Cambra
1cf2b59be2
Fix BasicComboBox internal layout, take proper account of insets
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-08 12:21:28 +01:00
Matthieu Gallien
2c94490b9c
do not create GUI from a random thread and show error on real error
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-12-08 10:58:58 +01:00
Claudio Cambra
135cab152b Format some QLabels as plain text
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-07 17:18:57 +01:00
Claudio Cambra
58f91072a5
Remove redundant openUrl variable
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-07 13:48:51 +01:00
Claudio Cambra
7eb31c31e5
Fix loss of integer precision in parameters for fileLockTimeRemainingMinutes
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-07 13:47:48 +01:00
Claudio Cambra
1b5b30d222
Make fileLockTimeRemainingMinutes a static method
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-07 13:46:21 +01:00
Claudio Cambra
4e508d0276
Run locking procedure on main thread, open file after file has been locked remotely
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-07 12:45:32 +01:00
Claudio Cambra
d3fa0066d0
Ensure we are using up-to-date item ptr instead of potentially un-update file record when checking lock state in fileLockSuccess, separate case with lock already pre-existing
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-07 12:45:32 +01:00
Claudio Cambra
6dbdcccb0f
Ensure we are using folder relative paths for synced folders that are not root to work correctly
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-07 12:45:31 +01:00
Claudio Cambra
3f20f192e9
Ensure we are checking lock state once file has been synced after setting lock
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-07 12:45:31 +01:00
Claudio Cambra
10746d8441
Notify user when file is locked when local editing begins
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-07 12:45:31 +01:00
Claudio Cambra
ff6ab38826
Lock file when editing locally
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-07 12:45:31 +01:00
alex-z
838817239a Fix CI errors for Edit Locally.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-12-06 15:31:24 +01:00
alex-z
b673ab996e Edit locally job will only sync a specific file by modifying the state of the Sync Engine. All other running syncs will get terminated. Syncing is now optimized to run faster and it checks if the file has changed on the server before syncing it.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-12-06 09:37:03 +01:00
Claudio Cambra
2ec1da22ed Remove now redundant use of textFormat
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-05 15:21:09 +01:00
Claudio Cambra
6c4070e786 Introduce EnforcedPlainTextLabel, convert all Label or Text labels to use this
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-05 15:21:09 +01:00
Valdnet
e2ff8715f4 l10n: Correct spelling
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-12-01 15:33:15 +01:00
Claudio Cambra
00fcb6e01d Ensure more QML text components are rendering things as plain text
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-01 14:20:15 +01:00
Claudio Cambra
83fd752981 Address capitalisation of End-to-end
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-01 11:50:18 +01:00
Claudio Cambra
70468be5e5 Differentiate between E2EE not being enabled at all vs. E2EE being enabled already through another device in account settings message
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-12-01 11:50:18 +01:00
Claudio Cambra
0262c77d27 Remove close/dismiss button from encryption message
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-11-28 18:24:40 +01:00
Claudio Cambra
a243f7c4d1 Prevent bad encrypting of folder if E2EE has not been correctly set up
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-11-28 17:48:53 +01:00
rakekniven
5353f4f92d l10n: Fixed grammar
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2022-11-28 14:37:24 +01:00
Claudio Cambra
2459a3a9f3 Rename 'Enable encryption' button to 'Setup encryption'
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-11-25 11:53:41 +01:00
Claudio Cambra
5a0d253187 Fix capitalisation of End-to-end
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-11-25 11:53:41 +01:00
Claudio Cambra
719a8f38bf Use material icons for lock and state-info
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-11-25 11:53:41 +01:00
Claudio Cambra
f6687c491d Change the colour of the encryption message box when encryption enabled
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-11-25 11:53:41 +01:00
Claudio Cambra
c1d6482c69 Add info icon when encryption not yet enabled
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-11-25 11:53:41 +01:00
Claudio Cambra
ef97200ac0 Show tick icon when encryption is enabled for account
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-11-25 11:53:41 +01:00
Claudio Cambra
89a66a98d8 Clearly tell user that E2EE has been enabled for an account
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-11-25 11:53:41 +01:00
Claudio Cambra
d24a40012e Fix bad custom button alignments, sizings, etc.
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-11-24 17:46:20 +01:00
Claudio Cambra
9a01480fcc Fix tray window margins, stop cutting into window border
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-11-24 15:02:37 +01:00
Claudio Cambra
53abfb4785 Add an end to end test utils file
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-11-23 08:40:46 +01:00
allexzander
6affc6e6ab Implement 'Leave this share' context menu entry. Fix incorrect sharing state for incoming and my shares in custom state icons and local database.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2022-11-22 12:14:20 +01:00
Matthieu Gallien
26fd4d2226 tidy some loop related code: avoid one letter variable names
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-18 16:02:21 +01:00
Matthieu Gallien
b5adbf3ab0 fix instances of: c++11 range-loop might detach Qt container warnings
analyzed via clazy

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-18 16:02:21 +01:00
Claudio Cambra
58660b82f8 Ensure forcing a folder to be synced unpauses syncing on said folder
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-11-15 12:32:13 +01:00
Claudio Cambra
e281c46fa5 Fix ActivityList delegate warnings·
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-11-15 11:51:39 +01:00
Claudio Cambra
561b55800c Remove reference to inexistent property in NCCustomButton
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-11-15 11:48:24 +01:00
Matthieu Gallien
61c792c6f4
fully qualify types in signals and slots
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-15 09:57:54 +01:00
hefee
14292ec867 Fix typo of connector
Signed-off-by: hefee <hefee@debian.org>
2022-11-14 09:43:36 +01:00
tnixeu
d0d666d084 exclude kmessagewidget.cpp and wheelhandler.cpp from unity build
Signed-off-by: tnixeu <4436784+tnixeu@users.noreply.github.com>
2022-11-14 08:41:47 +01:00
tnixeu
e3adb90d60 skip unity build for files which fail to compile
Signed-off-by: tnixeu <4436784+tnixeu@users.noreply.github.com>
2022-11-14 08:41:47 +01:00
tnixeu
0b98f471ed add guards around string constants and into an anonymous namespace
Signed-off-by: tnixeu <4436784+tnixeu@users.noreply.github.com>
2022-11-14 08:41:47 +01:00
Claudio Cambra
8315770467 Make user status selector modal, show user header
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-11-09 17:39:28 +01:00
Claudio Cambra
ddc14a844d Remove unused remotePath in User::processCompletedSyncItem
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-11-09 16:29:21 +01:00
alex-z
4b6ce9f951 Do not use copy-assignment of QDialog.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-11-09 16:01:17 +01:00
Claudio Cambra
31a89c68d7 Fix share delegate button icon colors in dark mode
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-11-08 17:33:25 +01:00
Claudio Cambra
1a0903f178 Ensure 'Sync now' button doesn't have its text elided
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-11-08 16:32:04 +01:00
Claudio Cambra
161ed1ec9b Remove unused app pointer in CocoaInitializer
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-11-08 15:43:25 +01:00
Claudio Cambra
e45a023961 Remove unused internal link widget from old share dialog
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-11-03 14:03:38 +01:00
allexzander
6cb988b667 Fix accounts avatar issue when it becomes completely white due to non-changing account id member with changing account index in the list.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2022-11-03 10:14:44 +01:00
alex-z
b00007e07d Fix incorrect current user index when removing and adding an account.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-11-03 10:14:44 +01:00
allexzander
9ab89daedd E2EE. Do not generate keypair without user request.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2022-11-01 09:18:28 +01:00
Claudio Cambra
d79312b2f7
Change liveDialog to nullDialog
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:13 +01:00
Claudio Cambra
7ba6969e65
Moved all server mocking code for share model test to independent ShareTestUtils file
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:10 +01:00
Claudio Cambra
e021f25634
Add a suite of tests for ShareModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Test ShareModel error handling

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Improve testing of user/group shares in ShareModel

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add testing for maximum share expire date enforcement in ShareModel

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:09 +01:00
Claudio Cambra
77fb0c4808
Filter out sharees that already have active shares
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:09 +01:00
Claudio Cambra
0826e8d6ba
Improve server error handling in the ShareModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:09 +01:00
Claudio Cambra
c707dd0ccc
Check for state of file record retrieval in fileactivitylistmodel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:09 +01:00
Claudio Cambra
79c0f3464a
Fix default date parser handling of timezones
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:09 +01:00
Claudio Cambra
ff4a4c63a1
Renamed _userStoppedTypingTimer to searchRateLimitingTimer
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:09 +01:00
Claudio Cambra
ce53c8439f
Add trailing comma to shareemodel enum
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:08 +01:00
Claudio Cambra
639fb21a13
Replace manual index bound checks with calls to checkIndex
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:08 +01:00
Claudio Cambra
fb4bb95b91
Perform inactive qquickwindow garbage collection when generating new file detail dialogs, raise existing dialog instead of always deleting
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:08 +01:00
Claudio Cambra
d2552ba439
Use auto where possible
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:08 +01:00
Claudio Cambra
b7d96781de
Add minimum size to file details window
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:08 +01:00
Claudio Cambra
121ab38177
Remove default cases in switches, rely on compiler warnings for missed cases
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:08 +01:00
Claudio Cambra
31afb02c84
Eliminate unneeded parent Item in FileActivityView
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:08 +01:00
Claudio Cambra
0ca927843f
Add early return checks for setter methods
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:08 +01:00
Claudio Cambra
685a0362fc
Refactor generation of dialogs, remove need for QSharedPointer and reduce use of pointers
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:07 +01:00
Claudio Cambra
f97f39375b
Remove Q_REQUIRED_RESULT from method with side-effect where result not always required, and viceversa
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:07 +01:00
Claudio Cambra
de0831c297
Use [[nodiscard]] more broadly in methods returning values, and respect it elsewhere
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:07 +01:00
Claudio Cambra
ec3c361c89
Show password set errors in the popup where passwords are set rather than in the main dialog
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:07 +01:00
Claudio Cambra
d92bc91bdf
Improve share view tab buttons
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:07 +01:00
Claudio Cambra
eda0328e9c
Change 'Link share' to 'Share link', matching server
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:07 +01:00
Claudio Cambra
6adefb572a
Improve flat buttons in share delegates
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:07 +01:00
Claudio Cambra
7971789112
Add a file details window/page, QMLify file sharing
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:03 +01:00
Matthieu Gallien
1dbdd8853f
add mising namespace
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-31 12:23:52 +01:00
Matthieu Gallien
521054dbf0
use new public API to open an edit locally URL
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-31 10:28:47 +01:00
Claudio Cambra
09997b189f Only show Sync Now button if account is connected
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-29 15:54:19 +02:00
Claudio Cambra
ff3eab1275 Modernise QString-related construction
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-29 14:03:58 +02:00
Claudio Cambra
b4be56c267 Add braces to all if statements missing them
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-29 14:03:58 +02:00
Claudio Cambra
7d05d8471b Expand use of const and auto, improve readability of accountsettings
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-10-29 14:03:58 +02:00
Claudio Cambra
72e154def1 Rename EditLocallyHandler to EditLocallyJob
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-29 13:32:48 +02:00
Claudio Cambra
ee8b12009a Ensure the checkTokenJob object gets deallocated
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-29 13:32:48 +02:00
Claudio Cambra
ae12519dd5 Show edit locally loading dialog sooner, improve feedback for user
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-29 13:32:48 +02:00
Claudio Cambra
9f7a699ad9 Refactor edit locally handler management away from application and into own class
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-29 13:32:48 +02:00
Claudio Cambra
4b6fdcc550 Don't show the user any potenitally questionable remote data
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-29 13:32:48 +02:00
Claudio Cambra
9438d3f1c7 Verify token before checking disk or modifying state
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-29 13:32:48 +02:00
Claudio Cambra
9a00aa6e66 Refactor edit locally into its own class, rather than bolting onto FolderMan
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-29 13:32:48 +02:00
Claudio Cambra
224621bb85 Refactor large editFileLocally FolderMan method into smaller, clearer separate methods
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-29 13:32:48 +02:00
Claudio Cambra
734c986cd1
Use addQueryParams for checkTokenForEditLocally SimpleApiJob
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-28 12:38:46 +02:00
Claudio Cambra
0b33ce2b40
Make sure to check relPath and compare to canonical cleaned path
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-28 12:38:18 +02:00
Claudio Cambra
0c6127de44
Make sure to encode the relPath
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-28 12:38:14 +02:00
Claudio Cambra
8683ee08e7
Validate edit locally token before sending to server
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-28 12:37:26 +02:00
Claudio Cambra
16532375da Fix macOS autoupdater settings
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-27 14:30:33 +02:00
Claudio Cambra
a537df296b
Constexpr settings constant strings, expand use of const and auto, modernise, in accountsmanager
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-10-26 13:28:24 +02:00
Claudio Cambra
c0baf5c93c Add a 'Sync now' button to the sync status header in the tray window
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-25 19:14:40 +02:00
Claudio Cambra
94b45d6d68 Add forcefoldersync method to folder manager
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-25 19:14:40 +02:00
Claudio Cambra
1a6326ed97 Create commonly accessible properties for current user colours in Style.qml
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-25 19:14:40 +02:00
Claudio Cambra
57f8de9fb6 Make Systray's void methods slots
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-10-25 12:19:17 +02:00
Matthieu Gallien
81f33ef94c emit missing signal to update folder sync status icon
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-24 16:53:06 +02:00
Claudio Cambra
9edc7357f7
Fix call notification dialog buttons
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-20 14:11:10 +02:00
Claudio Cambra
0bce17425b
Change unchanging settings strings into constexpr auto in accountmanager
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-19 13:31:50 +02:00
Claudio Cambra
8de5b0ffa5
Use prettyName more widely, instead of duplicating fallback string code
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-19 13:31:48 +02:00
Claudio Cambra
359627007b
Display the user's 'pretty' name in the webflow credentials
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-19 13:31:44 +02:00
Claudio Cambra
29afd9d5f3
Save account's display name in config
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-19 13:31:41 +02:00
Claudio Cambra
25ca698ad5
Improve user-related strings in webflow credentials
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-19 13:31:34 +02:00
alex-z
4e2ea9c00c Fix account not found when doing local file editing.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-10-17 14:56:30 +03:00
Camila
b55d71dffe The dismiss button is now a CustomButton component.
Signed-off-by: Camila <hello@camila.codes>
2022-10-17 11:29:23 +00:00
Camila
0624bec007 Fix the dismiss button: display it whenever possible.
Signed-off-by: Camila <hello@camila.codes>
2022-10-17 11:29:23 +00:00
Matthieu Gallien
f9949ee0de
edit locally requires a valid token
check on server that the token received during a request to open a local
file is indeed a valid one

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-17 09:02:26 +02:00
Matthieu Gallien
a36672c1a4 fix review comments
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-12 12:13:45 +02:00
Matthieu Gallien
146bd44b09 use correct version copmparison on NSIS updater: fix update from rc
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-12 12:13:45 +02:00
Matthieu Gallien
ad10d4bb9c remove support for skipping an update: hard to understand for users
skiping an update is probably there for historical reasons to work
around broken updates in the past

this can lead to users not getting an update they should be getting

this can elad to user confusion and the current user interaction is
broken if you do not go read the settings file with a text editor

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-12 12:13:45 +02:00
Claudio Cambra
924d5df3c4 Fix invisible user status selector button not being checked when user is in Offline mode
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-10-12 11:50:54 +02:00
Matthieu Gallien
ec1fb6209a improve logs when adding sync errors in activity list of main dialog
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-12 08:25:45 +02:00
alex-z
7672cb7903 Improve 'Handle local file editing' feature. Add loading popup. Add force sync before opening a file.'
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-10-10 17:13:06 +03:00
allexzander
289a641d74 VFS Windows: Display the sharing state and lock state in the 'Status' column of Windows Explorer
Signed-off-by: allexzander <blackslayer4@gmail.com>
2022-10-04 18:32:51 +02:00
Matthieu Gallien
565a5f0999 add [[nodiscard]] attribute via clang-tidy
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,modernize-use-nodiscard' -fix
under linux with most part of our code covered

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-04 11:14:45 +02:00
Claudio Cambra
c67141430b Fix link shares default expire date being enforced as maximum expire date even when maximum date enforcement is disabled on the server
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-10-03 22:27:18 +02:00
Matthieu Gallien
ecc588c27a avoid possibly crashing static_cast
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,cppcoreguidelines-pro-type-static-cast-downcast' -fix

this can prevent casting to a type that is unrelated to the real type
and later cause a crash because you go into undefined behavior domain

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-03 10:23:24 +02:00
Matthieu Gallien
3193937e50
use auto
ran
run-clang-tidy-14.py -header-filter='.*' -checks='-*,modernize-use-auto' -fix

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-10-02 14:56:37 +02:00
Claudio Cambra
7a1dbcf2fe Don't set up tray context menu on macOS, even if not building app bundle
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-30 21:45:30 +02:00
Claudio Cambra
652c0dcff7 Fix predefined status text formatting
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-30 16:24:36 +02:00
Claudio Cambra
6137fe246e Fix sync progress bar colours in dark mode
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-29 21:55:44 +02:00
Camila
7633cc490d
Fix 'Reply' action primary property.
Primary is set to true when object type is 'room' or 'chat' and it set to
false when object type is 'call'.

Signed-off-by: Camila <hello@camila.codes>
2022-09-29 15:20:56 +02:00
Camila
cbe22d8c1e
Remove unused property.
Signed-off-by: Camila <hello@camila.codes>
2022-09-29 15:17:10 +02:00
Claudio Cambra
9781e896a1 Improve the error box QML component
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-29 12:14:37 +02:00
Claudio Cambra
db861e1ade Make activity action button an actual button, clean up contents
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-28 13:07:08 +02:00
Claudio Cambra
be2c0ddbc8 Ensure placeholder message in emoji picker wraps correctly
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-28 12:33:09 +02:00
Camila
348c9ea915 Fix persistent two factor auth notification.
The server app returns a 202 code when the request succeeded, which was
not taken into account.

Signed-off-by: Camila <hello@camila.codes>
2022-09-27 14:49:29 +00:00
Camila
f3513aaafe Fix two factor auth notification: 'Approve' link is a primary action.
Signed-off-by: Camila <hello@camila.codes>
2022-09-27 14:49:29 +00:00
Claudio Cambra
e721b03106 Remove sorting code in activitylistmodel as not needed with sortedactivitylistmodel
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-26 18:18:34 +02:00
Claudio Cambra
f71ddc4d43 Add a sortedactivitylistmodel that automatically handles sorting of activities
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-26 18:18:28 +02:00
Claudio Cambra
664a80cbb5 Clicking on file name clash activities now opens file in web UI were the clash can be resolved
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-26 12:10:38 +02:00
Claudio Cambra
6fa2542a10 Categorise file name clash sync file issues as separate FileNameClash enum treated as warning
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-26 12:10:38 +02:00
Claudio Cambra
80fcb6d95f Ensure strings in main window QML are presented as plain text and not HTML
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-26 10:57:18 +02:00
Claudio Cambra
bc08559655 Add a placeholder item for empty activity list
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-22 12:17:21 +02:00
Camila
7db68ad2c5
Fix two factor auth notification: activity item was disabled.
User couldn't click on the links.

Signed-off-by: Camila <hello@camila.codes>
2022-09-20 18:56:31 +02:00
Claudio Cambra
547e5a4675 Do not format text in QML components as HTML
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-17 15:05:22 +02:00
allexzander
b40c2dfe01 Revert "Remove behavior changes."
This reverts commit 84d06ce9906df7bb6d87bf7093dd11fac6a6057a.

Signed-off-by: allexzander <blackslayer4@gmail.com>
2022-09-17 09:47:15 +02:00
allexzander
d425005a29 Remove behavior changes.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2022-09-17 09:47:15 +02:00
allexzander
ffb7fcad7d Fix deprecation warnings.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2022-09-17 09:47:15 +02:00
allexzander
65cd8d06bc Do not ignore return values for SyncJournalDB in accountsettings folderstatusmodel activitylistmodel abstractpropagateremotedeleteyncrypted lockgilejobs and propagator jobs
Signed-off-by: allexzander <blackslayer4@gmail.com>
2022-09-17 09:47:15 +02:00
allexzander
0cb448cf8e Do not ignore return values for SyncJournalDB in folder, encryptfolderjob, hydrationjob, and vfs_suffix.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2022-09-17 09:47:15 +02:00
alex-z
f34fb9ea97 Do not ignore return value of SyncJournalDB in socket API.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-09-17 09:47:15 +02:00
Claudio Cambra
5a56584fba Deallocate call notification dialog objects when closed
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-14 12:34:47 +02:00
Claudio Cambra
14303d0eb6 Make account setup wizard's adjustWizardSize resize to current page size instead of largest wizard page
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-13 23:00:05 +02:00
Claudio Cambra
1a5fa50fbb Refactor ActivityListModel population mechanisms
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-13 19:34:41 +02:00
Claudio Cambra
4c9e0873a3 Fix low-resolution file changed overlay icons in activities
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-13 18:55:47 +02:00
Claudio Cambra
66198055d3 Fix add account text clipping, enlarge text
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-10 20:16:17 +02:00
Claudio Cambra
871ad24e28 Fix ActivityItem activityHover error
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-10 12:11:23 +02:00
Claudio Cambra
b1caa45929 Fix menu bar height calculation on macOS
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-10 11:52:29 +02:00
Claudio Cambra
b3ccbe2808 Fix fileactivitylistmodel QML registration
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-10 11:17:10 +02:00
alex-z
2a529eef3c Make sure Folder is deleted from the list and the SyncJournalDB is closed for every folder of the account that has been removed.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-09-10 10:34:34 +02:00
alex-z
f0b9ecd747 Check folder invalidity reson when deciding to enable or disable the 'Finish' button in a Wizard page.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-09-10 10:34:34 +02:00
Claudio Cambra
9a0753dabb Replace private API QZipWriter with KArchive
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-07 19:10:03 +02:00
Claudio Cambra
b7b374c442 Fix rebase issue with activity list keyboard navigation PR
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-07 18:45:58 +02:00
Claudio Cambra
b820df90b9 Improve activity list highlighting/keyboard item selection
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-07 18:27:14 +02:00
Claudio Cambra
85c5002d34 Simplify activity list delegates by making them ItemDelegates, clean up
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-07 18:19:49 +02:00
Claudio Cambra
e79ced22ae Clean up QML registration
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-07 17:00:44 +02:00
Claudio Cambra
7882e224fd Set UnifiedSearchResultNothingFound visibility less messily
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-07 15:01:07 +02:00
alex-z
1b98733b1a Start sync immediately after modifying the selective sync settings.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-09-07 13:38:09 +03:00
alex-z
7ba681544c Fix wrong estimated time when doing sync.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-09-07 09:31:05 +03:00
Claudio Cambra
316f3981ab Align, resize, and layout everything uniformly in the unified search view
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-06 09:02:17 +02:00
Claudio Cambra
5acb0b272a Use same tooltip component everywhere
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-06 08:40:03 +02:00
Claudio Cambra
2fe4bc5403 Add a ScrollView to the predefined statuses area of the UserStatusSelector
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-09-05 12:33:19 +02:00
Matthieu Gallien
d1408df7ba let Qt use OpenGLES instead of desktop OpenGL to workaround bugs
should help picking a working rendering pipeline on windows

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-09-04 22:20:38 +02:00
Matthieu Gallien
0092ad15c7 sets special configuration to webengine to work around bugs
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-09-04 22:20:38 +02:00
alex-z
ba9a39856b Change Activities dialog show and Systray.forceWindowInit call sequence to fix the issue of Activities dialog not being shown.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-08-29 10:59:55 +03:00
alex-z
22a3b6cc16 Fix File Activities dialog not showing up.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-08-29 10:59:55 +03:00
Claudio Cambra
27f28d781e Prevent the 'Cancel' button of the user status selector getting squashed
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-08-17 21:08:25 +02:00
Claudio Cambra
ecab3d76ee Ensure that clear status message combo box is at least implicit width
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-08-17 20:34:17 +02:00
Claudio Cambra
bedcfbd14c Fix alignment of predefined status contents regardless of emoji fonts
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-08-17 20:01:12 +02:00
Claudio Cambra
fc5e9db839 Prevent crashing when trying to create error-ing QML component in systray.cpp, output error to log
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-08-17 15:31:04 +02:00
Claudio Cambra
2ab95a30f9 Ensure file activity dialog is centered on screen and appears at top of window stack
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-08-17 14:01:32 +02:00
Claudio Cambra
7d41530284 Fix account switching and hover issues with UserLine component
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-08-10 18:07:02 +03:00
Claudio Cambra
37bd55b232 Fix unified seach item placeholder image source
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-08-10 13:31:45 +02:00
Claudio Cambra
387dfa96a1 Refactor user line
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-08-10 12:10:20 +02:00
Claudio Cambra
d86f25d215 Make UserStatusSelector a dismissible page pushed onto the tray window
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-08-10 09:22:33 +00:00
Claudio Cambra
0a89bf2335 Fix QML warnings
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-08-09 14:45:18 +03:00
Claudio Cambra
81bb290e4c Eliminate padding around the menu separator in the account menu
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-08-08 16:14:32 +02:00
Matthieu Gallien
8551a14c48 ensure SyncEngine use an initialized instance of SyncOptions
will prevent nextcloudcmd command line client from ignoring the settings
handled by SyncOptions

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-08-08 12:36:37 +03:00
Claudio Cambra
e9e482b174 Restyle unified search skeleton items animation and simplify their code
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-08-05 18:40:13 +02:00
allexzander
ff0a058f66 Fix crash: 'Failed to create OpenGL context'.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2022-08-05 16:29:21 +03:00
Valdnet
443ec4bfac
i18n: Spelling unification
Spelling unification in Transifex.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-08-05 12:04:36 +02:00
Valdnet
0e703c57c2
i18n: Spelling unification
Spelling unification in Transifex.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-08-05 12:03:03 +02:00
Valdnet
ee950435c9
i18n: Spelling unification
Spelling unification in Transifex.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-08-05 11:26:03 +02:00
Valdnet
42854355ad
i18n: Spelling unification
Spelling unification in Transifex.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-08-05 11:23:31 +02:00
alex-z
d42d3c057f Implement URI handler for local file editing
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-08-03 11:38:33 +03:00
Claudio Cambra
2b598d1820 Double-clicking tray icon opens currently-selected user's local folder (if available)
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-08-02 19:06:44 +02:00
Claudio Cambra
c74c466725
Merge branch 'master' into bugfix/clean-up-talkreplytextfield 2022-08-02 18:28:28 +02:00
Claudio Cambra
789179214f Clicking on an activity list item for a file opens the local file if available
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-08-02 17:43:18 +02:00
Matthieu Gallien
7180b09807 mark unused variable as bein unused to avoid clang warning
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-08-02 16:28:50 +02:00
Matthieu Gallien
fe7a62bc77 remove variables set but never read
will fix a clang compilation error

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-08-02 16:28:50 +02:00
alex-z
f3c10ac3a4 Always run MSI with full UI.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-08-02 15:27:01 +03:00
Claudio Cambra
b1deb6cd1d Replace unified search text field busy indicator with custom indicator
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-08-02 13:23:33 +02:00
allexzander
250faf027f Do not reboot PC when running an MSI via autoupdate.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2022-08-02 09:26:17 +03:00
alex-z
001deace2d Implement COM Dll for CfApi shell extensins. Implement Thumbnail Provider.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-07-29 19:26:53 +03:00
Claudio Cambra
78b3e09f3b Clean up TalkReplyTextField, remove unnecessary parent Item
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-07-29 12:47:08 +02:00
Claudio Cambra
061f443920 Make apps menu scrollable when content taller than available vertical space, preventing borking of layout
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-07-27 12:19:10 +02:00
Claudio Cambra
7a78f2b19f Ensure that throttled notifications still appear in tray activity model
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-07-25 13:15:50 +02:00
Claudio Cambra
8d0df62c49 Stop styling QML unified search items hierarchically, use global Style constants
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-07-21 15:38:18 +02:00
Claudio Cambra
bb034b8bf4 Ensure debug archive contents are readable by any user
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-07-21 13:47:49 +02:00
Claudio Cambra
8dfe1647ed Stop clearing notifications when new notifications are received
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-07-21 13:14:51 +02:00
Claudio Cambra
e3d897cb7f Fix ActivityItemContent QML paintedWidth errors
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-07-18 15:13:58 +02:00
Claudio Cambra
539ba93fd1 QMLify the UserModel, use properties rather than setter methods
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-07-15 16:47:17 +02:00
Claudio Cambra
f8d79c389c Use preprocessor directive rather than normal 'if' for UNNotification types
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-07-15 16:21:16 +02:00
Claudio Cambra
f2dbceaee0 Respect skipAutoUpdateCheck in nextcloud.cfg with Sparkle on macOS
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-07-15 15:49:13 +02:00
Claudio Cambra
6872e1a75b Take ints by value rather than reference in UserModel methods
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-07-15 15:01:48 +02:00
Claudio Cambra
bc01db7cff
Merge branch 'master' into bugfix/limit-concurrent-notifications 2022-07-13 00:18:08 +02:00
Claudio Cambra
ce9e4a99c0 Refactor tray window opening code for clarity and efficiency
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-07-12 22:54:00 +02:00
Claudio Cambra
cf372b43ac Properly adapt the userstatusselectormodel, eliminate hacks, make code more declarative
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-07-12 21:10:26 +02:00
Claudio Cambra
7d087026ca Limit concurrent notifications
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-07-12 20:24:50 +02:00
Claudio Cambra
f892d24717 Fix bad quote in PNG generation message
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-07-12 20:20:30 +02:00
Claudio Cambra
e0041feca0 Add a placeholder message for the recents tab of the emoji picker
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-07-12 15:19:57 +02:00
Claudio Cambra
b712eb95e2 Clean up systray methods, make more QML-friendly
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-07-06 11:26:53 +02:00
Claudio Cambra
5e67405b45 Add a custom back button to the account wizard's advanced setup page
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-07-06 09:57:30 +02:00
Claudio Cambra
22464f5005 Work around issues with window positioning on Linux DEs, hardcode tray window to screen center when new account added
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-07-04 14:11:19 +02:00
Claudio Cambra
ada355061a Increase the call state checking interval to not overload the server
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-07-01 14:44:46 +02:00
Claudio Cambra
a504dbf965 Close call notifications when the call has been joined by the user, or the call has ended
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-07-01 11:39:50 +02:00
szaimen
d81d3b188a use an en-dash for the userstatus panel
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-06-30 14:34:20 +02:00
Camila
fae5b5573c Clean up code, move values to Style.qml.
Signed-off-by: Camila <hello@camila.codes>
2022-06-28 09:25:48 +02:00
Camila
3ff781ee17 Talk reply field should now have the same height as the 'Reply' button.
Signed-off-by: Camila <hello@camila.codes>
2022-06-28 09:25:48 +02:00
Valdnet
b214b87491 i18n: Add dot
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-06-28 08:55:54 +02:00
Valdnet
2fb1aab655 i18n: Fix for "end-to-end"
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-06-28 08:55:54 +02:00
Claudio Cambra
749f5dee82 Fix the system tray menu not being correctly replaced in setupContextMenu
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-06-24 18:22:54 +02:00
Claudio Cambra
ee3e0d3351 User dialog now looks in line with the rest of the desktop client tray
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-06-24 16:29:18 +02:00
Claudio Cambra
b7c2e16aa9 Make client language gender-neutral and more clear
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-06-24 14:36:36 +02:00
Claudio Cambra
2fe6e075b6 Share dialog is now resizeable
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-06-24 13:45:56 +02:00
Claudio Cambra
0658d7227e Remove Q_ASSERTs for userstatusconnector
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-06-24 12:34:52 +02:00
Claudio Cambra
e873f3b348 Fix crashing when selecting user status
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-06-24 12:34:52 +02:00
Claudio Cambra
d8d72e81bb Redesign local folder information in the account adding wizard
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-06-24 10:19:47 +02:00
Matthieu Gallien
e581805138 set OpenGL software rendering and set similar options for webview
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-06-24 08:00:48 +02:00
Camila
ac0c227263 Remove unused signal fileActivityButtonClicked.
Signed-off-by: Camila <hello@camila.codes>
2022-06-23 10:10:55 +02:00
Camila
55d6035f1e absolutePath was undefined.
It was not part of the model, the correct one was path (PathRole).

Signed-off-by: Camila <hello@camila.codes>
2022-06-23 10:10:55 +02:00
Camila
7744ad29a9 Remove tooltip because it is only repeating the label of the link.
It is bad for accessibility.

Signed-off-by: Camila <hello@camila.codes>
2022-06-23 08:56:23 +02:00
Claudio Cambra
0d26929d41 Ensure call notification stays on top of other windows
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-06-22 10:25:51 +02:00
Camila
fc2408cf41 Add contrast to the text/icon of buttons if the server defined color is light.
Signed-off-by: Camila <hello@camila.codes>
2022-06-21 11:49:30 +02:00
Claudio Cambra
8267136013 Rephrase button text to be in line with clients on other platforms
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-06-15 12:52:12 +02:00
Claudio Cambra
281e50f4cd Prevent call dialogs from being presented when do not disturb is set as the user status
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-06-10 11:30:16 +02:00
allexzander
d7217d1c07
Merge pull request #4622 from nextcloud/feature/generate-state-icons-from-svg
Feature/generate state icons from svg
2022-06-10 12:15:45 +03:00
Claudio Cambra
9dd9c46493 Do not compile things that require the app bundle when building the client without the app bundle on macOS
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-06-10 10:43:36 +02:00
alex-z
6ef296d823 Generate state icons from SVG in CMake.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-06-10 11:37:29 +03:00
Claudio Cambra
4bdfe59270 Fix builds on macOS versions pre-11
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-31 11:10:17 +02:00
rakekniven
276616d211 l10n: Fixed grammar
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2022-05-30 10:12:33 +02:00
Camila
6ff82659ac Change color of text field to ncTextColor instead of ncSecondaryTextColor.
Signed-off-by: Camila <hello@camila.codes>
2022-05-25 12:08:53 +02:00
Camila
f911c546d9 Add a transparent background to the send reply button.
Signed-off-by: Camila <hello@camila.codes>
2022-05-25 12:08:53 +02:00
Camila
282aadb7e9 Reduce spacing above the notification buttons.
Spacing is now the  same as space between lines in the text above.

Signed-off-by: Camila <hello@camila.codes>
2022-05-25 10:01:38 +02:00
Camila
2fa834446a Fix 'TypeError: Cannot readproperty 'messageSent' of undefined'.
Signed-off-by: Camila <hello@camila.codes>
2022-05-24 11:51:55 +02:00
alex-z
43a37637cf Display chat message inside the OS notification.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-05-23 17:01:22 +03:00
alex-z
e40142847b Add and use DO_NOT_REBOOT_IN_SILENT=1 parameter for MSI to not reboot automatically when running from the updater.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-05-19 12:52:40 +03:00
Claudio Cambra
a2cc2ace4a Explicitly ask user for notification authorisation on launch
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-19 10:59:12 +02:00
alex-z
be23e747de Stretch WebView to fit dialog's height.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-05-18 10:57:10 +03:00
Matthieu Gallien
d622999971 add explicit capture for lambda
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-05-17 13:33:22 +02:00
Valdnet
f4931026d7
i18n: Add a space
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-05-17 09:08:37 +02:00
Valdnet
83415062ba
i18n: Change three dots to an ellipsis
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-05-17 09:06:20 +02:00
Claudio Cambra
2d74a5752e Fix label borking and wrong icon colours in the share dialog
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-16 22:59:00 +02:00
Camila
290851c33a Convert primary, WEB and DELETE notification links to action buttons.
Signed-off-by: Camila <hello@camila.codes>
2022-05-16 22:03:53 +02:00
Camila
9c63615a78 Do not add a second DELETE to the list of actions in one notification.
Signed-off-by: Camila <hello@camila.codes>
2022-05-16 22:03:53 +02:00
Claudio Cambra
31f3800d0d Fixed share link expiration box being ineditable and always reloading invalid date
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-16 18:51:12 +02:00
alex-z
53654b2a50 Allow manual renaming of files and folders with spaces. Allow uploading invalid file name via the InvalidFileName dialog.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-05-16 18:07:26 +03:00
Claudio Cambra
463496153a Fixed several issues with activity items relating to icon colouration and activity item sizing + layout
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-16 16:42:53 +02:00
Claudio Cambra
364d02a13f Actually reset menu when user accounts are added or removed
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-16 16:42:20 +02:00
alex-z
101a92faf3 Bugfix. Take root folder's files size into account when displaying the total size in selective sync dialog.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-05-16 17:40:30 +03:00
Claudio Cambra
b6def51945 Fix notifications not being shown when they should be
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-16 14:28:33 +02:00
alex-z
514f72f975 Use proper online status for user ('dnd', 'online', 'invisible', etc.) to enable or disable desktop notifications.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-05-16 10:47:05 +03:00
Camila
e4a0d57bc8
Do not replace strings in action links coming from the notification api.
Signed-off-by: Camila <hello@camila.codes>
2022-05-12 12:47:48 +02:00
Claudio Cambra
c22d5959b8 Reimplement notifications for macOS and add support for actionable update notifications
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-11 17:33:33 +02:00
Matthieu Gallien
553d324d3d only add OCS-APIREQUEST header for 1st request of webflow v1
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-05-10 09:39:35 +02:00
rakekniven
ad17d39817 l10n: Remove string from translation
Reported at Transifex.

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2022-05-06 08:48:55 +02:00
Philip Allgaier
e75f37bf2e Remove "…" from "Create Debug Archive" button
Looks like an ellipsis (as if some text is cut off), but that is not the case => clearer without the dots

Signed-off-by: Philip Allgaier <philip.allgaier@gmx.de>
2022-05-05 22:26:58 +02:00
Claudio Cambra
cdae0a56d5 Stop dumping cache data in home dir, cache in default cache location
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-05 14:31:31 +02:00
rakekniven
994c2e02d8 l10n: Changed triple dot to ellipsis
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2022-05-04 11:33:47 +02:00
Claudio Cambra
7129bf2489 Add user avatars in talk notifications in activity list
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-02 15:12:45 +02:00
Claudio Cambra
a5019f1f8e Add some logging
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-02 14:57:47 +02:00
Claudio Cambra
22e42ac6d3 Fix macOS autoupdater
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-05-02 14:57:47 +02:00
Matthieu Gallien
702e9abe4b display lock info in share dialog
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-05-02 13:52:05 +02:00
Matthieu Gallien
2d27a68e73 show errors on lock/unlock actions
use a native dialog to show users errors when trying to lock/unlock
files

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-05-02 13:52:05 +02:00
Matthieu Gallien
b55a099b61 allow lock/unlock of files from files explorer integration
add new commands to the contextual menu provided by our files explorer
plugins to allow locking/unlocking a file

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-05-02 13:52:05 +02:00
alex-z
7b441a0f6e Optimize activities fetch requests. Do not fetch when the Tray is not open. Fetch next subset only when scrolling. Fix duplicate notifications.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-04-29 20:59:56 +03:00
Matthieu Gallien
558c6cb1f6
adjust API of retry count to have everything private and simpler
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-04-29 12:53:38 +02:00
Matthieu Gallien
6798f2ca31
obsolete and no longer needed
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-04-29 12:31:32 +02:00
Matthieu Gallien
a6571e2d8a
improve readability of computation of currentDelay recoonect time
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-04-29 12:29:45 +02:00
Matthieu Gallien
4e348db1d0
increase time between connection tries
each time we do a failed attempt to connect increase the time until the
next try

use an elapsed timer to ensure we do properly wait between each attempt

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-04-29 12:15:15 +02:00
Claudio Cambra
3f5243aaee Add an incoming talk call notification to the desktop client
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>

Co-authored-by: Camila <hello@camila.codes>
2022-04-28 09:13:13 +02:00
Claudio Cambra
010f49a392
Realigned and resized thumbnails
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-04-27 18:02:37 +02:00
Claudio Cambra
15078260b4
Removed spacing between activies, labels now centre-aligned
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-04-20 18:07:41 +02:00
Claudio Cambra
7b65c1ceed
Fix thumbnails for new files made while client open
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-04-19 10:16:43 +02:00
Claudio Cambra
5ce736222e Use header text color to improve contrast with header colours when hovering on themed elements
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-04-15 13:17:09 +02:00
Camila
74d214726c
Remove unused function parameter.
Signed-off-by: Camila <hello@camila.codes>
2022-04-06 10:38:01 +02:00
Camila
6189b2115e
Adress design issues.
- The input field was not using the  theming.
- After submitting the reply, the text and icon on the left were moving.

Signed-off-by: Camila <hello@camila.codes>
2022-04-06 10:38:01 +02:00
Camila
f524635cf4
Do not hide'View chat' link.
This logic was also hiding 'Answer call'.

Signed-off-by: Camila <hello@camila.codes>
2022-04-06 10:38:01 +02:00
Camila
ead4eeda1e
Windows fix: activityIndex was not being passed to the lambda slot function.
Signed-off-by: Camila <hello@camila.codes>
2022-04-06 10:38:00 +02:00
Camila
c254572e80
Add 'Reply' as activity link instead of changing the 'View chat' link.
- Align 'Reply' button.
- Do not display 'View chat' as a link: the 'View chat' action is active when
the user clickcs on the notification item in the tray window.
- Convert the QByteArray verb value to String.
- Handle logic to toggle the reply textfield in the QML code.

Signed-off-by: Camila <hello@camila.codes>
2022-04-06 10:38:00 +02:00
Claudio Cambra
a2e1c68c26 Fix broken activity icon and loading entries colour in unified search
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
2022-04-05 16:41:11 +00:00