Commit graph

21856 commits

Author SHA1 Message Date
Camila Ayres
6a14f71a28
Add new icon for more apps menu.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-13 12:30:08 +02:00
Camila Ayres
9e8fa84787
Use palette.window as header background color.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-13 12:30:08 +02:00
Camila Ayres
16986c2233
Add colored to base colors.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-13 12:30:08 +02:00
Camila Ayres
fa8048c70c
Fix display of icons in dark/light theme.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-13 12:30:08 +02:00
Camila Ayres
589bff16df
Fix dark/light mode for account menu.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-13 12:30:08 +02:00
Camila Ayres
bbf4f3125a
Fix caret-down icon theme, size and alignment.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-13 12:30:08 +02:00
Camila Ayres
f8a0551dba
Fix tray header light/dark theme.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-13 12:30:03 +02:00
Matthieu Gallien
78082808a9
Merge pull request #7096 from nilsding/work/context-for-translations
gui: add some context for translators
2024-09-13 11:41:15 +02:00
Jyrki Gadinger
34785c2fd2 gui: add some context for translators
Resolves #7095

Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
2024-09-13 11:41:07 +02:00
Nextcloud bot
9c9943bd25
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-13 02:48:24 +00:00
Matthieu Gallien
4cd63d89d3
Merge pull request #6970 from nextcloud/bugfix/prevent-renotification
Make sure we do not renotify notifications when we have received the same etag as during the last check
2024-09-12 10:53:51 +02:00
Claudio Cambra
6b0e485ab9 Notify even if pre-fetch etag header is empty
This prevents situations where the server does not provide an etag header. This would make the empty pre-fetch and empty post-fetch etag headers match, meaning notifications would never be notified

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:52:54 +02:00
Claudio Cambra
291f0c8c85 Make sure we do not renotify notifications when we have received the same etag as during the last check
Do this regardless of what the server's response is

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:52:54 +02:00
Matthieu Gallien
804cb1d4d6
Merge pull request #6960 from nextcloud/feature/macos-vfs-locking
Feature/macos vfs locking
2024-09-12 09:50:59 +02:00
Claudio Cambra
94a783c482 Signal enumeration of locked/unlocked file
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
4012d43bb9 Do not provide items if account is not set up correctly
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
7413cf6735 Display checkmark when file lock completed
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
419035c275 Fix NSExtensionFileProviderActionActivationRules for locking menu items
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
19c9c199a6 Add warn image to locking view if there is an error
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
4348869684 Fix internal layouting of lock view by simply using a nsview rather than fumbling with a stack view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
616ac2e50c Fix XIB initialisation in LockViewController
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
4dbfbc3d96 Fix file lock server url in lockviewcontroller
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
f3e341c860 Make sure not to check for kit before we should in shares table view data source
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
7ae9f833aa Once finished locking/unlocking, stop loading indicator
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
d312d009f7 Pull out error handling from completionHandler for nckit lockunlock
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
516fc7cc10 Stop loading indicator when presenting error
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
65e4297e12 Add convenience function to stop/hide loading indicator in lock view controller
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
c7d2ed3fcb Perform lock/unlock procedure in lock view controller
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
3b33b2651b Process target item on init of lock view controller
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
fdbc52b83b Add method to simply provide file details in locking view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
05e5793f06 Add convenience method to present and log errors in lock view controller
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
81566eec09 Move item metadata fetch into util file in FileProviderUIExt
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
624b72bd80 Move service connection fetcher method into a utils file
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
4edbb4b50d Add close action to lock view controller
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
10f37d3af1 Design lock view in file provider ui
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
e3b6cd9935 Add basic properties to lock view controller
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
ec66bcd19b Handle new locking action identifiers in document action view controller of FileProviderUIExt
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
501c1c4d62 Add lock/unlock actions in FileProviderUIExt info plist
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
73674bf633 Add basic LockViewController components
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Claudio Cambra
1d0e3bc98e Move all sharing components for FileProviderUIExt into a Sharing folder
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-12 09:50:50 +02:00
Matthieu Gallien
3777a3b36d
Merge pull request #7102 from nextcloud/bugfix/fixOneRenameIssue
Bugfix/fix one rename issue
2024-09-12 09:50:36 +02:00
Matthieu Gallien
7a3ed38040 improve some log that are produced during discovery
would be usefull to track bugs during rename operations

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-12 09:50:27 +02:00
Matthieu Gallien
092175e23a avoid wrong tracking of renamed folders during discovery
ensure server rename operations are tracked as server rename operations

ensure local rename are tracked as local rename operations

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-12 09:50:27 +02:00
Matthieu Gallien
18bb41b410 add automated tests for complex move scenario
we rename the top folder and we rename a not direct child that is also
moved to another folder below the original renamed top folder

so
a/b/c
a/b/d/file

will be
e/b/c/f/file

with
a -> e
d-> f

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-12 09:50:27 +02:00
Matthieu Gallien
341263b97e
Merge pull request #7061 from nextcloud/bugfix/deleteReadOnlyRemnantsFolders
Bugfix/delete read only remnants folders
2024-09-12 09:42:46 +02:00
Matthieu Gallien
8faefc6fa2 delete invalid folders and restart sync automatically
users should then notice that the sync errors are gone

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-12 08:40:50 +02:00
Matthieu Gallien
34c25ecb43 let FileSystem::removeRecursively be able to delete read-only folders
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-12 08:40:50 +02:00
Matthieu Gallien
a118c0ad1e detect remnants read-only folders to delete: try to delete them
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-12 08:40:50 +02:00
Matthieu Gallien
155c61acbb let cancel sync and finish sync lambda be reusable methods
will enable implementation of other ways to interrupt sync after
discovery to get user feedback

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-12 08:40:50 +02:00
Matthieu Gallien
b7b72bf9f2 collect remnant read-only folders during discovery
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-12 08:40:50 +02:00