Commit graph

22104 commits

Author SHA1 Message Date
Claudio Cambra
5b5c5e3ac7
Match definition of shared_with_me with other properties in OcsShareJob getShares
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-20 13:23:54 +08:00
Claudio Cambra
9fb96b277d
Clean up whitespace in ShareModel::slotPropfindReceived
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-20 13:23:36 +08:00
Claudio Cambra
6610f2ad38
Ensure account pointer is valid when fetching avatars
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-21 11:11:10 +08:00
Claudio Cambra
14793710bc
Ensure requestedSize for avatars is valid
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-21 11:10:58 +08:00
Claudio Cambra
d7f7d94e1d
Display image for sharedWithMe share owner in share view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-21 01:54:13 +08:00
Claudio Cambra
7ff1d011c0
Build shareOwnerAvatar image provider string when handling sharedWithMe share in ShareModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-21 01:48:44 +08:00
Claudio Cambra
cec497073e
Add shareOwnerAvatar property to ShareModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-21 01:48:17 +08:00
Claudio Cambra
d479c13ac7
Add ability to fetch remote server avatars in usermodel avatar ImageResponse
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-21 01:46:56 +08:00
Claudio Cambra
896e61ae04
Convert ImageProvider in an async image provider using an internal image response
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-21 01:46:27 +08:00
Claudio Cambra
88a2904651
Bolden string showing who owns the share that was shared with me
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-20 17:48:47 +08:00
Claudio Cambra
aa7be97edb
Display share owner rather than file owner (this is more relevant to user)
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-20 17:48:32 +08:00
Claudio Cambra
cf36ab9a2b
Display shared with me file's share expiry in share view if relevant
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-20 17:37:09 +08:00
Claudio Cambra
fce130440e
Display file owner information (if not self) in share view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-20 17:36:52 +08:00
Claudio Cambra
cf0dd27b5f
When handling fetched shares, record shared-with-me related information in sharemodel properties
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-20 17:36:20 +08:00
Claudio Cambra
a72f23a4d3
Also fetch shared with me share on target path
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-20 17:35:42 +08:00
Claudio Cambra
4fdac399f0
Add sharedWithMe-related properties to sharemodel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-20 17:33:14 +08:00
Claudio Cambra
b687f1b2c2
Set if the file owner should be displayed and the file owner display name on propfind in sharemodel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-20 17:30:57 +08:00
Claudio Cambra
77c6dd6e33
Add fileOwnerDisplayName property to ShareModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-20 17:29:15 +08:00
Claudio Cambra
c62588b49d
Add displayFileOwner property to ShareModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-20 17:28:13 +08:00
Claudio Cambra
544ae0b33e
Merge pull request #7328 from nextcloud/bugfix/global-progress-vfs-bigsur
Check for availability of Big Sur (under 11.3) before using VFS progress tracking method
2024-10-18 14:00:29 +08:00
Claudio Cambra
d1e26b27f9 Wrap use of NSFileProviderManager globalProgress in availability check
This selector was only made available on macOS 11.3
Just to be safe we should check for the availability

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-18 14:00:21 +08:00
Claudio Cambra
18fb6dc456
Merge pull request #6123 from nextcloud/bugfix/docs-format
Fix issues on manpages
2024-10-18 13:34:09 +08:00
Claudio Cambra
34e4f40408 Incorporate doc fixes from pull request #6122
Fix issues on manpages

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-18 13:33:59 +08:00
Nextcloud bot
5412fd2498
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-10-18 02:52:09 +00:00
Claudio Cambra
2d300240c0
Merge pull request #7351 from nextcloud/bugfix/alwaysRecordMovedItemsAfterServerReplied
on receiving reply of a remote MOVE: always record it
2024-10-18 10:22:09 +08:00
Matthieu Gallien
0eb5ddd442 on receiving reply of a remote MOVE: always record it
even if local item has disappeared, record the result of a remote MOVE
when receiving the reply

enable better state tracking when syncing rename or move operations

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-18 10:09:08 +08:00
Claudio Cambra
471ed2f4e9
Merge pull request #7346 from nextcloud/Rello-patch-1
remove ownCloud wording in logging
2024-10-18 10:07:58 +08:00
Rello
2695590f70 remove ownCloud wording in logging
remove ownCloud wording in logging

Signed-off-by: Rello <Rello@users.noreply.github.com>
2024-10-18 10:07:47 +08:00
Claudio Cambra
1b78915961
Merge pull request #3014 from nextcloud/foreground-background
Show/Hide Menubar and Dock Icon on macOS
2024-10-17 16:45:17 +08:00
Elsie Hupp
0ad55e82c7
Show/Hide Menubar and Dock Icon
Signed-off-by: Elsie Hupp <9206310+elsiehupp@users.noreply.github.com>
2024-10-17 16:26:28 +08:00
Claudio Cambra
32b035b1e6
Merge pull request #4367 from nextcloud/finder-sidebar-icon-fix
Fix Finder sidebar icon to work as a "template" image
2024-10-17 15:55:13 +08:00
Elsie Hupp
b04edf1b62 Fix Finder sidebar icon to work as a "template" image and change to SF Symbols lineweights
Signed-off-by: Elsie Hupp <github@elsiehupp.com>
2024-10-17 15:54:45 +08:00
Matthieu Gallien
809c699e71
Merge pull request #7321 from nextcloud/dependabot/github_actions/cpp-linter/cpp-linter-action-2.13.2
Bump cpp-linter/cpp-linter-action from 2.13.1 to 2.13.2
2024-10-17 09:53:13 +02:00
dependabot[bot]
be018efb0b Bump cpp-linter/cpp-linter-action from 2.13.1 to 2.13.2
Bumps [cpp-linter/cpp-linter-action](https://github.com/cpp-linter/cpp-linter-action) from 2.13.1 to 2.13.2.
- [Release notes](https://github.com/cpp-linter/cpp-linter-action/releases)
- [Commits](https://github.com/cpp-linter/cpp-linter-action/compare/v2.13.1...v2.13.2)

---
updated-dependencies:
- dependency-name: cpp-linter/cpp-linter-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-10-17 09:53:06 +02:00
Matthieu Gallien
b59c7b4aa0
Merge pull request #7334 from nextcloud/bugfix/useFileIdToTrackRenamedItems
Bugfix/use file id to track renamed items
2024-10-17 09:46:17 +02:00
Matthieu Gallien
05b6db55c3 remove the enforcement of identical etag for a server side item MOVE
orignally added by https://github.com/owncloud/client/pull/6632

most probably a too strong assumption on the behavior of the Nextcloud
server

better check real item metadata like fileid, size or modification time

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-17 09:45:57 +02:00
Matthieu Gallien
f0908dbbfc handle NEW/NEW conflicts by being real conflicts
NEW/NEW conflicts could sometime be ignored and replaced by update
metadata instructions

we stop doing this and handle them like any other conflicts

that would cause more download from the server

those conflicts would be solved automatically in case this is not a real
conflict but the client was missing the server reply with the updated
metadata

will enable more changes to improve MOVE detection from server side

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-17 09:45:57 +02:00
Matthieu Gallien
7301ad3356 in automated tests, update modtime when modifying the content of a file
why one would not update the modification time when modifying a remote
file during automated tests

there is no reason to not update the modification time as this is what
is done by the server

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-17 09:45:57 +02:00
Matthieu Gallien
fe47ca01ce
Merge pull request #7291 from nextcloud/bugfix/improveLocalDiscoveryLogs
better logs to understand when a folder is locally discovered
2024-10-17 08:52:36 +02:00
Matthieu Gallien
8abe8e6f52 better logs tounderstand when a folder is local scanned
should hopefully allows to understand when local file system discovery
is done or omitted

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-17 08:52:27 +02:00
Matthieu Gallien
647f5b26a2
Merge pull request #7285 from nextcloud/bugfix/catchFilesystemExceptions
test syncing of read-only .lnk windows shorcuts
2024-10-17 08:51:47 +02:00
Matthieu Gallien
8a791713cd test syncing of read-only .lnk windows shorcuts
related to https://github.com/nextcloud/desktop/pull/7282

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-17 08:51:37 +02:00
Nextcloud bot
88f3ef3944
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-10-17 02:52:33 +00:00
Matthieu Gallien
97539218e6
Merge pull request #7333 from nextcloud/bugfix/signature
Bugfix/signature
2024-10-16 15:22:21 +02:00
Camila Ayres
ddaaf2c344 Fail with error before calling folder metada setup when received empty signature.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-10-16 11:51:01 +02:00
Camila Ayres
ef811ff220 Report client status error when signature is empty.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-10-16 11:51:01 +02:00
Camila Ayres
0e218bc549 Add test testFolderMetadataWithEmptySignatureDecryptFails.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-10-16 11:51:01 +02:00
Camila Ayres
8cce183ba4 Check if signature is empty.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-10-16 11:51:01 +02:00
Claudio Cambra
e02cf85201
Merge pull request #7322 from nextcloud/bugfix/vfs-crash-socketcontroller
Fix crash caused due to null accountstate in FileProviderSocketController
2024-10-16 16:09:05 +08:00
Claudio Cambra
14a9382772 Fix crash caused by null accountstate due to bad domain identifier parsed from FPExt
Turns out since we are forced to replace colons with hyphens we need to
replace them back to colons when we receive the domain identifier from
the file provider extension. If we do not then we get a null
accountState pointer in the socket controller and this causes a crash

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-16 15:49:59 +08:00