Commit graph

22351 commits

Author SHA1 Message Date
Matthieu Gallien
4923873ac8 ensure folder permissions are read-only when needed
a folder item must be set read-only if files or sub-folders cannot be
created

a folder item must be set read-write in all other situations

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-11-21 12:06:57 +01:00
Matthieu Gallien
728cff383e
Merge pull request #7495 from nextcloud/feature/smartFlushOfLogs
flush logs every 5 lines written
2024-11-21 12:06:19 +01:00
Matthieu Gallien
fac4cedd2b flush logs every 5 lines written
should help not loosing too much logs in case of a crash or similar not
nominal stop of the client

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-11-21 12:06:06 +01:00
Matthieu Gallien
ea94e4490d
Merge pull request #7517 from nextcloud/feature/noDefaultShareLinks
Feature/no default share links
2024-11-21 12:04:58 +01:00
Matthieu Gallien
ba4138a13d improve files explorer context menu by removing obsolete commands
remove any commands related to publi share links because they either got
replaced by the use of the share dialog or are better achieved by
showing the share dialog

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-11-21 12:04:47 +01:00
Claudio Cambra
b0057a7f77
Merge pull request #7541 from nextcloud/bugfix/final-mac-crafter-fix-istg
Fix mac-crafter codesign executable detection
2024-11-21 18:52:33 +08:00
Claudio Cambra
a8c0eca6ba
Do not do final bundle codesign
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 18:47:32 +08:00
Claudio Cambra
e8ac221769
Do not rely on FileManager's isExecutableFile, check manually for Mach-O executable type
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 18:47:32 +08:00
Claudio Cambra
92f0cd96ef
Allow using an external task for running commands in mac-crafter run command
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 18:46:59 +08:00
Matthieu Gallien
0208ec6b79
Merge pull request #7512 from nextcloud/bugfix/search-view-on-focus
Pull up the unified search view immediately on unified search field focus
2024-11-21 10:14:51 +01:00
Claudio Cambra
f7ae0254fc Unify definition of unified seach placeholder views fonts
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 10:13:00 +01:00
Claudio Cambra
1a052a42f2 Clean up ids of internal components of placeholder views
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 10:13:00 +01:00
Claudio Cambra
a50074362e Place unified search placeholder view in main tray window view when in focus and no text is entered
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 10:13:00 +01:00
Claudio Cambra
5fdc8a236f Add a UnifiedSearchPlaceholderView
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 10:13:00 +01:00
Claudio Cambra
baedf1502e On escape pressed of unified search placeholder view, diable activeSearchFocus
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 10:13:00 +01:00
Claudio Cambra
e8eb8adf5f Fix keyboard tab behaviour when focus reaches unified search bar
Do not activate search if the focus reason is tab as otherwise the user
will never be able to access elements that depend on search being
inactive via the keyboard

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 10:13:00 +01:00
Claudio Cambra
02372d9237 Add a mouse area to allow de-focusing the unified search text field on click elsewhere
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 10:13:00 +01:00
Claudio Cambra
3f26947525 Make the unified search input being focused a valid active reason
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 10:13:00 +01:00
Matthieu Gallien
b421b35dff
Merge pull request #7375 from nextcloud/bugfix/filetag-fetching-path
Fix file tag fetching for files in sync folders that have non-root remote target
2024-11-21 09:58:19 +01:00
Claudio Cambra
2769ae8a53 Remove unused includes in filetagmodel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 09:57:39 +01:00
Claudio Cambra
f159f40ec9 Add missing nodiscards in folder methods
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 09:57:39 +01:00
Claudio Cambra
8ef972211b Move setup of server relative path used in FileTagModel into FileDetails
This fixes the build breakages in the file tag model tests

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 09:57:39 +01:00
Claudio Cambra
bf2303cd6c Ensure we are checking for tags in correct server path regardless of the particular local path
Fixes issues with users who are using remote non-root sync folders

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 09:57:39 +01:00
Claudio Cambra
b8b8b480aa Simply pass AccountPtr to updateFileTagModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 09:57:39 +01:00
Claudio Cambra
20a4915e7c Store fetched folder as private member in filedetails
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 09:57:39 +01:00
Claudio Cambra
fd769adb05 Mark non-const getters in Folder definition as const
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 09:57:39 +01:00
Claudio Cambra
92d0dca614
Merge pull request #7537 from nextcloud/bugfix/exec-detection-mac-crafter
Do not treat bundles as executables in codesign check
2024-11-21 16:26:39 +08:00
Claudio Cambra
da581e2b0e
Do not treat bundles as executables in codesign check
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 16:24:52 +08:00
Matthieu Gallien
258ba6da85
Merge pull request #7498 from nextcloud/bugfix/ui-polish
Polish tray window interface
2024-11-21 08:41:41 +01:00
Claudio Cambra
cf2d895625
Move tray window header component into separate file
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 14:37:29 +08:00
Claudio Cambra
2a2b0daa53
Move current account header button definition into own file
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 14:22:24 +08:00
Claudio Cambra
362d3d9f72
Do not load caret on current user button if the button had a non-null indicator
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 14:11:41 +08:00
Claudio Cambra
330483cc12
Remove unused properties from UserLine
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 13:51:29 +08:00
Claudio Cambra
beda545f3d
Remove rectangle aboce folder state indicator background in tray folders menu button
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 13:29:45 +08:00
Claudio Cambra
a1e57fe09f
Reduce size of tray window header
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 13:21:02 +08:00
Claudio Cambra
0f689fd255
Fix colour of indicator outlines in tray header elements
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

f bgc

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 13:21:02 +08:00
Claudio Cambra
a235b9379d
Remove unused style measurements
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 13:21:02 +08:00
Claudio Cambra
ccff4fa1c7
Use constexpr for accentcolor adjustment value
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 13:21:01 +08:00
Claudio Cambra
fab03f2369
Give sync progress bar expected fill colour
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

f p

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 13:21:01 +08:00
Claudio Cambra
a8982465a9
Use accentColor rather than header colour where appropriate
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 13:21:01 +08:00
Claudio Cambra
7c317cb4d9
Remove unused colours from style
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 13:21:01 +08:00
Claudio Cambra
4a383f93fc
Move remaining uses of secondary text color to use palette midlight, remove this property froms style
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 13:21:01 +08:00
Claudio Cambra
0a40388a7a
Use standard text colour in ncinputtextedit
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 13:21:01 +08:00
Claudio Cambra
6b91a7e43d
Remove background color from Style, use palette base in its place
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 13:21:01 +08:00
Claudio Cambra
5688cc1d27
Remove now unused hover colors
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 13:21:01 +08:00
Claudio Cambra
874aaa35a0
Remove menuBorder Style variable, just use palette (as we have already done in parts)
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 13:21:01 +08:00
Claudio Cambra
33d525069e
Fix search bar separator in tray window
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 13:21:00 +08:00
Claudio Cambra
e69b2275de
Do not use magic numnbers for spacing of sync status icon
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 13:21:00 +08:00
Claudio Cambra
7c213de8d7
Fix displaying of busy indicator on share view
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 13:21:00 +08:00
Claudio Cambra
17d3930590
Fix label alignments on share view checkboxes
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-11-21 13:21:00 +08:00