Commit graph

15194 commits

Author SHA1 Message Date
Kevin Ottens
607347289e Expose more of the logger state
It is better to rely on the Logger state to know exactly where we're
logging. Indeed due to the the various ways to impact its state the
config alone might not now where we're logging.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-10-07 13:33:20 +00:00
Kevin Ottens
167800320f Make sure --logfile has precedence on config
Since we changed the default in the config file and since log dir had
precedence on log file, the --logfile command line option wasn't doing
anything anymore.

We make sure it has an effect again overriding --logdir or the logDir
config entry.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-10-07 13:33:20 +00:00
Kevin Ottens
b0a38816fc Change the defaults for logging
Turn on the logging by default for everyone. Let's use a log dir within
the config directory of the application and have debug logs expiring
after a day.

This obviously means we'll generate quite some logs but with the
automated compression it shouldn't be too horrible. Obviously that
scales with the amount of files and syncs occurring. In our tests with a
large setup we're around 100 MB for a day worth of logs, this shouldn't
be too much of an issue on today's average desktop/laptop.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-10-07 13:33:20 +00:00
Michael Schuster
f90ae66d94
Merge pull request #2520 from nextcloud/handle_askForOptionalPassword_capability
Handle ask for optional password capability
2020-10-07 15:30:17 +02:00
Kevin Ottens
e78312f094 If askForOptionalPassword is enabled preset a random password
This is the same approach used on the server side. Turns out I quite
like it, this avoids popping up a dialog to the user and since she won't
know the password she'll have to set a new one anyway or disable it.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-10-07 09:43:47 +00:00
Kevin Ottens
099d25a56c Since we must ask for a password this can't be a default public link
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-10-07 09:43:47 +00:00
Kevin Ottens
e356acbcee Add sharePublicLinkAskOptionalPassword to Capabilities
Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-10-07 09:43:47 +00:00
Nextcloud bot
d6f53d66f4
[tx-robot] updated from transifex 2020-10-07 03:36:23 +00:00
Nextcloud bot
a2a58eefde
[tx-robot] updated from transifex 2020-10-06 03:36:51 +00:00
Michael Schuster
36002701ed
Merge pull request #2512 from nextcloud/fix_updater_with_github_downloads
Handle redirects when downloading updates
2020-10-05 16:56:23 +02:00
Kevin Ottens
f39542688a
Handle redirects when downloading updates
This is necessary for downloads coming from Github for instance. They
are systematically redirected and we'd just fail the download.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
2020-10-05 15:48:39 +02:00
Kevin Ottens
01152d3f37
Merge pull request #2500 from nextcloud/docs-msi
Windows MSI: Update Docs & add SKIPAUTOUPDATE property
2020-10-05 09:43:00 +02:00
Michael Schuster
b552c77128 Docs: Be slightly more modern and use 64-bit examples
Signed-off-by: Michael Schuster <michael@schuster.ms>
2020-10-05 07:18:35 +00:00
Michael Schuster
ce279d0bbd Windows MSI: Add SKIPAUTOUPDATE property for the skipUpdateCheck setting
Signed-off-by: Michael Schuster <michael@schuster.ms>
2020-10-05 07:18:35 +00:00
Michael Schuster
c5ff288b37 Docs: Use our app name in the MSI docs
Signed-off-by: Michael Schuster <michael@schuster.ms>
2020-10-05 07:18:35 +00:00
Michael Schuster
2476dcb425 Windows MSI: Stay compatible with the upstream "StartMenuShortcuts" feature
Even though we only create a program shortcut in the Start Menu, try to make administrators lives easier by not diverging feature and option naming.

Signed-off-by: Michael Schuster <michael@schuster.ms>
2020-10-05 07:18:35 +00:00
Michael Schuster
bf6980d31a Docs: Adopt latest MSI doc enhancements from upstream master
Signed-off-by: Michael Schuster <michael@schuster.ms>
2020-10-05 07:18:35 +00:00
Dominik Schmidt
8e48d53b04 Docs: Adopt upstream commit fe04300 for MSI installation
See: fe043006c8

Signed-off-by: Michael Schuster <michael@schuster.ms>
2020-10-05 07:18:35 +00:00
Michael Schuster
0e5d9a5a6b Docs: Update macOS version info
Signed-off-by: Michael Schuster <michael@schuster.ms>
2020-10-05 07:18:35 +00:00
Nextcloud bot
d1c0481338
[tx-robot] updated from transifex 2020-10-05 03:38:36 +00:00
Nextcloud bot
06177b1a7c
[tx-robot] updated from transifex 2020-10-04 03:38:54 +00:00
Nextcloud bot
ebe7cbf0ed
[tx-robot] updated from transifex 2020-10-03 03:40:51 +00:00
Michael Schuster
a0b351b145
Merge pull request #2497 from nextcloud/fix/mac-folderwatcher-memory-leak
macOS: Fix memory leak in FolderWatcherPrivate::startWatching
2020-10-02 19:30:26 +02:00
Michael Schuster
bb30633d31 Fix source file access modes
Signed-off-by: Michael Schuster <michael@schuster.ms>
2020-10-02 16:56:29 +00:00
Michael Schuster
5979ae30e1 macOS: Fix memory leak in FolderWatcherPrivate::startWatching
Signed-off-by: Michael Schuster <michael@schuster.ms>
2020-10-02 16:56:29 +00:00
Nextcloud bot
4b985ab3b3
[tx-robot] updated from transifex 2020-10-02 03:32:41 +00:00
Michael Schuster
5467909389
Merge pull request #2478 from Aldaris1985/patch-1
Update propagateupload.cpp
2020-10-02 00:07:45 +02:00
Aldaris1985
ef6773bd60 Update propagateupload.cpp
Typo corrected.
2020-10-01 21:26:17 +00:00
Kevin Ottens
c1feecc727
Merge pull request #2493 from nextcloud/kesselb-patch-1
Delete FUNDING.yml
2020-10-01 13:03:09 +02:00
kesselb
fbeba931d2
Delete FUNDING.yml 2020-10-01 11:21:12 +02:00
Nextcloud bot
ce2dec0194
[tx-robot] updated from transifex 2020-10-01 03:40:09 +00:00
Kevin Ottens
48524fc1f4
Merge pull request #2487 from nextcloud/add-talk-icon
Add a clickable icon for Talk notifications.
2020-09-30 14:02:27 +02:00
Camila
954544830d Add a clickable icon for Talk notifications.
Signed-off-by: Camila <hello@camila.codes>
2020-09-30 08:46:01 +00:00
Nextcloud bot
2cb919a684
[tx-robot] updated from transifex 2020-09-30 03:39:38 +00:00
Kevin Ottens
6569ecbd27
Merge pull request #2272 from snake66/issues/2219/deprecate-foreach
Issues/2219/deprecate foreach
2020-09-29 19:58:52 +02:00
Harald Eilertsen
7721da25e5 Replace find_if with none_of where appropriate.
We're not interested in any found element in these cases, just to check
that none of the elements matches.

Signed-off-by: Harald Eilertsen <haraldei@anduin.net>
2020-09-29 19:32:39 +02:00
Harald Eilertsen
061ef027ff Don't hold ref to value returned from function.
Signed-off-by: Harald Eilertsen <haraldei@anduin.net>
2020-09-29 19:32:24 +02:00
Harald Eilertsen
074a94ceb9 gui/accountmanager: Make isAccountIdAvailable a bit clearer.
Signed-off-by: Harald Eilertsen <haraldei@anduin.net>
2020-09-29 19:31:24 +02:00
Harald Eilertsen
62bf4c5fda gui/folderman: Replace foreach (#2219)
Signed-off-by: Harald Eilertsen <haraldei@anduin.net>
2020-09-29 19:31:24 +02:00
Harald Eilertsen
677997b2b3 gui/folder: Replace foreach (#2219)
Signed-off-by: Harald Eilertsen <haraldei@anduin.net>
2020-09-29 19:31:23 +02:00
Harald Eilertsen
5bd2529ca6 gui/application: replace foreach (#2219)
Signed-off-by: Harald Eilertsen <haraldei@anduin.net>
2020-09-29 19:31:23 +02:00
Harald Eilertsen
e343b4b947 gui/accountstate: Replace foreach (#2219)
Signed-off-by: Harald Eilertsen <haraldei@anduin.net>
2020-09-29 19:31:23 +02:00
Harald Eilertsen
225fdabf6a gui/accountstate: Replace foreach (#2219)
Most instances have been converted to range based for, but std::find_if
has been used where it made sense.

Signed-off-by: Harald Eilertsen <haraldei@anduin.net>
2020-09-29 19:31:23 +02:00
Harald Eilertsen
1898782781 gui/accountmanager: Replace foreach/Q_FOREACH (#2219)
Signed-off-by: Harald Eilertsen <haraldei@anduin.net>
2020-09-29 19:31:23 +02:00
Harald Eilertsen
5f4cec870b cmd: Replace foreach with range base for (#2219)
Signed-off-by: Harald Eilertsen <haraldei@anduin.net>
2020-09-29 19:31:23 +02:00
Camila
1b1975e01d
Merge pull request #2486 from nextcloud/fix-notification
Connect signal guiLog to slot to display systray message.
2020-09-29 19:26:06 +02:00
Camila
dc12cdf196
Correct the object name returned by the api.
The id was always 0 so no new systray messages were displayed.

Signed-off-by: Camila <hello@camila.codes>
2020-09-29 18:53:28 +02:00
Camila
d2eb24a9a8
Connect signal guiLog to slot to display systray message.
Signed-off-by: Camila <hello@camila.codes>
2020-09-29 18:53:28 +02:00
Kevin Ottens
b9873cac63
Merge pull request #2485 from nextcloud/Valdnet-patch-1
l10n: Remove space from string text
2020-09-29 14:43:39 +02:00
Valdnet
d50ad548d2
l10n: Remove space from string text 2020-09-29 14:39:34 +02:00