Matthieu Gallien
69d6f4acec
our source code files have lower case names
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-10-25 15:38:21 +02:00
alex-z
1b8448402a
Fix JsonApiJob incorrect 'statuscode' parsing.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2021-10-25 14:45:05 +03:00
alex-z
c1dab7e4cb
Unified Search via Tray window
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2021-10-25 14:45:05 +03:00
rakekniven
91884eef4a
Changed wording to suggestion
...
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2021-10-23 07:06:23 +00:00
rakekniven
fb3c740129
Changed wording of status message
...
The files themselves have no problem. The sync process has problems.
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2021-10-23 07:06:23 +00:00
alex-z
da03acc656
Fix folder creation issues.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2021-10-20 19:47:41 +00:00
Felix Weilbach
9f35fa6d3d
Also update sync state summary based on connectivity
...
Otherwise, with zero folders configured, the state will stay at
offline.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-10-20 12:31:55 +02:00
Felix Weilbach
1156d82594
Log file name and line number
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-10-19 17:10:44 +00:00
alex-z
bd731a9cda
Windows. Remove CWD from DLL search paths.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2021-10-19 06:40:56 +00:00
Felix Weilbach
24f6bc5203
Only use basic authentication if needed
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-10-18 12:20:20 +02:00
Camila
c6e629c30d
Give the user a more descriptive error message when syncing is aborted.
...
Signed-off-by: Camila <hello@camila.codes>
2021-10-18 09:50:02 +02:00
Valdnet
22b0a2e196
i18n: Correct typo and remove apostrophe
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-10-15 08:44:02 +02:00
Felix Weilbach
d51bfec61d
Remove unnecessary braces
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-10-14 19:56:39 +00:00
Felix Weilbach
f27ef02273
Set dialog max and min width and height before width and height
...
Otherwise, resize events will not be processed correctly.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-10-14 19:56:39 +00:00
Felix Weilbach
a663d235ef
Add .sync-exclude.lst to exclude files
...
Previously the .sync-exclude.lst file of the sync root directory was
not added to the exclude files, because the current logic did only
recognize .sync-exclude.lst files when their containing directory was
discovered during the discovery phase. Therefore the sync root
.sync-exclude.lst file was never discovered. See also
ExcludedFiles::traversalPatternMatch().
Fix : #3830 , #2728
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-10-14 14:02:29 +00:00
Felix Weilbach
df11424596
Trim trailing spaces before uploading files
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-10-14 11:22:59 +00:00
Matthieu Gallien
46bc0452c7
provide logs of SSL errors including the certificate chain
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-10-13 15:20:52 +00:00
Felix Weilbach
0792dc36c2
Check if current user exists before getting it's account state
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-10-13 11:25:13 +02:00
Felix Weilbach
4c11f6763e
Show sync progress in main dialog
...
Fixes #3662
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-10-12 16:14:24 +00:00
Matthieu Gallien
d76778e3ee
fix macOs build after targets name are not changed by branding
...
target names used to be variable depending on branding
now the target names are always constant but generated output file names
are set according to active branding
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-10-11 07:41:29 +00:00
Felix Weilbach
2da6dab403
Add missing copyright headers
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-10-08 13:19:10 +02:00
Kevin Ottens
5fe63a4d9a
Display the right endpoint in the warning in case of error
...
At that point in time _pollEndpoint isn't set yet. All the checks are
against pollEndpoint so display that one in the warning. Otherwise one
always end up with an empty URL in the logs which is not very useful for
debugging purposes.
Signed-off-by: Kevin Ottens <kevin.ottens@enioka.com>
2021-10-06 10:17:38 +00:00
Matthieu Gallien
833237b2e4
use alias target for internal libraries
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-10-06 07:56:33 +00:00
Matthieu Gallien
c751fd5672
ensure DLL are generated with branded names
...
cmake distinct runtime and library
on unix dynamic shared libraries are library kind of objects
on windows they are runtime kind of objects
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-10-06 07:56:33 +00:00
Felix Weilbach
0c9dce1154
Add file activity dialog
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-10-05 12:41:34 +00:00
alex-z
6cafcc1124
Remove Temporary solution for file restoration issue due to failing to set the data-fingerprint.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2021-09-30 08:39:47 +00:00
Guido Falsi
b0b70d1e77
Check for argp library before depending on it.
...
Signed-off-by: Guido Falsi <madpilot@freebsd.org>
2021-09-29 15:46:07 +02:00
Guido Falsi
5f036641b9
Add -largp on non linux systems.
...
Signed-off-by: Guido Falsi <madpilot@freebsd.org>
2021-09-29 15:46:07 +02:00
Felix Weilbach
d6e60cd8d4
Don't log encryption data in release mode
...
We deliver our builds to users with debug logging enabled to have an
easier time finding problems. However, logging all the encryption data
in this loop is too much and should not be done in release mode.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-27 19:50:38 +00:00
Camila
df38e5c08b
Apply server default permissions for federated file sharing too.
...
See nextcloud/server#24729 comments.
Signed-off-by: Camila <hello@camila.codes>
2021-09-27 08:53:45 +00:00
Camila
8f847906c6
Check server capabilities for file sharing default permissions.
...
Signed-off-by: Camila <hello@camila.codes>
2021-09-27 08:53:45 +00:00
alex-z
dc22307a42
Fix review comments + also check against trailing bakslash.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2021-09-27 08:13:29 +00:00
alex-z
e16402a102
Fix incorrect db name for nextcloud command line client.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2021-09-27 08:13:29 +00:00
rakekniven
68e02bc62d
Fixed context
...
Reported at Transifex.
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2021-09-27 07:25:08 +00:00
rakekniven
49e1b12eb1
Fixed grammar
...
Reported at Transifex.
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2021-09-27 07:25:08 +00:00
Felix Weilbach
d3d8b1c631
Add dialog to resolve invalid filenames
...
Fixes #3751
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-23 10:45:15 +00:00
Matthieu Gallien
ac28cc1cf5
set default format for QSurface to handle NVidia context loss events
...
should fix wrong OpenGL rendering after suspend on Linux with NVidia
binary OpenGL driver
close #3759
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-09-22 08:56:16 +00:00
alex-z
59199fc907
General Settings window. Allow opening the update URL via mouse.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2021-09-21 16:21:38 +02:00
Camila
db447c4676
Refactor OcsShareJob creation.
...
Signed-off-by: Camila <hello@camila.codes>
2021-09-21 10:01:20 +00:00
Camila
ba8ec56e65
Add option to create label for share link.
...
Signed-off-by: Camila <hello@camila.codes>
2021-09-21 10:01:20 +00:00
Matthieu Gallien
19b77416da
TextInput by default do not allow selecting text by mouse
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-09-21 08:07:19 +00:00
rakekniven
af49a7993a
Fixed placeholder numbering
...
Fix for #3812
Reported at Transifex.
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2021-09-20 11:39:51 +02:00
Felix Weilbach
0074d6c40a
Disable Qt deprecation warnings
...
They don't help us during regular development and some of them are not
fixable (e.g. QNetworkMangerConfiguration) in the open source variant
of Qt5.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-17 13:32:26 +00:00
Felix Weilbach
fb1b3481d1
Fix warnings
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-17 13:32:26 +00:00
Camila
e4e74ff38f
Display share note when there is one associated with a share link.
...
Signed-off-by: Camila <hello@camila.codes>
2021-09-17 06:57:08 +00:00
Camila
4581279d23
Fix indentation sharelinkwidget.h.
...
Signed-off-by: Camila <hello@camila.codes>
2021-09-17 06:57:08 +00:00
Felix Weilbach
8370c9c1ca
Accept nc scheme in provider page
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-14 09:01:18 +00:00
Felix Weilbach
86da74908a
Emit user status changed after clear user status
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-14 07:26:46 +00:00
Felix Weilbach
9aee46b3a4
Remove unnecessary logging statements
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-14 07:26:46 +00:00
Dmytro Korchynskyi
cffceaae1f
Fixed warning: extra ';' in Q_ENUM_NS(PinState);
...
Signed-off-by: Dmytro Korchynskyi <kdl.dima@gmail.com>
2021-09-13 13:05:41 +03:00
Dmytro Korchynskyi
5f232c30be
Fixed warnings from ntstatus.h on Windows
...
Signed-off-by: Dmytro Korchynskyi <kdl.dima@gmail.com>
2021-09-13 13:05:41 +03:00
Dmytro Korchynskyi
608fc5fb3a
Fixed warnings by using static_cast
...
Signed-off-by: Dmytro Korchynskyi <kdl.dima@gmail.com>
2021-09-13 13:05:41 +03:00
Valdnet
a441d733dc
l10n: Correct two typo
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-09-10 12:25:34 +02:00
Felix Weilbach
8a8d488454
Add dialog to set user status
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-09 11:18:22 +02:00
alex-z
4018f8d554
Prompt reboot when runing the auto update.
...
Signed-off-by: alex-z <blackslayer4@gmail.com>
2021-09-09 07:20:19 +00:00
Felix Weilbach
5622c33f40
Fix various deprecated warnings
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-08 08:54:00 +00:00
Felix Weilbach
93f590c6de
Replace deprecated use of QProcess::execute()
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-08 08:54:00 +00:00
Felix Weilbach
c9863dc225
Use QRecursiveMutex
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-08 08:54:00 +00:00
Felix Weilbach
b6e3c6d718
Replace deprecated use of QProcess::start()
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-08 08:54:00 +00:00
Felix Weilbach
0af83dd1b6
Use QRandomGenerator instead of qrand
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-08 08:54:00 +00:00
Felix Weilbach
2fe3a7947e
endl has been deprecated
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-08 08:54:00 +00:00
Matthieu Gallien
95e3ecfd3c
prevent infinte recursion when closing a websocket in case of SSL errors
...
the slots connected to the web socket can be called even during close
and lead to infinite calls to close -> error slot -> close -> ...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-09-07 07:09:43 +00:00
Felix Weilbach
6fd0adda52
Close wizard if done
...
This is needed because of the changes in 02bb5db544
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-07 06:43:27 +00:00
Felix Weilbach
031b2e0683
Remove assert that caues crashes
...
This assert does not add value. Utility::concatUrlPath() takes care of
appending paths correctly.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-06 15:54:44 +00:00
allexzander
a3fc812539
Enable share to Talk and Email. Display correct icon. Added unit tests.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-09-06 13:27:39 +00:00
Hannah von Reth
02bb5db544
Remove wizard page that has been dead for 4 years
2021-09-03 16:08:37 +02:00
Felix Weilbach
fa37f5c2bc
Don't create binding loop
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-03 11:48:42 +00:00
Felix Weilbach
8a2097e7b9
Implicitly defined onFoo properties in Connections are deprecated
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-03 11:48:42 +00:00
Felix Weilbach
ba2d8e8201
Only set dav user after login.
...
Setting the credentials of the account inside the auth widget is not a
good idea as that will destroy the previous credentials object which
may wait for a signal to be emitted by the credentials dialog that
was created by the credentials that are going to be deleted. Uff.
It should be enough to set the dav user only after login because the
dav user will never change.
See also the discussion here
https://github.com/nextcloud/desktop/issues/3677#issuecomment-907976839
Fixes #3677
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-09-03 08:32:15 +00:00
Nicolas Fella
bc3eb7845d
Remove unneeded target_link_libraries
...
OS_SPECIFIC_LINK_LIBRARIES is always empty here
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
2021-09-01 11:43:03 +00:00
Nicolas Fella
72277726a3
Remove unneeded include_directories
...
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
2021-09-01 11:43:03 +00:00
Nicolas Fella
18ddb9df4a
Use CMAKE_INSTALL_DATADIR instead of custom DATADIR
...
CMake provides what we wan out of the box
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
2021-09-01 11:43:03 +00:00
Heinz Wiesinger
727de34879
Allow using rsvg-convert to generate pngs instead of inkscape
...
Signed-off-by: Heinz Wiesinger <pprkut@liwjatan.org>
2021-08-31 14:52:46 +02:00
Matthieu Gallien
d17d831205
switch from Q_DECL_OVERRIDE to plain override
...
our requirements guarantee availability of override keyword so we just
use it
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-08-31 08:35:57 +00:00
Matthieu Gallien
25669938fd
let clang-tidy add missing override after enabling again the check
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-08-31 08:35:56 +00:00
Felix Weilbach
44df9283fe
Handle every enum value in switch statement
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-08-26 15:52:25 +00:00
Felix Weilbach
23fca8019b
Add parens around && in || statement
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-08-26 15:52:25 +00:00
Felix Weilbach
4d72d375f2
Fix warnings related to wrong ordering of ctor init
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-08-26 15:52:25 +00:00
Matthieu Gallien
601c4fb3c0
remove a tr call where translator cannot do anything meaningful
...
close #3708
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-08-26 15:26:54 +00:00
allexzander
4927e48bf3
Update nextcloudcmd documentation.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-08-26 10:38:06 +03:00
Matthieu Gallien
23bd4675fd
fix build socket api Mac specific file is now in a subdirectory
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-08-25 14:02:05 +00:00
Valdnet
86cb56757e
l10n: Remove line break
...
A line break is unnecessary in this message.
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-08-25 09:11:06 +00:00
Matthieu Gallien
22a5fadc13
remove broken assert that is not needed and break account setup
...
it has been also removed from the original branch so no problem removing
it
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-08-23 14:13:58 +02:00
Matthieu Gallien
0456cacd79
fix clang-tidy check for usage of =default
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-08-23 09:44:34 +02:00
Hannah von Reth
c273c8f71b
Ensure the socket listener still exists
2021-08-23 09:44:34 +02:00
Hannah von Reth
4b0122093a
Add socket command to upload a selection of files based on a regex
...
(cherry picked from commit 0ded3a56a9f3470a951b18eaa9d3c1b5e8db1135)
2021-08-23 09:44:34 +02:00
Hannah von Reth
010fccb4fa
Remove dead code
2021-08-23 09:44:34 +02:00
Christian Kamm
ebaa98fa7a
owncloudcmd: Use env vars for chunk sizes #7078
...
Moves a bunch of env var reading from Folder into SyncOptions.
2021-08-23 09:44:34 +02:00
Hannah von Reth
10e02b0031
Don't create QStringList copy first
2021-08-23 09:44:34 +02:00
Hannah von Reth
44fa4aad88
Always call doLog to ensure we get a crash log
2021-08-23 09:44:34 +02:00
Hannah von Reth
d16b2bd369
Send crash log as comment
2021-08-23 09:44:34 +02:00
Hannah von Reth
1ff3a0f8b6
Remove anchient debug msg that mutated to a warning over the year
2021-08-23 09:44:34 +02:00
Hannah von Reth
6324ac9cac
Cleanup members
2021-08-23 09:44:34 +02:00
Hannah von Reth
df567efd37
Remove dead code
2021-08-23 09:44:34 +02:00
Hannah von Reth
990ce6ed05
Dump the last 20 lines of logs to a file when we crash
...
Fixes : #8467
2021-08-23 09:44:34 +02:00
Hannah von Reth
48f4c1e9e1
Log fallback result
2021-08-23 09:44:34 +02:00
Hannah von Reth
acd83a2998
Ensure unit test are using absolute paths
2021-08-23 09:44:34 +02:00
Hannah von Reth
1eee5c849e
Add assert to ensure we used _remotePath as base
2021-08-23 09:44:34 +02:00
Hannah von Reth
6c1073db92
Fix another url for etag request
...
Fixes : #7838
2021-08-23 09:44:34 +02:00
Hannah von Reth
5b457a1663
Use byte array for etag
2021-08-23 09:44:33 +02:00
Hannah von Reth
d16befd1fd
Align MkColJob finish signal with the other jobs
2021-08-23 09:40:27 +02:00
Hannah von Reth
c4f4fb48a4
Minor cleanup of socket api
2021-08-23 09:40:27 +02:00
Hannah von Reth
cb57d8e54c
Add missing Q_EMIT
2021-08-23 09:40:27 +02:00
Hannah von Reth
baa571018e
Log invocation, useful for debugging startup issues
2021-08-23 09:40:27 +02:00
Hannah von Reth
789e0e45d5
Fix Windows long path issue introduced in dd641fae997d71c8396b77def2fa25ad96fdf47f
2021-08-23 09:40:27 +02:00
Hannah von Reth
a72ff9ea7f
Set permissions for new folder
2021-08-23 09:40:26 +02:00
Hannah von Reth
90b733801e
Simplify uuid handling
2021-08-23 09:40:26 +02:00
Klaas Freitag
73549a0529
Ignore the desktop.ini file in every directory, not only in top dir. ( #8299 )
...
* Ignore the desktop.ini file in every directory, not only in top dir.
See https://github.com/owncloud/client/issues/8298 for reasons.
* Fix test for ignoring desktop.ini everywhere.
Co-authored-by: Hannah von Reth <hannah.vonreth@owncloud.com>
2021-08-23 09:40:26 +02:00
Hannah von Reth
7715583b14
Correctly use indexOf
2021-08-23 09:40:26 +02:00
Hannah von Reth
557b11aca7
Include os version 'windows-10.0.19042' in about dialog
2021-08-23 09:40:26 +02:00
Hannah von Reth
324d5a04c6
Align type used for getPHash
2021-08-23 09:40:26 +02:00
Hannah von Reth
de2d11125b
Move Prepared sql queries to seperate class to manage access
2021-08-23 09:40:26 +02:00
allexzander
ba73b6d914
VFS + E2EE. Improved data alignment and unit tests for StreamingDecryptor. Refactoring and renaming for readability.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-08-20 12:57:22 +00:00
allexzander
289df252b5
VFS + E2EE. Handle scenario of sync journal deleted.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-08-20 12:57:22 +00:00
allexzander
c28cac8479
VFS + E2EE placeholder size migration from old versions.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-08-20 12:57:22 +00:00
allexzander
2c78925acb
VFS + E2EE VFS implicit hydration of E2EE files.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-08-20 12:57:22 +00:00
allexzander
b6d216b794
Use separate arguments for a remote root and do not use dav or webdav in the server's URL
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-08-20 13:30:35 +03:00
Felix Weilbach
332a48e6a1
Update to Qt 5.15
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-08-19 14:01:46 +02:00
Felix Weilbach
3d72e24bb8
Brand name of vfs plugins
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-08-19 10:30:24 +00:00
Nicolas Fella
43cccb0a73
Don't use variables for CMake target identifiers
...
This makes the code a bit nicer to read and maybe a bit more robust.
Set the relevant OUTPUT_NAME target properties to keep the ability to
customize the names of the installed binaries.
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
2021-08-19 10:30:23 +00:00
Felix Weilbach
d706125b15
Return the login name instead of user id
...
App password and login name need to match. If authResult() returns the
user id the user id will be stored in webdav_user
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-08-12 14:32:07 +02:00
Felix Weilbach
ccd27870a7
Don't compare integers with different signs
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-08-11 20:20:39 +00:00
Felix Weilbach
acf6cc0527
Remove unused functions and variables
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-08-11 20:20:39 +00:00
Felix Weilbach
d72f7e9109
Check result of setPinState()
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-08-11 20:20:39 +00:00
Hannah von Reth
9ffa7bcd4d
Add workaround for issue discovered in https://github.com/owncloud/core/pull/38304
2021-08-11 17:13:44 +00:00
Hannah von Reth
3b99b11849
Always reset prepared sql statements
...
This allow the creation of checkpoints and fixes the growing wal issue
Fixes : #7646
2021-08-11 17:13:44 +00:00
Hannah von Reth
6e0a43b570
Fix clash detection with virtual files
...
Fixes : #8323
2021-08-11 17:13:44 +00:00
Hannah von Reth
45f3a97997
Small cleanup
2021-08-11 17:13:44 +00:00
Hannah von Reth
989390bc41
Don't shadow
2021-08-11 17:13:44 +00:00
Hannah von Reth
3bc026a557
Make findBestChecksum case insensitive
...
Especially the casing of ADLER32 did not match the server.
2021-08-11 17:13:44 +00:00
Hannah von Reth
f977a54694
Finish is already called in the destructor
2021-08-11 17:13:44 +00:00
Hannah von Reth
d60eb67c2e
Also prepend appName if id is empty
2021-08-11 17:13:44 +00:00
Hannah von Reth
8468e70cba
Use QKeychain:: explicitly
2021-08-11 17:13:44 +00:00
Hannah von Reth
926a52b33d
Remove unused computation
2021-08-11 17:13:44 +00:00
Hannah von Reth
ec0466ed73
Allow to add and remove log rules
2021-08-11 17:13:44 +00:00
Felix Weilbach
f9daa27a5d
Enforce fetching of user id
...
With the change of commit 3e61bdc431
and
the relase of v3.3.0 users that had their email address used as login
are not able to login anymore. The dav_user should be empty if users
tried to create a account in the meantime. Therefore we fetch the user
id in the case dav_user (and then Account::_davUser) is empty. We then
store the user id in dav_user.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-08-11 16:16:12 +00:00
Felix Weilbach
5195264a20
Ensure that the users id is used for accessing webdav
...
https://docs.nextcloud.com/server/latest/developer_manual/client_apis/LoginFlow/index.html#obtaining-the-login-credentials
states that the email address can be used for login but it's not
allowed to use the email address to access webdav.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-08-11 15:26:39 +02:00
allexzander
4106c646f9
Fix incorrect activity message on invalid char in the file name.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-08-04 13:22:17 +03:00
allexzander
c930d8e30f
Delete apptoken after account removal.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-08-04 09:37:40 +00:00
Valdnet
dbd061c44b
l10n: Replace apostrophe with double quotation. Remove double space and sort sentence.
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-08-03 15:00:53 +03:00
rakekniven
37b012fcbd
Changed grammar
...
Reported at Transifex.
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2021-08-02 06:40:50 +00:00
szaimen
2c95b9519c
Set default maxChunkSize to 1000MB
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2021-07-30 07:00:09 +00:00
allexzander
fc75b94524
Fix clang-tidy errors.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-07-30 06:21:05 +00:00
Valdnet
7ebbb499e0
l10n: Replace apostrophe with double quotation
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-07-30 06:21:05 +00:00
Matthieu Gallien
391935c90f
prevent crash in Accont::davPath without credentials
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-07-29 08:27:53 +00:00
Felix Weilbach
7bb0c588c1
Don't constrain size of hover background
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-07-28 10:29:04 +00:00
Matthieu Gallien
d2133da3ee
fix review comments
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-07-28 12:27:02 +02:00
Matthieu Gallien
c40d276770
remove dead code around overriding dav path in URL
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-07-28 12:12:17 +02:00
Matthieu Gallien
77433f7e1d
in wizard always use the correct way to get dav path
...
fixes listing being incorrect when using dav endpoint
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-07-28 09:45:49 +00:00
allexzander
98ae715905
Fix crash in Folder::isSyncRunning()
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-07-28 08:58:00 +00:00
allexzander
8122c63ebc
Revert Added config parameter that allows to bypass checksum validation failure.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-07-28 07:57:10 +00:00
Valdnet
9dee4b1a7a
Merge branch 'master' into Valdnet-patch-3
2021-07-23 09:07:18 +02:00
Valdnet
bc9d3c5936
l10n: Change to uppercase
2021-07-22 15:47:52 +00:00
Valdnet
7db51e9029
l10n: Change to uppercase
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-07-22 15:47:52 +00:00
Felix Weilbach
a421ebf01c
Make main dialog normal window when displayed as regular window
...
This will enable users to minimize the dialog.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-07-22 10:34:13 +02:00
Felix Weilbach
302651620b
Use Q_UNUSED instead of commenting out arg names
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-07-21 17:15:11 +00:00
Felix Weilbach
3f6bb4a929
Use QStringLiteral instead of plain strings
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-07-21 17:15:11 +00:00
Felix Weilbach
ee49a7ed52
Fix review comments
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-07-21 17:15:11 +00:00
Felix Weilbach
e4f92ad1a1
Enforce https in flow1 and flow2 for https connections
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-07-21 17:15:11 +00:00
Camila
6886d6213a
Add custom component ActivityItem.
...
That also addresses QML warnings.
Signed-off-by: Camila <hello@camila.codes>
2021-07-21 17:03:26 +02:00
Camila
79dd4f73fe
Fix QML warning: Unable to assign [undefined] to QFont.
...
Signed-off-by: Camila <hello@camila.codes>
2021-07-21 14:46:04 +00:00
Matthieu Gallien
a8ef8bdcb8
do not block account menu: availability checking can be slow
...
ignore availability that can be very slow to check with CfApi virtual
files plugin
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-07-21 12:58:23 +00:00
allexzander
801e4ad363
Create QMessageBox on heap when the update is ready. Do not return true from OCUpdater to allow for a proper app::quit
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-07-21 14:23:43 +03:00
Matthieu Gallien
1fca07546c
print the real permissions string instead of its address
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-07-21 08:25:42 +00:00
Felix Weilbach
4e95e32791
Call setClosed() on correct Object
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-07-20 12:56:00 +02:00
Felix Weilbach
89fea30a3b
Remove Q_INVOKABLE from signals because it's not needed
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-07-20 12:55:37 +02:00
Felix Weilbach
12bdd8742b
Remove unnused variable
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-07-20 07:43:36 +00:00
Felix Weilbach
38467b2e30
Remove unused pushNotifications variable
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-07-20 07:43:36 +00:00
Matthieu Gallien
064f64f06d
fix width of user status message to not overlap other elements
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-07-16 15:19:20 +00:00
Matthieu Gallien
260e1d77f5
clean indentation in UserLine.qml
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-07-16 15:19:20 +00:00
Matthieu Gallien
c2602135ab
fix size of the Label with user status
...
ensure the label width is not higher than the parent to ensure log
string get elided as expected
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-07-16 13:04:33 +00:00
Felix Weilbach
3e61bdc431
Use dav instead of webdav
...
Fixes #3342
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-07-16 12:42:02 +00:00
allexzander
de627a9b7c
Remove request to config for userVisibleURL.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-07-16 06:45:41 +00:00
Felix Weilbach
036db9d22d
Position main dialog on at tray icon if not a regular window
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-07-14 18:27:50 +02:00
Felix Weilbach
efaccbd6fd
Show main dialog as normal window if tray icons not available
...
Fixes #3307
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-07-12 14:10:26 +00:00
Matthieu Gallien
2ee26bbd59
fix review comments
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-07-12 14:31:19 +02:00
Matthieu Gallien
7c68408ee1
only compile xattr virtual files backend for linux platform (not unices)
...
for a reason a mac os platform specific file is missing and before xattr
plugin was compiled only for linux
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-07-12 14:10:54 +02:00
Matthieu Gallien
d2f2e3305a
avoid being stuck trying to create placeholder for existing file
...
id sync db think a file is cirtual (empty placeholder) but file system
has a real file (non empty file) once the server has a modified version
we can no longer update it
state of file on disk takes precedence over sync DB to allow recovery
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-07-09 12:37:47 +00:00
Matthieu Gallien
8ad6f89fed
bring back dynamic load of VFS plugins
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-07-08 08:11:17 +00:00
Matthieu Gallien
c123edb173
address review comments
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-07-06 14:16:43 +00:00
Matthieu Gallien
4016c2fab0
avoid error when doing hydration when data socket is closed too early
...
when data is received, if we close the socket they cannot be read
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-07-06 14:16:43 +00:00
Hannah von Reth
e7e218d8e6
Improve the error message returned by updateMetadata
...
Also properly handle the case the the file can't be converted to a placeholder
as it is locked
2021-07-06 14:03:53 +00:00
Matthieu Gallien
8f5b88acd5
improve error message in case of trailing space in directory name
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-07-02 10:50:31 +00:00
Matthieu Gallien
746072e95d
fix all usage of _com_error(cfExecuteresult).ErrorMessage()
...
_com_error(cfExecuteresult).ErrorMessage() calls should be translated to
QString before use with qDebug and related logging facilities
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-07-02 11:19:04 +02:00
Matthieu Gallien
2bc72592a0
fix review comments
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-07-01 14:40:25 +02:00
Matthieu Gallien
698d5f19ba
download server public key and check user certificate against it
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-07-01 14:07:27 +02:00
allexzander
99f6e82290
Fix review comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-07-01 11:59:21 +03:00
allexzander
6ce5279b6c
Fix review comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-07-01 11:59:21 +03:00
allexzander
22eba41cb8
Do not process non-directories and non-virtual files. Wipe empty online-only folder based on its pinState.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-07-01 11:59:21 +03:00
allexzander
c5982143aa
Refactoring.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-07-01 11:59:21 +03:00
allexzander
48aefc1983
Fix VFS crash and false conflict on local new.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-07-01 11:59:20 +03:00
Matthieu Gallien
c27fc1be4a
use fallback icons for activities without icons
...
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-06-30 11:28:13 +00:00
Matthieu Gallien
269d225511
directly send the icon url for activities to teh qml component
...
should allow usage of default cache from Image qml standard component
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2021-06-30 11:28:12 +00:00
Felix Weilbach
c9715db720
Check if first is not empty
...
If it's not checked that first is empty, crashes may happen.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-06-30 06:57:41 +00:00
Felix Weilbach
015a5ae235
Don't display account name in italic
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-06-25 20:13:06 +00:00
Felix Weilbach
2ee3ca02a4
Add unit test for move custom remote root
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-06-25 10:14:29 +00:00
Felix Weilbach
40065dc6dc
Disable QtWebEngine automatic if not found
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-06-24 15:43:51 +00:00
Felix Weilbach
991f79c123
Open provider page in browser when compiling without webengine
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-06-24 15:43:51 +00:00
Felix Weilbach
8376b99ec5
Allow to compile without QWebEngine
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-06-24 15:43:51 +00:00
Felix Weilbach
216a57c74e
Remove dead code
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-06-24 15:43:51 +00:00
Felix Weilbach
cb5e8398c4
Fix review comment
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-06-21 12:04:11 +02:00
Felix Weilbach
ab9784374f
Fix review comments
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-06-21 12:04:11 +02:00
Felix Weilbach
52342e5710
Prevent crash in dialog that warns user about vfs and e2ee
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-06-21 12:04:03 +02:00
Valdnet
3937595eef
l10n: Spelling unification
...
Spelling unification in Transifex.
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-06-17 12:18:00 +00:00
Valdnet
33bdfe687f
l10n: Spelling unification
...
Spelling unification in Transifex.
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-06-17 12:18:00 +00:00
Felix Weilbach
c799dbdd61
Cfapi: Make sure no data is transfered after cancellation
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-06-17 09:10:06 +00:00
Hannah von Reth
22c634935b
Run expansive assert only in dev builds
2021-06-16 10:54:07 +00:00
Hannah von Reth
03182ea714
Use longWinPath in more places
2021-06-16 10:54:07 +00:00
Hannah von Reth
d014293f6d
Ensure pathtoUNC is called with an absolute path
2021-06-16 10:54:06 +00:00
Camila
7ddc4ca170
Remove extra RowLayout.
...
Signed-off-by: Camila <hello@camila.codes>
2021-06-16 07:55:33 +00:00
Camila
449fda16e1
Fix QML Warning: ReferenceError: PopupMenu is not defined.
...
Signed-off-by: Camila <hello@camila.codes>
2021-06-16 07:55:33 +00:00
Camila
f3c17c747a
Fix compiling warning: multiple definitions of stateOnlineImageSource in theme.h.
...
Signed-off-by: Camila <hello@camila.codes>
2021-06-16 07:55:33 +00:00
Camila
19e581657d
Fix QML warning: Cannot specify left, right... anchors for items inside Row.
...
Signed-off-by: Camila <hello@camila.codes>
2021-06-16 07:55:33 +00:00
Camila
5585f61cc0
Fix QML warning: Detected anchors on an item that is managed by a layout.
...
Signed-off-by: Camila <hello@camila.codes>
2021-06-16 07:55:33 +00:00
Camila
c8edb11228
Fix QML warning: Accessible must be attached to an Item.
...
Signed-off-by: Camila <hello@camila.codes>
2021-06-16 07:55:33 +00:00
Felix Weilbach
7850551cad
Start macOS app bundle name with uppercase letter
...
It's a convention on macOS that app bundle names start with an uppercase
letter. Also this aligns the app name with Windows and Linux.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-06-15 12:19:55 +00:00
allexzander
a3d12a616b
Add error message to GUI.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-06-15 14:33:45 +03:00
allexzander
6312f6ddde
Wipe empty folder when moving a VFS placeholder. Keep a folder if there are hydrated items inside.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-06-15 13:19:35 +03:00
Felix Weilbach
a89a84ff14
Mark placeholder in sync after updating the placeholder
...
Fixes #3403 #3082 #3391
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-06-14 13:40:26 +00:00
Felix Weilbach
d4b0273792
Generate application png icons from svg icons
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-06-14 10:14:28 +00:00
Felix Weilbach
e7c65a71b8
Remove conditional logic for OEM.cmake
...
This file is not used in Brander and in the desktop client and just
confused people.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-06-14 10:14:28 +00:00
allexzander
dc72686ab3
Allow download with mismatched checksum if a config option is set.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-06-10 13:39:11 +03:00
allexzander
d6ddf595f8
Fix review comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-06-08 09:25:43 +00:00
allexzander
5dd310c21c
Fix review comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-06-08 09:25:43 +00:00
allexzander
b150de9106
Fix review comments. Also consider exclude.lst.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-06-08 09:25:43 +00:00
allexzander
bb55232e8e
VFS freeze fix. Treat .sync-exclude.lst as a non-virtual file always.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-06-08 09:25:43 +00:00
AJ Jordan
a51d0a14db
Improve error message
...
This one is more user-friendly and grammatically correct.
Signed-off-by: AJ Jordan <alex@strugee.net>
2021-06-03 11:25:47 +00:00
allexzander
bf39f053c4
Fix review comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-06-01 13:51:02 +00:00
allexzander
a80c58f367
Bugfix. Crash when printing OpenSSL decryption errors with no e2ee mnemonic.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-06-01 13:51:02 +00:00
Felix Weilbach
03610cb706
Set button on QMessageBox before changing the text
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-05-27 07:39:50 +00:00
Matthieu Gallien
7fb09a8163
check e2ee public key against private one
...
should ensure we have matching private/public keys
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
2021-05-27 07:26:48 +00:00
Camila
f758157973
Fix aligment emoji + message on Windows.
...
Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:53 +00:00
Camila
8d2264e027
Display the user status emoji separated from the message.
...
It allows to align the emoji with the message.
Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:53 +00:00
Camila
1cb7f63575
Remove signal refreshCurrentUserGui.
...
Use only QML property bindings to refresh the UI.
Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:53 +00:00
Camila
46f7cd3884
User property isConnected instead of a invokable.
...
Remove unnecessary connection to refreshCurrentUserGui signal.
Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:53 +00:00
Camila
1adde8d547
serverUserStatus => serverHasUserStatus.
...
Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:53 +00:00
Camila
2caa9ccfc6
Add Q_UNREACHABLE() after switch statements in UserStatus.
...
Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:53 +00:00
Camila
73da14040b
Rename ServerUserStatusRole to ServerHasUserStatusRole.
...
- serverHasUserStatus Q_PROPERTY is CONSTANT.
- Fix code style.
Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:53 +00:00
Camila
828881d82a
Do not display the folder status if there are no folders being synced.
...
Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:53 +00:00
Camila
4326eb53ba
Fix margins and sizes to align both avatar + user status displays.
...
Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:52 +00:00
Camila
dc01b76066
Fix code style.
...
Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:52 +00:00
Camila
93227ab08b
Check if new value is different from the current one.
...
In AccountState::setDesktopNotificationsAllowed.
Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:52 +00:00
Camila
f7e9e31bc9
Rename isDesktopNotificationsAllowed property to desktopNotificationsAllowed.
...
- User !== instead of !=.
- Fix code style.
Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:52 +00:00
Camila
820e97cd9b
Do not display the user status if there is no pre defined message.
...
Display the server url instead.
Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:52 +00:00
Camila
c793cbe593
Always display the server url in the drop down account menu.
...
Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:52 +00:00
Camila
419595ce5e
Use DesktopNotificationsAllowedRole to check if user is online.
...
Rename ServerUserStatus to ServerUserStatusRole.
Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:52 +00:00
Camila
bd65eee278
Remove unused methods in UserModel.
...
Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:52 +00:00
Camila
671b099c98
Check if the user is connected and if the server supports user status.
...
Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:52 +00:00
Camila
e3b96ddc85
Move stringToEnum and enumToString to an anonymous namespace.
...
Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:52 +00:00
Camila
1f61d258bb
Fix user status message alignment.
...
Signed-off-by: Camila <hello@camila.codes>
2021-05-25 06:55:52 +00:00
rakekniven
793c211232
Merge branch 'master' into Valdnet-patch-3
2021-05-20 07:47:17 +02:00
Felix Weilbach
78f1943d76
Add a key value store to the sync journal
...
This key value store should help to keep track of important events,
that can not be store in the logs, because the logs are deleted too fast.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-05-19 09:04:43 +02:00
Felix Weilbach
32b7e62359
Warn user if using e2ee and vfs together
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-05-18 11:50:18 +00:00
allexzander
76be5dce73
Add remote folder prefix for renaming in a non-root local folder.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-05-17 12:19:58 +00:00
Felix Weilbach
e2d0481c64
Add CMake option to enable address sanitizers
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-05-17 11:43:55 +00:00
Matthieu Gallien
89be02f8e7
upgrade SQLite3 to 3.35.5
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
2021-05-17 09:48:15 +00:00
Valdnet
a3b2dc669c
One more apostrophe change
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-05-12 12:45:33 +02:00
Valdnet
dadddd7ea2
l10n: Replace apostrophe with double quotation
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-05-12 12:34:22 +02:00
Felix Weilbach
c3a2587a91
Remove unnecessary cfapi logging statements
...
For big files that can add a lot lines to the log files.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-05-12 08:49:13 +00:00
allexzander
bbf11d7e7a
Temporary! Windows. VFS. Block Virtual Files for partition root sync folders.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-05-11 18:53:35 +03:00
Matthieu Gallien
54d91cdd7b
also update ownCloud years interval in copyright notice
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
2021-05-10 10:29:22 +00:00
Matthieu Gallien
86dda5675f
send OS name and version to auto updater to allow selective upgrades
...
in order to be able to suuport legacy OS, also sends the OS name and
version
will be used to detect Windows 8.1 and similar legacy versions
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
2021-05-06 09:32:09 +00:00
Hannah von Reth
17a1a630a4
Use the http logger with the unittests
...
This allow better debugging of the tests
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
2021-05-06 07:35:59 +00:00
Hannah von Reth
98655ef28b
Fix warning by using qsizetype instead of size_t
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
2021-05-06 07:35:59 +00:00
Hannah von Reth
ea3d78aecf
Fix warning by using QByteArrayLiteral
...
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
2021-05-06 07:35:59 +00:00
Hannah von Reth
e04c6abcd5
Fix placeholder detection for cfapi
...
Fixes : #8326
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
2021-05-06 07:35:59 +00:00
Hannah von Reth
adb56178b9
GetLastError() needs to be called when the error happens
...
qDebug might clear it already
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
2021-05-06 07:35:59 +00:00
allexzander
d754bb7102
Fix review comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-05-06 06:17:36 +00:00
allexzander
ef89256d39
VFS. Allow dehydartion of readonly files. Preserve 'readonly' flag when creating a placeholder.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-05-06 06:17:36 +00:00
allexzander
19522210ac
VFS. Display local file name clash error when syncing in VFS mode.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-05-05 17:34:59 +00:00
rakekniven
6d23e93d31
Changed copyright year to 2021
...
Fix for #3258
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2021-05-05 13:37:31 +02:00
Felix Weilbach
aadee15008
Fallback to primary screen if screen under pointer not found
...
Fixes #3252
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-05-05 11:56:46 +02:00
Matthieu Gallien
23ba193102
add missing call to tr to get a translated string
...
Fix #3250
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
2021-05-04 12:16:10 +02:00
Felix Weilbach
7112d2aa78
Push Notifications: Reconnect forever if capabilities allow it
...
Fixes #3115
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-05-04 10:05:19 +02:00
Felix Weilbach
d21df33a50
Add missing copyright headers for push notifications
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-05-04 07:27:06 +00:00
rakekniven
33ef3a1d1e
Merge branch 'master' into rakekniven-patch-2
2021-04-30 14:38:23 +02:00
Valdnet
dc6518a4ee
l10n: Translation of ellipse
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-04-30 13:57:02 +02:00
rakekniven
0e12b0323e
No need to translate ellipsis
...
Here another PR for the same code line as #3238
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2021-04-30 13:27:18 +02:00
Valdnet
f431649bad
l10n: Change to an ellipsis
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-04-30 08:19:25 +00:00
allexzander
e72013fed1
Fix Felix's comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-04-29 07:43:21 +00:00
allexzander
19e2d70c53
Final corrections and refactoring.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-04-29 07:43:21 +00:00
allexzander
deb9ba89f0
Only show password option for email shares.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-04-29 07:43:21 +00:00
allexzander
526fa399dc
Fix review comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-04-29 07:43:20 +00:00
allexzander
c908183044
Use separate progress indicator for password and replace a button with it while running.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-04-29 07:43:20 +00:00
allexzander
0072d39ca0
Fix review comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-04-29 07:43:20 +00:00
allexzander
2d88fc6c99
Obey enforced password for share by email.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-04-29 07:43:20 +00:00
Valdnet
8aedc74838
l10n: Delete space and change capital letter
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-04-28 11:41:06 +00:00
allexzander
e7e5542d3e
Improve public link sharing UI. Fix UX issues.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-04-27 13:51:52 +03:00
yopito
14d61c5071
clang's variadic macro warnings: only for clang
...
following settings of cmake/modules/Warnings.cmake
Signed-off-by: yopito <pierre.bourgin@free.fr>
2021-04-26 13:22:41 +00:00
Felix Weilbach
9a88e38121
Call finish() if going to remove all files
...
While investigating #3172 , I discoverd that the sync will hang forever
if the user has deleted all files on the server. Calling the callback
resolves the problem.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-04-26 12:50:14 +00:00
Matthieu Gallien
419bd93dea
when files get hydrated indirectly through pinning, sets correct state
...
files that get downloaded not through an hydration request need to be
converted to placeholder
sets the expected state when converting them to placeholder files
#3082
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
2021-04-26 13:54:32 +02:00
Matthieu Gallien
929ae965ce
prevent progress bar to appear after a download is finished with CfApi
...
when using Cloud Filter API with enabled VFS on Windows, a progress bar
stays visible for some time after hydration is completed. Not updating a
last time the progress bar prevents that.
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
2021-04-26 13:54:32 +02:00
Matthieu Gallien
97d785f1bb
fix errors when calling CfRegisterSyncRoot by setting more fields
...
sets a reasonable size of the StructSize members in the struct passed to
CfRegisterSyncRoot function
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
2021-04-26 08:02:40 +00:00
Valdnet
796b4e4e72
l10n: Change to an ellipsis
...
Reported on Transifex.
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-04-22 07:40:15 +00:00
Matthieu Gallien
782a2fdf06
avoid an assert by delaying access to response timestamp when in error
...
when canceling the sync of a big directory, I can get some network
request that are aborted before a Date reply header has been read
in this case we would always access
AbstractNetworkJob::responseTimestamp() and fire the assert even if we
know that the network reply has an error
delay the access to after the possible errors have been dealt with
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
2021-04-20 17:42:17 +02:00
Felix Weilbach
275e46f0db
Show progess indicator
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-04-20 07:13:23 +00:00
Felix Weilbach
c3fac23903
Don't delete note and expiration date on toggle
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-04-20 07:13:23 +00:00
Felix Weilbach
8711d5bf49
Don't use unnecessary layout element
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-04-20 07:13:23 +00:00
Felix Weilbach
2851528595
Show user/group note on share if already set
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-04-20 07:13:23 +00:00
Felix Weilbach
22a3b19e08
Add expire date to user and group share
...
Fixes #3100
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-04-20 07:13:23 +00:00
Felix Weilbach
946a51e4c1
Add note to user and group share
...
Fixes #3104
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-04-20 07:13:23 +00:00
Matthieu Gallien
20357ca7fa
Revert "Add CMake option to enable address sanitizers"
...
This reverts commit 3000e26640
.
This was not intended for a direct push
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
2021-04-19 17:54:09 +02:00
Felix Weilbach
3000e26640
Add CMake option to enable address sanitizers
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-04-19 15:38:59 +02:00
allexzander
d65c91ea36
Display VFS sync folder within the navigation panel on Windows.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-04-16 07:18:44 +00:00
Nicolas Fella
2548455f45
Copy FindSharedMimeInfo from ECM
...
Instead of relying on ECM being installed.
We copy other stuff from ECM so be consistent.
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
2021-04-15 14:32:46 +00:00
Felix Weilbach
da1e5c448a
CMake: Use own SQLite3 on macOS and Windows
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-04-15 08:51:06 +02:00
rakekniven
03e7d8da28
Merge branch 'master' into patch-1
2021-04-14 17:11:27 +02:00
Nicolas Fella
70033cda1f
Use imported target for Threads
...
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
2021-04-14 11:07:04 +00:00
castillo92
98a4bb8cce
Update sharedialog.cpp
...
The original sentence uses the word "share" three times and is too redundant when translated into other languages
2021-04-14 09:24:35 +02:00
allexzander
bc919bcc8c
Temporary solution for file restoration issue due to failing the dataFingerprint on client.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-04-14 06:42:48 +00:00
Felix Weilbach
696979cb0e
Display invalid filenames as warning
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-04-13 14:58:51 +00:00
Felix Weilbach
b736355985
Add notification cache
...
The notification cache helps to not display duplicate desktop
notifications to the user.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-04-13 14:58:50 +00:00
Felix Weilbach
b256c6e694
Ping websocket server
...
This helps the client to recognize if the websocket server is still alive.
Fixes #2983
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-04-13 12:19:40 +00:00
Valdnet
e628a51735
l10n: Unify spelling
...
Spelling unification in Nextcloud applications.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-04-13 12:24:57 +02:00
Nicolas Fella
3bc66bea66
Improve Inotify cmake code
...
Use the FindInotify from ECM. It handles the case of Linux vs BSD
correctly automatically.
Also only find Inotify on Linux and BSD
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
2021-04-13 06:36:14 +00:00
Nicolas Fella
b34a901838
Use FindPkgConfig to find libcloudproviders and related libs
...
Instead of using custom find modules.
This allows using imported targets which make the code much nicer.
Signed-off-by: Nicolas Fella <nicolas.fella@gmx.de>
2021-04-12 10:00:08 +00:00
Felix Weilbach
c49dc440bb
Embed version and icon into windows executable
...
These changes are necessary because of changing the compilation
process for the gui from a single executable to static lib +
executable in commit 0521dce174
.
Otherwise the version and icon information will be lost.
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-04-09 13:53:12 +02:00
Camila
1ca0ea49dd
Remove unnecessary local variable.
...
Signed-off-by: Camila <hello@camila.codes>
2021-04-08 07:10:59 +00:00
Camila
29f4a3857b
Reposition qml elements for the folder status icon.
...
Signed-off-by: Camila <hello@camila.codes>
2021-04-08 07:10:59 +00:00
Camila
050bd49373
Rename enumToUserString => enumToString.
...
Signed-off-by: Camila <hello@camila.codes>
2021-04-08 07:10:59 +00:00
Camila
8986975a17
Use enum class instead of enum.
...
Signed-off-by: Camila <hello@camila.codes>
2021-04-08 07:10:59 +00:00
Camila
50de12b3c3
Undo unnecessary removal of lines.
...
Signed-off-by: Camila <hello@camila.codes>
2021-04-08 07:10:59 +00:00
Camila
163015492a
Fix #3067 : missing apps icon.
...
Signed-off-by: Camila <hello@camila.codes>
2021-04-08 07:10:59 +00:00
Camila
c8ac99c8cf
Align status text with server url.
...
Cleans the space in the beginning of the string when there is no emoji
set.
Signed-off-by: Camila <hello@camila.codes>
2021-04-08 07:10:59 +00:00
Camila
e51dad79a2
Refactor UserStatus.
...
- Make preDefinedStatus a local var.
- Add function to get the status user string.
Signed-off-by: Camila <hello@camila.codes>
2021-04-08 07:10:59 +00:00
Camila
d2b762aa66
Move curly brackets to the correct line.
...
Signed-off-by: Camila <hello@camila.codes>
2021-04-08 07:10:59 +00:00
Camila
98cfc362f7
Remove const and reference of base types.
...
Signed-off-by: Camila <hello@camila.codes>
2021-04-08 07:10:58 +00:00
allexzander
4b58c2b7b7
Fix review comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-04-07 09:08:02 +00:00
allexzander
82953d0601
Fix review comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-04-07 09:08:02 +00:00
allexzander
de85b79bb8
Address review comments.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-04-07 09:08:02 +00:00
allexzander
cb8b6ccd9b
Ignore *.lnk files on Windows.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-04-07 09:08:02 +00:00
allexzander
13f4bb541d
Treat .lnk files as normal files without hydrating them or creating a placeholder.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-04-07 09:08:02 +00:00
allexzander
3906ae0922
Another way to fix this.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-04-07 09:08:02 +00:00
allexzander
7235c708dc
Added .lnk file placeholder creation fix.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-04-07 09:08:02 +00:00
allexzander
d5b6d93978
Fix VFS freeze when syncing '.lnk' files on Windows.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-04-07 09:08:02 +00:00
Matthieu Gallien
d6752c96b1
use QFileInfo to check if path is absolute to avoid assert on windows
...
on windos absolute path does not have to start with / . Remove failing assert
when editing ignored files list.
Signed-off-by: Matthieu Gallien <matthieu_gallien@yahoo.fr>
2021-04-07 07:40:07 +00:00
allexzander
0a33e99053
Create std::wstrings out of const wchar_t* so a copy is created every time.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-04-06 10:03:22 +03:00
allexzander
e15045977e
Reduce Socket API logging.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-04-06 09:34:20 +03:00
Felix Weilbach
b2377ff64f
Remove html tags from strings that may appear in notifications
...
The content of notifications on MacOS are not allowed to contain HTML
tags in it. Linux (Free Desktop) notifications may contain HTML tags
in their content. However, it is optional that the notification daemon
interprets the tags. The GNOME notification daemon does not interpret
HTML tags and even does not strip them off. KDE's daemon interprets
the tags. For now I think it's the best solution to remove the HTML
tags. In the future we should fire a action if the user clicks on the
notification and react on it and open the link then. This should work
on all platforms. But as this change involves working with the native
MacOS api and I don't have hardware for that at the moment for that I
will postpone it.
Fixes #2200
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-03-31 16:23:42 +02:00
Felix Weilbach
354f4c02ee
Don't deploy bearer plugin on MacOS
...
Fixes #2944 , #2237
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-03-29 13:46:07 +00:00
allexzander
28771b25e3
Fix VFS CfAPI Syncroot Register Error.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-03-27 02:41:24 +02:00
allexzander
ab128cc4aa
Revert "Merge pull request #3042 from nextcloud/temp-fix-vfs-failure-wow6432"
...
This reverts commit cafa475398
, reversing
changes made to 003e56f4e6
.
2021-03-26 22:25:31 +02:00
allexzander
9d15334813
Temp fix for vfs failure.
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-03-26 21:41:44 +02:00
Camila
9219926a74
Add checks in case userStatus is not available/fails on the server side.
...
Signed-off-by: Camila <hello@camila.codes>
2021-03-24 15:42:26 +01:00
Camila
d9a0778e52
Add UserStatus enum with the pre defined status.
...
- User QHash to map status strings and Status enum.
Signed-off-by: Camila <hello@camila.codes>
2021-03-24 15:41:31 +01:00
Camila
974e2fb718
Do not display notifications when user status is do not disturb.
...
- This information is retrieved from the notifications endpoint.
- Add icons for the different pre defined status.
- Make functions available to QML to decide which status icon to display.
- Display the user status icon on the avatar and
move the online/offline connection status to the folder icon.
Signed-off-by: Camila <hello@camila.codes>
2021-03-24 15:40:05 +01:00
Camila
f4d8699db8
Add UserStatus class to retrieve the user status.
...
- AccountState controls UserStatus.
- Display user status in the system tray menu next to user's avatar.
Signed-off-by: Camila <hello@camila.codes>
2021-03-24 15:39:13 +01:00
Valdnet
519dee9104
l10n: Change sync message #3027
2021-03-24 13:13:40 +00:00
allexzander
193e50311b
Refresh Windows download dialog progress when hydrating a placeholder
...
Signed-off-by: allexzander <blackslayer4@gmail.com>
2021-03-24 14:09:06 +02:00
Felix Weilbach
d78774f29e
Check reading from journal was successful before remove placeholder
...
Signed-off-by: Felix Weilbach <felix.weilbach@nextcloud.com>
2021-03-24 10:51:50 +00:00