mirrors/nextcloud-desktop
1
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2024-12-22 21:50:30 +03:00
Code Issues Projects Releases Packages Wiki Activity
18398 commits 486 branches 258 tags 464 MiB
Commit graph

8648 commits

Author SHA1 Message Date
Matthieu Gallien
26fd4d2226 tidy some loop related code: avoid one letter variable names 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-11-18 16:02:21 +01:00
Matthieu Gallien
b5adbf3ab0 fix instances of: c++11 range-loop might detach Qt container warnings 
analyzed via clazy

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-11-18 16:02:21 +01:00
Matthieu Gallien
ad32bc7ce5
remove a few warnings reported by sonarcloud to tidy the code 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-11-18 09:19:03 +01:00
Matthieu Gallien
37c867bf30
tidy code to fix review comments 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-11-18 09:11:41 +01:00
Matthieu Gallien
2742c6a5a1
tidy code by fixing one clazy reported warning 
use QString::arg with multiple parameters because that is faster

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-11-17 14:48:51 +01:00
Matthieu Gallien
9a2f07d53b
fix behavior of folder rename with deep hierarchy inside it 
propagate renaming of parent folders to child recursively

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-11-17 14:47:01 +01:00
Matthieu Gallien
d36b2ee793
improve logging of discovery policy decisions when scanning folders 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-11-17 14:47:00 +01:00
Matthieu Gallien
686f78bebc
improve logging of the discovery policy when scanning a folder 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-11-17 14:47:00 +01:00
Claudio Cambra
58660b82f8 Ensure forcing a folder to be synced unpauses syncing on said folder 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-15 12:32:13 +01:00
Claudio Cambra
e281c46fa5 Fix ActivityList delegate warnings· 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-15 11:51:39 +01:00
Claudio Cambra
561b55800c Remove reference to inexistent property in NCCustomButton 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-15 11:48:24 +01:00
Matthieu Gallien
61c792c6f4
fully qualify types in signals and slots 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-11-15 09:57:54 +01:00
hefee
14292ec867 Fix typo of connector 
Signed-off-by: hefee <hefee@debian.org>
 2022-11-14 09:43:36 +01:00
tnixeu
d0d666d084 exclude kmessagewidget.cpp and wheelhandler.cpp from unity build 
Signed-off-by: tnixeu <4436784+tnixeu@users.noreply.github.com>
 2022-11-14 08:41:47 +01:00
tnixeu
e3adb90d60 skip unity build for files which fail to compile 
Signed-off-by: tnixeu <4436784+tnixeu@users.noreply.github.com>
 2022-11-14 08:41:47 +01:00
tnixeu
0b98f471ed add guards around string constants and into an anonymous namespace 
Signed-off-by: tnixeu <4436784+tnixeu@users.noreply.github.com>
 2022-11-14 08:41:47 +01:00
tnixeu
fa4d73ef06 add #pragma once 
Signed-off-by: tnixeu <4436784+tnixeu@users.noreply.github.com>
 2022-11-14 08:41:47 +01:00
Claudio Cambra
8315770467 Make user status selector modal, show user header 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-09 17:39:28 +01:00
Claudio Cambra
ddc14a844d Remove unused remotePath in User::processCompletedSyncItem 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-09 16:29:21 +01:00
alex-z
4b6ce9f951 Do not use copy-assignment of QDialog. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-11-09 16:01:17 +01:00
Claudio Cambra
31a89c68d7 Fix share delegate button icon colors in dark mode 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-08 17:33:25 +01:00
Claudio Cambra
1a0903f178 Ensure 'Sync now' button doesn't have its text elided 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-08 16:32:04 +01:00
Claudio Cambra
161ed1ec9b Remove unused app pointer in CocoaInitializer 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-08 15:43:25 +01:00
Matthieu Gallien
402d959cae do not skip folder deletion if BlacklistedError during propagation 
in case some propgation actions ends up with a BlacklistedError, we
would skip the deletions of local folders (even though they have been
deleted from server)

let's not skip them but rather keep track of the error status and
properly report them

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-11-07 18:33:13 +01:00
Matthieu Gallien
f8fc720fbb improve logs of E2EE API to not pollute logs 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-11-07 18:33:13 +01:00
Matthieu Gallien
7fe6a3df78 logs from discovery are now namespaced by nextcloud to show debug logs 
use nextcloud namespace for discovery logs as it does not show correcly
without that

this is because we have central rules for all logs from nextcloud
namespace

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-11-07 18:33:13 +01:00
Matthieu Gallien
9a06128eec remove dead code related to item renaming 
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
 2022-11-07 18:33:13 +01:00
alex-z
ba9d3269e3 Use separate variable for cfg file name in CMAKE. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-11-07 11:05:27 +01:00
Claudio Cambra
e45a023961 Remove unused internal link widget from old share dialog 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-11-03 14:03:38 +01:00
allexzander
6cb988b667 Fix accounts avatar issue when it becomes completely white due to non-changing account id member with changing account index in the list. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2022-11-03 10:14:44 +01:00
alex-z
b00007e07d Fix incorrect current user index when removing and adding an account. 
Signed-off-by: alex-z <blackslayer4@gmail.com>
 2022-11-03 10:14:44 +01:00
allexzander
9ab89daedd E2EE. Do not generate keypair without user request. 
Signed-off-by: allexzander <blackslayer4@gmail.com>
 2022-11-01 09:18:28 +01:00
Claudio Cambra
d79312b2f7
Change liveDialog to nullDialog 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:13 +01:00
Claudio Cambra
7f9a85a3d0
Update Kirigami WheelHandler to upstream v5.99.0 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:13 +01:00
Claudio Cambra
7ba6969e65
Moved all server mocking code for share model test to independent ShareTestUtils file 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:10 +01:00
Claudio Cambra
e021f25634
Add a suite of tests for ShareModel 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Test ShareModel error handling

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Improve testing of user/group shares in ShareModel

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add testing for maximum share expire date enforcement in ShareModel

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:09 +01:00
Claudio Cambra
77fb0c4808
Filter out sharees that already have active shares 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:09 +01:00
Claudio Cambra
0826e8d6ba
Improve server error handling in the ShareModel 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:09 +01:00
Claudio Cambra
c707dd0ccc
Check for state of file record retrieval in fileactivitylistmodel 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:09 +01:00
Claudio Cambra
79c0f3464a
Fix default date parser handling of timezones 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:09 +01:00
Claudio Cambra
ff4a4c63a1
Renamed _userStoppedTypingTimer to searchRateLimitingTimer 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:09 +01:00
Claudio Cambra
ce53c8439f
Add trailing comma to shareemodel enum 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:08 +01:00
Claudio Cambra
639fb21a13
Replace manual index bound checks with calls to checkIndex 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:08 +01:00
Claudio Cambra
fb4bb95b91
Perform inactive qquickwindow garbage collection when generating new file detail dialogs, raise existing dialog instead of always deleting 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:08 +01:00
Claudio Cambra
d2552ba439
Use auto where possible 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:08 +01:00
Claudio Cambra
b7d96781de
Add minimum size to file details window 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:08 +01:00
Claudio Cambra
121ab38177
Remove default cases in switches, rely on compiler warnings for missed cases 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:08 +01:00
Claudio Cambra
31afb02c84
Eliminate unneeded parent Item in FileActivityView 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:08 +01:00
Claudio Cambra
0ca927843f
Add early return checks for setter methods 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:08 +01:00
Claudio Cambra
685a0362fc
Refactor generation of dialogs, remove need for QSharedPointer and reduce use of pointers 
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
 2022-10-31 18:06:07 +01:00