Commit graph

18398 commits

Author SHA1 Message Date
Matthieu Gallien
26fd4d2226 tidy some loop related code: avoid one letter variable names
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-18 16:02:21 +01:00
Matthieu Gallien
b5adbf3ab0 fix instances of: c++11 range-loop might detach Qt container warnings
analyzed via clazy

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-18 16:02:21 +01:00
Matthieu Gallien
4135b757b9
Merge pull request #5182 from nextcloud/bugfix/fixRenameDeepHierarchy
fix renaming of folders with a deep hierarchy inside them
2022-11-18 11:43:02 +01:00
Matthieu Gallien
ad32bc7ce5
remove a few warnings reported by sonarcloud to tidy the code
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-18 09:19:03 +01:00
Matthieu Gallien
37c867bf30
tidy code to fix review comments
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-18 09:11:41 +01:00
Matthieu Gallien
2742c6a5a1
tidy code by fixing one clazy reported warning
use QString::arg with multiple parameters because that is faster

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-17 14:48:51 +01:00
Matthieu Gallien
9a2f07d53b
fix behavior of folder rename with deep hierarchy inside it
propagate renaming of parent folders to child recursively

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-17 14:47:01 +01:00
Matthieu Gallien
8fa727e299
test for proper renaming of folder parent of a deep hierarchy
currently broken test as we miss to rename recursively

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-17 14:47:01 +01:00
Matthieu Gallien
d36b2ee793
improve logging of discovery policy decisions when scanning folders
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-17 14:47:00 +01:00
Matthieu Gallien
686f78bebc
improve logging of the discovery policy when scanning a folder
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-17 14:47:00 +01:00
Nextcloud bot
01f8003413
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-17 03:28:03 +00:00
Matthieu Gallien
131938f037
Merge pull request #5178 from nextcloud/ci/followUpstreamCraft
switch back to upstream craft
2022-11-15 18:33:08 +01:00
Matthieu Gallien
23b8da319f
no need to install python that is already installed
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-15 15:15:14 +01:00
Matthieu Gallien
86e06a2ae2
switch back to upstream craft
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-15 14:03:48 +01:00
Claudio Cambra
65e0b9ea2f
Merge pull request #5152 from nextcloud/bugfix/sync-now-paused-folder
Ensure forcing a folder to be synced unpauses syncing on said folder
2022-11-15 12:57:16 +01:00
Claudio Cambra
58660b82f8 Ensure forcing a folder to be synced unpauses syncing on said folder
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-11-15 12:32:13 +01:00
Claudio Cambra
d5af4bc7c6
Merge pull request #5172 from nextcloud/bugfix/fix-activitylist-warnings
Fix ActivityList delegate warnings
2022-11-15 11:52:12 +01:00
Claudio Cambra
e281c46fa5 Fix ActivityList delegate warnings·
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-11-15 11:51:39 +01:00
Claudio Cambra
a437a99204
Merge pull request #5173 from nextcloud/bugfix/nccustombutton-warnings
Remove reference to inexistent property in NCCustomButton
2022-11-15 11:51:23 +01:00
Claudio Cambra
561b55800c Remove reference to inexistent property in NCCustomButton
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-11-15 11:48:24 +01:00
Matthieu Gallien
adb91765a6
Merge pull request #5088 from nextcloud/ci/clazyNotFullyQualifiedTypes
fully qualify types in signals and slots
2022-11-15 11:02:00 +01:00
Matthieu Gallien
61c792c6f4
fully qualify types in signals and slots
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-15 09:57:54 +01:00
Nextcloud bot
401a7778bb
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-15 03:26:34 +00:00
Nextcloud bot
075b6812e3
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-14 10:47:30 +00:00
Matthieu Gallien
b920b1cdc5
Merge pull request #5157 from nextcloud/hefee-patch-1
Fix typo of connector
2022-11-14 09:43:46 +01:00
hefee
14292ec867 Fix typo of connector
Signed-off-by: hefee <hefee@debian.org>
2022-11-14 09:43:36 +01:00
Matthieu Gallien
81f6844393
Merge pull request #5109 from tnixeu/prepare_cmake_unity_build
Add support cmake unity build
2022-11-14 09:42:59 +01:00
tnixeu
5eadb269a6 enable unity build for appimage
Signed-off-by: tnixeu <4436784+tnixeu@users.noreply.github.com>
2022-11-14 08:41:47 +01:00
tnixeu
d0d666d084 exclude kmessagewidget.cpp and wheelhandler.cpp from unity build
Signed-off-by: tnixeu <4436784+tnixeu@users.noreply.github.com>
2022-11-14 08:41:47 +01:00
tnixeu
e3adb90d60 skip unity build for files which fail to compile
Signed-off-by: tnixeu <4436784+tnixeu@users.noreply.github.com>
2022-11-14 08:41:47 +01:00
tnixeu
0b98f471ed add guards around string constants and into an anonymous namespace
Signed-off-by: tnixeu <4436784+tnixeu@users.noreply.github.com>
2022-11-14 08:41:47 +01:00
tnixeu
fa4d73ef06 add #pragma once
Signed-off-by: tnixeu <4436784+tnixeu@users.noreply.github.com>
2022-11-14 08:41:47 +01:00
Nextcloud bot
26d7d2796c
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-14 03:24:00 +00:00
Nextcloud bot
d9c1698e13
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-13 03:22:20 +00:00
Nextcloud bot
0fe476e72c
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-12 03:25:37 +00:00
Nextcloud bot
fd561d7d61
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-10 03:30:19 +00:00
Matthieu Gallien
83c3746857
Merge pull request #5151 from nextcloud/ci/fixOneTestOnWindows
properly escape a path when creating a test file during tests
2022-11-09 22:49:32 +01:00
Matthieu Gallien
7dfb27f799 do not run tests in parallel as we may get side effects
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-09 18:35:10 +01:00
Matthieu Gallien
d70d4f61ec properly escape a path when creating a test file during tests
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-09 18:35:10 +01:00
Claudio Cambra
de7976eb83
Merge pull request #5145 from nextcloud/feature/userstatusselector-modal
Make user status selector modal, show user header
2022-11-09 18:16:21 +01:00
Claudio Cambra
8315770467 Make user status selector modal, show user header
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-11-09 17:39:28 +01:00
Claudio Cambra
136bbd14b3
Merge pull request #5118 from nextcloud/bugfix/remove-unused-var-user
Remove unused remotePath in User::processCompletedSyncItem
2022-11-09 17:08:12 +01:00
Claudio Cambra
ddc14a844d Remove unused remotePath in User::processCompletedSyncItem
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-11-09 16:29:21 +01:00
allexzander
16f6a7e479
Merge pull request #5148 from nextcloud/bugfix/qdialig-do-not-use-copy-assignment
Do not use copy-assignment of QDialog.
2022-11-09 16:06:08 +01:00
alex-z
4b6ce9f951 Do not use copy-assignment of QDialog.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-11-09 16:01:17 +01:00
Nextcloud bot
ae6cd7ca27
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-09 03:20:17 +00:00
Claudio Cambra
957caef67b
Merge pull request #5132 from nextcloud/bugfix/dark-mode-share-delegate-buttons
Fix share delegate button icon colors in dark mode
2022-11-08 18:17:29 +01:00
Claudio Cambra
31a89c68d7 Fix share delegate button icon colors in dark mode
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-11-08 17:33:25 +01:00
Claudio Cambra
2c1ef6e4a8
Merge pull request #5129 from nextcloud/bugfix/sync-now-button-elide
Ensure 'Sync now' button doesn't have its text elided
2022-11-08 17:33:10 +01:00
Claudio Cambra
1a0903f178 Ensure 'Sync now' button doesn't have its text elided
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-11-08 16:32:04 +01:00