Commit graph

18498 commits

Author SHA1 Message Date
Claudio Cambra
4c32d54dfb
Merge pull request #5127 from nextcloud/bugfix/remove-unused-app-ptr
Remove unused app pointer in CocoaInitializer
2022-11-08 16:31:31 +01:00
Claudio Cambra
161ed1ec9b Remove unused app pointer in CocoaInitializer
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-11-08 15:43:25 +01:00
Nextcloud bot
1c11701826
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-08 03:21:23 +00:00
Matthieu Gallien
b02f112366
Merge pull request #5104 from nextcloud/bugfix/doNotDeleteFilesInSyncDatabase
Bugfix/delete folders during propagation even when propagation has errors
2022-11-07 23:41:59 +01:00
Matthieu Gallien
402d959cae do not skip folder deletion if BlacklistedError during propagation
in case some propgation actions ends up with a BlacklistedError, we
would skip the deletions of local folders (even though they have been
deleted from server)

let's not skip them but rather keep track of the error status and
properly report them

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-07 18:33:13 +01:00
Matthieu Gallien
783cefe3f1 new autotest to ensure that we delete folders despite blacklist errors
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-07 18:33:13 +01:00
Matthieu Gallien
f8fc720fbb improve logs of E2EE API to not pollute logs
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-07 18:33:13 +01:00
Matthieu Gallien
7fe6a3df78 logs from discovery are now namespaced by nextcloud to show debug logs
use nextcloud namespace for discovery logs as it does not show correcly
without that

this is because we have central rules for all logs from nextcloud
namespace

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-07 18:33:13 +01:00
Matthieu Gallien
9a06128eec remove dead code related to item renaming
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2022-11-07 18:33:13 +01:00
allexzander
ad8933304b
Merge pull request #5136 from nextcloud/feature/config-name-in-cmake
Use separate variable for cfg file name in CMAKE.
2022-11-07 15:13:50 +01:00
alex-z
ba9d3269e3 Use separate variable for cfg file name in CMAKE.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-11-07 11:05:27 +01:00
Nextcloud bot
a5e4d97593
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-07 03:20:00 +00:00
Nextcloud bot
9e7a79fdf6
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-06 03:21:51 +00:00
Nextcloud bot
6e6c76971c
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-05 03:25:03 +00:00
Nextcloud bot
938a2d686b
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-04 13:34:48 +00:00
alex-z
7e95f5306b Revert "[tx-robot] updated from transifex"
This reverts commit 89c68c48dc.
2022-11-04 12:05:11 +01:00
Nextcloud bot
89c68c48dc
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-04 03:20:29 +00:00
Claudio Cambra
b11a51dff9
Merge pull request #5123 from nextcloud/bugfix/remove-unused-internal-link-widget
Remove unused internal link widget from old share dialog
2022-11-03 15:16:34 +01:00
Claudio Cambra
e45a023961 Remove unused internal link widget from old share dialog
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-11-03 14:03:38 +01:00
allexzander
34a59fbb45
Merge pull request #5092 from nextcloud/bugfix/incorrect-currentuserid
Fix incorrect current user index when adding or removing a user account. Also fix incorrect user avatar lookup by id.
2022-11-03 14:00:50 +01:00
allexzander
6cb988b667 Fix accounts avatar issue when it becomes completely white due to non-changing account id member with changing account index in the list.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2022-11-03 10:14:44 +01:00
alex-z
b00007e07d Fix incorrect current user index when removing and adding an account.
Signed-off-by: alex-z <blackslayer4@gmail.com>
2022-11-03 10:14:44 +01:00
Nextcloud bot
ca15f308e6
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-03 03:19:28 +00:00
Nextcloud bot
35842654d5
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-02 03:21:25 +00:00
allexzander
3755914a95
Merge pull request #5067 from nextcloud/bugfix/e2e-do-not-generate-keys-without-request
E2EE. Do not generate keypair without user request.
2022-11-01 10:41:00 +01:00
allexzander
9ab89daedd E2EE. Do not generate keypair without user request.
Signed-off-by: allexzander <blackslayer4@gmail.com>
2022-11-01 09:18:28 +01:00
Nextcloud bot
2839c95887
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-11-01 03:20:33 +00:00
Claudio Cambra
038048a64d
Merge pull request #4929 from nextcloud/feature/qml-file-details
Add a new file details window, unify file activity and sharing
2022-10-31 18:41:51 +01:00
Claudio Cambra
d79312b2f7
Change liveDialog to nullDialog
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:13 +01:00
Claudio Cambra
7f9a85a3d0
Update Kirigami WheelHandler to upstream v5.99.0
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:13 +01:00
Claudio Cambra
63354f8432
Add testing for SortedShareModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:13 +01:00
Claudio Cambra
7ba6969e65
Moved all server mocking code for share model test to independent ShareTestUtils file
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:10 +01:00
Claudio Cambra
a0ff46a7fb
Add testing for ShareeModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:09 +01:00
Claudio Cambra
e021f25634
Add a suite of tests for ShareModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Test ShareModel error handling

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Improve testing of user/group shares in ShareModel

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>

Add testing for maximum share expire date enforcement in ShareModel

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:09 +01:00
Claudio Cambra
77fb0c4808
Filter out sharees that already have active shares
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:09 +01:00
Claudio Cambra
0826e8d6ba
Improve server error handling in the ShareModel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:09 +01:00
Claudio Cambra
c707dd0ccc
Check for state of file record retrieval in fileactivitylistmodel
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:09 +01:00
Claudio Cambra
79c0f3464a
Fix default date parser handling of timezones
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:09 +01:00
Claudio Cambra
ff4a4c63a1
Renamed _userStoppedTypingTimer to searchRateLimitingTimer
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:09 +01:00
Claudio Cambra
ce53c8439f
Add trailing comma to shareemodel enum
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:08 +01:00
Claudio Cambra
639fb21a13
Replace manual index bound checks with calls to checkIndex
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:08 +01:00
Claudio Cambra
fb4bb95b91
Perform inactive qquickwindow garbage collection when generating new file detail dialogs, raise existing dialog instead of always deleting
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:08 +01:00
Claudio Cambra
d2552ba439
Use auto where possible
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:08 +01:00
Claudio Cambra
b7d96781de
Add minimum size to file details window
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:08 +01:00
Claudio Cambra
121ab38177
Remove default cases in switches, rely on compiler warnings for missed cases
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:08 +01:00
Claudio Cambra
31afb02c84
Eliminate unneeded parent Item in FileActivityView
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:08 +01:00
Claudio Cambra
0ca927843f
Add early return checks for setter methods
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:08 +01:00
Claudio Cambra
685a0362fc
Refactor generation of dialogs, remove need for QSharedPointer and reduce use of pointers
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:07 +01:00
Claudio Cambra
f97f39375b
Remove Q_REQUIRED_RESULT from method with side-effect where result not always required, and viceversa
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:07 +01:00
Claudio Cambra
de0831c297
Use [[nodiscard]] more broadly in methods returning values, and respect it elsewhere
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2022-10-31 18:06:07 +01:00