Commit graph

21958 commits

Author SHA1 Message Date
Claudio Cambra
02f9acb2ca Encourage use of https in error message for cmd.cpp
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-11 21:29:18 +08:00
Claudio Cambra
35a4e7f086 Remove unused <random> import in cmd.cpp
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-11 21:29:18 +08:00
Claudio Cambra
e05ab4116d
Merge pull request #7302 from nextcloud/backport/7240/stable-3.14
[stable-3.14] Fix authentication issues for macOS File Provider Extension
2024-10-11 21:29:03 +08:00
Claudio Cambra
5eceb725c8 Stop fetching user profile details now that is not necessary in file provider extension
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-11 09:03:16 +00:00
Claudio Cambra
49f7b06261 Handle userId correctly in File Provider Extension client interface
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-11 09:03:16 +00:00
Claudio Cambra
5b472a238c Properly provide both user-provided username AND backing user ID to File Provider Extension
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-11 09:03:16 +00:00
Claudio Cambra
94b84a5c46 Fetch user profile (and user ID) when setting up domain account
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-11 09:03:16 +00:00
Claudio Cambra
47bb200fb7 Wait for task to complete synchronously after setting up domain account rather than wrapping everything in task
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-11 09:03:16 +00:00
Claudio Cambra
35073e61f8 Retry authentication if connection timed out
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-11 09:03:16 +00:00
Claudio Cambra
e7e958ed82 Try to authenticate new account details before setting them
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-11 09:03:16 +00:00
Matthieu Gallien
5c34390478
Merge pull request #7295 from nextcloud/backport/7290/stable-3.14
[stable-3.14] Cleaning logs
2024-10-10 16:10:38 +02:00
Matthieu Gallien
f3e3a581f2 remove info level output from activity list model: not so usefull
they just are printed when everything is working fine

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-10 13:11:55 +00:00
Matthieu Gallien
72480f61d5 remove not so usefull log output
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-10 13:11:55 +00:00
Matthieu Gallien
629cbf47fb
Merge pull request #7292 from nextcloud/backport/7289/stable-3.14
[stable-3.14] remove extra argument from QString::arg: string has only 1 placeholder
2024-10-10 15:08:21 +02:00
Matthieu Gallien
b5d4c976fa remove extra argument from QString::arg: string has only 1 placeholder
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-10 12:35:22 +00:00
Matthieu Gallien
86d7d2f44c
Merge pull request #7283 from nextcloud/backport/7282/stable-3.14
[stable-3.14] properly catch std::filesystem exceptions
2024-10-08 14:36:46 +02:00
Matthieu Gallien
afa176c069 properly catch std::filesystem exceptions
will prevent std::terminate from being called with uncatched exceptions

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-08 11:47:58 +00:00
Camila Ayres
fd18abc984
Merge pull request #7276 from nextcloud/backport/7163/stable-3.14
[stable-3.14] Add support for the new craft blueprint options relating to override server urls
2024-10-07 16:14:22 +02:00
Claudio Cambra
a8a6c85098 Add support for the new craft blueprint options relating to override server urls
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-10-07 16:13:58 +02:00
Matthieu Gallien
08b07405bc
Merge pull request #7275 from nextcloud/backport/7270/stable-3.14
[stable-3.14] Bugfix/use qml fusion on windows
2024-10-07 16:09:33 +02:00
Matthieu Gallien
7e729241c3 remove hard coded white color in elements of folder wizard
fix broken white backgrounds in folder wizard when using Windows dark
mode

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-07 16:09:24 +02:00
Matthieu Gallien
0d3aee7aad switch folder wizar to modern style to avoid borken windows dark mode
the QWizard AeroStyle style is broken on windows dark mode, switch to
ModernStyle that is working fine

see upstream Qt bug: https://bugreports.qt.io/browse/QTBUG-123853

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-07 16:09:24 +02:00
Matthieu Gallien
513a4bf46e qml Windows native style is broken on dark mode: switch to Fusion
we will temporarily be using Fusion generic desktop style

Close https://github.com/nextcloud/desktop/issues/7215

see upstream Qt bug
https://bugreports.qt.io/browse/QTBUG-113469?focusedId=724929&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-724929

they apparently do not plan to fix Windows qml style to support dark
mode on Windows 11

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-07 16:09:24 +02:00
Matthieu Gallien
c49669f9d7
Merge pull request #7272 from nextcloud/backport/7263/stable-3.14
[stable-3.14] remove too verbose logs during discovery
2024-10-07 16:08:47 +02:00
Matthieu Gallien
b91c696dc9 downgrade severity level of logs during propagation
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-07 12:27:31 +00:00
Matthieu Gallien
e97e03d5e6 remove internal logs in propagation scheduler: not usefull
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-07 12:27:31 +00:00
Matthieu Gallien
7395a3f72d remove too verbose not so usefull logs
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-07 12:27:31 +00:00
Matthieu Gallien
b1b87134c0 remove useless internal log about remote permissions management
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-07 12:27:31 +00:00
Matthieu Gallien
31657804f4 remove too verbose logs during discovery
will make the logs less verbose and improve performance

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-07 12:27:31 +00:00
Matthieu Gallien
825727f72f
Merge pull request #7267 from nextcloud/backport/7259/stable-3.14
[stable-3.14] Bugfix/fix log issues
2024-10-07 14:25:12 +02:00
Matthieu Gallien
337e4a3c0e improve debugger logs on Windows to have same content than normal log
makes debugger logs more usefull

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-04 10:03:12 +00:00
Matthieu Gallien
5e251e696f enable dev logs only when NEXTCLOUD_DEV is defined to value 1
will switch back production logs to the intended behavior

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-10-04 10:03:12 +00:00
Matthieu Gallien
ed0995d54f
fix visibility of dismiss button
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-30 13:20:30 +02:00
Claudio Cambra
05b286d0c0
Merge pull request #7239 from nextcloud/backport/7232/stable-3.14
[stable-3.14] Fix QtWebEngineProcess crash on macOS when building with mac-crafter
2024-09-30 16:28:03 +08:00
Claudio Cambra
e5bb65759b Codesign webengineprocess with correct entitlements on macOS with mac crafter
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
2024-09-30 07:28:57 +00:00
Matthieu Gallien
2a4aa48bab
prepare for release 3.14.1
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-27 10:30:33 +02:00
Matthieu Gallien
096f5f199d
Merge pull request #7224 from nextcloud/backport/6871/stable-3.14
[stable-3.14] Only check for leading/trailing space for files on Windows.
2024-09-27 09:27:03 +02:00
Camila Ayres
f5f971d2b8 Use preprocessor directives in tests.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-27 07:26:21 +00:00
Camila Ayres
75896f5bb8 Fix tests for trailing spaces on Linux.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-27 07:26:21 +00:00
Camila Ayres
cfb39b7034 Add test testCreateLocalPathsWithLeadingAndTrailingSpaces_syncOnSupportingOs.
- Fix discovery tests for files with invalid names.
- Now leading/trailing spaces trigger an error only on Windows.

Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-27 07:26:21 +00:00
Camila Ayres
c6bc7e630d Only check leading/trailing spaces for files on Windows.
Fix for #6807.

Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-27 07:26:21 +00:00
Matthieu Gallien
4db6cf0b10
Merge pull request #7218 from nextcloud/backport/7200/stable-3.14
[stable-3.14] disable our code for network timeout
2024-09-26 18:12:43 +02:00
Matthieu Gallien
14aef728b4 disable our code for network timeout
seems we have an issue with Windows and QTimer instances used to detect
network timeout

workaround, find cause of https://github.com/nextcloud/desktop/issues/7184

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-26 14:14:53 +00:00
Matthieu Gallien
abbbc29e5f
Merge pull request #7217 from nextcloud/backport/7142/stable-3.14
[stable-3.14] Fix alignment and size of buttons.
2024-09-26 16:11:09 +02:00
Camila Ayres
4669c8b5ea Fix alignment and size of buttons.
Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-26 10:02:42 +00:00
Matthieu Gallien
e843fa44d3
Merge pull request #7213 from nextcloud/backport/7208/stable-3.14
[stable-3.14] Bugfix/missing unlock command
2024-09-26 12:00:50 +02:00
Matthieu Gallien
d011a0f93a lock token should be sent via webdav only for token lock type
to be able to modify a locked file using token lock, we must sent it
with webdav requests

this must not be sent if the file is locked but the lock type is not a
token lock

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-26 08:56:47 +00:00
Matthieu Gallien
59568ad29d clarify when desktop client should offer to unlock a file
a file can be unlocked when:

 * the lock is an user lock from the current user
 * the lock is a token lock from the current desktop files client

Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
2024-09-26 08:56:47 +00:00
Matthieu Gallien
2ffbc6a1a3
Merge pull request #7207 from nextcloud/backport/7167/stable-3.14
[stable-3.14] Use version of linuxdeploy-plugin-qt from PR in the project.
2024-09-25 18:43:43 +02:00
Camila Ayres
f965c7cffe Use version of linuxdeploy-plugin-qt from PR in the project.
Fix for #7128.

See https://github.com/linuxdeploy/linuxdeploy-plugin-qt/pull/186.

Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-25 17:53:40 +02:00