mirrors/nextcloud-desktop
1
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2024-11-23 21:46:03 +03:00
Code Issues Projects Releases Packages Wiki Activity
14878 commits 473 branches 255 tags 510 MiB
Commit graph

14878 commits

This branch
This branch
All branches
Author SHA1 Message Date
Michael Schuster
bd519ffe7a
Adapt code style in addition to #2300 
- Use "!empty()" instead of "size() > 0" in std::list
- Add comments for namespace brackets

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-27 01:31:06 +02:00
Michael Schuster
e973c43a7a
Merge pull request #2300 from chenecharry/master 
Support client builds on VS2019 (QLinkedList is deprecated)
 2020-08-27 01:27:09 +02:00
Michael Schuster
24a2b21c2c
Merge branch 'master' into master 2020-08-27 01:12:30 +02:00
Nextcloud bot
07bde18c3a
[tx-robot] updated from transifex 2020-08-26 03:29:53 +00:00
V.C
b20ea25201 Code review changes implemented 
Code review changes implemented for bandwidthmanager.cpp
1. Use auto instead of size_t
2. Check for empty instead of size comparisions

Signed-off-by: V.C <c******@rediffmail.com>
 2020-08-26 02:45:20 +00:00
V.C
af1bb7e98c Support client builds on VS2019 
Scenario: Build fails on Qt 5.15.0 + VS2019 16.7.2
Root cause: QLinkedList seems to be depreciated. Advise to use std::list instead.
Fix: Used std::list insead of QLinkedList.

Signed-off-by: V.C <c******@rediffmail.com>
 2020-08-26 02:45:20 +00:00
Michael Schuster
c1cb3e6c49
Merge pull request #2309 from nextcloud/update-docs-page-title 
Update copyright date and version displayed in the page title.
 2020-08-25 21:07:18 +02:00
Camila
cbea02390e Update copyright date and version displayed in the page title. 
- This is the title displayed at https://docs.nextcloud.com/desktop/x.y

Signed-off-by: Camila <hello@camila.codes>
 2020-08-25 18:50:14 +00:00
Michael Schuster
c4b87cd465
Merge pull request #2313 from nextcloud/update-issue-template 
Add --logdebug parameter to instructions in issue_template for Github.
 2020-08-25 20:48:59 +02:00
Camila
c746e65a8e Update issue_template with information about logs, e2ee versions and code of conduct. 
Signed-off-by: Camila <hello@camila.codes>
 2020-08-25 15:11:34 +00:00
Camila
6c36041829 Add --logdebug parameter to instructions in issue_template for Github. 
Signed-off-by: Camila <hello@camila.codes>
 2020-08-25 15:11:34 +00:00
Nextcloud bot
c687fb0291
[tx-robot] updated from transifex 2020-08-25 03:32:20 +00:00
Nextcloud bot
d4183aebb3
[tx-robot] updated from transifex 2020-08-24 03:31:03 +00:00
Nextcloud bot
7af6e18491
[tx-robot] updated from transifex 2020-08-22 03:28:48 +00:00
Michael Schuster
5b8ec5cede
Merge pull request #2302 from ivaradi/no-eoan 
Do not build for Eoan
 2020-08-22 00:55:31 +02:00
István Váradi
cd303e313d Do not build for Eoan 
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu>
 2020-08-21 18:54:56 +02:00
Nextcloud bot
32880507b2
[tx-robot] updated from transifex 2020-08-21 03:30:20 +00:00
Michael Schuster
b60239c29e
Merge pull request #2288 from nextcloud/enh/windows-shellext 
Windows shell extensions: Use custom GUIDs and prepare for MSI
 2020-08-20 21:11:34 +02:00
Michael Schuster
4df8db4ff6
Fix spacing 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Michael Schuster
db05f65e0d
Windows shell extensions: Add WiX (MSI) fragment 
Use CMake to generate a WXI fragment to handle the DLL registration and file deployment for the shellext components.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Michael Schuster
11632da7ea
Windows shell extensions: Change NCUtil Pipe name from ownCloud to APPLICATION_EXECUTABLE 
Avoid interference with foreign pipes as this is always a bad idea ;p

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Michael Schuster
0ba5df597f
Windows shell extensions: Rename all files and classes from OC* to NC*, update version info 
This also ensures a clear separation in the system registry.

SelfReg is not recommended by Microsoft and will be handled by the MSI package to allow proper Repair and Uninstall.
However, we keep it for backward compatibility with the NSIS installer.

For details see:
https://stackoverflow.com/questions/364187/how-do-you-register-a-win32-com-dll-file-in-wix-3#364210
https://docs.microsoft.com/en-us/windows/win32/msi/selfreg-table#remarks

Another fix by this commit:
The "Version" registry value in the NCOverlays self reg should be a key and not a value.

Details: https://wixtoolset.org/documentation/manual/v3/xsd/wix/class.html

Example:

  [HKCR\CLSID\{01234567-89AB-CDEF-0123-456789ABCDEF}\Version]
  @="1.0.0.0"

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Michael Schuster
8ce13b7bdb
Windows shell extensions: Use custom GUIDs via CMake and prepare MSI reg 
Previously side by side installation with ownCloud or other NC custom builds would break the shell integration because the same GUIDs and registry keys were used.

Now we specify our custom GUIDs in NEXTCLOUD.cmake and use CMake to generate a header file and WiX (MSI) include file with these constants.

Note: Using generators like "guidgen" or "uuidgen" ensures that GUIDs are unique, as manual changes are not guaranteed to be.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Hannah von Reth
4675869fb3
Remove dead code 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Hannah von Reth
bfd7707ff4
2.7 has less automatic includes on Windows 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Hannah von Reth
34e9e2f288
Cleanup Windows shell extensions 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Hannah von Reth
6c9a31f6ee
Remove outdated visual studio projects, we now use cmake 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Dominik Schmidt
13d4b91935
Avoid warning because /MT overrides /MD flag 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Dominik Schmidt
e4b53b12e1
Make OCUtil helper lib static and link it statically against crt 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Olivier Goffart
906556640d
Windows Shell Integration: Don't limit the size of the buffer 
Otherwise we can't have operation that has many many filename

As reported in #6780

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Christian Kamm
77cc262337
Windows shellext: Update copyrights and company name 
Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Olivier Goffart
6274462036
windows shell extension: add OCUtil/resource.h 
It's a copy from OCContextMenu/resources.h

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Christian Kamm
c6fc46aa09
Windows shellext: Add rc for OCUtil #6554 
To set the dll's metadata.

Signed-off-by: Michael Schuster <michael@schuster.ms>
 2020-08-20 18:50:05 +02:00
Kevin Ottens
d446431804
Merge pull request #2292 from nextcloud/prevent_sharing_for_e2ee_folders 
Disable context menu actions for E2EE files and folders
 2020-08-20 18:36:37 +02:00
Kevin Ottens
ed5e9de9f6
Present sharing of E2EE files from the main dialog too 
The visibility of the share button for the activity list is tied to the
path role in the ActivityListModel, so make sure we don't return a path
for E2EE files and folders.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-08-20 14:53:14 +02:00
Kevin Ottens
07388e0f22
Disable context menu actions for E2EE files and folders 
Those files and folders are not shareable and the "Edit" or "Open in
browser" actions will lead to showing an error in the web GUI. No need
to lead users there so just disable them.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-08-20 14:13:56 +02:00
Nextcloud bot
b67c61bf4a
[tx-robot] updated from transifex 2020-08-20 03:32:34 +00:00
Nextcloud bot
d6cc9fe829
[tx-robot] updated from transifex 2020-08-19 03:32:55 +00:00
Kevin Ottens
3540f1e460 Show the "Display mnemonic" button only when we know e2e is supported 
Turns out that showing the button straight from the page ctor is a bit
too early. At that point the account might not be connected yet and thus
we wouldn't have proper information. Currently we were displaying that
button all the time, now we wait for the account to be connected to
decide to show it or not.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-08-18 17:41:38 +02:00
Camila
71fbc65eb0 Minor fix in text of warning and debug message. 
Signed-off-by: Camila <hello@camila.codes>
 2020-08-18 14:00:21 +02:00
Kevin Ottens
f6e36523d2 Make sure we don't assert when calling fileStatus 
It happens that sometimes we leak a directory path ending with a slash,
but that violates fileStatus' precondition so let's catch it early and
skip such path.

Of course the right fix would be a larger swipe in the sync engine and
around it to not use naked strings anymore but rely on the typesystem.

Signed-off-by: Kevin Ottens <kevin.ottens@nextcloud.com>
 2020-08-18 13:52:28 +02:00
Nextcloud bot
2456f943af
[tx-robot] updated from transifex 2020-08-18 03:34:45 +00:00
Nextcloud bot
c8b6bc6029
[tx-robot] updated from transifex 2020-08-17 03:28:12 +00:00
Nextcloud bot
60ce985828
[tx-robot] updated from transifex 2020-08-16 03:28:22 +00:00
István Váradi
770e3e7b85
Merge pull request #2271 from ivaradi/cstdint-fix 
Include cstdint only when compiling C++ code
 2020-08-15 14:35:01 +02:00
István Váradi
387df7ae71
Merge branch 'master' into cstdint-fix 2020-08-15 12:56:13 +02:00
Nextcloud bot
2e69680812
[tx-robot] updated from transifex 2020-08-15 03:29:02 +00:00
István Váradi
89d4b6e12a Include cstdint only when compiling C++ code 
Signed-off-by: István Váradi <ivaradi@varadiistvan.hu>
 2020-08-14 06:15:42 +02:00
Nextcloud bot
74c1710ed4
[tx-robot] updated from transifex 2020-08-14 03:44:39 +00:00
Kevin Ottens
4117ac2913
Merge pull request #2268 from nextcloud/cherry_pick_testchunkingng_related_improvements 
Cherry pick TestChunkingNG related improvements
 2020-08-13 17:26:33 +02:00