mirrors/nextcloud-desktop
1
0
Fork 0
mirror of https://github.com/nextcloud/desktop.git synced 2024-12-17 19:31:48 +03:00
Code Issues Projects Releases Packages Wiki Activity

remove some FIXME

Browse source
This commit is contained in:
Olivier Goffart 2013-05-07 17:16:11 +02:00
parent 685bf395be
commit 7cd12e7dc5
1 changed files with 3 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/mirall/owncloudpropagator.cpp
View file

@ -58,7 +58,8 @@ csync_instructions_e OwncloudPropagator::propagate(const SyncFileItem &item)
} //fall trough } //fall trough
case CSYNC_INSTRUCTION_SYNC: case CSYNC_INSTRUCTION_SYNC:
if (item._isDirectory) { if (item._isDirectory) {
return CSYNC_INSTRUCTION_UPDATED; //FIXME // Should we set the mtime?
return CSYNC_INSTRUCTION_UPDATED;
} else { } else {
return item._dir == SyncFileItem::Down ? downloadFile(item) : uploadFile(item); return item._dir == SyncFileItem::Down ? downloadFile(item) : uploadFile(item);
} }
@ -136,9 +137,6 @@ csync_instructions_e OwncloudPropagator::localRemove(const SyncFileItem& item)
return CSYNC_INSTRUCTION_DELETED; return CSYNC_INSTRUCTION_DELETED;
_errorString = file.errorString(); _errorString = file.errorString();
} }
//FIXME: we should update the md5
_etag.clear();
//FIXME: we should update the mtime
return CSYNC_INSTRUCTION_NONE; // not ERROR so it is still written to the database return CSYNC_INSTRUCTION_NONE; // not ERROR so it is still written to the database
} }
@ -146,7 +144,7 @@ csync_instructions_e OwncloudPropagator::localMkdir(const SyncFileItem &item)
{ {
QDir d; QDir d;
if (!d.mkpath(_localDir + item._file)) { if (!d.mkpath(_localDir + item._file)) {
//FIXME: errorString _errorString = "could not create directory " + _localDir + item._file;
return CSYNC_INSTRUCTION_ERROR; return CSYNC_INSTRUCTION_ERROR;
} }
return CSYNC_INSTRUCTION_UPDATED; return CSYNC_INSTRUCTION_UPDATED;
@ -194,8 +192,6 @@ csync_instructions_e OwncloudPropagator::uploadFile(const SyncFileItem &item)
} }
QScopedPointer<char, QScopedPointerPodDeleter> uri(ne_path_escape((_remoteDir + item._file).toUtf8())); QScopedPointer<char, QScopedPointerPodDeleter> uri(ne_path_escape((_remoteDir + item._file).toUtf8()));
//TODO: FIXME: check directory
bool finished = true; bool finished = true;
int attempts = 0; int attempts = 0;
/* /*